This revision was automatically updated to reflect the committed changes.
Closed by commit R120:28d86ab43567: optionally show a history of notifications
(authored by progwolff).
CHANGED PRIOR TO COMMIT
https://phabricator.kde.org/D7271?vs=18139=18185#toc
REPOSITORY
R120 Plasma Workspace
progwolff added a comment.
thanks!
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7271
To: progwolff, #plasma, #vdg, davidedmundson
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot, progwolff,
lesliezhai, ali-mohamed,
davidedmundson accepted this revision.
davidedmundson added a comment.
This revision is now accepted and ready to land.
yes
REPOSITORY
R120 Plasma Workspace
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7271
To: progwolff, #plasma, #vdg, davidedmundson
Cc: mart,
progwolff marked 2 inline comments as done.
progwolff added a comment.
so this can be considered accepted?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7271
To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson, plasma-devel, ZrenBot,
progwolff added a comment.
In https://phabricator.kde.org/D7271#135544, @davidedmundson wrote:
> Cool, do you have commit access?
I have commit access, yes
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7271
To: progwolff, #plasma, #vdg
Cc:
progwolff updated this revision to Diff 18139.
progwolff added a comment.
- fix typo
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7271?vs=18135=18139
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7271
AFFECTED FILES
davidedmundson added a comment.
Cool, do you have commit access?
INLINE COMMENTS
> Notifications.qml:92
> +//create a copy of the notification.
> +//Disable actions in this copy as they will stop working once
> the original notification ist closed.
> +
progwolff updated this revision to Diff 18135.
progwolff added a comment.
- simplify object copy
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7271?vs=18134=18135
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7271
AFFECTED
progwolff updated this revision to Diff 18134.
progwolff added a comment.
- use the same delegate for persistent notifications and history items
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7271?vs=18075=18134
BRANCH
master
REVISION DETAIL
mart added inline comments.
INLINE COMMENTS
> progwolff wrote in Notifications.qml:257
> It's almost the same. Only the models differ (NotificationsModel is used in
> NotificationDelegate, NotificationsHistoryModel is used in
> NotificationHistoryDelegate).
>
> I also thought it might be a
davidedmundson added a comment.
@notmart, click the "show older changes" and see reply to my first comment
asking the same thing.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7271
To: progwolff, #plasma, #vdg
Cc: mart, graesslin, davidedmundson,
mart added inline comments.
INLINE COMMENTS
> NotificationHistoryDelegate.qml:27
> +
> +PlasmaComponents.ListItem {
> +id: notificationItem
Why a different delegate for this? all the delegates, persistent or history
should be the same
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
progwolff added a reviewer: VDG.
progwolff added a comment.
In https://phabricator.kde.org/D7271#135079, @graesslin wrote:
> Could you please attach some screenshots and maybe also add the
https://phabricator.kde.org/tag/vdg/ to the review?
F3860046: notifications_screenshot.png
graesslin added a comment.
Could you please attach some screenshots and maybe also add the
https://phabricator.kde.org/tag/vdg/ to the review?
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7271
To: progwolff, #plasma
Cc: graesslin, davidedmundson,
progwolff updated this revision to Diff 18075.
progwolff added a comment.
- show number of active items in compact representation, excluding history
- show heading above history
- don't show actions in history
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
davidedmundson added a comment.
There's a visual quirk I'd like fixing.
Each delegate has a line on the bottom.
However, there's no line between the persistent notifications and the
history, so it looks weird.
Maybe a heading "history" would also work.
Also in your last
progwolff updated this revision to Diff 18051.
progwolff added a comment.
- fix property name
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7271?vs=18050=18051
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D7271
AFFECTED FILES
progwolff updated this revision to Diff 18050.
progwolff added a comment.
- uncomment unintentionally commented line
- rename counters
REPOSITORY
R120 Plasma Workspace
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D7271?vs=18045=18050
BRANCH
master
REVISION DETAIL
progwolff marked 2 inline comments as done.
progwolff added inline comments.
INLINE COMMENTS
> davidedmundson wrote in Notifications.qml:243
> ?
sorry, missed to revert this...
> davidedmundson wrote in Notifications.qml:257
> How does this differ to the persistent delegate?
>
> Can we share
progwolff marked 2 inline comments as done.
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D7271
To: progwolff, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart, lukas
davidedmundson added a comment.
Thanks for looking into this.. first round of comments.
INLINE COMMENTS
> Notifications.qml:243
> }
> -onPopupShown: notificationsRoot.popupShown(popup)
> +//onPopupShown: notificationsRoot.popupShown(popup)
> }
?
>
progwolff created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Bug 378032.
With these changes, notifications can be configured to always persist
in the notifications applet.
Todo: filter by
22 matches
Mail list logo
