D9414: Implement OSD to select action when unknown monitors is connected

acrouthamel added a comment. Could this be implemented for bug 390096 ? Having the display button open this OSD would be an improvement over the current operation, in my opinion. REPOSITORY R104 KScreen REVISION DETAIL

D9414: Implement OSD to select action when unknown monitors is connected

This revision was automatically updated to reflect the committed changes. Closed by commit R104:5feb84305560: Merge branch dvratil/osd (authored by dvratil). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D9414?vs=25635=27873#toc REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

D9414: Implement OSD to select action when unknown monitors is connected

dvratil added a comment. @ngraham Yes, the screenshot is still accurate. If you want a screenshot with more of background or another background, I can provide one. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc:

D9414: Implement OSD to select action when unknown monitors is connected

ngraham added a comment. Is the screenshot in the Summary section still accurate? I'd like to feature this in the coming weekend's Usability & Productivity blog post (assuming it lands today or tomorrow; if not, next week's post), and people love looking at screenshots. REPOSITORY R104

D9414: Implement OSD to select action when unknown monitors is connected

sebas added a comment. When landing, can you merge the whole branch into master, the history here is relevant and it will make continuing work on my kscreen kcm qmlification branch a lot easier. Thanks! REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To:

D9414: Implement OSD to select action when unknown monitors is connected

sebas accepted this revision. This revision is now accepted and ready to land. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: abetts, broulik, kamathraghavendra, graesslin, ngraham, plasma-devel, mlaurent, ZrenBot,

D9414: Implement OSD to select action when unknown monitors is connected

sebas added a comment. In https://phabricator.kde.org/D9414#193341, @dvratil wrote: > Please disregard the noise in this patch, sebas merged master into the dvratil/osd branch so I can't generate a proper diff against the base revision without the noise from master. Sorry for

D9414: Implement OSD to select action when unknown monitors is connected

dvratil updated this revision to Diff 25635. dvratil added a comment. Please disregard the noise in this patch, sebas merged master into the dvratil/osd branch so I can't generate a proper diff against the base revision without the noise from master. REPOSITORY R104 KScreen CHANGES SINCE

D9414: Implement OSD to select action when unknown monitors is connected

dvratil marked 15 inline comments as done. dvratil added inline comments. INLINE COMMENTS > broulik wrote in osdmanager.cpp:60 > Shouldn't it rather do that in the plugin's `registerTypes`? We don't have a QML plugin :( This is the only C++ class that is exposed to the OSD QML. > broulik

D9414: Implement OSD to select action when unknown monitors is connected

broulik added a comment. Cool. INLINE COMMENTS > daemon.cpp:188 > +{ > +self->deleteLater(); > + This makes me uneasy. > daemon.cpp:195 > +case KScreen::OsdAction::SwitchToInternal: > +qCDebug(KSCREEN_KDED) << "OSD: swutch to internal"; > + >

D9414: Implement OSD to select action when unknown monitors is connected

sebas requested changes to this revision. sebas added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > OsdSelector.qml:49 > +iconSource: "osd-shutd-screen", > +label: qsTr("Switch to external screen"), > +

D9414: Implement OSD to select action when unknown monitors is connected

sebas added a comment. I've tested this branch, and it's looking quite good. On X11, it works as expected now after doing a few changes: - The first two icons were mixed up, fix added to dvratil/osd branch - The OSD wouldn't dismiss when the cable got unplugged without selecting an

D9414: Implement OSD to select action when unknown monitors is connected

sebas added a comment. In https://phabricator.kde.org/D9414#192009, @abetts wrote: > Will this OSD need any kind of styling? Or will we just use what was shown above in the screenshot? We're open to mockups, of course. :) REPOSITORY R104 KScreen REVISION DETAIL

D9414: Implement OSD to select action when unknown monitors is connected

abetts added a comment. Will this OSD need any kind of styling? Or will we just use what was shown above in the screenshot? REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: abetts, broulik, kamathraghavendra,

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. I just had a look at all the OSD's used and they all have outputOnly set to true. I have to say the idea here is clearly that OSDs should be non-interactive. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas,

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. In https://phabricator.kde.org/D9414#191973, @broulik wrote: > According to KWin code, windows of type `OnScreenDisplay` do not accept focus and don't take keyboard input but they can still be clicked (unless set to `outputOnly`, obviously). The idea

D9414: Implement OSD to select action when unknown monitors is connected

broulik added a comment. According to KWin code, windows of type `OnScreenDisplay` do not accept focus and don't take keyboard input but they can still be clicked (unless set to `outputOnly`, obviously). REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To:

D9414: Implement OSD to select action when unknown monitors is connected

sebas added a comment. In https://phabricator.kde.org/D9414#191971, @dvratil wrote: > In https://phabricator.kde.org/D9414#191653, @broulik wrote: > > > I think `OnScreenDisplay` implies being non-interactive on Wayland > > > I could interact with the dialog on Wayland, so

D9414: Implement OSD to select action when unknown monitors is connected

dvratil added a comment. In https://phabricator.kde.org/D9414#191653, @broulik wrote: > I think `OnScreenDisplay` implies being non-interactive on Wayland I could interact with the dialog on Wayland, so either it's not implied, or there's a bug in KWin :-) REPOSITORY R104

D9414: Implement OSD to select action when unknown monitors is connected

broulik added a comment. I think `OnScreenDisplay` implies being non-interactive on Wayland REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: broulik, kamathraghavendra, graesslin, ngraham, plasma-devel, mlaurent,

D9414: Implement OSD to select action when unknown monitors is connected

dvratil updated this revision to Diff 25432. dvratil added a comment. Fixes and improvements REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9414?vs=24119=25432 BRANCH dvratil/osd REVISION DETAIL https://phabricator.kde.org/D9414 AFFECTED FILES

D9414: Implement OSD to select action when unknown monitors is connected

dvratil added a comment. In https://phabricator.kde.org/D9414#181150, @graesslin wrote: > How is the interaction supposed to happen? KWin considers OSDs as a non-interactive on screen display (as the name says). Key events are not passed to OSDs and for mouse I'm not sure. This

D9414: Implement OSD to select action when unknown monitors is connected

dvratil edited the summary of this revision. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: kamathraghavendra, graesslin, ngraham, plasma-devel, mlaurent, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. And also please test on Wayland: we have a requirement of new features on Wayland first. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414 To: dvratil, sebas, davidedmundson, #vdg Cc: graesslin, ngraham, plasma-devel, mlaurent,

D9414: Implement OSD to select action when unknown monitors is connected

graesslin added a comment. How is the interaction supposed to happen? KWin considers OSDs as a non-interactive on screen display (as the name says). Key events are not passed to OSDs and for mouse I'm not sure. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D9414

D9414: Implement OSD to select action when unknown monitors is connected

dvratil created this revision. dvratil added reviewers: sebas, davidedmundson, VDG. dvratil added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Building on top of the `sebas/osd` branch, this change introduces a special OSD that appears when a