D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. In D9848#234654 , @anemeth wrote: > > `GLRenderTarget::setTextureDirty` > > I added this because on line (1101 <---> 1124) the `disable()` function that also sets the texture dirty was moved into a condition. > I

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. In D9848#234268 , @zzag wrote: > > `GLRenderTarget::attachTexture` This was not changed. It was used by old blur and simple blur. Looks like it's not used anymore. >

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Why does this patch have non-related changes? E.g. `GLRenderTarget::attachTexture`, `GLRenderTarget::detachTexture`, empty GLRenderTarget constructor, `GLRenderTarget::setTextureDirty`, etc? They aren't

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#196036, @zzag wrote: > File mode bits are slightly off. Fixed in https://phabricator.kde.org/D10100 REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. File mode bits are slightly off. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, fredrik Cc: hein, dos, luebking, broulik, romangg, zzag,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

This revision was automatically updated to reflect the committed changes. Closed by commit R108:0179f741bbd4: Updated the blur method to use the more efficient dual kawase blur algorithm. (authored by anemeth, committed by hein). Restricted Application edited projects, added Plasma; removed KWin.

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25948. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Rebased to master. There was a conflict with https://phabricator.kde.org/D9879 This change reverts those changes since it is superseded by this change

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

hein added a comment. Restricted Application edited projects, added Plasma; removed KWin. @anemeth The patch doesn't apply cleanly to current master. Would you mind rebasing it please? I don't want to introduce errors at this stage by editing code I didn't review. REPOSITORY R108 KWin

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

hein added a comment. Restricted Application edited projects, added KWin; removed Plasma. I'll push this for you (I'm interpreting Martin's resignation as withdrawing objections, knock on wood). REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9848 To:

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, fredrik Cc: dos, luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, fredrik Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik accepted this revision. This revision is now accepted and ready to land. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin BRANCH master REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, fredrik Cc: luebking,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked an inline comment as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25782. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Implemented the change suggested by @fredrik REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25720=25782 BRANCH

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > kwinglutils.cpp:1104 > + > +s_renderTargets.reserve(s_renderTargets.size() + targets.size()); > + The reserve() call should be in the else {} clause. REPOSITORY R108 KWin

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fredrik wrote in blur.cpp:255 > Does calling effects->addRepaintFull() also work? It does. Changed to that. REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25720. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Implemented the changes suggested by @fredrik REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25643=25720 BRANCH

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 3 inline comments as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added a comment. Restricted Application edited projects, added KWin; removed Plasma. I haven't looked at everything in detail, but in general I think this looks ready to land. Just a couple of nitpicks, and a question below. INLINE COMMENTS > anemeth wrote in blur.cpp:145 > Ok

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190176, @graesslin wrote: > I would like to see this reviewed by @fredrik, @mart , @davidedmundson and in general the https://phabricator.kde.org/tag/vdg/

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25643. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Moved a shader variable to a uniform, so that the calculation can be done on the CPU instead. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25638. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Fixed a bug where updating the blur strength would not update the blurred area. With this fix every window gets updated when the blur strength is

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > anemeth wrote in blur.cpp:145 > I checked if I have these extensions. Just to make sure it works I included > another extension I know my card supports. > >

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fredrik wrote in blur.cpp:145 > Okay, I see what you mean. I think this is a trade-off between two > undesirable effects though, because the clamping causes abrupt changes near

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#193152, @davidedmundson wrote: > Changing the blur size at runtime didn't seem to have an effect, it all worked after kwin restart. > Your code looks fine,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Thanks for the patience going through this! Some reviews do go through a lot of iterations, but it's generally worth it. I gave it a quick test. Blur part works nicely. Changing the

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 2 inline comments as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25615. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Updated the blur amount value configuration to use less magically numbers and added an explanation comment. This new method creates an evenly distributed

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 6 inline comments as done. anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > romangg wrote in blur.cpp:152 > I think 5 blur strength steps to select from is fine, if that means we can > get rid off the magic

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25596. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Made the changes that were suggested by @frederik Now only the taskbar doesn't have the extended blur effect. REPOSITORY R108 KWin CHANGES SINCE LAST

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > blur.cpp:30 > #include > +#include > Is this still needed when qPow() is not used? > anemeth wrote in blur.cpp:145 > This texture is only used by

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25551. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. With one of my previous changes I accidentally introduced an extended blur effect. Not it's corrected. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25511. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added the .arcconfig file REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25504=25511 BRANCH master REVISION

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked an inline comment as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25504. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added a new function to GLRenderTarget called `setRenderTargets` With this function I implemented the changes suggested by @fredrik to remove unnecessary

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 13 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: luebking, broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25490. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Added a new constructor to GLRenderTarget Added a new function `detachTexture()` to GLRenderTarget Implemented most of the changes suggested by @fredrik

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > fredrik wrote in blur.cpp:145 > Why is this needed? > > I'm probably missing something here, but it looks to me as if the effect > copies the contents of the framebuffer to the

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

fredrik added a comment. Restricted Application edited projects, added Plasma; removed KWin. Don't forget to add your name to the license headers. INLINE COMMENTS > blur.cpp:46 > m_simpleShader = > ShaderManager::instance()->generateShaderFromResources(ShaderTrait::MapTexture, >

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > fredrik wrote in blur.h:41 > This number could use an explanation. I don't know why it's 5 This was in the old blur too:

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25436. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Removed the option the cache blur. The reason was that since it was disabled in wayland (https://phabricator.kde.org/D9879) because it does not work

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#191008, @zzag wrote: > In https://phabricator.kde.org/D9848#190964, @luebking wrote: > > > I'm not actually smiling ... > > > > Anyway, instead of

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190964, @luebking wrote: > I'm not actually smiling ... > > Anyway, instead of using three vectors it's strongly suggest to use one vector (or rather array)

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

luebking added a comment. Restricted Application edited projects, added Plasma; removed KWin. I'm not actually smiling ... Anyway, instead of using three vectors it's strongly suggest to use one vector (or rather array) of a struct. a) you can access the inner values by names b) it's

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190676, @romangg wrote: > In https://phabricator.kde.org/D9848#190644, @anemeth wrote: > > > .arcconfig is not needed here > > > Your current patch

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

broulik added a comment. Restricted Application edited projects, added Plasma; removed KWin. > (Or how can I see the previous patch in this messy review tool Under "Revision Contents" is a "History" tab. > which draws an entire core when typing...) :D REPOSITORY R108 KWin

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

luebking added a comment. Restricted Application edited projects, added KWin; removed Plasma. Why was that a problem? (Or how can I see the previous patch in this messy review tool which draws an entire core when typing...) REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 6 inline comments as done. Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: broulik, romangg, zzag, anthonyfieroni, mart, davidedmundson, fredrik,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25350. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Reverted the change of putting the blur strength configuration into a vector, because it resulted in some complications. Doing it with the huge switch

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anthonyfieroni added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > blur.cpp:94 > delete shader; > -delete target; > +shader = NULL; > + m_simpleTarget should be deleted too > blur.cpp:96-104 > +for (int i = 0; i <

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190882, @broulik wrote: > > There are some rendering artifacts, when intermediate rendering results shall be saved. > > That feature has shown to be

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. > There are some rendering artifacts, when intermediate rendering results shall be saved. That feature has shown to be flaky numerous times and is, I think, still broken on Wayland

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added a comment. Restricted Application edited projects, added Plasma; removed KWin. It works on my main PC. There are some rendering artifacts, when intermediate rendering results shall be saved. To reproduce: put a window with different color to background halfway under the sound

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190775, @romangg wrote: > I'm trying to test this. In Konsole it does not seem to blur anything at all. Read something about setting xprop dbus signal to

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added a comment. Restricted Application edited projects, added Plasma; removed KWin. I'm trying to test this. In Konsole it does not seem to blur anything at all. Read something about setting xprop dbus signal to Konsole. Then it was blurred but a change of blur strength in the

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > blur.cpp:35 > > +#define BORDER_SIZE 5 > + `static const` and in the KWin namespace please. Also camel case then. > blur.cpp:139 > + * > + * The texture blur amount is

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190644, @anemeth wrote: > .arcconfig is not needed here Your current patch would delete the .arcconfig file from the KWin repo when being pushed. Do

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 2 inline comments as done. anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > romangg wrote in blur.h:29 > Put this into the cpp. Why? REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25305. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Moved pointer initialization to the header file. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25300=25305

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. > .arcconfig is not needed here and I re-added the whitespace to match the old version. git-checkout `.arcconfig` from parent commit. REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > blurshader.cpp:58 > +GLShader *m_shaderUpsample = nullptr; > +GLShader *m_shaderCopysample = nullptr; > + No, it should be in the header file. E.g. ... private:

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 8 inline comments as done. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. In https://phabricator.kde.org/D9848#190515, @romangg wrote: > In https://phabricator.kde.org/D9848#190128, @anemeth wrote: > > > Removed .arcconfig

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25300. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Changed all references of NULL to nullptr REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25290=25300 BRANCH

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added a comment. Restricted Application edited projects, added KWin; removed Plasma. Also, I would consider using smart pointers(e.g. `QScopedPointer`). INLINE COMMENTS > blur.cpp:92 > +delete m_simpleTarget; > +m_simpleTarget = NULL; > + Please use `nullptr`. >

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

romangg added a comment. Restricted Application edited projects, added Plasma; removed KWin. I think we talked about your patch on IRC some time ago. I'm very happy that you decided to put it up here in Phab for review. Your Kawase blur looks really good in my opinion. That it is also faster

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25290. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Fixed a bug where changing resolution would break the blur effect. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 6 inline comments as done. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25282. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Implementing the changes that were suggested by @zzag REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25267=25282

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > zzag wrote in blur.cpp:135 > Where did they come from? I came up with these numbers by testing different iteration and offset values. REPOSITORY R108 KWin REVISION DETAIL

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

zzag added inline comments. Restricted Application edited projects, added Plasma; removed KWin. INLINE COMMENTS > blur.cpp:135 > +/** > + * Explanation for the magic numbers: > + * Where did they come from? > blur.cpp:160 > +// Dummy data needed, because the blur strength

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: zzag, anthonyfieroni, mart, davidedmundson, fredrik, ngraham, plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. In https://phabricator.kde.org/D9848#190209, @davidedmundson wrote: > In general, I think it makes sense. Academically the change is sound[1] - and the results certainly look good. >

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added inline comments. Restricted Application edited projects, added KWin; removed Plasma. INLINE COMMENTS > davidedmundson wrote in blur.cpp:186 > m_simpleTarget no longer gets updated on screen changes. What do you mean by this? m_simpleTarget works independently form the vector of

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth marked 13 inline comments as done. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. These changes were implemented. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin Cc: anthonyfieroni,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25267. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Implemented the changes that were suggested by anthonyfieroni REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

davidedmundson added a comment. Restricted Application edited projects, added Plasma; removed KWin. Definitely not for 5.12 material with the release this close, but in general I'm in favour of it with the 4 months of testing we'd get if we went with this soon after branching. In

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

graesslin resigned from this revision. graesslin added subscribers: fredrik, davidedmundson, mart. graesslin added a comment. Restricted Application edited projects, added Plasma; removed KWin. I would like to see this reviewed by @fredrik, @mart , @davidedmundson and in general the

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. And here it is in action: F5644329: a.mp4 REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

Restricted Application edited projects, added Plasma; removed KWin. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, graesslin Cc: ngraham, plasma-devel, kwin, #kwin, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth edited the summary of this revision. Restricted Application edited projects, added KWin; removed Plasma. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, graesslin Cc: plasma-devel, kwin, #kwin, iodelay, bwowk, ZrenBot, progwolff,

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25253. anemeth added a comment. Restricted Application edited projects, added Plasma; removed KWin. Removed .arcconfig and added a whitespace REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25252=25253 BRANCH

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth updated this revision to Diff 25252. anemeth added a comment. Restricted Application edited projects, added KWin; removed Plasma. Removed whitespaces and added blur config structure. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9848?vs=25249=25252

D9848: Updated the blur method to use the more efficient dual kawase blur algorithm.

anemeth added reviewers: Plasma, KWin, graesslin. Restricted Application edited projects, added Plasma; removed KWin. Restricted Application added a subscriber: plasma-devel. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D9848 To: anemeth, #plasma, #kwin, graesslin Cc: