Re: Plasma 5.18 release post-mortem

2020-02-14 Thread Nate Graham
Some of the features or large changes that were added to 5.18 but caused regressions made it in close to the cut-off, but many were committed months ago. In particular 417424, 416695, 416358 were not the result of rush jobs, but they got broken anyway. I don't necessarily disagree though, but

Re: Plasma 5.18 release post-mortem

2020-02-14 Thread Marco Martin
On Thu, Feb 13, 2020 at 5:40 PM Nate Graham wrote: > > Plasma 5.18 was a pretty buggy release, and I'd like to start a > discussion about how we think it happened and what we can do better next > time. Here are some of the top bugs that our users are reporting: I think we wanted to put too much

Re: Plasma 5.18 release post-mortem

2020-02-13 Thread Nate Graham
On 2020-02-13 11:55, Vlad Zahorodnii wrote: On 2/13/20 8:11 PM, David Edmundson wrote: I'm also seeing a rising amount of pushing without review on the core repos.  I would like for us all to (nicely) call that out if we see any instances. Reviews are super important, the best time to fix a bug

Re: Plasma 5.18 release post-mortem

2020-02-13 Thread David Edmundson
On Thu, Feb 13, 2020 at 6:55 PM Vlad Zahorodnii wrote: > > On 2/13/20 8:11 PM, David Edmundson wrote: > > I'm also seeing a rising amount of pushing without review on the core > > repos. I would like for us all to (nicely) call that out if we see > > any instances. Reviews are super important,

Re: Plasma 5.18 release post-mortem

2020-02-13 Thread Vlad Zahorodnii
On 2/13/20 8:11 PM, David Edmundson wrote: I'm also seeing a rising amount of pushing without review on the core repos. I would like for us all to (nicely) call that out if we see any instances. Reviews are super important, the best time to fix a bug is before it even happens. Even for small

Re: Plasma 5.18 release post-mortem

2020-02-13 Thread David Edmundson
The important part right now is that we get on top with fixing them. For 5.18 there was /wy/ too much feature pushing for this release. Even if the new stuff itself doesn't introduce breakages, it takes developer and review time away from what should be a month of being totally on top of

Plasma 5.18 release post-mortem

2020-02-13 Thread Nate Graham
Plasma 5.18 was a pretty buggy release, and I'd like to start a discussion about how we think it happened and what we can do better next time. Here are some of the top bugs that our users are reporting: - https://bugs.kde.org/show_bug.cgi?id=417424 [Can't enter edit mode if widgets were