Re: Review Request: Add missing property alias animation in Slider Plasma Component

2012-03-20 Thread Sebastian Kügler
On Monday, March 19, 2012 10:09:21 David Edmundson wrote: Make sure Gallery/Sliders.qml is updated too. I've updated it. -- sebas http://www.kde.org | http://vizZzion.org | GPG Key ID: 9119 0EF9 ___ Plasma-devel mailing list Plasma-devel@kde.org

Re: Review Request: Add missing property alias animation in Slider Plasma Component

2012-03-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104318/#review11611 --- actually it was removed and i did forget to remove it from the

Re: Review Request: Add missing property alias animation in Slider Plasma Component

2012-03-19 Thread Aaron J. Seigo
On March 18, 2012, 7:57 p.m., Aaron J. Seigo wrote: what is the use case for knowing if it is animated or not? this seems like an internal implementation detail? David Edmundson wrote: I assume it's more for setting whether it animates or not. (when the user clicks on the slider,

Re: Review Request: Add missing property alias animation in Slider Plasma Component

2012-03-19 Thread David Edmundson
On March 18, 2012, 7:57 p.m., Aaron J. Seigo wrote: what is the use case for knowing if it is animated or not? this seems like an internal implementation detail? David Edmundson wrote: I assume it's more for setting whether it animates or not. (when the user clicks on the slider,

Re: Review Request: Add missing property alias animation in Slider Plasma Component

2012-03-18 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104318/#review11571 --- what is the use case for knowing if it is animated or not?

Re: Review Request: Add missing property alias animation in Slider Plasma Component

2012-03-18 Thread David Edmundson
On March 18, 2012, 7:57 p.m., Aaron J. Seigo wrote: what is the use case for knowing if it is animated or not? this seems like an internal implementation detail? I assume it's more for setting whether it animates or not. (when the user clicks on the slider, whether it slides to the new