Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-15 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/ --- (Updated Sept. 15, 2014, 9:24 a.m.) Status -- This change has been

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review66227 --- Kai, Martin. What's the status of this? Might be good to work

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread Martin Klapetek
On Sept. 11, 2014, 1:45 p.m., David Edmundson wrote: Kai, Martin. What's the status of this? Might be good to work it out whilst you're both here. It's ready, waiting for Ship it. - Martin --- This is an automatically generated

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread David Edmundson
On Sept. 11, 2014, 11:45 a.m., David Edmundson wrote: Kai, Martin. What's the status of this? Might be good to work it out whilst you're both here. Martin Klapetek wrote: It's ready, waiting for Ship it. Ship it! - David

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review66247 --- Ship it! And then we need to fix the horrible Free Space

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-11 Thread Martin Klapetek
On Sept. 11, 2014, 3:08 p.m., Kai Uwe Broulik wrote: And then we need to fix the horrible Free Space Notifier notification ;) http://quickgit.kde.org/?p=plasma-workspace.gita=commitdiffh=66c83af0baaf018947bb5e4edadd28ed4cb45e27 ;) - Martin

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/ --- (Updated Sept. 3, 2014, 6:14 p.m.) Review request for Plasma. Changes

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-03 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/ --- (Updated Sept. 3, 2014, 6:16 p.m.) Review request for Plasma.

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-09-02 Thread Martin Klapetek
On Aug. 24, 2014, 11:55 a.m., Kai Uwe Broulik wrote: applets/notifications/package/contents/ui/NotificationPopup.qml, line 60 https://git.reviewboard.kde.org/r/119916/diff/1/?file=307345#file307345line60 Why not make it take into account the button actual size? Such as Math.max(5

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-08-30 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review65546 --- I just pushed Review 119817 which you gave a Ship it weeks

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-08-24 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review65112 ---

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-08-23 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/ --- (Updated Aug. 24, 2014, 1:19 a.m.) Review request for Plasma.

Re: Review Request 119916: Make the notification popup higher when 3 actions are present

2014-08-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119916/#review65108 --- Ship it! One monsterous bug below. Make sure to fix it.