Re: Review Request: Add an unit test for Plasma::ConfigLoader

2010-09-13 Thread Martin Blumenstingl
On 2010-09-12 21:47:38, Martin Blumenstingl wrote: /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp, line 172 http://svn.reviewboard.kde.org/r/5329/diff/1/?file=35739#file35739line172 I am not sure why, but actual is always empty. I can't figure out the reason, because

Re: Review Request: Add an unit test for Plasma::ConfigLoader

2010-09-13 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/ --- (Updated 2010-09-13 17:51:03.041714) Review request for Plasma. Changes

Re: Review Request: Add an unit test for Plasma::ConfigLoader

2010-09-13 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/#review7582 --- Ship it! looks great; and it shows a problem in ConfigLoader -

Review Request: Add an unit test for Plasma::ConfigLoader

2010-09-12 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/ --- Review request for Plasma. Summary --- Currently I'm changing some of

Re: Review Request: Add an unit test for Plasma::ConfigLoader

2010-09-12 Thread Martin Blumenstingl
--- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5329/#review7566 --- /trunk/KDE/kdelibs/plasma/tests/configloadertest.cpp