Re: Review Request: KHoliday::HolidayRegionSelector: emit signal when modified

2011-02-13 Thread John Layt
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100619/#review1403 --- Ship it! Lookd good! - John On Feb. 12, 2011, 4:40 a.m.,

Re: Review Request: KHoliday::HolidayRegionSelector: emit signal when modified

2011-02-11 Thread Romário Rios
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100619/ --- (Updated Feb. 12, 2011, 4:40 a.m.) Review request for KDEPIM-Libraries

Re: Review Request: KHoliday::HolidayRegionSelector: emit signal when modified

2011-02-11 Thread Romário Rios
On Feb. 10, 2011, 4:53 p.m., John Layt wrote: Good idea, but not quite the right approach. I want to keep the internal implementation of the widget completely hidden from any clients, allowing it to be completely changed in the future if needs be, so exposing the QTreeWidgetItem