---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41214
---
Nothing serious, just some nitpicking.
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41215
---
Ship it!
Looking good, lots of incremental improvements, too.
On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote:
Looking good, lots of incremental improvements, too.
I suppose we need to adjust the linker targets in plasma-framework and
kde-workspace, too? If you don't have a patch for that as well, let me
know, and I'll change it shortly
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41220
---
Ship it!
+1 for taking care of this.
I'm noticing now there
On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote:
Looking good, lots of incremental improvements, too.
I suppose we need to adjust the linker targets in plasma-framework and
kde-workspace, too? If you don't have a patch for that as well, let me
know, and I'll change it shortly
On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote:
experimental/kdeclarative/bindings/backportglobal.h, line 24
http://git.reviewboard.kde.org/r/113086/diff/1/?file=193824#file193824line24
backportglobal should be not needed anymore since we don't have
qscriptengine anymore (needs
On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote:
Looking good, lots of incremental improvements, too.
I suppose we need to adjust the linker targets in plasma-framework and
kde-workspace, too? If you don't have a patch for that as well, let me
know, and I'll change it shortly
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/
---
(Updated Oct. 4, 2013, 4:26 p.m.)
Status
--
This change has been
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/#review41235
---
This review has been submitted with commit
---
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/113086/
---
Review request for KDE Frameworks and Plasma.
Repository: kdelibs
10 matches
Mail list logo