Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 10, 2014, 1:04 p.m.) Status -- This change has been m

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/#review52530 --- This review has been submitted with commit a4af9679f9f1864f33

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: > > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png > > > > > > Scale method and vsync are backend dependent, so i'd move this below > > the two (resp. them r

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 10, 2014, 9:20 a.m., Thomas Lübking wrote: > > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png > > > > > > Scale method and vsync are backend dependent, so i'd move this below > > the two (resp. them ri

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: > > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png > > > > > > Scale method and vsync are backend dependent, so i'd move this below > > the two (resp. them r

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 10, 2014, 9:20 a.m., Thomas Lübking wrote: > > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png > > > > > > Scale method and vsync are backend dependent, so i'd move this below > > the two (resp. them ri

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 4:15 p.m., Hugo Pereira Da Costa wrote: > > Hi Martin, > > Any idea why the background behind the shells is flat ? Does it happend > > with all KCMs ? > > (I'll double check asap but right now my systemsettings is crashing because > > my kauth is fubared. Links against incor

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: > > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png > > > > > > Scale method and vsync are backend dependent, so i'd move this below > > the two (resp. them r

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: > > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png > > > > > > acceptable to remove this from the for layout (and put on top and a > > splitter below?) spli

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 3:15 p.m., Hugo Pereira Da Costa wrote: > > Hi Martin, > > Any idea why the background behind the shells is flat ? Does it happend > > with all KCMs ? > > (I'll double check asap but right now my systemsettings is crashing because > > my kauth is fubared. Links against incor

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 3:15 p.m., Hugo Pereira Da Costa wrote: > > Hi Martin, > > Any idea why the background behind the shells is flat ? Does it happend > > with all KCMs ? > > (I'll double check asap but right now my systemsettings is crashing because > > my kauth is fubared. Links against incor

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 10, 2014, 10:20 a.m., Thomas Lübking wrote: > > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png > > > > > > Would this rather belong into the FX kcm? > > Thomas Pfeiffer wrote: > The "Enable Desktop

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 10, 2014, 9:20 a.m., Thomas Lübking wrote: > > File Attachment: Latest kcmcompositing screenshot - kcmcompositing.png > > > > > > Would this rather belong into the FX kcm? The "Enable Desktop Effects on Startup" option is one

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/#review52495 --- File Attachment: Latest kcmcompositing screenshot - kcmcompos

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 10, 2014, 10:02 a.m.) Review request for kwin, Plasma and

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 10, 2014, 10:03 a.m.) Review request for kwin, Plasma and

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 9, 2014, 7:04 p.m., Thomas Lübking wrote: > > File Attachment: New advanced compositing KCM - kcmcompositing.png > > > > > > OOC: Is there any HIG on this? > > Is the situation on QML better than on QWidget? > > (The i

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 9, 2014, 6:04 p.m., Thomas Lübking wrote: > > File Attachment: New advanced compositing KCM - kcmcompositing.png > > > > > > OOC: Is there any HIG on this? > > Is the situation on QML better than on QWidget? > > (The i

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 10:52 a.m., David Edmundson wrote: > > qml/CompositingView.qml, line 76 > > > > > > This is really liable to break. > > If someone were to add an entry in the earlier in the model and > >

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 9, 2014, 7:04 p.m., Thomas Lübking wrote: > > File Attachment: New advanced compositing KCM - kcmcompositing.png > > > > > > OOC: Is there any HIG on this? > > Is the situation on QML better than on QWidget? > > (The i

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 9, 2014, 7:04 p.m., Thomas Lübking wrote: > > File Attachment: New advanced compositing KCM - kcmcompositing.png > > > > > > OOC: Is there any HIG on this? > > Is the situation on QML better than on QWidget? > > (The i

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/#review52461 --- File Attachment: New advanced compositing KCM - kcmcompositin

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 9, 2014, 2:53 p.m.) Review request for kwin, Plasma and An

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 3:15 p.m., Hugo Pereira Da Costa wrote: > > Hi Martin, > > Any idea why the background behind the shells is flat ? Does it happend > > with all KCMs ? > > (I'll double check asap but right now my systemsettings is crashing because > > my kauth is fubared. Links against incor

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 3:15 p.m., Hugo Pereira Da Costa wrote: > > Hi Martin, > > Any idea why the background behind the shells is flat ? Does it happend > > with all KCMs ? > > (I'll double check asap but right now my systemsettings is crashing because > > my kauth is fubared. Links against incor

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 4:15 p.m., Hugo Pereira Da Costa wrote: > > Hi Martin, > > Any idea why the background behind the shells is flat ? Does it happend > > with all KCMs ? > > (I'll double check asap but right now my systemsettings is crashing because > > my kauth is fubared. Links against incor

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 3:15 p.m., Hugo Pereira Da Costa wrote: > > Hi Martin, > > Any idea why the background behind the shells is flat ? Does it happend > > with all KCMs ? > > (I'll double check asap but right now my systemsettings is crashing because > > my kauth is fubared. Links against incor

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/#review52352 --- Hi Martin, Any idea why the background behind the shells is fl

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

On Friday 07 March 2014 15:28:49 Thomas Pfeiffer wrote: > On Friday 07 March 2014 15:12:43 Jos Poortvliet wrote: > > On Friday 07 March 2014 13:37:22 Martin Gräßlin wrote: > > > > To not end on a low note, let me repeat again: Martin, thanks for this > > change. It is a step forward, no matter wh

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

On Friday 07 March 2014 13:37:22 Martin Gräßlin wrote: > > If they have to be split into two, I suggest renaming them into > > something more correct instead of something precise - like > > "Eye candy" and "Compositing KWM system", one being > > extremely childish and fancyful and the other uneces

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

On Friday 07 March 2014 15:12:43 Jos Poortvliet wrote: > On Friday 07 March 2014 13:37:22 Martin Gräßlin wrote: > > On Friday 07 March 2014 13:07:06 Jens Reuterberg wrote: > > > Sry for perhaps breaking etiquette with review requests. > > > > No that's just fine, but it would be better if you used

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

On Friday 07 March 2014 13:37:22 Martin Gräßlin wrote: > On Friday 07 March 2014 13:07:06 Jens Reuterberg wrote: > > Sry for perhaps breaking etiquette with review requests. > > No that's just fine, but it would be better if you used the web frontend to > keep the discussion in one place and you j

Re: Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

On Friday 07 March 2014 13:07:06 Jens Reuterberg wrote: > Sry for perhaps breaking etiquette with review requests. No that's just fine, but it would be better if you used the web frontend to keep the discussion in one place and you just lost the kwin mailing list :-) > The > KCM are at this mome

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

Sry for perhaps breaking etiquette with review requests. The KCM are at this moment a hot topic and one of the many issues is fragmentation vs merging of subject. The main issue is that the settings are, as it is, an extremely hostile area for new users. The sorting is arbitrary but justified

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 7, 2014, 12:40 p.m.) Review request for kwin, Plasma and A

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 7, 2014, 12:39 p.m.) Review request for kwin, Plasma and A

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 7, 2014, 12:19 p.m.) Review request for kwin, Plasma and A

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 9:52 a.m., David Edmundson wrote: > > > > Martin Gräßlin wrote: > Thanks for the review and I agree that all these things need improvment. > But it's orthogonal to the actual change of splitting into two and thus I > don't want to fix them right now. Therefore I dropped

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- (Updated March 7, 2014, 12:10 p.m.) Review request for kwin, Plasma and A

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 10:52 a.m., David Edmundson wrote: > > Thanks for the review and I agree that all these things need improvment. But it's orthogonal to the actual change of splitting into two and thus I don't want to fix them right now. Therefore I dropped all the issues which are unrelate

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

> On March 7, 2014, 10:52 a.m., David Edmundson wrote: > > File Attachment: New advanced compositing KCM - kcmcompositing.png > > > > > > Double margin? Looks like this is in kcmshell - Martin ---

Re: Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/#review52327 --- File Attachment: New effects KCM - kcmeffects.png

Review Request 116648: Split into one KCM for Desktop Effects and one for Compositing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/116648/ --- Review request for kwin, Plasma and Antonis Tsiapaliokas. Repository: kwi