Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

2017-02-08 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/ --- (Updated Feb. 8, 2017, 2:32 p.m.) Status -- This change has been

Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

2017-02-08 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/#review102468 --- Cleaned up patch and moved into:

Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

2014-10-01 Thread Joseph Wenninger
On Sept. 23, 2014, 8:47 vorm., Marco Martin wrote: applets/binary-clock/package/contents/ui/BinaryClock.qml, line 39 https://git.reviewboard.kde.org/r/120325/diff/1/?file=314629#file314629line39 perhaps the reason it looks too small in panels is that should use main.height

Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

2014-10-01 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/ --- (Updated Okt. 1, 2014, 8:21 nachm.) Review request for Plasma. Changes

Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

2014-09-24 Thread Martin Klapetek
On Sept. 23, 2014, 11:22 a.m., David Edmundson wrote: applets/binary-clock/package/contents/ui/configGeneral.qml, line 58 https://git.reviewboard.kde.org/r/120325/diff/1/?file=314632#file314632line58 in general ColumnLayout is better than Columns (from QtQuick.Layouts 1.1)

Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

2014-09-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/#review67274 --- Ship it! good start, it should be pushed then iteratively

Re: Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

2014-09-23 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/#review67280 --- applets/binary-clock/package/contents/ui/configGeneral.qml

Review Request 120325: port of the kde4 c++ based binary clock to kf5/qml only. It works on the desktop, but some sizing/dot sizeing issues exist in the panels. At least it is a start

2014-09-22 Thread Joseph Wenninger
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120325/ --- Review request for Plasma. Repository: kdeplasma-addons Description