Re: Review Request 123271: improve kickoff representation on vertical panels

2017-02-08 Thread Mathias Kraus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated Feb. 8, 2017, 1:29 p.m.) Status -- This change has been

Re: Review Request 123271: improve kickoff representation on vertical panels

2017-02-08 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review102463 --- kickoff has been rewritten, the patch is not valid anymore.

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-08 Thread Marco Martin
On April 7, 2015, 12:59 p.m., Sebastian Kügler wrote: So if the panel is horizontal, and high, people get a huge icon. If it's vertical and wide, the icon is limited and centered? That's pretty inconsistent. I agree that a huge button may not be what the user wants, but then what's

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-07 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78604 --- What when I place it on the desktop? I'd like it to fill the

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-07 Thread Martin Klapetek
On April 7, 2015, 11:43 a.m., Kai Uwe Broulik wrote: What when I place it on the desktop? I'd like it to fill the entire room there. If I want a massive Kickoff button on my desktop, that's up to me :) +1; it should really be iff vertical == true - Martin

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-07 Thread Marco Martin
On April 7, 2015, 12:59 p.m., Sebastian Kügler wrote: So if the panel is horizontal, and high, people get a huge icon. If it's vertical and wide, the icon is limited and centered? That's pretty inconsistent. I agree that a huge button may not be what the user wants, but then what's

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-07 Thread Mathias Kraus
On April 7, 2015, 9:43 vorm., Kai Uwe Broulik wrote: applets/kickoff/package/contents/ui/CompactRepresentation.qml, line 28 https://git.reviewboard.kde.org/r/123271/diff/1/?file=360272#file360272line28 readonly property The user could change the edge and then the property would

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-07 Thread Mathias Kraus
On April 7, 2015, 9:43 vorm., Kai Uwe Broulik wrote: What when I place it on the desktop? I'd like it to fill the entire room there. If I want a massive Kickoff button on my desktop, that's up to me :) Martin Klapetek wrote: +1; it should really be iff vertical == true This patch

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-07 Thread Mathias Kraus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- (Updated April 7, 2015, 9:56 nachm.) Review request for Plasma.

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-07 Thread Mathias Kraus
On April 7, 2015, 12:59 nachm., Sebastian Kügler wrote: So if the panel is horizontal, and high, people get a huge icon. If it's vertical and wide, the icon is limited and centered? That's pretty inconsistent. I agree that a huge button may not be what the user wants, but then

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-07 Thread Kai Uwe Broulik
On April 7, 2015, 9:43 vorm., Kai Uwe Broulik wrote: What when I place it on the desktop? I'd like it to fill the entire room there. If I want a massive Kickoff button on my desktop, that's up to me :) Martin Klapetek wrote: +1; it should really be iff vertical == true Mathias

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-06 Thread Mark Gaiser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78570 --- Err, i don't see an error in the vertical before version. The

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-06 Thread Mathias Kraus
On April 6, 2015, 5:18 nachm., Mark Gaiser wrote: Err, i don't see an error in the vertical before version. The kickoff icon simply scales to the new available width, that's how it's supposed to work, right? I'm not 100% sure. A plasma dev will probably jump in and correct me if

Re: Review Request 123271: improve kickoff representation on vertical panels

2015-04-06 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/#review78577 --- Personally I think this patch makes sense, having the button

Review Request 123271: improve kickoff representation on vertical panels

2015-04-06 Thread Mathias Kraus
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/123271/ --- Review request for Plasma. Repository: plasma-desktop Description