Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-26 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 26, 2016, 12:17 p.m.) Status -- This change has been

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-25 Thread Martin Klapetek
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91599 --- Ship it! Looks good to me, thanks! - Martin Klapetek

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-25 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 25, 2016, 7:48 p.m.) Review request for Plasma and Martin

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-25 Thread Martin Gräßlin
> On Jan. 22, 2016, 10:33 p.m., Xuetian Weng wrote: > > pam_kwallet_init.desktop.cmake, line 7 > > > > > > Why limit to these desktop anyway? I don't see why this is necessary. > > (e.g. why not lxqt?) > > Armin

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Xuetian Weng
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91457 --- pam_kwallet_init.desktop.cmake (line 7)

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 19-23 > > > > > > on syntax: else and endif don't need to repeat the condition any more. > > Also we tend to use the lower case

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 22, 2016, 7:02 p.m.) Review request for Plasma and Martin

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- (Updated Jan. 22, 2016, 7:08 p.m.) Review request for Plasma and Martin

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/#review91445 --- Good idea and looks good (IMHO). CMakeLists.txt (line 2)

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, line 2 > > > > > > out of interest: why is the version raise required? I see all the packages that use extra-cmake-modules use that

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Xuetian Weng
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 19-23 > > > > > > on syntax: else and endif don't need to repeat the condition any more. > > Also we tend to use the lower case

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> On Jan. 22, 2016, 6:11 p.m., Martin Gräßlin wrote: > > CMakeLists.txt, lines 19-23 > > > > > > on syntax: else and endif don't need to repeat the condition any more. > > Also we tend to use the lower case

Re: Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
> On Jan. 22, 2016, 9:33 p.m., Xuetian Weng wrote: > > pam_kwallet_init.desktop.cmake, line 7 > > > > > > Why limit to these desktop anyway? I don't see why this is necessary. > > (e.g. why not lxqt?) Hmm, I

Review Request 126843: Make kwallet-pam usable outside of Plasma

2016-01-22 Thread Armin K.
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126843/ --- Review request for Plasma and Martin Klapetek. Repository: kwallet-pam