Re: Review Request 128966: Don't include kdeglobals when dealing with a cache config

2016-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128966/#review99348 --- Ship it! good catch - Marco Martin On Sept. 21, 2016,

[Differential] [Closed] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

2016-09-21 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP9d55c52f76cf: [KeyboardDaemon] Don't call getCurrentLayout() in destructor (authored by broulik). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 09:53:44 + Build duration: 22 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 352 - Still unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/352/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 09:54:08 + Build duration: 21 min CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 353 - Still Unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/353/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 10:17:24 + Build duration: 12 min CHANGE SET Revision

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

2016-09-21 Thread via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=341762 bl...@vivaldi.net changed: What|Removed |Added CC||bl...@vivaldi.net --- Comment #8 from

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

2016-09-21 Thread Oliver Henshaw via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369129 Oliver Henshaw changed: What|Removed |Added CC|

[Breeze] [Bug 365025] Breeze Dark Theme made Dolphin main view hard to read

2016-09-21 Thread Elvis Angelaccio via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=365025 Elvis Angelaccio changed: What|Removed |Added Assignee|dolphin-bugs-n...@kde.org

[kio-extras] [Bug 364642] 16.04.3: kio_sftp is broken

2016-09-21 Thread Elvis Angelaccio via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=364642 Elvis Angelaccio changed: What|Removed |Added Component|general |default

Re: Review Request 128966: Don't include kdeglobals when dealing with a cache config

2016-09-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128966/ --- (Updated Sept. 21, 2016, 12:44 p.m.) Status -- This change has been

Is it possible to include in the plasmoid file the translations?

2016-09-21 Thread Michail Vourlakos
Hello everyone, is it possible inside the .plasmoid file to include the various translations some how? I am referring to .mo files... regards, michail

[Differential] [Accepted] D2823: [Device Notifier] Only ever pop up if device is visible in the list

2016-09-21 Thread sitter (Harald Sitter)
sitter accepted this revision. sitter added a comment. lgtm. and it works \o/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2823 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D2820: Updating the wallpaper cache only when the configuration file settles

2016-09-21 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > sortedactivitiesmodel.cpp:65 > +updateTimer.setSingleShot(true); > +updateTimer.setInterval(500); > + is a blind timer the only way to wait enough? :/ REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Updated] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

2016-09-21 Thread sitter (Harald Sitter)
sitter added a comment. seems to not be crashing anymore. unfortunately I can't comment on the correctness of the change REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2818 EMAIL PREFERENCES

Re: Review Request 128948: Update shortcuts kcm docbook

2016-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128948/#review99346 --- Ship it! Ship It! - Marco Martin On Sept. 20, 2016,

Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme

2016-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128392/#review99349 --- Any news on that? - Marco Martin On July 11, 2016, 10:51

[Differential] [Changed Subscribers] D2820: Updating the wallpaper cache only when the configuration file settles

2016-09-21 Thread broulik (Kai Uwe Broulik)
broulik added inline comments. INLINE COMMENTS > sortedactivitiesmodel.cpp:49 > +, plasmaConfig(KSharedConfig::openConfig(PLASMACONFIG)) > +, updateTimer() > { Not needed? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-21 Thread Marco Martin
> On Sept. 19, 2016, 9:52 p.m., Marco Martin wrote: > > shell/scripting/panel.cpp, line 189 > > > > > > this can't rely on the order of qGuiApp->screens, but should use > > screenpool in shellcorona, it's the

[Differential] [Accepted] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

2016-09-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2818 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 351 - Failure!

2016-09-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/351/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 09:26:17 + Build duration: 3 min 38 sec CHANGE SET Revision

[Differential] [Accepted] D2824: Make sure that default devices are not null

2016-09-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D2824 EMAIL PREFERENCES

[Differential] [Closed] D2823: [Device Notifier] Only ever pop up if device is visible in the list

2016-09-21 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb28ea53b351c: [Device Notifier] Only ever pop up if device is visible in the list (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Review Request 128948: Update shortcuts kcm docbook

2016-09-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128948/ --- (Updated Sept. 21, 2016, 10:11 a.m.) Status -- This change has been

[Differential] [Closed] D2824: Make sure that default devices are not null

2016-09-21 Thread drosca (David Rosca)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAPA270110e5520f: Make sure that default devices are not null (authored by drosca). REPOSITORY rPLASMAPA Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

[Breeze] [Bug 369158] New: Breeze sddm theme broken on dual monitor setup (no cursor)

2016-09-21 Thread Andreas Eckstein via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369158 Bug ID: 369158 Summary: Breeze sddm theme broken on dual monitor setup (no cursor) Product: Breeze Version: 5.7.95 Platform: Other OS: Linux Status:

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 13:29:09 + Build duration: 19 min CHANGE SET Revision

Review Request 128973: Update icon lcm docbook

2016-09-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128973/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 354 - Still Unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/354/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 12:14:17 + Build duration: 17 min CHANGE SET Revision

[Differential] [Request, 4 lines] D2825: [Panel Config View] Set Qt::WindowStaysOnTopHint

2016-09-21 Thread broulik (Kai Uwe Broulik)
broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We set KeepAbove using

Re: Review Request 128760: Fix crash on exit

2016-09-21 Thread Peter Wu
> On Sept. 17, 2016, 11:39 p.m., Hugo Pereira Da Costa wrote: > > Sorry for the delay > > ... for some reason I don't always recieve notifications from reviewboard > > Hugo Pereira Da Costa wrote: > Ping ? > Do people have commit rights ? Should I commit it myself ? I think you should

Review Request 128974: Proofread/update cursortheme kcm docbook

2016-09-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128974/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

2016-09-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128978/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

[Differential] [Updated] D2796: Fix valgrind warning in volume and channelMap memcmp

2016-09-21 Thread davidedmundson (David Edmundson)
davidedmundson updated the summary for this revision. REPOSITORY rPLASMAPA Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D2796 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: plasma-devel, lesliezhai,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 355 - Still Unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/355/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 13:29:44 + Build duration: 24 min CHANGE SET Revision

Re: Review Request 128760: Fix crash on exit

2016-09-21 Thread Peter Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128760/ --- (Updated Sept. 21, 2016, 12:19 p.m.) Status -- This change has been

[Differential] [Closed] D2825: [Panel Config View] Set Qt::WindowStaysOnTopHint

2016-09-21 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEdacb6b27dcd0: [Panel Config View] Set Qt::WindowStaysOnTopHint (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2820: Updating the wallpaper cache only when the configuration file settles

2016-09-21 Thread davidedmundson (David Edmundson)
davidedmundson added inline comments. INLINE COMMENTS > sortedactivitiesmodel.cpp:197 > bool initialized; > -KConfig plasmaConfig; > +KSharedConfig::Ptr plasmaConfig; > +QTimer updateTimer; Now it's a sharedconfig (a *very* sensible change) - you don't even need

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

2016-09-21 Thread Rudd-O
https://bugs.kde.org/show_bug.cgi?id=369129 --- Comment #5 from Manuel Amador (Rudd-O) --- We should tackle the problem with KDE first, as KDE moves faster than GNOME and has a long history of innovating in this space (Solid). A KDE-only / Powerdevil-only solution is adequate

[Differential] [Accepted] D2825: [Panel Config View] Set Qt::WindowStaysOnTopHint

2016-09-21 Thread mart (Marco Martin)
mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2825 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Review Request 128977: Proofread/update emoticons kcm docbook

2016-09-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128977/ --- Review request for Documentation and Plasma. Repository: plasma-desktop

[Differential] [Updated, 28 lines] D2827: Polish SwipeListItem

2016-09-21 Thread apol (Aleix Pol Gonzalez)
apol updated this revision to Diff 6856. apol added a comment. Reduce magic numbers REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2827?vs=6855=6856 BRANCH master REVISION DETAIL https://phabricator.kde.org/D2827 AFFECTED FILES

[Differential] [Updated] D2827: Polish SwipeListItem

2016-09-21 Thread apol (Aleix Pol Gonzalez)
apol marked an inline comment as done. apol added inline comments. INLINE COMMENTS > mart wrote in SwipeListItem.qml:362 > what's the rationale for this? Good point, fixed. REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2827 EMAIL PREFERENCES

[Differential] [Accepted] D2827: Polish SwipeListItem

2016-09-21 Thread mart (Marco Martin)
mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2827 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc:

[Differential] [Request, 9 lines] D2826: Fix shortcuts editor with double click to activate enabled

2016-09-21 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Semantically we want to show the suboptions on selection not activation. Also it fixes an

[Differential] [Commented On] D2827: Polish SwipeListItem

2016-09-21 Thread mart (Marco Martin)
mart added inline comments. INLINE COMMENTS > SwipeListItem.qml:362 > margins: Units.smallSpacing > +rightMargin: handleIcon.width * 2 > } what's the rationale for this? REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL

[Differential] [Closed] D2827: Polish SwipeListItem

2016-09-21 Thread apol (Aleix Pol Gonzalez)
This revision was automatically updated to reflect the committed changes. apol marked an inline comment as done. Closed by commit rKIRIGAMIf90a5ca65f04: Polish SwipeListItem (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE

[Differential] [Request, 21 lines] D2827: Polish SwipeListItem

2016-09-21 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Make sure we don't have 2 different code paths for contentItem initialization as one of them had a

Re: Review Request 128973: Update icon lcm docbook

2016-09-21 Thread Marco Martin
> On Sept. 21, 2016, 2:58 p.m., Marco Martin wrote: > > doc/kcontrol/icons/index.docbook, line 33 > > > > > > uppercase Plasma, Dolphin etc? > > Burkhard Lück wrote: > frameworks/kdoctools > >

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

2016-09-21 Thread Rudd-O
https://bugs.kde.org/show_bug.cgi?id=369129 --- Comment #4 from Manuel Amador (Rudd-O) --- I don't think things further up the stack have the necessary information to make an informed decision. The "sound card" of HDMI outs and the video cards powering them appear as

Re: Review Request 128974: Proofread/update cursortheme kcm docbook

2016-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128974/#review99367 --- Ship it! Ship It! - Marco Martin On Sept. 21, 2016,

Re: Review Request 128973: Update icon lcm docbook

2016-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128973/#review99368 --- Fix it, then Ship it! doc/kcontrol/icons/index.docbook

Re: Review Request 128973: Update icon lcm docbook

2016-09-21 Thread Burkhard Lück
> On Sept. 21, 2016, 2:58 nachm., Marco Martin wrote: > > doc/kcontrol/icons/index.docbook, line 33 > > > > > > uppercase Plasma, Dolphin etc? frameworks/kdoctools general.entities:400:Plasma">

Re: Review Request 128977: Proofread/update emoticons kcm docbook

2016-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128977/#review99366 --- Ship it! Ship It! - Marco Martin On Sept. 21, 2016,

Re: Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

2016-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128978/#review99365 --- Ship it! Ship It! - Marco Martin On Sept. 21, 2016,

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-21 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99390 --- for reference, look at what the recent commit

Re: Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

2016-09-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128978/ --- (Updated Sept. 21, 2016, 6:45 p.m.) Status -- This change has been

[Breeze] [Bug 363602] Symlinked SVG files fails to load under Windows

2016-09-21 Thread Jasem Mutlaq via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=363602 Jasem Mutlaq changed: What|Removed |Added Resolution|--- |FIXED

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 356 - Still Unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/356/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 18:40:50 + Build duration: 7 min 41 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 357 - Still Unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/357/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 18:49:05 + Build duration: 7 min 31 sec CHANGE SET Revision

Re: Review Request 128965: Update color kcm docbook to 5.8

2016-09-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128965/ --- (Updated Sept. 21, 2016, 6:40 p.m.) Status -- This change has been

Re: Review Request 128977: Proofread/update emoticons kcm docbook

2016-09-21 Thread Burkhard Lück
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128977/ --- (Updated Sept. 21, 2016, 7:03 p.m.) Status -- This change has been

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 358 - Still Unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/358/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 19:04:06 + Build duration: 7 min 33 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Unstable!

2016-09-21 Thread no-reply
GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 22:42:24 + Build duration: 9 min 27 sec CHANGE SET Revision

Re: Review Request 128996: Don't generate appstream files for components that are not in rdn

2016-09-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128996/#review99399 --- +1 - David Edmundson On Sept. 21, 2016, 10:41 p.m., Aleix

[Differential] [Request, 10 lines] D2830: ApplicationWindow.bannerPressed signal

2016-09-21 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2830 AFFECTED FILES

[Differential] [Request, 12 lines] D2831: Introduce an action to display what we're showing in the menu

2016-09-21 Thread apol (Aleix Pol Gonzalez)
apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY We let the developer introduce a tree of actions as a menu. This patch makes it possible for the

Re: Review Request 128996: Don't generate appstream files for components that are not in rdn

2016-09-21 Thread Matthias Klumpp
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128996/#review99401 --- Ship it! Ship It! - Matthias Klumpp On Sept. 21, 2016,

Jenkins-kde-ci: khotkeys Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

2016-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 23:01:45 + Build duration: 2 min 12 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: khotkeys Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

2016-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 23:01:45 + Build duration: 2 min 12 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 12 - Fixed!

2016-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 23:40:50 + Build duration: 8 min 2 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 12 - Fixed!

2016-09-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/ Project: PLATFORM=Linux,compiler=gcc Date of build: Wed, 21 Sep 2016 23:40:50 + Build duration: 8 min 2 sec CHANGE SET No changes JUNIT RESULTS

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-21 Thread Aleix Pol Gonzalez
> On Sept. 22, 2016, 1:42 a.m., David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? The warning was saying that it's a delete of something fwd-declared. A bit more

[Powerdevil] [Bug 369181] New: User session security vulnerability from screen lock being suppressed with power management

2016-09-21 Thread Boskote via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369181 Bug ID: 369181 Summary: User session security vulnerability from screen lock being suppressed with power management Product: Powerdevil Version: 5.6.4 Platform: Debian testing

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/#review99402 --- appmenu/appmenu.cpp (line 90)

[Powerdevil] [Bug 369181] User session security vulnerability from screen lock being suppressed with power management

2016-09-21 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369181 Kai Uwe Broulik changed: What|Removed |Added Flags||Usability?

Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128997/ --- Review request for Plasma. Repository: plasma-workspace Description

[Differential] [Request, 2 lines] D2829: Add description for volume applet

2016-09-21 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes appstream test failure on CI. Also it's a useful thing to have anyway as the comment

Re: Review Request 128760: Fix crash on exit

2016-09-21 Thread Hugo Pereira Da Costa
> On Sept. 17, 2016, 9:39 p.m., Hugo Pereira Da Costa wrote: > > Sorry for the delay > > ... for some reason I don't always recieve notifications from reviewboard Ping ? Do people have commit rights ? Should I commit it myself ? - Hugo

Re: Review Request 128965: Update color kcm docbook to 5.8

2016-09-21 Thread Olivier Churlaud
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128965/#review99344 --- Ship it! Ship It! - Olivier Churlaud On Sept. 21,

[Differential] [Request, 43 lines] D2824: Make sure that default devices are not null

2016-09-21 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Sometimes at the time when default sink/source change is signalled by pa, we don't have that device in

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016-09-21 Thread David Edmundson
> On Sept. 21, 2016, 10:35 p.m., John Salatas wrote: > > Reopened due to > > https://bugs.kde.org/show_bug.cgi?id=369160 No need to reopen it, just create a new review with any new changes in it. Hopefully we'll be a bit quicker at responding. Note that reviews have now moved onto

Re: Review Request 128996: Don't generate appstream files for components that are not in rdn

2016-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128996/ --- (Updated Sept. 21, 2016, 11:38 p.m.) Status -- This change has been

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

2016-09-21 Thread John Salatas
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128402/#review99397 --- Reopened due to https://bugs.kde.org/show_bug.cgi?id=369160

Review Request 128996: Don't generate appstream files for components that are not in rdn

2016-09-21 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128996/ --- Review request for KDE Frameworks and Plasma. Repository: kpackage

Re: Review Request 128997: Fix most obvious clazy and clang warnings

2016-09-21 Thread Anthony Fieroni
> On Септ. 22, 2016, 2:42 преди обяд, David Edmundson wrote: > > appmenu/appmenu.cpp, line 90 > > > > > > what's with this change? > > Aleix Pol Gonzalez wrote: > The warning was saying that it's a delete of

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

2016-09-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128950/#review99342 --- shell/scripting/panel.cpp (line 182)

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

2016-09-21 Thread Kai Uwe Broulik via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=369129 Kai Uwe Broulik changed: What|Removed |Added CC|

Re: NM-Qt: tens of blocking DBus calls for every nm device

2016-09-21 Thread Jan Grulich
Hi, I'm aware that we do this. Give me few days to fix this in all NMQT classes, like we do in Manager class. Regards, Jan -- Jan Grulich Software Engineer, Desktop team Red Hat Czech On středa 21. září 2016 1:46:29 CEST Aleix Pol wrote: > Hi networkmanagerers, plasmers,

Review Request 128966: Don't include kdeglobals when dealing with a cache config

2016-09-21 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128966/ --- Review request for KDE Frameworks and Plasma. Repository: