[Differential] [Commented On] D2942: [klipper] Move notification from tray to Klipper

graesslin added a comment. In https://phabricator.kde.org/D2942#54618, @broulik wrote: > If there isn't an option for that already (haven't checked) might make sense to turn that notification into a proper notifyrc event, so the user can turn the notification off. (separate to this

[Differential] [Commented On] D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling

graesslin added inline comments. INLINE COMMENTS > luebking wrote in tabboxhandler.cpp:621 > x + y? dangerous. If there is a scrolling in both horizontal and vertical (could happen on touchpad) it could result in no scrolling if one is negative and the other is positive. REPOSITORY rKWIN

[Differential] [Updated, 34 lines] D2942: [klipper] Move notification from tray to Klipper

graesslin updated this revision to Diff 7130. graesslin added a comment. Use the KNotification::event overload which takes the icon name REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2942?vs=7107=7130 BRANCH

[Differential] [Commented On] D2942: [klipper] Move notification from tray to Klipper

graesslin added a comment. In https://phabricator.kde.org/D2942#54723, @tillschafer wrote: > another minor issue: the notification symbol/icon is blurred and the old one from KDE 4 times. That problem should be addressed with the updated version. It no longer sends a 16x16 icon.

[Differential] [Commented On] D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling

luebking added inline comments. INLINE COMMENTS > graesslin wrote in tabboxhandler.cpp:621 > dangerous. If there is a scrolling in both horizontal and vertical (could > happen on touchpad) it could result in no scrolling if one is negative and > the other is positive. One might call that

[Differential] [Updated, 43 lines] D2957: [SDDM Theme] Offer switching to the user's session if there is one

broulik updated this revision to Diff 7138. broulik added a comment. Apply similar patch like https://phabricator.kde.org/D2956 so pressing Return triggers the "Switch To" functionality if applicable REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated] D2957: [SDDM Theme] Offer switching to the user's session if there is one

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2957 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel,

[Differential] [Closed] D2946: make sure allTimezones is set

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEe88b52a18ff9: make sure allTimezones is set (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2946?vs=7117=7133

Re: Review Request 129110: Generate the icon into the appstream file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129110/#review99805 --- Ship it! Ship It! - Marco Martin On Oct. 6, 2016,

[Differential] [Accepted] D2954: [Notification Data Engine] Don't group notification if it should replace an existing one

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 36 lines] D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling

graesslin created this revision. graesslin added reviewers: KWin, Plasma, broulik. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY The TabBox performs the scrolling of the items by itself in order to support wheel

[Differential] [Request, 2 lines] D2956: [Lock Screen] When pressing Return just trigger button

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When pressing Return on

[Differential] [Request, 24 lines] D2955: Fix scissoring of VBO rendering in multi-screen setup on Wayland

graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY On Wayland in multi-screen a "window" is used to render to per

[Differential] [Commented On] D2954: [Notification Data Engine] Don't group notification if it should replace an existing one

graesslin added a comment. +1 REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2954 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mck182 Cc: graesslin, plasma-devel, lesliezhai,

[Differential] [Request, 3 lines] D2954: [Notification Data Engine] Don't group notification if it should replace an existing one

broulik created this revision. broulik added reviewers: Plasma, mck182. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If an application

[Differential] [Updated] D2957: [SDDM Theme] Offer switching to the user's session if there is one

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2957 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: plasma-devel,

[Differential] [Accepted] D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling

lukedashjr accepted this revision. lukedashjr added a reviewer: lukedashjr. lukedashjr added a comment. This revision is now accepted and ready to land. I'm not familiar with the codebase, but the changes look reasonable, and I can confirm it fixes the issue (applied on top of 5.6.5).

[Differential] [Changed Subscribers] D2953: [tabbox] Intercept QWheelEvents on QQuickWindow for scrolling

luebking added inline comments. INLINE COMMENTS > tabboxhandler.cpp:618 > +if (watched == d->window()) { > +if (e->type() == QEvent::Wheel) { > +QWheelEvent *event = static_cast(e); test type first - you'll get many paint events etc. but the filter is

[Differential] [Request, 41 lines] D2957: [SDDM Theme] Offer switching to the user's session if there is one

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When

[Differential] [Commented On] D2957: [SDDM Theme] Offer switching to the user's session if there is one

mart added a comment. +1000 from me \o/ REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2957 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design Cc: mart, plasma-devel,

[Differential] [Commented On] D2660: Prefer an algorithm over an explicit for loop

mart added a comment. any news on that? REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL https://phabricator.kde.org/D2660 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: jkt, broulik Cc: mart, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Accepted] D2833: Quicklaunch: Add support for jumplist actions

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL https://phabricator.kde.org/D2833 EMAIL PREFERENCES

[Differential] [Request, 1 line] D2959: [KAccess] Set componentDisplayName

broulik created this revision. broulik added reviewers: Plasma, Plasma: Design. broulik set the repository for this revision to rPLASMADESKTOP Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures

[Differential] [Changed Subscribers] D2957: [SDDM Theme] Offer switching to the user's session if there is one

colomar added a subscriber: graesslin. colomar added a comment. > Also it really needs to be a config option somewhere. People do multiple login. We made LightDM reuse sessions and got tonnes of comments. @graesslin said he'd prefer to block multiple login with the same user due to all

[Differential] [Commented On] D2945: Workaround xkbcommon behavior concerning consumed modifiers

graesslin added inline comments. INLINE COMMENTS > luebking wrote in keyboard_input.cpp:420 > Possible pitfalls: > > What if eg. Ctrl+Alt+Foo creates a keysym, but Ctrl+Alt+Shift+Foo does not? > > If however Ctrl+Alt+Foo and Ctrl+Alt+Shift+Foo create keysyms, Ctrl+Alt+Shift > would be

[Differential] [Request, 4 lines] D2960: [shell] Fix non-interactive panelview on non-primary screen

bshah created this revision. bshah added reviewers: Plasma, mart, graesslin. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If we don't pass the current screen to QCursor::pos, it will return position relative to

[Differential] [Updated, 9 lines] D2660: Prefer an algorithm over an explicit for loop

jkt removed rPOWERDEVIL Powerdevil as the repository for this revision. jkt updated this revision to Diff 7144. jkt added a comment. I used cbegin because this is in a place which uses STL idioms. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2660?vs=6435=7144 REVISION DETAIL

[Differential] [Accepted] D2960: [shell] Fix non-interactive panelview on non-primary screen

graesslin accepted this revision. graesslin added a comment. This revision is now accepted and ready to land. yay, I finally was able to remove the stupid panel on my second screen! REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH fix-panel (branched from Plasma/5.8) REVISION DETAIL

[Differential] [Abandoned] D2835: add a temporary timer

mart abandoned this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2835 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: apol, davidedmundson, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D2956: [Lock Screen] When pressing Return just trigger button

mart added a comment. hmm is a bit dangerous? should the handler of button clicked be a function callable also from there instead? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2956 EMAIL PREFERENCES

[Differential] [Accepted] D2959: [KAccess] Set componentDisplayName

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2959 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D2945: Workaround xkbcommon behavior concerning consumed modifiers

luebking added inline comments. INLINE COMMENTS > keyboard_input.cpp:420 > +// handle this is through new API in xkbcommon which doesn't exist yet > +if (m_consumedModifiers & ~m_modifiers) { > +return mods; Possible pitfalls: What if eg. Ctrl+Alt+Foo creates a keysym, but

[Differential] [Accepted] D2877: Use Plasma::PluginLoader to list applets

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2877 EMAIL PREFERENCES

[Differential] [Commented On] D2894: Start KDE Cleanups

mart added a comment. what's the status on that? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2894 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: mart, broulik, plasma-devel,

[Differential] [Requested Changes To] D2957: [SDDM Theme] Offer switching to the user's session if there is one

davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. The theme is not an appropriate place to do behavioural changes. Otherwise you change theme and login is

[Differential] [Accepted] D2945: Workaround xkbcommon behavior concerning consumed modifiers

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH consumed-mods-fix-5.8 REVISION DETAIL https://phabricator.kde.org/D2945 EMAIL PREFERENCES

[Differential] [Accepted] D2894: Start KDE Cleanups

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH startkde_fixups REVISION DETAIL https://phabricator.kde.org/D2894 EMAIL PREFERENCES

[Differential] [Accepted] D2955: Fix scissoring of VBO rendering in multi-screen setup on Wayland

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. sounds sensible. REPOSITORY rKWIN KWin BRANCH vertex-buffer-scissoring-multi-screen REVISION DETAIL https://phabricator.kde.org/D2955 EMAIL PREFERENCES

[Differential] [Commented On] D2957: [SDDM Theme] Offer switching to the user's session if there is one

colomar added a comment. Definitely a good change! Suggestion as for when to release: One way we could go about it is see whether we get bug reports about the current behavior. If users perceive it as a bug, we release this as a bugfix, otherwise it goes into 5.9. REPOSITORY

[Differential] [Accepted] D2660: Prefer an algorithm over an explicit for loop

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision is now accepted and ready to land. you can make them constBegin() now you're doing the clear after? REPOSITORY rPOWERDEVIL Powerdevil REVISION DETAIL

Re: Review Request 129101: Port to new plasma-framework API

> On Oct. 6, 2016, 4:58 a.m., Michael Stemle wrote: > > runners/windowedwidgets/windowedwidgetsrunner.cpp, line 111 > > > > > > *Nit-picky:* If it's not a name, and other parts have a name, maybe we > > should

[Differential] [Accepted] D2952: Only trigger mod-only-shortcuts if global shortcuts are enabled

hein accepted this revision. hein added a reviewer: hein. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH mod-only-shortcuts-disabled-5.8 REVISION DETAIL https://phabricator.kde.org/D2952 EMAIL PREFERENCES

[Differential] [Updated] D2942: [klipper] Move notification from tray to Klipper

mart added a comment. should be ok now with https://phabricator.kde.org/D2954 ? REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2942 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma Cc:

[Differential] [Closed] D2954: [Notification Data Engine] Don't group notification if it should replace an existing one

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEfcc806c09859: [Notification Data Engine] Don't group notification if it should replace an… (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2894: Start KDE Cleanups

mart added a comment. In https://phabricator.kde.org/D2894#54900, @davidedmundson wrote: > In https://phabricator.kde.org/D2894#54881, @mart wrote: > > > what's the status on that? > > > Done in the second patch. so this should be good to go? REPOSITORY

[Differential] [Commented On] D2680: [Task Manager] Activate tasks by Meta + number shortcuts

mart added a comment. any news on that? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2680 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, hein Cc: colomar, ivan, graesslin,

[Differential] [Commented On] D2894: Start KDE Cleanups

davidedmundson added a comment. In https://phabricator.kde.org/D2894#54881, @mart wrote: > what's the status on that? Done in the second patch. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2894 EMAIL PREFERENCES

[Differential] [Commented On] D2894: Start KDE Cleanups

davidedmundson added a comment. In https://phabricator.kde.org/D2894#54911, @mart wrote: > In https://phabricator.kde.org/D2894#54900, @davidedmundson wrote: > > > In https://phabricator.kde.org/D2894#54881, @mart wrote: > > > > > what's the status on that? > > > > > > Done

[Differential] [Commented On] D2957: [SDDM Theme] Offer switching to the user's session if there is one

mart added a comment. two sessions with the same login is something that is always bound to cause many problems. returning to the same session should be at least the default, with some hoops to go trough in order to achieve the 2 logins for the same user. REPOSITORY rPLASMAWORKSPACE

[Differential] [Accepted] D2942: [klipper] Move notification from tray to Klipper

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH klipper-notification-5.8 REVISION DETAIL https://phabricator.kde.org/D2942 EMAIL PREFERENCES

Re: Review Request 129110: Generate the icon into the appstream file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129110/ --- (Updated Oct. 6, 2016, 11:11 a.m.) Status -- This change has been

[Differential] [Request, 5 lines] D2966: save the containment only aftyer switch

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY during a type switch if the new containment gets saved before getting a view, it will get lastScreen=-1 so the

Review Request 129112: [QtQuickRendererSettings] Fix default to be empty instead of "false"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129112/ --- Review request for Plasma. Repository: kdeclarative Description

[Differential] [Closed] D2966: save the containment only aftyer switch

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE53b2a407af9d: save the containment only aftyer switch (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2965: [Logout Greeter] Add QtQuickSettings

graesslin accepted this revision. graesslin added a reviewer: graesslin. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2965 EMAIL PREFERENCES

[Differential] [Closed] D2952: Only trigger mod-only-shortcuts if global shortcuts are enabled

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINdb2ff13d4fa8: Only trigger mod-only-shortcuts if global shortcuts are enabled (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D2945: Workaround xkbcommon behavior concerning consumed modifiers

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN421824b654a5: Workaround xkbcommon behavior concerning consumed modifiers (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2945?vs=7116=7148

[Differential] [Closed] D2941: Only repeat one key

This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN3bc608939444: Only repeat one key (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2941?vs=7106=7147 REVISION DETAIL

[Differential] [Closed] D2955: Fix scissoring of VBO rendering in multi-screen setup on Wayland

This revision was automatically updated to reflect the committed changes. Closed by commit rKWINff6e042c7f96: Fix scissoring of VBO rendering in multi-screen setup on Wayland (authored by graesslin). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE

Re: Review Request 129101: Port to new plasma-framework API

> On Oct. 6, 2016, 2:58 a.m., Michael Stemle wrote: > > runners/windowedwidgets/windowedwidgetsrunner.cpp, line 111 > > > > > > *Nit-picky:* If it's not a name, and other parts have a name, maybe we > > should

[Differential] [Commented On] D2942: [klipper] Move notification from tray to Klipper

tillschafer added a comment. just a short feedback: tested the patches together with https://phabricator.kde.org/D2954 and everything works as expected REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2942 EMAIL PREFERENCES

[Differential] [Request, 5 lines] D2965: [Logout Greeter] Add QtQuickSettings

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY It's a separate

Re: Review Request 129112: [QtQuickRendererSettings] Fix default to be empty instead of "false"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129112/#review99812 --- Ship it! Ship It! - Marco Martin On Oct. 6, 2016, 1:56

[Differential] [Accepted] D2963: [server] Send key events to all wl_keyboard resources of a client

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rKWAYLAND KWayland BRANCH server-multiple-keyboards REVISION DETAIL https://phabricator.kde.org/D2963 EMAIL PREFERENCES

[Differential] [Accepted] D2960: [shell] Fix non-interactive panelview on non-primary screen

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. Tested on X11, no regressions observed, panels on a second screen still work. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH fix-panel (branched from Plasma/5.8) REVISION DETAIL

[Differential] [Request, 6 lines] D2967: delete containments upon activity deletion

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY after the latest activities refactor, containments weren't deleted anymore upon activity deletion. TEST PLAN

[Differential] [Updated] D2967: delete containments upon activity deletion

mart added a reviewer: ivan. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2967 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, ivan Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

Re: Review Request 129091: Add icons for Fcitx

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/ --- (Updated 十月 6, 2016, 6:03 p.m.) Review request for Plasma. Repository:

[Differential] [Requested Changes To] D2967: delete containments upon activity deletion

davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. > m_desktopContainments.remove(id); should not be here. REPOSITORY rPLASMAWORKSPACE Plasma Workspace

Re: Review Request 129098: Add keyboard icons for kimpanel

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129098/ --- (Updated 十月 6, 2016, 5:56 p.m.) Review request for Plasma. Repository:

Re: Plasma 5.9 Kickoff Meeting

On mercoledì 5 ottobre 2016 14:12:51 CEST Jonathan Riddell wrote: > What was good about 5.8? What would you like to see in 5.9? Come to > the Kickoff meeting to discuss the future of our favourite desktop. > > To schedule the meeting please mark when you're free on this Doodle > poll and I'll

[Differential] [Request, 4 lines] D2970: [shell] Fix crash when moving panel between two monitors

bshah created this revision. bshah added reviewers: Plasma, mart. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When moving panel between two screens there is time when panel is on edge of screen and screenToFollow is

[Differential] [Closed] D2968: Don't control the look of the delegate on completion

This revision was automatically updated to reflect the committed changes. Closed by commit rKIRIGAMI33d03d4920db: Don't control the look of the delegate on completion (authored by apol). REPOSITORY rKIRIGAMI Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2968?vs=7160=7165

[Differential] [Abandoned] D2913: Make the background of the logout screen darker

jsalatas abandoned this revision. jsalatas added a comment. I just tested it in a normal PC (ie not Virtual Machine) with 3D acceleration and the background is indeed blurred as davidedmundson said. So I'm abandoning this, as it seems a very minor issue. REPOSITORY rPLASMAWORKSPACE

Re: Review Request 129091: Add icons for Fcitx

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129091/ --- (Updated 十月 6, 2016, 6:02 p.m.) Review request for Plasma. Changes

[Breeze] [Bug 370216] New: breeze sddm theme could have the password and username field text centered

https://bugs.kde.org/show_bug.cgi?id=370216 Bug ID: 370216 Summary: breeze sddm theme could have the password and username field text centered Product: Breeze Version: 5.8.0 Platform: Archlinux Packages OS:

Re: Review Request 129112: [QtQuickRendererSettings] Fix default to be empty instead of "false"

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129112/ --- (Updated Oct. 6, 2016, 8:03 p.m.) Status -- This change has been

[Differential] [Commented On] D2913: Make the background of the logout screen darker

apol added a comment. FWIW it could still make sense. the text is not super readable sometimes, as it's gray (at least on my system). REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2913 EMAIL PREFERENCES

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/#review99834 --- Ping? - Aleix Pol Gonzalez On Oct. 5, 2016, 4:18 a.m.,

Re: Review Request 129100: Port some few remaining uses of pluginInfo to pluginMetaData

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129100/#review99836 --- Ship it! Ship It! - David Edmundson On Oct. 4, 2016,

Re: Review Request 129102: Don't enforce metadata.desktop, cleanup constructor

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129102/#review99835 --- src/plasma/applet.cpp (lines 96 - 97)

[Differential] [Request, 44 lines] D2972: Allow configuring script's screen edges from the KCM

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY Modify the kwinscreenedges KCM to also list scripts which support screen edge activation

[Differential] [Closed] D2894: Start KDE Cleanups

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEbc1324ceebbd: Start KDE Cleanups (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D2894?vs=7007=7172

[Differential] [Closed] D2877: Use Plasma::PluginLoader to list applets

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEa3b5065d: Use Plasma::PluginLoader to list applets (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Breeze] [Bug 369676] White lockscreen text's readability depends on background

https://bugs.kde.org/show_bug.cgi?id=369676 Christoph Feck changed: What|Removed |Added CC||pas...@dhermilly.dk ---

[Differential] [Closed] D2970: [shell] Fix crash when moving panel between two monitors

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE5cfb957c8799: [shell] Fix crash when moving panel between two monitors (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Changed Subscribers] D2972: Allow configuring script's screen edges from the KCM

graesslin added inline comments. INLINE COMMENTS > main.cpp:95-96 > > + > + > monitorLoad(); nitpick > main.cpp:212 > > +KService::List offers = KServiceTypeTrader::self()->query("KWin/Script", > "[X-KWin-Border-Activate] == true and not (exist [X-KWin-Exclude-Listing]) or >

[Differential] [Closed] D2960: [shell] Fix non-interactive panelview on non-primary screen

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE9c94cd136006: [shell] Fix non-interactive panelview on non-primary screen (authored by bshah). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Request, 6 lines] D2968: Don't control the look of the delegate on completion

apol created this revision. apol added reviewers: Kirigami, mart. Restricted Application added a project: Kirigami. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The index could change at any time TEST PLAN Still works, doesn't fix the dreaded warning REPOSITORY

[Differential] [Updated] D2968: Don't control the look of the delegate on completion

mart added a comment. uuh, but can it change? REPOSITORY rKIRIGAMI Kirigami REVISION DETAIL https://phabricator.kde.org/D2968 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: plasma-devel, apol

[Differential] [Closed] D2942: [klipper] Move notification from tray to Klipper

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE77aaa88eb2a1: [klipper] Move notification from tray to Klipper (authored by graesslin). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D2942: [klipper] Move notification from tray to Klipper

tillschafer added a comment. hmm, another small thing: the timeout of the message is about 15 seconds, which is quite long. This is especially long since you just need a short feedback of an action you are actively doing. I.e. in comparison of a message that pops up asynchronously from your

[Differential] [Request, 2 lines] D2962: [Breeze Window Decoration] Disable size grip for windows without border

broulik created this revision. broulik added reviewers: Breeze, Plasma: Design, Plasma. broulik set the repository for this revision to rBREEZE Breeze. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Nowadays you can

[Differential] [Updated] D2962: [Breeze Window Decoration] Disable size grip for windows without border

broulik updated the test plan for this revision. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D2962 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #breeze, #plasma:_design, #plasma Cc: plasma-devel, lesliezhai,

[Differential] [Request, 78 lines] D2963: [server] Send key events to all wl_keyboard resources of a client

graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This is what Weston does. With this change clients can create multiple

[Differential] [Accepted] D2968: Don't control the look of the delegate on completion

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKIRIGAMI Kirigami BRANCH master REVISION DETAIL https://phabricator.kde.org/D2968 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: apol, #kirigami, mart Cc: