[Differential] [Updated] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-11 Thread bgupta (Boudhayan Gupta)
bgupta removed a commit: rPLASMAWORKSPACEaafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2983 EMAIL PREFERENCES

[Differential] [Request, 54 lines] D3022: [wayland] Support for hideClient in ShellClient

2016-10-11 Thread bshah (Bhushan Shah)
bshah created this revision. bshah added reviewers: Plasma, graesslin. Restricted Application added a project: KWin. Restricted Application added subscribers: kwin, plasma-devel. REVISION SUMMARY This implements the hideClient for ShellClient which was previously not implmented. Also autotest

[Differential] [Closed] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-11 Thread bgupta (Boudhayan Gupta)
bgupta closed this revision. bgupta added a comment. Committed in https://phabricator.kde.org/rPLASMAWORKSPACEaafa20f19c87898a1ff06996ba0fffebdc236ba5: sddm-theme: support configurable solid colour and image backgrounds. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

Re: Review Request 129148: use kwayland for shadows and dialog positioning

2016-10-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129148/ --- (Updated Oct. 11, 2016, 3:24 p.m.) Status -- This change has been

Plasma 5.8.1 is now released

2016-10-11 Thread Jonathan Riddell
Plasma 5.8.1 is now released https://www.kde.org/announcements/plasma-5.8.1.php Jonathan

Re: Review Request 129148: use kwayland for shadows and dialog positioning

2016-10-11 Thread Marco Martin
> On Oct. 11, 2016, 2:58 p.m., Martin Gräßlin wrote: > > src/plasmaquick/CMakeLists.txt, lines 7-11 > > > > > > why are you adding the definition if you have it in config-plasma.h? right, config-plasma.h is for

Re: Review Request 129148: use kwayland for shadows and dialog positioning

2016-10-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129148/#review99939 --- Ship it! Ship It! - Martin Gräßlin On Oct. 11, 2016,

[Differential] [Request, 197 lines] D3024: Remove WaylandDialogFilter

2016-10-11 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY now that KWayland is a framework, it's used directly from Dialog, no need to inject kwayland usage from here

[Differential] [Accepted] D3022: [wayland] Support for hideClient in ShellClient

2016-10-11 Thread Martin Gräßlin
graesslin accepted this revision. This revision is now accepted and ready to land. REPOSITORY rKWIN KWin BRANCH hideclient (branched from master) REVISION DETAIL https://phabricator.kde.org/D3022 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: bshah,

Re: Review Request 129148: use kwayland for shadows and dialog positioning

2016-10-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129148/ --- (Updated Oct. 11, 2016, 3:11 p.m.) Review request for Plasma.

[Differential] [Closed] D3021: restore all panel properties

2016-10-11 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEaea33cddb547: restore all panel properties (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3021?vs=7305=7309

Re: Review Request 129148: use kwayland for shadows and dialog positioning

2016-10-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129148/#review99937 --- src/plasmaquick/CMakeLists.txt (lines 7 - 11)

[Differential] [Closed] D3022: [wayland] Support for hideClient in ShellClient

2016-10-11 Thread bshah (Bhushan Shah)
This revision was automatically updated to reflect the committed changes. Closed by commit rKWIN7843974a8a5b: [wayland] Support for hideClient in ShellClient (authored by bshah). REPOSITORY rKWIN KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3022?vs=7306=7307 REVISION DETAIL

[Differential] [Updated] D2983: Support solid colour and image backgrounds with a configurable background colour in the SDDM theme

2016-10-11 Thread bgupta (Boudhayan Gupta)
bgupta added a commit: rPLASMAWORKSPACEaafa20f19c87: sddm-theme: support configurable solid colour and image backgrounds. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2983 EMAIL PREFERENCES

Re: Review Request 129148: use kwayland for shadows and dialog positioning

2016-10-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129148/ --- (Updated Oct. 11, 2016, 2:44 p.m.) Review request for Plasma.

[Differential] [Accepted] D3024: Remove WaylandDialogFilter

2016-10-11 Thread Martin Gräßlin
graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added a comment. This revision is now accepted and ready to land. kill it, kill it, kill it. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/nofilter REVISION DETAIL

[Differential] [Accepted] D3021: restore all panel properties

2016-10-11 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/panelrestore REVISION DETAIL https://phabricator.kde.org/D3021 EMAIL PREFERENCES

[Differential] [Request, 6 lines] D3023: Set icon to wayland if desktop file is not found

2016-10-11 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY For X windows KWin uses the generic X icon if no icon is found.

[Differential] [Closed] D3024: Remove WaylandDialogFilter

2016-10-11 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE092c2c7cf734: Remove WaylandDialogFilter (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3024?vs=7311=7312

Review Request 129148: use kwayland for shadows and dialog positioning

2016-10-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129148/ --- Review request for Plasma. Repository: plasma-framework Description

Review Request 129150: Use less deprecated API

2016-10-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129150/ --- Review request for KDE Frameworks and Plasma. Repository:

[Differential] [Request, 27 lines] D3021: restore all panel properties

2016-10-11 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY restore the missing panel properties: alignment minimum length maximum length offset also, allow non

[Plasma Workspace Wallpapers] [Bug 370464] New: On reboot desktop wallpaper settings are forgotten

2016-10-11 Thread davidblunkett via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370464 Bug ID: 370464 Summary: On reboot desktop wallpaper settings are forgotten Product: Plasma Workspace Wallpapers Version: 5.5.5 Platform: Kubuntu Packages OS: Linux

Re: System Settings - Network -> Connectivity

2016-10-11 Thread Jan Grulich
On úterý 11. října 2016 12:08:18 CEST Thomas Pfeiffer wrote: > > Hi, > > > > just a heads up, I started working (again) on a new KCM for network > > configuration, this time I decided to make it simple, just implement it > > similar to the editor, with just a bit nicer UI. We can always add > >

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

2016-10-11 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/ --- (Updated Oct. 11, 2016, 1:33 p.m.) Status -- This change has been

[Differential] [Changed Subscribers] D3020: Set window state on QEvent::PlatformSurface on Qt 5.5+.

2016-10-11 Thread apol (Aleix Pol Gonzalez)
apol added inline comments. INLINE COMMENTS > dashboardwindow.cpp:126 > KWindowSystem::setState(winId(), NET::SkipTaskbar | NET::SkipPager); > +#if (QT_VERSION > QT_VERSION_CHECK(5, 5, 0)) > +} else if (event->type() == QEvent::PlatformSurface) { I don't think the version check is

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

2016-10-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/#review99935 --- Ship it! Ship It! - Marco Martin On Oct. 10, 2016,

[Differential] [Closed] D3017: enable all preview plugins

2016-10-11 Thread mart (Marco Martin)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEc05f2fc2171e: enable all preview plugins (authored by mart). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3017?vs=7296=7302

Re: Review Request 129148: use kwayland for shadows and dialog positioning

2016-10-11 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129148/#review99931 --- CMakeLists.txt (line 68)

[Differential] [Updated] D3019: [kstyle] Implement window moving on Wayland

2016-10-11 Thread Martin Gräßlin
graesslin added dependencies: D3018: [client] Add methods to get ShellSurface from a QWindow, D3016: [server] Send pointer events to all wl_pointer resources of a client. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3019 EMAIL PREFERENCES

[Differential] [Updated] D3018: [client] Add methods to get ShellSurface from a QWindow

2016-10-11 Thread Martin Gräßlin
graesslin added a dependent revision: D3019: [kstyle] Implement window moving on Wayland. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D3018 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc:

[Differential] [Commented On] D3005: Library support for per-activity pinned tasks

2016-10-11 Thread hein (Eike Hein)
hein added a comment. Yeah this looks cleaner now :) REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3005 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ivan, #plasma, hein Cc: plasma-devel, lesliezhai,

[Differential] [Updated] D3016: [server] Send pointer events to all wl_pointer resources of a client

2016-10-11 Thread Martin Gräßlin
graesslin added a dependent revision: D3019: [kstyle] Implement window moving on Wayland. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D3016 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland Cc:

[Differential] [Updated] D3019: [kstyle] Implement window moving on Wayland

2016-10-11 Thread Martin Gräßlin
graesslin added a reviewer: hpereiradacosta. REPOSITORY rBREEZE Breeze REVISION DETAIL https://phabricator.kde.org/D3019 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, #plasma_on_wayland, hpereiradacosta Cc: plasma-devel, lesliezhai,

[Differential] [Request, 200 lines] D3019: [kstyle] Implement window moving on Wayland

2016-10-11 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY So far breeze hard disabled the window moving on Wayland. With this change the

Re: System Settings - Network -> Connectivity

2016-10-11 Thread Thomas Pfeiffer
Hi, just a heads up, I started working (again) on a new KCM for network configuration, this time I decided to make it simple, just implement it similar to the editor, with just a bit nicer UI. We can always add features and changes in future, but right now I think that the most important part

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 505 - Fixed!

2016-10-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/505/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:46:18 + Build duration: 20 min CHANGE SET No changes JUNIT RESULTS Name:

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 505 - Fixed!

2016-10-11 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/505/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:46:18 + Build duration: 20 min CHANGE SET No changes JUNIT RESULTS Name:

[Differential] [Request, 10 lines] D3020: Set window state on QEvent::PlatformSurface on Qt 5.5+.

2016-10-11 Thread hein (Eike Hein)
hein created this revision. hein added reviewers: Plasma, mart. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Identical to code in Plasma::Dialog, also needed here. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8

[Differential] [Accepted] D3020: Set window state on QEvent::PlatformSurface on Qt 5.5+.

2016-10-11 Thread bshah (Bhushan Shah)
bshah accepted this revision. bshah added a reviewer: bshah. bshah added a comment. This revision is now accepted and ready to land. +1 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH Plasma/5.8 REVISION DETAIL https://phabricator.kde.org/D3020 EMAIL PREFERENCES

[Differential] [Closed] D3020: Set window state on QEvent::PlatformSurface on Qt 5.5+.

2016-10-11 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP36e34538bc40: Set window state on QEvent::PlatformSurface on Qt 5.5+. (authored by hein). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Breeze] [Bug 370484] New: Lockscreen Breeze theme doesn't have keyboard layout indicator

2016-10-11 Thread Vytautas via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370484 Bug ID: 370484 Summary: Lockscreen Breeze theme doesn't have keyboard layout indicator Product: Breeze Version: 5.8.0 Platform: Neon Packages OS: Linux

Re: Review Request 128761: Fix crash on exit

2016-10-11 Thread Peter Wu
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128761/ --- (Updated Oct. 11, 2016, 6:34 p.m.) Status -- This change has been

[Breeze] [Bug 370484] Lockscreen Breeze theme doesn't have keyboard layout indicator

2016-10-11 Thread Martin Gräßlin via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=370484 Martin Gräßlin changed: What|Removed |Added Status|UNCONFIRMED |RESOLVED

[Differential] [Commented On] D2981: Removes preferred definition so a new wallpaper is selected.

2016-10-11 Thread antlarr (Antonio Larrosa Jimenez)
antlarr added inline comments. INLINE COMMENTS > mart wrote in image.cpp:245 > shouldn't then "preferred" just not be defined anymore in the wallpaper > package structure then? Sorry, I don't get your comment. That's why I remove it, so that "preferred" is not defined anymore and the next

[Differential] [Request, 20 lines] D3015: Fix shortcut triggering with shift+letter

2016-10-11 Thread Martin Gräßlin
graesslin created this revision. graesslin added reviewers: KWin, Plasma on Wayland. Restricted Application added subscribers: kwin, plasma-devel. Restricted Application added projects: Plasma on Wayland, KWin. REVISION SUMMARY A shortcut with e.g. shift+w could not be triggered as shift is

[Differential] [Request, 117 lines] D3016: [server] Send pointer events to all wl_pointer resources of a client

2016-10-11 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This is what Weston does. With this change clients can create multiple

Re: System Settings - Network -> Connectivity

2016-10-11 Thread Jan Grulich
On úterý 27. září 2016 13:03:09 CEST Marco Martin wrote: > On Tuesday 27 September 2016, David Edmundson wrote: > > On Mon, Sep 26, 2016 at 10:01 PM, kainz.a wrote: > > > After some review of the existing System Setting overview page I come up > > > that the subgroups for each

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

2016-10-11 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/#review99921 --- Ship it! this version seems to work well - Marco Martin

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

2016-10-11 Thread Marco Martin
> On Oct. 11, 2016, 8:52 a.m., Kai Uwe Broulik wrote: > > I have a FolderView applet in my panel (pointing to Downloads folder) and > > it is blank with this patch now. ok, so please don't push this yet - Marco --- This is an

[Differential] [Request, 3 lines] D3017: enable all preview plugins

2016-10-11 Thread mart (Marco Martin)
mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY try to preview everything that's found in the list. by default not all image types are enabled, like svg,

Re: Review Request 129143: Fix loading plasmoids by absolute path, fixes configmodeltest

2016-10-11 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129143/#review99923 --- I have a FolderView applet in my panel (pointing to

[Differential] [Closed] D3012: [DrKonqi] Update URL to Wiki page on how to create useful bug reports

2016-10-11 Thread broulik (Kai Uwe Broulik)
This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACEb9a75d39cf86: [DrKonqi] Update URL to Wiki page on how to create useful bug reports (authored by broulik). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

Re: Review Request 128526: Make BINARY_ICONS_RESOURCE ON by default

2016-10-11 Thread Jarosław Staniek
> On July 27, 2016, 2:01 p.m., Jarosław Staniek wrote: > > Update: the script of build.kde.org sets BINARY_ICONS_RESOURCE to ON, > > nevertheless everyone who compiles breeze-icons needs to know it's needed. > > It's hard to say not buiulding the rcc files gives any important > >

[Differential] [Accepted] D3017: enable all preview plugins

2016-10-11 Thread davidedmundson (David Edmundson)
davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH phab/svgPreview REVISION DETAIL https://phabricator.kde.org/D3017 EMAIL PREFERENCES

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 504 - Failure!

2016-10-11 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/504/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 11 Oct 2016 09:07:23 + Build duration: 14 min CHANGE SET Revision

[Differential] [Request, 99 lines] D3018: [client] Add methods to get ShellSurface from a QWindow

2016-10-11 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma on Wayland. Restricted Application added a subscriber: plasma-devel. Restricted Application added a project: Plasma on Wayland. REVISION SUMMARY This is similar to what already exists for Surface. With this methods it's