[Differential] [Updated, 180 lines] D3603: Option to show percentage charge in the icon

mart updated this revision to Diff 8788. mart added a comment. - correct copyright REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3603?vs=8787=8788 BRANCH phab/batterypercent REVISION DETAIL https://phabricator.kde.org/D3603 AFFECTED FILES

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

mart added a comment. eew, sorry, that canvas thing was from an old experiment i did for a possible alternative graphics, which i forgot to kill ;) INLINE COMMENTS > broulik wrote in main.xml:11 > I think this could even be the default? not sure it's pretty enough for default (yet?), in

[Differential] [Accepted] D3590: [libinput] Sane unset behaviour of scroll method and acceleration profile properties

graesslin accepted this revision. graesslin added a reviewer: graesslin. graesslin added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > device.cpp:363-364 > > -void Device::setLmrTapButtonMap(bool set) { > +void Device::setLmrTapButtonMap(bool set) > +{ >

[Differential] [Commented On] D3603: Option to show percentage charge in the icon

broulik added a comment. Nifty. That I haven't thought of that kind of placement before. I always wanted some crappy overlay like we had before. Can you please check again with opacity mask instead of just overlaying a Rectangle. Also, what's up with the Canvas thing? INLINE COMMENTS

[Differential] [Request, 763 lines] D3598: rework kscreen's OSD logic

sebas created this revision. sebas added a reviewer: Plasma. sebas added a subscriber: davidedmundson. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This changeset moves the various OSDs used in kscreen (output

[Differential] [Request, 181 lines] D3603: Option to show percentage charge in the icon

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY add an option to show a text label with the percentage value in the battery icon. text will be shown

[Differential] [Commented On] D3488: [platforms/wayland] Use a ConfinedPointer if available

graesslin added inline comments. INLINE COMMENTS > sebas wrote in wayland_backend.cpp:574 > Plasma perhaps, instead of KDE? It's only the window title of the nested compositor. Given that KDE is the producer and Wayland Compositor is the product I think KDE Wayland Compositor is correct.

[Differential] [Commented On] D3488: [platforms/wayland] Use a ConfinedPointer if available

sebas added inline comments. INLINE COMMENTS > graesslin wrote in wayland_backend.cpp:574 > It's only the window title of the nested compositor. Given that KDE is the > producer and Wayland Compositor is the product I think KDE Wayland Compositor > is correct. Otherwise KDE Plasma Wayland

[Differential] [Commented On] D3598: rework kscreen's OSD logic

sebas added inline comments. INLINE COMMENTS > broulik wrote in osd.cpp:120 > Compare with QL1S - in case you have KWindowSystem you can ask it We only have KWindowSystem implicitly, I'm going with the QGuiApplication::platformName() comparison (changed to QL1S). > broulik wrote in

[Differential] [Updated, 820 lines] D3598: rework kscreen's OSD logic

sebas updated this revision to Diff 8796. sebas marked 15 inline comments as done. sebas added a comment. - improve osd test app - call the dbus service from the test app - also register the service - Addressing Kai's review, part 1 REPOSITORY R104 KScreen CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3559: [Notification Popup] Clear notification data after popup closed

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3559 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Request, 14 lines] D3594: [Notifications] Never manually hide() the NotificationPopup

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to R120 Plasma Workspace. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise the positioner will get

[Differential] [Closed] D3559: [Notification Popup] Clear notification data after popup closed

This revision was automatically updated to reflect the committed changes. Closed by commit R120:76baa59dea73: [Notification Popup] Clear notification data after popup closed (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3560: [Notifications] Tighten layout

This revision was automatically updated to reflect the committed changes. Closed by commit R120:6c7a2a65c1b7: [Notifications] Tighten layout (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3560?vs=8677=8769#toc REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST

Re: KDE 4 vs 5, regional settings and dolphin

Christoph Feck wrote: > On 04.12.2016 11:17, René J.V. Bertin wrote: >> Under KDE4, the translations KCM had detailed settings for just about every >> aspect > > See bug 340982. Thanks, I suppose I could have found that ticket myself ... > customizations, but progress is slow, so no code has

[Differential] [Accepted] D3594: [Notifications] Never manually hide() the NotificationPopup

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3594 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

Minutes Monday Plasma Meeting

Plasma Meeting minutes 5-12-2016 Present: notmart, romangg, kbroulik, sebas, Riddell romangg: - worked on touchpad kcm and also did some stuff in kwin libinput backend. - kwin stuff: https://phabricator.kde.org/D3590 notmart: * fixed flicker of current thumbnail on startup of

[Differential] [Closed] D3591: [qrc] update ressource file

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f88c6a7e2152: [qrc] update ressource file (authored by bearsh). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3591?vs=8764=8771 REVISION DETAIL

[Differential] [Accepted] D3589: Add a notication service to inhibit certain notifications based on metadata

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3589 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson,

[Differential] [Updated] D3588: Remove inexistent file references from kirigami.qrc

mart added a comment. In https://phabricator.kde.org/D3588#67023, @bearsh wrote: > running `scripts/gen_qml_qrc.sh` produces a different diff. the question is now, are all qml files (the script simply includes all available files) required? yes, all the qml files are required.

[Differential] [Accepted] D3591: [qrc] update ressource file

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R169 Kirigami BRANCH kirigami2 (branched from mart/Kirigami2) REVISION DETAIL https://phabricator.kde.org/D3591 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 1 line] D3593: [Folder View] Clear hover state when mouse leaves view

broulik created this revision. broulik added reviewers: Plasma, hein. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This ensures there isn't a stray

[Differential] [Accepted] D3572: systemtray: Don't propagate unhandled wheel events

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. ok for this revision (in 5.8 as well) even tough it kinda masks the actual problem, that is the wheel containmentactions plugin sometimes loaded in still unknown

[Differential] [Accepted] D3560: [Notifications] Tighten layout

mart accepted this revision. mart added a reviewer: mart. mart added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > NotificationItem.qml:156 > > -spacing: units.smallSpacing > +spacing: units.smallSpacing / 2 > you should still make sure

[Differential] [Commented On] D3578: [RFC] Implement drag from free space also for QtQuickControls

mart added a comment. big +1 on this. to make it build on kde4, even if it's not pretty, could the method declarations be ifdeffed? implementations are mostly the same REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D3578 EMAIL PREFERENCES

[Differential] [Accepted] D3051: [applets/notification] Add nullptr check

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. So, let's merge this? It's small enough... REPOSITORY R120 Plasma Workspace BRANCH notification-add-popup-null REVISION DETAIL

[Differential] [Closed] D3594: [Notifications] Never manually hide() the NotificationPopup

This revision was automatically updated to reflect the committed changes. Closed by commit R120:b97fdfa293dd: [Notifications] Never manually hide() the NotificationPopup (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D3506: Implement support for pointer constraints

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Smallish comments, otherwise looks good to me. INLINE COMMENTS > input.cpp:417 > +if (event->type() == QEvent::KeyPress) { > +// is

[Differential] [Request, 26 lines] D3596: Block Network manager notifications when the popup is visible

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY If we have the notification plasmoid visible and expanded we don't need to see notifications

Review Request 129615: (WIP) QtCurve-specific XCB client messages

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129615/ --- Review request for Plasma and Yichao Yu. Repository: qtcurve

[Differential] [Accepted] D3488: [platforms/wayland] Use a ConfinedPointer if available

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. Consider my comment, but up to you. Patch looks good otherwise. INLINE COMMENTS > wayland_backend.cpp:574 > +const QString title = i18nc("Title of nested

[Differential] [Accepted] D3596: Block Network manager notifications when the popup is visible

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D3596 EMAIL PREFERENCES