[Differential] [Changed Subscribers] D4831: Add new component for the greyed out labels in Item Delegates.

broulik added inline comments. INLINE COMMENTS > DescriptiveLabel.qml:41 > + * properties, methods and signals. > + */ > +Label { @inherits ? > DescriptiveLabel.qml:48 > + * property should be set to true when the label is being interacted > with. > + * The default is false > + */

[Differential] [Updated, 29 lines] D4836: Indicate that a port is unavailable

drosca updated this revision to Diff 11933. drosca added a comment. Use same wording as pavucontrol - unavailable only for internal devices, unplugged otherwise REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4836?vs=11931=11933 BRANCH

[Differential] [Accepted] D4689: IconItem: Add roundToIconSize property

sebas accepted this revision. sebas added a comment. This revision is now accepted and ready to land. Almost good, you can add the signalspy and then ship it from my side. INLINE COMMENTS > iconitemtest.cpp:526 > + > +item->setProperty("roundToIconSize", false); > + Might as well check

[Differential] [Changed Subscribers] D4830: Adjust plasma-desktop to the new fallback prefixes

broulik added inline comments. INLINE COMMENTS > TaskProgressOverlay.qml:46 > imagePath: "widgets/tasks" > -prefix: calculatePrefix() > -onRepaintNeeded: prefix = calculatePrefix() > - > -function calculatePrefix() { > -var prefix

[Differential] [Closed] D4689: IconItem: Add roundToIconSize property

This revision was automatically updated to reflect the committed changes. Closed by commit R242:af2b27d1b89b: IconItem: Add roundToIconSize property (authored by drosca). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4689?vs=11897=11934#toc REPOSITORY R242 Plasma Framework (Library)

[Differential] [Commented On] D4821: Implement manual focus on click

fvogt added a comment. I finally figured the issue out. Newly appearing windows try to steal focus, which makes m_focusedLockWindow actually wrong. That explains why it works only for some and only for some setups... I'll try to fix that by adding

[KDE4] what component does the screenlocking?

Hi, Sorry for cross-posting, I'm hoping it'll increase my chances of reaching someone who has an answer to the following. After upgrading my hardware to an N3150-based notebook, my KUbuntu 14.04 install has developed an annoying quirk. From time to time, the screensaver fails to start (= I

[Differential] [Accepted] D4833: Only activate kded Appmenu signals if menus are in the window decoration

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4833 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma,

[Differential] [Accepted] D4832: Open the correct submenu in kwin menu when activating the Appmenu with a shortcut

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4832 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma,

[Differential] [Commented On] D4836: Indicate that a port is unavailable

broulik added a comment. Would it make sense to disable (in the ContextMenu) and/or filter out those ports instead? Or is this so you can configure it to play on headphones and once you plug them in it will work? Not sure about the "unavailable" prefix. INLINE COMMENTS >

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

broulik added a comment. I also only get this non-descript square – the button doesn't neven have a tooltip F2663529: Screenshot_20170228_110118.png REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4751

[Differential] [Request, 23 lines] D4836: Indicate that a port is unavailable

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Show "portname (unavailable)" in port list if a port is not available. REPOSITORY R115 Plasma Audio Volume Applet BRANCH

[Differential] [Commented On] D4831: Add new component for the greyed out labels in Item Delegates.

sebas added a comment. I like it. If kbroulik is happy, consider that a +1 from me, too. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4831 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson,

[Differential] [Commented On] D4836: Indicate that a port is unavailable

drosca added a comment. > Would it make sense to disable (in the ContextMenu) and/or filter out those ports instead? Or is this so you can configure it to play on headphones and once you plug them in it will work? I don't think we should filter/disable it, because if you plug it in, it

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 640 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/640/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 09:09:26 + Build duration: 6 min 17 sec CHANGE SET Revision

[Differential] [Closed] D4762: [SliderStyle] Allow providing a "hint-handle-size" element

This revision was automatically updated to reflect the committed changes. Closed by commit R242:6b70fd983b3c: [SliderStyle] Allow providing a "hint-handle-size" element (authored by broulik). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

Scaling and multiple monitors

Hello awesome plasma devs! I've just upgraded to Kubuntu 17.04 Beta 1, with Plasma 5.9.2, and many of my scaling and multiple monitor issues havebeen solved. So, Thank you for that!! I still have some small issues, and I'd like to ask for help in identifying if they are plasma, kwin or

Re: Scaling and multiple monitors

I kept playing around with the settings, trying to scale things to a similar size on all screens and Scaling from System Settings, has 3 results: * Huge text small icons * tiny text huge icons * huge text, huge icons I can see no way of reseting the whole display and scaling set-up. Please

Re: Scaling and multiple monitors

I kept playing around with the settings, trying to scale things to a similar size on all screens and Scaling from System Settings, has 3 results: * Huge text small icons * tiny text huge icons * huge text, huge icons I can see no way of reseting the whole display and scaling set-up. Please

Re: Merging strings

On Monday 27 February 2017, Ivan Čukić wrote: > Unfortunately, not sure what to do with this, one string is a prefix > for the spin box, and the other is the suffix. See > plasma-desktop/kcms/activities/PrivacyTab.cpp:215 > > What does the UI look like if it is set to a space or even better an >

[Differential] [Request, 5 lines] D4837: Applet: Make volume indicator icon bigger

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY There were complaints that the icon is too small, so make it bigger. REPOSITORY R115 Plasma Audio Volume Applet BRANCH

[Differential] [Updated] D4838: [Notifications] Add context menu for thumbnail

subdiff added subscribers: colomar, subdiff. subdiff added a comment. That's an awesome idea Kai! I normally only want to open the containing folder and not the screenshot directly, so I was really missing this functionality. Would it be a good idea to not make this as a right click context

[Differential] [Commented On] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

hein added a comment. The next step is me reviewing the patch :) REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, davidedmundson, hein, broulik Cc: plasma-devel, progwolff, lesliezhai,

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 84 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/84/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 12:33:40 + Build duration: 6 min 8 sec CHANGE SET Revision

[Differential] [Commented On] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

hein added a comment. Thanks, landed! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, davidedmundson, hein, broulik Cc: plasma-devel, progwolff, lesliezhai,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 642 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/642/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 13:07:14 + Build duration: 6 min 2 sec CHANGE SET Revision

Jenkins-kde-ci: khotkeys Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 15 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/khotkeys%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/15/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 13:11:03 + Build duration: 8 min 13 sec CHANGE SET Revision

[Differential] [Request, 2 lines] D4840: Preview Centered wallpaper as PreserveAspectFit

davidedmundson created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Currently the we create previews with QPixmapItem from KDeclrarative and when a wallpaper is set to centered sets it to an enum value

[Differential] [Request, 66 lines] D4838: [Notifications] Add context menu for thumbnail

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Since it represents a file, right clicking it should provide similar options found in a file manager. This allows to open the application

[Differential] [Updated, 2,978 lines] D4508: Plasma controls based on QtQuickControls2

mart updated this revision to Diff 11948. mart marked 2 inline comments as done. mart added a comment. - don't install files that shouldn't REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11630=11948 BRANCH arcpatch-D4508

[Differential] [Requested Changes] D4803: Basic keyboard support + fixes to QuickShare plasmoid

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. almost there INLINE COMMENTS > AlternativesView.qml:101 > delegate: stack.delegate > +highlight: Rectangle { > +radius: 5 this should be a

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

davidedmundson added inline comments. INLINE COMMENTS > mart wrote in Label.qml:27 > the reason for the padding is that it makes it correctly vertically aligned > with other widgets both in a Row and a RowLayout. > without this default height, every label should be manually vertically >

[Differential] [Updated, 77 lines] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

ppalaga updated this revision to Diff 11952. ppalaga added a comment. > One more request, would you mind rebasing it against current master? (Doesn't apply cleanly currently.) I rebased and updated the diff, but I had no to time to run the rebased code. I hope that you or somebody else

Jenkins-kde-ci: plasma-tests Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 6 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-tests%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/6/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 12:34:56 + Build duration: 59 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 85 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 12:35:16 + Build duration: 6 min 49 sec CHANGE SET Revision

[Differential] [Closed] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

This revision was automatically updated to reflect the committed changes. Closed by commit R119:26b92df48a6a: Task Manager: Make the icon size configurable for task buttons in a vertical… (authored by ppalaga, committed by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Changed Subscribers] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

broulik added inline comments. INLINE COMMENTS > ShareDialog.qml:54 > onClicked: view.createJob(index) > +Keys.onReturnPressed: view.createJob(index) > +Keys.onEscapePressed: window.hide() You should also do `Keys.onEnterPressed` (the Enter key

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

mart added a comment. i don't think the panel controller does that, but would be easy to do so? (in the panel containment, when isuserconfiguring proeprty changes) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4842 EMAIL PREFERENCES

[Differential] [Request, 6 lines] D4842: [System Tray] Listen to external collapse

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When plasmoid.expanded = false is done, hide the popup. This is done by the panelcontroller to ensure we don't manipulate the panel with

[Differential] [Updated, 2,977 lines] D4508: Plasma controls based on QtQuickControls2

mart updated this revision to Diff 11960. mart added a comment. - remove custom height REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4508?vs=11948=11960 BRANCH arcpatch-D4508 REVISION DETAIL https://phabricator.kde.org/D4508

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in Label.qml:27 > It probably made sense when it was written, but your comments about layouts > is outdated. > > No manual changes are needed. > > try: > https://paste.kde.org/pgi2ui6e3 > > If it was a problem we'd be seeing

[Differential] [Request, 5 lines] D4843: PulseObject: Also use "device.icon_name" for icon

drosca created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Opened mpv from konsole which for some reason had application.icon_name="kded5" + media.icon_name="mpv" and it correctly shows mpv icon now

[Differential] [Updated] D4843: PulseObject: Also use "media.icon_name" for icon

drosca retitled this revision from "PulseObject: Also use "device.icon_name" for icon" to "PulseObject: Also use "media.icon_name" for icon". REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4843 EMAIL PREFERENCES

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. > Just as well or as badly as a regular "Open" button. If in this scenario you hide the Open button because it has no valid target, then of course there would be no split Open button, either. So, how can I access the menu options for the invidiaual files, here?

[kio-extras] [Bug 376577] filenamesearch crashes when started from root folder

https://bugs.kde.org/show_bug.cgi?id=376577 --- Comment #8 from Alex --- Created attachment 104275 --> https://bugs.kde.org/attachment.cgi?id=104275=edit from console: KDE_SLABE_DEBUG_WAIT=dolphin kdeinit5 -- You are receiving this mail because: You are the assignee for the

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. > You don't have that in a file manager, either, and this thing represents a file. A file manager has a menu bar, however, so the context menu is never the only means to execute an action. I don't see how turning the Open button into a split button would

Re: Merging strings

It would be nice if we had examples of these strings in Hungarian - if the only 'problem' is that an empty string looks strange, then we don't have a problem - it does not look strange as far as I'm concerned. If the problem is bigger, then putting everything into the spinbox might work, although

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

broulik added a comment. Hold on, I didn't properly test this. It closes because of the controller window gaining focus, my idea was to also have it close when the pin is checked which this patch doesn't fix. REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Differential] [Commented On] D4842: [System Tray] Listen to external collapse

broulik added a comment. Of course I meant the code in panel containment, but here it does expanded = false and that's what I wanted to listen to :) Plasmoid.onUserConfiguringChanged: { ... if (plasmoid.userConfiguring) { for (var i = 0; i <

[Differential] [Closed] D4833: Only activate kded Appmenu signals if menus are in the window decoration

This revision was automatically updated to reflect the committed changes. Closed by commit R120:907296e8d30b: Only activate kded Appmenu signals if menus are in the window decoration (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Closed] D4832: Open the correct submenu in kwin menu when activating the Appmenu with a shortcut

This revision was automatically updated to reflect the committed changes. Closed by commit R120:9343bc2bb835: Open the correct submenu in kwin menu when activating the Appmenu with a… (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Updated, 33 lines] D4830: Adjust plasma-desktop to the new fallback prefixes

davidedmundson updated this revision to Diff 11958. davidedmundson added a comment. Fixed a stupid mistake REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4830?vs=11911=11958 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4830

Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 85 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/85/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 14:08:38 + Build duration: 5 min 37 sec CHANGE SET Revision

[Differential] [Updated] D4830: Adjust plasma-desktop to the new fallback prefixes

davidedmundson marked an inline comment as done. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4830 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma Cc: broulik, plasma-devel, progwolff, lesliezhai,

[Differential] [Commented On] D4830: Adjust plasma-desktop to the new fallback prefixes

broulik added inline comments. INLINE COMMENTS > TaskProgressOverlay.qml:46 > imagePath: "widgets/tasks" > -prefix: calculatePrefix() > -onRepaintNeeded: prefix = calculatePrefix() > - > -function calculatePrefix() { > -var prefix

[Differential] [Accepted] D4840: Preview Centered wallpaper as PreserveAspectFit

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4840 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: davidedmundson, #plasma,

Re: [KDE4] what component does the screenlocking?

Am 2017-02-28 10:20, schrieb René J.V. Bertin: What component(s) might be involved? Who's responsible for the screensaver and screen/session locking? Is there a way to get an on-screen keyboard in the session unlock screen? As you should be aware of: kde4 has been unmaintained for years and is

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. > A file manager has a menu bar, however, so the context menu is never the only means to execute an action. Dolphin does not by default. I don't see an "Open" or "Open With" action anywhere in its menus, neither the file actions (compress, activities, send to,

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#90994, @broulik wrote: > > A file manager has a menu bar, however, so the context menu is never the only means to execute an action. > > Dolphin does not by default. I don't see an "Open" or "Open With" action anywhere in

Plasma 5.9.3

Plasma 5.9.3 is now released https://www.kde.org/announcements/plasma-5.9.3.php Tars are at a temporary location due to a server upgrade http://weegie.edinburghlinux.co.uk/~jr/tmp/stable/plasma/5.9.3/ Jonathan

[Differential] [Updated] D4838: [Notifications] Add context menu for thumbnail

broulik edited the test plan for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #vdg Cc: plasma-devel, progwolff, lesliezhai,

[Differential] [Accepted] D4837: Applet: Make volume indicator icon bigger

subdiff accepted this revision. subdiff added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > ListItemBase.qml:123 > +roundToIconSize: false > +Layout.preferredWidth: Math.round(slider.height * > 0.95) > +

[Differential] [Updated, 83 lines] D4838: [Notifications] Add context menu for thumbnail

broulik updated this revision to Diff 11939. broulik edited the test plan for this revision. broulik added a comment. - Add "Copy" action REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4838?vs=11937=11939 REVISION DETAIL

[Differential] [Commented On] D4751: Button and Context Menu to Mute, Set Default Sink/Source, Active Port

subdiff added a comment. Yes, today it's on my system too small as well (as @Zren described it already earlier). I'll investigate what's the reason and try to fix it in a new diff. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4751 EMAIL

[Differential] [Updated] D4739: make sure the cancel action is last

mart marked an inline comment as done. mart added inline comments. INLINE COMMENTS > dfaure wrote in dropjob.h:38 > Not a good enough reason to have it in the public header (which doesn't use > it anywhere), you can move that fwd decl to the .cpp file. done REPOSITORY R241 KIO REVISION

[Differential] [Accepted] D4739: make sure the cancel action is last

dfaure accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO BRANCH arcpatch-D4739 REVISION DETAIL https://phabricator.kde.org/D4739 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma, #frameworks,

[Differential] [Updated, 104 lines] D4739: make sure the cancel action is last

mart updated this revision to Diff 11942. mart added a comment. remove dropmenu declaration from public header REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4739?vs=11682=11942 BRANCH arcpatch-D4739 REVISION DETAIL https://phabricator.kde.org/D4739

[Differential] [Accepted] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Patch looks good. Do you have a developer account to commit it or should I do it for you? REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES

[Differential] [Accepted] D4707: move setImagePath logic into updateFrameData()

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4707 REVISION DETAIL https://phabricator.kde.org/D4707 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Closed] D4707: move setImagePath logic into updateFrameData()

This revision was automatically updated to reflect the committed changes. Closed by commit R242:2b3e8dfe866a: move setImagePath logic into updateFrameData() (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4707?vs=11632=11949#toc REPOSITORY R242 Plasma Framework

[Differential] [Accepted] D4805: Basic keyboard support + fixes to QuickShare plasmoid: Plasma-addons side patch

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D4805 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: yuenlim, #plasma, apol, mart Cc: plasma-devel,

[Differential] [Updated] D4739: make sure the cancel action is last

mart marked 4 inline comments as done. mart added inline comments. INLINE COMMENTS > dfaure wrote in dropjob.h:38 > still here? used for class KIO::DropMenu : public QMenu in dropjob.cpp, doesn't compile otherwise REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D4739

[kio-extras] [Bug 376344] cant write to smb shares which has write access

https://bugs.kde.org/show_bug.cgi?id=376344 --- Comment #3 from Elvis Angelaccio --- It looks like samba doesn't set write permission to the root folder: kio-extras/smb/kio_smb_browser.cpp has two occurrences of: udsentry.insert(KIO::UDSEntry::UDS_ACCESS, (S_IRUSR |

[Differential] [Commented On] D4837: Applet: Make volume indicator icon bigger

drosca added inline comments. INLINE COMMENTS > subdiff wrote in ListItemBase.qml:123 > Ok, ship it. To still easily distinguish the two icons we could place the > sound lines on the left side of the microphone and not on the right side like > for the speaker. @andreask, could you take a look

[Differential] [Updated] D4838: [Notifications] Add context menu for thumbnail

broulik added a comment. > which makes sense to me because not every user will know about the possibility to do a right click. You don't have that in a file manager, either, and this thing represents a file. Even more so if there's multiple files, they'll show up as square items. I

[Differential] [Updated, 29 lines] D4821: Implement manual focus on click

fvogt updated this revision to Diff 11941. fvogt added a comment. Newly created windows do not steal focus anymore Needs a quick test that it does not break wayland (e.g. no focus at all) REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE

[Differential] [Requested Review] D4821: Implement manual focus on click

fvogt requested review of this revision. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D4821 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: fvogt, broulik, #plasma, graesslin Cc: plasma-devel, progwolff, lesliezhai,

[Differential] [Accepted] D4831: Add new component for the greyed out labels in Item Delegates.

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Nice. Note Kicker has some of those greyed out labels IIRC. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4831 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D4837: Applet: Make volume indicator icon bigger

subdiff added a subscriber: andreask. subdiff added inline comments. INLINE COMMENTS > drosca wrote in ListItemBase.qml:123 > Because `slider.height` is already too big (it's like half of the main > device/app icon size). > > We should change the microphone-sensitivity icons to look same as

[Differential] [Commented On] D4707: move setImagePath logic into updateFrameData()

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in framesvg.cpp:804 > I don't understand this and the FrameData part of this change. > > q->imagePath() will still always be correct as before, you still set that in > setImagePath() regardless of whether we are blocking

[Differential] [Commented On] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

ppalaga added a comment. > Patch looks good. Thanks for the review and for the assistance! > Do you have a developer account to commit it or should I do it for you? Yes, please do it for me. REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES

[Differential] [Commented On] D4837: Applet: Make volume indicator icon bigger

drosca added inline comments. INLINE COMMENTS > subdiff wrote in ListItemBase.qml:123 > Why still the 0.95? Couldn't you just use the slider height? It's still a > little bit small for the microphone icon (especially showing the red line > above as the difference between muted and unmuted)

[Differential] [Request, 2 lines] D4839: kio_mtp: add write permissions to root storage folder

elvisangelaccio created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Otherwise it's impossible to paste files there. CCBUG: 366795 TEST PLAN I can now paste files to the root folder of my phone's

[Differential] [Commented On] D4739: make sure the cancel action is last

dfaure added inline comments. INLINE COMMENTS > mart wrote in dropjob.h:38 > used for class KIO::DropMenu : public QMenu in dropjob.cpp, > doesn't compile otherwise Not a good enough reason to have it in the public header (which doesn't use it anywhere), you can move that fwd decl to the .cpp

[Differential] [Closed] D4739: make sure the cancel action is last

This revision was automatically updated to reflect the committed changes. mart marked an inline comment as done. Closed by commit R241:cae36e0efc65: make sure the cancel action is last (authored by mart). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D4508: Plasma controls based on QtQuickControls2

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in CMakeLists.txt:42 > It's easier to add something later than to remove it. > > I'd go with not installing for now, then revisit it. Maybe same for Menus. ok. what about the combobox? > davidedmundson wrote in Button.qml:28 >

[Differential] [Commented On] D4550: Task Manager: Make the icon size configurable for task buttons in a vertical task manager

hein added a comment. One more request, would you mind rebasing it against current master? (Doesn't apply cleanly currently.) REVISION DETAIL https://phabricator.kde.org/D4550 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ppalaga, davidedmundson,

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 641 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/641/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 11:59:41 + Build duration: 6 min 3 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 86 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/86/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 15:13:53 + Build duration: 5 min 37 sec CHANGE SET Revision

[Differential] [Accepted] D4508: Plasma controls based on QtQuickControls2

davidedmundson accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH arcpatch-D4508 REVISION DETAIL https://phabricator.kde.org/D4508 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 643 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/643/ Project: PLATFORM=Linux,compiler=gcc Date of build: Tue, 28 Feb 2017 14:52:43 + Build duration: 30 min CHANGE SET Revision

Re: [KDE4] what component does the screenlocking?

In data martedì 28 febbraio 2017 18:08:40 CET, René J.V. Bertin ha scritto: > Yeah, I know that KDE no longer maintains most of KDE4. Fortunately some > distributions have a slightly different take on concepts like continuity I would like if you stopped doing such blanket statements. Plasma 4

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#91009, @subdiff wrote: > I thought of something like this: F2668672: Screenshot_20170228_114914.png > Is this in line with the HIG? That's the idea we've discussed above and

Re: Plasma 5.9.3

On Tue, Feb 28, 2017 at 04:03:59PM +, Jonathan Riddell wrote: > Plasma 5.9.3 is now released > https://www.kde.org/announcements/plasma-5.9.3.php > > Tars are at a temporary location due to a server upgrade > > http://weegie.edinburghlinux.co.uk/~jr/tmp/stable/plasma/5.9.3/ Now moved over

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

colomar added a comment. In https://phabricator.kde.org/D4838#91004, @broulik wrote: > > Just as well or as badly as a regular "Open" button. If in this scenario you hide the Open button because it has no valid target, then of course there would be no split Open button, either. > >

[Differential] [Abandoned] D4838: [Notifications] Add context menu for thumbnail

broulik abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #vdg Cc: subdiff, colomar, plasma-devel, progwolff, lesliezhai,

[Differential] [Commented On] D4838: [Notifications] Add context menu for thumbnail

subdiff added a comment. I thought of something like this: F2668672: Screenshot_20170228_114914.png Is this in line with the HIG? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4838 EMAIL PREFERENCES

Re: [KDE4] what component does the screenlocking?

On Tuesday February 28 2017 16:48:25 Martin Gräßlin wrote: >As you should be aware of: kde4 has been unmaintained for years and is >EOL. Yeah, I know that KDE no longer maintains most of KDE4. Fortunately some distributions have a slightly different take on concepts like continuity and

[Differential] [Updated] D4803: Basic keyboard support + fixes to QuickShare plasmoid

yuenlim marked an inline comment as done. yuenlim added inline comments. INLINE COMMENTS > mart wrote in AlternativesView.qml:101 > this should be a PlasmaComponents.Highlight instead after discussion, should avoid using Plasma-specific components here (in purpose) for now. To use Rectangle

[Differential] [Updated, 7 lines] D4803: Basic keyboard support + fixes to QuickShare plasmoid

yuenlim updated this revision to Diff 11963. yuenlim marked an inline comment as done. yuenlim added a comment. Added onEnterPressed and removed Radius on Rectangle highligh as requested REPOSITORY R495 Purpose Library CHANGES SINCE LAST UPDATE

  1   2   >