anemeth updated this revision to Diff 27202.
anemeth added a comment.
Reduced the width of the horizontal line so it doesn't intersect with the
vertical line.
REPOSITORY
R31 Breeze
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10522?vs=27201&id=27202
BRANCH
master
REVISION D
ngraham planned changes to this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10500
To: ngraham, #discover_software_store
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, mart
anemeth added a comment.
The best looking solution would be that menu entries that have
checkbox/radiobutton, do not get an icon and then we can show the icon and the
checkbox/radiobutton on the left column.
Like you see in the Windows 7 pic in the test plan.
Or maybe I'm just used to tha
ngraham updated this revision to Diff 27203.
ngraham added a comment.
- Merge branch 'master' into review-popup-button-text
- Also fix 390426
REPOSITORY
R134 Discover Software Store
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D10500?vs=27131&id=27203
BRANCH
review-popup-but
ngraham edited the summary of this revision.
ngraham edited the test plan for this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10500
To: ngraham, #discover_software_store
Cc: anemeth, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed
cfeck added a comment.
When I had designed the menus for the Skulpture style, I opted for not using
a separate column for checkboxes, but indent the items that use them. The
separate column was used for icons, though. See
http://skulpture.maxiom.de/images/skulpture-sample-2.png
REPOSITORY
apol created this revision.
apol added a reviewer: Kirigami.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
apol requested review of this revision.
REVISION SUMMARY
Make sure the page header is destroyed with the page itself
Don't dup
ngraham added a comment.
Much better! I still get a few warnings though:
file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/ToolBarApplicationHeader.qml:49:
TypeError: Cannot read property of null
file:///usr/lib/x86_64-linux-gnu/qt5/qml/org/kde/kirigami.2/ToolBarApplicat
ngraham created this revision.
ngraham added reviewers: Kirigami, apol.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
If the header text is going to be left aligned, we'd bett
ngraham edited the test plan for this revision.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D10524
To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein
ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Previously, you could write the first review
ngraham edited the test plan for this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10525
To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham created this revision.
ngraham added reviewers: Discover Software Store, apol.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.
REVISION SUMMARY
Use slightly more natural text for the "show
ngraham edited the test plan for this revision.
REPOSITORY
R134 Discover Software Store
REVISION DETAIL
https://phabricator.kde.org/D10527
To: ngraham, #discover_software_store, apol
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg,
abetts, sebas, apol, mart
ngraham edited the summary of this revision.
REPOSITORY
R169 Kirigami
REVISION DETAIL
https://phabricator.kde.org/D10524
To: ngraham, #kirigami, apol
Cc: plasma-devel, apol, davidedmundson, mart, hein
hpereiradacosta added a comment.
Ok. This time I am strongly against this change.
This vertical line serves no purpose, clutters the ui, and is not "simple by
default".
Why would one need to separate the checkbox from the icon and text to which
it is directly related to.
Also see how i
ngraham added a comment.
Don't worry Hugo, I don't think we're going to turn Breeze into a mutant that
you don't recognize. :) This change doesn't seem very popular, and if it's
necessary to make a previous change work, that calls into question whether that
was the right change.
REPOSITORY
mmustac added a comment.
I liked Breeze because of its light and easy concept, get rid of too many
lines, keep only the ones which make sense or are totally necessary, this
feeling gets lost here for me so that Breeze would slowly increase into a Storm
(little overstated I know) Even when th
martinkostolny accepted this revision.
martinkostolny added a comment.
thanks!
REPOSITORY
R884 Active Window Control Applet for Plasma
REVISION DETAIL
https://phabricator.kde.org/D10516
To: mvourlakos, martinkostolny
Cc: broulik, plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed,
101 - 119 of 119 matches
Mail list logo
