D11151: [Notifications] Announce body-images capability

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ba0980c640c7: [Notifications] Announce body-images 
capability (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11151?vs=29003=29004

REVISION DETAIL
  https://phabricator.kde.org/D11151

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

[Andras Mantia]

amantia closed this revision.

REVISION DETAIL
  https://phabricator.kde.org/D10728

To: amantia, #plasma, hein
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10728: Improve multi-desktop folderview behavior

[Andras Mantia]

amantia updated this revision to Diff 28998.
amantia added a comment.


  Moved to 5.12

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10728?vs=27733=28998

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D10728

AFFECTED FILES
  containments/desktop/plugins/folder/screenmapper.cpp
  containments/desktop/plugins/folder/screenmapper.h

To: amantia, #plasma, hein
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10890: Don't skip certain recent documents in kicker and taskmanager

[Алексей Шилин]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:ca96f850efbf: Dont skip certain recent documents in 
kicker and taskmanager (authored by aleksejshilin).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10890?vs=28681=29001

REVISION DETAIL
  https://phabricator.kde.org/D10890

AFFECTED FILES
  applets/kicker/plugin/actionlist.cpp
  applets/taskmanager/plugin/backend.cpp

To: aleksejshilin, #plasma, broulik, hein
Cc: anthonyfieroni, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11151: [Notifications] Announce body-images capability

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  We explicitly allow `` tags so announce that we support this

TEST PLAN
  Chrome now adds images to notifications if available

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11151

AFFECTED FILES
  dataengines/notifications/notificationsengine.cpp

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11101: Minor spelling corrections

[Scarlett Clark]

scarlettclark closed this revision.

REPOSITORY
  R878 Latte Dock

REVISION DETAIL
  https://phabricator.kde.org/D11101

To: scarlettclark, mvourlakos
Cc: ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11142: Add ConnectionCheck for Dash Cards

[Aditya Mehra]

Aiix added inline comments.

INLINE COMMENTS

> yurchor wrote in main.qml:132
> Is it necessary to use "" between "the" and "internet" in this message? 
> Thanks in advance for your answer.

Thanks for reviewing this, I wasn't sure if there is general issue on using 
Unicode symbols in strings and rather a shortcut to not using a icon instead, 
will fix it.

REPOSITORY
  R846 Mycroft Plasma integration

REVISION DETAIL
  https://phabricator.kde.org/D11142

To: Aiix, #plasma
Cc: yurchor, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D10262: [Look and feel KCM] Fix creating a broken colors scheme file in KcmTest

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:0b31d9347d09: [Look and feel KCM] Fix creating a broken 
colors scheme file in KcmTest (authored by kossebau).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10262?vs=26402=29027

REVISION DETAIL
  https://phabricator.kde.org/D10262

AFFECTED FILES
  kcms/lookandfeel/autotests/kcmtest.cpp

To: kossebau, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D10297: Add new "Tools" button above System Monitor's process list

[Nathaniel Graham]

ngraham added reviewers: broulik, mart, hein.
ngraham added a comment.


  I'm a +1, FWIW.

REPOSITORY
  R111 KSysguard Library

REVISION DETAIL
  https://phabricator.kde.org/D10297

To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein
Cc: anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11166: Simplify display when there's only a single device

[Nathaniel Graham]

ngraham added a comment.


  Thanks for all your help!

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca
Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11166: Simplify display when there's only a single device

[Nathaniel Graham]

ngraham updated this revision to Diff 29055.
ngraham added a comment.


  Only show the simple mode when there's exactly one input device and exactly 
one output device

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11166?vs=29054=29055

BRANCH
  simplify-single-device-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11166

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11166: Simplify display when there's only a single input device and a single output device

[Chris Holland]

Zren added inline comments.

INLINE COMMENTS

> main.qml:420
>  Layout.fillWidth: true
> -visible: sourceView.count > 0
> +visible: sourceView.count > 1 && 
> !devicesView.simpleMode
>  text: i18n("Capture Devices")

2 speakers + 1 mic won't show the mic header since it's only visible if there's 
2 mics.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca
Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11166: Simplify display when there's only a single device

[Chris Holland]

Zren added a comment.


  Hmmm. So if there was 2 sinks (eg: 3.5mm jack + HDMI) and 1 mic (3.5mm jack) 
it'd show the sink header, but not the source header? Labelling all 3 as a sink?
  
  Might want to create a `bool simpleMode: sinkView.count + sourceView.count <= 
2` that is used everywhere in `main.qml`. Or `sinkView.count == 1 && 
sourceView.count == 1`.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca
Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11166: Simplify display when there's only a single device

[Nathaniel Graham]

ngraham added a comment.


  Hey, that's not a bad idea!

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca
Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11166: Simplify display when there's only a single device

[Nathaniel Graham]

ngraham added a comment.


  Hmm, I'm seeing that wherever in `main.qml` I define `simpleMode`, it doesn't 
seem to actually get set. Maybe the listView delegates aren't yet initialized 
or something?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca
Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11166: Simplify display when there's only a single device

[Chris Holland]

Zren added a comment.


  I remember having trouble binding to stuff in the `___Representation` in the 
`main.qml` too, but don't remember the specifics. Why not just define it in the 
`ColumnLayout { id: devicesView }` since it's not really needed elsewhere. 
`onlyOne: devicesView.simpleMode`, `visible: !devicesView.simpleMode`.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D11166

To: ngraham, #plasma, drosca
Cc: Zren, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11166: Simplify display when there's only a single device

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: Plasma, drosca.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  The Audio Volume plasmoid has always seemed a bit too heavy and complicated 
for the common use case of a single input device and a single output device. 
This patch presents a simplified UI for that use case.

TEST PLAN
  Before, single devices:
  
  After, single devices:
  
  As I lack the hardware to test the multi-device use case, testing by others 
would be appreciated.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  simplify-single-device-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11166

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11166: Simplify display when there's only a single device

[Nathaniel Graham]

ngraham updated this revision to Diff 29054.
ngraham added a comment.


  Simplify logic

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11166?vs=29053=29054

BRANCH
  simplify-single-device-ui (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D11166

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: ngraham, #plasma, drosca
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11069#221385 , 
@hpereiradacosta wrote:
  
  > > - What's the best way to share code between KStyle and KDecoration 
plugin? (currently, I'm symlinking files)
  >
  > File links is not an option.  (it breaks when you make tarballs of when 
compiling on e.g. windows)
  >  You would need to move the files away in a separate folder, compile them 
in a library, link the library to both kstyle and kdecoration. Oxygen does that.
  
  
  Thanks, I'll take a look at oxygen.
  
  > I'd say yes, as soon as you provide different shadow sizes for the windows 
(that also answers the last question)
  
  Well, than I would like to get help with params. I believe computed params 
won't produce good looking results so they have to be hand picked, maybe I'm 
wrong. VDG folks, if you know CSS, you can help!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Vlad Zagorodniy]

zzag added a comment.


  So, I'd spent last two hours trying to find good menu shadow params.. HIG 
guidelines don't say too much about shadows(also, navigating them is hard).
  F5745942: menu-shadows.png 
  
  You can help by providing CSS shadows.
  
  Some questions:
  
  - Do we really need different shadow sizes for menus, etc? Can we use single 
shadow size in kstyle?
  - Do menus have outlines? If you look at picture above, you can see grey 
"gap" between menu and submenu.
  - What's the best way to share code between KStyle and KDecoration? 
(currently, I'm symlinking files)
  
  In addition to the first question, it's a little bit weird that changing 
window decoration shadow size also changes shadows "in apps" (e.g. menu shadows 
would have different size, etc).

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11148: Move applet packages' /code subdirs below /ui subdirs

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:600b64eb9ab8: Move applet packages /code subdirs 
below /ui subdirs (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11148?vs=28985=29019#toc

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11148?vs=28985=29019

REVISION DETAIL
  https://phabricator.kde.org/D11148

AFFECTED FILES
  applets/kicker/package/contents/code/tools.js
  applets/kicker/package/contents/ui/DashboardRepresentation.qml
  applets/kicker/package/contents/ui/ItemGridDelegate.qml
  applets/kicker/package/contents/ui/ItemListDelegate.qml
  applets/kicker/package/contents/ui/SideBarItem.qml
  applets/kicker/package/contents/ui/code/tools.js
  applets/kickoff/package/contents/code/tools.js
  applets/kickoff/package/contents/ui/KickoffItem.qml
  applets/kickoff/package/contents/ui/code/tools.js
  applets/taskmanager/package/contents/code/layout.js
  applets/taskmanager/package/contents/code/tools.js
  applets/taskmanager/package/contents/ui/GroupDialog.qml
  applets/taskmanager/package/contents/ui/MouseHandler.qml
  applets/taskmanager/package/contents/ui/Task.qml
  applets/taskmanager/package/contents/ui/TaskProgressOverlay.qml
  applets/taskmanager/package/contents/ui/code/layout.js
  applets/taskmanager/package/contents/ui/code/tools.js
  applets/taskmanager/package/contents/ui/main.qml

To: kossebau, #plasma, mart, broulik, hein
Cc: apol, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, mart

D11144: Merge applet packages' /code subdirs into /ui subdirs

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R114:c3ccefda4bea: Merge applet packages /code subdirs 
into /ui subdirs (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11144?vs=28978=29015#toc

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11144?vs=28978=29015

REVISION DETAIL
  https://phabricator.kde.org/D11144

AFFECTED FILES
  applets/colorpicker/package/contents/code/logic.js
  applets/colorpicker/package/contents/ui/configGeneral.qml
  applets/colorpicker/package/contents/ui/logic.js
  applets/colorpicker/package/contents/ui/main.qml
  applets/quicklaunch/package/contents/code/layout.js
  applets/quicklaunch/package/contents/ui/IconItem.qml
  applets/quicklaunch/package/contents/ui/Popup.qml
  applets/quicklaunch/package/contents/ui/layout.js
  applets/quicklaunch/package/contents/ui/main.qml

To: kossebau, #plasma, mart
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11069: [WIP] refine decoration shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  > Some questions:
  > 
  > - Do we really need different shadow sizes for menus, etc? Can we use 
single shadow size in kstyle?
  
  I'd say yes, as soon as you provide different shadow sizes for the windows 
(that also answers the last question)
  
  > - Do menus have outlines? If you look at picture above, you can see grey 
"gap" between menu and submenu.
  
  yes menus have outlines. In fact, in the old shadows, windows also had an 
outline. (drawn with the shadow).
  We want to keep it as far as I know.
  
  > - What's the best way to share code between KStyle and KDecoration plugin? 
(currently, I'm symlinking files)
  
  File links is not an option.  (it breaks when you make tarballs of when 
compiling on e.g. windows)
  You would need to move the files away in a separate folder, compile them in a 
library, link the library to both kstyle and kdecoration. Oxygen does that.
  
  > In addition to the first question, it's a little bit weird that changing 
window decoration shadow size also changes shadows "in apps" (e.g. menu shadows 
would have different size, etc).
  
  Why weird ? if I want "large shadows" I want them large for everything that 
have shaodws (with possible hierarchy). And if I want small I want them all 
small. 
  That seems natural to me.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D11145: Merge applet packages' /code subdirs into /ui subdirs

[Friedrich W . H . Kossebau]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:b10f5bc729e7: Merge applet packages /code subdirs 
into /ui subdirs (authored by kossebau).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D11145?vs=28980=29020#toc

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11145?vs=28980=29020

REVISION DETAIL
  https://phabricator.kde.org/D11145

AFFECTED FILES
  applets/batterymonitor/package/contents/code/logic.js
  applets/batterymonitor/package/contents/ui/logic.js
  applets/lock_logout/contents/code/data.js
  applets/lock_logout/contents/ui/data.js
  applets/notifications/package/contents/code/uiproperties.js
  applets/notifications/package/contents/ui/uiproperties.js

To: kossebau, #plasma, mart, broulik, apol
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart