KDE CI: Plasma systemsettings kf5-qt5 SUSEQt5.9 - Build # 137 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20systemsettings%20kf5-qt5%20SUSEQt5.9/137/
 Project:
Plasma systemsettings kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Mar 2018 09:18:34 +
 Build duration:
10 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report0%
(0/7)0%
(0/28)0%
(0/28)0%
(0/1830)0%
(0/719)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsapp0%
(0/3)0%
(0/3)0%
(0/271)0%
(0/138)app.ToolTips0%
(0/1)0%
(0/1)0%
(0/92)0%
(0/18)classic0%
(0/2)0%
(0/2)0%
(0/191)0%
(0/52)core0%
(0/10)0%
(0/10)0%
(0/495)0%
(0/235)icons0%
(0/5)0%
(0/5)0%
(0/273)0%
(0/54)sidebar0%
(0/6)0%
(0/6)0%
(0/415)0%
(0/200)sidebar.ToolTips0%
(0/1)0%
(0/1)0%
(0/93)0%
(0/22)

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> breezewindowmanager.cpp:100
> +#if QT_VERSION >= QT_VERSION_CHECK(5, 11, 0)
> +#include 
>  #endif

Using private API will lock Breeze to that specific Qt version it was compiled 
with, requiring a rebuild. This has imho shown to be quite painful in 
plasma-integration and Kwin already.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11573

To: volkov, #breeze
Cc: broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

[Alexander Volkov]

volkov added a comment.


  https://codereview.qt-project.org/224251

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11573

To: volkov, #breeze
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework kf5-qt5 SUSEQt5.9 - Build # 249 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20kf5-qt5%20SUSEQt5.9/249/
 Project:
Plasma plasma-framework kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Mar 2018 11:49:32 +
 Build duration:
1 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 91.38 KB...]QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'QT_SELECT = 'qt5'XDG_CURRENT_DESKTOP   = 'KDE'ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON  "/home/jenkins/workspace/Plasma plasma-framework kf5-qt5 SUSEQt5.9"-- The C compiler identification is GNU 7.3.1-- The CXX compiler identification is GNU 7.3.1-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Looking for __GLIBC__-- Looking for __GLIBC__ - found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at CMakeLists.txt:27 (include):  include could not find load file:ECMSetupQtPluginMacroNames-- Found KF5Activities: /home/jenkins/install-prefix/lib64/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Archive: /home/jenkins/install-prefix/lib64/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.45.0") -- Found KF5Config: /home/jenkins/install-prefix/lib64/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /home/jenkins/install-prefix/lib64/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /home/jenkins/install-prefix/lib64/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /home/jenkins/install-prefix/lib64/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found KF5Declarative: /home/jenkins/install-prefix/lib64/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.45.0") -- Found KF5GlobalAccel: /home/jenkins/install-prefix/lib64/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.45.0") -- Found KF5GuiAddons: /home/jenkins/install-prefix/lib64/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /home/jenkins/install-prefix/lib64/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /home/jenkins/install-prefix/lib64/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5KIO: /home/jenkins/install-prefix/lib64/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /home/jenkins/install-prefix/lib64/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /home/jenkins/install-prefix/lib64/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5XmlGui: /home/jenkins/install-prefix/lib64/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.45.0") -- Found KF5Notifications: /home/jenkins/install-prefix/lib64/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") -- Found KF5Package: /home/jenkins/install-prefix/lib64/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.45.0") -- Found KF5Kirigami2: /home/jenkins/install-prefix/lib64/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.45.0") -- Found KF5Wayland: /home/jenkins/install-prefix/lib64/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /home/jenkins/install-prefix/lib64/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5: success (found suitable version "5.45.0", minimum required is "5.44.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools -- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so-- Looking for XOpenDisplay in /usr/lib64/libX11.so;/usr/lib64/libXext.so - found-- Looking for gethostbyname-- Looking for gethostbyname - 

Plasma Sprint topics

[Bhushan Shah]

Hello Plasmoids,

with plasma sprint drawing closer, I wanted to start a etherpad to
collect the topics for Plasma Sprint:

https://notes.kde.org/p/plasma-sprint-2018-topics

Please fill-in.

Thanks

-- 
Bhushan Shah
http://blog.bshah.in
IRC Nick : bshah on Freenode
GPG key fingerprint : 0AAC 775B B643 7A8D 9AF7 A3AC FE07 8411 7FBC E11D


signature.asc
Description: PGP signature

D11558: Don't show cache memory in systemloadviewer bars

[Henrik Fehlauer]

rkflx added a comment.


  In a sense the cache tells me about aggregated memory pressure from the past 
(because the cache will only slowly fill up again after it was squeezed), and 
the unused memory is a metrics showing the current memory pressure.
  
  I find it useful, and apparently when it was first introduced in KDE and 
later ported to Plasma it was deemed useful. It's a power user tool anyway, 
please don't tell users to go back to `xosview` (which won't work on Wayland).
  
  I see where you are coming from, though. Maybe you can make this transparent 
by default, and anyone liking the feature could turn on the colour again?

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9 - Build # 85 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20FreeBSDQt5.9/85/
 Project:
Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 22 Mar 2018 11:49:32 +
 Build duration:
1 min 32 sec and counting
   CONSOLE OUTPUT
  [...truncated 67.90 KB...]CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'JAVA_HOME = '/usr/local/openjdk8-jre'LOGNAME   = 'jenkins'== Commencing Configuration:cmake -DCMAKE_BUILD_TYPE=Debug -DECM_ENABLE_SANITIZERS='address' -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/usr/home/jenkins//install-prefix/"  "/usr/home/jenkins/workspace/Plasma plasma-framework stable-kf5-qt5 FreeBSDQt5.9"-- The C compiler identification is Clang 4.0.0-- The CXX compiler identification is Clang 4.0.0-- Check for working C compiler: /usr/bin/cc-- Check for working C compiler: /usr/bin/cc -- works-- Detecting C compiler ABI info-- Detecting C compiler ABI info - done-- Detecting C compile features-- Detecting C compile features - done-- Check for working CXX compiler: /usr/bin/c++-- Check for working CXX compiler: /usr/bin/c++ -- works-- Detecting CXX compiler ABI info-- Detecting CXX compiler ABI info - done-- Detecting CXX compile features-- Detecting CXX compile features - done-- -- Could not set up the appstream test. appstreamcli is missing.-- Looking for __GLIBC__-- Looking for __GLIBC__ - not found-- Performing Test _OFFT_IS_64BIT-- Performing Test _OFFT_IS_64BIT - Success-- Performing Test HAVE_DATE_TIME-- Performing Test HAVE_DATE_TIME - SuccessCMake Error at CMakeLists.txt:27 (include):  include could not find load file:ECMSetupQtPluginMacroNames-- Found KF5Activities: /usr/home/jenkins/install-prefix/lib/cmake/KF5Activities/KF5ActivitiesConfig.cmake (found version "5.45.0") -- Found KF5Archive: /usr/home/jenkins/install-prefix/lib/cmake/KF5Archive/KF5ArchiveConfig.cmake (found version "5.45.0") -- Found KF5Config: /usr/home/jenkins/install-prefix/lib/cmake/KF5Config/KF5ConfigConfig.cmake (found version "5.45.0") -- Found KF5ConfigWidgets: /usr/home/jenkins/install-prefix/lib/cmake/KF5ConfigWidgets/KF5ConfigWidgetsConfig.cmake (found version "5.45.0") -- Found KF5CoreAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5CoreAddons/KF5CoreAddonsConfig.cmake (found version "5.45.0") -- Found KF5DBusAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5DBusAddons/KF5DBusAddonsConfig.cmake (found version "5.45.0") -- Found KF5Declarative: /usr/home/jenkins/install-prefix/lib/cmake/KF5Declarative/KF5DeclarativeConfig.cmake (found version "5.45.0") -- Found KF5GlobalAccel: /usr/home/jenkins/install-prefix/lib/cmake/KF5GlobalAccel/KF5GlobalAccelConfig.cmake (found version "5.45.0") -- Found KF5GuiAddons: /usr/home/jenkins/install-prefix/lib/cmake/KF5GuiAddons/KF5GuiAddonsConfig.cmake (found version "5.45.0") -- Found Gettext: /usr/local/bin/msgmerge (found version "0.19.8.1") -- Found PythonInterp: /usr/local/bin/python3.6 (found version "3.6.4") -- Found KF5I18n: /usr/home/jenkins/install-prefix/lib/cmake/KF5I18n/KF5I18nConfig.cmake (found version "5.45.0") -- Found KF5IconThemes: /usr/home/jenkins/install-prefix/lib/cmake/KF5IconThemes/KF5IconThemesConfig.cmake (found version "5.45.0") -- Found KF5KIO: /usr/home/jenkins/install-prefix/lib/cmake/KF5KIO/KF5KIOConfig.cmake (found version "5.45.0") -- Found KF5Service: /usr/home/jenkins/install-prefix/lib/cmake/KF5Service/KF5ServiceConfig.cmake (found version "5.45.0") -- Found KF5WindowSystem: /usr/home/jenkins/install-prefix/lib/cmake/KF5WindowSystem/KF5WindowSystemConfig.cmake (found version "5.45.0") -- Found KF5XmlGui: /usr/home/jenkins/install-prefix/lib/cmake/KF5XmlGui/KF5XmlGuiConfig.cmake (found version "5.45.0") -- Found KF5Notifications: /usr/home/jenkins/install-prefix/lib/cmake/KF5Notifications/KF5NotificationsConfig.cmake (found version "5.45.0") -- Found KF5Package: /usr/home/jenkins/install-prefix/lib/cmake/KF5Package/KF5PackageConfig.cmake (found version "5.45.0") -- Found KF5Kirigami2: /usr/home/jenkins/install-prefix/lib/cmake/KF5Kirigami2/KF5Kirigami2Config.cmake (found version "5.45.0") -- Found KF5Wayland: /usr/home/jenkins/install-prefix/lib/cmake/KF5Wayland/KF5WaylandConfig.cmake (found version "5.45.0") -- Found KF5DocTools: /usr/home/jenkins/install-prefix/lib/cmake/KF5DocTools/KF5DocToolsConfig.cmake (found version "5.45.0") -- Found KF5: success (found suitable version "5.45.0", minimum required is "5.44.0") found components:  Activities Archive Config ConfigWidgets CoreAddons DBusAddons Declarative GlobalAccel GuiAddons I18n IconThemes KIO Service WindowSystem XmlGui Notifications Package Kirigami2 Wayland DocTools -- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so-- Looking for XOpenDisplay in /usr/local/lib/libX11.so;/usr/local/lib/libXext.so - found-- Looking for gethostbyname-- Looking for gethostbyname - found-- Looking for 

D11558: Don't show cache memory in systemloadviewer bars

[David Edmundson]

davidedmundson added a comment.


  Unless you know how much of that cache was actually read back, you have 
absolutely no knowledge of whether the cache was utilised properly or not. 
  In your example seeing the cache value stay "good" is giving you the same 
result as seeing the free memory stay "good" just arguably with the effect 
lingering ever so slightly longer.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11558: Don't show cache memory in systemloadviewer bars

[Henrik Fehlauer]

rkflx added a comment.


  In D11558#231516 , @davidedmundson 
wrote:
  
  > I'm not sure we're talking about the same place. This is the little 
overview applet, systemloadviewer
  >
  > F5762570: Screenshot_20180322_115217.png 

  
  
  Yup, that's exactly the thing I'm talking about. At this point I don't care 
that much about the other options, but it would be annoying if the applet lost 
that feature. I felt this might concern a lot of users using this, so I spoke 
up. I don't want to block improvements, but maybe we can find a compromise 
here. Removing features which have been there for a long time is always a bad 
message to send when one of our goals is polishing.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11558: Don't show cache memory in systemloadviewer bars

[David Edmundson]

davidedmundson added a comment.


  > It's a power user tool anyway,
  
  I'm not sure we're talking about the same place. This is the little overview 
applet, systemloadviewer
  
  F5762570: Screenshot_20180322_115217.png 

  
  KSysguard is the power tool. 
  Even that doesn't show it by default, but it's available if you choose to add 
custom sensors. I'm not intending on changing that.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D11558

To: davidedmundson, #plasma
Cc: rkflx, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

[Alexander Volkov]

volkov created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
volkov requested review of this revision.

REVISION SUMMARY
  ... instead of X11 API to initiate window movement by a window
  manager. It works correctly when mouse events are synthesized from
  touch events (requires releasing of touch sequences that relies on
  Qt's internals and can be done only inside the xcb plugin).
  Besides it should work on Wayland.
  
  Note that now globalPos is used when creating QMouseEvent that
  triggers window movement. Otherwise QMouseEvent will take it
  from QCursor::pos() with integer coordinates received from the
  X server, which may differ from coordinates rounded by Qt for
  touch events.

REPOSITORY
  R31 Breeze

BRANCH
  Plasma/5.12

REVISION DETAIL
  https://phabricator.kde.org/D11573

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breezewindowmanager.cpp

To: volkov
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

[Alexander Volkov]

volkov added a comment.


  IIRC, the X server floors coordinates, while Qt rounds them.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11573

To: volkov, #breeze
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11175: [kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  Ship it, thanks !

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

[David Edmundson]

davidedmundson added a comment.


  > Note that now globalPos is used when creating QMouseEvent that
  > triggers window movement. Otherwise QMouseEvent will take it
  > from QCursor::pos() with integer coordinates received from the
  > X server, which may differ from coordinates rounded by Qt for
  > touch events.
  
  Can you expand on this, I don't understand why Qt would have different 
positions for synthesised touch events

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11573

To: volkov, #breeze
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag requested review of this revision.
zzag added a comment.


  F5762842: mdi-shadows.png 
  
  //Shadows in Qt Designer//
  
  It's hard to see them because background is gray... I couldn't find another 
app with MDI, sorry. :(

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag updated this revision to Diff 30238.
zzag added a comment.
This revision is now accepted and ready to land.


  - fix MDI child window shadows

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11175?vs=29541=30238

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

AFFECTED FILES
  kstyle/CMakeLists.txt
  kstyle/breeze.kcfg
  kstyle/breezemdiwindowshadow.cpp
  kstyle/breezeshadowhelper.cpp
  kstyle/breezeshadowhelper.h

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11069: [kdecoration] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  First, I am now running this set of patch routinely and think these new 
shadows are gorgeous on a dayly usage. (I think the default is too large to my 
taste, but using a 70% shadow strenght and medium size, I'm quite happy with 
the result). So no regret with accepting it. 
  Second, concerning code review: 
  I now see that you kept the door opened for horizontal offsets in your 
shadowParams definition and in the code implementation. I think this is quite 
superfluous, and could be dropped. Not sure that the current shadow model works 
for non centered shadows anyway. 
  This would result in changing .offset frop QPoint to int, and modifying the 
rendering code accordingly. IMHO there is no point being too generic here.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11069

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, fabianr, hpereiradacosta, ngraham, plasma-devel, ZrenBot, 
lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag planned changes to this revision.
zzag added a comment.


  Fix MDI child window shadows.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  In D11175#231610 , @zzag wrote:
  
  > Fix MDI child window shadows.
  
  
  I have pushed a fix to the "current" shadows already. so you would need to 
rebase this patch to master. (I did it locally, this will create some minor 
conflicts). 
  I also have a local patch for fixing the MDI shadows on top of this patch, if 
you are interested. 
  Note that I also commented on the possible horizontal offset that you left in 
your implementation, for the kdecoration part. It also applies here. I would 
drop it :)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

Experience on wayland regressed

[Aleix Pol]

Hi,
Since the recent removal of QT_QPA_PLATFORM=wayland, we lost some
functionality. At the moment it seems that kded is being ran as xcb so
the per-screen scaling isn't being set up. Also system settings shows
the behavior for xcb instead of the one for wayland also with the
per-display UX broken.

I also see that Spectacle is now even more broken as it's trying to
ask xcb for the screenshots.

Aleix

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

[David Edmundson]

davidedmundson added a comment.


  +++ to using this.
  
  However, I think we should at least try to get this as public API in Qt, 
rather than using internals. 
  Breeze is far from the only case where someone would want to do this and 
QWindow has other system calls it seems to make sense to me.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11573

To: volkov, #breeze
Cc: davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

KDE CI: Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9 - Build # 112 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma%20plasma-framework%20stable-kf5-qt5%20SUSEQt5.9/112/
 Project:
Plasma plasma-framework stable-kf5-qt5 SUSEQt5.9
 Date of build:
Thu, 22 Mar 2018 11:49:32 +
 Build duration:
32 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 15 test(s), Skipped: 0 test(s), Total: 15 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report50%
(9/18)49%
(78/159)49%
(78/159)39%
(5237/13481)29%
(3033/10583)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsautotests100%
(26/26)100%
(26/26)96%
(1097/1144)50%
(746/1492)src.declarativeimports.calendar0%
(0/11)0%
(0/11)0%
(0/453)0%
(0/241)src.declarativeimports.core56%
(10/18)56%
(10/18)33%
(753/2267)27%
(403/1494)src.declarativeimports.plasmacomponents0%
(0/9)0%
(0/9)0%
(0/525)0%
(0/214)src.declarativeimports.plasmaextracomponents0%
(0/5)0%
(0/5)0%
(0/44)0%
(0/27)src.declarativeimports.platformcomponents0%
(0/4)0%
(0/4)0%
(0/60)0%
(0/14)src.declarativeimports.platformcomponents.utils0%
(0/2)0%
(0/2)0%
(0/15)0%
(0/4)src.plasma64%
(14/22)64%
(14/22)49%
(1710/3515)37%
(1077/2917)src.plasma.packagestructure57%
(4/7)57%
(4/7)35%
(51/144)43%
(6/14)src.plasma.private58%
(14/24)58%
(14/24)58%
(951/1636)40%
(454/1121)src.plasma.scripting67%
(2/3)67%
(2/3)21%
(36/168)11%
(15/132)src.plasmapkg0%
(0/1)0%
(0/1)0%
(0/45)0%
(0/40)src.plasmaquick42%
(5/12)42%
(5/12)29%
(594/2018)18%
(327/1779)src.plasmaquick.private33%
(1/3)33%
(1/3)28%
(31/110)36%
(5/14)src.scriptengines.qml.plasmoid33%
(2/6)33%
(2/6)1%
(14/1179)0%
(0/1056)tests.dpi0%
(0/2)0%
(0/2)0%
(0/22)0%
(0/2)tests.kplugins0%
(0/2)0%
(0/2)0%
(0/62)0%
(0/16)tests.testengine0%
  

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11175#231614 , 
@hpereiradacosta wrote:
  
  > In D11175#231610 , @zzag wrote:
  >
  > > Fix MDI child window shadows.
  >
  >
  > I have pushed a fix to the "current" shadows already. so you would need to 
rebase this patch to master. (I did it locally, this will create some minor 
conflicts). 
  >  I also have a local patch for fixing the MDI shadows on top of this patch, 
if you are interested.
  
  
  MDI shadows have another problem? Is it because of this patch?
  
  > Note that I also commented on the possible horizontal offset that you left 
in your implementation, for the kdecoration part. It also applies here. I would 
drop it :)
  
  Yeah, I added them to keep everything consistent(the box shadow helper 
expects QPoint to be an offset). I'd like to keep it, if you don't mind. :)

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

KDE CI: Plasma kwin kf5-qt5 FreeBSDQt5.9 - Build # 116 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma%20kwin%20kf5-qt5%20FreeBSDQt5.9/116/
 Project:
Plasma kwin kf5-qt5 FreeBSDQt5.9
 Date of build:
Thu, 22 Mar 2018 15:03:33 +
 Build duration:
51 min and counting
   JUnit Tests
  Name: (root) Failed: 19 test(s), Passed: 104 test(s), Skipped: 0 test(s), Total: 123 test(s)Failed: TestSuite.kwin-testClientMachineFailed: TestSuite.kwin-testDebugConsoleFailed: TestSuite.kwin-testDecorationInputFailed: TestSuite.kwin-testDecorationInput-waylandonlyFailed: TestSuite.kwin-testDontCrashCursorPhysicalSizeEmptyFailed: TestSuite.kwin-testDontCrashCursorPhysicalSizeEmpty-waylandonlyFailed: TestSuite.kwin-testIdleInhibitionFailed: TestSuite.kwin-testInternalWindowFailed: TestSuite.kwin-testInternalWindow-waylandonlyFailed: TestSuite.kwin-testLockScreenFailed: TestSuite.kwin-testMaximized-waylandonlyFailed: TestSuite.kwin-testShadeWobblyWindowsFailed: TestSuite.kwin-testShellClientFailed: TestSuite.kwin-testShellClient-waylandonlyFailed: TestSuite.kwin-testShellClientRules-waylandonlyFailed: TestSuite.kwin-testShowingDesktopFailed: TestSuite.kwin-testTabBox-waylandonlyFailed: TestSuite.kwin-testTouchInputFailed: TestSuite.kwin-testTransientPlacmenet

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  I'd like to land it but KWin patches haven't landed yet.

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  
  
  >> I have pushed a fix to the "current" shadows already. so you would need to 
rebase this patch to master. (I did it locally, this will create some minor 
conflicts). 
  >>  I also have a local patch for fixing the MDI shadows on top of this 
patch, if you are interested.
  > 
  > MDI shadows have another problem? Is it because of this patch?
  
  Yes (another problem) and no (because of this patch).
  
  As you quoted on IRC, they used the raw shadowSize enum as an actual value. 
This was correct for the old-old shadows, but not any more when Nathan and 
myself switched to using an enum. Thats what required fixing, disregarding 
whether your patch gets landed or not.
  
  > 
  > 
  >> Note that I also commented on the possible horizontal offset that you left 
in your implementation, for the kdecoration part. It also applies here. I would 
drop it :)
  > 
  > Yeah, I added them to keep everything consistent(the box shadow helper 
expects QPoint to be an offset). I'd like to keep it, if you don't mind. :)
  
  Ok. No problem. 
  Still, you'll probably need to rebase your patch to the current master 
(because of the fix I introduced above)

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11175: [kstyle] refine shadows

[Vlad Zagorodniy]

zzag added a comment.


  In D11175#231649 , 
@hpereiradacosta wrote:
  
  > Still, you'll probably need to rebase your patch to the current master 
(because of the fix I introduced above)
  
  
  I already rebased onto master(7f18aa39ed261828c774094c404ee7a3ed3b060e 
).

REPOSITORY
  R31 Breeze

BRANCH
  shadows

REVISION DETAIL
  https://phabricator.kde.org/D11175

To: zzag, #breeze, #vdg, hpereiradacosta
Cc: abetts, ngraham, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, sebas, apol, mart

D11561: fix typos in UI strings

[Ivan Čukić]

ivan accepted this revision.
ivan added a comment.


  You can also switch to 'can't' as far as I'm concerned

REPOSITORY
  R845 Plasma Vault

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D11561

To: schwarzer, ivan, davidedmundson
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Experience on wayland regressed

[Martin Flöser]

Am 22. März 2018 15:54:22 MEZ schrieb Aleix Pol :
>Hi,
>Since the recent removal of QT_QPA_PLATFORM=wayland, we lost some
>functionality. At the moment it seems that kded is being ran as xcb so
>the per-screen scaling isn't being set up. Also system settings shows
>the behavior for xcb instead of the one for wayland also with the
>per-display UX broken.

Uh kded was an oversight on my side as it's not part of workspace - I checked 
what workspace has as binaries and adjusted those. I'll have a look.

Systemsettings is adjusted and works fine.

>
>I also see that Spectacle is now even more broken as it's trying to
>ask xcb for the screenshots.

Well it should not do that. Even on X11 spectacle should use the dbus protocol. 
That should be easy to adjust without needing to check the platform in 
spectacle.

Cheers
Martin

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

fvogt added a comment.


  The  blank line deletion should be ok, but someone should test on X11 as 
well. I don't expect any regressions there though.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11584

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11573: Use QPlatformWindow::startSystemMove() with Qt 5.11

[Martin Flöser]

graesslin added a comment.


  In general I like the idea and that should be extended to Wayland as well, 
but private API is a no-no for breeze. That has huge runtime breakage potential.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D11573

To: volkov, #breeze
Cc: graesslin, davidedmundson, broulik, plasma-devel, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Re: Experience on wayland regressed

[Martin Flöser]

Am 2018-03-22 19:13, schrieb Martin Flöser:

Am 22. März 2018 15:54:22 MEZ schrieb Aleix Pol :

Hi,
Since the recent removal of QT_QPA_PLATFORM=wayland, we lost some
functionality. At the moment it seems that kded is being ran as xcb so
the per-screen scaling isn't being set up. Also system settings shows
the behavior for xcb instead of the one for wayland also with the
per-display UX broken.


Uh kded was an oversight on my side as it's not part of workspace - I
checked what workspace has as binaries and adjusted those. I'll have a
look.


-> https://phabricator.kde.org/D11583

sorry about the inconvenience. If there are any other processes you 
notice, please report a bug and put me on CC.


Cheers
Martin

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  Those had no transient parent set, so they got displayed somewhere, most of 
the
  time on the wrong screen.
  
  Also pass the actual click coordinates instead of (0,0), although those are
  ignored anyway.

TEST PLAN
  Works fine for spotify and kteatime now, but certain applications
  which trigger a LayoutChanged signal on the opened event have a Y offset.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  snitest

REVISION DETAIL
  https://phabricator.kde.org/D11584

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtray.cpp

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D1231: Add Remote Access interface to KWayland

[Roman Gilg]

romangg added inline comments.

INLINE COMMENTS

> CMakeLists.txt:430
> +target_link_libraries( testRemoteAccess Qt5::Test Qt5::Gui 
> KF5::WaylandClient KF5::WaylandServer)
> +add_test(kwayland-testRemoteAccess testRemoteAccess)
> +ecm_mark_as_test(testRemoteAccess)

`add_test(NAME kwayland-testRemoteAccess COMMAND testRemoteAccess)`

otherwise ctest doesn't find the test.

> remote_access_interface.cpp:206
> +// clients don't necessarily bind outputs
> +if (boundScreens.isEmpty())
> +return;

Use braces: https://techbase.kde.org/Policies/Frameworks_Coding_Style#Braces

REPOSITORY
  R127 KWayland

REVISION DETAIL
  https://phabricator.kde.org/D1231

To: Kanedias, graesslin, davidedmundson, romangg
Cc: jtamate, jgrulich, romangg, ngraham, alexeymin, #frameworks, 
davidedmundson, plasma-devel, schernikov, michaelh, ZrenBot, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, mart, hein

Re: Experience on wayland regressed

[David Edmundson]

>At the moment it seems that kded is being ran as xcb so
the per-screen scaling isn't being set u

All scaling will be half-broken since that change anyway.
Running clients in xwayland means we lose all client high DPI support.

​>. Also system settings shows
the behavior for xcb instead of the one for wayland also with the
per-display UX broken.

Systemsettings knows what backend the kscreen daemon is using, which is
sensible behaviour. It should be fixed by the kded change.



We might have a big problem. Even though 5.11 now has fallback support I'm
not convinced that changing the default
QT_QPA_DEFAULT_PLATFORM_NAME is going to happen for 5.11.  That will be a
big problem.

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

fvogt added a comment.


  Urgh, arc. I'll split again.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11584

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

fvogt updated this revision to Diff 30248.
fvogt added a comment.


  libdbusmenu-qt: Remove nonexistant actions directly from the menu
  
  The getLayout response handler compares the new list of actions with the
  current actions in the menu and calls deleteLater on all actions which aren't
  part of the new list anymore.
  Then, it adds all actions from the new list which aren't part of the menu yet.
  
  As deleteLater only has an effect after the next event processing, the menu
  still contains them together with the added actions.
  This resulted in broken size calculations, as even for static menus the item
  count changed during aboutToShow.
  
  Note that this is not a proper solution for the resize issue, as the
  aboutToShow handler changes the menus content for a reason, the application
  is free to add/remove items at any point in time.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11584?vs=30245=30248

BRANCH
  snitest

REVISION DETAIL
  https://phabricator.kde.org/D11584

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtray.cpp
  libdbusmenuqt/dbusmenuimporter.cpp

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11586: libdbusmenu-qt: Remove nonexistant actions directly from the menu

[Fabian Vogt]

fvogt created this revision.
fvogt added a reviewer: Plasma.
Restricted Application added a project: Plasma.
fvogt requested review of this revision.

REVISION SUMMARY
  The getLayout response handler compares the new list of actions with the
  current actions in the menu and calls deleteLater on all actions which aren't
  part of the new list anymore.
  Then, it adds all actions from the new list which aren't part of the menu yet.
  
  As deleteLater only has an effect after the next event processing, the menu
  still contains them together with the added actions.
  This resulted in broken size calculations, as even for static menus the item
  count changed during aboutToShow.
  
  Note that this is not a proper solution for the resize issue, as the
  aboutToShow handler changes the menus content for a reason, the application
  is free to add/remove items at any point in time.

TEST PLAN
  The context menu for SNI items in the system tray shows at the
  correct position now. Only tested the wayland session.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  snifix

REVISION DETAIL
  https://phabricator.kde.org/D11586

AFFECTED FILES
  libdbusmenuqt/dbusmenuimporter.cpp

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Experience on wayland regressed

[Martin Flöser]

Am 22. März 2018 20:36:38 MEZ schrieb David Edmundson 
:
>>At the moment it seems that kded is being ran as xcb so
>the per-screen scaling isn't being set u
>
>All scaling will be half-broken since that change anyway.
>Running clients in xwayland means we lose all client high DPI support.
>
>​>. Also system settings shows
>the behavior for xcb instead of the one for wayland also with the
>per-display UX broken.
>
>Systemsettings knows what backend the kscreen daemon is using, which is
>sensible behaviour. It should be fixed by the kded change.
>
>
>
>We might have a big problem. Even though 5.11 now has fallback support
>I'm
>not convinced that changing the default
>QT_QPA_DEFAULT_PLATFORM_NAME is going to happen for 5.11.  That will be
>a
>big problem.

Maybe we could get a change in to use the XDG_SESSION_TYPE environment variable 
to pick the default platform?

D11567: Fix use of assert/crash when removing global shortcut

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:db311474f048: Fix use of assert/crash when removing 
global shortcut (authored by davidedmundson).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11567?vs=30174=30198

REVISION DETAIL
  https://phabricator.kde.org/D11567

AFFECTED FILES
  kcms/keys/kglobalshortcutseditor.cpp

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, 
abetts, sebas, apol, mart

D11586: libdbusmenu-qt: Remove nonexistant actions directly from the menu

[Fabian Vogt]

fvogt added a comment.


  Looking at the `WAYLAND_DEBUG` output I think I'm closer to understanding the 
issue now.
  
  When the `QMenu::popup` method is called, the chain "opened Event -> 
LayoutChanged -> GetLayout" gets started.
  The menu calculates its size and position, and sometime later creates the 
zxdg_positioner and finally gets the zxdg_popup_v6.
  
  At some point later, the DBus call completes and the menu changes size. This 
happens with the surface, but the popup
  position can't retroactively be adjusted to fit.
  
  I'm not sure why the menu size calculation reliably occurs after this method 
got called, though. That's the only point
  when the menu's sizeHint is wrong (exactly by the Y offset).

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11586

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11571: [Battery Monitor] Support "Gaming Input Battery type"

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, fvogt, dollinger.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Gives them a nicer icon.
  The icon does not yet exist in Plasma but `gaming-input` does, so it falls 
back to that.

TEST PLAN
  I think this stuff (sans the soliddeviceengine i18n) could also go into 5.12 
since it's trivial and Frameworks that suddenly supports those devices is 
independent of Plasma
  F5762235: Screenshot_20180322_084502.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11571

AFFECTED FILES
  components/workspace/BatteryIcon.qml
  dataengines/powermanagement/powermanagementengine.cpp
  dataengines/soliddevice/soliddeviceengine.cpp

To: broulik, #plasma, fvogt, dollinger
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11571: [Battery Monitor] Support "Gaming Input Battery type"

[Anthony Fieroni]

anthonyfieroni added a comment.


  @broulik, does it makes sens, when batteries isn't available (as your 
screenshot) to be shown, the icon of next device in the list, in systray ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11571

To: broulik, #plasma, dollinger, lbeltrame
Cc: anthonyfieroni, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11571: [Battery Monitor] Support "Gaming Input Battery type"

[Kai Uwe Broulik]

broulik added a comment.


  In D11571#231359 , @anthonyfieroni 
wrote:
  
  > @broulik, does it makes sens, when batteries isn't available (as your 
screenshot) to be shown, the icon and its percentage of next device in the 
list, in systray ?
  
  
  I thought about that a long time and I think we even used to show the lowest 
peripheral battery, if any, but it wasn't particularly predictable what it 
shows, so I removed it. Could be revisited at some point but that is unrelated 
to this patch

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11571

To: broulik, #plasma, dollinger, lbeltrame
Cc: anthonyfieroni, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D11591: Remove anchors in layout in wallpaper config

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

TEST PLAN
  Looks literally identical
  No more warnings

REPOSITORY
  R120 Plasma Workspace

BRANCH
  davidedmundson/wallpaperrewrite

REVISION DETAIL
  https://phabricator.kde.org/D11591

AFFECTED FILES
  wallpapers/image/imagepackage/contents/ui/config.qml

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11590: Add mutex round static member used in a thread

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  BackgroundFinder runs in a separate thread, it uses a static QStringList cache
  It's perfectly plausible that two BackgroundFinders threads could run at once

TEST PLAN
  Old code didn't crash, it was a pure hypothetical.
  Works as before

REPOSITORY
  R120 Plasma Workspace

BRANCH
  davidedmundson/wallpaperrewrite

REVISION DETAIL
  https://phabricator.kde.org/D11590

AFFECTED FILES
  wallpapers/image/backgroundlistmodel.cpp
  wallpapers/image/backgroundlistmodel.h

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

Re: Experience on wayland regressed

[David Edmundson]

Already proposed.

To summarise, we have:

My patch to change the default default qpa:
https://codereview.qt-project.org/#/c/224225/

Which is what I thought Johan was clearly making all his patches in order
to change, yet somehow it didn't materialise so he asked me to submit it to
get feedback.

Allan of Webkit  wrote the version you suggest:
https://codereview.qt-project.org/#/c/224306/

Then just now I had an idea for a super minimal won't-break-anything-patch
which no-one could possibly object to. Hopefully.
https://codereview.qt-project.org/#/c/224330/

*if* Qt 5.11 will not give us a better way to have wayland working for apps
I will want to revisit that env var change, but we can have that discussion
when the time comes.

David

D11590: Add mutex round static member used in a thread

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> backgroundlistmodel.cpp:532
>  
> -m_suffixes = suffixes.toList();
> +s_suffixes = suffixes.toList();
>  }

Potentially it still can produce a crash, the function returns a reference to 
list, simultaneously read/write on list is race condition. So function can 
return a copy to static list for this function, then global variables or 
mutexes doesn't needed.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11590

To: davidedmundson, #plasma
Cc: anthonyfieroni, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart

D1230: GBM remote access support for KWin

[Oleg Chernovskiy]

Kanedias updated this revision to Diff 30189.
Kanedias added a comment.


  Remove override fix

REPOSITORY
  R108 KWin

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D1230?vs=30092=30189

BRANCH
  fix-clang

REVISION DETAIL
  https://phabricator.kde.org/D1230

AFFECTED FILES
  plugins/platforms/drm/CMakeLists.txt
  plugins/platforms/drm/drm_buffer_gbm.h
  plugins/platforms/drm/drm_output.h
  plugins/platforms/drm/egl_gbm_backend.cpp
  plugins/platforms/drm/egl_gbm_backend.h
  plugins/platforms/drm/remoteaccess_manager.cpp
  plugins/platforms/drm/remoteaccess_manager.h

To: Kanedias, graesslin, davidedmundson, romangg, #kwin
Cc: kossebau, jgrulich, romangg, ngraham, alexeymin, aacid, kwin, #kwin, 
davidedmundson, plasma-devel, schernikov, iodelay, zzag, bwowk, ZrenBot, 
lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, eliasp, sebas, 
apol, mart, hein

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

fvogt updated this revision to Diff 30251.
fvogt added a comment.


  Now for real. Please arc, cooperate.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11584?vs=30250=30251

BRANCH
  snitest

REVISION DETAIL
  https://phabricator.kde.org/D11584

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtray.cpp

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11584: Set a transient parent for SNI context menus

[Fabian Vogt]

fvogt updated this revision to Diff 30250.
fvogt added a comment.


  Split into https://phabricator.kde.org/D11586

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D11584?vs=30248=30250

BRANCH
  snitest

REVISION DETAIL
  https://phabricator.kde.org/D11584

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtray.cpp
  libdbusmenuqt/dbusmenuimporter.cpp

To: fvogt, #plasma
Cc: plasma-devel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D11584: Set a transient parent for SNI context menus

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> StatusNotifierItem.qml:63
>  onClicked: {
> -var pos = plasmoid.nativeInterface.popupPosition(taskIcon, 0, 0);
> +var pos = plasmoid.nativeInterface.popupPosition(taskIcon, mouse.x, 
> mouse.y);
>  

This change is unrelated, and not a change I would support.

> systemtray.cpp:297
>  KAcceleratorManager::manage(menu);
> +menu->winId();
> +
> menu->windowHandle()->setTransientParent(statusNotifierIcon->window());

This part is all fine.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D11584

To: fvogt, #plasma
Cc: davidedmundson, plasma-devel, ZrenBot, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, mart