Re: bugfix in frameworks vital for 5.13

On 14/05/18 19:16, Marco Martin wrote: > Hi all, > about https://bugs.kde.org/show_bug.cgi?id=394134 which makes many new kcms > look borked, the problem actually wasn't the upstream qt bug (which is an > issue as well) > but another one which was actually in qqc2-desktop-style > now, since

Switchuser Issue

Hi, I have an issue with switch user in ksmserver on my newly installed Debian buster system (plama-workspaces 5.12.5): When I try to swich user, I get the switchuser dialog displayed, but when I click on switch, I get to my own session's lockscreen. This doesn't seem to be a general issue,

D12890: [Look and Feel KCM] Restore layout reset warning

broulik created this revision. broulik added reviewers: Plasma, VDG. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The "Use Desktop Layout from theme" is quite destructive, add

D12882: [Notifications] Move "Open With" items into the top group of the menu

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. Thanks! REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D12882 To: ngraham, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot,

D12890: [Look and Feel KCM] Restore layout reset warning

broulik updated this revision to Diff 34180. broulik edited the summary of this revision. broulik added a comment. - Remove unused `id` REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12890?vs=34179=34180 REVISION DETAIL

D12893: Fix Logout screen countdown not cancelling on multi-monitor setups

davidedmundson updated this revision to Diff 34195. davidedmundson marked 2 inline comments as done. davidedmundson added a comment. Address all comments REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12893?vs=34186=34195 BRANCH master

D12849: Improve layout of fonts kcm

progwolff added a comment. F5849518: Screenshot_fonts_layout_tab2.png F5849517: Screenshot_fonts_layout_tab1.png REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from master) REVISION

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34197. progwolff added a comment. - fix button widths REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34196=34197 BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34191. progwolff added a comment. - Use radio buttons. Use spacing instead of Separator. Simplify max(...). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34065=34191 BRANCH fonts_kcm_layout

D12849: Improve layout of fonts kcm

rkflx added a comment. In D12849#262693 , @progwolff wrote: > How about joining the options instead? > > F5849093: Screenshot_fonts_layout_radio.png Great idea! BTW, what's the difference

D12893: Fix Logout screen countdown not cancelling on multi-monitor setups

zzag added a comment. @broulik: `for ... in` iterates over the enumerable properties. This would lead to "weird unexpected"(not really) results. ECMAScript 2015 introduced `for ... of` statement that iterates over data. In most cases, `for ... of` should be preferred over `for ... in`,

KDE CI: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma%20plasma-vault%20kf5-qt5%20FreeBSDQt5.10/4/ Project: Plasma plasma-vault kf5-qt5 FreeBSDQt5.10 Date of build: Tue, 15 May 2018 11:38:32 + Build duration: 29 sec and counting CONSOLE OUTPUT

D12849: Improve layout of fonts kcm

progwolff marked an inline comment as done. progwolff added a comment. F5849439: Screenshot_fonts_layout_radio2.png REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D12849

D12837: Split replaceAccount from addAccountToCache

ngraham added a comment. Any chance we could land this on the stable branch? REPOSITORY R128 User Manager BRANCH master REVISION DETAIL https://phabricator.kde.org/D12837 To: valeriymalov, #plasma, davidedmundson Cc: davidedmundson, ngraham, rdieter, plasma-devel, ragreen, Pitel,

Re: Switchuser Issue

Hi, I digged a little further: On Dienstag, 15. Mai 2018 09:02:52 CEST Rainer Dorsch wrote: > Hi, > > I have an issue with switch user in ksmserver on my newly installed Debian > buster system (plama-workspaces 5.12.5): > > When I try to swich user, I get the switchuser dialog displayed, but

Re: Switchuser Issue

Hi, small addition: There is at least one user on #debian-kde who claims that sddm and switchuser works for him. For sddm this line should apply in kdisplaymanager.cpp: return exec("caps\n", re) && re.indexOf("\tlocal") >= 0; What does that do? I do not find a file caps which can be executed

D12849: Improve layout of fonts kcm

ngraham added a comment. Huge +1 on Henrik's suggestion for removing "Vendor Default" in another patch. This one is looking great though! However, by increasing the vertical size so much, the content is now going to require scrolling at the default System Settings window size of roughly

D12891: Make logout greeter share QMLEngine

This revision was automatically updated to reflect the committed changes. Closed by commit R120:0ff5e8d0fb22: Make logout greeter share QMLEngine (authored by davidedmundson). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12891?vs=34183=34194

D12849: Improve layout of fonts kcm

abetts added a comment. In D12849#262693 , @progwolff wrote: > How about joining the options instead? > > F5849093: Screenshot_fonts_layout_radio.png I like that! REPOSITORY R119 Plasma

D10297: Add new "Tools" button above System Monitor's process list

gregormi marked an inline comment as done. gregormi added inline comments. INLINE COMMENTS > rkflx wrote in CMakeLists.txt:37 > Is `Plasma` needed here? If so, I think this needs more discussion or should > be made optional. > > KSysGuard can also be used in other desktop environments and

D10297: Add new "Tools" button above System Monitor's process list

gregormi updated this revision to Diff 34204. gregormi added a comment. - Use qApp->desktopFileName() REPOSITORY R111 KSysguard Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10297?vs=34199=34204 BRANCH arcpatch-D10297_2 REVISION DETAIL

D12837: Split replaceAccount from addAccountToCache

valeriymalov added inline comments. INLINE COMMENTS > davidedmundson wrote in accountmodel.cpp:361 > On second look, I might have misunderstood. > > This isn't a replace, it's just making sure the current user is at the top? Yes. Replace code was added to `addAccountToCache` at some point

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34196. progwolff added a comment. - use tabs REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34191=34196 BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL

D12849: Improve layout of fonts kcm

progwolff added a comment. Using tabs there are some problems with Kirigami now: file:///usr/lib/qt/qml/org/kde/kirigami.2/ScrollablePage.qml:159: ReferenceError: applicationWindow is not defined ... : QML QQuickLayoutAttached: Binding loop detected for property "alignment"

D10297: Add new "Tools" button above System Monitor's process list

gregormi updated this revision to Diff 34199. gregormi marked 6 inline comments as done. gregormi added a comment. - Revert unrelated changes - Remove not needed Plasma dependency - Undo unrelated whitespace change - Clean code - Use blank lines instead of blocks REPOSITORY R111

D10297: Add new "Tools" button above System Monitor's process list

gregormi added inline comments. INLINE COMMENTS > rkflx wrote in ksysguardprocesslist.cpp:412 > Recently I learned comparing with `qApp->desktopFileName()` might be even > better than looking at the path of the executable… Interesting. This indeed returns "org.kde.ksysguard". Do you have an

D12837: Split replaceAccount from addAccountToCache

davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed. It might work, but it's overly messy. We have addAccountToCache which has an argument pos, which determines if we're adding or replacing. Then we have a

D12893: Fix Logout screen countdown not cancelling on multi-monitor setups

broulik added a comment. This is both genius and evil. I like that you kept it all in the theme. INLINE COMMENTS > timer.js:25 > > -import "../components" > +var callbacks = new Array(); > `var callbacks = [];` > timer.js:27 > > -ActionButton { > -property var action > -

Re: Cursor sizes on wayland

On Mon, May 14, 2018 at 7:42 PM, David Edmundson wrote: > We definitely need to scale the cursor image to device pixels in DRM Output. > That's code we need to add that I simply haven't done yet; it wasn't a high > priority as we also have the concept of just cursors

D12891: Make logout greeter share QMLEngine

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Gives a speed boost on multiple monitors

D12837: Split replaceAccount from addAccountToCache

davidedmundson added inline comments. INLINE COMMENTS > accountmodel.cpp:361 > if (uid == getuid()) { > addAccountToCache(path, acc, 0); > return; On second look, I might have misunderstood. This isn't a replace, it's just making sure the current user is at the top?

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#262777 , @rkflx wrote: > > BTW, what's the difference between Vendor Default and the regular Defaults button? Either we provide an option to reset to the default for every single option

D12849: Improve layout of fonts kcm

progwolff added a comment. How about joining the options instead? F5849093: Screenshot_fonts_layout_radio.png REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL https://phabricator.kde.org/D12849

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#262782 , @rkflx wrote: > In D12849#262781 , @progwolff wrote: > > > In D12849#262777 , @rkflx wrote: > > > > >

D12849: Improve layout of fonts kcm

rkflx added a comment. In D12849#262781 , @progwolff wrote: > In D12849#262777 , @rkflx wrote: > > > BTW, what's the difference between Vendor Default and the regular Defaults button? Either we

D12882: [Notifications] Move "Open With" items into the top group of the menu

ngraham closed this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D12882 To: ngraham, broulik Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12893: Fix Logout screen countdown not cancelling on multi-monitor setups

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY The logout greeter theme has a timer that

D12849: Improve layout of fonts kcm

zzag added inline comments. INLINE COMMENTS > main.qml:34 > id: formLayout > -readonly property int maxImplicitWidth: > Math.max(adjustAllFontsButton.implicitWidth, > Math.max(antiAliasingComboBox.implicitWidth, > Math.max(excludeField.implicitWidth,

D12837: Split replaceAccount from addAccountToCache

valeriymalov added a comment. > We have addAccountToCache which has an argument pos, which determines if we're adding or replacing. I've actually removed this bit, addAccountToCache now only adds accounts (either inserts at pos or appends) Though I agree that current code is

D12794: [weather applet] Improve name & comment metadata

This revision was automatically updated to reflect the committed changes. Closed by commit R114:286561d839e0: [weather applet] Improve name comment metadata (authored by kossebau). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12794?vs=34137=34189

D12849: Improve layout of fonts kcm

ngraham added a comment. @mart, are you aware of the issues with tabs in Kirigami? @progwolff, what happened to the frame for the tabbed view? Also, why is there still a scrollbar there? REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL

D12118: Only install translations if they are available

ltoscano requested changes to this revision. ltoscano added a comment. This revision now requires changes to proceed. This change should not be needed; ki18n_install is a noop operation if the directory does not exist - did you see any issue? REPOSITORY R129 Window Decoration Library

D12849: Improve layout of fonts kcm

progwolff added a comment. From what I could find there is no TabView in QtQuickControls2 or Kirigami. This is how it's done in Kirigami Gallery: F5849728: kirigami.png I agree that this should be improved, but it's probably better to do this in

D12849: Improve layout of fonts kcm

progwolff updated this revision to Diff 34209. progwolff added a comment. - fix tabbar frame REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12849?vs=34197=34209 BRANCH fonts_kcm_layout (branched from master) REVISION DETAIL

D12849: Improve layout of fonts kcm

ngraham added a comment. E, that doesn't look great. Sounds like the view in Kirigami needs some work. @mart Could we have the line extend all the way to the window edges, at least when No Borders is used? REPOSITORY R119 Plasma Desktop BRANCH fonts_kcm_layout (branched from

D12118: Only install translations if they are available

ltoscano added a comment. I'd argue that ki18n_install should be fixed instead. It does not make sense to duplicate the if check for every call to ki18n_install. REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D12118 To: heikobecker, #plasma,

D12849: Improve layout of fonts kcm

ngraham added a comment. In D12849#262919 , @progwolff wrote: > F5849709: Screenshot_fonts_layout_tabbar.png Hmm, typically there is a frame around the entire content of the tab, not just at the

D12118: Only install translations if they are available

heikobecker added a comment. Ping? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D12118 To: heikobecker, #plasma, graesslin Cc: plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

D12118: Only install translations if they are available

heikobecker added a comment. In D12118#262921 , @ltoscano wrote: > This change should not be needed; ki18n_install is a noop operation if the directory does not exist - did you see any issue? Yeah, it tries to install an empty dir:

D12102: Port Language KCM to Qt Quick

yurchor added a comment. Please, can I ask why is it impossible now to configure the keyboard layout as a result of this? https://cgit.kde.org/plasma-desktop.git/diff/kcms/CMakeLists.txt?id=6055cfb94e1e8e42278cd4bea7d4debe4e745c7b REPOSITORY R119 Plasma Desktop REVISION DETAIL

D12118: Only install translations if they are available

heikobecker added a comment. In D12118#262926 , @ltoscano wrote: > I'd argue that ki18n_install should be fixed instead. It does not make sense to duplicate the if check for every call to ki18n_install. Seems every other ki18n_install

D10297: Add new "Tools" button above System Monitor's process list

gregormi added a comment. This now ready from my side. REPOSITORY R111 KSysguard Library REVISION DETAIL https://phabricator.kde.org/D10297 To: gregormi, #plasma, colomar, kossebau, broulik, mart, hein Cc: apol, anthonyfieroni, andreaska, rkflx, ngraham, plasma-devel, ragreen, Pitel,

D12849: Improve layout of fonts kcm

progwolff added a comment. In D12849#262903 , @ngraham wrote: > @progwolff, what happened to the frame for the tabbed view? Did it the wrong way. Is fixed now. > Also, why is there still a scrollbar there? I have no idea. The

D12890: [Look and Feel KCM] Restore layout reset warning

This revision was automatically updated to reflect the committed changes. Closed by commit R119:a0d880b20440: [Look and Feel KCM] Restore layout reset warning (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12890?vs=34180=34181

D12849: Improve layout of fonts kcm

ngraham added a comment. Filed some bugs for Kirigami: - https://bugs.kde.org/show_bug.cgi?id=394295 - Tab widget's inactive tabs don't connect with the line below them - https://bugs.kde.org/show_bug.cgi?id=394296 - Kirigami tab widget should decide whether it wants to look like a

D12909: Don't create salt file if user home directory does not exist

aacid created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. REPOSITORY R107 KWallet PAM Integration BRANCH master REVISION DETAIL https://phabricator.kde.org/D12909 AFFECTED

D12910: Return PAM_IGNORE from pam_sm_authenticate

aacid created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. aacid requested review of this revision. REVISION SUMMARY PAM_SUCCESS signals to the PAM stack that the authentication succeeded. That is actually not the

D12777: Fixed access to current slideshow image using correct field in action_open

This revision was automatically updated to reflect the committed changes. Closed by commit R120:69a0e05bc54d: Fixed access to current slideshow image using correct field in action_open (authored by odeda, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D12916: Panel should not stop auto-hiding if a window wants attention

michaelmoon created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. michaelmoon requested review of this revision. REVISION SUMMARY BUG: 394119 I love an auto-hiding panel. However, if any window wants attention,