D14105: Use a broom-style icon for clearing clipboard and notification history

Zren added a comment. Should the context menu also use this icon? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D14105 To: ngraham, broulik, Fuchs, #plasma Cc: Zren, plasma-devel, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed, jensreuterberg, abetts,

D14081: Fix types, improve readability

gladhorn updated this revision to Diff 37724. gladhorn added a comment. Added * to auto pointers REPOSITORY R110 KScreen Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D14081?vs=37663=37724 BRANCH arcpatch-D14081 REVISION DETAIL https://phabricator.kde.org/D14081

D12804: Fix window frame rounding when scaling is used

davidedmundson added a comment. > And in that function qreal newScale = screens()->scale(m_screen); gets the value from here: https://github.com/KDE/kwin/blob/master/screens.cpp#L114 > You can see that this function just returns 1 The method is virtual. It definitely is not always 1.

Re: Discussion for Virtual Desktops and Activities future

Whilst personally I am in favour of just completely unifying, I think there's an option that might be a happy medium. --- If we were to unify, we would do the following: * Windows are not directly associated with activities * Windows are on N virtual desktops * Kwin and plasmashell

D14025: Move scale and unify button to the top, next to primary combo

colomar added a comment. The Unify Outputs button definitely makes sense to be there, but I'm not sure about the "Scale display" button. The "Primary display" selection and the Unify Outputs button both affect the whole setup, whereas Scale Display only affects the selected display,

D14025: Move scale and unify button to the top, next to primary combo

davidedmundson added a comment. It (currently) depends. There are two scale UI options with the appropriate one visible. The global scale factor for X is the only one that's moved. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D14025 To: gladhorn, #vdg,

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

ngraham added a comment. Good idea, @colomar. I did that in D10245#201638 , resulting in a change supported by at least a little bit of user testing: D11768: Add Desktop and Downloads to the default list of Places

D13734: Make GConf optional dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R115:c9fae1fb3f8e: Make GConf optional dependency (authored by drosca). Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY R115 Plasma

D14025: Move scale and unify button to the top, next to primary combo

colomar added a comment. In D14025#291499 , @davidedmundson wrote: > It (currently) depends. There are two scale UI options with the appropriate one visible. > > The global scale factor for X is the only one that's moved. Ah, cool,

D14035: Unbreak SSH agent support for SSH VPN tunnels.

jgrulich added inline comments. INLINE COMMENTS > secretagent.cpp:363 > +NetworkManager::VpnSetting::Ptr vpnSetting = > connectionSettings->setting(NetworkManager::Setting::Vpn).dynamicCast(); > +if (vpnSetting->serviceType() == > "org.freedesktop.NetworkManager.ssh" &&

D13593: [Fonts KCM] Improve user-friendliness of some anti-aliasing strings

colomar added a comment. I know that doing user research is not something favored here, but given how easy it is to use some user testing to settle discussions like this in a fact-based manner, I would really suggest the following: Each of us here who knows people that use English as their

D11198: [libbreezecommon] Add box shadow helper

rikmills added a comment. Fails to build from source: https://build.neon.kde.org/job/bionic_unstable_kde_breeze_bin_armhf/44/consoleFull 06:47:17 CMakeFiles/Makefile2:118: recipe for target 'libbreezecommon/CMakeFiles/breezecommon4.dir/all' failed 06:47:17

D11198: [libbreezecommon] Add box shadow helper

zzag added a comment. Gosh, I forgot that `qreal` can be also a float. On it. REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D11198 To: zzag, #breeze, #vdg, hpereiradacosta Cc: rikmills, ngraham, broulik, abetts, plasma-devel, ragreen, Pitel, ZrenBot,

D14090: [libbreezecommon] Fix build when qreal is float

zzag created this revision. zzag added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY 06:47:17 CMakeFiles/Makefile2:118: recipe for target

Re: Discussion for Virtual Desktops and Activities future

On Fri, Jul 13, 2018 at 1:54 PM David Edmundson wrote: > > Whilst personally I am in favour of just completely unifying, I think there's > an option that might be a happy medium. > > --- > > If we were to unify, we would do the following: So the following is not the "happy medium", but what you

Re: Discussion for Virtual Desktops and Activities future

@David Regarding the backend (wherever the actual logic ends up in - kwin or kamd), your idea does sound nice. It would also provide the ability that some of the 'C' category users wanted - to have variable number of VDs per activity. But the problem is not primarily how to handle the

Re: Discussion for Virtual Desktops and Activities future

VDs to inform KWin, if they are not part of the current activity and > therefore should not be switched to when switching through VDs. Also > the pager must know which VDs not to display in the current activity. > But as said this can be a porperty on the VDs and not on the Activity. > > > I

Re: Discussion for Virtual Desktops and Activities future

On Fri, 13 Jul 2018 08:22:31 -0700 Ivan Čukić wrote > This would provide the more obvious distinction - "groups" are for > window management and "activities" are about providing different > workspaces. "groups" would be volatile in the sense that their number > can vary a lot

Re: Discussion for Virtual Desktops and Activities future

> I think kwin shouldn't filter them. Pager lists all, effects and shortcuts > cover all. Ugh... I think that will kill the group 'C'*. While it /would/ be possible to to use multi-VD-multi-activity setup, it would be far from convenient. Or it would require an alternative set of applets that

Re: Discussion for Virtual Desktops and Activities future

On Fri, Jul 13, 2018 at 1:54 PM David Edmundson wrote: > * Windows are not directly associated with activities > > * Windows are on N virtual desktops > > * Kwin and plasmashell taskamanager/pagers only speak virtual desktops. > References to both VDs and activities in the UI are reduced to 1

Re: Discussion for Virtual Desktops and Activities future

On Thu, Jul 12, 2018 at 4:43 PM Ivan Čukić wrote: > Activities are not meant to be switched overly often. In the way that > I see activities, you switch to an activity and work for at least half > an hour. If a project deserves less time to focus on than half an > hour, it is either a one of a

Re: Discussion for Virtual Desktops and Activities future

> Work "stack" Home "stack" > || || > |VD 1| |VD 3| > | Web browser| | Web browser| > | IDE| |Music player| > || || > > || || > |VD 2| |VD

Re: Discussion for Virtual Desktops and Activities future

On Fri, Jul 13, 2018 at 5:51 PM, Ivan Čukić wrote: > > I think kwin shouldn't filter them. Pager lists all, effects and > shortcuts > > cover all. > > Ugh... I think that will kill the group 'C'*. While it /would/ be > possible to to use multi-VD-multi-activity setup, it would be far from >

D12804: Fix window frame rounding when scaling is used

anemeth updated this revision to Diff 37718. anemeth added a comment. Rebase on master REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D12804?vs=33941=37718 BRANCH master REVISION DETAIL https://phabricator.kde.org/D12804 AFFECTED FILES

D14105: Use a broom-style icon for clearing clipboard and notification history

ngraham created this revision. ngraham added reviewers: broulik, Fuchs, Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Use Breeze's new broom-style icon for the Clear

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. F6100511: breeze2x.PNG REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D12804 To: anemeth, #breeze, #vdg, hpereiradacosta, davidedmundson Cc: zzag, davidedmundson, ngraham, plasma-devel, ragreen, Pitel,

Re: Discussion for Virtual Desktops and Activities future

I find it very constructive in the discussion that everyone speaks its mind in order to understand better what we are trying to accomplish here. Based on that I think that there are some goals that almost all agree. G1: Simplify the Activities/VDs infrastructure for kwin and plasma desktop in

D12804: Fix window frame rounding when scaling is used

anemeth added a comment. As others said the dpi scaling should normally be dealt with `QImage::setDevicePixelRatio()` As far as I can tell this is not working with Breeze for the following reason: The decoration rendering starts here: