D18802: Fix pragma once problem with process class

davidedmundson added a comment. > @mart commit message updated, @alexeymin I believe that you'll find the answer for this question in my new commit message :) It hasn't updated what phab shows. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To:

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. It compiles but I could not test this. When I run the plasma-discover segmentation fault prevails. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D18766 To: shubham, apol, ngraham Cc: ngraham, broulik, plasma-devel,

D18861: Improve the Fonts KCM UI

davidedmundson accepted this revision. davidedmundson added a comment. > Perhaps "Modernize" would be a more specific word than "Improve"? Not really. There's nothing "modern" about putting an icon on a button. adding "UI" helps clarify it's not behavioural changes. That'll do.

D18861: Improve the Fonts KCM UI

ngraham added a comment. Perhaps "Modernize" would be a more specific word than "Improve"? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc: davidedmundson, ndavis, ngraham, rooty, plasma-devel, #vdg, #plasma,

D18801: CMakeLists: Fix bfd.h include path on windows

patrickelectric updated this revision to Diff 51256. patrickelectric added a comment. update commit message REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18801?vs=51067=51256 BRANCH arcpatch-D18801 REVISION DETAIL https://phabricator.kde.org/D18801

D18802: Fix pragma once problem with process class

davidedmundson added a comment. Your comment doesn't match what the internet says about "#pragma once" (though it is a non-standard and some compilers are weird) Two files with the same filename should be included twice. REPOSITORY R871 DrKonqi REVISION DETAIL

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. In D18809#408461 , @alexde wrote: > Great work! > > Currently you have a very long folder list object. However, in my experience most users only have a few folders, where they store their wallpapers. > So, what

D18766: Don't show tooltip when search field has text and set a timeout period

shubham updated this revision to Diff 51272. shubham added a comment. Remove timeout period REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18766?vs=50977=51272 BRANCH search REVISION DETAIL https://phabricator.kde.org/D18766 AFFECTED

D18802: Fix pragma once problem with process class

patrickelectric added a comment. https://stackoverflow.com/questions/17107410/qt-field-has-incomplete-type REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: alexeymin, mart, plasma-devel, jraleigh,

D18802: Fix pragma once problem with process class

patrickelectric added a comment. @mart commit message updated, @alexeymin I believe that you'll find the answer for this question in my new commit message :) REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava,

D18802: Fix pragma once problem with process class

patrickelectric updated this revision to Diff 51257. patrickelectric added a comment. Update commit message REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18802?vs=51068=51257 BRANCH arcpatch-D18802 REVISION DETAIL https://phabricator.kde.org/D18802

D18801: CMakeLists: Fix bfd.h include path on windows

patrickelectric added a comment. @mart commit message updated. REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18801 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18861: Improve the look of the Fonts KCM UI

GB_2 updated this revision to Diff 51274. GB_2 added a comment. Show pt after font size and remove seperator in the font preview. Also apply the KDE HIG even more. REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18861?vs=51213=51274 BRANCH master

D18890: Add button to reset index database and repair Baloo crashing

guoyunhe created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. guoyunhe requested review of this revision. REVISION SUMMARY Here are a lot of bug reports of Baloo crashing caused by corrupted database. This patch provide a button in KCM to quickly

D18892: Move Look and Feel KCM to top level

rooty accepted this revision. rooty added a comment. This revision is now accepted and ready to land. this seems like a simple enough change and we did agree to put it there, but maybe wait for someone else to okay it too before landing it you got my vote though REPOSITORY R119 Plasma

D18886: Remove unused dependencies

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. TEST PLAN Probably doesn't make a dent as we still pull in all of KIOWidgets for one usage of

D18766: Don't show tooltip when search field has text and set a timeout period

ngraham added a comment. Works for me, no segfault. I don't see any reason why this change could cause that. @shubham, does the segfault stop happening when you build Discover from source without this change? REPOSITORY R134 Discover Software Store REVISION DETAIL

D18861: Improve the look of the Fonts KCM UI

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Looks good to me! REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty, davidedmundson Cc:

D18892: Move Look and Feel KCM to top level

GB_2 created this revision. GB_2 added reviewers: Plasma, VDG. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. GB_2 requested review of this revision. REVISION SUMMARY Moves the LnF KCM from the Workspace Theme category to the top level (to the Appearance section),

D18766: Don't show tooltip when search field has text and set a timeout period

shubham added a comment. In D18766#408901 , @ngraham wrote: > Works for me, no segfault. I don't see any reason why this change could cause that. @shubham, does the segfault stop happening when you build Discover from source without this

D18716: Add a TextField component

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > TextField.qml:74 > + */ > +property QtObject rightAction > + I would like those to actually be lists as we do have use cases for more than one icon

D18645: BasicListItem: use specified tint color when transparency is 0

mart added a comment. can you try on kirigami master? i did a similar thing the other day with commit 015e1d0ac19e4 REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D18645 To: pwegner,

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added a comment. I just build the patch in a VM and it works as intended. Sorry I would have hoped that it didn't work so that I could investigate your issue. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18809 To: davidre, #vdg, ngraham Cc:

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

davidre added inline comments. INLINE COMMENTS > ngraham wrote in WallpaperDelegate.qml:40 > I just realized: setting this to false when in slideshow mode is a quick way > to make them non-selectable. That doesn't work - they're still selectable but now we don't get the "open containing

D18645: BasicListItem: use specified tint color when transparency is 0

pwegner added a comment. In the current master I get `file:///home/lemourin/.qt/5.12.1/gcc_64/qml/org/kde/kirigami.2/private/GlobalDrawerActionItem.qml:39:5: Unable to assign [undefined] to QColor` (probably related to some other change). Anyway, tinting can be disabled now after your

D18861: Improve the Fonts KCM UI

davidedmundson added a comment. Please use more descriptive messages than "Improve the blahblah". Practically every single commit aims to improve the product. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D18861 To: GB_2, #plasma, #vdg, ngraham, rooty Cc:

D18809: Image Wallpaper Slideshow - display the list of images that will be shown

alexde added a comment. Great work! Currently you have a very long folder list object. However, in my experience most users only have a few folders, where they store their wallpapers. So, what about saving space by positioning the folder list to the right of the controls? As we now

D18861: Improve the Fonts KCM UI

GB_2 added a comment. In D18861#408459 , @davidedmundson wrote: > Please use more descriptive messages than "Improve the blahblah". > Practically every single commit aims to improve the product. I added the word UI, what do you

D18867: Remove redundant DNS field per bug 403546

lbeltrame added a comment. Migrating sounds like a good idea. I don't think popups are necessary for this. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D18867 To: andersonbruce, jgrulich Cc: lbeltrame, plasma-devel, jraleigh, GB_2,

D18802: Fix pragma once problem with process class

mart added a comment. needs better commit message REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18801: CMakeLists: Fix bfd.h include path on windows

mart added a comment. needs longer commit message REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18801 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot, lesliezhai, ali-mohamed,

D18640: Reset tooltip delegate label height to defaults

mart added a comment. In D18640#403147 , @broulik wrote: > Supposedly fixed in Qt 5.12.1? https://bugreports.qt.io/browse/QTBUG-71684 with 5.12.1 the patch woudn't be necessary anymore? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D18796: [PassiveNotification] Don't start timer until window has focus

mart requested changes to this revision. mart added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > PassiveNotification.qml:65 > +//be working with multiple windows at once > +timer.running = Qt.binding(function() { > +return

D18839: Port Cards Grid, Cards List and Inline Messages extra information to json-based info sheet

This revision was automatically updated to reflect the committed changes. Closed by commit R1014:d8ce1591e861: Port Cards Grid, Cards List and Inline Messages extra information to json-based… (authored by dkardarakos). REPOSITORY R1014 Kirigami Gallery CHANGES SINCE LAST UPDATE

D18802: Fix pragma once problem with process class

alexeymin added a comment. Is it because process.h exists somewhere else? REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D18802 To: patrickelectric, davidedmundson, tcanabrava, ngraham Cc: alexeymin, mart, plasma-devel, jraleigh, GB_2, ragreen, Pitel, ZrenBot,

D18640: Reset tooltip delegate label height to defaults

mart added inline comments. INLINE COMMENTS > ngraham wrote in main.qml:227 > If we do end up going with this patch, I'd like to see comments explaining > why these are set to `undefined`. look at https://doc.qt.io/qt-5/properties.html at the RESET function (basically, properties that provide