D22509: [ComboBox] Set close policy to close on click outside instead of only outside parent

ngraham added a comment. I'm not seeing any change from this patch in the wallpaper chooser page for example. Clicking on the combobox while the popup is open still doesn't close it. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D22509

D22517: kcms: translations: Make list separator translatable

aspotashev created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. aspotashev requested review of this revision. TEST PLAN none REPOSITORY R120 Plasma Workspace BRANCH i18n-sep REVISION DETAIL https://phabricator.kde.org/D22517 AFFECTED FILES

D22333: Move Solid::Device::listFromQuery calls to a separate thread

bruns added a comment. In D22333#496544 , @davidedmundson wrote: > Kinda, you're summary missing a key part. > (the commit description is a bit poor) > > This patch does the following: > > - It does the search in the other thread.

D22514: Show if KRunner is still searching for more things

apol created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY Shows a busy indicator in the TextField. Depends on D22513 TEST PLAN Searched things,

D18860: Add comment / description to the translations kcm

jbbgameich updated this revision to Diff 61930. jbbgameich added a comment. Update description once again REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D18860?vs=51321=61930 BRANCH arcpatch-D18860 REVISION DETAIL

D22034: Introduce ContainmentLayoutManager QML plugin

davidedmundson added a comment. Concept makes sense. I mostly like the layering and architecture, except for all the cases where we end up searching up the hierarchy to find objects. That doesn't seem quite as nicely layered. I'm not finished, it's a big patch - but I thought I should

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

bshah added a comment. (me confused by cryptic comment) :P REPOSITORY R120 Plasma Workspace BRANCH translations-no-systemsettings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich, hein Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh,

D10747: Implement zwp_linux_dmabuf_v1

romangg updated this revision to Diff 61912. romangg added a comment. - Rebase on master - Use packaged dma-buf xml REPOSITORY R127 KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10747?vs=60654=61912 BRANCH dmaBuf REVISION DETAIL

D10747: Implement zwp_linux_dmabuf_v1

romangg added a comment. If there are no objections I would push this soon. There is one remaining annoyance I have with the current version: the name of the class inside the interface the compositor has to subclass for interfacing with KWayland. I changed the name from Bridge to Impl

D22458: [sddm-theme] Add slot to configure a logo to be shown on the SDDM login screen

cblack updated this revision to Diff 61916. cblack added a comment. Hide logo by default REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22458?vs=61859=61916 BRANCH distro-logo-slot (branched from master) REVISION DETAIL

D10750: [wayland] Add support for zwp_linux_dmabuf

romangg updated this revision to Diff 61915. romangg marked 2 inline comments as done. romangg added a comment. Rebase on master. REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D10750?vs=60898=61915 BRANCH dmaBuf REVISION DETAIL

D10750: [wayland] Add support for zwp_linux_dmabuf

romangg marked an inline comment as done. romangg added inline comments. INLINE COMMENTS > romangg wrote in abstract_egl_backend.cpp:405 > rm Nope, better not. Overlooked the `m_`. REPOSITORY R108 KWin REVISION DETAIL https://phabricator.kde.org/D10750 To: romangg, #kwin, #plasma,

D22513: Expose if we're still searching for more results

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. TEST PLAN Tested with a patch in plasma-workspace I'll upload shortly REPOSITORY R112 Milou BRANCH master REVISION

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. This creayes REPOSITORY R120 Plasma Workspace BRANCH translations-no-systemsettings (branched from master) REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich, hein Cc:

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

This revision was automatically updated to reflect the committed changes. Closed by commit R120:08a802656df5: kcms: translations: use availableDomainTranslations from plasmashell instead of… (authored by jbbgameich). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D22363: Remove cursor theme option

filipf updated this revision to Diff 61940. filipf added a comment. remove CursorTheme entry in config file when resetting theme syncing REPOSITORY R123 SDDM Configuration Panel (KCM) CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22363?vs=61481=61940 BRANCH

D22363: Remove cursor theme option

filipf planned changes to this revision. filipf added a comment. This should now be completely functional. In order to proceed further, the dependent revision needs to be landed and then this patch rebased on master. REPOSITORY R123 SDDM Configuration Panel (KCM) REVISION DETAIL

D22457: Make it possible to show the QR of a network connection

apol updated this revision to Diff 61944. apol added a comment. Hopefully address Nate's complaint on how it ends up behind the expanded plasmoid REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22457?vs=61885=61944 BRANCH master

D22457: Make it possible to show the QR of a network connection

ngraham accepted this revision. ngraham added a comment. Yep, that did it! REPOSITORY R116 Plasma Network Management Applet BRANCH master REVISION DETAIL https://phabricator.kde.org/D22457 To: apol, #plasma, jgrulich, ngraham Cc: broulik, ngraham, plasma-devel, LeGast00n, jraleigh,

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

hein added a comment. Sorry, the cryptic comment can be safely ignored. I had a concern at first, then looked into it, decided I'm OK with the patch and forgot the started sentence. :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich,

D22506: Read BAMF_DESKTOP_FILE_HINT from environment

hein added a comment. The idea and approach are good. But disk I/O in a UI hotpath is pretty scary. I do think a cache would be a good addition. In general I think libtm could use some improvements on its currently very coarse cache eviction scheme. It's mostly fine but there are

D18860: Add comment / description to the translations kcm

hein added a comment. How about - and sorry if you're tired of the patch by now - "Change workspace and application languages"? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol,

D22306: Do not skip code launching application in application dashboard

hein added a comment. First of, run `kdebugsettings` and make sure that debug output isn't disabled on your system. Then you can e.g. stop plasmashell from a terminal with: `kquitapp5 plasmashell` And restart it with `plasmashell`, and you'll see `console.log` output on the

D18860: Add comment / description to the translations kcm

hein added a comment. Agreed with Harald, the wording's misleading sorry :) REVISION DETAIL https://phabricator.kde.org/D18860 To: jbbgameich, hein, #plasma, ngraham Cc: bshah, sitter, apol, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot, himcesjf,

D22493: [Notifications] Move history items' icons over to the left a bit

broulik added a comment. Is it just me or does vertical alignment look off now? How does it affect the popup layout? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22493 To: ngraham, broulik, #vdg, #plasma Cc: plasma-devel, LeGast00n, jraleigh,

Re: how about a developer KCM

On 7/16/19 11:36 PM, Nate Graham wrote: On 7/16/19 8:32 AM, David Edmundson wrote: However, I fear it will end up becoming some sort of hidden plasma-tweaks, where we dump general aesthetic/behaviour settings in here which we think are too niche for the main UI. I don't want that to happen.

D22306: Do not skip code launching application in application dashboard

hein added a comment. I see what this is trying to do, but some of the details seem a bit wrong. E.g. you're only setting `dragging` to false in a code branch that's only executed when it already is false, which means it's not going to be set to false on a drag release, and pressX/Y

Re: how about a developer KCM

Am 17.07.19 um 08:50 schrieb Eike Hein: I think DrKonqi-related options are natural fit in 'kdebugsettings' however. This app already exists, is essentially for devs, and has domain overlap with what DrKonqi does. That is exactly where I wanted to put said option but got rejected. Cheers Kai

D22482: WIP: Show file dialog in directory mode when only directory is requested

jgrulich added a comment. What would be the usecase here? I can think of Firefox only, but as I mentioned, it won't work with Firefox, because it behaves exactly the same way as Qt, which means a dialog inside sandbox is opened when requesting to open a folder. REPOSITORY R838 Flatpak

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

jbbgameich created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. jbbgameich requested review of this revision. REVISION SUMMARY The kcm might be used with different settings apps like plasma-settings, in that case systemsettings is not installed.

D22493: [Notifications] Move history items' icons over to the left a bit

ndavis added a comment. In D22493#496618 , @broulik wrote: > Is it just me or does vertical alignment look off now? How does it affect the popup layout? Doesn't seem different from the current vertical alignment. F7037286:

D22503: kcms: translations: use availableDomainTranslations from plasmashell instead of systemsettings

bshah added subscribers: hein, bshah. bshah added a comment. Personally speaking, +1, would love opinion of @hein REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22503 To: jbbgameich Cc: bshah, hein, plasma-devel, LeGast00n, jraleigh, fbampaloukas, GB_2,

D22505: [SpinBox] Set renderType

broulik created this revision. broulik added reviewers: Plasma, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures it uses the system's font rendering settings BUG: 409888 TEST PLAN Fonts KCM

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg updated this revision to Diff 61910. romangg marked 23 inline comments as done. romangg added a comment. - Message on backend error - Use switch statements in OutputModel - Initialize roleNames from super class - i18n labels - Checkboxes to the left - Set onClicked -

D22509: [ComboBox] Set close policy to close on click outside instead of only outside parent

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Ensures clicking the `ComboBox` itself closes the popup as it does with widget `QComboBox`.

D22468: Rewrite KScreen KCM as ConfigModule with outputs model and Kirigami

romangg added inline comments. INLINE COMMENTS > broulik wrote in OutputPanel.qml:41 > Try `Kirigami.FormData.checkable: true` to make the checkbox to the left > instead of having a lonely tiny checkbox floating there Then there are two checkboxes. Looked at Night Color KCM, which does it by

D22493: [Notifications] Move history items' icons over to the left a bit

broulik added a comment. No, no, leave the popup :P I was asking to make sure it doesn't accidentally change the popups. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22493 To: ngraham, broulik, #vdg, #plasma Cc: ndavis, plasma-devel, LeGast00n,

D22493: [Notifications] Move history items' icons over to the left a bit

ngraham added a comment. Yeah, this patch touches only the history items, not the popups. I can do that too, if you'd like. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D22493 To: ngraham, broulik, #vdg, #plasma Cc: ndavis, plasma-devel, LeGast00n,

D22506: Read BAMF_DESKTOP_FILE_HINT from environment

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY This contains the actual name of the desktop file which might be different from the one the

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 61901. guoyunhe edited the summary of this revision. guoyunhe added a comment. Change default collectionId to all wallpapers instead of desktop wallpaper REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D22306: Do not skip code launching application in application dashboard

luc4 added a comment. Unfortunately I'm not able to get logs from plasma-desktop. Can someone explain how (assuming this is possible) to write logs in this portion of code and read? Or can you point me to docs? I tried to add console.log calls and read using journalctl but I don't see the

D22494: Attempt to support different collections of Unsplash

guoyunhe updated this revision to Diff 61899. guoyunhe added a comment. Add all Unsplash Wallpaper collections REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22494?vs=61877=61899 BRANCH master REVISION DETAIL https://phabricator.kde.org/D22494