D21860: Set a font for gtk applications in the fonts kcm

gikari added inline comments. INLINE COMMENTS > broulik wrote in fonts.cpp:607 > kded (the application you're running in) is a `QApplication`, so from the > constructor of your kdedmodule you could do > > #include > connect(qApp, ::fontChanged, this, [this](this QFont ) > { > //

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

cblack updated this revision to Diff 64698. cblack added a comment. DRY that code REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23451?vs=64606=64698 BRANCH window-button-symbolics (branched from master) REVISION DETAIL

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

ndavis added a comment. Seems like people still complain about the patch, so I'll go ahead and land this. REPOSITORY R119 Plasma Desktop BRANCH revert-showdesktop-minimizall (branched from master) REVISION DETAIL https://phabricator.kde.org/D22359 To: ndavis, #vdg, #plasma,

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

This revision was automatically updated to reflect the committed changes. Closed by commit R98:fa8e67c617f3: [GTK3] Recolor CSD titlebuttons according to users color scheme (authored by cblack). REPOSITORY R98 Breeze for Gtk CHANGES SINCE LAST UPDATE

D22359: Revert "[showdesktop][minimizeall] Reduce the maximum panel icon size"

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9705414e3ec3: Revert [showdesktop][minimizeall] Reduce the maximum panel icon size (authored by ndavis). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

luc4 updated this revision to Diff 64689. luc4 added a comment. Updated according to requests. REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22774?vs=63248=64689 REVISION DETAIL https://phabricator.kde.org/D22774 AFFECTED FILES

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

ognarb accepted this revision. ognarb added a comment. Much better now thanks :) REPOSITORY R98 Breeze for Gtk BRANCH window-button-symbolics (branched from master) REVISION DETAIL https://phabricator.kde.org/D23451 To: cblack, #breeze, #vdg, ngraham, ognarb Cc: ognarb, plasma-devel,

D23174: Improve the look of the Activities KCM UI

This revision was automatically updated to reflect the committed changes. Closed by commit R119:fbd0465c3b1c: Improve the look of the Activities KCM UI (authored by GB_2). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23174?vs=63818=64686 REVISION

D23049: Add Kirigami ListSectionHeader component

GB_2 added a comment. Ping. REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D23049 To: GB_2, #kirigami, #vdg, mart, ngraham Cc: jbbgameich, ognarb, davidre, ngraham, #vdg, plasma-devel, #kirigami, fbampaloukas, GB_2, domson, dkardarakos, apol, davidedmundson, mart,

D23174: Improve the look of the Activities KCM UI

ngraham added a comment. Hooray! Next, do you think you could clean up the applications list so there aren't all those duplicates and they all get icons? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23174 To: GB_2, #plasma, #vdg, ivan, ngraham,

D23469: Move the notifier logic into a separate process

apol updated this revision to Diff 64711. apol added a comment. Fix build with gcc REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23469?vs=64680=64711 BRANCH notifier REVISION DETAIL https://phabricator.kde.org/D23469 AFFECTED FILES

D23242: Add grouping and "Show Only Minimized" options to icons-only task manager

GB_2 added a comment. Ping @hein REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23242 To: GB_2, #plasma, #vdg, hein, ngraham Cc: ngraham, hein, #vdg, plasma-devel, #plasma, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, Pitel, ZrenBot,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 marked 2 inline comments as done. GB_2 added a comment. This is what happens when you set the current index to -1: F7282553: System Settings Sidebar Show Intro Page Button Bug.png REPOSITORY R124 System Settings REVISION DETAIL

D23152: [energy kcm] Display Vendor and model

This revision was automatically updated to reflect the committed changes. Closed by commit R102:708879b54aa8: [energy kcm] Display Vendor and model (authored by meven). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23152?vs=64424=64627 REVISION DETAIL

D23386: [Applet] Double-click on icon to make it the default

davidedmundson added a comment. I don't like patches with secret features that rely on double click. We don't use double click in our UIs and we should be consistent. Also if we do have a UX problem where finding how to change the default is hard (which D23389

D21860: Set a font for gtk applications in the fonts kcm

broulik added inline comments. INLINE COMMENTS > fonts.cpp:607 > +}; > +kdedInterface.call("setFont", m_generalFont.toString()); > +} Given this is a kded module and as such a regular qt application, you should be able to get all of this automatically. Is the

D23261: Add option to discourage reporting bugs

This revision was automatically updated to reflect the committed changes. Closed by commit R871:81c4e8f53148: Add option to discourage reporting bugs (authored by broulik). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23261?vs=64649=64650 REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.13 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.13/6/ Project: kf5-qt5 WindowsMSVCQt5.13 Date of build: Mon, 26 Aug 2019 09:59:36 + Build duration: 9 min 49 sec and counting CONSOLE OUTPUT

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

davidedmundson added a comment. > Could you update the title and summary so they reflect what's in the patch now? This isn't done (or at least phabricator is being unhelpful and not showing it if you have) REPOSITORY R114 Plasma Addons REVISION DETAIL

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

luc4 added a comment. In D22774#519403 , @davidedmundson wrote: > > Could you update the title and summary so they reflect what's in the patch now? > > This isn't done (or at least phabricator is being unhelpful and not showing it if you

D22514: Show if KRunner is still searching for more things

broulik added inline comments. INLINE COMMENTS > RunCommand.qml:105 > + > +opacity: queryTimer.stillQuerying ? 1 : 0 > +running: visible Easier would be `!queryTimer.running && results.querying`, then you don't need any of the custom state tracking And then

D23461: Remove 'magic' filtering of recent apps

tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision. REVISION SUMMARY The recent app wasn't displayed if it's recent *and* favorites. REPOSITORY R119 Plasma Desktop BRANCH

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

davidedmundson added a comment. Generally seems ok. Two minor comments. INLINE COMMENTS > main.qml:238 > +_iconName: "edit-redo" > +_text: i18nd("libplasma5", "Redo") > +onTriggered: contextMenu.retFocus(() => >

Monday meeting notes for 26/8/2019

Kai Uwe plasma-browser-integration: * Threshold for controlling short videos has been increased from 5s to 8s * Failure error message has been removed in favor of a toolbar icon with popup * Enhanced media controls are enabled by default now * Minor improvements and reliability fixes for tabs

D22514: Show if KRunner is still searching for more things

apol updated this revision to Diff 64653. apol added a comment. delay REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22514?vs=64265=64653 BRANCH arcpatch-D22514 REVISION DETAIL https://phabricator.kde.org/D22514 AFFECTED FILES

D21035: Remove disconnected network devices from Network Monitor.

jgrulich added a subscriber: mart. jgrulich added a comment. Looks good to me, but I'm not the author of this code. I would rather let @mart to approve this review. INLINE COMMENTS > Applet.qml:71 > +function removeSource(source1, friendlyName1, source2, friendlyName2) { > +var

D21860: Set a font for gtk applications in the fonts kcm

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in fonts.cpp:607 > Given this is a kded module and as such a regular qt application, you should > be able to get all of this automatically. > Is the `QGuiApplication::fontChanged` emitted when you change font settings? There

D23261: Add option to discourage reporting bugs

broulik added inline comments. INLINE COMMENTS > sitter wrote in statusnotifier.cpp:144 > I care more about the context that this is a notification message than about > the brevity recommendation. We never do that. Do we have a `@context` for that or should I just write `i18nc("Notification

D23261: Add option to discourage reporting bugs

sitter added inline comments. INLINE COMMENTS > broulik wrote in statusnotifier.cpp:144 > We never do that. Do we have a `@context` for that or should I just write > `i18nc("Notification text", "...")`? We do not. I always check my handy cheat sheet

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. :/ good catch. INLINE COMMENTS > startuptasksmodel.cpp:178 > +// drop ".desktop" suffix > +appId.chop(8); > I quite like doing

D23261: Add option to discourage reporting bugs

broulik updated this revision to Diff 64647. broulik added a comment. Herald added a project: Dolphin. Herald added a subscriber: kfm-devel. - Add i18nc REPOSITORY R318 Dolphin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23261?vs=64038=64647 REVISION DETAIL

D23261: Add option to discourage reporting bugs

sitter added inline comments. INLINE COMMENTS > sitter wrote in main.cpp:225 > Surely it should also return right away if isShuttingDown down and > interaction isn't allowed, otherwise you create a dump needlessly on account > of the user not being meant to report it. What about this?

D23448: Capacity degradation -> Battery health

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. That's much clearer. REPOSITORY R120 Plasma Workspace BRANCH degradation-to-health (branched from master) REVISION DETAIL https://phabricator.kde.org/D23448 To:

D23261: Add option to discourage reporting bugs

sitter accepted this revision. sitter added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R871 DrKonqi REVISION DETAIL https://phabricator.kde.org/D23261 To: broulik, #plasma, sitter Cc: kfm-devel, sitter, davidedmundson, plasma-devel, aprcela,

D23241: Show application window icon on AboutPage

sitter added inline comments. INLINE COMMENTS > caspermeijn wrote in settings.h:81 > I have no idea what the value would be for that and Kirigami doesn't have any > example. https://doc.qt.io/qt-5/qtqml-cppintegration-definetypes.html#type-revisions-and-versions tldr: - add `REVISON 10` to

D23261: Add option to discourage reporting bugs

broulik updated this revision to Diff 64649. broulik added a comment. - Do nothing when shutting down in non-interactive mode REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23261?vs=64647=64649 REVISION DETAIL https://phabricator.kde.org/D23261

D22176: Rework system tray settings

nicolasfella added a comment. In D22176#519573 , @kmaterka wrote: > @nicolasfella I updated D23413 , now it can be used in configuration entries. Can you check if you can use this? That makes sense,

D23449: Capacity degradation -> Battery health

ngraham updated this revision to Diff 64658. ngraham added a comment. Rebase REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23449?vs=64603=64658 BRANCH degradation-to-health (branched from master) REVISION DETAIL

D23449: Capacity degradation -> Battery health

This revision was automatically updated to reflect the committed changes. Closed by commit R102:3795d42091a1: Capacity degradation - Battery health (authored by ngraham). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23449?vs=64658=64659#toc REPOSITORY R102 KInfoCenter CHANGES SINCE

D22514: Show if KRunner is still searching for more things

broulik accepted this revision. broulik added a comment. This revision is now accepted and ready to land. I still think it should be more than 200ms, more like 500ms. INLINE COMMENTS > RunCommand.qml:103 > +opacity: !queryTimer.running && results.querying ? 1 : 0 > +

D23448: Capacity degradation -> Battery health

This revision was automatically updated to reflect the committed changes. Closed by commit R120:441c3449dab6: Capacity degradation - Battery health (authored by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23448?vs=64621=64656 REVISION

D22514: Show if KRunner is still searching for more things

This revision was automatically updated to reflect the committed changes. Closed by commit R120:fae4515f23fc: Show if KRunner is still searching for more things (authored by apol). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D22514?vs=64655=64661#toc REPOSITORY R120 Plasma Workspace

D23463: Fix PrivateActionToolButton with menu not clearing checked state properly

ahiemstra updated this revision to Diff 64663. ahiemstra edited the test plan for this revision. ahiemstra added a comment. - Fix null object error REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23463?vs=64662=64663 BRANCH fix_actiontoolbutton

D23417: libtaskmanager: fix launch url for startup info with pathless desktop file

This revision was automatically updated to reflect the committed changes. Closed by commit R120:4f309328ee00: libtaskmanager: fix launch url for startup info with pathless desktop file (authored by kossebau). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D23417?vs=64529=64665#toc

D22514: Show if KRunner is still searching for more things

apol updated this revision to Diff 64655. apol added a comment. simplify REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D22514?vs=64653=64655 BRANCH arcpatch-D22514 REVISION DETAIL https://phabricator.kde.org/D22514 AFFECTED FILES

D23386: [Applet] Double-click on icon to make it the default

ngraham abandoned this revision. ngraham added a comment. Yeah, I don't disagree. Let's focus on D23389 . REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D23386 To: ngraham, drosca, #plasma Cc: davidedmundson,

D23463: Fix PrivateActionToolButton with menu not clearing checked state properly

ahiemstra created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY When closing the menu of a PrivateActionToolButton with a click on the button, the checked state of the button would not

D23463: Fix PrivateActionToolButton with menu not clearing checked state properly

ahiemstra updated this revision to Diff 64664. ahiemstra added a comment. - Remove usage of no longer existing property REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23463?vs=64663=64664 BRANCH fix_actiontoolbutton REVISION DETAIL

D21860: Set a font for gtk applications in the fonts kcm

gikari added inline comments. INLINE COMMENTS > broulik wrote in fonts.cpp:607 > Given this is a kded module and as such a regular qt application, you should > be able to get all of this automatically. > Is the `QGuiApplication::fontChanged` emitted when you change font settings? @broulik I do

D21860: Set a font for gtk applications in the fonts kcm

broulik added inline comments. INLINE COMMENTS > gikari wrote in fonts.cpp:607 > @broulik I do not understand. `KDEDModule` (which is a parent of `GtkConfig`) > is `QObject`, not a `QGuiApplication`. Maybe I am missing something? You want > me to create a connection with that signal within a

D23413: [System Tray] Unified data model for System Tray items

kmaterka updated this revision to Diff 64669. kmaterka added a comment. Now the same model is used for: - rendering all items, both Plasmoids and StatusNotifications - "Entries" configuration page That should greatly simplify the https://phabricator.kde.org/D22176 (this is not my

D22176: Rework system tray settings

kmaterka added a comment. @nicolasfella I updated D23413 , now it can be used in configuration entries. Can you check if you can use this? I like the idea of removing "Categories", these are confusing and probably no-one uses them. **Important

D23461: Remove 'magic' filtering of recent apps

davidedmundson requested changes to this revision. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > recentusagemodel.cpp:98 > - > -return (service && (!favoritesModel || > !favoritesModel->isFavorite(service->storageId(; > -}

D22774: In the note applet, always paste without formatting by default. Add an action to paste preserving formatting in the contextual menu.

davidedmundson added inline comments. INLINE COMMENTS > luc4 wrote in main.qml:238 > I think I copied from here: > https://git.reviewboard.kde.org/r/121698/diff/1/#. Is it outdated maybe? ~ish. To explain what it's doing. i18n("hello") will return a translated version of the word "hello"

D23469: Move the notifier logic into a separate process

apol created this revision. apol added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. apol requested review of this revision. REVISION SUMMARY At the moment, the bit that notifies about system updates was a plasmoid and it was working well. The

D23451: [GTK3] Recolor CSD titlebuttons according to user's color scheme

ognarb added a comment. Could it be possible to remove most of the code duplication between _window_decorations.scss and _chromium.scss? REPOSITORY R98 Breeze for Gtk BRANCH window-button-symbolics (branched from master) REVISION DETAIL https://phabricator.kde.org/D23451 To: cblack,

D23274: [WIP] Add "Show intro page" button to System Settings sidebar

GB_2 updated this revision to Diff 64682. GB_2 added a comment. Use a bool property setter and disable button when on intro page REPOSITORY R124 System Settings CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D23274?vs=64071=64682 BRANCH

D23117: kcmlookandfeel - Correctly set the Splash Screen to what the Look & Feel intends for it to be set to

The-Feren-OS-Dev added a comment. Pong. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D23117 To: The-Feren-OS-Dev, #plasma, davidedmundson, mart Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, Pitel, ZrenBot, himcesjf,