D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

broulik added a comment. I never noticed that line before but now that I did, I can't unsee it. It looks quite bad with dark Breeze title bar, where it is quite superfluous. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25728 To: filipf, #plasma, #vdg Cc:

D25729: Make it compile without qt deprecated method

mlaurent created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. mlaurent requested review of this revision. REVISION SUMMARY Compile without deprecated qt5.x method REPOSITORY R134 Discover Software Store BRANCH compile_against_qt514_no_deprecated

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/23/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 11:46:44 + Build duration: 1 min 22 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 23 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/23/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 11:46:24 + Build duration: 1 min 45 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 46 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/46/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 11:46:26 + Build duration: 1 min 44 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 221 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/221/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 11:48:42 + Build duration: 7 min 58 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 70 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/70/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 11:48:42 + Build duration: 18 min and counting CONSOLE OUTPUT

D25688: [Style KCM] Set implicit size after show

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1c56622f05db: [Style KCM] Set implicit size after show (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25688?vs=70766=70820 REVISION

D25690: [Style KCM] Forward geometryChanged to parent class

This revision was automatically updated to reflect the committed changes. Closed by commit R119:9fe2562af12c: [Style KCM] Forward geometryChanged to parent class (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25690?vs=70768=70821

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 43 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/43/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 11:55:13 + Build duration: 6 min 9 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 86 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/86/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 11:55:26 + Build duration: 7 min 38 sec and counting CONSOLE OUTPUT

D25711: Remove scrollbar behavior option in GTK KCM

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since this setting now in sync with Plasma and Qt apps one, there is no need in it to be in separate KCM. TEST PLAN 1. Check if

D25703: Sync scrollbar behavior with GTK applications

gikari added a comment. In D25703#571286 , @ngraham wrote: > Nice, works great. Wanna remove the option in the KCM in this patch too? Oops. I did it in separate one D25711 . Should I undo? REPOSITORY

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 SUSEQt5.12 - Build # 47 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20SUSEQt5.12/47/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 13:45:18 + Build duration: 2 min 27 sec and counting JUnit Tests

KDE CI: Plasma » systemsettings » stable-kf5-qt5 SUSEQt5.12 - Build # 87 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/stable-kf5-qt5%20SUSEQt5.12/87/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 13:45:43 + Build duration: 4 min 40 sec and counting JUnit Tests

D25709: Make it compile against qt5.14 without deprecated method

apol added inline comments. INLINE COMMENTS > kquickstyleitem.cpp:112 > +#else > +qmlRegisterAnonymousType("org.kde.qqc2-desktop-style", 1); > +#endif Maybe use `org.kde.qqc2desktopstyle.private` which we are already using? Also shouldn't we be registering the types and the plugin class

KDE CI: Plasma » kde-cli-tools » stable-kf5-qt5 FreeBSDQt5.13 - Build # 24 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/stable-kf5-qt5%20FreeBSDQt5.13/24/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 13:45:15 + Build duration: 2 min 47 sec and counting JUnit Tests

KDE CI: Plasma » kgamma5 » stable-kf5-qt5 SUSEQt5.12 - Build # 24 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kgamma5/job/stable-kf5-qt5%20SUSEQt5.12/24/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 13:45:23 + Build duration: 1 min 5 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 SUSEQt5.12 - Build # 222 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20SUSEQt5.12/222/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 13:45:38 + Build duration: 9 min 34 sec and counting JUnit Tests

KDE CI: Plasma » plasma-desktop » stable-kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/stable-kf5-qt5%20FreeBSDQt5.13/71/ Project: stable-kf5-qt5 FreeBSDQt5.13 Date of build: Tue, 03 Dec 2019 13:45:35 + Build duration: 5 min 8 sec and counting JUnit Tests

KDE CI: Plasma » powerdevil » stable-kf5-qt5 SUSEQt5.12 - Build # 44 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/stable-kf5-qt5%20SUSEQt5.12/44/ Project: stable-kf5-qt5 SUSEQt5.12 Date of build: Tue, 03 Dec 2019 13:45:41 + Build duration: 5 min 6 sec and counting JUnit Tests Name:

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

GB_2 added a comment. Works now :-) REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #plasma, apol Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf,

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D24275#571531 , @GB_2 wrote: > Works now :-) With the cmake or the meson? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #plasma, apol Cc: GB_2,

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D24275#546111 , @GB_2 wrote: > In D24275#538994 , @cblack wrote: > > > Does it work if you use an absolute path to the library? Go to

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 70834. cblack added a comment. Pull from master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D24275?vs=66974=70834 BRANCH color-reload-module (branched from master) REVISION DETAIL

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

GB_2 added a comment. In D24275#571532 , @cblack wrote: > In D24275#571531 , @GB_2 wrote: > > > Works now :-) > > > With the cmake or the meson? Meson. REPOSITORY R99 KDE Gtk

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

ngraham added a comment. Needs a rebase on current master. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D24275 To: cblack, #plasma, apol Cc: GB_2, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot,

Plasma 5.17.4

Plasma 5.17.4 is out now https://kde.org/announcements/plasma-5.17.4.php

D25711: Remove scrollbar behavior option in GTK KCM

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. This thing is getting mighty tiny! REPOSITORY R99 KDE Gtk Configuration Tool BRANCH remove-scroll-settings-from-kcm (branched from master) REVISION DETAIL

D25703: Sync scrollbar behavior with GTK applications

ngraham added a comment. That's fine, no worries. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D25703 To: gikari, cblack, #vdg Cc: ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,

D25703: Sync scrollbar behavior with GTK applications

ngraham accepted this revision. ngraham added a reviewer: apol. ngraham added a comment. This revision is now accepted and ready to land. @cblack and/or #plasma people, all good here? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH master

D25428: Improved support for desktop "Folder View"

steffenh added a comment. Hi @ngraham, thanks for testing, OK, I will rewrite this and see if I can get rid of all the simulated mouse clicks REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham Cc: ngraham,

D25428: Improved support for desktop "Folder View"

ngraham added a comment. Good luck! Thanks for working on this, it's really important. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25428 To: steffenh, #plasma, hein, ngraham Cc: ngraham, nicolasfella, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,

D24275: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

nicolasfella added a comment. Unrelated to the issue: For GLIB2 we have a ECM find module that makes things a bit nicer. See https://invent.kde.org/snippets/601 For GOBJECT we don't have one, but since we afaik use it on at least one other place it might be worth making one REPOSITORY

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70859. ngraham marked an inline comment as done. ngraham added a comment. Correct string error REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70858=70859 BRANCH

D25725: Get icon size from QStyle

nicolasfella created this revision. nicolasfella added reviewers: Plasma, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. TEST PLAN No visual difference REPOSITORY R97 Bluedevil BRANCH it REVISION DETAIL

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

ngraham updated this revision to Diff 70858. ngraham added a comment. Rebase REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25447?vs=70119=70858 BRANCH suspend-and-resume-and-monitor-indexing-from-the-kcm (branched from master) REVISION DETAIL

D25447: [Baloo KCM] Add the ability to suspend, resume, and monitor indexing

davidedmundson added inline comments. INLINE COMMENTS > main.qml:93 > + > +visible: fileSearchEnabled.checked && monitor.state != > Constants.State.Idle > + what about: LowPowerIdle? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25447 To:

D25726: [Icon View] Fix titles of previously opened KCMs bleeding into QML KCMs

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The change in D14580 triggered the spawning of an additional header in QML KCMs in icon view

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY I added a top separator for QML applet configuration windows in D20908 This separator is

D25728: [Applet Configuration] Don't draw a full-on separator between the titlebar and window

ngraham added a comment. But... the "Before" image looks better. :/ Having the titlebar blend with the window kind of requires that nothing wants to be touching the titlebar, or else it just looks bad IMO. Personally my preference is to restore consistency by moving in the opposite

D25709: Make it compile against qt5.14 without deprecated method

mlaurent added a comment. yep it seems more logical REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D25709 To: mlaurent, apol Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D25709: Make it compile against qt5.14 without deprecated method

mlaurent updated this revision to Diff 70875. mlaurent added a comment. Fix comment REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25709?vs=70808=70875 BRANCH fix_compile_qt5.14 (branched from master) REVISION DETAIL

D25709: Make it compile against qt5.14 without deprecated method

mlaurent updated this revision to Diff 70876. mlaurent added a comment. Forgot to commit it REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25709?vs=70875=70876 BRANCH fix_compile_qt5.14 (branched from master) REVISION DETAIL