D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73395. kmaterka added a comment. Workaround for Kirigami.AbstractListItem REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73389=73395 BRANCH master REVISION DETAIL

D26516: [Icon Item] Check URL validity and scheme

This revision was automatically updated to reflect the committed changes. Closed by commit R120:c765c990: [Icon Item] Check URL validity and scheme (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26516?vs=73038=73393

D26271: [Applet]Update layout based on T10470

gvgeo added a comment. Found this request to display the name of the stream https://bugs.kde.org/show_bug.cgi?id=409453 . Which was done, but remove here. Maybe should leave it too? With a quick check, not many applications have this information. F7880660: Screenshot_20200113_135516.png

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. In D26530#591355 , @ngraham wrote: > Yeah, I really dislike the fully-disappearing scrollbars too, for the same reason. I also like the GNOME approach when overlay-style scrollbars absolutely have to be used. That seems

Meeting Notes 13 Jan 2020

David Redondo (@davidre:kde.org) Added ability to filter plasma themes by name and if they are dark/light/follow color scheme https://phabricator.kde.org/R119:b25a0d41985e596454e49c2ee783296c1189c224 Fixed two bugs in Colors kcm

D26572: Always render checkbox/radiobutton background

ndavis added a comment. Since this improves checkbox visibility when rendered over images, should we or should we not do this? REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D26572 To: ndavis, #vdg, #breeze, #plasma, hpereiradacosta, ngraham Cc: plasma-devel,

D26530: ScrollView: Do not overlay scrollbars over contents

mart added a comment. In D26530#591413 , @ahiemstra wrote: > Also note that the intention is to have the scrollbar background match the view background. In the example case I didn't bother with any view specific styling, so it looks a little

D26621: [kstyle] Drop Qt 4 style plugin

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY KWindowSystem cannot be used in the Qt 4 style plugin. On the other hand, we need to use KWindowSystem

D26583: [Application Style] Add GTK Application Style Page

gikari updated this revision to Diff 73390. gikari added a comment. Replace `include gtkpage` with forward declaration REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26583?vs=73313=73390 BRANCH gtk-style-page REVISION DETAIL

D26530: ScrollView: Do not overlay scrollbars over contents

mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed. In D26530#591641 , @ngraham wrote: > I think this is why the best compromise for desktop usage is to use thick always-visible

D15418: Dim application icon when it is not playing anything

gvgeo added a comment. In D15418#331397 , @ngraham wrote: > Maybe something like this? > > F6283615: Screenshot_20180924_195355.png This feels too much. There is no need to be so obvious, just

D26586: [SystemTray] Rework system tray settings

kmaterka updated this revision to Diff 73389. kmaterka added a comment. Review fixes: Key shortcut header width Background Few other small changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26586?vs=73284=73389 BRANCH master REVISION

D26586: [SystemTray] Rework system tray settings

kmaterka added a comment. > The discussion about overlay vs non-overlay scrollbars is unrelated to whether or not to show a frame and background behind a scrollview. :) Just add the background for now I think. Oh, true, my mistake. It looks much better with background, thanks! >

D26476: [kstyle] Remove shadows in Qt 4 style plugin

zzag updated this revision to Diff 73387. zzag added a comment. Drop Qt 4 style plugin REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26476?vs=72925=73387 BRANCH port-to-shadows-api REVISION DETAIL https://phabricator.kde.org/D26476 AFFECTED FILES

Re: Long press global shortcuts

On Sun, Jan 12, 2020 at 5:11 PM Aleix Pol wrote: > > Hi, > In a discussion some weeks ago, we came to the conclusion that it > would make sense to support long press global shortcuts. > > The use-case we discussed back then was the power button on the Plasma > phone. We need to have 2 actions

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#592286 , @ngraham wrote: > I notice that this also has the effect of changing the button texts to not have ellipses on the end. I guess `NewStuff.Button` needs to do that itself? There's a bug report for

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir planned changes to this revision. leinir added a comment. In D26544#592285 , @ngraham wrote: > This patch makes plasma-desktop fail to build without the dependent KNS framework change. That means that the KNS change is in fact a hard

D26544: Switch the Plasma Desktop KCMs to using KNewStuffQuick

leinir added a comment. In D26544#591591 , @bcooksley wrote: > In the case of three Frameworks (namely plasma-framework, kwayland and kwindowsystem) I have on file requests from the Plasma and KWin developers informing me that their software

D26458: [windowsystem] Provide a KWindowShadow implementation

zzag updated this revision to Diff 73381. zzag added a comment. Update. REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=73380=73381 BRANCH port-to-shadows-api REVISION DETAIL

D26458: [windowsystem] Provide a KWindowShadow implementation

zzag updated this revision to Diff 73380. zzag added a comment. Fix a typo REPOSITORY R130 Frameworks integration plugin using KWayland CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26458?vs=73350=73380 BRANCH port-to-shadows-api REVISION DETAIL

D26392: Add option to easily configure and start a hotspot

mthw added a comment. @meven But we already know it's too late for the icon, at least for distros that won't update to KF5 5.67 before Plasma 5.18. Are you saying this can't go forward without an icon? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL

D26392: Add option to easily configure and start a hotspot

meven added a comment. In D26392#592892 , @mthw wrote: > Is is possible to check if a hotspot icon exists, and if it does, show it, otherwise show a text? It is being taken care of : D26595

D26392: Add option to easily configure and start a hotspot

mthw added a comment. Is is possible to check if a hotspot icon exists, and if it does, show it, otherwise show a text? REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D26392 To: jgrulich, #plasma, ngraham, #vdg Cc: cblack, alexde, mthw,

D26392: Add option to easily configure and start a hotspot

mthw added a comment. A checkbox with a tooltip "Create hotspot" and an icon next to it should be enought, right? Just like Wifi and Airplane mode... REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D26392 To: jgrulich, #plasma, ngraham, #vdg

D26565: KCM/Component Revamp email config

meven added a comment. In D26565#591581 , @ngraham wrote: > In D26565#591542 , @meven wrote: > > > Do you mean, we should drop command line text fields, like we have in the terminal and browser

D26566: Fix layout for the reviews sheet

This revision was automatically updated to reflect the committed changes. Closed by commit R134:98898d6ac407: Fix layout for the reviews sheet (authored by mart). REPOSITORY R134 Discover Software Store CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26566?vs=73213=73379 REVISION

D26392: Add option to easily configure and start a hotspot

jgrulich added a comment. In D26392#592288 , @ngraham wrote: > In D26392#592133 , @jgrulich wrote: > > > Can someone please look into this review? Either try it or check the code? I would like to

D26392: Add option to easily configure and start a hotspot

jgrulich added a comment. In D26392#592136 , @apol wrote: > In D26392#588345 , @jgrulich wrote: > > > In D26392#587159 , @mthw wrote: > > > > > @apol

D26565: KCM/Component Revamp email config

meven updated this revision to Diff 73375. meven added a comment. Clean reference to unused and not existant .config/emails directory REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26565?vs=73212=73375 BRANCH email-config REVISION DETAIL

D26598: Drop unused method

This revision was automatically updated to reflect the committed changes. Closed by commit R122:c3b253f49468: Drop unused method (authored by nicolasfella). REPOSITORY R122 Powerdevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26598?vs=73321=73371 REVISION DETAIL

<    1   2