D27055: [kcms/cursortheme] Don't skip everything because of lack of XFixes

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY XFixes is only used on X. But we definitely still need to update the

D27054: Syncronise environment to user systemd session

broulik added inline comments. INLINE COMMENTS > updatelaunchenvjob.cpp:104 > + > QStringLiteral("/org/freedesktop/systemd1"), > + >

D27052: Solid-device-automounter/kcm: Convert some foreach

alex added a comment. > if it is a function you don't need to do anything if the function is const (keys()), if not the best practice is to introduce an intermediate const variable That makes everything clear, thank you very much ! REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27045: [wallpapers] Use more high-quality JPEGs for Next

ngraham added a comment. Agreed. Perhaps for the next contest, we should explicitly require that the 5K version be under 6 MB, and provide a few recommendations for how to achieve this. REPOSITORY R31 Breeze BRANCH more-hq-next (branched from master) REVISION DETAIL

D27063: Fix disabeling of autolock timeout

ervin added a comment. Looks like it's caused by the initial state of the ui file being "wrong" (checkbox unchecked and spinbox enabled), what about simply having the spinbox disabled in the ui file? Maybe we miss a connect there too. It's the kind of ui specific details I try to push out

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > DeviceModel.cpp:185 > if (index.isValid()) { > -if (index.parent().isValid()) { > -if (index.column() > 0) { > -return

D26941: [Task Manager] Remove strict URL handling

This revision was automatically updated to reflect the committed changes. Closed by commit R120:bb573b83ace5: [Task Manager] Remove strict URL handling (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26941?vs=74424=74775

D27053: Solid-device-automounter/kcm: Improve width of columns

meven updated this revision to Diff 74776. meven added a comment. Case issue REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27053?vs=74770=74776 BRANCH arcpatch-D27053 REVISION DETAIL https://phabricator.kde.org/D27053 AFFECTED FILES

D27054: Syncronise environment to user systemd session

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY Equivalent of dbus-update-activation-environment but in runtime TEST PLAN

D27054: Syncronise environment to user systemd session

davidedmundson planned changes to this revision. davidedmundson added a comment. hold on, I fixed all this. stupid phab REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27054 To: davidedmundson, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n,

D27054: Syncronise environment to user systemd session

davidedmundson updated this revision to Diff 74755. davidedmundson added a comment. update properly this time REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27054?vs=74751=74755 BRANCH master REVISION DETAIL

D27052: Solid-device-automounter/kcm: Convert some foreach

meven added a comment. In D27052#603798 , @alex wrote: > Hello, > I have a question regarding your changed. > > you sometimes declare the variables you want to loop over before the loop, but sometimes in the loop. > For instance in

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

meven updated this revision to Diff 74767. meven added a comment. Don't list ignored devices as intended REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27019?vs=74656=74767 BRANCH arcpatch-D27019 REVISION DETAIL

D27053: Solid-device-automounter/kcm: Improve width of columns

meven updated this revision to Diff 74770. meven added a comment. Add translation context REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27053?vs=74743=74770 BRANCH arcpatch-D27053 REVISION DETAIL https://phabricator.kde.org/D27053 AFFECTED

D27063: Fix disabeling of autolock timeout

alex created this revision. alex added reviewers: mart, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY When the "Lock Screen:" checkbox gets disabled the timeout spin box gets disabled too. But the spin

D27053: Solid-device-automounter/kcm: Improve width of columns

ervin added a comment. LGTM, waiting for nate's opinion. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27053 To: meven, ngraham, ervin, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot,

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 2 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/2/ Project: stable-kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 31 Jan 2020 13:29:38 + Build duration: 1 min 18 sec and counting CONSOLE

D27023: Port to UpdateLaunchEnvJob

davidedmundson added a comment. We haven't called start on any of the jobs, so they do nothing :/ Also given they're kjobs do we want: auto job = new UpdateEnvJob() so we don't delete the job immediately? REPOSITORY R119 Plasma Desktop REVISION DETAIL

D27054: Syncronise environment to user systemd session

davidedmundson updated this revision to Diff 74751. davidedmundson added a comment. changes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27054?vs=74745=74751 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27054 AFFECTED FILES

D27061: replace samba module with data that works

sitter updated this revision to Diff 74764. sitter added a comment. translate accessible bool to icons + resize its column. looks better and avoids yet more new strings REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27061?vs=74762=74764 BRANCH smb

D27058: Clean outdated QT_VERSION_CHECK

This revision was automatically updated to reflect the committed changes. Closed by commit R119:5ee3b4145c26: Clean outdated QT_VERSION_CHECK (authored by meven). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27058?vs=74752=74765 REVISION DETAIL

D27041: fix incorrect parsing of "at foo.so" and empty function name

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice find. REPOSITORY R871 DrKonqi BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D27041 To: sitter, ngraham Cc: ngraham, plasma-devel, Orage, LeGast00n,

D27041: fix incorrect parsing of "at foo.so" and empty function name

This revision was automatically updated to reflect the committed changes. Closed by commit R871:a90e3b38468b: fix incorrect parsing of at foo.so and empty function name (authored by sitter). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27041?vs=74710=74774

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

meven updated this revision to Diff 74773. meven marked 3 inline comments as done. meven added a comment. Simplify DeviceModel::flags, carriage returns REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27057?vs=74750=74773 BRANCH onattabch REVISION

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 4 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/4/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Fri, 31 Jan 2020 13:29:38 + Build duration: 4 min 5 sec and counting CONSOLE OUTPUT

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

meven created this revision. meven added reviewers: Plasma, ervin, ngraham, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY To make clear to the user what automount options imply. REPOSITORY R119

D27055: [kcms/cursortheme] Don't skip everything because of lack of XFixes

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > kcmcursortheme.cpp:301 > > -// Qt cursors > -names << "left_ptr" << "up_arrow" << "cross" << "wait" > - << "left_ptr_watch" <<

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

davidedmundson commandeered this revision. davidedmundson edited reviewers, added: kossebau; removed: davidedmundson. davidedmundson added a comment. <3 Saw your messages on kde-devel. Thanks for starting this I'm sure we can take it from here REPOSITORY R129 Window Decoration

D27061: replace samba module with data that works

sitter created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY ... and doesn't require lots of maintenance! this targets 5.18 but is kind of unfortunate because it needs a bunch of new strings

D27053: Solid-device-automounter/kcm: Improve width of columns

meven added a comment. Makes more sense with D27057 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27053 To: meven, ngraham, ervin, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus,

D27052: Solid-device-automounter/kcm: Convert some foreach

alex added a comment. Hello, I have a question regarding your changed. you sometimes declare the variables you want to loop over before the loop, but sometimes in the loop. For instance in DeviceModel.cpp line 135 it is declared as a const before the loop and in line 139 it is

D27054: Syncronise environment to user systemd session

davidedmundson marked 2 inline comments as done. davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in updatelaunchenvjob.cpp:105 > Does this need some form of escaping? I don't think so. you can't have an = in your var name and that's the only part that matters REPOSITORY

D27058: Clean outdated QT_VERSION_CHECK

meven created this revision. meven added reviewers: Plasma, ervin, mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Plasma desktop depends on KF 5.66 REPOSITORY R119 Plasma Desktop BRANCH

D27061: replace samba module with data that works

sitter updated this revision to Diff 74762. sitter added a comment. unbreak model actually REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27061?vs=74761=74762 BRANCH smb REVISION DETAIL https://phabricator.kde.org/D27061 AFFECTED FILES

D27045: [wallpapers] Use more high-quality JPEGs for Next

rikmills added a comment. I don't object to bumping the size for this release. However, I do wonder if it might be worth thinking about future guidelines/rules regarding wallpaper maximum sizes after optimisation. REPOSITORY R31 Breeze BRANCH more-hq-next (branched from master)

D27066: remove pointless ifdef

sitter created this revision. sitter added a reviewer: mlaurent. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. sitter requested review of this revision. REVISION SUMMARY the cast may not be necessary with <5.15 it will build all the same since we are using legacy

D27053: Solid-device-automounter/kcm: Improve width of columns

meven created this revision. meven added reviewers: ngraham, ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. REVISION SUMMARY Make the "automatic login on..." columns thinner to give more room to the Peripheral

D19004: Remove extra nested dbus session

davidedmundson added a comment. > git log says it is needed for systems where dbus-user-session is not installed Sure, but I don't understand why the solution is to work around it, rather than explain that it's a dep. --- This is now causing me problems. I get the two user

D27052: Solid-device-automounter/kcm: Convert some foreach

meven created this revision. meven added reviewers: broulik, ervin, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. meven requested review of this revision. TEST PLAN builds REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL

D27063: Fix disabeling of autolock timeout

alex added a comment. Thats a good point, the issue is that the validation slot gets only triggered if the value gets changed. If the automatic locking is disabled the value does not change and no signal gets triggered. Setting the spin box disabled by default is then the easiest

D27068: [System Tray] Initially set correct category for plasmoids

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. I definitely need to split D26992 into smaller chunks :) I had it fixed, but obviously D26992 can't be merged

D26418: [Applet]Add global mute function

This revision was automatically updated to reflect the committed changes. Closed by commit R115:681e1c8faaaf: [Applet]Add global mute function (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D26574: [Applet]Hide hamburger menu when empty

This revision was automatically updated to reflect the committed changes. Closed by commit R115:10ab204a62cf: [Applet]Hide hamburger menu when empty (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D26271: [Applet]Update layout based on T10470

ngraham added a comment. @gvgeo though I tested this before and found it to be working, after landing the patch I'm now seeing that using the new radio buttons to change the default device does not automatically move all running streams to the new device, as it used to. Can you check this?

D27066: remove pointless ifdef

mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. wrong as static_cast is deprecated and it will not work without deprecated method. Or you can convert it to static_cast but "int" signal doesn't exist when we build

D27061: replace samba module with data that works

ngraham added reviewers: Localization, Plasma, VDG. ngraham added a comment. Very nice. Looks much better and seems to work quite well. While we're already breaking proposing breaking the string freeze, instead of "Exports" and "Imports", how about "Exported Shares" and "Mounted shares"

how OSX tells what type of device a samba host is

The past week I've been poking around various smb things and also investigated how OS X knows what device type a remote host is. After all, Kai has been fond of their lovely CRT screens for the longest time. But we never quite knew how they actually which server should have a CRT.

D27068: [System Tray] Initially set correct category for plasmoids

This revision was automatically updated to reflect the committed changes. Closed by commit R120:50f9c3cf5292: [System Tray] Initially set correct category for plasmoids (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D27068: [System Tray] Initially set correct category for plasmoids

broulik added a comment. > category overrides in main.qml I think those should go away and have the SNI/plasmoid in the right category. I think most of them are obsolete already anyway, e.g. `org.kde.plasma.networkmanagement` is `Hardware` in its metadata REPOSITORY R120 Plasma

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex created this revision. alex added reviewers: kossebau, vhanda. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY The two foreach occurences are refactored and the signals in the runner/kcm now use the C++ 11

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

ngraham added a comment. In D27047#604091 , @apol wrote: > We made an effort to not use "convergence", as it seems like it's hard to understand. How about "adaptable"? +1, that's a better word. REPOSITORY R169 Kirigami REVISION

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 74802. kmaterka added a comment. Rebase2 REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74797=74802 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26992 AFFECTED FILES

D26729: do not disable getifaddrs use because of sa_len availablility

sitter marked an inline comment as done. sitter added inline comments. INLINE COMMENTS > jjazeix wrote in nic.cpp:137 > buf is not defined in this conditional and causes a build fail on freebsd: >

D27074: [Applet]Fix port check

gvgeo created this revision. gvgeo added reviewers: Plasma, drosca, ngraham. gvgeo added a project: Plasma. Herald added a subscriber: plasma-devel. gvgeo requested review of this revision. REPOSITORY R115 Plasma Audio Volume Applet BRANCH check (branched from master) REVISION DETAIL

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

meven updated this revision to Diff 74782. meven added a comment. Use a switch case REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27057?vs=74773=74782 BRANCH onattabch REVISION DETAIL https://phabricator.kde.org/D27057 AFFECTED FILES

D27029: Remove header top margin from private ScrollView

This revision was automatically updated to reflect the committed changes. Closed by commit R169:da3d41f13690: Remove header top margin from private ScrollView (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27029?vs=74677=74784

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74795. alex added a comment. Simplify statement REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74793=74795 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D27045: [wallpapers] Use more high-quality JPEGs for Next

This revision was automatically updated to reflect the committed changes. Closed by commit R31:df58788d4cf4: [wallpapers] Use more high-quality JPEGs for Next (authored by filipf). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27045?vs=74721=74794 REVISION

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 98 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/98/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 31 Jan 2020 15:13:01 + Build duration: 22 min and counting CONSOLE OUTPUT [...truncated

D27073: [Colors KCM] Consider settings dirty if currently active scheme is edited

broulik created this revision. broulik added reviewers: Plasma, crossi, ervin. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Otherwise one cannot re-apply changes made to the current color scheme. TEST PLAN

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 99 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/99/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Fri, 31 Jan 2020 16:23:57 + Build duration: 1 min 32 sec and counting

D15418: Dim application icon when it is not playing anything

alexde added a comment. In D15418#604200 , @broulik wrote: > > Can't we dim label instead? > > I quite like that. Also not very obvious what it means, I guess.. Not sure if it was already discussed, but what about adding an overlay

D27072: [Colors KCM] Fix roles mixup

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Nice catch, this had been mildly bugging me. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27072 To: broulik, #plasma, ngraham Cc: ngraham,

D27027: Clip the flickable parent item

This revision was automatically updated to reflect the committed changes. Closed by commit R169:dd41d57f5404: Clip the flickable parent item (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27027?vs=74674=74785 REVISION DETAIL

D27027: Clip the flickable parent item

ahiemstra added a comment. Note that I did spend some time investigating what causes the clipping to be needed in the first place, but that looks like an issue deep in kcmshell5, which allows any kcm to be resized to below its minimum size. This also leads to issues with other KCMs like

D27063: Fix disabeling of autolock timeout

alex updated this revision to Diff 74787. alex added a comment. Set spinbox disabled by default REPOSITORY R133 KScreenLocker CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27063?vs=74769=74787 BRANCH fix_disabled_state REVISION DETAIL https://phabricator.kde.org/D27063

D27061: replace samba module with data that works

sitter added a comment. I was trying to recycle as many strings as possible. If the localizers are fine with us throwing caution to the wind for those two strings as well then that's fine with me naturally, it would also allow me to get rid of a naughty hack I had to pull to retain the

D26256: [Applet] Make 'raise maximum volume' global

This revision was automatically updated to reflect the committed changes. Closed by commit R115:d0c753c188e8: [Applet] Make raise maximum volume global (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 74797. kmaterka added a comment. Rebase REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74586=74797 BRANCH master REVISION DETAIL https://phabricator.kde.org/D26992 AFFECTED FILES

D26271: [Applet]Update layout based on T10470

This revision was automatically updated to reflect the committed changes. Closed by commit R115:8ada15ad8e5b: [Applet]Update layout based on T10470 (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27052: Solid-device-automounter/kcm: Convert some foreach

meven updated this revision to Diff 74803. meven added a comment. Add intermediate const variable for function REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27052?vs=74742=74803 BRANCH arcpatch-D27052 REVISION DETAIL

D15418: Dim application icon when it is not playing anything

ngraham added a comment. @broulik Ping. :) REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, ngraham, plasma-devel, Orage, LeGast00n,

D15418: Dim application icon when it is not playing anything

broulik added a comment. > Can't we dim label instead? I quite like that REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D15418 To: broulik, #plasma, #vdg Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, ngraham,

D26992: [SystemTray] Use unified data model everywhere

kmaterka updated this revision to Diff 74805. kmaterka added a comment. I will split it into smaller changes, this one is too big for a review. I'll keep it here as a backup. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26992?vs=74802=74805

D27071: Remove KCM Init Phase 2

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY It is unused and we have better means of daemon autostart than this. TEST PLAN Compiles. I

D26729: do not disable getifaddrs use because of sa_len availablility

jjazeix added inline comments. INLINE COMMENTS > nic.cpp:137 > +#ifdef HAVE_STRUCT_SOCKADDR_SA_LEN > +return getnameinfo(addr, ifa->ifa_addr->sa_len, buf, 127, 0, 0, > NI_NUMERICHOST); > +#else buf is not defined in this conditional and causes a build fail on freebsd:

D27072: [Colors KCM] Fix roles mixup

broulik created this revision. broulik added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY There were two role enums that became out of sync, breaking e.g. editing user themes ("override"

D27068: [System Tray] Initially set correct category for plasmoids

broulik created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY The category was only used for proper `Plasma::Applet` instances but not unloaded plasmoids from pure metadata. BUG: 416947

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

apol added a comment. We made an effort to not use "convergence", as it seems like it's hard to understand. How about "adaptable"? concept makes sense to me. INLINE COMMENTS > Mainpage.dox:26 > \section overview Introduction > -Kirigami is a set of QtQuick components at the moment

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

alex updated this revision to Diff 74793. alex added a comment. Remove unused include REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27070?vs=74789=74793 BRANCH master REVISION DETAIL https://phabricator.kde.org/D27070 AFFECTED FILES

D26729: do not disable getifaddrs use because of sa_len availablility

This revision was automatically updated to reflect the committed changes. Closed by commit R102:4582053b7cac: do not disable getifaddrs use because of sa_len availablility (authored by sitter). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D27074: [Applet]Fix port check

ngraham added a comment. What issue is this fixing? Can you update the description and test plan sections? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27074 To: gvgeo, #plasma, drosca, ngraham Cc: plasma-devel, Orage, LeGast00n,

D27074: [Applet]Add port check

gvgeo added a comment. Give 5 min to update the code. REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27074 To: gvgeo, #plasma, drosca, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen,

D26271: [Applet]Update layout based on T10470

gvgeo added a comment. In D26271#604203 , @ngraham wrote: > @gvgeo though I tested this before and found it to be working, after landing the patch I'm now seeing that using the new radio buttons to change the default device does not

D27074: [Applet]Add port check

gvgeo added a comment. In D27074#604235 , @ngraham wrote: > Maybe only show the description when there's more than one input or output device? I thought the lack of a description for the single-device use case was a feature! :) It looks so nice

D27074: [Applet]Add port check

ngraham added a comment. Maybe only show the description when there's more than one input or output device? I thought the lack of a description for the single-device use case was a feature! :) It looks so nice and clean: F8062861: popup, one device.png

D27074: [Applet]Add port check

gvgeo updated this revision to Diff 74811. gvgeo added a comment. Added port.description too. There is port.description.length now, better safe than sorry. REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27074?vs=74810=74811 BRANCH

D27074: [Applet]Add port check

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. Oh you're right, I was looking at the wrong thing. REPOSITORY R115 Plasma Audio Volume Applet BRANCH check (branched from master) REVISION DETAIL

D27074: [Applet]Add port check

This revision was automatically updated to reflect the committed changes. Closed by commit R115:8f0847af1d17: [Applet]Add port check (authored by gvgeo, committed by ngraham). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE

D27074: [Applet]Fix port check

ngraham added a comment. Thanks! Are you planning code changes? Or was that "Plan changes" just about updating the description and test plan? REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D27074 To: gvgeo, #plasma, drosca, ngraham Cc:

D26891: Upgrade theme to Breeze GTK on startup

ngraham added a comment. @fvogt, are you good with this now? REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL https://phabricator.kde.org/D26891 To: gikari, fvogt Cc: ngraham, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2,

D26891: Upgrade theme to Breeze GTK on startup

gikari updated this revision to Diff 74815. gikari edited the test plan for this revision. gikari added a comment. Rebase on master REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26891?vs=74386=74815 BRANCH apply-theme-on-startup

D26891: Upgrade theme to Breeze GTK on startup

fvogt added a comment. The only remaining question from my side is why we have four different gtk configuration files and whether that causes issues. Besides that, only @meven's comment needs a resolution. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY A lot of people seem to think the 30-second timeout is way too long; See Bug 253405 and

D27078: fix for: Bug 416915 - broken keep of destination coordinates in drag-and-drop operations

painlessroaster created this revision. painlessroaster added a reviewer: hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. painlessroaster requested review of this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27078

D27079: Don't escape search text in search page title

ngraham created this revision. ngraham added reviewers: VDG, Discover Software Store, apol. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY Doing so makes the title display look ugly and generated a bug report.

D27078: Drag-and-drop files at the right coordinates

ngraham added a comment. Thanks for submitting a patch! INLINE COMMENTS > positioner.cpp:370 > } > - > + > QVector fromIndices; unnecessary/unintentional whitespace change REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27078 To:

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

vhanda added a comment. Sorry. I'm removing myself as a reviewer. I barely remember this code base. It has been way too many years. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D27070 To: alex, #plasma Cc: vhanda, plasma-devel, Orage, LeGast00n,

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

davidedmundson accepted this revision. davidedmundson added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > spellcheck.cpp:145 > { > -auto defaultSpeller = m_spellers[QString()]; > +auto = m_spellers[QString()]; > //If first term is a language

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

nicolasfella updated this revision to Diff 74825. nicolasfella added a comment. - Update wording REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27047?vs=74726=74825 BRANCH docs REVISION DETAIL https://phabricator.kde.org/D27047 AFFECTED FILES

  1   2   >