D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> spellcheck.cpp:145
>  {
> -auto defaultSpeller = m_spellers[QString()];
> +auto  = m_spellers[QString()];
>  //If first term is a language code (like en_GB), set it as the 
> spell-check language

Const auto &

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

[David Edmundson]

davidedmundson added a comment.


  It's meant as a confirmation screen as it's a destructive action, which a 
user would confirm.
  
  No one is meant to be sitting around waiting for the timeout so
  I don't see a compelling reason to make it shorter. None of the bug reports 
have a good reason why they would do that.
  
  Resolved-wontfix

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27077

To: ngraham, #vdg, #plasma
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex added reviewers: ngraham, broulik.
alex added a comment.


  > Sorry. I'm removing myself as a reviewer. I barely remember this code base. 
It has been way too many years.
  
  Thanks anyway.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

[Nicolas Fella]

nicolasfella updated this revision to Diff 74825.
nicolasfella added a comment.


  - Update wording

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27047?vs=74726=74825

BRANCH
  docs

REVISION DETAIL
  https://phabricator.kde.org/D27047

AFFECTED FILES
  Mainpage.dox

To: nicolasfella, #kirigami
Cc: ngraham, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart, hein

D27079: Don't escape search text in search page title

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Discover Software Store, apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Doing so makes the title display look ugly and generated a bug report. I 
can't see any
  obvious reason why we need to un-escape this text. It was added in
  ae8088d0b9bcc1baea244c5d14d4f0788a2f2b68 
 
without explanation; maybe we don't need it?
  
  @apol do you remember?
  
  BUG: 416781
  FIXED-IN: 5.18.0

TEST PLAN
  Searching still works
  
  Search terms with HTML entities in them no longer look ugly in the title:
  
  F8070324: good text.png 

REPOSITORY
  R134 Discover Software Store

BRANCH
  show-search-text-un-escaped (branched from Plasma/5.18)

REVISION DETAIL
  https://phabricator.kde.org/D27079

AFFECTED FILES
  discover/qml/ApplicationsListPage.qml

To: ngraham, #vdg, #discover_software_store, apol
Cc: plasma-devel, apol, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27078: Drag-and-drop files at the right coordinates

[Nathaniel Graham]

ngraham added a comment.


  Thanks for submitting a patch!

INLINE COMMENTS

> positioner.cpp:370
>  }
> -
> +
>  QVector fromIndices;

unnecessary/unintentional whitespace change

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27078

To: painlessroaster, hein, #plasma
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27078: fix for: Bug 416915 - broken keep of destination coordinates in drag-and-drop operations

[Painless Roaster]

painlessroaster created this revision.
painlessroaster added a reviewer: hein.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
painlessroaster requested review of this revision.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27078

AFFECTED FILES
  containments/desktop/plugins/folder/positioner.cpp
  containments/desktop/plugins/folder/positioner.h

To: painlessroaster, hein
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27077: [RFC] [Logout screen] Shorten timeout to 10 seconds

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  A lot of people seem to think the 30-second timeout is way too long; See Bug 
253405 and
  the comments and duplicates.
  
  This patch switches to a 10-second timeout.
  
  Open for comments since I don't feel particularly strongly about this one way 
or another
  or really understand why a 30-second timeout was chosen in the first place.
  
  BUG: 253405
  FIXED-IN: 5.19.0

REPOSITORY
  R120 Plasma Workspace

BRANCH
  shorter-timeout (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27077

AFFECTED FILES
  lookandfeel/contents/logout/Logout.qml

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Vishesh Handa]

vhanda added a comment.


  Sorry. I'm removing myself as a reviewer. I barely remember this code base. 
It has been way too many years.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D27070

To: alex, #plasma
Cc: vhanda, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Upgrade theme to Breeze GTK on startup

[Fabian Vogt]

fvogt added a comment.


  The only remaining question from my side is why we have four different gtk 
configuration files and whether that causes issues.
  Besides that, only @meven's comment needs a resolution.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt
Cc: ngraham, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Upgrade theme to Breeze GTK on startup

[Nathaniel Graham]

ngraham added a comment.


  @fvogt, are you good with this now?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D26891

To: gikari, fvogt
Cc: ngraham, meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26891: Upgrade theme to Breeze GTK on startup

[Mikhail Zolotukhin]

gikari updated this revision to Diff 74815.
gikari edited the test plan for this revision.
gikari added a comment.


  Rebase on master

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26891?vs=74386=74815

BRANCH
  apply-theme-on-startup (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D26891

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kconf_update/gtk_theme.upd
  kconf_update/main.cpp
  kded/configeditor.cpp

To: gikari, fvogt
Cc: meven, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[George Vogiatzis]

gvgeo added a comment.


  In D26271#604203 , @ngraham wrote:
  
  > @gvgeo though I tested this before and found it to be working, after 
landing the patch I'm now seeing that using the new radio buttons to change the 
default device does not automatically move all running streams to the new 
device, as it used to. Can you check this? Thanks!
  
  
  This should not happen. The changes to the `defaultButton` were minimum, 
except the transformation to RadioButton, onClicked stayed the same. I suspect 
something else is to blame, but **cannot replicate** in two systems, and cannot 
see something in the code.
  
  Can you check the console for any messages?
  Next step is to confirm that was working before these patches. And try to 
pinpoint the responsible patch, by applying them 1 by 1 and testing.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27074: [Applet]Add port check

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:8f0847af1d17: [Applet]Add port check (authored by gvgeo, 
committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27074?vs=74811=74812

REVISION DETAIL
  https://phabricator.kde.org/D27074

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Oh you're right, I was looking at the wrong thing.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[George Vogiatzis]

gvgeo added a comment.


  In D27074#604235 , @ngraham wrote:
  
  > Maybe only show the description when there's more than one input or output 
device? I thought the lack of a description for the single-device use case was 
a feature! :) It looks so nice and clean: F8062861: popup, one device.png 

  
  
  II don't see the problem, in this picture. I don't even know if it is before 
of after this patch.
  It looks fine, both devices show the port.
  
  This should not change anything. It is a bug fix.
  There are 2 descriptions, `Device description` and `Port description`. We 
prefer to show the Port description.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[Nathaniel Graham]

ngraham added a comment.


  Maybe only show the description when there's more than one input or output 
device? I thought the lack of a description for the single-device use case was 
a feature! :) It looks so nice and clean: F8062861: popup, one device.png 


REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[George Vogiatzis]

gvgeo updated this revision to Diff 74811.
gvgeo added a comment.


  Added port.description too.
  There is port.description.length now, better safe than sorry.

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27074?vs=74810=74811

BRANCH
  check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27074

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Add port check

[George Vogiatzis]

gvgeo added a comment.


  Give 5 min to update the code.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Fix port check

[Nathaniel Graham]

ngraham added a comment.


  Thanks!
  
  Are you planning code changes? Or was that "Plan changes" just about updating 
the description and test plan?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Fix port check

[Nathaniel Graham]

ngraham added a comment.


  What issue is this fixing? Can you update the description and test plan 
sections?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27074

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27074: [Applet]Fix port check

[George Vogiatzis]

gvgeo created this revision.
gvgeo added reviewers: Plasma, drosca, ngraham.
gvgeo added a project: Plasma.
Herald added a subscriber: plasma-devel.
gvgeo requested review of this revision.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  check (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27074

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml

To: gvgeo, #plasma, drosca, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27072: [Colors KCM] Fix roles mixup

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice catch, this had been mildly bugging me.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27072

To: broulik, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D15418: Dim application icon when it is not playing anything

[Alex Debus]

alexde added a comment.


  In D15418#604200 , @broulik wrote:
  
  > > Can't we dim label instead?
  >
  > I quite like that. Also not very obvious what it means, I guess..
  
  
  Not sure if it was already discussed, but what about adding an overlay 
mute-icon, similar to D3302 ? Maybe this is 
easier to understand?

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: alexde, gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, 
abetts, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D26271: [Applet]Update layout based on T10470

[Nathaniel Graham]

ngraham added a comment.


  @gvgeo though I tested this before and found it to be working, after landing 
the patch I'm now seeing that using the new radio buttons to change the default 
device does not automatically move all running streams to the new device, as it 
used to. Can you check this? Thanks!

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D26271

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D26729: do not disable getifaddrs use because of sa_len availablility

[Harald Sitter]

sitter marked an inline comment as done.
sitter added inline comments.

INLINE COMMENTS

> jjazeix wrote in nic.cpp:137
> buf is not defined in this conditional and causes a build fail on freebsd: 
> https://build.kde.org/view/Failing/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/lastFailedBuild/

thanks. should be fixed

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26729

To: sitter, ngraham
Cc: jjazeix, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 99 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/99/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 31 Jan 2020 16:23:57 +
 Build duration:
1 min 32 sec and counting

D15418: Dim application icon when it is not playing anything

[Kai Uwe Broulik]

broulik added a comment.


  > Can't we dim label instead?
  
  I quite like that

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D15418: Dim application icon when it is not playing anything

[Nathaniel Graham]

ngraham added a comment.


  @broulik Ping. :)

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D15418

To: broulik, #plasma, #vdg
Cc: gvgeo, squeakypancakes, meven, mart, svenmauch, acrouthamel, abetts, 
ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra

D27073: [Colors KCM] Consider settings dirty if currently active scheme is edited

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, crossi, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Otherwise one cannot re-apply changes made to the current color scheme.

TEST PLAN
  - Copied breeze color scheme (since you cannot edit system schemes), applied 
my copy, edited my copy (requires D27072  
to work agin), saved my changes: and I had the Apply button active so I could 
apply my changes right away

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27073

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h

To: broulik, #plasma, crossi, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27072: [Colors KCM] Fix roles mixup

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  There were two role enums that became out of sync, breaking e.g. editing user 
themes ("override" mode).

TEST PLAN
  5.18
  I can edit my own themes directly without Save As again

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27072

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/colors/colors.h
  kcms/colors/filterproxymodel.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26729: do not disable getifaddrs use because of sa_len availablility

[Johnny Jazeix]

jjazeix added inline comments.

INLINE COMMENTS

> nic.cpp:137
> +#ifdef HAVE_STRUCT_SOCKADDR_SA_LEN
> +return getnameinfo(addr, ifa->ifa_addr->sa_len, buf, 127, 0, 0, 
> NI_NUMERICHOST);
> +#else

buf is not defined in this conditional and causes a build fail on freebsd: 
https://build.kde.org/view/Failing/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/lastFailedBuild/

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D26729

To: sitter, ngraham
Cc: jjazeix, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27071: Remove KCM Init Phase 2

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  It is unused and we have better means of daemon autostart than this.

TEST PLAN
  Compiles.
  I don't think that README in ksmserver is really any good but I updated it 
regardless.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27071

AFFECTED FILES
  ksmserver/README
  startkde/kcminit/main.cpp
  startkde/kcminit/main.h
  startkde/plasma-session/startup.cpp
  startkde/plasma-session/startup.h

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

[Konrad Materka]

kmaterka updated this revision to Diff 74805.
kmaterka added a comment.


  I will split it into smaller changes, this one is too big for a review. I'll 
keep it here as a backup.

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26992?vs=74802=74805

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26992

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kinfocenter » kf5-qt5 FreeBSDQt5.13 - Build # 98 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kinfocenter/job/kf5-qt5%20FreeBSDQt5.13/98/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Fri, 31 Jan 2020 15:13:01 +
 Build duration:
22 min and counting
   CONSOLE OUTPUT
  [...truncated 421 lines...][2020-01-31T15:35:26.934Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.cpp:11:[2020-01-31T15:35:26.934Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.h:24:4: warning: "The USB subsystem has changed in 8.0. Disabling." [-W#warnings][2020-01-31T15:35:26.934Z] #  warning "The USB subsystem has changed in 8.0. Disabling."[2020-01-31T15:35:26.934Z]^[2020-01-31T15:35:26.934Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/kcmusb.cpp:26:[2020-01-31T15:35:26.934Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.h:24:4: warning: "The USB subsystem has changed in 8.0. Disabling." [-W#warnings][2020-01-31T15:35:26.934Z] #  warning "The USB subsystem has changed in 8.0. Disabling."[2020-01-31T15:35:26.934Z]^[2020-01-31T15:35:27.582Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/usbview/usbdevices.h:72:64: warning: private field '_power' is not used [-Wunused-private-field][2020-01-31T15:35:27.582Z] int _bus, _level, _parent, _port, _count, _device, _channels, _power;[2020-01-31T15:35:27.582Z]   ^[2020-01-31T15:35:27.582Z] [ 32%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/memory.cpp.o[2020-01-31T15:35:27.862Z] 2 warnings generated.[2020-01-31T15:35:27.862Z] 1 warning generated.[2020-01-31T15:35:27.862Z] [ 33%] Building CXX object Modules/usbview/CMakeFiles/kcm_usb.dir/usbdb.cpp.o[2020-01-31T15:35:28.132Z] Scanning dependencies of target kcm_samba[2020-01-31T15:35:28.132Z] [ 35%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/main.cpp.o[2020-01-31T15:35:28.406Z] [ 37%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/kcm_samba_autogen/mocs_compilation.cpp.o[2020-01-31T15:35:28.700Z] [ 38%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/soldevice.cpp.o[2020-01-31T15:35:28.989Z] [ 40%] Building CXX object Modules/about-distro/src/CMakeFiles/kcm_about_distro.dir/Module.cpp.o[2020-01-31T15:35:30.403Z] [ 41%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/chartWidget.cpp.o[2020-01-31T15:35:30.679Z] [ 43%] Linking CXX shared module ../../bin/kcm_usb.so[2020-01-31T15:35:30.961Z] [ 43%] Built target kcm_usb[2020-01-31T15:35:30.961Z] [ 45%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/totalMemoryChart.cpp.o[2020-01-31T15:35:30.961Z] [ 46%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/main.cpp.o[2020-01-31T15:35:31.244Z] [ 48%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/info.cpp.o[2020-01-31T15:35:31.843Z] [ 50%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/devinfo.cpp.o[2020-01-31T15:35:32.112Z] [ 51%] Linking CXX shared module ../../../bin/kcm_about_distro.so[2020-01-31T15:35:32.729Z] [ 51%] Built target kcm_about_distro[2020-01-31T15:35:32.729Z] [ 53%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/os_current.cpp.o[2020-01-31T15:35:33.037Z] [ 54%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/physicalMemoryChart.cpp.o[2020-01-31T15:35:33.312Z] Scanning dependencies of target kcm_nic[2020-01-31T15:35:33.312Z] [ 56%] Building CXX object Modules/nics/CMakeFiles/kcm_nic.dir/kcm_nic_autogen/mocs_compilation.cpp.o[2020-01-31T15:35:33.944Z] [ 58%] Building CXX object Modules/samba/CMakeFiles/kcm_samba.dir/ksmbstatus.cpp.o[2020-01-31T15:35:33.944Z] [ 59%] Building CXX object Modules/memory/CMakeFiles/kcm_memory.dir/swapMemoryChart.cpp.o[2020-01-31T15:35:34.891Z] [ 61%] Building CXX object Modules/devinfo/CMakeFiles/kcm_devinfo.dir/devicelisting.cpp.o[2020-01-31T15:35:34.891Z] In file included from /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/base/os_current.cpp:24:[2020-01-31T15:35:34.891Z] /usr/home/jenkins/workspace/Plasma/kinfocenter/kf5-qt5 FreeBSDQt5.13/Modules/info/../base/os_base.h:343:12: warning: unused function 'GetInfo_ReadfromPipe' [-Wunused-function][2020-01-31T15:35:34.891Z] static int GetInfo_ReadfromPipe(QTreeWidget* tree, const char *FileName, bool WithEmptyLines = true) {[2020-01-31T15:35:34.891Z]^[2020-01-31T15:35:35.182Z] 1 warning generated.[2020-01-31T15:35:35.182Z] [ 62%] Building CXX object Modules/info/CMakeFiles/kcm_info.dir/__/base/info_wayland.cpp.o[2020-01-31T15:35:35.182Z] [ 64%] Building CXX object Modules/nics/CMakeFiles/kcm_nic.dir/nic.cpp.o[2020-01-31T15:35:35.182Z] [ 66%] Building CXX object 

D27052: Solid-device-automounter/kcm: Convert some foreach

[Méven Car]

meven updated this revision to Diff 74803.
meven added a comment.


  Add intermediate const variable for function

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27052?vs=74742=74803

BRANCH
  arcpatch-D27052

REVISION DETAIL
  https://phabricator.kde.org/D27052

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceModel.cpp
  solid-device-automounter/kded/DeviceAutomounter.cpp

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

[Konrad Materka]

kmaterka updated this revision to Diff 74802.
kmaterka added a comment.


  Rebase2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26992?vs=74797=74802

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26992

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26574: [Applet]Hide hamburger menu when empty

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:10ab204a62cf: [Applet]Hide hamburger menu when empty 
(authored by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26574?vs=74150=74801

REVISION DETAIL
  https://phabricator.kde.org/D26574

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml

To: gvgeo, #vdg, #plasma, drosca, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26418: [Applet]Add global mute function

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:681e1c8faaaf: [Applet]Add global mute function (authored 
by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26418?vs=74149=74800

REVISION DETAIL
  https://phabricator.kde.org/D26418

AFFECTED FILES
  applet/contents/config/main.xml
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, drosca, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26256: [Applet] Make 'raise maximum volume' global

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:d0c753c188e8: [Applet] Make raise maximum 
volume global (authored by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26256?vs=74192=74798

REVISION DETAIL
  https://phabricator.kde.org/D26256

AFFECTED FILES
  applet/contents/code/icon.js
  applet/contents/config/main.xml
  applet/contents/ui/ConfigGeneral.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml

To: gvgeo, ngraham, #vdg, #plasma, drosca
Cc: drosca, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26992: [SystemTray] Use unified data model everywhere

[Konrad Materka]

kmaterka updated this revision to Diff 74797.
kmaterka added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26992?vs=74586=74797

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D26992

AFFECTED FILES
  applets/systemtray/CMakeLists.txt
  applets/systemtray/package/contents/applet/CompactApplet.qml
  applets/systemtray/package/contents/ui/ConfigEntries.qml
  applets/systemtray/package/contents/ui/ExpandedRepresentation.qml
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/PlasmoidPopupsContainer.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml
  applets/systemtray/sortedsystemtraymodel.cpp
  applets/systemtray/sortedsystemtraymodel.h
  applets/systemtray/systemtray.cpp
  applets/systemtray/systemtray.h
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26271: [Applet]Update layout based on T10470

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R115:8ada15ad8e5b: [Applet]Update layout based on T10470 
(authored by gvgeo, committed by ngraham).

REPOSITORY
  R115 Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26271?vs=74145=74796

REVISION DETAIL
  https://phabricator.kde.org/D26271

AFFECTED FILES
  applet/contents/ui/DeviceListItem.qml
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/StreamListItem.qml
  applet/contents/ui/main.qml

To: gvgeo, #vdg, #plasma, manueljlin, drosca, ngraham
Cc: cfeck, ndavis, filipf, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, 
alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex updated this revision to Diff 74795.
alex added a comment.


  Simplify statement

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=74793=74795

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck_config.cpp

To: alex, kossebau, vhanda
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27045: [wallpapers] Use more high-quality JPEGs for Next

[Filip Fila]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:df58788d4cf4: [wallpapers] Use more high-quality JPEGs for 
Next (authored by filipf).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27045?vs=74721=74794

REVISION DETAIL
  https://phabricator.kde.org/D27045

AFFECTED FILES
  wallpapers/Next/contents/images/1024x768.jpg
  wallpapers/Next/contents/images/1280x1024.jpg
  wallpapers/Next/contents/images/1280x800.jpg
  wallpapers/Next/contents/images/1366x768.jpg
  wallpapers/Next/contents/images/1440x900.jpg
  wallpapers/Next/contents/images/1600x1200.jpg
  wallpapers/Next/contents/images/1680x1050.jpg
  wallpapers/Next/contents/images/1920x1080.jpg
  wallpapers/Next/contents/images/1920x1200.jpg
  wallpapers/Next/contents/images/2560x1440.jpg
  wallpapers/Next/contents/images/2560x1600.jpg
  wallpapers/Next/contents/images/3200x1800.jpg
  wallpapers/Next/contents/images/3200x2000.jpg
  wallpapers/Next/contents/images/3840x2160.jpg
  wallpapers/Next/contents/images/5120x2880.jpg

To: filipf, #plasma, #vdg, ngraham
Cc: The-Feren-OS-Dev, rikmills, raveomelette, plasma-devel, Orage, LeGast00n, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex updated this revision to Diff 74793.
alex added a comment.


  Remove unused include

REPOSITORY
  R114 Plasma Addons

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27070?vs=74789=74793

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck_config.cpp

To: alex, kossebau, vhanda
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26729: do not disable getifaddrs use because of sa_len availablility

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:4582053b7cac: do not disable getifaddrs use because of 
sa_len availablility (authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26729?vs=73777=74792

REVISION DETAIL
  https://phabricator.kde.org/D26729

AFFECTED FILES
  Modules/nics/nic.cpp

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

[Harald Sitter]

sitter added a comment.


  I was trying to recycle as many strings as possible. If the localizers are 
fine with us throwing caution to the wind for those two strings as well then 
that's fine with me naturally, it would also allow me to get rid of a naughty 
hack I had to pull to retain the strings.
  If not, we can improve the strings in master for 5.19.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27061

To: sitter, #localization, #plasma, #vdg
Cc: ngraham, alexde, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27068: [System Tray] Initially set correct category for plasmoids

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:50f9c3cf5292: [System Tray] Initially set correct 
category for plasmoids (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27068?vs=74786=74790

REVISION DETAIL
  https://phabricator.kde.org/D27068

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp

To: broulik, #plasma, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27070: Refactor foreach, use Qt5 signal syntax, remove unnecessary method call

[Alexander Lohnau]

alex created this revision.
alex added reviewers: kossebau, vhanda.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  The two foreach occurences are refactored and the signals in the runner/kcm 
now use the C++ 11 for loop.
  Additonally the duplicate call of the load method has been removed and 
smaller improvements have been made.

TEST PLAN
  Compile time check for signals, trying out the runner and editing the config.

REPOSITORY
  R114 Plasma Addons

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27070

AFFECTED FILES
  runners/spellchecker/spellcheck.cpp
  runners/spellchecker/spellcheck_config.cpp

To: alex, kossebau, vhanda
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

[Nathaniel Graham]

ngraham added a comment.


  In D27047#604091 , @apol wrote:
  
  > We made an effort to not use "convergence", as it seems like it's hard to 
understand. How about "adaptable"?
  
  
  +1, that's a better word.

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27047

To: nicolasfella, #kirigami
Cc: ngraham, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart, hein

D27068: [System Tray] Initially set correct category for plasmoids

[Kai Uwe Broulik]

broulik added a comment.


  > category overrides in main.qml
  
  I think those should go away and have the SNI/plasmoid in the right category. 
I think most of them are obsolete already anyway, e.g. 
`org.kde.plasma.networkmanagement` is `Hardware` in its metadata

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27068

To: broulik, #plasma, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27068: [System Tray] Initially set correct category for plasmoids

[Konrad Materka]

kmaterka accepted this revision.
kmaterka added a comment.
This revision is now accepted and ready to land.


  I definitely need to split D26992  into 
smaller chunks :) I had it fixed, but obviously D26992 
 can't be merged for 5.18.
  
  There is a second inconsistency, but it is not a serious problem. There are 
some category overrides in main.qml, if you think it is a problem I will 
prepare separate revision with something like this:
  
static const QHash s_categoryOverride = {
{QStringLiteral("org.kde.discovernotifier"), 
QStringLiteral("SystemServices")},
{QStringLiteral("org.kde.plasma.networkmanagement"), 
QStringLiteral("Hardware")},
{QStringLiteral("org.kde.kdeconnect"), QStringLiteral("Hardware")},
{QStringLiteral("org.kde.plasma.keyboardindicator"), 
QStringLiteral("Hardware")},
{QStringLiteral("touchpad"), QStringLiteral("Hardware")}
};

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27068

To: broulik, #plasma, kmaterka
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27047: Make the api docs reflect that Kirigami is not only a mobile toolkit

[Aleix Pol Gonzalez]

apol added a comment.


  We made an effort to not use "convergence", as it seems like it's hard to 
understand. How about "adaptable"?
  
  concept makes sense to me.

INLINE COMMENTS

> Mainpage.dox:26
>  \section overview Introduction
> -Kirigami is a set of QtQuick components at the moment targeted for mobile 
> use (in the future desktop as well) targeting both Plasma Mobile and Android. 
> It’s not a whole set of components (all the “Primitive” ones like buttons and 
> textboxes are a job for QtQuickControls2), but it’s a set of high-level 
> components to make the creation of applications that look and feel great on 
> mobile as well as desktop devices and follow the  href="https://hig.kde.org;>KDE Human Interface Guidelines.
> +Kirigami is a set of QtQuick components for building convergent UIs based on 
> Qt Quick Controls 2. It's goal is to enable creation of applications that 
> look and feel great on mobile as well as desktop devices and follow the  href="https://hig.kde.org;>KDE Human Interface Guidelines.
>  The target of those components is anybody that wants to do an application 
> using QtQuick as its main UI, especially if targeting a mobile platform, 
> without adding many dependencies. They work on a variety of platforms, such 
> as Plasma Mobile, Desktop Linux, Android, iOS and Windows.

`Its goal`

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27047

To: nicolasfella, #kirigami
Cc: apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
ahiemstra, davidedmundson, mart, hein

D27063: Fix disabeling of autolock timeout

[Alexander Lohnau]

alex added a comment.


  Thats a good point, the issue is that the validation slot gets only triggered 
if the value gets changed. 
  If the automatic locking is disabled the value does not change and no signal 
gets triggered.
  
  Setting the spin box disabled by default is then the easiest solution :-)

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D27063

To: alex, mart, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27063: Fix disabeling of autolock timeout

[Alexander Lohnau]

alex updated this revision to Diff 74787.
alex added a comment.


  Set spinbox disabled by default

REPOSITORY
  R133 KScreenLocker

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27063?vs=74769=74787

BRANCH
  fix_disabled_state

REVISION DETAIL
  https://phabricator.kde.org/D27063

AFFECTED FILES
  kcm/kcm.ui

To: alex, mart, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27027: Clip the flickable parent item

[Arjen Hiemstra]

ahiemstra added a comment.


  Note that I did spend some time investigating what causes the clipping to be 
needed in the first place, but that looks like an issue deep in kcmshell5, 
which allows any kcm to be resized to below its minimum size. This also leads 
to issues with other KCMs like https://bugs.kde.org/show_bug.cgi?id=398797

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D27027

To: ahiemstra, #kirigami, ngraham, mart
Cc: ngraham, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart, hein

D27068: [System Tray] Initially set correct category for plasmoids

[Kai Uwe Broulik]

broulik created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  The category was only used for proper `Plasma::Applet` instances but not 
unloaded plasmoids from pure metadata.
  
  BUG: 416947
  FIXED-IN: 5.18.0

TEST PLAN
  - I dont have any plasmoids that shift from Misc to their proper category 
once loaded anymore

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27068

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp

To: broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27027: Clip the flickable parent item

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:dd41d57f5404: Clip the flickable parent item (authored by 
ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27027?vs=74674=74785

REVISION DETAIL
  https://phabricator.kde.org/D27027

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml

To: ahiemstra, #kirigami, ngraham, mart
Cc: ngraham, apol, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, 
ahiemstra, davidedmundson, mart, hein

how OSX tells what type of device a samba host is

[Harald Sitter]

The past week I've been poking around various smb things and also
investigated how OS X knows what device type a remote host is.

After all, Kai has been fond of their lovely CRT screens for the
longest time. But we never quite knew how they actually which server
should have a CRT.

https://i.imgur.com/ASDBCCG.jpg
https://i.imgur.com/DjGw8iT.jpg

Long story short:

- Services discovered over dns-sd are considered "macish" and get
macish icons (e.g. SMITH in screenshot 1)

- Services that further have a _device-info._tcp service get more
specific icons (e.g. me's iMac in screenshot 1 is an iMac so it gets
an iMac icon)

- If that device info contains useless information a question mark
icon is used (e.g. ME-STANDARD in screenshot 2)

- Services discovered via other technology (smb1, wsdiscovery) are PCs
and get CRT icons

So, it simply leverage dns-sd. Albeit in a bit of a special way
because OSX itself does not actually expose _device-info._tcp as a
service but simply sends the information along with the mDNS response.
Furthermore device-info actually has no specified format [1].
It's a bit awkward from an avahi POV because that data doesn't show up
in the regular service listing. To not bore you with avahi details
though, here's what the underlying mDNS response would contain:

me\342\200\231s iMac._device-info._tcp.local: type TXT, class IN
Name: me\342\200\231s iMac._device-info._tcp.local
Type: TXT (Text strings) (16)
.000   0001 = Class: IN (0x0001)
0...    = Cache flush: False
Time to live: 4500
Data length: 26
TXT Length: 14
TXT: model=iMac10,1
TXT Length: 10
TXT: osxvers=18

In essence, the device-info service needs to contain model data and
OSX will make use of it. For example you could retrofit any Linux with
this information by publishing a suitable service

e.g. `avahi-publish -s AJAX _device-info._tcp 0 model=MacBook`

would show the host using a MacBook icon. Other options are listed here [2].

Great!
But what happens when you set arbitrary models?

That is actually what we see in screenshot 2 for the me-STANDARD host.
It uses a newer samba which smartly exports device-info by default.
Not so smartly it does that using the type 'MacSamba' to which OS X
says "?". Also, I'm a bit on the fence about smbd claiming a general
purpose service name like that... Anyway, the question mark icon is
kind of a step back, but fortunately you can actually configure this
[3]

[global]
fruit:model = iMac

in your smb.conf and your PC is an iMac! Macgic!

This more or less concludes what I know on the subject. As a
consequence, since our smb slave supports dns-sd, we could allow icon
themes to have device-adjusted 'network-server-$model' icons. On linux
we of course have the problem that the default MacSamba isn't all that
useful for anything though :(

[1] http://www.dns-sd.org/ServiceTypes.html
[2] https://www.tumfatig.net/20170607/let-mac-os-auto-discover-your-smb-shares/
[3] https://www.samba.org/samba/docs/current/man-html/vfs_fruit.8.html

D27061: replace samba module with data that works

[Nathaniel Graham]

ngraham added reviewers: Localization, Plasma, VDG.
ngraham added a comment.


  Very nice. Looks much better and seems to work quite well.
  
  While we're already breaking proposing breaking the string freeze, instead of 
"Exports" and "Imports", how about "Exported Shares" and "Mounted shares" or 
"Accessed shares"? Needs #localization 
 approval for that of course.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D27061

To: sitter, #localization, #plasma, #vdg
Cc: ngraham, alexde, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27029: Remove header top margin from private ScrollView

[Arjen Hiemstra]

This revision was automatically updated to reflect the committed changes.
Closed by commit R169:da3d41f13690: Remove header top margin from private 
ScrollView (authored by ahiemstra).

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27029?vs=74677=74784

REVISION DETAIL
  https://phabricator.kde.org/D27029

AFFECTED FILES
  src/controls/templates/private/ScrollView.qml

To: ahiemstra, #kirigami, ngraham, mart
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart, hein

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

[Méven Car]

meven updated this revision to Diff 74782.
meven added a comment.


  Use a switch case

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27057?vs=74773=74782

BRANCH
  onattabch

REVISION DETAIL
  https://phabricator.kde.org/D27057

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceModel.cpp
  solid-device-automounter/kcm/DeviceModel.h

To: meven, #plasma, ervin, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27066: remove pointless ifdef

[Laurent Montel]

mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.


  wrong as static_cast is deprecated and it will 
not work without deprecated method.
  Or you can convert it to  static_cast
  but "int" signal doesn't exist when we build without deprecarted method

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D27066

To: sitter, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27066: remove pointless ifdef

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: mlaurent.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  the cast may not be necessary with <5.15 it will build all the same
  since we are using legacy API here

TEST PLAN
  build

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27066

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_base.cpp
  src/bugzillaintegration/reportassistantpages_bugzilla_duplicates.cpp

To: sitter, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27053: Solid-device-automounter/kcm: Improve width of columns

[Méven Car]

meven updated this revision to Diff 74776.
meven added a comment.


  Case issue

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27053?vs=74770=74776

BRANCH
  arcpatch-D27053

REVISION DETAIL
  https://phabricator.kde.org/D27053

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, ngraham, ervin, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26941: [Task Manager] Remove strict URL handling

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bb573b83ace5: [Task Manager] Remove strict URL handling 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D26941?vs=74424=74775

REVISION DETAIL
  https://phabricator.kde.org/D26941

AFFECTED FILES
  libtaskmanager/autotests/launchertasksmodeltest.cpp
  libtaskmanager/launchertasksmodel.cpp
  libtaskmanager/launchertasksmodel_p.h

To: broulik, #plasma, hein, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

[Méven Car]

meven updated this revision to Diff 74773.
meven marked 3 inline comments as done.
meven added a comment.


  Simplify DeviceModel::flags, carriage returns

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27057?vs=74750=74773

BRANCH
  onattabch

REVISION DETAIL
  https://phabricator.kde.org/D27057

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceModel.cpp
  solid-device-automounter/kcm/DeviceModel.h

To: meven, #plasma, ervin, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 4 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/4/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 31 Jan 2020 13:29:38 +
 Build duration:
4 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 502 lines...][2020-01-31T13:33:37.394Z] [120/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportinterface.cpp.obj[2020-01-31T13:33:37.394Z] [121/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_bugzilla_duplicates.cpp.obj[2020-01-31T13:33:37.981Z] [122/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\duplicatefinderjob.cpp.obj[2020-01-31T13:33:37.981Z] [123/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\productmapping.cpp.obj[2020-01-31T13:33:38.556Z] [124/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\reportassistantpages_bugzilla.cpp.obj[2020-01-31T13:33:39.141Z] [125/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\drkonqi_debug.cpp.obj[2020-01-31T13:33:39.141Z] [126/149] Linking CXX executable bin\bugtest.exe[2020-01-31T13:33:39.402Z] [127/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\producttest.dir\producttest_autogen\mocs_compilation.cpp.obj[2020-01-31T13:33:39.403Z] [128/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\bugzillaintegration\parsebugbacktraces.cpp.obj[2020-01-31T13:33:39.403Z] [129/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\commenttest.dir\commenttest_autogen\mocs_compilation.cpp.obj[2020-01-31T13:33:39.663Z] [130/149] Building CXX object src\CMakeFiles\DrKonqiInternal.dir\DrKonqiInternal_autogen\mocs_compilation.cpp.obj[2020-01-31T13:33:39.663Z] [131/149] Linking CXX executable bin\attachmenttest.exe[2020-01-31T13:33:39.663Z] [132/149] Automatic MOC for target connectiontest[2020-01-31T13:33:39.663Z] [133/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\connectiontest.dir\connectiontest_autogen\mocs_compilation.cpp.obj[2020-01-31T13:33:39.927Z] [134/149] Linking CXX executable bin\bugzillatest.exe[2020-01-31T13:33:39.927Z] [135/149] Linking CXX static library lib\DrKonqiInternal.lib[2020-01-31T13:33:40.189Z] [136/149] Automatic MOC for target drkonqi[2020-01-31T13:33:40.189Z] [137/149] Automatic MOC for target bugfieldtest[2020-01-31T13:33:40.189Z] [138/149] Building CXX object src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj[2020-01-31T13:33:40.189Z] [139/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\bugfieldtest.dir\bugfieldtest_autogen\mocs_compilation.cpp.obj[2020-01-31T13:33:41.578Z] [140/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\commenttest.dir\commenttest.cpp.obj[2020-01-31T13:33:41.578Z] [141/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\producttest.dir\producttest.cpp.obj[2020-01-31T13:33:41.843Z] [142/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\bugfieldtest.dir\bugfieldtest.cpp.obj[2020-01-31T13:33:42.417Z] [143/149] Building CXX object src\bugzillaintegration\libbugzilla\autotests\CMakeFiles\connectiontest.dir\connectiontest.cpp.obj[2020-01-31T13:33:42.417Z] ..\src\bugzillaintegration\libbugzilla\autotests\connectiontest.cpp(52): warning C4101: 'e': unreferenced local variable[2020-01-31T13:33:42.417Z] ..\src\bugzillaintegration\libbugzilla\autotests\connectiontest.cpp(159): warning C4573: the usage of 'QObject::connect' requires the compiler to capture 'this' but the current default capture mode does not allow it[2020-01-31T13:33:42.678Z] [144/149] Building CXX object src\CMakeFiles\drkonqi.dir\main.cpp.obj[2020-01-31T13:33:42.939Z] [145/149] Linking CXX executable bin\commenttest.exe[2020-01-31T13:33:43.511Z] [146/149] Linking CXX executable bin\producttest.exe[2020-01-31T13:33:43.771Z] [147/149] Linking CXX executable bin\bugfieldtest.exe[2020-01-31T13:33:44.033Z] [148/149] Linking CXX executable bin\connectiontest.exe[2020-01-31T13:33:44.300Z] [149/149] Linking CXX executable bin\drkonqi.exe[2020-01-31T13:33:44.300Z] FAILED: bin/drkonqi.exe [2020-01-31T13:33:44.301Z] cmd.exe /C "cd . && C:\Craft\CI-Qt514\windows-msvc2019_64-cl-debug\dev-utils\cmake-base\bin\cmake.exe -E vs_link_exe --intdir=src\CMakeFiles\drkonqi.dir --manifests  -- C:\PROGRA~2\MICROS~1\2019\PROFES~1\VC\Tools\MSVC\1424~1.283\bin\Hostx64\x64\link.exe /nologo src\CMakeFiles\drkonqi.dir\main.cpp.obj src\CMakeFiles\drkonqi.dir\drkonqi_autogen\mocs_compilation.cpp.obj  /out:bin\drkonqi.exe /implib:lib\drkonqi.lib /pdb:bin\drkonqi.pdb /version:0.0  /machine:x64 /NODEFAULTLIB:libcmtd /DEFAULTLIB:msvcrtd /debug /INCREMENTAL  /subsystem:console  lib\DrKonqiInternal.lib "C:\CI\Software Installs\drkonqi\lib\KF5ConfigWidgets.lib" 

D27041: fix incorrect parsing of "at foo.so" and empty function name

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:a90e3b38468b: fix incorrect parsing of at 
foo.so and empty function name (authored by sitter).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27041?vs=74710=74774

REVISION DETAIL
  https://phabricator.kde.org/D27041

AFFECTED FILES
  src/parser/backtraceparsergdb.cpp
  src/parser/backtraceparsergdb.h
  src/tests/CMakeLists.txt
  src/tests/gdbbacktracelinetest.cpp

To: sitter, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » stable-kf5-qt5 WindowsMSVCQt5.14 - Build # 2 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/stable-kf5-qt5%20WindowsMSVCQt5.14/2/
 Project:
stable-kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Fri, 31 Jan 2020 13:29:38 +
 Build duration:
1 min 18 sec and counting
   CONSOLE OUTPUT
  [...truncated 391 lines...][2020-01-31T13:30:48.420Z] [8/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsercdb.cpp.obj[2020-01-31T13:30:48.420Z] [9/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsernull.cpp.obj[2020-01-31T13:30:48.421Z] [10/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla.cpp.obj[2020-01-31T13:30:48.421Z] [11/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_parser_debug.cpp.obj[2020-01-31T13:30:48.689Z] [12/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserkdbgwin.cpp.obj[2020-01-31T13:30:48.689Z] [13/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsergdb.cpp.obj[2020-01-31T13:30:48.689Z] [14/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparser.cpp.obj[2020-01-31T13:30:48.953Z] [15/149] Building CXX object src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest.cpp.obj[2020-01-31T13:30:49.218Z] [16/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\callbacks.cpp.obj[2020-01-31T13:30:49.218Z] [17/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_process.cpp.obj[2020-01-31T13:30:49.485Z] [18/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugupdate.cpp.obj[2020-01-31T13:30:49.745Z] [19/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newattachment.cpp.obj[2020-01-31T13:30:49.745Z] [20/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\connection.cpp.obj[2020-01-31T13:30:49.745Z] [21/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\productclient.cpp.obj[2020-01-31T13:30:49.745Z] [22/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\jsoncommand.cpp.obj[2020-01-31T13:30:49.745Z] [23/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\bugsearch.cpp.obj[2020-01-31T13:30:49.745Z] [24/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\apijob.cpp.obj[2020-01-31T13:30:49.745Z] [25/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugfieldclient.cpp.obj[2020-01-31T13:30:49.745Z] [26/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\attachmentclient.cpp.obj[2020-01-31T13:30:50.004Z] [27/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commentclient.cpp.obj[2020-01-31T13:30:50.266Z] [28/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\bugclient.cpp.obj[2020-01-31T13:30:50.527Z] [29/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\exceptions.cpp.obj[2020-01-31T13:30:50.527Z] [30/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\logindetails.cpp.obj[2020-01-31T13:30:50.527Z] [31/149] Linking CXX static library lib\drkonqi_backtrace_parser.lib[2020-01-31T13:30:50.527Z] [32/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\clientbase.cpp.obj[2020-01-31T13:30:50.793Z] [33/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\comment.cpp.obj[2020-01-31T13:30:50.793Z] [34/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newbug.cpp.obj[2020-01-31T13:30:50.793Z] [35/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\bugzilla_debug.cpp.obj[2020-01-31T13:30:50.793Z] [36/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bugfield.cpp.obj[2020-01-31T13:30:50.793Z] [37/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\querycommand.cpp.obj[2020-01-31T13:30:50.793Z] [38/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bug.cpp.obj[2020-01-31T13:30:51.078Z] [39/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\qbugzilla_autogen\mocs_compilation.cpp.obj[2020-01-31T13:30:51.078Z] [40/149] Linking CXX executable bin\crashtest.exe[2020-01-31T13:30:51.078Z] [41/149] Automatic MOC for target gdbbacktracelinetest[2020-01-31T13:30:51.078Z] [42/149] Automatic MOC for target 

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

[Kevin Ottens]

ervin requested changes to this revision.
ervin added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> DeviceModel.cpp:185
>  if (index.isValid()) {
> -if (index.parent().isValid()) {
> -if (index.column() > 0) {
> -return Qt::ItemIsSelectable | Qt::ItemIsEnabled | 
> Qt::ItemIsUserCheckable;
> -} else if (index.column() == 0) {
> -return Qt::ItemIsSelectable | Qt::ItemIsEnabled;
> +if (index.parent().isValid() && index.column() > 0) {
> +if (index.column() == 1) {

This logic is becoming harder to read than necessary. I think I would go for 
something structured along those lines:

  if (!index.parent().isValid()) {
  return Qt::ItemIsEnabled;
  }
  
  switch (index.column()) {
  case 0:
  ...
  case 1:
  ...
  case 2:
  ...
  default:
  Q_UNREACHABLE
  }

> DeviceModel.cpp:350
> +
> +void DeviceModel::setAutomaticMountOnLogin(bool automaticLogin) {
> +if (m_automaticLogin != automaticLogin) {

{ Should be on its own line

> DeviceModel.cpp:359
> +}
> +void DeviceModel::setAutomaticMountOnPlugin(bool automaticAttached) {
> +if (m_automaticAttached != automaticAttached) {

Ditto + needs an empty line before that one.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27057

To: meven, #plasma, ervin, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27041: fix incorrect parsing of "at foo.so" and empty function name

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Nice find.

REPOSITORY
  R871 DrKonqi

BRANCH
  Plasma/5.18

REVISION DETAIL
  https://phabricator.kde.org/D27041

To: sitter, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27053: Solid-device-automounter/kcm: Improve width of columns

[Kevin Ottens]

ervin added a comment.


  LGTM, waiting for nate's opinion.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27053

To: meven, ngraham, ervin, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27063: Fix disabeling of autolock timeout

[Kevin Ottens]

ervin added a comment.


  Looks like it's caused by the initial state of the ui file being "wrong" 
(checkbox unchecked and spinbox enabled), what about simply having the spinbox 
disabled in the ui file? Maybe we miss a connect there too. It's the kind of ui 
specific details I try to push out of the C++ file.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D27063

To: alex, mart, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27045: [wallpapers] Use more high-quality JPEGs for Next

[Nathaniel Graham]

ngraham added a comment.


  Agreed. Perhaps for the next contest, we should explicitly require that the 
5K version be under 6 MB, and provide a few recommendations for how to achieve 
this.

REPOSITORY
  R31 Breeze

BRANCH
  more-hq-next (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27045

To: filipf, #plasma, #vdg, ngraham
Cc: The-Feren-OS-Dev, rikmills, raveomelette, plasma-devel, Orage, LeGast00n, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27053: Solid-device-automounter/kcm: Improve width of columns

[Méven Car]

meven updated this revision to Diff 74770.
meven added a comment.


  Add translation context

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27053?vs=74743=74770

BRANCH
  arcpatch-D27053

REVISION DETAIL
  https://phabricator.kde.org/D27053

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.ui
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, ngraham, ervin, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27063: Fix disabeling of autolock timeout

[Alexander Lohnau]

alex created this revision.
alex added reviewers: mart, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
alex requested review of this revision.

REVISION SUMMARY
  When the "Lock Screen:" checkbox gets disabled the timeout spin box gets 
disabled too.
  But the spin box is still enabled when the checkbox is disabled if the module 
is loaded.

TEST PLAN
  Disable screenlocking and restart module. The spin box should be disabled.
  Before:
  
https://phabricator.kde.org/file/data/u6vxui546tvyluaoyo4l/PHID-FILE-b3uowaz5ar2xk7buwt6r/edit_before.png
  
  After:
  
https://phabricator.kde.org/file/data/6cwds725zvhbtadcndxt/PHID-FILE-onnxln4uw4miuvcj7nbf/edit_after.png

REPOSITORY
  R133 KScreenLocker

BRANCH
  fix_disabled_state

REVISION DETAIL
  https://phabricator.kde.org/D27063

AFFECTED FILES
  kcm/kcm.cpp

To: alex, mart, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27045: [wallpapers] Use more high-quality JPEGs for Next

[Rik Mills]

rikmills added a comment.


  I don't object to bumping the size for this release.
  
  However, I do wonder if it might be worth thinking about future 
guidelines/rules regarding wallpaper maximum sizes after optimisation.

REPOSITORY
  R31 Breeze

BRANCH
  more-hq-next (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27045

To: filipf, #plasma, #vdg, ngraham
Cc: The-Feren-OS-Dev, rikmills, raveomelette, plasma-devel, Orage, LeGast00n, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27053: Solid-device-automounter/kcm: Improve width of columns

[Méven Car]

meven added a comment.


  Makes more sense with D27057 

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27053

To: meven, ngraham, ervin, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27019: Solid-device-automounter/kcm: Hide ignored Solid::StorageAccess

[Méven Car]

meven updated this revision to Diff 74767.
meven added a comment.


  Don't list ignored devices as intended

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27019?vs=74656=74767

BRANCH
  arcpatch-D27019

REVISION DETAIL
  https://phabricator.kde.org/D27019

AFFECTED FILES
  solid-device-automounter/kcm/DeviceModel.cpp

To: meven, #plasma, broulik, ngraham, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27058: Clean outdated QT_VERSION_CHECK

[Méven Car]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:5ee3b4145c26: Clean outdated QT_VERSION_CHECK (authored 
by meven).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27058?vs=74752=74765

REVISION DETAIL
  https://phabricator.kde.org/D27058

AFFECTED FILES
  kcms/emoticons/emoticonslist.cpp
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp

To: meven, #plasma, ervin, mlaurent, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

[Harald Sitter]

sitter updated this revision to Diff 74764.
sitter added a comment.


  translate accessible bool to icons + resize its column. looks better and 
avoids yet more new strings

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27061?vs=74762=74764

BRANCH
  smb

REVISION DETAIL
  https://phabricator.kde.org/D27061

AFFECTED FILES
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/MIT.txt
  Modules/samba/CMakeLists.txt
  Modules/samba/autotests/CMakeLists.txt
  Modules/samba/autotests/ksambasharemodeltest.cpp
  Modules/samba/autotests/smbmountmodeltest.cpp
  Modules/samba/kcmsambaimports.cpp
  Modules/samba/kcmsambaimports.h
  Modules/samba/kcmsambalog.cpp
  Modules/samba/kcmsambalog.h
  Modules/samba/kcmsambastatistics.cpp
  Modules/samba/kcmsambastatistics.h
  Modules/samba/ksambasharemodel.cpp
  Modules/samba/ksambasharemodel.h
  Modules/samba/ksmbstatus.cpp
  Modules/samba/ksmbstatus.h
  Modules/samba/main.cpp
  Modules/samba/smbmountmodel.cpp
  Modules/samba/smbmountmodel.h

To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

[Harald Sitter]

sitter updated this revision to Diff 74762.
sitter added a comment.


  unbreak model actually

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27061?vs=74761=74762

BRANCH
  smb

REVISION DETAIL
  https://phabricator.kde.org/D27061

AFFECTED FILES
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/MIT.txt
  Modules/samba/CMakeLists.txt
  Modules/samba/autotests/CMakeLists.txt
  Modules/samba/autotests/ksambasharemodeltest.cpp
  Modules/samba/autotests/smbmountmodeltest.cpp
  Modules/samba/kcmsambaimports.cpp
  Modules/samba/kcmsambaimports.h
  Modules/samba/kcmsambalog.cpp
  Modules/samba/kcmsambalog.h
  Modules/samba/kcmsambastatistics.cpp
  Modules/samba/kcmsambastatistics.h
  Modules/samba/ksambasharemodel.cpp
  Modules/samba/ksambasharemodel.h
  Modules/samba/ksmbstatus.cpp
  Modules/samba/ksmbstatus.h
  Modules/samba/main.cpp
  Modules/samba/smbmountmodel.cpp
  Modules/samba/smbmountmodel.h

To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27061: replace samba module with data that works

[Harald Sitter]

sitter created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  ... and doesn't require lots of maintenance!
  this targets 5.18 but is kind of unfortunate because it needs a bunch of
  new strings as no existing strings provide what is needed here.
  
  the previous module was super broken in various ways.
  in the interest of maintainability I've thrown everything out and replaced
  it with 2 core features which require only modeling code on the KInfoCenter
  end and provide actually (possibly) useful functionality to the design
  personas of plasma.
  
  there is now a single page which contains two table views:
  
  a) Exports: this is a simple table of shares "exported" from the host. the
  
data for this comes from KSambaShare in KIOCore. this is the same API
used by dolphin to create new shares, so the data will be consistent
and the API needs maintaining anyway
  
  b) Imports: simple table of shares "imported" (i.e. mounted) onto the host.
  
the data for this comes from solid
  
  both are backed by models, with an eye towards a future port to qml (out of
  scope since I want this fixed for 5.18)
  
  all previous functionality was removed, in part because it was doing CLI
  parsing, some of the parsing was broken, some of the CLI tools couldn't
  even run as !root, log parsing could use incorrect paths on existing users,
  log parsing has nothing to parse with samba defaults, log parsing didn't
  implement per-host log file support (current default in samba), log parsing
  didn't correctly implement per-user-config-log-file support.
  in short: there was not a single feature that worked properly.
  
  BUG: 411433
  BUG: 374141
  BUG: 325951

TEST PLAN
  exports
  ===
  
  - nothing when nothing is exported
  - changing exports via dolphin is immediately reflected in the kcm
  - export data is valid
  
  imports
  ===
  
  - nothing when nothing is mounted
  - (un)mounting a cifs updates the view immediately
  - data is valid

REPOSITORY
  R102 KInfoCenter

BRANCH
  smb

REVISION DETAIL
  https://phabricator.kde.org/D27061

AFFECTED FILES
  LICENSES/GPL-2.0-only.txt
  LICENSES/GPL-2.0-or-later.txt
  LICENSES/GPL-3.0-only.txt
  LICENSES/LicenseRef-KDE-Accepted-GPL.txt
  LICENSES/MIT.txt
  Modules/samba/CMakeLists.txt
  Modules/samba/autotests/CMakeLists.txt
  Modules/samba/autotests/ksambasharemodeltest.cpp
  Modules/samba/autotests/smbmountmodeltest.cpp
  Modules/samba/kcmsambaimports.cpp
  Modules/samba/kcmsambaimports.h
  Modules/samba/kcmsambalog.cpp
  Modules/samba/kcmsambalog.h
  Modules/samba/kcmsambastatistics.cpp
  Modules/samba/kcmsambastatistics.h
  Modules/samba/ksambasharemodel.cpp
  Modules/samba/ksambasharemodel.h
  Modules/samba/ksmbstatus.cpp
  Modules/samba/ksmbstatus.h
  Modules/samba/main.cpp
  Modules/samba/smbmountmodel.cpp
  Modules/samba/smbmountmodel.h

To: sitter
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27052: Solid-device-automounter/kcm: Convert some foreach

[Alexander Lohnau]

alex added a comment.


  > if it is a function you don't need to do anything if the function is const 
(keys()), if not the best practice is to introduce an intermediate const 
variable
  
  That makes everything clear, thank you very much !

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27052

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27036: KApiDox: add "Plasma Workspaces Libraries" group info

[David Edmundson]

davidedmundson commandeered this revision.
davidedmundson edited reviewers, added: kossebau; removed: davidedmundson.
davidedmundson added a comment.


  <3
  
  Saw your messages on kde-devel. Thanks for starting this
  
  I'm sure we can take it from here

REPOSITORY
  R129 Window Decoration Library

REVISION DETAIL
  https://phabricator.kde.org/D27036

To: davidedmundson, #plasma, kossebau
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27052: Solid-device-automounter/kcm: Convert some foreach

[Méven Car]

meven added a comment.


  In D27052#603798 , @alex wrote:
  
  > Hello,
  >  I have a question regarding your changed.
  >
  > you sometimes declare the variables you want to loop over before the loop, 
but sometimes in the loop.
  >  For instance in DeviceModel.cpp line 135 it is declared as a const before 
the loop and  in line 139 it is directly used in the loop.
  >
  > In one of my previous revisions I have implemented it like in line 139 and 
https://phabricator.kde.org/D26912?id=74352#inline-152211 and changes were 
requested.
  >
  > Am I missing conceptual differences between these use cases ?
  >
  > Thanks again for your expertise !
  
  
  The important thing is as long as you don't need to change in a loop the 
container, your container should be const to be used in a for loop, so that 
semantically the for loop is equivalent to the foreach version, but avoiding 
the copying foreach did.
  So either your container is a variable, it needs to be const, if not use 
qAsConst, and if it is a function you don't need to do anything if the function 
is const (`keys()`), if not the best practice is to introduce an intermediate 
const variable.
  
  The long version about this Q_FOREACH / foreach is at 
https://www.kdab.com/goodbye-q_foreach/

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27052

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27054: Syncronise environment to user systemd session

[David Edmundson]

davidedmundson updated this revision to Diff 74755.
davidedmundson added a comment.


  update properly this time

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27054?vs=74751=74755

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27054

AFFECTED FILES
  libkworkspace/updatelaunchenvjob.cpp

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27054: Syncronise environment to user systemd session

[David Edmundson]

davidedmundson planned changes to this revision.
davidedmundson added a comment.


  hold on, I fixed all this.
  
  stupid phab

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27054

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27055: [kcms/cursortheme] Don't skip everything because of lack of XFixes

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> kcmcursortheme.cpp:301
>  
> -// Qt cursors
> -names << "left_ptr"   << "up_arrow"  << "cross"  << "wait"
> -  << "left_ptr_watch" << "ibeam" << "size_ver"   << 
> "size_hor"
> -  << "size_bdiag" << "size_fdiag"<< "size_all"   << "split_v"
> -  << "split_h"<< "pointing_hand" << "openhand"
> -  << "closedhand" << "forbidden" << "whats_this" << "copy" 
> << "move" << "link";
> -
> -// X core cursors
> -names << "X_cursor"<< "right_ptr"   << "hand1"
> -  << "hand2"   << "watch"   << "xterm"
> -  << "crosshair"   << "left_ptr_watch"  << "center_ptr"
> -  << "sb_h_double_arrow"   << "sb_v_double_arrow"   << "fleur"
> -  << "top_left_corner" << "top_side"<< 
> "top_right_corner"
> -  << "right_side"  << "bottom_right_corner" << "bottom_side"
> -  << "bottom_left_corner"  << "left_side"   << 
> "question_arrow"
> -  << "pirate";
> -
> -foreach (const QString , names) {
> -XFixesChangeCursorByName(QX11Info::display(), 
> theme->loadCursor(name, size), QFile::encodeName(name));
> +if (CursorTheme::haveXfixes()) {
> +// Qt cursors

Move this above `QStringList names;`

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27055

To: davidedmundson, #plasma, broulik
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27058: Clean outdated QT_VERSION_CHECK

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ervin, mlaurent.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  Plasma desktop depends on KF 5.66

REPOSITORY
  R119 Plasma Desktop

BRANCH
  clean-check-version

REVISION DETAIL
  https://phabricator.kde.org/D27058

AFFECTED FILES
  kcms/emoticons/emoticonslist.cpp
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp

To: meven, #plasma, ervin, mlaurent
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27054: Syncronise environment to user systemd session

[David Edmundson]

davidedmundson marked 2 inline comments as done.
davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in updatelaunchenvjob.cpp:105
> Does this need some form of escaping?

I don't think so.

you can't have an = in your var name
and that's the only part that matters

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27054

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27052: Solid-device-automounter/kcm: Convert some foreach

[Alexander Lohnau]

alex added a comment.


  Hello,
  I have a question regarding your changed.
  
  you sometimes declare the variables you want to loop over before the loop, 
but sometimes in the loop.
  For instance in DeviceModel.cpp line 135 it is declared as a const before the 
loop and  in line 139 it is directly used in the loop.
  
  In one of my previous revisions I have implemented it like in line 139 and 
https://phabricator.kde.org/D26912?id=74352#inline-152211 and changes were 
requested.
  
  Am I missing conceptual differences between these use cases ?
  
  Thanks again for your expertise !

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27052

To: meven, broulik, ervin, #plasma
Cc: alex, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27054: Syncronise environment to user systemd session

[David Edmundson]

davidedmundson updated this revision to Diff 74751.
davidedmundson added a comment.


  changes

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27054?vs=74745=74751

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27054

AFFECTED FILES
  libkworkspace/updatelaunchenvjob.cpp

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27057: Solid-device-automounter/kcm: Enable/Disable columns automount onLogin/onAttached depending on corresponding checkbox

[Méven Car]

meven created this revision.
meven added reviewers: Plasma, ervin, ngraham, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  To make clear to the user what automount options imply.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  onattabch

REVISION DETAIL
  https://phabricator.kde.org/D27057

AFFECTED FILES
  solid-device-automounter/kcm/DeviceAutomounterKCM.cpp
  solid-device-automounter/kcm/DeviceModel.cpp
  solid-device-automounter/kcm/DeviceModel.h

To: meven, #plasma, ervin, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27023: Port to UpdateLaunchEnvJob

[David Edmundson]

davidedmundson added a comment.


  We haven't called start on any of the jobs, so they do nothing
  
  :/
  
  Also given they're kjobs do we want:
  
  auto job = new UpdateEnvJob()
  so we don't delete the job immediately?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27023

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27054: Syncronise environment to user systemd session

[Kai Uwe Broulik]

broulik added inline comments.

INLINE COMMENTS

> updatelaunchenvjob.cpp:104
> +
> QStringLiteral("/org/freedesktop/systemd1"),
> +
> QStringLiteral("org.freedesktop.systemd1.Manager"),QStringLiteral("SetEnvironment"));
> +const QString updateString = d->varName + "=" + d->value;

Coding style

> updatelaunchenvjob.cpp:105
> +
> QStringLiteral("org.freedesktop.systemd1.Manager"),QStringLiteral("SetEnvironment"));
> +const QString updateString = d->varName + "=" + d->value;
> +systemdActivationMsg.setArguments({QVariant(QStringList{updateString})});

Does this need some form of escaping?

> updatelaunchenvjob.cpp:108
> +
> +auto systemdActivationReply = 
> QDBusConnection::sessionBus().asyncCall(dbusActivationMsg);
> +d->monitorReply(systemdActivationReply);

You probably want to send `systemdActivationMsg`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27054

To: davidedmundson, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27055: [kcms/cursortheme] Don't skip everything because of lack of XFixes

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  XFixes is only used on X.
  But we definitely still need to update the available entries in the size
  combo box.
  We still want to emit changes, and we still want to update the env

TEST PLAN
  Ran on wayland

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27055

AFFECTED FILES
  kcms/cursortheme/kcmcursortheme.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27054: Syncronise environment to user systemd session

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Equivalent of dbus-update-activation-environment but in runtime

TEST PLAN
  Changed cursor theme (with some additional fixes there)
  Checked the systemd env via the property on manager1. 
  It had changed

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27054

AFFECTED FILES
  libkworkspace/updatelaunchenvjob.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D19004: Remove extra nested dbus session

[David Edmundson]

davidedmundson added a comment.


  > git log says it is needed for systems where dbus-user-session is not 
installed
  
  Sure, but I don't understand why the solution is to work around it, rather 
than explain that it's a dep.
  
  ---
  
  This is now causing me problems. I get the two user DBus's and they are set 
up differently. We need to do something.
  
  IMHO we should just make socket activated DBus a system dependency for a 
working system.
  Failing that I can turn this into a:
  
  - try and query DBus, if it fails, run this, otherwise do nothing.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D19004

To: davidedmundson, #plasma
Cc: bshah, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart