D28065: Add missing types to qrc

This revision was automatically updated to reflect the committed changes. Closed by commit R169:f1ac443fefff: Add missing types to qrc (authored by nicolasfella). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28065?vs=77690=77707 REVISION DETAIL

D28067: check for window existence

This revision was automatically updated to reflect the committed changes. Closed by commit R169:848b5a7345f9: check for window existence (authored by mart). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28067?vs=77708=77710 REVISION DETAIL

D28038: Fix enabling border for ShadowedRectangle on item creation

ahiemstra updated this revision to Diff 77709. ahiemstra added a comment. - Use proper float constants REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28038?vs=77589=77709 BRANCH shadowedrectangle_border REVISION DETAIL

D28068: Cleanup file resolving

broulik added inline comments. INLINE COMMENTS > kirigamiplugin.h:51 > #elif defined(KIRIGAMI_BUILD_TYPE_STATIC) > -return filePath; > +return QStringLiteral(":/org/kde/kirigami/") + path; > #else Doesn't that have to be `qrc` to be a valid URL? > kirigamiplugin.h:58 > +{

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

bport accepted this revision. bport added a comment. This revision is now accepted and ready to land. Ok for me but need to wait approval on font dialog review (to ensure correct font style is selected when editing) REPOSITORY R119 Plasma Desktop BRANCH arcpatch-D27785 (branched from

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. In D27892#628090 , @zzag wrote: > Yes, whether tiled windows should cast shadows is something that must be decided by the compositor or ultimately implemented somewhere in KDecoration2 (not a big fan of this though).

D27675: feat: avoid duplicated text when assembling user-facing output names

ahmadsamir added inline comments. INLINE COMMENTS > utils.cpp:64 > +return append(name, QLatin1Char('(') + output->name() + > QLatin1Char(')')); > } > } If I am reading this correctly, you could keep the old code and use simplified(): const QString outName =

D28029: WIP: Use `ShadowedRectangle`

broulik added a comment. kirigamiplugin.cpp: // 2.12 qmlRegisterType(uri, 2, 12, "ShadowedRectangle"); REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28029 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel, Orage,

D28067: check for window existence

mart created this revision. mart added a reviewer: Kirigami. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. mart requested review of this revision. REVISION SUMMARY not always after componentcompleted a window is already there. if is not there, do the same check

D28067: check for window existence

ahiemstra accepted this revision. ahiemstra added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > shadowedrectangle.cpp:178 > + > +void ShadowedRectangle::checkSoftwareItem() > +{ Just a minor nitpick: Please move this to the end of the file so that the

D28068: Cleanup file resolving

nicolasfella created this revision. Herald added a project: Kirigami. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY The current code is ... a mess. resolveFileUrl and resolveFilePath do very similar things, except that one returns a

D27785: [Fonts KCM] Change how nearestExistingFonts() finds a matching font

ahmadsamir added a comment. In D27785#628110 , @bport wrote: > Ok for me but need to wait approval on font dialog review (to ensure correct font style is selected when editing) Thanks. The font dialog review, D27808

D28065: Add missing types to qrc

broulik added a comment. I was wondering, could this file be auto-generated by cmake? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28065 To: nicolasfella, apol Cc: broulik, keithzg, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol,

D28038: Fix enabling border for ShadowedRectangle on item creation

This revision was automatically updated to reflect the committed changes. Closed by commit R169:d545a7155e71: Fix enabling border for ShadowedRectangle on item creation (authored by ahiemstra). REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D28067: check for window existence

broulik added inline comments. INLINE COMMENTS > shadowedrectangle.h:161 > protected: > +void itemChange(QQuickItem::ItemChange change, const > QQuickItem::ItemChangeData ); > QSGNode *updatePaintNode(QSGNode *node, QQuickItem::UpdatePaintNodeData > *data) override; Missing

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 65 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/65/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 08:49:26 + Build duration: 37 sec and counting CONSOLE OUTPUT [...truncated 291

KDE CI: Plasma » drkonqi » kf5-qt5 SUSEQt5.12 - Build # 136 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20SUSEQt5.12/136/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 08:49:26 + Build duration: 51 sec and counting CONSOLE OUTPUT [...truncated 353

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

zzag added a comment. Yes, whether tiled windows should cast shadows is something that must be decided by the compositor or ultimately implemented somewhere in KDecoration2 (not a big fan of this though). REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D27892 To:

D27935: Make kwallet-pam work with pam_fscrypt

sitter added inline comments. INLINE COMMENTS > aacid wrote in pam_kwallet.c:329 > That is a good question, the old code was kind of prepared for it. > > I am going to say "no" open can not be called before authenticate, if you > read

D28042: [DrKonqi] Port QRegExp to QRegularExpression

sitter added a comment. I wouldn't terribly mind a second pair of eyes. Code generally looks good to me though, so if nobody else comments feel free to land in a couple days. INLINE COMMENTS > backtraceparsergdb.cpp:55 > +// "#5 0x7f50e99f776f in QWidget::testAttribute_helper

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 66 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/66/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 11:17:18 + Build duration: 35 sec and counting CONSOLE OUTPUT [...truncated 292

D28066: Remove the STATIC_LIBRARY option to fix static builds

apol added a comment. Makes sense to me. +1 Since most people who did static builds will be using STATIC_LIBRARY, can you set a fatal error if it's on, so the devs know to use BUILD_SHARED_LIBS instead? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28066

D28059: Be more accurate in reporting the x86 CPU features solid detects

This revision was automatically updated to reflect the committed changes. Closed by commit R102:53ff92062221: Be more accurate in reporting the x86 CPU features solid detects (authored by carewolf). REPOSITORY R102 KInfoCenter CHANGES SINCE LAST UPDATE

D28072: [WIP][GTK Config] Apply color scheme to GTK3 application

gikari created this revision. gikari added a reviewer: cblack. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Move from krdb (see D28070 ) with some refactorings.

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY When a KWindowShadow object is destroyed, it's automatically removed from _shadows and therefore

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. In D28074#628308 , @broulik wrote: > It would be nice not to mutate a list that's being deleted Well, we could do something like this (not sure whether it works though) for (KWindowShadow *shadow : _shadows)

Re: Proposal to centralize KCM bugs inside the systemsettings product

On Mon, Mar 16, 2020 at 1:42 PM Nate Graham wrote: > > On 3/12/20 10:58 AM, David Edmundson wrote: > > With one exception: print manager. > > > > The version field will not match the product version . This will be a > > problem. > > Hmm, you're right. I suppose the applet bugs should be moved

D28069: Support execution of shell scripts on activity events

ivan created this revision. ivan added reviewers: davidedmundson, mart. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY In addition to opening a file and starting an application specified by a .desktop file,

D27980: make opengl module support multiple dri devices

sitter updated this revision to Diff 77716. sitter added a comment. use qvector instead of list fix device detection by doing readlink resolution on the correct directory (subdir appending got lost in the code rejiggering) /proc/dri support is now gone entirely as it is only

D28069: Support execution of shell scripts on activity events

ivan updated this revision to Diff 77722. REPOSITORY R161 KActivity Manager Service CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28069?vs=77715=77722 REVISION DETAIL https://phabricator.kde.org/D28069 AFFECTED FILES CMakeLists.txt cmake/modules/CheckCxxFeatures.cmake

D28069: Support execution of shell scripts on activity events

This revision was automatically updated to reflect the committed changes. Closed by commit R161:9a36c4da7d7a: Support execution of shell scripts on activity events (authored by ivan). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28069?vs=77722=77724#toc REPOSITORY R161 KActivity

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. I would say it's undefined behavior. Either way, we should not call qDeleteAll on a container which is being "simultaneously" mutated. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: broulik, plasma-devel,

D28075: [kstyle] Properly unregister widgets in ShadowHelper

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY After a widget has been unregistered, a WinIdChange event may be sent. If that happens, ShadowHelper is

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

anthonyfieroni added a comment. In D28074#628309 , @zzag wrote: > Well, we could do something like this (not sure whether it works though) > > for (KWindowShadow *shadow : _shadows) > disconnect(shadow, nullptr, this, nullptr); >

D28068: Cleanup file resolving

mart added inline comments. INLINE COMMENTS > broulik wrote in kirigamiplugin.h:58 > You sure a `qrc` URL turns into a local path (or rather Qt's internal `:/` > magic path) like this? i think only :/ works? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28068 To:

KDE CI: Plasma » drkonqi » kf5-qt5 SUSEQt5.12 - Build # 137 - Unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20SUSEQt5.12/137/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 11:17:18 + Build duration: 1 min 48 sec and counting JUnit Tests Name: (root) Failed:

monday meeting notes for 16/3/2020

Kai Uwe NOTE: !!! Plasma sprint canceled due to Corona :( !!! gmenu-dbusmenu-proxy: * Fixed radio buttons behavior in menus plasma-browser-integration: * Got bug report about supposed privacy violation but it's again Firefox just leaking file descriptors into the host... KWin: * Made

Re: monday meeting notes for 16/3/2020

On Monday, 16 March 2020 12:44:53 CET Marco Martin wrote: > Kai Uwe > NOTE: !!! Plasma sprint canceled due to Corona :( !!! > gmenu-dbusmenu-proxy: > * Fixed radio buttons behavior in menus > plasma-browser-integration: > * Got bug report about supposed privacy violation but it's again >

D28069: Support execution of shell scripts on activity events

davidedmundson accepted this revision. davidedmundson added a comment. This revision is now accepted and ready to land. > This patch also removes CMake checks for C++11 features and increases Please commit as two. REPOSITORY R161 KActivity Manager Service REVISION DETAIL

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

gikari added inline comments. INLINE COMMENTS > configeditor.cpp:107 > +modifyColorsCssFile(colorsDefinitions); > +// FIXME Find a way to update colors on the fly > +} Also, I would like to move D24275 to kde-gtk-config repo too with autoloading the

D28073: [kstyle] Properly unregister widgets in ShadowHelper

zzag created this revision. zzag added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision. REVISION SUMMARY After a widget has been unregistered, a WinIdChange event may be sent. If that happens, ShadowHelper is

D28073: [kstyle] Properly unregister widgets in ShadowHelper

zzag added a comment. it would be nice to have `qSafeDeleteAll` or something that takes a copy rather than a const ref. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28073 To: zzag, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. Another way around is not to use `qDeleteAll`, e.g. for( QWidget* widget : _widgets ) { unregisterWidget( widget ); } // or uninstallShadows() Either way, I'm open to suggestions. :-) REPOSITORY R113 Oxygen Theme REVISION DETAIL

D27701: [ComboBox] Use transparent dimmer

broulik added a comment. In D27701#628321 , @ngraham wrote: > I can't reproduce the issue with the comboboxes on the system tray settings page, which are in a scrollview. Where can I see the original bug? e.g. KScreen's resolution

D27701: [ComboBox] Use transparent dimmer

ngraham added a comment. I can't reproduce the issue with the comboboxes on the system tray settings page, which are in a scrollview. Where can I see the original bug? REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27701 To: broulik,

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77730. cblack added a comment. Drop extraneous meson.build REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77729=77730 BRANCH color-reload-module (branched from master) REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack created this revision. cblack added a reviewer: Plasma. cblack added a project: Plasma. cblack requested review of this revision. REVISION SUMMARY The title is somewhat self explanatory. TEST PLAN `gtk-app-here --gtk-module colorreload-gtk-module` REPOSITORY R99 KDE Gtk

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. it would be nice to have qSafeDeleteAll or something that takes a copy rather than a const ref. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

broulik added a comment. It would be nice not to mutate a list that's being deleted REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D27701: [ComboBox] Use transparent dimmer

ngraham added a comment. Ah yes, can reproduce with that combobox, when running the KScreen KCM in both System Settings and KCMShell. But not for other comboboxes! :p REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D27701 To: broulik,

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 11 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/11/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 16 Mar 2020 11:17:18 + Build duration: 55 sec and counting CONSOLE OUTPUT

D28070: [KRDB] Remove GTK3 color export

gikari created this revision. gikari added a reviewer: cblack. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY This will be moved to kde-gtk-config module, once ready. REPOSITORY R119 Plasma Desktop BRANCH

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

broulik added a comment. Don't you access garbage then if the shadow is destroyed during `qDeleteAll`? REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh,

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari requested changes to this revision. gikari added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > CMakeLists.txt:1 > +cmake_minimum_required ( VERSION 3.14 ) > +project ( libcolorreload C ) Would you mind setting this at the parent CMakeLists.txt? >

D28077: [applet] Add tooltip to enable bluetooth checkbox

This revision was automatically updated to reflect the committed changes. Closed by commit R97:a0bc4ed75f46: [applet] Add tooltip to enable bluetooth checkbox (authored by nicolasfella). REPOSITORY R97 Bluedevil CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28077?vs=77735=77736

D28029: Use `ShadowedRectangle`

This revision was automatically updated to reflect the committed changes. Closed by commit R858:1bb57b10e7bd: Use `ShadowedRectangle` (authored by broulik). REPOSITORY R858 Qt Quick Controls 2: Desktop Style CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28029?vs=77573=77738

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

ngraham added a comment. In D27892#628109 , @davidre wrote: > Please note that his doesn't disable shadows completely for quick tiled windows, only on the edges that it is tiled to. Personally I think that would be worthwhile, if we had

Re: Proposal to centralize KCM bugs inside the systemsettings product

On 3/16/20 8:03 AM, David Edmundson wrote: On Mon, Mar 16, 2020 at 1:42 PM Nate Graham wrote: Hmm, you're right. I suppose the applet bugs should be moved back into print-manager then. Would you like me to do that? There are only four bugs in there so it should not generate a flood or

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 12 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/12/ Project: kf5-qt5 WindowsMSVCQt5.14 Date of build: Mon, 16 Mar 2020 14:06:16 + Build duration: 56 sec and counting CONSOLE OUTPUT

D28029: Use `ShadowedRectangle`

ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land. My bad, sorry. LGTM. REPOSITORY R858 Qt Quick Controls 2: Desktop Style REVISION DETAIL https://phabricator.kde.org/D28029 To: broulik, #plasma, ngraham Cc: ngraham, plasma-devel,

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:9 > + > +add_library( > +colorreload-gtk-module SHARED add_library(colorreload-gtk-module SHARED reloader.c ) > CMakeLists.txt:14 > + > +target_link_libraries( > +colorreload-gtk-module PRIVATE Sorry, this is a

D26695: [KCMs/Standard Actions] Give KCMShell window a sane default size

ngraham added a comment. Ping! REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D26695 To: ngraham, #plasma Cc: cfeck, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham,

D28061: Reduce unneeded dependencies

This revision was automatically updated to reflect the committed changes. Closed by commit R871:aa2ea5059e02: Reduce unneeded dependencies (authored by apol). REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28061?vs=77678=77732 REVISION DETAIL

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 67 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/67/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 14:06:16 + Build duration: 37 sec and counting CONSOLE OUTPUT [...truncated 292

D28074: [kstyle] Avoid invalid iterators in qDeleteAll

zzag added a comment. Alternatively, we could drop `qDeleteAll( _widgets );` because the style is destroyed after all widgets have been deleted. REPOSITORY R113 Oxygen Theme REVISION DETAIL https://phabricator.kde.org/D28074 To: zzag, #plasma Cc: anthonyfieroni, broulik, plasma-devel,

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. I'm still seeing the binding loop. :( REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To: cblack, #vdg, #plasma, manueljlin, ngraham Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham, manueljlin,

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

gvgeo added a comment. Are there objections for `Math.round(gridUnit * 2.33)` (42 with default settings) suggested by @filifp? So that it can have big icons. In D27845#622739 , @ndavis wrote: > I don't want to turn this into bikeshedding,

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:1 > +project(libcolorreload C) > + Why is this needed? > CMakeLists.txt:3 > + > +find_package(PkgConfig REQUIRED) > +include(GNUInstallDirs) Move to parent CMakeLists.txt > CMakeLists.txt:4 > +find_package(PkgConfig REQUIRED) >

D27944: KCM Colors fix apply button always disabled

ervin added a comment. I marked it accepted, but of course this is assuming David's patch wouldn't make it quickly and we'd need the fix here ASAP. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27944 To: crossi, #plasma, ervin, bport, meven, broulik Cc:

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added inline comments. INLINE COMMENTS > CMakeLists.txt:3 > set(PROJECT_VERSION "5.17.80") > -cmake_minimum_required(VERSION 2.8.12) > +cmake_minimum_required (VERSION 3.4) > Extra space REPOSITORY R99 KDE Gtk Configuration Tool BRANCH color-reload-module (branched from master)

D25375: Start of the accessibility KCM

ngraham requested changes to this revision. ngraham added a comment. This revision now requires changes to proceed. Almost there! INLINE COMMENTS > Bell.qml:53 > +} > +Row { > +Kirigami.FormData.label: i18nc("Defines if the system will use a > sound system bell", "Audible

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77731. cblack added a comment. Fix memory leak REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77730=77731 BRANCH color-reload-module (branched from master) REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77733. cblack added a comment. Replace 801 with something more semantically meaningful REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77731=77733 BRANCH color-reload-module (branched from

D28077: [applet] Add tooltip to enable bluetooth checkbox

nicolasfella created this revision. nicolasfella added reviewers: Plasma, VDG, drosca. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. nicolasfella requested review of this revision. REVISION SUMMARY Thoroughly inspired by what plasma-nm does REPOSITORY R97 Bluedevil

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added inline comments. INLINE COMMENTS > gikari wrote in CMakeLists.txt:2 > Would you mind making this as a subproject? That's a Meson thing, not a CMake thing. CMake just has add_subdirectory, afaik. REPOSITORY R99 KDE Gtk Configuration Tool REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari accepted this revision. gikari added a comment. This revision is now accepted and ready to land. Nice! Does it need to be manually passed to GTK apps when testing D28072 ? REPOSITORY R99 KDE Gtk Configuration Tool BRANCH color-reload-module

D28064: [applet/notes] Show a "remove" button on the button row

This revision was automatically updated to reflect the committed changes. Closed by commit R114:ef9ecb605dbc: [applet/notes] Show a remove button on the button row (authored by ngraham). REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

ngraham added a comment. Darn. Guess that's gotta get fixed first then. :/ REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D27160 To: cblack, #vdg, #plasma, manueljlin, ngraham Cc: kmaterka, iasensio, ndavis, broulik, gvgeo, davidedmundson, ngraham,

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

davidre added a comment. In D27892#628432 , @ngraham wrote: > In D27892#628109 , @davidre wrote: > > > Please note that his doesn't disable shadows completely for quick tiled windows, only on the

D27892: [RFC] Don't draw shadows on quick tiled or maximized edges

ngraham added a comment. Sorry, I wasn't clear. I mean, I think it would be nice if adjacent quick-tiled windows didn't show shadows on their shared edges. Quick tiled windows would still show shadows on their edges that are not toughing a screen edge or another quick tiled window

D26934: KCM/Autostart Add a model to separate logic from UI

ervin requested changes to this revision. ervin added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > autostart.h:52 > +void updateDesktopStartItem(DesktopStartItem *item, const QString , > const QString , bool disabled, const QString ); > +void

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77739. cblack marked 4 inline comments as done. cblack added a comment. Address feedback REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77733=77739 BRANCH color-reload-module (branched from

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77740. cblack marked 7 inline comments as done. cblack added a comment. Address feedback REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77739=77740 BRANCH color-reload-module (branched from

D27944: KCM Colors fix apply button always disabled

davidedmundson added a comment. Apparently my patch doesn't work, so go ahead. Though I don't fully understand why my patch isn't enough REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27944 To: crossi, #plasma, ervin, bport, meven, broulik Cc:

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack added a comment. In D27160#628387 , @ngraham wrote: > I'm still seeing the binding loop. :( Looks like this is a bug with Plasma's Label component, and not this patch. The Label component the height of the component based off of

D28042: [DrKonqi] Port QRegExp to QRegularExpression

ahmadsamir updated this revision to Diff 77744. ahmadsamir added a comment. Fix comment grammar REPOSITORY R871 DrKonqi CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28042?vs=77606=77744 BRANCH l-QRE-port (branched from master) REVISION DETAIL

D28042: [DrKonqi] Port QRegExp to QRegularExpression

ahmadsamir added a comment. In D28042#628179 , @sitter wrote: > I wouldn't terribly mind a second pair of eyes. > > Code generally looks good to me though, so if nobody else comments feel free to land in a couple days. OK, thanks.

D27160: [applets/mediacontroller] Visually refresh media controller plasmoid

cblack updated this revision to Diff 77763. cblack added a comment. Replace PE.Heading with Kirigami.Heading REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27160?vs=77684=77763 BRANCH media-plasmoid-relayout (branched from master) REVISION

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D28076#628452 , @gikari wrote: > Nice! Does it need to be manually passed to GTK apps when testing D28072 ? GTK needs to be configured to load the GTK module

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 118 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/118/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 18:52:33 + Build duration: 1 min 4 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 70 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/70/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 18:52:33 + Build duration: 1 min 19 sec and counting CONSOLE OUTPUT

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

This revision was automatically updated to reflect the committed changes. Closed by commit R99:306e01d86ab9: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them (authored by cblack). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D28076?vs=77764=77768#toc

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 71 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/71/ Project: kf5-qt5 FreeBSDQt5.13 Date of build: Mon, 16 Mar 2020 18:57:18 + Build duration: 34 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 119 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/119/ Project: kf5-qt5 SUSEQt5.12 Date of build: Mon, 16 Mar 2020 18:57:18 + Build duration: 42 sec and counting CONSOLE OUTPUT [...truncated 457

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

ahmadsamir updated this revision to Diff 77754. ahmadsamir added a comment. Tweak comment REPOSITORY R126 KDE CLI Utilities CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28079?vs=77753=77754 BRANCH l-mainglobpattern (branched from master) REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack updated this revision to Diff 77764. cblack added a comment. Minor formatting improvements REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D28076?vs=77740=77764 BRANCH color-reload-module (branched from master) REVISION DETAIL

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

gikari added a comment. > GTK needs to be configured to load the GTK module `colorreload-gtk-module`. You mean we need to add `gtk-modules=colorreload-gtk-module` to settings.ini? And how to add this module to autoload in Wayland? REPOSITORY R99 KDE Gtk Configuration Tool

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

cblack added a comment. In D28076#628617 , @gikari wrote: > > GTK needs to be configured to load the GTK module `colorreload-gtk-module`. > > You mean we need to add `gtk-modules=colorreload-gtk-module` to settings.ini? And how to add this

D28053: Make the animation slider more granular

pereira.alex added a comment. thank you all for the positive feedback :) I am not a kde dev ( don't have a developer account ). I will try to apply for one, but in the meanwhile, anyone could land this? REPOSITORY R119 Plasma Desktop BRANCH more-granular-animation-speed-slider

D28057: Fix/Allow folderview popup mode icon and list icon size

pereira.alex updated this revision to Diff 77789. pereira.alex added a comment. Removed commented code Removed commented code as requested. Didn't removed the function, there are two connections to the makeIconSize function on line 1064 and 1072. I edited like this, if no problem.

  1   2   >