Re: Problems in KWayland causes by API and ABI compatibility promises

[Aleix Pol]

On Tue, Mar 17, 2020 at 11:27 AM David Edmundson
 wrote:
>
> There's definitely a problem, and I think it's a lot more than just
> discussing location and protocol versions.
>
> My typical workflow is reading the wayland protocol in detail, and
> kwayland is in that awkward position where I absolutely still need to
> read those underlying docs and the abstraction kwayland provides
> frankly only doubles my workload.
>
> Taking a step backwards, there's a lot of parts of kwayland that are
> very inconsistent.
>
> It looks like it's been written by 4 different devs all exploring
> different ideas of how things should work...which isn't too surprising
> given that's exactly what happened!
>
> IMHO we're lacking a "what actually is kwayland?"  and an accurate
> definition of what's the added value compared to just using the auto
> generated classes directly.
>
> 
>
> To bootstrap this I've started an initial list of discrete yes/no
> questions to help serve as a starting point of what kwayland's
> direction specifically should be.

I'd say the right question to ask is not what kwayland is but what we
need it to be.
When working on it, I sometimes feel it's about implementing wayland
interfaces so they can easily be adopted by another Qt-based, not
QtWaylandCompositor-based, Wayland compositor.

>  - Is it kwayland's job to abstract different versions of the same protocol?
>
>  - Is it kwayland's job to abstract different protocols that are
> semantically similar?
> (including xdgshellv6 and wm_base)
>
> - Is it kwayland's job to turn an event-driven API into a property-driven API?
> (i.e turning the request set_minimum_size into an API where you can
> query what was last received)
>
>  - Is it kwayland's job to abstract receiving double buffered stuff?
> (i.e the getter above only gets the value once committed)
>
>  - Is it kwayland's job to abstract sending double buffered stuff?
> (i.e implicitly send "wl_output.done() after Output::setSize())
>
>  - Is it kwayland's job to be a multiplexer?
> (i.e updating xdgoutput or plasmawindowmanagement forwards events to
> all listening resources)
> If so should we express this difference in the API or have them as
> methods on the global? Same for the sending to only the focussed
> window?
>
>  - Is it kwayland's job to convert basic types into Qt friendly types?

On all the above, I'd say the answer to all these we should set some
expectations. In the end we should be creating the KWayland that is
most useful for us.

As a rule of thumb, I'd say it doesn't make sense to implement on
KWayland things that won't be used outside of KWin, e.g. D26858.

Aleix

D10042: feat: parse EDID on the backend side

[Daniel Vrátil]

dvratil updated this revision to Diff 77825.
dvratil edited the summary of this revision.
dvratil added a comment.


  - Rebase on current master
  - Move Edid construction to WaylandOutput::edid

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D10042?vs=76459=77825

BRANCH
  arcpatch-D10042

REVISION DETAIL
  https://phabricator.kde.org/D10042

AFFECTED FILES
  CMakeLists.txt
  autotests/testconfigserializer.cpp
  autotests/testkwaylandbackend.cpp
  autotests/testqscreenbackend.cpp
  backends/fake/fake.cpp
  backends/fake/fake.h
  backends/kwayland/waylandbackend.cpp
  backends/kwayland/waylandbackend.h
  backends/kwayland/waylandoutput.cpp
  backends/kwayland/waylandoutput.h
  backends/xrandr/xrandr.cpp
  backends/xrandr/xrandr.h
  interfaces/org.kde.KScreen.Backend.xml
  src/CMakeLists.txt
  src/abstractbackend.cpp
  src/abstractbackend.h
  src/backendlauncher/backenddbuswrapper.cpp
  src/backendlauncher/backenddbuswrapper.h
  src/backendmanager.cpp
  src/configserializer.cpp
  src/configserializer_p.h
  src/doctor/doctor.cpp
  src/edid.cpp
  src/edid.h
  src/edid_p.h
  src/getconfigoperation.cpp
  src/output.cpp
  src/output.h
  src/types.h
  tests/kwayland/waylandconfigreader.cpp

To: dvratil, sebas, #plasma, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D10042: feat: parse EDID on the backend side

[Daniel Vrátil]

dvratil marked an inline comment as done.
dvratil added inline comments.

INLINE COMMENTS

> romangg wrote in waylandbackend.cpp:81
> Let the backend populate the Private here is unusual, or is it not? On the 
> other side it makes sense. Let the consumer only access the public interface 
> and the backend access the private one. I don't know what's the commonly used 
> approach to that in Qt dev. Out of interest you can say? In any case we can 
> leave it like that for now.

I found this to be the simplest solution to avoid exposing some setters/factory 
functions into `Edid'`public interface. It's all internal code, so no risk of 
API/ABI breakages...

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D10042

To: dvratil, sebas, #plasma, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D10042: feat: parse EDID on the backend side

[Daniel Vrátil]

dvratil added a comment.


  Here's kscreen-console output for one of my monitors under Wayland with this 
patch applied:
  
[15:31:16.520] kscreen-console(422251:422251) unknown: Id:  3
[15:31:16.520] kscreen-console(422251:422251) unknown: Name:  "Eizo Nanao 
Corporation DP-7-EV2736W/96211045"
[15:31:16.520] kscreen-console(422251:422251) unknown: Type:  "DisplayPort"
[15:31:16.520] kscreen-console(422251:422251) unknown: Connected:  true
[15:31:16.520] kscreen-console(422251:422251) unknown: Enabled:  true
[15:31:16.520] kscreen-console(422251:422251) unknown: Primary:  true
[15:31:16.520] kscreen-console(422251:422251) unknown: Rotation:  2
[15:31:16.520] kscreen-console(422251:422251) unknown: Pos:  QPoint(0,0)
[15:31:16.520] kscreen-console(422251:422251) unknown: MMSize:  QSize(600, 
340)
[15:31:16.520] kscreen-console(422251:422251) unknown: FollowPreferredMode: 
 false
[15:31:16.520] kscreen-console(422251:422251) unknown: Size:  QSize(-1, -1)
[15:31:16.520] kscreen-console(422251:422251) unknown: Scale:  1
[15:31:16.520] kscreen-console(422251:422251) unknown: Clones:  None
[15:31:16.520] kscreen-console(422251:422251) unknown: Mode:  "0"
[15:31:16.520] kscreen-console(422251:422251) unknown: Preferred Mode:  "0"
[15:31:16.520] kscreen-console(422251:422251) unknown: Preferred modes:  
("0")
[15:31:16.520] kscreen-console(422251:422251) unknown: Modes: 
[15:31:16.520] kscreen-console(422251:422251) unknown:   "0"
"2560x1440@60"   QSize(2560, 1440)   59.951
[15:31:16.520] kscreen-console(422251:422251) unknown:   "1"
"2560x1440@30"   QSize(2560, 1440)   29.935
[15:31:16.520] kscreen-console(422251:422251) unknown:   "10"
"1280x720@60"   QSize(1280, 720)   60
[15:31:16.520] kscreen-console(422251:422251) unknown:   "11"
"1280x720@60"   QSize(1280, 720)   59.94
[15:31:16.520] kscreen-console(422251:422251) unknown:   "12"
"1024x768@60"   QSize(1024, 768)   60.004
[15:31:16.520] kscreen-console(422251:422251) unknown:   "13"
"800x600@60"   QSize(800, 600)   60.317
[15:31:16.521] kscreen-console(422251:422251) unknown:   "14"
"720x480@60"   QSize(720, 480)   60
[15:31:16.521] kscreen-console(422251:422251) unknown:   "15"
"720x480@60"   QSize(720, 480)   60
[15:31:16.521] kscreen-console(422251:422251) unknown:   "16"
"720x480@60"   QSize(720, 480)   59.94
[15:31:16.521] kscreen-console(422251:422251) unknown:   "17"
"720x480@60"   QSize(720, 480)   59.94
[15:31:16.521] kscreen-console(422251:422251) unknown:   "18"
"720x480@60"   QSize(720, 480)   59.94
[15:31:16.521] kscreen-console(422251:422251) unknown:   "19"
"640x480@60"   QSize(640, 480)   60
[15:31:16.521] kscreen-console(422251:422251) unknown:   "2"
"1920x1200@60"   QSize(1920, 1200)   59.885
[15:31:16.521] kscreen-console(422251:422251) unknown:   "20"
"640x480@60"   QSize(640, 480)   59.94
[15:31:16.521] kscreen-console(422251:422251) unknown:   "21"
"640x480@60"   QSize(640, 480)   59.94
[15:31:16.521] kscreen-console(422251:422251) unknown:   "22"
"720x400@70"   QSize(720, 400)   70.082
[15:31:16.521] kscreen-console(422251:422251) unknown:   "3"
"1920x1080@60"   QSize(1920, 1080)   60
[15:31:16.521] kscreen-console(422251:422251) unknown:   "4"
"1920x1080@60"   QSize(1920, 1080)   60
[15:31:16.521] kscreen-console(422251:422251) unknown:   "5"
"1920x1080@60"   QSize(1920, 1080)   59.94
[15:31:16.521] kscreen-console(422251:422251) unknown:   "6"
"1600x1200@60"   QSize(1600, 1200)   60
[15:31:16.521] kscreen-console(422251:422251) unknown:   "7"
"1280x1024@60"   QSize(1280, 1024)   60.02
[15:31:16.521] kscreen-console(422251:422251) unknown:   "8"
"1280x960@60"   QSize(1280, 960)   60
[15:31:16.521] kscreen-console(422251:422251) unknown:   "9"
"1280x720@60"   QSize(1280, 720)   60
[15:31:16.521] kscreen-console(422251:422251) unknown: EDID Info: 
[15:31:16.521] kscreen-console(422251:422251) unknown:  Device ID:  
"xrandr-Eizo Nanao Corporation-DP-7-EV2736W/96211045"
[15:31:16.521] kscreen-console(422251:422251) unknown:  Name:  
"DP-7-EV2736W/96211045"
[15:31:16.521] kscreen-console(422251:422251) unknown:  Vendor:  "Eizo 
Nanao Corporation"
[15:31:16.521] kscreen-console(422251:422251) unknown:  Serial:  ""
[15:31:16.521] kscreen-console(422251:422251) unknown:  EISA ID:  ""
[15:31:16.521] kscreen-console(422251:422251) unknown:  Hash:  
"0aaedf5ca2"
[15:31:16.521] kscreen-console(422251:422251) unknown:  Width:  60
[15:31:16.521] kscreen-console(422251:422251) unknown:  Height:  34
[15:31:16.521] kscreen-console(422251:422251) unknown:  Gamma:  0
[15:31:16.521] kscreen-console(422251:422251) unknown:  Red:  

D28086: Improve CMake handling of GNOME libraries

[Carson Black]

cblack added a comment.


  In D28086#628957 , @gikari wrote:
  
  > It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` 
module? It actually uses it inside already, but with some bugs, that prevents 
from building last patch.
  
  
  It's a lot of CMake code that duplicates what CMake already offers with its 
pkgconf handling. There's no reason to use it when CMake can wrangle that stuff 
for you.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D10042: feat: parse EDID on the backend side

[Daniel Vrátil]

dvratil added a comment.


  Agreed. deviceId is not actually used (it's stored in KDED config files, but 
the value doesn't seem to be used anywhere). I'll fix it in a separate commit 
(since it also needs adjusting a bunch of unit-tests in libkscreen and kscreen).

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D10042

To: dvratil, sebas, #plasma, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28103: introduce PassiveNotification type

[Marco Martin]

mart updated this revision to Diff 77843.
mart added a comment.


  - export the item

REPOSITORY
  R169 Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28103?vs=77842=77843

BRANCH
  mart/passivenotification

REVISION DETAIL
  https://phabricator.kde.org/D28103

AFFECTED FILES
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/PassiveNotification.qml
  src/controls/templates/PassiveNotification.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/qmldir
  src/kirigamiplugin.cpp
  src/qmldir

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 626 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/626/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 17 Mar 2020 15:05:25 +
 Build duration:
1 hr 0 min and counting
   JUnit Tests
  Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 test(s)Name: projectroot Failed: 0 test(s), Passed: 19 test(s), Skipped: 0 test(s), Total: 19 test(s)Name: projectroot.autotests Failed: 0 test(s), Passed: 108 test(s), Skipped: 0 test(s), Total: 108 test(s)Name: projectroot.autotests.integration Failed: 0 test(s), Passed: 20 test(s), Skipped: 0 test(s), Total: 20 test(s)
   Cobertura Report
  
   Project Coverage Summary
  
   Name
  PackagesFilesClassesLinesConditionalsCobertura Coverage Report70%
(59/84)57%
(322/561)57%
(322/561)43%
(31612/74227)32%
(14343/44360)Coverage Breakdown by Package
Name
   FilesClassesLinesConditionalsdefault86%
(130/151)86%
(130/151)65%
(19565/29946)51%
(9995/19686)colorcorrection100%
(7/7)100%
(7/7)79%
(672/855)59%
(238/401)data0%
(0/1)0%
(0/1)0%
(0/30)0%
(0/8)decorations100%
(10/10)100%
(10/10)79%
(443/562)65%
(140/216)effects100%
(2/2)100%
(2/2)99%
(156/158)86%
(24/28)effects.backgroundcontrast25%
(1/4)25%
(1/4)4%
(14/379)4%
(12/292)effects.blur20%
(1/5)20%
(1/5)2%
(14/693)3%
(13/405)effects.colorpicker100%
(2/2)100%
(2/2)19%
(12/62)8%
(2/24)effects.coverswitch33%
(1/3)33%
(1/3)0%
(2/657)1%
(4/530)effects.cube25%
(1/4)25%
(1/4)0%
(2/1291)0%
(0/1015)effects.cubeslide67%
(2/3)67%
(2/3)33%
(158/480)19%
(72/374)effects.desktopgrid67%
(2/3)67%
(2/3)8%
(79/970)3%
(29/894)effects.diminactive33%
(1/3)33%
(1/3)13%
(30/233)2%
(3/158)effects.fallapart100%
(2/2)100%
(2/2)34%
(38/111)26%
(17/66)effects.flipswitch33%
(1/3)33%
(1/3)7%
(46/657)1%
(5/552)effects.glide67%
(2/3)67%
(2/3)72%
(150/208)65%
(60/93)effects.highlightwindow100%
(2/2)100%
(2/2)40%

D28103: introduce PassiveNotification type

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> PassiveNotification.qml:18
> +notifications in the app.
> + * used to show messages of limited importance that make sense only when
> + * the user is using the application and wouldn't be suited as a global 

`messages of limited importance` -> maybe something a bit more explicit like 
`transient, ignorable status messages of limited importance`

> PassiveNotification.qml:21
> + * system-wide notification.
> + * This is not a full-fledged notification system. the applciation should 
> + * use this with care and only one notification should be visible at once 
> per app.

`the applciation` -> `The application`

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 625 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/625/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 17 Mar 2020 14:53:06 +
 Build duration:
12 min and counting
   CONSOLE OUTPUT
  [...truncated 3079 lines...][2020-03-17T15:05:12.083Z] In file included from /usr/include/qt5/QtCore/qdebug.h:49,[2020-03-17T15:05:12.083Z]  from /usr/include/qt5/QtCore/qloggingcategory.h:44,[2020-03-17T15:05:12.083Z]  from /usr/include/qt5/QtCore/QLoggingCategory:1,[2020-03-17T15:05:12.083Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/utils.h:31,[2020-03-17T15:05:12.083Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/abstract_wayland_output.h:24,[2020-03-17T15:05:12.083Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_output.h:23,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:21:[2020-03-17T15:05:12.084Z] /usr/include/qt5/QtCore/qtextstream.h:260:28: note:   ���endl���[2020-03-17T15:05:12.084Z]   260 | Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T15:05:12.084Z]   |^~~~[2020-03-17T15:05:12.084Z] In file included from /usr/include/c++/9/iterator:64,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/qbytearray.h:53,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/qstring.h:49,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/qcoreapplication.h:44,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/QCoreApplication:1,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwinglobals.h:24,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/platform.h:23,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.h:22,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:20:[2020-03-17T15:05:12.084Z] /usr/include/c++/9/ostream:599:5: note:   ���std::endl���[2020-03-17T15:05:12.084Z]   599 | endl(basic_ostream<_CharT, _Traits>& __os)[2020-03-17T15:05:12.084Z]   | ^~~~[2020-03-17T15:05:12.084Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:786:64: error: ���endl��� is not a member of ���Qt���[2020-03-17T15:05:12.084Z]   786 | s << "Atomic Mode Setting: " << m_atomicModeSetting << Qt::endl;[2020-03-17T15:05:12.084Z]   |^~~~[2020-03-17T15:05:12.084Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:786:64: note: suggested alternatives:[2020-03-17T15:05:12.084Z] In file included from /usr/include/qt5/QtCore/qdebug.h:49,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/qloggingcategory.h:44,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/QLoggingCategory:1,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/utils.h:31,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/abstract_wayland_output.h:24,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_output.h:23,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:21:[2020-03-17T15:05:12.084Z] /usr/include/qt5/QtCore/qtextstream.h:260:28: note:   ���endl���[2020-03-17T15:05:12.084Z]   260 | Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T15:05:12.084Z]   |^~~~[2020-03-17T15:05:12.084Z] In file included from /usr/include/c++/9/iterator:64,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/qbytearray.h:53,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/qstring.h:49,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/qcoreapplication.h:44,[2020-03-17T15:05:12.084Z]  from /usr/include/qt5/QtCore/QCoreApplication:1,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwinglobals.h:24,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/platform.h:23,[2020-03-17T15:05:12.084Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.h:22,[2020-03-17T15:05:12.084Z]  from 

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack added a comment.


  In D27959#629133 , @broulik wrote:
  
  > I think you should cache the X props, otherwise every `data` access causes 
a round trip to the X server.
  
  
  Implemented a cache for appmenus, but as I don't know what to listen to for 
appmenu updates, I haven't implemented cache invalidation.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28081: Populate Greeter process exit stderr

[Roman Gilg]

romangg added a comment.


  In D28081#628985 , @davidedmundson 
wrote:
  
  > Can we use categorised logging please.
  
  
  Yea, but I haven't seen any categorized logging in KScreenLocker so I opted 
for now with non-categorized logging as the rest of the code does. The category 
logging should be introduced for sure in another patch though (and then all 
debug messages converted to categorized logging at once).
  
  > But general +1

REPOSITORY
  R133 KScreenLocker

BRANCH
  debug

REVISION DETAIL
  https://phabricator.kde.org/D28081

To: romangg, #plasma, apol
Cc: davidedmundson, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Kai Uwe Broulik]

broulik added a comment.


  I think if you added those properties `KWindowInfo`, you'd get change events, 
cache eviction, less manual X code basically for free :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28098: remove pointless and arbitrary 4 line frame limit

[Ben Cooksley]

bcooksley requested changes to this revision.
bcooksley added a comment.
This revision now requires changes to proceed.


  There should be no further changes to Dr Konqi at this time as it fails to 
build from source on both FreeBSD and Windows.
  Please see the relevant CI jobs for more information - 
https://build.kde.org/view/Failing/job/Plasma/job/drkonqi/

REPOSITORY
  R871 DrKonqi

REVISION DETAIL
  https://phabricator.kde.org/D28098

To: sitter, apol, bcooksley
Cc: bcooksley, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 622 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/622/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 17 Mar 2020 14:37:31 +
 Build duration:
6 min 53 sec and counting
   CONSOLE OUTPUT
  [...truncated 2890 lines...][2020-03-17T14:44:08.247Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/gestures.cpp.o[2020-03-17T14:44:08.247Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/globalshortcuts.cpp.o[2020-03-17T14:44:08.505Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/group.cpp.o[2020-03-17T14:44:08.763Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/idle_inhibition.cpp.o[2020-03-17T14:44:08.763Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/input.cpp.o[2020-03-17T14:44:09.021Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/input_event.cpp.o[2020-03-17T14:44:09.279Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/input_event_spy.cpp.o[2020-03-17T14:44:09.279Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/internal_client.cpp.o[2020-03-17T14:44:09.537Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/keyboard_input.cpp.o[2020-03-17T14:44:09.537Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/keyboard_layout.cpp.o[2020-03-17T14:44:10.106Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/keyboard_layout_switching.cpp.o[2020-03-17T14:44:10.106Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/keyboard_repeat.cpp.o[2020-03-17T14:44:10.106Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/killwindow.cpp.o[2020-03-17T14:44:10.365Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/layers.cpp.o[2020-03-17T14:44:10.365Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/libinput/connection.cpp.o[2020-03-17T14:44:10.621Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/libinput/context.cpp.o[2020-03-17T14:44:10.880Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/libinput/device.cpp.o[2020-03-17T14:44:11.139Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/libinput/events.cpp.o[2020-03-17T14:44:11.397Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/libinput/libinput_logging.cpp.o[2020-03-17T14:44:11.397Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/linux_dmabuf.cpp.o[2020-03-17T14:44:11.656Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/logind.cpp.o[2020-03-17T14:44:11.913Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/main.cpp.o[2020-03-17T14:44:11.913Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/modifier_only_shortcuts.cpp.o[2020-03-17T14:44:11.913Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/moving_client_x11_filter.cpp.o[2020-03-17T14:44:12.170Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/netinfo.cpp.o[2020-03-17T14:44:12.170Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/onscreennotification.cpp.o[2020-03-17T14:44:12.429Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/options.cpp.o[2020-03-17T14:44:12.429Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/osd.cpp.o[2020-03-17T14:44:12.688Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/outline.cpp.o[2020-03-17T14:44:12.948Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/outputscreens.cpp.o[2020-03-17T14:44:12.948Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/overlaywindow.cpp.o[2020-03-17T14:44:13.208Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/placement.cpp.o[2020-03-17T14:44:13.208Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/platform.cpp.o[2020-03-17T14:44:13.208Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/pointer_input.cpp.o[2020-03-17T14:44:13.208Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/popup_input_filter.cpp.o[2020-03-17T14:44:13.776Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/rootinfo_filter.cpp.o[2020-03-17T14:44:13.776Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/rules.cpp.o[2020-03-17T14:44:14.035Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/rulebooksettings.cpp.o[2020-03-17T14:44:14.035Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/scene.cpp.o[2020-03-17T14:44:14.035Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/screenedge.cpp.o[2020-03-17T14:44:14.035Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/screenlockerwatcher.cpp.o[2020-03-17T14:44:14.293Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/screens.cpp.o[2020-03-17T14:44:14.553Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/scripting/dbuscall.cpp.o[2020-03-17T14:44:14.812Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/scripting/meta.cpp.o[2020-03-17T14:44:14.812Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/scripting/screenedgeitem.cpp.o[2020-03-17T14:44:15.071Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/scripting/scriptedeffect.cpp.o[2020-03-17T14:44:15.331Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting.cpp.o[2020-03-17T14:44:15.331Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting_logging.cpp.o[2020-03-17T14:44:15.331Z] [ 64%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting_model.cpp.o[2020-03-17T14:44:16.267Z] [ 64%] Building CXX object 

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 466 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/466/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 14:52:12 +
 Build duration:
2 min 38 sec and counting
   CONSOLE OUTPUT
  [...truncated 3233 lines...][2020-03-17T14:54:45.224Z] [ 71%] Built target KWinQpaPlugin[2020-03-17T14:54:45.224Z] [ 71%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/edge.cpp.o[2020-03-17T14:54:45.224Z] [ 71%] Building CXX object autotests/integration/CMakeFiles/KWinIntegrationTestFramework.dir/__/__/xwl/selection_source.cpp.o[2020-03-17T14:54:45.224Z] [ 71%] Building CXX object autotests/integration/CMakeFiles/KWinIntegrationTestFramework.dir/__/__/xwl/transfer.cpp.o[2020-03-17T14:54:45.792Z] [ 71%] Building CXX object autotests/integration/CMakeFiles/KWinIntegrationTestFramework.dir/__/__/xwl/xwayland.cpp.o[2020-03-17T14:54:46.051Z] [ 71%] Linking CXX executable bin/kwin_wayland[2020-03-17T14:54:46.051Z] [ 71%] Built target kwin_wayland[2020-03-17T14:54:46.051Z] [ 71%] Building CXX object plugins/platforms/x11/windowed/CMakeFiles/KWinWaylandX11Backend.dir/logging.cpp.o[2020-03-17T14:54:46.309Z] [ 71%] Building CXX object autotests/integration/CMakeFiles/KWinIntegrationTestFramework.dir/__/__/xwayland_logging.cpp.o[2020-03-17T14:54:46.310Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/xwl/drag_x.cpp:510:39: warning: suggest braces around initialization of subobject [-Wmissing-braces][2020-03-17T14:54:46.310Z] xcb_client_message_data_t data = "">[2020-03-17T14:54:46.310Z]   ^[2020-03-17T14:54:46.310Z]   {}[2020-03-17T14:54:46.310Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/xwl/drag_x.cpp:520:39: warning: suggest braces around initialization of subobject [-Wmissing-braces][2020-03-17T14:54:46.310Z] xcb_client_message_data_t data = "">[2020-03-17T14:54:46.310Z]   ^[2020-03-17T14:54:46.310Z]   {}[2020-03-17T14:54:46.569Z] [ 72%] Building CXX object plugins/platforms/x11/windowed/CMakeFiles/KWinWaylandX11Backend.dir/scene_qpainter_x11_backend.cpp.o[2020-03-17T14:54:46.569Z] [ 72%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/effects_mouse_interception_x11_filter.cpp.o[2020-03-17T14:54:46.569Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/xwl/drag_wl.cpp:232:39: warning: suggest braces around initialization of subobject [-Wmissing-braces][2020-03-17T14:54:46.569Z] xcb_client_message_data_t data = "">[2020-03-17T14:54:46.569Z]   ^[2020-03-17T14:54:46.569Z]   {}[2020-03-17T14:54:46.569Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/xwl/drag_wl.cpp:287:39: warning: suggest braces around initialization of subobject [-Wmissing-braces][2020-03-17T14:54:46.569Z] xcb_client_message_data_t data = "">[2020-03-17T14:54:46.569Z]   ^[2020-03-17T14:54:46.569Z]   {}[2020-03-17T14:54:46.569Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/xwl/drag_wl.cpp:342:39: warning: suggest braces around initialization of subobject [-Wmissing-braces][2020-03-17T14:54:46.569Z] xcb_client_message_data_t data = "">[2020-03-17T14:54:46.569Z]   ^[2020-03-17T14:54:46.569Z]   {}[2020-03-17T14:54:46.569Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/xwl/drag_wl.cpp:355:39: warning: suggest braces around initialization of subobject [-Wmissing-braces][2020-03-17T14:54:46.569Z] xcb_client_message_data_t data = "">[2020-03-17T14:54:46.569Z]   ^[2020-03-17T14:54:46.569Z]   {}[2020-03-17T14:54:46.569Z] [ 72%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/effects_x11.cpp.o[2020-03-17T14:54:46.569Z] [ 72%] Building CXX object plugins/platforms/x11/windowed/CMakeFiles/KWinWaylandX11Backend.dir/x11windowed_backend.cpp.o[2020-03-17T14:54:46.828Z] [ 72%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/logging.cpp.o[2020-03-17T14:54:46.828Z] [ 72%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/non_composited_outline.cpp.o[2020-03-17T14:54:47.089Z] 4 warnings generated.[2020-03-17T14:54:47.089Z] [ 72%] Building CXX object plugins/platforms/x11/windowed/CMakeFiles/KWinWaylandX11Backend.dir/x11windowed_output.cpp.o[2020-03-17T14:54:47.089Z] [ 72%] Building CXX object plugins/platforms/x11/standalone/CMakeFiles/KWinX11Platform.dir/overlaywindow_x11.cpp.o[2020-03-17T14:54:47.089Z] [ 72%] Building CXX object 

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack updated this revision to Diff 77834.
cblack marked 5 inline comments as done.
cblack added a comment.


  Address feedback

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27959?vs=77681=77834

BRANCH
  cblack/appmenu-libtaskmanager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27959

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27675: feat: avoid duplicated text when assembling user-facing output names

[Daniel Vrátil]

dvratil updated this revision to Diff 77838.
dvratil added a comment.


  - Simplify a bit more

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27675?vs=77837=77838

BRANCH
  arcpatch-D27675

REVISION DETAIL
  https://phabricator.kde.org/D27675

AFFECTED FILES
  common/utils.cpp

To: dvratil, #plasma, romangg
Cc: ahmadsamir, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28103: introduce PassiveNotification type

[Marco Martin]

mart created this revision.
mart added a reviewer: Kirigami.
Herald added a project: Kirigami.
Herald added a subscriber: plasma-devel.
mart requested review of this revision.

REVISION SUMMARY
  PassiveNotification is a type for small, passive and inline
  notifications in the app.
  used to show messages of limited importance that make sense only when
  the user is using the application and wouldn't be suited as a global
  system-wide notification.
  This is not a full-fledged notification system. the applciation should
  use this with care and only one notification should be visible at once
  per app.

TEST PLAN
  it looks and behaves the same as ApplicationWindow.showPassiveNotification 
  (which now uses it) as well standalone notification items work.

REPOSITORY
  R169 Kirigami

BRANCH
  mart/passivenotification

REVISION DETAIL
  https://phabricator.kde.org/D28103

AFFECTED FILES
  src/controls/AbstractApplicationItem.qml
  src/controls/AbstractApplicationWindow.qml
  src/controls/PassiveNotification.qml
  src/controls/templates/PassiveNotification.qml
  src/controls/templates/private/PassiveNotification.qml
  src/controls/templates/qmldir

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

D28103: introduce PassiveNotification type

[Marco Martin]

mart added a comment.


  In D28103#629313 , @ngraham wrote:
  
  > Didn't this already exist in Kirigami, or am I imagining that?
  
  
  there is ApplicationWindow.showPassiveNotification.
  it was only accessible by that (and not accessible by kcms) this makes it an 
instatiable component
  
  look and features stay the same

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28090: [applet] Fix button bar right margin

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R97:3c2175fe8e04: [applet] Fix button bar right margin 
(authored by ngraham).

REPOSITORY
  R97 Bluedevil

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28090?vs=77798=77845

REVISION DETAIL
  https://phabricator.kde.org/D28090

AFFECTED FILES
  src/applet/package/contents/ui/Toolbar.qml

To: ngraham, #vdg, #plasma, drosca, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 623 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/623/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 17 Mar 2020 14:44:26 +
 Build duration:
5 min 51 sec and counting
   CONSOLE OUTPUT
  [...truncated 3114 lines...][2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/qloggingcategory.h:44,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/QLoggingCategory:1,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/utils.h:31,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/abstract_wayland_output.h:24,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_output.h:23,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:21:[2020-03-17T14:50:12.198Z] /usr/include/qt5/QtCore/qtextstream.h:260:28: note:   ���endl���[2020-03-17T14:50:12.198Z]   260 | Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T14:50:12.198Z]   |^~~~[2020-03-17T14:50:12.198Z] In file included from /usr/include/c++/9/iterator:64,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/qbytearray.h:53,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/qstring.h:49,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/qcoreapplication.h:44,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/QCoreApplication:1,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwinglobals.h:24,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/platform.h:23,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.h:22,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:20:[2020-03-17T14:50:12.198Z] /usr/include/c++/9/ostream:599:5: note:   ���std::endl���[2020-03-17T14:50:12.198Z]   599 | endl(basic_ostream<_CharT, _Traits>& __os)[2020-03-17T14:50:12.198Z]   | ^~~~[2020-03-17T14:50:12.198Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:786:64: error: ���endl��� is not a member of ���Qt���[2020-03-17T14:50:12.198Z]   786 | s << "Atomic Mode Setting: " << m_atomicModeSetting << Qt::endl;[2020-03-17T14:50:12.198Z]   |^~~~[2020-03-17T14:50:12.198Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:786:64: note: suggested alternatives:[2020-03-17T14:50:12.198Z] In file included from /usr/include/qt5/QtCore/qdebug.h:49,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/qloggingcategory.h:44,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/QLoggingCategory:1,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/utils.h:31,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/abstract_wayland_output.h:24,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_output.h:23,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.cpp:21:[2020-03-17T14:50:12.198Z] /usr/include/qt5/QtCore/qtextstream.h:260:28: note:   ���endl���[2020-03-17T14:50:12.198Z]   260 | Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T14:50:12.198Z]   |^~~~[2020-03-17T14:50:12.198Z] In file included from /usr/include/c++/9/iterator:64,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/qbytearray.h:53,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/qstring.h:49,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/qcoreapplication.h:44,[2020-03-17T14:50:12.198Z]  from /usr/include/qt5/QtCore/QCoreApplication:1,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwinglobals.h:24,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/platform.h:23,[2020-03-17T14:50:12.198Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/drm/drm_backend.h:22,[2020-03-17T14:50:12.199Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari accepted this revision.
gikari added a comment.
This revision is now accepted and ready to land.


  Fine.  It builds.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28099: Show command output on unknown failure

[Ivan Čukić]

This revision was automatically updated to reflect the committed changes.
Closed by commit R845:1e2988d7d3ca: Show command output on unknown failure 
(authored by ivan).

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28099?vs=77828=77836

REVISION DETAIL
  https://phabricator.kde.org/D28099

AFFECTED FILES
  .gitignore
  kded/engine/backends/cryfs/cryfsbackend.cpp
  kded/engine/commandresult.cpp
  kded/engine/commandresult.h
  kded/engine/fusebackend_p.cpp
  kded/ui/mountdialog.cpp
  kded/ui/mountdialog.h

To: ivan, #plasma, davidedmundson, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27675: feat: avoid duplicated text when assembling user-facing output names

[Daniel Vrátil]

dvratil updated this revision to Diff 77837.
dvratil added a comment.


  - Make the lambda more explicit
  - Address review comments

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27675?vs=76457=77837

BRANCH
  arcpatch-D27675

REVISION DETAIL
  https://phabricator.kde.org/D27675

AFFECTED FILES
  common/utils.cpp

To: dvratil, #plasma, romangg
Cc: ahmadsamir, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Nathaniel Graham]

ngraham added a comment.


  Making a second slider is fine, but it's not actually necessary. Instead, you 
could make `cfg_iconSize` and `cfg_listViewIconSize` not be aliases, and 
instead bind the single slider's value to whichever one is appropriate, like so:
  
value: viewMode.currentIndex === 1 ? cfg_iconSize : cfg_listViewIconSize

INLINE COMMENTS

> main.xml:102
>  
>The icon size to use for Folder View icons. One of the list of 
> Plasma icon sizes.
>4

This label needs updating now, to differentiate it from `listViewIconSize`

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28086: Improve CMake handling of GNOME libraries

[Carson Black]

cblack updated this revision to Diff 77831.
cblack added a comment.


  Rebase on master for reverted commits

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28086?vs=77790=77831

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 465 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/465/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 14:44:36 +
 Build duration:
2 min 30 sec and counting
   CONSOLE OUTPUT
  [...truncated 3114 lines...][2020-03-17T14:47:02.295Z]   endl[2020-03-17T14:47:02.295Z] /usr/local/include/qt5/QtCore/qtextstream.h:260:28: note: 'endl' declared here[2020-03-17T14:47:02.295Z] Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T14:47:02.295Z]^[2020-03-17T14:47:02.295Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/plugins/platforms/drm/drm_backend.cpp:785:36: error: no member named 'endl' in namespace 'Qt'; did you mean simply 'endl'?[2020-03-17T14:47:02.295Z] s << "Active: " << m_active << Qt::endl;[2020-03-17T14:47:02.295Z]^~~~[2020-03-17T14:47:02.295Z]endl[2020-03-17T14:47:02.295Z] /usr/local/include/qt5/QtCore/qtextstream.h:260:28: note: 'endl' declared here[2020-03-17T14:47:02.295Z] Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T14:47:02.295Z]^[2020-03-17T14:47:02.295Z] [ 69%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/main.cpp.o[2020-03-17T14:47:02.295Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/plugins/platforms/drm/drm_backend.cpp:786:60: error: no member named 'endl' in namespace 'Qt'; did you mean simply 'endl'?[2020-03-17T14:47:02.295Z] s << "Atomic Mode Setting: " << m_atomicModeSetting << Qt::endl;[2020-03-17T14:47:02.295Z]^~~~[2020-03-17T14:47:02.295Z]endl[2020-03-17T14:47:02.295Z] /usr/local/include/qt5/QtCore/qtextstream.h:260:28: note: 'endl' declared here[2020-03-17T14:47:02.295Z] Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T14:47:02.295Z]^[2020-03-17T14:47:02.295Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/plugins/platforms/drm/drm_backend.cpp:788:54: error: no member named 'endl' in namespace 'Qt'; did you mean simply 'endl'?[2020-03-17T14:47:02.295Z] s << "Using EGL Streams: " << m_useEglStreams << Qt::endl;[2020-03-17T14:47:02.295Z]  ^~~~[2020-03-17T14:47:02.295Z]  endl[2020-03-17T14:47:02.295Z] /usr/local/include/qt5/QtCore/qtextstream.h:260:28: note: 'endl' declared here[2020-03-17T14:47:02.295Z] Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T14:47:02.295Z]^[2020-03-17T14:47:02.554Z] 4 errors generated.[2020-03-17T14:47:02.554Z] gmake[2]: *** [plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/build.make:76: plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/drm_backend.cpp.o] Error 1[2020-03-17T14:47:02.554Z] gmake[2]: *** Waiting for unfinished jobs[2020-03-17T14:47:02.554Z] [ 69%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/offscreensurface.cpp.o[2020-03-17T14:47:02.554Z] [ 69%] Linking CXX executable bin/kwin_x11[2020-03-17T14:47:02.554Z] gmake[1]: *** [CMakeFiles/Makefile2:6300: plugins/platforms/drm/CMakeFiles/KWinWaylandDrmBackend.dir/all] Error 2[2020-03-17T14:47:02.554Z] gmake[1]: *** Waiting for unfinished jobs[2020-03-17T14:47:02.554Z] [ 69%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/platformcursor.cpp.o[2020-03-17T14:47:02.554Z] [ 69%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/screen.cpp.o[2020-03-17T14:47:02.554Z] [ 69%] Built target kwin_x11[2020-03-17T14:47:02.554Z] [ 69%] Building CXX object plugins/platforms/wayland/CMakeFiles/KWinWaylandWaylandBackend.dir/scene_qpainter_wayland_backend.cpp.o[2020-03-17T14:47:02.813Z] [ 69%] Building CXX object CMakeFiles/kwin_wayland.dir/xwl/databridge.cpp.o[2020-03-17T14:47:03.071Z] [ 69%] Building CXX object CMakeFiles/kwin_wayland.dir/xwl/dnd.cpp.o[2020-03-17T14:47:03.071Z] [ 69%] Linking CXX shared module ../../bin/kf5/org.kde.kwindowsystem.platforms/KF5WindowSystemKWinPrivatePlugin.so[2020-03-17T14:47:03.071Z] [ 69%] Building CXX object plugins/platforms/virtual/CMakeFiles/KWinWaylandVirtualBackend.dir/virtual_backend.cpp.o[2020-03-17T14:47:03.071Z] [ 69%] Built target KF5WindowSystemKWinPrivatePlugin[2020-03-17T14:47:03.331Z] [ 69%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/sharingplatformcontext.cpp.o[2020-03-17T14:47:03.331Z] [ 69%] Building CXX object plugins/platforms/virtual/CMakeFiles/KWinWaylandVirtualBackend.dir/virtual_output.cpp.o[2020-03-17T14:47:03.590Z] [ 69%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/window.cpp.o[2020-03-17T14:47:03.590Z] [ 69%] Building CXX object plugins/qpa/CMakeFiles/KWinQpaPlugin.dir/logging.cpp.o[2020-03-17T14:47:03.867Z] [ 69%] 

D27675: feat: avoid duplicated text when assembling user-facing output names

[Roman Gilg]

romangg added a comment.


  In D27675#629182 , @dvratil wrote:
  
  > As you described, the system makes sense on X11 where you get something 
like `HDMI-1 (Sony GigaTV-12345)` so you see which device it is and what 
physical output it's connected to. Since KWin does not use to output names but 
only the names of the actually connected devices, the needed behavior is 
different.
  >
  > I don't know if it's safe/feasible to change this on KWin side or not.
  
  
  Allright, let's go with your solution now and if somebody thinks it can be 
improved on KWin side it can be revisited later.
  
  Please handle the nitpicks I raised. When you are at it also add two to three 
comments to the lambda making it clearer what it does in each line and why. 
Thanks!

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D27675

To: dvratil, #plasma, romangg
Cc: ahmadsamir, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 467 - Still unstable!

[CI System]

BUILD UNSTABLE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/467/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 14:57:35 +
 Build duration:
20 min and counting
   JUnit Tests
  Name: projectroot Failed: 1 test(s), Passed: 18 test(s), Skipped: 0 test(s), Total: 19 test(s)Failed: projectroot.autotests.kwin_testClientMachineName: projectroot.autotests Failed: 12 test(s), Passed: 96 test(s), Skipped: 0 test(s), Total: 108 test(s)Failed: projectroot.autotests.integration.kwin_testDbusInterfaceFailed: projectroot.autotests.integration.kwin_testDecorationInputFailed: projectroot.autotests.integration.kwin_testDecorationInput_waylandonlyFailed: projectroot.autotests.integration.kwin_testDontCrashAuroraeDestroyDecoFailed: projectroot.autotests.integration.kwin_testLockScreenFailed: projectroot.autotests.integration.kwin_testPlasmaWindowFailed: projectroot.autotests.integration.kwin_testSceneQPainterFailed: projectroot.autotests.integration.kwin_testScreenEdgeClientShowFailed: projectroot.autotests.integration.kwin_testWindowRulesFailed: projectroot.autotests.integration.kwin_testXdgShellClientFailed: projectroot.autotests.integration.kwin_testXdgShellClient_waylandonlyFailed: projectroot.autotests.integration.kwin_testXwaylandInputName: projectroot.autotests.integration Failed: 7 test(s), Passed: 13 test(s), Skipped: 0 test(s), Total: 20 test(s)Failed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimationFailed: projectroot.autotests.integration.effects.kwin_testMinimizeAnimation_waylandonlyFailed: projectroot.autotests.integration.effects.kwin_testShadeWobblyWindowsFailed: projectroot.autotests.integration.effects.kwin_testSlidingPopupsFailed: projectroot.autotests.integration.effects.kwin_testTranslucencyFailed: projectroot.autotests.integration.scripting.kwin_testMinimizeAllScriptFailed: projectroot.autotests.integration.scripting.kwin_testMinimizeAllScript_waylandonly

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Carson Black]

cblack updated this revision to Diff 77835.
cblack added a comment.


  Don't double lookup cached appmenus

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27959?vs=77834=77835

BRANCH
  cblack/appmenu-libtaskmanager (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27959

AFFECTED FILES
  libtaskmanager/CMakeLists.txt
  libtaskmanager/abstracttasksmodel.h
  libtaskmanager/waylandtasksmodel.cpp
  libtaskmanager/xwindowtasksmodel.cpp

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28103: introduce PassiveNotification type

[Nathaniel Graham]

ngraham added a comment.


  Didn't this already exist in Kirigami, or am I imagining that?

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: ngraham, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, apol, 
ahiemstra, davidedmundson, mart

D28103: introduce PassiveNotification type

[Marco Martin]

mart added a comment.


  One thing I'm not sure of is whether going this way, with one popup that 
shows only one notification or having a popup with a listview that can show 
multiple notifications at once...
  tough for me an important thing is that this thing does *-NOT* become a full 
fledged notification system

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28103

To: mart, #kirigami
Cc: plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, apol, 
ahiemstra, davidedmundson, mart

[Breeze] [Bug 418949] plymouth-theme-breeze should have a background/wallpaper option

[Nate Graham]

https://bugs.kde.org/show_bug.cgi?id=418949

Nate Graham  changed:

   What|Removed |Added

 Ever confirmed|0   |1
 Status|REPORTED|CONFIRMED
 CC||n...@kde.org

-- 
You are receiving this mail because:
You are the assignee for the bug.

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 621 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/621/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 17 Mar 2020 14:32:56 +
 Build duration:
1 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 1636 lines...][2020-03-17T14:33:55.111Z] [  9%] Built target doc-windowbehaviour-index-cache-bz2[2020-03-17T14:33:55.111Z] Scanning dependencies of target kwincompositing[2020-03-17T14:33:55.111Z] [  9%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwincompositing_autogen/mocs_compilation.cpp.o[2020-03-17T14:33:55.111Z] [  9%] Generating ui_focus.h[2020-03-17T14:33:55.111Z] [  9%] Generating ui_mouse.h[2020-03-17T14:33:55.111Z] Scanning dependencies of target kdecorationprivatedeclarative[2020-03-17T14:33:55.111Z] Scanning dependencies of target kcm_kwindecoration[2020-03-17T14:33:55.111Z] [  9%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/kdecorationprivatedeclarative_autogen/mocs_compilation.cpp.o[2020-03-17T14:33:55.111Z] [  9%] Building CXX object kcmkwin/kwindecoration/CMakeFiles/kcm_kwindecoration.dir/kcm_kwindecoration_autogen/mocs_compilation.cpp.o[2020-03-17T14:33:55.111Z] [ 10%] Generating ui_moving.h[2020-03-17T14:33:55.111Z] [ 10%] Generating kwinoptions_settings.h, kwinoptions_settings.cpp[2020-03-17T14:33:55.111Z] [ 10%] Generating kwinoptions_settings.moc[2020-03-17T14:33:55.371Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/build/kcmkwin/kwinoptions/kwinoptions_settings.h:0: Note: No relevant classes found. No output generated.[2020-03-17T14:33:55.371Z] [ 10%] Generating kwin_effects_interface.moc[2020-03-17T14:33:55.371Z] Scanning dependencies of target kcm_kwinoptions[2020-03-17T14:33:55.371Z] [ 10%] Building CXX object kcmkwin/kwinoptions/CMakeFiles/kcm_kwinoptions.dir/kcm_kwinoptions_autogen/mocs_compilation.cpp.o[2020-03-17T14:33:55.371Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwinglplatform.cpp: In member function ���void KWin::GLPlatform::detect(KWin::OpenGLPlatformInterface)���:[2020-03-17T14:33:55.371Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwinglplatform.cpp:691:79: error: no match for ���operator=��� (operand types are ���QSet��� and ��)[2020-03-17T14:33:55.371Z]   691 | m_extensions = {extensionsList.constBegin(), extensionsList.constEnd()};[2020-03-17T14:33:55.371Z]   |   ^[2020-03-17T14:33:55.371Z] In file included from /usr/include/qt5/QtCore/QSet:1,[2020-03-17T14:33:55.371Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwinglplatform.h:28,[2020-03-17T14:33:55.371Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwinglplatform.cpp:21:[2020-03-17T14:33:55.371Z] /usr/include/qt5/QtCore/qset.h:54:7: note: candidate: ���QSet& QSet::operator=(const QSet&)���[2020-03-17T14:33:55.371Z]54 | class QSet[2020-03-17T14:33:55.371Z]   |   ^~~~[2020-03-17T14:33:55.371Z] /usr/include/qt5/QtCore/qset.h:54:7: note:   no known conversion for argument 1 from �� to ���const QSet&���[2020-03-17T14:33:55.371Z] /usr/include/qt5/QtCore/qset.h:54:7: note: candidate: ���QSet& QSet::operator=(QSet&&)���[2020-03-17T14:33:55.371Z] /usr/include/qt5/QtCore/qset.h:54:7: note:   no known conversion for argument 1 from �� to ���QSet&&���[2020-03-17T14:33:55.631Z] make[2]: *** [libkwineffects/CMakeFiles/kwinglutils.dir/build.make:76: libkwineffects/CMakeFiles/kwinglutils.dir/kwinglplatform.cpp.o] Error 1[2020-03-17T14:33:55.631Z] make[2]: *** Waiting for unfinished jobs[2020-03-17T14:33:55.631Z] [ 10%] Building CXX object kcmkwin/kwinoptions/CMakeFiles/kcm_kwinoptions.dir/__/__/effects/effect_builtins.cpp.o[2020-03-17T14:33:55.631Z] [ 10%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/main.cpp.o[2020-03-17T14:33:55.631Z] [ 10%] Built target doc-windowspecific-index-cache-bz2[2020-03-17T14:33:55.631Z] [ 10%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewbutton.cpp.o[2020-03-17T14:33:55.631Z] [ 10%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/compositing.cpp.o[2020-03-17T14:33:55.890Z] [ 10%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewbridge.cpp.o[2020-03-17T14:33:55.890Z] [ 10%] Linking CXX shared library ../bin/libkwinxrenderutils.so[2020-03-17T14:33:55.890Z] [ 10%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewclient.cpp.o[2020-03-17T14:33:55.890Z] [ 11%] Building CXX object 

D27677: feat: fix build after EDID changes in libkscreen

[Daniel Vrátil]

dvratil updated this revision to Diff 77830.
dvratil added a comment.


  - Fix commit message

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27677?vs=76460=77830

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D27677

AFFECTED FILES
  console/console.cpp

To: dvratil, #plasma
Cc: romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 464 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/464/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 14:40:33 +
 Build duration:
3 min 5 sec and counting
   CONSOLE OUTPUT
  [...truncated 2898 lines...][2020-03-17T14:43:22.109Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/gestures.cpp.o[2020-03-17T14:43:22.385Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/globalshortcuts.cpp.o[2020-03-17T14:43:22.661Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/group.cpp.o[2020-03-17T14:43:22.661Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/idle_inhibition.cpp.o[2020-03-17T14:43:22.929Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/input.cpp.o[2020-03-17T14:43:22.929Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/input_event.cpp.o[2020-03-17T14:43:23.209Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/input_event_spy.cpp.o[2020-03-17T14:43:23.209Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/internal_client.cpp.o[2020-03-17T14:43:23.209Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/keyboard_input.cpp.o[2020-03-17T14:43:23.489Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/keyboard_layout.cpp.o[2020-03-17T14:43:23.489Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/keyboard_layout_switching.cpp.o[2020-03-17T14:43:24.438Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/keyboard_repeat.cpp.o[2020-03-17T14:43:24.438Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/killwindow.cpp.o[2020-03-17T14:43:24.438Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/layers.cpp.o[2020-03-17T14:43:24.697Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/connection.cpp.o[2020-03-17T14:43:24.697Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/context.cpp.o[2020-03-17T14:43:24.963Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/device.cpp.o[2020-03-17T14:43:25.227Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/events.cpp.o[2020-03-17T14:43:25.499Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/libinput_logging.cpp.o[2020-03-17T14:43:25.499Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/linux_dmabuf.cpp.o[2020-03-17T14:43:25.499Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/logind.cpp.o[2020-03-17T14:43:25.775Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/main.cpp.o[2020-03-17T14:43:26.038Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/modifier_only_shortcuts.cpp.o[2020-03-17T14:43:26.302Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/moving_client_x11_filter.cpp.o[2020-03-17T14:43:26.302Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/netinfo.cpp.o[2020-03-17T14:43:26.302Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/onscreennotification.cpp.o[2020-03-17T14:43:26.566Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/options.cpp.o[2020-03-17T14:43:26.566Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/osd.cpp.o[2020-03-17T14:43:26.825Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/outline.cpp.o[2020-03-17T14:43:26.825Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/outputscreens.cpp.o[2020-03-17T14:43:27.084Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/overlaywindow.cpp.o[2020-03-17T14:43:27.084Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/placement.cpp.o[2020-03-17T14:43:27.344Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/platform.cpp.o[2020-03-17T14:43:27.917Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/pointer_input.cpp.o[2020-03-17T14:43:27.917Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/popup_input_filter.cpp.o[2020-03-17T14:43:27.917Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/rootinfo_filter.cpp.o[2020-03-17T14:43:28.187Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/rules.cpp.o[2020-03-17T14:43:28.187Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/rulebooksettings.cpp.o[2020-03-17T14:43:28.187Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/scene.cpp.o[2020-03-17T14:43:28.187Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/screenedge.cpp.o[2020-03-17T14:43:28.446Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/screenlockerwatcher.cpp.o[2020-03-17T14:43:28.712Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/screens.cpp.o[2020-03-17T14:43:28.712Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/dbuscall.cpp.o[2020-03-17T14:43:28.970Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/meta.cpp.o[2020-03-17T14:43:29.248Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/screenedgeitem.cpp.o[2020-03-17T14:43:29.519Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/scriptedeffect.cpp.o[2020-03-17T14:43:29.519Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting.cpp.o[2020-03-17T14:43:29.797Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting_logging.cpp.o[2020-03-17T14:43:29.797Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting_model.cpp.o[2020-03-17T14:43:30.380Z] [ 63%] Building CXX object 

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 624 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/624/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 17 Mar 2020 14:50:19 +
 Build duration:
2 min 46 sec and counting
   CONSOLE OUTPUT
  [...truncated 3357 lines...][2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwingltexture.h:31,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/platformsupport/scenes/opengl/texture.h:23,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/x11/standalone/glxbackend.h:23,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/x11/standalone/glxbackend.cpp:26:[2020-03-17T14:53:04.038Z] /usr/include/qt5/QtCore/qtextstream.h:239:28: note:   ���hex���[2020-03-17T14:53:04.038Z]   239 | Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T14:53:04.038Z]   |^~~[2020-03-17T14:53:04.038Z] In file included from /usr/include/c++/9/ios:42,[2020-03-17T14:53:04.038Z]  from /usr/include/c++/9/ostream:38,[2020-03-17T14:53:04.038Z]  from /usr/include/c++/9/iterator:64,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtCore/qbytearray.h:53,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtCore/qstring.h:49,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtCore/qobject.h:47,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtCore/qiodevice.h:45,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtCore/qdatastream.h:44,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtGui/qregion.h:49,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtGui/QRegion:1,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/platformsupport/scenes/opengl/backend.h:25,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/x11/standalone/glxbackend.h:22,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/x11/standalone/glxbackend.cpp:26:[2020-03-17T14:53:04.038Z] /usr/include/c++/9/bits/ios_base.h:1031:3: note:   ���std::hex���[2020-03-17T14:53:04.038Z]  1031 |   hex(ios_base& __base)[2020-03-17T14:53:04.038Z]   |   ^~~[2020-03-17T14:53:04.038Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/x11/standalone/glxbackend.cpp:692:77: error: ���hex��� is not a member of ���Qt���[2020-03-17T14:53:04.038Z]   692 | qCDebug(KWIN_X11STANDALONE).nospace() << "Using FBConfig 0x" << Qt::hex << fbc_id << " for visual 0x" << Qt::hex << visual_id;[2020-03-17T14:53:04.038Z]   | ^~~[2020-03-17T14:53:04.038Z] /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/x11/standalone/glxbackend.cpp:692:77: note: suggested alternatives:[2020-03-17T14:53:04.038Z] In file included from /usr/include/qt5/QtCore/qdebug.h:49,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtGui/qgenericmatrix.h:45,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtGui/qquaternion.h:44,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtGui/qmatrix4x4.h:46,[2020-03-17T14:53:04.038Z]  from /usr/include/qt5/QtGui/QMatrix4x4:1,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/libkwineffects/kwingltexture.h:31,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/platformsupport/scenes/opengl/texture.h:23,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/x11/standalone/glxbackend.h:23,[2020-03-17T14:53:04.038Z]  from /home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12/plugins/platforms/x11/standalone/glxbackend.cpp:26:[2020-03-17T14:53:04.038Z] /usr/include/qt5/QtCore/qtextstream.h:239:28: note:   ���hex���[2020-03-17T14:53:04.038Z]   239 | Q_CORE_EXPORT QTextStream (QTextStream );[2020-03-17T14:53:04.038Z]   |^~~[2020-03-17T14:53:04.039Z] In file included from /usr/include/c++/9/ios:42,[2020-03-17T14:53:04.039Z]  from /usr/include/c++/9/ostream:38,[2020-03-17T14:53:04.039Z]  from /usr/include/c++/9/iterator:64,[2020-03-17T14:53:04.039Z]  from /usr/include/qt5/QtCore/qbytearray.h:53,[2020-03-17T14:53:04.039Z]  from /usr/include/qt5/QtCore/qstring.h:49,[2020-03-17T14:53:04.039Z]  from 

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 75 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/75/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 15:00:12 +
 Build duration:
20 sec and counting
   CONSOLE OUTPUT
  [...truncated 170 lines...][2020-03-17T15:00:30.985Z] == Using the following environment to perform the build:[2020-03-17T15:00:30.985Z] JOB_NAME  = 'Plasma/kde-gtk-config/kf5-qt5 FreeBSDQt5.13'[2020-03-17T15:00:30.985Z] BUILD_NUMBER  = '75'[2020-03-17T15:00:30.985Z] LOGNAME   = 'jenkins'[2020-03-17T15:00:30.985Z] PAGER = 'more'[2020-03-17T15:00:30.985Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2020-03-17T15:00:30.985Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/display/redirect'[2020-03-17T15:00:30.985Z] MAIL  = '/var/mail/jenkins'[2020-03-17T15:00:30.985Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/75/display/redirect?page=changes'[2020-03-17T15:00:30.985Z] JENKINS_URL   = 'https://build.kde.org/'[2020-03-17T15:00:30.985Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-03-17T15:00:30.985Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.13'[2020-03-17T15:00:30.985Z] EDITOR= 'vi'[2020-03-17T15:00:30.985Z] ENV   = '/home/jenkins/.shrc'[2020-03-17T15:00:30.985Z] HUDSON_HOME   = '/home/production/data'[2020-03-17T15:00:30.985Z] BUILD_ID  = '75'[2020-03-17T15:00:30.985Z] OLDPWD= '/usr/home/jenkins'[2020-03-17T15:00:30.985Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kde-gtk-config/kf5-qt5 FreeBSDQt5.13'[2020-03-17T15:00:30.985Z] _ = '/usr/local/bin/java'[2020-03-17T15:00:30.985Z] TERM  = 'su'[2020-03-17T15:00:30.985Z] NODE_LABELS   = 'FreeBSD Builder Kappa FreeBSDQt5.13'[2020-03-17T15:00:30.985Z] BUILD_TAG = 'jenkins-Plasma-kde-gtk-config-kf5-qt5 FreeBSDQt5.13-75'[2020-03-17T15:00:30.985Z] BUILD_DISPLAY_NAME= '#75'[2020-03-17T15:00:30.985Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/75/display/redirect'[2020-03-17T15:00:30.985Z] USER  = 'jenkins'[2020-03-17T15:00:30.985Z] HOME  = '/home/jenkins'[2020-03-17T15:00:30.985Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/75/'[2020-03-17T15:00:30.985Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/'[2020-03-17T15:00:30.985Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-17T15:00:30.985Z] SHELL = '/bin/sh'[2020-03-17T15:00:30.985Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kde-gtk-config/kf5-qt5 FreeBSDQt5.13'[2020-03-17T15:00:30.985Z] STAGE_NAME= 'Configuring Build'[2020-03-17T15:00:30.985Z] NODE_NAME = 'FreeBSD Builder Kappa'[2020-03-17T15:00:30.985Z] BLOCKSIZE = 'K'[2020-03-17T15:00:30.985Z] EXECUTOR_NUMBER   = '0'[2020-03-17T15:00:30.985Z] SHLVL = '0'[2020-03-17T15:00:30.985Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-17T15:00:30.985Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-03-17T15:00:30.985Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-03-17T15:00:30.985Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-03-17T15:00:30.985Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-03-17T15:00:30.985Z] XDG_DATA_DIRS = '/usr/home/jenkins/install-prefix/share:/usr/share:/usr/local/share'[2020-03-17T15:00:30.985Z] XDG_CONFIG_DIRS   = '/usr/home/jenkins/install-prefix/etc/xdg:/usr/local/etc/xdg'[2020-03-17T15:00:30.985Z] QT_SELECT = 'qt5'[2020-03-17T15:00:30.985Z] LANG  = 'en_US.UTF-8'[2020-03-17T15:00:30.985Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-17T15:00:30.985Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0:detect_container_overflow=0:symbolize=1'[2020-03-17T15:00:30.985Z] ASAN_SYMBOLIZER_PATH  = '/usr/local/bin/llvm-symbolizer'[2020-03-17T15:00:30.985Z] [2020-03-17T15:00:30.985Z] [2020-03-17T15:00:30.985Z] == 

D10042: feat: parse EDID on the backend side

[Roman Gilg]

romangg added a comment.


  Thanks, so I'm talking about this line:
  
[15:31:16.521] kscreen-console(422251:422251) unknown:  Device ID:  
"xrandr-Eizo Nanao Corporation-DP-7-EV2736W/96211045"
  
  There it says xrandr, which should likely be not there.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D10042

To: dvratil, sebas, #plasma, romangg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kde-gtk-config » kf5-qt5 SUSEQt5.12 - Build # 123 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/123/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 17 Mar 2020 15:00:12 +
 Build duration:
55 sec and counting
   CONSOLE OUTPUT
  [...truncated 233 lines...][2020-03-17T15:01:04.711Z] XKEYSYMDB = '/usr/X11R6/lib/X11/XKeysymDB'[2020-03-17T15:01:04.711Z] BUILD_DISPLAY_NAME= '#123'[2020-03-17T15:01:04.711Z] XNLSPATH  = '/usr/X11R6/lib/X11/nls'[2020-03-17T15:01:04.711Z] HOME  = '/home/jenkins/'[2020-03-17T15:01:04.711Z] JENKINS_URL   = 'https://build.kde.org/'[2020-03-17T15:01:04.711Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.12'[2020-03-17T15:01:04.711Z] OSTYPE= 'linux'[2020-03-17T15:01:04.711Z] JOB_NAME  = 'Plasma/kde-gtk-config/kf5-qt5 SUSEQt5.12'[2020-03-17T15:01:04.711Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-03-17T15:01:04.711Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/123/display/redirect'[2020-03-17T15:01:04.711Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2020-03-17T15:01:04.711Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kde-gtk-config/kf5-qt5 SUSEQt5.12'[2020-03-17T15:01:04.711Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-17T15:01:04.711Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-03-17T15:01:04.711Z] NODE_NAME = 'Docker Swarm-70a380389759'[2020-03-17T15:01:04.711Z] HOST  = '70a380389759'[2020-03-17T15:01:04.711Z] LESSOPEN  = 'lessopen.sh %s'[2020-03-17T15:01:04.711Z] USER  = 'jenkins'[2020-03-17T15:01:04.711Z] MORE  = '-sl'[2020-03-17T15:01:04.711Z] CSHEDIT   = 'emacs'[2020-03-17T15:01:04.711Z] SHLVL = '2'[2020-03-17T15:01:04.711Z] BUILD_TAG = 'jenkins-Plasma-kde-gtk-config-kf5-qt5 SUSEQt5.12-123'[2020-03-17T15:01:04.711Z] WINDOWMANAGER = 'xterm'[2020-03-17T15:01:04.711Z] PAGER = 'less'[2020-03-17T15:01:04.711Z] EXECUTOR_NUMBER   = '0'[2020-03-17T15:01:04.711Z] CVS_RSH   = 'ssh'[2020-03-17T15:01:04.711Z] LIBGL_DEBUG   = 'quiet'[2020-03-17T15:01:04.711Z] STAGE_NAME= 'Configuring Build'[2020-03-17T15:01:04.711Z] NODE_LABELS   = 'Docker Swarm-70a380389759 SUSEQt5.12'[2020-03-17T15:01:04.711Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-03-17T15:01:04.711Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-03-17T15:01:04.711Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-03-17T15:01:04.711Z] PROFILEREAD   = 'true'[2020-03-17T15:01:04.711Z] MAIL  = '/var/spool/mail/jenkins'[2020-03-17T15:01:04.711Z] HOSTTYPE  = 'x86_64'[2020-03-17T15:01:04.711Z] BUILD_ID  = '123'[2020-03-17T15:01:04.711Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-03-17T15:01:04.711Z] OLDPWD= '/home/jenkins'[2020-03-17T15:01:04.711Z] LC_CTYPE  = 'C.UTF-8'[2020-03-17T15:01:04.711Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-17T15:01:04.711Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-03-17T15:01:04.711Z] PKG_CONFIG_PATH   = '/home/jenkins/install-prefix/lib64/pkgconfig:/usr/lib/pkgconfig:/usr/lib64/pkgconfig'[2020-03-17T15:01:04.711Z] QT_PLUGIN_PATH= '/home/jenkins/install-prefix/lib64/plugins'[2020-03-17T15:01:04.711Z] QML2_IMPORT_PATH  = '/home/jenkins/install-prefix/lib64/qml'[2020-03-17T15:01:04.711Z] QT_SELECT = 'qt5'[2020-03-17T15:01:04.711Z] LANG  = 'en_US.UTF-8'[2020-03-17T15:01:04.711Z] XDG_CURRENT_DESKTOP   = 'KDE'[2020-03-17T15:01:04.711Z] ASAN_OPTIONS  = 'detect_leaks=0:new_delete_type_mismatch=0:detect_odr_violation=0:stack-use-after-scope=0:alloc_dealloc_mismatch=0'[2020-03-17T15:01:04.711Z] [2020-03-17T15:01:04.711Z] [2020-03-17T15:01:04.711Z] == Commencing Configuration:[2020-03-17T15:01:04.711Z] cmake -DCMAKE_BUILD_TYPE=Debug -DBUILD_TESTING=ON -DCMAKE_INSTALL_PREFIX="/home/jenkins//install-prefix/" -DBUILD_COVERAGE=ON -DECM_ENABLE_SANITIZERS='address'  "/home/jenkins/workspace/Plasma/kde-gtk-config/kf5-qt5 SUSEQt5.12"[2020-03-17T15:01:04.970Z] -- The C compiler identification is GNU 9.2.1[2020-03-17T15:01:04.970Z] -- The CXX compiler identification is GNU 9.2.1[2020-03-17T15:01:05.236Z] -- Check for working C compiler: /usr/bin/cc[2020-03-17T15:01:05.236Z] -- Check for working C 

D28086: Improve CMake handling of GNOME libraries

[Carson Black]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:db87b4d270a1: Improve CMake handling of GNOME libraries 
(authored by cblack).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28086?vs=77831=77833

REVISION DETAIL
  https://phabricator.kde.org/D28086

AFFECTED FILES
  CMakeLists.txt
  cmake/modules/FindGTK3.cmake
  gtk3proxies/CMakeLists.txt
  gtkproxies/CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27669: [kstyle] Tools area

[Hugo Pereira Da Costa]

hpereiradacosta added a comment.


  Hi, 
   finally had some time to double-check into kiconloader, and confirmed that 
setting the custom palette and reseting is pretty harmless since it does not 
invalidate the cache. So to me it is fine to leave this part as it is now.
  I have added a few more optimization comments below. 
  Appart from these, I think what's still missing are:
  
  - an option to disable (both manually and automatically with non-null borders)
  - adressing the remaining comments (such as the unrelated metrics change, 
which IMO should really go into a separate commit and be justified on its own 
rather than within this (large) changeset,

INLINE COMMENTS

> breezestyle.cpp:4268
>  const auto& rect = option->rect;
> -const auto& palette = option->palette;
> +auto palette = option->palette;
> +

as far as I can tell, this palette is used only later, in "drawItemText" and 
only if text is shown. I would move this all block there (line 4395 or so)
Rational is that every time you call setColor to the palette, you actually 
detach the palette and create a new one, which is expensive. So one should do 
it as little as possible
In this case, when there are no text on the toolbar items, you would then never 
create the palette (and dont actually need it at all)
I have tried to look at the other places where you call palette.setColor(), but 
have found no easy way to avoid it (or minimize its impact). Still, feel free 
to have a look too.

> breezetoolsareamanager.cpp:162
> +for (auto window : animationMap.keys()) {
> +bool hasWidget = false;
> +if (std::none_of(_registeredWidgets.begin(), 
> _registeredWidgets.end(), [window](QWidget *widget) {

Unused

> breezetoolsareamanager.h:40
> +QMap animationMap;
> +QList m_widgetsWithPaletteForToolsAreaSet;
> +};

Should use a QSet rather than QList. It is faster on removal and contain check. 
Should also use const QWidget* as a contained object to avoid unnecessary need 
for const_caast

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg
Cc: IlyaBizyaev, davidre, davidedmundson, hpereiradacosta, gvgeo, ngraham, 
manueljlin, niccolove, ndavis, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28096: Don't overwrite status

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

TEST PLAN
  set an attentionIconByName in kstatusnotifieritemtest

REPOSITORY
  R120 Plasma Workspace

BRANCH
  attention (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28096

AFFECTED FILES
  applets/systemtray/systemtraymodel.cpp

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 461 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/461/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 14:08:16 +
 Build duration:
30 sec and counting
   CONSOLE OUTPUT
  [...truncated 160 lines...][2020-03-17T14:08:44.108Z] Retrieving: Plasma-prison-kf5-qt5[2020-03-17T14:08:44.108Z] Retrieving: Plasma-purpose-kf5-qt5[2020-03-17T14:08:44.108Z] Retrieving: Plasma-qqc2-desktop-style-kf5-qt5[2020-03-17T14:08:44.108Z] Retrieving: Plasma-syndication-kf5-qt5[2020-03-17T14:08:44.108Z] Retrieving: Plasma-kdecoration-kf5-qt5[2020-03-17T14:08:44.366Z] Retrieving: Plasma-kscreenlocker-kf5-qt5[2020-03-17T14:08:44.366Z] Retrieving: Plasma-kwayland-integration-kf5-qt5[2020-03-17T14:08:44.366Z] Retrieving: Plasma-breeze-kf5-qt5[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Configuring Build)[Pipeline] sh[2020-03-17T14:08:45.569Z] + python3 -u ci-tooling/helpers/configure-build.py --product Plasma --project kwin --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --installTo /home/jenkins/install-prefix/[2020-03-17T14:08:45.569Z] == Using the following environment to perform the build:[2020-03-17T14:08:45.569Z] JOB_NAME  = 'Plasma/kwin/kf5-qt5 FreeBSDQt5.13'[2020-03-17T14:08:45.569Z] BUILD_NUMBER  = '461'[2020-03-17T14:08:45.569Z] LOGNAME   = 'jenkins'[2020-03-17T14:08:45.569Z] PAGER = 'more'[2020-03-17T14:08:45.569Z] JAVA_HOME = '/usr/local/openjdk8-jre'[2020-03-17T14:08:45.569Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/display/redirect'[2020-03-17T14:08:45.569Z] MAIL  = '/var/mail/jenkins'[2020-03-17T14:08:45.569Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/461/display/redirect?page=changes'[2020-03-17T14:08:45.569Z] JENKINS_URL   = 'https://build.kde.org/'[2020-03-17T14:08:45.569Z] PATH  = '/usr/home/jenkins/install-prefix/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/home/jenkins/bin'[2020-03-17T14:08:45.569Z] JOB_BASE_NAME = 'kf5-qt5 FreeBSDQt5.13'[2020-03-17T14:08:45.569Z] EDITOR= 'vi'[2020-03-17T14:08:45.569Z] ENV   = '/home/jenkins/.shrc'[2020-03-17T14:08:45.569Z] HUDSON_HOME   = '/home/production/data'[2020-03-17T14:08:45.569Z] BUILD_ID  = '461'[2020-03-17T14:08:45.569Z] OLDPWD= '/usr/home/jenkins'[2020-03-17T14:08:45.569Z] PWD   = '/usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13'[2020-03-17T14:08:45.569Z] _ = '/usr/local/bin/java'[2020-03-17T14:08:45.569Z] TERM  = 'su'[2020-03-17T14:08:45.569Z] NODE_LABELS   = 'FreeBSD Builder Kappa FreeBSDQt5.13'[2020-03-17T14:08:45.569Z] BUILD_TAG = 'jenkins-Plasma-kwin-kf5-qt5 FreeBSDQt5.13-461'[2020-03-17T14:08:45.569Z] BUILD_DISPLAY_NAME= '#461'[2020-03-17T14:08:45.569Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/461/display/redirect'[2020-03-17T14:08:45.569Z] USER  = 'jenkins'[2020-03-17T14:08:45.569Z] HOME  = '/home/jenkins'[2020-03-17T14:08:45.569Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/461/'[2020-03-17T14:08:45.569Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/'[2020-03-17T14:08:45.569Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-17T14:08:45.569Z] SHELL = '/bin/sh'[2020-03-17T14:08:45.569Z] WORKSPACE = '/usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13'[2020-03-17T14:08:45.569Z] STAGE_NAME= 'Configuring Build'[2020-03-17T14:08:45.569Z] NODE_NAME = 'FreeBSD Builder Kappa'[2020-03-17T14:08:45.569Z] BLOCKSIZE = 'K'[2020-03-17T14:08:45.569Z] EXECUTOR_NUMBER   = '0'[2020-03-17T14:08:45.569Z] SHLVL = '0'[2020-03-17T14:08:45.569Z] CMAKE_PREFIX_PATH = '/usr/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-17T14:08:45.569Z] LD_LIBRARY_PATH   = '/usr/home/jenkins/install-prefix/lib:/usr/home/jenkins/install-prefix/libdata'[2020-03-17T14:08:45.569Z] PKG_CONFIG_PATH   = '/usr/home/jenkins/install-prefix/lib/pkgconfig:/usr/home/jenkins/install-prefix/libdata/pkgconfig:/usr/libdata/pkgconfig:/usr/local/libdata/pkgconfig'[2020-03-17T14:08:45.569Z] QT_PLUGIN_PATH= '/usr/home/jenkins/install-prefix/lib/plugins:/usr/local/lib/qca-qt5'[2020-03-17T14:08:45.569Z] QML2_IMPORT_PATH  = '/usr/home/jenkins/install-prefix/lib/qml'[2020-03-17T14:08:45.569Z] XDG_DATA_DIRS = 

D28099: Show command output on unknown failure

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> mountdialog.cpp:57
> +
> +QMessageBox::critical(this, i18n("Error details"), message);
> +

Kded is one of the processes that shouldn't freeze, lets avoid nested event 
loops

Some sort of

box = new QMessageBox()
box->setWidgetAttribute(delete on close)
box->show();

would be preferred

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28099

To: ivan, #plasma, davidedmundson, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 SUSEQt5.12 - Build # 620 - Failure!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/620/
 Project:
kf5-qt5 SUSEQt5.12
 Date of build:
Tue, 17 Mar 2020 14:08:16 +
 Build duration:
1 min 6 sec and counting
   CONSOLE OUTPUT
  [...truncated 223 lines...][2020-03-17T14:09:20.874Z] JAVA_ROOT = '/usr/lib64/jvm/jre-openjdk'[2020-03-17T14:09:20.874Z] JAVA_HOME = '/usr/lib64/jvm/jre-openjdk'[2020-03-17T14:09:20.874Z] JRE_HOME  = '/usr/lib64/jvm/jre'[2020-03-17T14:09:20.874Z] CPU   = 'x86_64'[2020-03-17T14:09:20.874Z] RUN_CHANGES_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/620/display/redirect?page=changes'[2020-03-17T14:09:20.874Z] JAVA_BINDIR   = '/usr/lib64/jvm/jre-openjdk/bin'[2020-03-17T14:09:20.874Z] GPG_TTY   = 'not a tty'[2020-03-17T14:09:20.874Z] HUDSON_HOME   = '/home/production/data'[2020-03-17T14:09:20.874Z] PWD   = '/home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12'[2020-03-17T14:09:20.874Z] LOGNAME   = 'jenkins'[2020-03-17T14:09:20.874Z] BUILD_URL = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/620/'[2020-03-17T14:09:20.874Z] JOB_URL   = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/'[2020-03-17T14:09:20.874Z] BUILD_NUMBER  = '620'[2020-03-17T14:09:20.874Z] _ = '/usr/bin/python3'[2020-03-17T14:09:20.874Z] XKEYSYMDB = '/usr/X11R6/lib/X11/XKeysymDB'[2020-03-17T14:09:20.874Z] BUILD_DISPLAY_NAME= '#620'[2020-03-17T14:09:20.874Z] XNLSPATH  = '/usr/X11R6/lib/X11/nls'[2020-03-17T14:09:20.874Z] HOME  = '/home/jenkins/'[2020-03-17T14:09:20.874Z] JENKINS_URL   = 'https://build.kde.org/'[2020-03-17T14:09:20.874Z] JOB_BASE_NAME = 'kf5-qt5 SUSEQt5.12'[2020-03-17T14:09:20.874Z] OSTYPE= 'linux'[2020-03-17T14:09:20.874Z] JOB_NAME  = 'Plasma/kwin/kf5-qt5 SUSEQt5.12'[2020-03-17T14:09:20.874Z] LESS_ADVANCED_PREPROCESSOR = 'no'[2020-03-17T14:09:20.874Z] RUN_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/620/display/redirect'[2020-03-17T14:09:20.874Z] JOB_DISPLAY_URL   = 'https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20SUSEQt5.12/display/redirect'[2020-03-17T14:09:20.874Z] WORKSPACE = '/home/jenkins/workspace/Plasma/kwin/kf5-qt5 SUSEQt5.12'[2020-03-17T14:09:20.874Z] HUDSON_URL= 'https://build.kde.org/'[2020-03-17T14:09:20.874Z] LESSCLOSE = 'lessclose.sh %s %s'[2020-03-17T14:09:20.875Z] NODE_NAME = 'Docker Swarm-6bf0dc55c5dc'[2020-03-17T14:09:20.875Z] HOST  = '6bf0dc55c5dc'[2020-03-17T14:09:20.875Z] LESSOPEN  = 'lessopen.sh %s'[2020-03-17T14:09:20.875Z] USER  = 'jenkins'[2020-03-17T14:09:20.875Z] MORE  = '-sl'[2020-03-17T14:09:20.875Z] CSHEDIT   = 'emacs'[2020-03-17T14:09:20.875Z] SHLVL = '2'[2020-03-17T14:09:20.875Z] BUILD_TAG = 'jenkins-Plasma-kwin-kf5-qt5 SUSEQt5.12-620'[2020-03-17T14:09:20.875Z] WINDOWMANAGER = 'xterm'[2020-03-17T14:09:20.875Z] PAGER = 'less'[2020-03-17T14:09:20.875Z] EXECUTOR_NUMBER   = '0'[2020-03-17T14:09:20.875Z] CVS_RSH   = 'ssh'[2020-03-17T14:09:20.875Z] LIBGL_DEBUG   = 'quiet'[2020-03-17T14:09:20.875Z] STAGE_NAME= 'Configuring Build'[2020-03-17T14:09:20.875Z] NODE_LABELS   = 'Docker Swarm-6bf0dc55c5dc SUSEQt5.12'[2020-03-17T14:09:20.875Z] XDG_DATA_DIRS = '/home/jenkins/install-prefix/share:/usr/share:/usr/local/share:/usr/share'[2020-03-17T14:09:20.875Z] CONFIG_SITE   = '/usr/share/site/x86_64-unknown-linux-gnu'[2020-03-17T14:09:20.875Z] PATH  = '/home/jenkins/install-prefix/bin:/home/jenkins//bin:/usr/local/bin:/usr/bin:/bin:/usr/lib/mit/bin:/usr/lib/mit/sbin'[2020-03-17T14:09:20.875Z] PROFILEREAD   = 'true'[2020-03-17T14:09:20.875Z] MAIL  = '/var/spool/mail/jenkins'[2020-03-17T14:09:20.875Z] HOSTTYPE  = 'x86_64'[2020-03-17T14:09:20.875Z] BUILD_ID  = '620'[2020-03-17T14:09:20.875Z] LESSKEY   = '/usr/etc/lesskey.bin'[2020-03-17T14:09:20.875Z] OLDPWD= '/home/jenkins'[2020-03-17T14:09:20.875Z] LC_CTYPE  = 'C.UTF-8'[2020-03-17T14:09:20.875Z] CMAKE_PREFIX_PATH = '/home/jenkins/install-prefix:/usr/:/usr/local/'[2020-03-17T14:09:20.875Z] LD_LIBRARY_PATH   = '/home/jenkins/install-prefix/lib64'[2020-03-17T14:09:20.875Z] PKG_CONFIG_PATH   = 

D28099: Show command output on unknown failure

[Ivan Čukić]

ivan updated this revision to Diff 77828.

REPOSITORY
  R845 Plasma Vault

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28099?vs=77822=77828

REVISION DETAIL
  https://phabricator.kde.org/D28099

AFFECTED FILES
  .gitignore
  kded/engine/backends/cryfs/cryfsbackend.cpp
  kded/engine/commandresult.cpp
  kded/engine/commandresult.h
  kded/engine/fusebackend_p.cpp
  kded/ui/mountdialog.cpp
  kded/ui/mountdialog.h

To: ivan, #plasma, davidedmundson, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 462 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/462/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 14:32:56 +
 Build duration:
56 sec and counting
   CONSOLE OUTPUT
  [...truncated 1595 lines...][2020-03-17T14:33:43.466Z] [  8%] Generating ui_editshortcut.h[2020-03-17T14:33:43.466Z] [  8%] Generating ui_ruleswidgetbase.h[2020-03-17T14:33:43.466Z] [  8%] Generating ui_ruleswidgetbase.h[2020-03-17T14:33:43.466Z] [  8%] Generating rulesettings.h, rulesettings.cpp[2020-03-17T14:33:43.466Z] [  8%] Generating rulesettings.h, rulesettings.cpp[2020-03-17T14:33:43.727Z] Scanning dependencies of target kwin_rules_dialog[2020-03-17T14:33:43.728Z] Scanning dependencies of target kcm_kwinrules[2020-03-17T14:33:43.728Z] [  8%] Building CXX object kcmkwin/kwinrules/CMakeFiles/kwin_rules_dialog.dir/kwin_rules_dialog_autogen/mocs_compilation.cpp.o[2020-03-17T14:33:43.728Z] [  9%] Building CXX object kcmkwin/kwinrules/CMakeFiles/kcm_kwinrules.dir/kcm_kwinrules_autogen/mocs_compilation.cpp.o[2020-03-17T14:33:44.000Z] [  9%] Building CXX object libkwineffects/CMakeFiles/kwinglutils.dir/logging.cpp.o[2020-03-17T14:33:44.000Z] [  9%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/main.cpp.o[2020-03-17T14:33:44.260Z] [  9%] Linking CXX shared library ../bin/libkwinxrenderutils.so[2020-03-17T14:33:44.260Z] /usr/home/jenkins/workspace/Plasma/kwin/kf5-qt5 FreeBSDQt5.13/libkwineffects/kwinglplatform.cpp:691:22: error: no viable overloaded '='[2020-03-17T14:33:44.260Z] m_extensions = {extensionsList.constBegin(), extensionsList.constEnd()};[2020-03-17T14:33:44.260Z]  ^ [2020-03-17T14:33:44.260Z] /usr/local/include/qt5/QtCore/qlist.h:71:29: note: candidate function (the implicit move assignment operator) not viable: cannot convert initializer list argument to 'QSet'[2020-03-17T14:33:44.260Z] template  class QSet;[2020-03-17T14:33:44.260Z] ^[2020-03-17T14:33:44.260Z] /usr/local/include/qt5/QtCore/qset.h:54:7: note: candidate function (the implicit copy assignment operator) not viable: cannot convert initializer list argument to 'const QSet'[2020-03-17T14:33:44.260Z] class QSet[2020-03-17T14:33:44.260Z]   ^[2020-03-17T14:33:44.260Z] [  9%] Built target kwinxrenderutils[2020-03-17T14:33:44.260Z] [  9%] Building CXX object kcmkwin/kwindecoration/CMakeFiles/kcm_kwindecoration.dir/declarative-plugin/buttonsmodel.cpp.o[2020-03-17T14:33:44.520Z] 1 error generated.[2020-03-17T14:33:44.520Z] gmake[2]: *** [libkwineffects/CMakeFiles/kwinglutils.dir/build.make:76: libkwineffects/CMakeFiles/kwinglutils.dir/kwinglplatform.cpp.o] Error 1[2020-03-17T14:33:44.520Z] gmake[2]: *** Waiting for unfinished jobs[2020-03-17T14:33:44.520Z] [ 10%] Building CXX object kcmkwin/kwindecoration/CMakeFiles/kcm_kwindecoration.dir/decorationmodel.cpp.o[2020-03-17T14:33:44.520Z] [ 10%] Generating ui_module.h[2020-03-17T14:33:44.520Z] Scanning dependencies of target kcm_kwin_scripts[2020-03-17T14:33:44.520Z] [ 10%] Building CXX object kcmkwin/kwindecoration/CMakeFiles/kcm_kwindecoration.dir/kcm.cpp.o[2020-03-17T14:33:44.520Z] [ 10%] Building CXX object kcmkwin/kwinscripts/CMakeFiles/kcm_kwin_scripts.dir/kcm_kwin_scripts_autogen/mocs_compilation.cpp.o[2020-03-17T14:33:44.785Z] [ 11%] Building CXX object kcmkwin/kwinoptions/CMakeFiles/kcm_kwinoptions.dir/__/__/effects/effect_builtins.cpp.o[2020-03-17T14:33:44.785Z] [ 11%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/compositing.cpp.o[2020-03-17T14:33:45.048Z] [ 11%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewbutton.cpp.o[2020-03-17T14:33:45.048Z] gmake[1]: *** [CMakeFiles/Makefile2:3024: libkwineffects/CMakeFiles/kwinglutils.dir/all] Error 2[2020-03-17T14:33:45.048Z] gmake[1]: *** Waiting for unfinished jobs[2020-03-17T14:33:45.048Z] [ 11%] Building CXX object kcmkwin/kwinrules/CMakeFiles/kwin_rules_dialog.dir/__/__/rulebooksettings.cpp.o[2020-03-17T14:33:45.641Z] [ 11%] Building CXX object kcmkwin/kwinoptions/CMakeFiles/kcm_kwinoptions.dir/main.cpp.o[2020-03-17T14:33:45.641Z] [ 11%] Building CXX object kcmkwin/kwinscripts/CMakeFiles/kcm_kwin_scripts.dir/main.cpp.o[2020-03-17T14:33:45.641Z] [ 11%] Building CXX object kcmkwin/kwinrules/CMakeFiles/kcm_kwinrules.dir/kcm.cpp.o[2020-03-17T14:33:45.641Z] [ 11%] Building CXX object kcmkwin/kwinrules/CMakeFiles/kwin_rules_dialog.dir/ruleswidget.cpp.o[2020-03-17T14:33:45.641Z] [ 11%] Building CXX object kcmkwin/kwincompositing/CMakeFiles/kwincompositing.dir/kwin_compositing_interface.cpp.o[2020-03-17T14:33:45.901Z] [ 11%] Building CXX object kcmkwin/kwindecoration/declarative-plugin/CMakeFiles/kdecorationprivatedeclarative.dir/previewbridge.cpp.o[2020-03-17T14:33:45.901Z] [ 11%] Building CXX object 

D28099: Show command output on unknown failure

[Ivan Čukić]

ivan added a comment.


  Of course... I need to reboot my brain it seems.

REPOSITORY
  R845 Plasma Vault

REVISION DETAIL
  https://phabricator.kde.org/D28099

To: ivan, #plasma, davidedmundson, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28083: Use methods in KF5-activities to switch to previous/next activity

[Christian Muehlhaeuser]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:805e70bb6e75: Use methods in KF5-activities to switch to 
previous/next activity (authored by muesli).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28083?vs=77780=77820

REVISION DETAIL
  https://phabricator.kde.org/D28083

AFFECTED FILES
  shell/shellcorona.cpp

To: muesli, ngraham, ivan, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28098: remove pointless and arbitrary 4 line frame limit

[Harald Sitter]

sitter updated this revision to Diff 77821.
sitter added a comment.


  update comment as well

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28098?vs=77817=77821

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28098

AFFECTED FILES
  src/parser/backtraceparser.cpp
  src/tests/backtraceparsertest/backtraceparsertest_data/test_bug192412_b

To: sitter, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27675: feat: avoid duplicated text when assembling user-facing output names

[Daniel Vrátil]

dvratil added a comment.


  The system makes sense on X11 where you get something like `HDMI-1 (Sony 
GigaTV-12345)` so you see which device it is and what physical output it's 
connected to. Since KWin does not use to output names but only the names of the 
actually connected devices, the needed behavior is different.

INLINE COMMENTS

> ahmadsamir wrote in utils.cpp:64
> If I am reading this correctly, you could keep the old code and use 
> simplified():
> const QString outName = output->name().simplified();
> 
> then later on:
> name = name.simplified();
> if (!name.isEmpty() && name != oName) {
> 
>   return name + QLatin1Char('(') + outName + QLatin1Char(')');
> 
> }

Not really, the catch is in the whitespace at the end of `name` (then `"Vendor 
Model " == "Vendor Model"` is never true)

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D27675

To: dvratil, #plasma, romangg
Cc: ahmadsamir, romangg, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28098: remove pointless and arbitrary 4 line frame limit

[Harald Sitter]

sitter created this revision.
sitter added a reviewer: apol.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
sitter requested review of this revision.

REVISION SUMMARY
  ... and update a related test case
  
  the original motivation here was garbage _start traces shouldn't be
  considered valuable. of course we have way more advanced measurements for
  whether a trace is valuable or not. notably the actual rating. so as
  long as we have any frame for evaluation that frame's rating **is**
  relevant.
  drkonqi is smart enough to ignore lines that do not matter already.
  e.g. everything above the crash handler is ignored, equally originator
  functions main/start_thread/start/... are ignored. they do not impact
  the rating at all, regardless of the amount of frames under review.
  as such it is entirely possible to have fewer than 4 frames under review
  and that those 4 frames are all we need (e.g. the crash is in main()
  directly)
  
  in fact, the very trace sample testing this was proving how the 4 line
  limit made no sense. the frame about KCmdLineArgs is the only relevant
  and only valuable frame in the sample and it is 100% useful making the
  entire trace useful. it is simply a nullptr dereference in the main.
  
  the frame limit is now 1 and the test sample has been replaced with
  a real-life sample from https://bugs.kde.org/show_bug.cgi?id=193032

TEST PLAN
  test passes again (was broken because _starts is now actively skipped)

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28098

AFFECTED FILES
  src/parser/backtraceparser.cpp
  src/tests/backtraceparsertest/backtraceparsertest_data/test_bug192412_b

To: sitter, apol
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28099: Show command output on unknown failure

[Ivan Čukić]

ivan created this revision.
ivan added reviewers: Plasma, davidedmundson, ngraham, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ivan requested review of this revision.

REVISION SUMMARY
  If the error is unknown (all errors in encfs), show the 'details...' button
  which shows the command line output to the user when activated.
  
  BUG:412779

REPOSITORY
  R845 Plasma Vault

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28099

AFFECTED FILES
  .gitignore
  kded/engine/backends/cryfs/cryfsbackend.cpp
  kded/engine/commandresult.cpp
  kded/engine/commandresult.h
  kded/engine/fusebackend_p.cpp
  kded/ui/mountdialog.cpp
  kded/ui/mountdialog.h

To: ivan, #plasma, davidedmundson, ngraham, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.13 - Build # 463 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.13/463/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 14:37:31 +
 Build duration:
2 min 56 sec and counting
   CONSOLE OUTPUT
  [...truncated 2899 lines...][2020-03-17T14:40:09.912Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/group.cpp.o[2020-03-17T14:40:09.912Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/idle_inhibition.cpp.o[2020-03-17T14:40:10.186Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/input.cpp.o[2020-03-17T14:40:10.186Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/input_event.cpp.o[2020-03-17T14:40:10.447Z] [ 60%] Building CXX object CMakeFiles/kwin.dir/input_event_spy.cpp.o[2020-03-17T14:40:10.447Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/internal_client.cpp.o[2020-03-17T14:40:10.733Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/keyboard_input.cpp.o[2020-03-17T14:40:10.733Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/keyboard_layout.cpp.o[2020-03-17T14:40:11.002Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/keyboard_layout_switching.cpp.o[2020-03-17T14:40:11.583Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/keyboard_repeat.cpp.o[2020-03-17T14:40:11.850Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/killwindow.cpp.o[2020-03-17T14:40:11.851Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/layers.cpp.o[2020-03-17T14:40:12.123Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/connection.cpp.o[2020-03-17T14:40:12.123Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/context.cpp.o[2020-03-17T14:40:12.123Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/device.cpp.o[2020-03-17T14:40:12.398Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/events.cpp.o[2020-03-17T14:40:12.981Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/libinput/libinput_logging.cpp.o[2020-03-17T14:40:12.981Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/linux_dmabuf.cpp.o[2020-03-17T14:40:13.242Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/logind.cpp.o[2020-03-17T14:40:13.242Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/main.cpp.o[2020-03-17T14:40:13.518Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/modifier_only_shortcuts.cpp.o[2020-03-17T14:40:13.786Z] [ 61%] Building CXX object CMakeFiles/kwin.dir/moving_client_x11_filter.cpp.o[2020-03-17T14:40:13.786Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/netinfo.cpp.o[2020-03-17T14:40:13.786Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/onscreennotification.cpp.o[2020-03-17T14:40:13.786Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/options.cpp.o[2020-03-17T14:40:14.050Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/osd.cpp.o[2020-03-17T14:40:14.050Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/outline.cpp.o[2020-03-17T14:40:14.050Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/outputscreens.cpp.o[2020-03-17T14:40:14.647Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/overlaywindow.cpp.o[2020-03-17T14:40:14.647Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/placement.cpp.o[2020-03-17T14:40:14.923Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/platform.cpp.o[2020-03-17T14:40:15.504Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/pointer_input.cpp.o[2020-03-17T14:40:15.504Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/popup_input_filter.cpp.o[2020-03-17T14:40:15.504Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/rootinfo_filter.cpp.o[2020-03-17T14:40:15.767Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/rules.cpp.o[2020-03-17T14:40:15.767Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/rulebooksettings.cpp.o[2020-03-17T14:40:15.767Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/scene.cpp.o[2020-03-17T14:40:15.767Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/screenedge.cpp.o[2020-03-17T14:40:15.767Z] [ 62%] Building CXX object CMakeFiles/kwin.dir/screenlockerwatcher.cpp.o[2020-03-17T14:40:15.767Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/screens.cpp.o[2020-03-17T14:40:16.357Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/dbuscall.cpp.o[2020-03-17T14:40:16.640Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/meta.cpp.o[2020-03-17T14:40:16.906Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/screenedgeitem.cpp.o[2020-03-17T14:40:17.498Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting.cpp.o[2020-03-17T14:40:17.498Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/scriptedeffect.cpp.o[2020-03-17T14:40:17.498Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting_logging.cpp.o[2020-03-17T14:40:17.498Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/scripting_model.cpp.o[2020-03-17T14:40:18.099Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/scriptingutils.cpp.o[2020-03-17T14:40:18.369Z] [ 63%] Building CXX object CMakeFiles/kwin.dir/scripting/timer.cpp.o[2020-03-17T14:40:18.369Z] [ 63%] Building CXX object 

D28106: fix: transfer tablet mode properties

[Roman Gilg]

romangg created this revision.
romangg added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
romangg requested review of this revision.

REVISION SUMMARY
  I forgot to copy over the tablet-mode-available and -engaged data from one
  config to the next one. Because of that the data was not available to the
  daemon.
  
  Also serialize the tablet mode properties in the Serializer. The Serializer
  is not used on Wayland afaik but if at one point for example the RandR backend
  gains auto rotation support we need to have it in the Serializer.
  
  BUG: 418739

TEST PLAN
  Manually with hard-coded tablet mode availability in KWin.

REPOSITORY
  R110 KScreen Library

BRANCH
  tablet-mode-fix

REVISION DETAIL
  https://phabricator.kde.org/D28106

AFFECTED FILES
  src/config.cpp
  src/configserializer.cpp

To: romangg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27808: [Fonts KCM] Port KFontDialog/KFontChooser to QFontDialog

[Ahmad Samir]

ahmadsamir added a comment.


  I spent some time looking (and hacking at a kdeplatformfontdialoghelper...) 
at the code in kdeplatformfiledialoghelper, KFontChooser and KFontDialog, and I 
am starting to think that moving KFontDialog to KWidgetAddons (where 
KFontChooser and KFontRequester live) is a better/more viable solution. Also 
the differences/features between KFonDialog/KFontChooser v.s. QFontDialog are 
numerous, unlike KIO open file dialog v.s. QFileDialog.
  
  Are there examples of how to move/port a class from one repo to another?

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27808

To: ahmadsamir, #plasma, davidedmundson, broulik, ervin, meven
Cc: cfeck, bport, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Carson Black]

cblack added a comment.


  In D28072#629439 , @gikari wrote:
  
  > > You simply test the recolouration like how it's been up until now—restart 
the applications.
  >
  > It doesn't work. This is what I was talking about:
  >
  > > It seems like it applies randomly whenever the GTK app would like to 
update the colors, but with that module it's predictable.
  
  
  You seem to be testing with Nautilus, which doesn't actually close when you 
press the close button.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  In D28072#629441 , @cblack wrote:
  
  > In D28072#629439 , @gikari wrote:
  >
  > > > You simply test the recolouration like how it's been up until 
now—restart the applications.
  > >
  > > It doesn't work. This is what I was talking about:
  > >
  > > > It seems like it applies randomly whenever the GTK app would like to 
update the colors, but with that module it's predictable.
  >
  >
  > You seem to be testing with Nautilus, which doesn't actually close when you 
press the close button.
  
  
  Yes, you're right, but I also tested it with Lutris. It also does not work. 
But with gedit it works fine.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Carson Black]

cblack added a comment.


  In D28072#629448 , @gikari wrote:
  
  > In D28072#629441 , @cblack wrote:
  >
  > > In D28072#629439 , @gikari 
wrote:
  > >
  > > > > You simply test the recolouration like how it's been up until 
now—restart the applications.
  > > >
  > > > It doesn't work. This is what I was talking about:
  > > >
  > > > > It seems like it applies randomly whenever the GTK app would like to 
update the colors, but with that module it's predictable.
  > >
  > >
  > > You seem to be testing with Nautilus, which doesn't actually close when 
you press the close button.
  >
  >
  > Yes, you're right, but I also tested it with Lutris. It also does not work. 
But with gedit it works fine.
  
  
  Lutris is also another application that doesn't close fully when you press 
close (however, that part is configurable in Lutris.)

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77860.
gikari edited the summary of this revision.
gikari added a comment.


  - Remove the recolor module. It is D28076 
 now

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=77855=77860

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Carson Black]

cblack requested changes to this revision.
cblack added a comment.
This revision now requires changes to proceed.


  The GTK+ module shouldn't be in this patch, as it and the functions to write 
CSS are separate changes.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Carson Black]

cblack updated this revision to Diff 77858.
cblack added a comment.


  Update CMakeLists.txt

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28076?vs=77857=77858

BRANCH
  arcpatch-D28076

REVISION DETAIL
  https://phabricator.kde.org/D28076

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28107: Fix overlayIcon sometimes not visible

[Anthony Fieroni]

anthonyfieroni added a comment.


  Can we just set/clear OverlayIconName depends of icon presence then 
`overlays: model.OverlayIconName` ?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28107

To: davidre, kmaterka, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari updated this revision to Diff 77855.
gikari added a comment.


  - Rebase on master
  - Add recoloration module

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=77723=77855

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Carson Black]

cblack added a comment.


  In D28072#629425 , @gikari wrote:
  
  > - I should add the recoloration module to autoload with GTK applications
  >
  > In D28072#629422 , @cblack wrote:
  >
  > > The GTK+ module shouldn't be in this patch, as it and the functions to 
write CSS are separate changes.
  >
  >
  > Then how do I test the recoloration? It seems like it applies randomly 
whenever the GTK app would like to update the colors, but with that module it's 
predictable. Or do you mean to make it as a separate patch, but make this one 
depend on it?
  
  
  The two items don't have a dependency relation codewise. You simply test the 
recolouration like how it's been up until now—restart the applications.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28104: [applets/digital-clock] Increase size of calendar in pop-up

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, broulik, mart.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  Various people were complaining that the calendar was too squished after 
D27903 . This
  patch restores its size to be closer to the old version. As a consequence, 
the whole
  expanded representation is quite large now, but there really is no other way.

TEST PLAN
  Before: F8181551: Before.png 
  After: F8181550: After.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  bigger-calendar (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28104

AFFECTED FILES
  applets/digital-clock/package/contents/ui/CalendarView.qml

To: ngraham, #vdg, broulik, mart
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28107: Fix overlayIcon sometimes not visible

[David Redondo]

davidre added a comment.


  I don't think the described behavior is not a bug in IconItem but rather a 
quirk in the interaction of all three (data engine, IconItem and KIconEngine) 
components. SO nothing to fix on that side.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28107

To: davidre, kmaterka, #plasma, broulik, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Carson Black]

cblack updated this revision to Diff 77862.
cblack added a comment.


  Fix bad symbol management

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28076?vs=77858=77862

BRANCH
  arcpatch-D28076

REVISION DETAIL
  https://phabricator.kde.org/D28076

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Carson Black]

cblack updated this revision to Diff 77857.
cblack added a comment.


  Rebase on master

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28076?vs=77768=77857

BRANCH
  arcpatch-D28076

REVISION DETAIL
  https://phabricator.kde.org/D28076

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28107: Fix overlayIcon sometimes not visible

[David Redondo]

davidre created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Workaround a specific behavior in IconItem if the source is a QIcon with a 
name
  and pixmaps. IconItem will use the name to find the original svg in any case
  and render that. This causes the rendered pixmaps that include the overlay 
inside
  the icons to be ignored by IconItem. This happens only when the service has a
  IconName but no IconPixmap (because the data engine prefers that) and
  a OverlayIconName.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  workaround (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28107

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp
  applets/systemtray/systemtraymodel.h

To: davidre
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari planned changes to this revision.
gikari added a comment.


  - I should add the recoloration module to autoload with GTK applications
  
  In D28072#629422 , @cblack wrote:
  
  > The GTK+ module shouldn't be in this patch, as it and the functions to 
write CSS are separate changes.
  
  
  Then how do I test the recoloration? It seems like it applies randomly 
whenever the GTK app would like to update the colors, but with that module it's 
predictable. Or do you mean to make it as a separate patch, but make this one 
depend on it?

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [WIP][GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  > You simply test the recolouration like how it's been up until now—restart 
the applications.
  
  It doesn't work. This is what I was talking about:
  
  > It seems like it applies randomly whenever the GTK app would like to update 
the colors, but with that module it's predictable.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27959: [libtaskmanager] Add ApplicationMenu{ObjectPath, ServiceName} roles to model

[Kai Uwe Broulik]

broulik added a comment.


  I think you should cache the X props, otherwise every `data` access causes a 
round trip to the X server.

INLINE COMMENTS

> xwindowtasksmodel.cpp:472
>  
> +static const QByteArray s_x11AppMenuServiceNamePropertyName = 
> QByteArrayLiteral("_KDE_NET_WM_APPMENU_SERVICE_NAME");
> +static const QByteArray s_x11AppMenuObjectPathPropertyName = 
> QByteArrayLiteral("_KDE_NET_WM_APPMENU_OBJECT_PATH");

We generally want to avoid global statics in library code. In the applet it's 
fine because it's a plugin that is loaded on demand

> xwindowtasksmodel.cpp:475
> +
> +#if HAVE_X11
> +static QHash s_atoms;

Is this check needed? I would think `xwindowtasksmodel` is guarded in its 
entirety both compile-time and run-time.

> xwindowtasksmodel.cpp:486
> +QByteArray value;
> +if (!s_atoms.contains(name)) {
> +const xcb_intern_atom_cookie_t atomCookie = xcb_intern_atom(c, 
> false, name.length(), name.constData());

Avoid double look-up, use iterator

> xwindowtasksmodel.cpp:494
> +s_atoms[name] = atomReply->atom;
> +if (s_atoms[name] == XCB_ATOM_NONE) {
> +return value;

Avoid double hash look-up. Store atom in variable and check it

> xwindowtasksmodel.cpp:523
> +}
> +return qMakePair(QStringLiteral(""), QStringLiteral(""));
> +}

Use null `QString()`

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27959

To: cblack, #plasma
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Carson Black]

cblack updated this revision to Diff 77871.
cblack added a comment.


  Address feedback

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28076?vs=77862=77871

BRANCH
  arcpatch-D28076

REVISION DETAIL
  https://phabricator.kde.org/D28076

AFFECTED FILES
  CMakeLists.txt
  color-reload-module/CMakeLists.txt
  color-reload-module/reloader.c

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28106: fix: transfer tablet mode properties

[Roman Gilg]

This revision was automatically updated to reflect the committed changes.
Closed by commit R110:6ba447e9e59d: fix: transfer tablet mode properties 
(authored by romangg).

REPOSITORY
  R110 KScreen Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28106?vs=77852=77874

REVISION DETAIL
  https://phabricator.kde.org/D28106

AFFECTED FILES
  src/config.cpp
  src/configserializer.cpp

To: romangg, #plasma, bshah
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28107: Fix overlayIcon sometimes not visible

[David Redondo]

davidre added a comment.


  In D28107#629521 , @kmaterka wrote:
  
  > Yep, icons in SNI are a mess...
  >  Icons are processed in `StatusNotifierItemSource`, including overlay - 
that's were this should be fixed. From you comment I see it won't be easy...
  >  This is a workaround, it works, but makes the code even more messy.
  >
  > So... if you are brave enough, you can rewrite icon handling in SNI. Idea 
is to:
  >
  > - remove custom icon handling code from `StatusNotifierItemSource`
  > - pass data directly to QML
  > - move icon display logic to QML
  >
  >   What do you think?
  
  
  That was my initial idea but @broulik said
  
  > cant really change that though
  >  data engines are basically public api
  >  i.e. no behavior changes
  
  So we can't just remove `Icon` from the engine. We could keep `Icon` around 
for legacy and introduce `IconPixmap` and friends would be an indea

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28107

To: davidre, kmaterka, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28109: [applets/systemtray] Simplify icon size logic

[Konrad Materka]

kmaterka created this revision.
kmaterka added reviewers: Plasma: Workspaces, Plasma, ngraham, broulik.
kmaterka added a project: Plasma.
kmaterka requested review of this revision.

REVISION SUMMARY
  This change simplifies icon size logic - now it is controled only in one 
place: AbstractItem. This gives additional benefits, like icons perfectly 
centered.

TEST PLAN
  - Highlights should always be centered

REPOSITORY
  R120 Plasma Workspace

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28109

AFFECTED FILES
  applets/systemtray/package/contents/ui/ExpanderArrow.qml
  applets/systemtray/package/contents/ui/HiddenItemsView.qml
  applets/systemtray/package/contents/ui/items/AbstractItem.qml
  applets/systemtray/package/contents/ui/items/ItemLoader.qml
  applets/systemtray/package/contents/ui/items/PlasmoidItem.qml
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/package/contents/ui/main.qml

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28107: Fix overlayIcon sometimes not visible

[David Redondo]

davidre added a comment.


  In D28107#629446 , @anthonyfieroni 
wrote:
  
  > Can we just set/clear OverlayIconName depends of icon presence then 
`overlays: model.OverlayIconName` ?
  
  
  Of course thats much easier! Thank you!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28107

To: davidre, kmaterka, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28096: Don't overwrite status

[Konrad Materka]

kmaterka added a comment.


  > Oh you're right. It was not wokring for me on 5.18 so I changed this and it 
worked. But matter of fact it worked on master all allong :)
  
  5.18 is not using this data model, in 5.18 it is used only in configuration 
page. In 5.19 this model is everywhere.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28096

To: davidre, broulik, kmaterka, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28096: Don't overwrite status

[Konrad Materka]

kmaterka requested changes to this revision.
kmaterka added a comment.
This revision now requires changes to proceed.


  > The qml checks the value against the enum but updateItemData inserts the 
string.
  
  These are two different roles:
  "status" with enum value
  "Status" from SNI data
  
  The same happens for "category" role.
  
  And yeah, I know this is confusing... The best would be to remove all unused 
roles, especially all *Changed. I just copied all from 
`StatusNotifierItemSource`, some of them are deprecated from Plasma 4 times.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28096

To: davidre, broulik, kmaterka, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28096: Don't overwrite status

[David Redondo]

davidre abandoned this revision.
davidre added a comment.


  In D28096#629508 , @kmaterka wrote:
  
  > > The qml checks the value against the enum but updateItemData inserts the 
string.
  >
  > These are two different roles:
  >  "status" with enum value
  >  "Status" from SNI data
  >
  > The same happens for "category" role.
  >
  > And yeah, I know this is confusing... The best would be to remove all 
unused roles, especially all *Changed. I just copied all from 
`StatusNotifierItemSource`, some of them are deprecated from Plasma 4 times.
  
  
  Oh you're right. It was not wokring for me on 5.18 so I changed this and it 
worked. But matter of fact it worked on master all allong :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28096

To: davidre, broulik, kmaterka, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28107: Fix overlayIcon sometimes not visible

[Konrad Materka]

kmaterka requested changes to this revision.
kmaterka added a comment.
This revision now requires changes to proceed.


  Yep, icons in SNI are a mess...
  Icons are processed in `StatusNotifierItemSource`, including overlay - that's 
were this should be fixed. From you comment I see it won't be easy...
  This is a workaround, it works, but makes the code even more messy.
  
  So... if you are brave enough, you can rewrite icon handling in SNI. Idea is 
to:
  
  - remove custom icon handling code from `StatusNotifierItemSource`
  - pass data directly to QML
  - move icon display logic to QML
  
  What do you think?

INLINE COMMENTS

> systemtraymodel.cpp:321
> + */
> +if(!icon.value().name().isEmpty()) {
> +updateItemData(dataItem, data, Role::OverlayIconName);

code formatting (missing space after if)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28107

To: davidre, kmaterka, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28109: [applets/systemtray] Simplify icon size logic

[Konrad Materka]

kmaterka added inline comments.

INLINE COMMENTS

> ExpanderArrow.qml:31
>  implicitHeight: implicitWidth
> -visible: root.hiddenLayout.contentItem.children.length > 0
> +visible: root.hiddenLayout.count > 0
>  

This fixes issue (regression) with expander arrow not hiding when all items are 
visible. Probably I should create separate commit...

> ItemLoader.qml:28
>  itemLoader.setSource("PlasmoidItem.qml", {
> - "applet": model.applet,
> - "effectiveStatus": model.effectiveStatus
> + "model": model
>   })

The `effectiveStatus` was copied from the model, not binded. Separate commit?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28109

To: kmaterka, #plasma_workspaces, #plasma, ngraham, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Mikhail Zolotukhin]

gikari added inline comments.

INLINE COMMENTS

> CMakeLists.txt:3
> +
> +enable_language(C)
> +

Why is this needed? Aren't the CMake default languages in project (parent 
CMakeLists) both `CXX` and `C`?

> reloader.c:35
> +__attribute__((visibility("default"))) void gtk_module_init(gint *argc, 
> gchar ***argv[]) {
> +path = g_strconcat(g_get_home_dir(), "/.config/gtk-3.0/colors.css", 
> NULL);
> +file = g_file_new_for_path(path);

This is hardcoded directory.  The $XDG_CONFIG_HOME may be set to something 
other, not only the default.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  arcpatch-D28076

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28107: Fix overlayIcon sometimes not visible

[David Redondo]

davidre updated this revision to Diff 77866.
davidre added a comment.


  Only set the role conditionally

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28107?vs=77853=77866

BRANCH
  workaround (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28107

AFFECTED FILES
  applets/systemtray/package/contents/ui/items/StatusNotifierItem.qml
  applets/systemtray/systemtraymodel.cpp

To: davidre, kmaterka, #plasma, broulik, davidedmundson
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28113: Fix initial loading of autostart program names

[Yichao Yu]

yuyichao created this revision.
yuyichao added reviewers: apol, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
yuyichao requested review of this revision.

REVISION SUMMARY
  When the auto start entry is first loaded, the module only take into account
  the "Name" entry in the desktop file. However, after editing or when adding
  a new one, `KService::name` is used which uses the file name as a fallback.
  This causes the name to "mysteriously" appear and disappear when
  checking the setting or reopenning the setting page.
  
  This change fixes the issue by using the same function `KService::name`
  in all cases. This is less efficient but easier to maintain than
  duplicating the logic from `KService`.
  
  Also use the newly available `KService` instance to replace some of
  the manual reading of the desktop file.
  The handling of `NotShowIn` and `OnlyShowIn` are left in place since
  `KService::showInCurrentDesktop()` takes into account the current running
  environment rather than only `KDE`.
  Changing that behavior should be a separate issue.

TEST PLAN
  Tested on 5.18.3. Unable to test on master (5.18.80)

REPOSITORY
  R119 Plasma Desktop

BRANCH
  names (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28113

AFFECTED FILES
  kcms/autostart/autostart.cpp

To: yuyichao, apol, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28068: Cleanup file resolving

[Keith Zubot-Gephart]

keithzg requested changes to this revision.
keithzg added a comment.
This revision now requires changes to proceed.


  Compiles when included in an Android Debug build but when attempting to run 
an application I hit an immediate crash on startup with:
  
  name=Android logcat
QQmlApplicationEngine failed to load component
qrc:/qml/main.qml:8:1: Type Kirigami.ApplicationWindow unavailable
qrc:/android_rcc_bundle/qml/org/kde/kirigami.2/ApplicationWindow.qml: No 
such file or directory
  
  Trying an Android Release compile still fails on the pre-exisiting error of 
being unable to include `` in
  
  name=kirigamiplugin.cpp
#ifdef KIRIGAMI_BUILD_TYPE_STATIC
#include 
#endif
  
  So unfortunately nothing is better and one side of things is worse, from the 
perspective of Android + QMake :(

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D28068

To: nicolasfella, #kirigami, mart, keithzg, vkrause
Cc: broulik, plasma-devel, fbampaloukas, GB_2, domson, dkardarakos, ngraham, 
apol, ahiemstra, davidedmundson, mart

D28086: Improve CMake handling of GNOME libraries

[Mikhail Zolotukhin]

gikari added a comment.


  It builds, but why aren't you using that stuff inside of `FingGTK3.cmake` 
module? It actually uses it inside already, but with some bugs, that prevents 
from building last patch.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  better-gtk-glib-etc-usage (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28086

To: cblack, #plasma, gikari, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28055: Fix on wayland activating minimized window will move window to current desktop

[Vlad Zahorodnii]

zzag added a comment.


  Yes, on Wayland, a window can be more on than just one desktop. However, in 
this scenario, the minimized window should not be placed on other desktops.
  
  > how should I proceed ?
  
  First, we need to make sure that plasmashell doesn't put the window on other 
desktops. We could do that by running WAYLAND_DEBUG=1 plasmashell and then 
analyzing the output. If plasmashell indeed doesn't place the window on other 
desktops, put some qDebugs in KWin to see where things go wrong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28055

To: pereira.alex, #plasma, zzag
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Breeze] [Bug 418949] New: plymouth-theme-breeze should have a background/wallpaper option

[Walther Pelser]

https://bugs.kde.org/show_bug.cgi?id=418949

Bug ID: 418949
   Summary: plymouth-theme-breeze should have a
background/wallpaper option
   Product: Breeze
   Version: unspecified
  Platform: Other
OS: Linux
Status: REPORTED
  Severity: normal
  Priority: NOR
 Component: Plymouth
  Assignee: plasma-devel@kde.org
  Reporter: w.pel...@web.de
CC: sit...@kde.org
  Target Milestone: ---

SUMMARY
On linux plymouth is started during boot in-between grub2 and sddm. grub2 comes
with a background, which could be changed by YAST, sddm can be customized by
systemsettings5, which could change the background too. Only plymouth has no
option. It seems to be nice and necessary, to have a backround/wallpaper
ability  too. The same background/wallpaper during all the steps of the boot
process would be  preferable.
This is an example for this issue with an other distro:
https://www.linuxliteos.com/forums/desktop-customization/background-image-when-starting-'the-feather'-4739/?PHPSESSID=a0lcqpabjrb2uuiuvb5utg7vo5

STEPS TO REPRODUCE
1. 
2. 
3. 

OBSERVED RESULT


EXPECTED RESULT


SOFTWARE/OS VERSIONS
Windows: 
macOS: 
Linux/KDE Plasma: openSUSE-Tumbleweed
(available in About System)
KDE Plasma Version: 5.67.0
KDE Frameworks Version: 5.18.3
Qt Version: 5.14.1

ADDITIONAL INFORMATION
Example:
It would be easy to add a code like this, to solve this issue. This would not
change the behavior of plymouth-theme-breeze, but it creates only an option.

--- a/breeze/breeze.script.cmake
+++ b/breeze/breeze.script.cmake
@@ -342,4 +342,20 @@ enable background image possibility
-// -- Background 
//
-Window.ApplyBackgroundColors();
-global.backgroundApplied = false;
-
+// -- Background 
//
+// to enable a BackgroundImage instead of BackgroundColor: copy a file with
the name "background.png" into the images folder. If "global.backgroundApplied
= true", background.png should be removed //
+if ("images/background.png")
+{
+ wallpaper_image = Image("images/background.png");
+ screen_width = Window.GetWidth();
+ screen_height = Window.GetHeight();
+ resized_wallpaper_image =
wallpaper_image.Scale(screen_width,screen_height);
+ wallpaper_sprite = Sprite(resized_wallpaper_image);
+ wallpaper_sprite.SetZ(-100);
+
+ Window.ApplyBackground();
+ global.backgroundApplied = false;
+}
+else 
+{ 
+ Window.ApplyBackgroundColor();
+ global.backgroundApplied = false;
+}
+

-- 
You are receiving this mail because:
You are the assignee for the bug.

D28057: Fix/Allow folderview popup mode icon and list icon size

[Alexandre Pereira]

pereira.alex added a comment.


  In D28057#628853 , @ngraham wrote:
  
  > Thanks!
  >
  > Now we have a new problem though: the default icon size for list view is 
synchronized with the default icon size for icon view, so it's now gigantic by 
default: F8180048: Screenshot_20200316_190912.png 

  >
  > We need for the default value itself to be different for icon vs list view, 
while allowing each one to be independent. Probably the cleanest way to do this 
is to define a new value in the config file for the default list view icon size 
(could be called something like `listViewIconSize`) and then change 
`makeIconSize()` (good thing you kept it, lol) to return `return 
FolderTools.iconSizeFromTheme(plasmoid.configuration.listViewIconSize)` when 
it's in list view.
  >
  > Does that make sense?
  
  
  Yes, it does !
  I will look into it, and do like you said, a new listViewIconSize default !

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28057

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28079: [keditfiletype] Prevent removing the "main" glob pattern for mime types

[Ahmad Samir]

ahmadsamir added a comment.


  For background see: https://bugs.kde.org/show_bug.cgi?id=414742
  
  I may be wrong, but personally I think QMimeDatabase is acting sensibly by 
not allowing to remove the "main" glob pattern of a mimetype.
  
  Also IIUC it seems other tools are sort of doing the same, e.g. gio (see the 
bug report for some testing I posted there).
  
  So, either this diff makes sense, or someone will have to put his upstream Qt 
hat on and change QMimeDatabase :p; I dug into the git history upstream, and 
IIRC it seems QMimeDatabase prepends the main glob pattern since 2012 (from 
before it was merged into qtbase).

REPOSITORY
  R126 KDE CLI Utilities

REVISION DETAIL
  https://phabricator.kde.org/D28079

To: ahmadsamir, #plasma, dfaure, davidedmundson, apol
Cc: kde-frameworks-devel, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28057: Fix/Allow folderview popup mode icon and list icon size

[Alexandre Pereira]

pereira.alex updated this revision to Diff 77808.
pereira.alex added a comment.


  Using separate configs for list and icon mode
  
  Like previously talked, added listViewIconSize 
  to the config xml. ( i also fix a little typoo, hope it doesn't make the 
commit invalid )
  
  My solution was to duplicate the slider, one with id iconSize and another 
with id listViewIconSize.
  Sorry if this is a bad solution, I have to pick up the qt qml books !
  
  But it seems to be working as intended, with each mode having it size saved 
and applied accordingly.

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28057?vs=77791=77808

BRANCH
  fix-folderview-popup-icon-list-size (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28057

AFFECTED FILES
  containments/desktop/package/contents/config/main.xml
  containments/desktop/package/contents/ui/ConfigIcons.qml
  containments/desktop/package/contents/ui/FolderView.qml

To: pereira.alex, #plasma, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

KDE CI: Plasma » drkonqi » kf5-qt5 WindowsMSVCQt5.14 - Build # 14 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20WindowsMSVCQt5.14/14/
 Project:
kf5-qt5 WindowsMSVCQt5.14
 Date of build:
Tue, 17 Mar 2020 08:23:31 +
 Build duration:
1 min 52 sec and counting
   CONSOLE OUTPUT
  [...truncated 405 lines...][2020-03-17T08:25:07.714Z] [23/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bug.cpp.obj[2020-03-17T08:25:07.714Z] [24/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\qbugzilla_autogen\mocs_compilation.cpp.obj[2020-03-17T08:25:07.975Z] [25/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsernull.cpp.obj[2020-03-17T08:25:08.549Z] [26/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparser.cpp.obj[2020-03-17T08:25:08.549Z] [27/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\clients\commands\newbug.cpp.obj[2020-03-17T08:25:08.809Z] [28/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\comment.cpp.obj[2020-03-17T08:25:09.069Z] [29/149] Building CXX object src\bugzillaintegration\libbugzilla\CMakeFiles\qbugzilla.dir\models\bugfield.cpp.obj[2020-03-17T08:25:09.069Z] [30/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsercdb.cpp.obj[2020-03-17T08:25:09.069Z] [31/149] Linking CXX static library lib\qbugzilla.lib[2020-03-17T08:25:09.330Z] [32/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserlldb.cpp.obj[2020-03-17T08:25:09.593Z] [33/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparserkdbgwin.cpp.obj[2020-03-17T08:25:09.593Z] [34/149] Building CXX object src\tests\crashtest\CMakeFiles\crashtest.dir\crashtest_autogen\mocs_compilation.cpp.obj[2020-03-17T08:25:09.854Z] [35/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\backtraceparsergdb.cpp.obj[2020-03-17T08:25:10.426Z] [36/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_backtrace_parser_autogen\mocs_compilation.cpp.obj[2020-03-17T08:25:10.426Z] [37/149] Building CXX object src\parser\CMakeFiles\drkonqi_backtrace_parser.dir\drkonqi_parser_debug.cpp.obj[2020-03-17T08:25:10.687Z] [38/149] Linking CXX static library lib\drkonqi_backtrace_parser.lib[2020-03-17T08:25:10.948Z] [39/149] Automatic MOC for target bugzillalibtest[2020-03-17T08:25:11.209Z] [40/149] Automatic MOC for target bugzillatest[2020-03-17T08:25:12.151Z] [41/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\abstract_generator.cpp.obj[2020-03-17T08:25:12.151Z] [42/149] Automatic MOC for target gdbbacktracelinetest[2020-03-17T08:25:12.412Z] [43/149] Building CXX object src\tests\CMakeFiles\gdbbacktracelinetest.dir\gdbbacktracelinetest_autogen\mocs_compilation.cpp.obj[2020-03-17T08:25:12.412Z] [44/149] Automatic MOC for target DrKonqiInternal[2020-03-17T08:25:12.413Z] [45/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\main.cpp.obj[2020-03-17T08:25:12.986Z] [46/149] Generating ui_assistantpage_bugzilla_version.h[2020-03-17T08:25:12.986Z] [47/149] Automatic MOC for target backtraceparsertest[2020-03-17T08:25:12.986Z] [48/149] Generating ui_assistantpage_bugzilla_preview.h[2020-03-17T08:25:12.986Z] [49/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_process.cpp.obj[2020-03-17T08:25:13.248Z] [50/149] Automatic MOC for target backtraceparsertest_manual[2020-03-17T08:25:13.248Z] [51/149] Generating ui_assistantpage_bugzilla_send.h[2020-03-17T08:25:13.248Z] [52/149] Generating ui_maindialog.h[2020-03-17T08:25:13.248Z] [53/149] Generating ui_assistantpage_introduction.h[2020-03-17T08:25:13.248Z] [54/149] Generating ui_assistantpage_bugzilla_duplicates_dialog.h[2020-03-17T08:25:13.514Z] [55/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\kdbgwin_autogen\mocs_compilation.cpp.obj[2020-03-17T08:25:13.514Z] [56/149] Generating ui_assistantpage_bugawareness.h[2020-03-17T08:25:13.514Z] [57/149] Generating ui_backtracewidget.h[2020-03-17T08:25:13.514Z] [58/149] Generating ui_assistantpage_conclusions.h[2020-03-17T08:25:13.514Z] [59/149] Generating ui_assistantpage_conclusions_dialog.h[2020-03-17T08:25:13.514Z] [60/149] Generating ui_assistantpage_bugzilla_login.h[2020-03-17T08:25:13.514Z] [61/149] Generating ui_assistantpage_bugzilla_duplicates_dialog_confirmation.h[2020-03-17T08:25:13.783Z] [62/149] Generating ui_assistantpage_bugzilla_information.h[2020-03-17T08:25:13.783Z] [63/149] Generating ui_assistantpage_bugzilla_duplicates.h[2020-03-17T08:25:13.783Z] [64/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\__\drkonqi_debug.cpp.obj[2020-03-17T08:25:15.170Z] [65/149] Building CXX object src\kdbgwin\CMakeFiles\kdbgwin.dir\callbacks.cpp.obj[2020-03-17T08:25:16.114Z] [66/149] Building CXX object 

KDE CI: Plasma » drkonqi » kf5-qt5 FreeBSDQt5.13 - Build # 69 - Still Failing!

[CI System]

BUILD FAILURE
 Build URL
https://build.kde.org/job/Plasma/job/drkonqi/job/kf5-qt5%20FreeBSDQt5.13/69/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 08:23:32 +
 Build duration:
43 sec and counting
   CONSOLE OUTPUT
  [...truncated 292 lines...][2020-03-17T08:24:07.498Z]  * KF5Completion (required version >= 5.61.0)[2020-03-17T08:24:07.498Z]  * KF5WidgetsAddons (required version >= 5.61.0)[2020-03-17T08:24:07.498Z]  * Qt5Gui (required version >= 5.12.0)[2020-03-17T08:24:07.498Z]  * KF5Wallet (required version >= 5.61.0)[2020-03-17T08:24:07.498Z]  * Qt5DBus (required version >= 5.12.0)[2020-03-17T08:24:07.498Z]  * KF5Notifications (required version >= 5.61.0)[2020-03-17T08:24:07.498Z]  * Qt5Core (required version >= 5.12.0)[2020-03-17T08:24:07.498Z]  * KF5IdleTime (required version >= 5.61.0)[2020-03-17T08:24:07.498Z]  * Qt5Widgets (required version >= 5.12.0)[2020-03-17T08:24:07.498Z]  * KF5WindowSystem (required version >= 5.61.0)[2020-03-17T08:24:07.498Z]  * KF5 (required version >= 5.61.0)[2020-03-17T08:24:07.498Z]  * Qt5Test[2020-03-17T08:24:07.498Z] [2020-03-17T08:24:07.498Z] -- The following features have been disabled:[2020-03-17T08:24:07.498Z] [2020-03-17T08:24:07.498Z]  * DrKonqiIntegrationTesting, Needs Ruby, functional atspi gem, gdb, as well as xvfb-run.[2020-03-17T08:24:07.498Z] [2020-03-17T08:24:07.498Z] -- Configuring done[2020-03-17T08:24:08.090Z] -- Generating done[2020-03-17T08:24:08.090Z] -- Build files have been written to: /usr/home/jenkins/workspace/Plasma/drkonqi/kf5-qt5 FreeBSDQt5.13/build[Pipeline] }[Pipeline] // stage[Pipeline] stage[Pipeline] { (Compiling)[Pipeline] sh[2020-03-17T08:24:08.878Z] + python3 -u ci-tooling/helpers/compile-build.py --product Plasma --project drkonqi --branchGroup kf5-qt5 --platform FreeBSDQt5.13 --usingInstall /home/jenkins/install-prefix/[2020-03-17T08:24:09.137Z] Scanning dependencies of target drkonqi_backtrace_parser_autogen[2020-03-17T08:24:09.137Z] [  1%] Automatic MOC for target drkonqi_backtrace_parser[2020-03-17T08:24:09.137Z] Scanning dependencies of target qbugzilla_autogen[2020-03-17T08:24:09.137Z] Scanning dependencies of target lsb_release_autogen[2020-03-17T08:24:09.137Z] Scanning dependencies of target crashtest_autogen[2020-03-17T08:24:09.137Z] [  1%] Automatic MOC for target lsb_release[2020-03-17T08:24:09.137Z] [  2%] Automatic MOC for target qbugzilla[2020-03-17T08:24:09.137Z] [  2%] Automatic MOC for target crashtest[2020-03-17T08:24:09.707Z] [  2%] Built target crashtest_autogen[2020-03-17T08:24:09.707Z] Scanning dependencies of target crashtest[2020-03-17T08:24:09.707Z] [  2%] Built target lsb_release_autogen[2020-03-17T08:24:10.008Z] [  3%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest.cpp.o[2020-03-17T08:24:10.008Z] Scanning dependencies of target lsb_release[2020-03-17T08:24:10.008Z] [  3%] Building CXX object src/tests/crashtest/CMakeFiles/crashtest.dir/crashtest_autogen/mocs_compilation.cpp.o[2020-03-17T08:24:10.008Z] [  3%] Building CXX object src/tests/CMakeFiles/lsb_release.dir/lsb_release_autogen/mocs_compilation.cpp.o[2020-03-17T08:24:10.008Z] [  4%] Building C object src/tests/CMakeFiles/lsb_release.dir/lsb_release_double.c.o[2020-03-17T08:24:10.269Z] [  5%] Linking CXX executable ../../bin/lsb_release[2020-03-17T08:24:10.557Z] [  5%] Built target lsb_release[2020-03-17T08:24:10.816Z] [  5%] Built target drkonqi_backtrace_parser_autogen[2020-03-17T08:24:11.096Z] Scanning dependencies of target drkonqi_backtrace_parser[2020-03-17T08:24:11.096Z] [  6%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsergdb.cpp.o[2020-03-17T08:24:11.096Z] [  6%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparser.cpp.o[2020-03-17T08:24:11.096Z] [  7%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_backtrace_parser_autogen/mocs_compilation.cpp.o[2020-03-17T08:24:11.096Z] [  8%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserkdbgwin.cpp.o[2020-03-17T08:24:11.096Z] [  8%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsernull.cpp.o[2020-03-17T08:24:11.096Z] [  8%] Built target qbugzilla_autogen[2020-03-17T08:24:11.096Z] [  9%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparserlldb.cpp.o[2020-03-17T08:24:11.096Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/backtraceparsercdb.cpp.o[2020-03-17T08:24:11.096Z] [ 10%] Building CXX object src/parser/CMakeFiles/drkonqi_backtrace_parser.dir/drkonqi_parser_debug.cpp.o[2020-03-17T08:24:11.386Z] Scanning dependencies of target qbugzilla[2020-03-17T08:24:11.386Z] [ 10%] Building CXX object src/bugzillaintegration/libbugzilla/CMakeFiles/qbugzilla.dir/apijob.cpp.o[2020-03-17T08:24:11.386Z] [ 11%] Building CXX object 

D28076: [GTK3] Add module to reload colorscheme in GTK3 apps without restarting them

[Ben Cooksley]

bcooksley added a comment.


  This change, and changes subsequent to it have broken the build of 
kde-gtk-config.
  
  Please see 
https://build.kde.org/view/Failing/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20SUSEQt5.12/
 and 
https://build.kde.org/view/Failing/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/
  
  Plasma developers - this is one of several breakages which have occurred over 
the last couple of days which you have failed to address in a timely fashion.
  Should this behaviour continue then CI coverage for Plasma will be 
discontinued and Plasma repositories will be blacklisted from the CI system and 
be unable to be used by other KDE software projects.

REPOSITORY
  R99 KDE Gtk Configuration Tool

REVISION DETAIL
  https://phabricator.kde.org/D28076

To: cblack, #plasma, gikari
Cc: bcooksley, gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28081: Populate Greeter process exit stderr

[David Edmundson]

davidedmundson added a comment.


  Can we use categorised logging please.
  
  But general +1

REPOSITORY
  R133 KScreenLocker

BRANCH
  debug

REVISION DETAIL
  https://phabricator.kde.org/D28081

To: romangg, #plasma, apol
Cc: davidedmundson, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

KDE CI: Plasma » kde-gtk-config » kf5-qt5 FreeBSDQt5.13 - Build # 74 - Fixed!

[CI System]

BUILD SUCCESS
 Build URL
https://build.kde.org/job/Plasma/job/kde-gtk-config/job/kf5-qt5%20FreeBSDQt5.13/74/
 Project:
kf5-qt5 FreeBSDQt5.13
 Date of build:
Tue, 17 Mar 2020 08:48:33 +
 Build duration:
56 sec and counting