D28707: Show purpose context menu only when enabled

[Kai Uwe Broulik]

broulik updated this revision to Diff 80149.
broulik added a comment.


  - Remove caching
  
  We update the menu on startup and when settings change, no need to cache it.

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28707?vs=79721=80149

REVISION DETAIL
  https://phabricator.kde.org/D28707

AFFECTED FILES
  extension/extension-purpose.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28838: fix the title of the mobile wifi kcm connection editor

[Tobias Fella]

tfella created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
Herald added a reviewer: jgrulich.
tfella requested review of this revision.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileWifiTitle (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28838

AFFECTED FILES
  mobile/wifi/package/contents/ui/NetworkSettings.qml

To: tfella, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28838: show ssid as title in mobile wifi connection editor

[Tobias Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:e527a2f0026f: show ssid as title in mobile wifi 
connection editor (authored by tfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28838?vs=80152=80153

REVISION DETAIL
  https://phabricator.kde.org/D28838

AFFECTED FILES
  mobile/wifi/package/contents/ui/NetworkSettings.qml

To: tfella, jgrulich, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Anthony Loiseau]

aloiseau abandoned this revision.
aloiseau added a comment.


  No problem :) If someone find it useful, then he/she will find it there and 
can apply it locally in its ~/.local/share folder.
  Note for anyone wanting to apply this patch locally in the future: hiding 
minute marks around the clock (keeping only hour marks) is the next funny step!

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma, ngraham
Cc: broulik, ngraham, aloiseau, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28262: [applets/analog-clock] Optional minute hand

[Nathaniel Graham]

ngraham added a comment.


  Heh. Thanks anyway! And now you have a dev environment set up so your next 
patch will be easier. :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D28262

To: aloiseau, #vdg, #plasma, ngraham
Cc: broulik, ngraham, aloiseau, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

gikari added a comment.


  So, is it ok to land? If so, approve please.

REPOSITORY
  R99 KDE Gtk Configuration Tool

BRANCH
  set-colors

REVISION DETAIL
  https://phabricator.kde.org/D28072

To: gikari, cblack, #plasma
Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28837: Add device icons to KDE Connect context menu

[Nicolas Fella]

nicolasfella added a comment.


  Cool, +1

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28837

To: broulik, #plasma, #kde_connect, fvogt, ndavis
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28799: Refactor and fix the mobile wifi kcm

[Tobias Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:7e65fd05b38e: Refactor and fix the mobile wifi kcm 
(authored by tfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28799?vs=80143=80146

REVISION DETAIL
  https://phabricator.kde.org/D28799

AFFECTED FILES
  libs/models/mobileproxymodel.cpp
  mobile/wifi/package/contents/ui/ConnectionEditor.qml
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/NetworkSettings.qml
  mobile/wifi/package/contents/ui/main.qml
  mobile/wifi/wifisettings.cpp

To: tfella, #plasma, ngraham, jgrulich, jbbgameich
Cc: nicolasfella, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28837: Add device icons to KDE Connect context menu

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, KDE Connect, fvogt, ndavis.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Firefox supports setting icons on menus [1]. Chrome refuses to create a menu 
with unknown keys, so this is guarded by `IS_FIREFOX`.
  This uses the appropriate Breeze icons, except "computer-tablet" which I 
edited to have larger padding to somewhat fit better with the rest of the icons.
  
  [1] 
https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/menus#Icons

TEST PLAN
  Probably some ESR testing? Though it said something about Firefox 55, so I 
suspect that has been in there since.
  
  F8237728: Screenshot_20200414_210421.png 

  
  (Will add the "Share..." icon once D28707 
 is in)

REPOSITORY
  R856 Plasma Browser Integration

REVISION DETAIL
  https://phabricator.kde.org/D28837

AFFECTED FILES
  extension/extension-kdeconnect.js
  extension/icons/computer-laptop-symbolic.svg
  extension/icons/computer-symbolic.svg
  extension/icons/smartphone-symbolic.svg
  extension/icons/tablet-symbolic.svg

To: broulik, #plasma, #kde_connect, fvogt, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28842: Raise size of default fixed-width font from 9 to 10pt

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, KTextEditor, Kate, Konsole.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  See discussion in T12744 . The fixed 
width font being smaller than others seems fairly
  arbitrary, and we have gotten some user complaints about it being too small. 
And the devs
  of our apps that use a lot of fixed-width fonts--Konsole and KTextEditor--are 
on board
  with this change.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  even-bigger-hack (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28842

AFFECTED FILES
  kcms/fonts/fontssettings.kcfg

To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28841: Raise size of default fixed-width font from 9 to 10pt

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma, KTextEditor, Kate, Konsole.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  See discussion in T12744 . The fixed 
width font being smaller than others seems fairly
  arbitrary, and we have gotten some user complaints about it being too small. 
And the devs of our apps that use a lot of fixed-width fonts--Konsole and 
KTextEditor--are on board
  with this change.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  even-bigger-hack (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28841

AFFECTED FILES
  src/platformtheme/kfontsettingsdata.cpp

To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28792: [Purpose Plugin] Open shared URL when clicking notification

[Kai Uwe Broulik]

This revision was not accepted when it landed; it landed in state "Needs 
Review".
This revision was automatically updated to reflect the committed changes.
Closed by commit R856:ae4890cf6f1a: [Purpose Plugin] Open shared URL when 
clicking notification (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28792?vs=80070=80147

REVISION DETAIL
  https://phabricator.kde.org/D28792

AFFECTED FILES
  extension/extension-purpose.js

To: broulik, #plasma, fvogt
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20569: RFC: Use more compact OSD

[Nathaniel Graham]

ngraham added a comment.


  https://bugs.kde.org/show_bug.cgi?id=344393 now has two duplicates. I would 
like to propose reconsidering this.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: broulik, #plasma, #vdg
Cc: alexde, achauvel, abetts, ngraham, davidedmundson, hein, Codezela, Fuchs, 
filipf, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

Kickoff menu with empty history tab

[Thomas Nemeth]

Hello.

It's been bugging me for a long time now but my kickoff menu doesn't
display any application nor document in its "History" tab. I thought
it was because I was using Debian Testing and that what I thought was
a bug would be fixed soon.

However, today, on a newly created user, I've seen that the History
tab isn't empty for other users. So I was wondering what could have
made my menu so special and what I could do to fix the problem...
without deleting my kde configuration and recreating it.

Thanks.


Thomas.

D28841: Raise size of default fixed-width font from 9 to 10pt

[Noah Davis]

ndavis accepted this revision.
ndavis added a comment.
This revision is now accepted and ready to land.


  +1

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  even-bigger-hack (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28841

To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28072: [GTK Config] Apply color scheme to GTK3 applications

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R99:a5d4ddb3b1a2: [GTK Config] Apply color scheme to GTK3 
applications (authored by gikari).

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28072?vs=79263=80166

REVISION DETAIL
  https://phabricator.kde.org/D28072

AFFECTED FILES
  CMakeLists.txt
  kconf_update/CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h

To: gikari, cblack, #plasma, ngraham
Cc: ndavis, ngraham, davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28070: [KRDB] Remove GTK3 color export

[Mikhail Zolotukhin]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:23aeddc99ad6: [KRDB] Remove GTK3 color export (authored 
by gikari).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28070?vs=9=80165

REVISION DETAIL
  https://phabricator.kde.org/D28070

AFFECTED FILES
  kcms/colors/colors.cpp
  kcms/krdb/krdb.cpp
  kcms/krdb/krdb.h
  kcms/style/kcmstyle.cpp

To: gikari, cblack, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28841: Raise size of default fixed-width font from 9 to 10pt

[Nathaniel Graham]

ngraham added a comment.


  There's also D28842  if you wanna be the 
VDG approver for that as well.

REPOSITORY
  R135 Integration for Qt applications in Plasma

BRANCH
  even-bigger-hack (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28841

To: ngraham, #vdg, #plasma, #ktexteditor, #kate, #konsole, ndavis
Cc: ndavis, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27972: [NightColor] fix for plasmoid status and tooltip subtext

[Peter J. Mello]

rscholar added a comment.


  In D27972#645517 , @pdabrowski 
wrote:
  
  > This widget could probably contain (at least) the information from the 
tooltip as mocked above or in D26688 . Or 
maybe even some settings (color temperature slidebar?).
  
  
  You beat me to it; adding a slidebar to manage the color temperate on-the-fly 
is the next logical evolution here (just like the Display Brightness Control 
widget, but hopefully with a much greater measure of aesthetic finesse).

REVISION DETAIL
  https://phabricator.kde.org/D27972

To: pdabrowski, #plasma, zzag, ngraham, #vdg
Cc: rscholar, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D20569: RFC: Use more compact OSD

[Armstrong]

Armstrong added a comment.


  the solution that @broulik is the ideal. Simply reposition it to a location 
that is not the center of the screen.
  Please reconsider adding that.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D20569

To: broulik, #plasma, #vdg
Cc: Armstrong, alexde, achauvel, abetts, ngraham, davidedmundson, hein, 
Codezela, Fuchs, filipf, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, sebas, apol, ahiemstra, mart

Re: Update on Status of Gitlab Migration

[Ivan Čukić]

Hi all,

While I do like the invent name, I agree there should be a redirect of some 
sort from git.kde.org to it.

The aforementioned Debian salsa server has one as well - https://
git.debian.org/ - a message stating that the new server is 'salsa.debian.org'

Cheers,
Ivan


-- 
dr Ivan Čukić
i...@cukic.co, https://cukic.co/
gpg key fingerprint: 8FE4 D32F 7061 EA9C 8232  07AE 01C6 CE2B FF04 1C12

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[José JORGE]

jjorge added a comment.


  I have finished my corrections. Is it nice now? Thanks.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28127

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28706: Restore old Audio prototype after exportFunction

[Kai Uwe Broulik]

broulik reclaimed this revision.
broulik added a comment.
This revision is now accepted and ready to land.


  Apparently there's no good alternative.
  In the future might make sense to refactor this to use a `moz-extensions` 

D28662: KCM LookAndFeel check widgetStyle availability before applying it

[Cyril Rossi]

crossi updated this revision to Diff 80067.
crossi added a comment.


  Fix comments

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28662?vs=79597=80067

REVISION DETAIL
  https://phabricator.kde.org/D28662

AFFECTED FILES
  kcms/lookandfeel/kcm.cpp

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Mon, Apr 13, 2020 at 9:29 AM Johan Ouwerkerk  wrote:
>
> On Sun, Apr 12, 2020 at 12:49 AM Johan Ouwerkerk  
> wrote:
> >
> > >
> > > We may need to do on-the-fly conversion of the kde: repo paths if they
> > > won't be expressible as 'kde:foo' in the future, but we should have the
> > > information needed to do this in kdesrc-build to make this happen
> > > on-the-fly.
> > >
> >
> > Yes, this should be fairly straight forward: we could do a `git remote
> > set-url` based on what the repo metadata tells us before updating a
> > local clone. In fact: we could build this right now and sell it as
> > "automagically recover your upstream".  :)
> >
> > I might try to hack something up tomorrow or monday for that.
> >
>
> A basic version of this is now available via:
> https://invent.kde.org/kde/kdesrc-build/-/merge_requests/27
> With this feature sysadmin should now be free to change the repopath
> value in the metadata YAML and kdesrc-build will reconfigure the
> remote URL appropriately automatically. This works as long as the same
> `kde:$path` expression works for both fetch and push, i.e. the layout
> on the anongit.kde.org network must match with the layout of
> git.kde.org/invent.kde.org. If necessary a simple path prefix change
> could still work with a minor update to the pushInsteadOf mapping,
> e.g. when repos on invent are mapped to kde/   instead of
> /.
>
> You can also experiment with setting invent.kde.org as the push URL by
> setting x-invent-kde-push-urls to true in your rc file. The effect
> should be visible through git remote -vv afterwards. (Disable the
> setting and re-run again afterwards because this will obviously break
> your push URLs as long as the Gitlab migration hasn't completed yet).

Many thanks for sending this patch through Johan, it's appreciated.

As one of the options we are looking at involves grouping
repositories, having the ability for kdesrc-build to seamlessly handle
this transition is definitely appreciated.


>
> Regards,
>
> - Johan

Cheers,
Ben

Re: Update on Status of Gitlab Migration

[Ben Cooksley]

On Tue, Apr 14, 2020 at 2:37 PM Nate Graham  wrote:
>
> On 4/13/20 6:59 PM, Ben Cooksley wrote:
> > Why do we need to mimic them?
> >
> > If you Google "KDE Gitlab" then the first hit is invent.kde.org
> > .
>
> To flip it around: why do we need to do something different? I don't
> think it's about mimicking anyone else, but rather using the most
> intuitively obvious domain name rather than some arbitrarily different one.
>
> No matter what, we're all going to be talking about "KDE GitLab" or
> "KDE's GitLab instance". The title of the relevant documentation page is
> "GitLab" (much as the Phabricator documentation page was named
> "Phabricator"). And when the migration is complete, we're all going to
> announce that "KDE is now using GitLab!" So the cat's out of the bag on
> using the word "GitLab" and avoiding some number of people looking for
> our stuff at gitlab.com and not finding it there. invent.kde.org doesn't
> avoid that at all.
>
> Given that, which is more confusing: explaining to people that we have a
> GitLab instance at invent.kde.org, or explaining to people that we have
> a GitLab instance at gitlab.kde.org?

There is no difference to be honest, the amount of explaining is
exactly the same.

We're also not alone in giving ours a different name - Debian did as
well (theirs is at salsa.debian.org). They didn't see fit to setup a
compatibility "gitlab.debian.org" hostname either.

>
> I know that over the next few years I'm going to be directing hundreds
> of people towards our infrastructure, and I would rather be able to say
> "please submit a pull request at gitlab.kde.org" rather than "please
> submit a pull request at KDE's GitLab instance at invent.kde.org."

Sorry, but the "KDE's Gitlab instance" in your second sentence is superfluous.
You could just as easily say "please submit a pull request on
invent.kde.org", not sure why you need to explicitly mention it is
Gitlab.

If people have already found the source code, chances are they will
have already found invent.kde.org anyway - as they will have probably
found it via a web browser, and Gitlab will be the only web interface
to our repositories (CGit is being discontinued)

>
> I know this probably feels like annoyingly extreme bikeshedding, but, I
> dunno, names are important.
>
> Nate

Cheers,
Ben

D28744: Rewrite of the global shortcuts kcm

[Cyril Rossi]

crossi added inline comments.

INLINE COMMENTS

> shortcutsmodel.h:83
> +void save();
> +bool needsSave();
> +bool isDefault();

should be const

> shortcutsmodel.h:84
> +bool needsSave();
> +bool isDefault();
> +

should be const

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: crossi, nicolasfella, ngraham, iasensio, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D27271: [kcms/colors] RFC: Accent Colours

[Cyril Rossi]

crossi added a comment.


  These new properties can be managed by KConfig.
  It will automatically handle the read/write process and 
isSaveNeeded/isDefault status.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27271

To: cblack, #plasma, #vdg
Cc: crossi, ngraham, The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

[Powerdevil] [Bug 383307] Brightness level is not remembered/restoring after sleep and levels up to maximum level

[Méven Car]

https://bugs.kde.org/show_bug.cgi?id=383307

Méven Car  changed:

   What|Removed |Added

 CC||meven@enioka.com
 Status|REPORTED|RESOLVED
 Resolution|--- |DUPLICATE

--- Comment #1 from Méven Car  ---


*** This bug has been marked as a duplicate of bug 414440 ***

-- 
You are receiving this mail because:
You are the assignee for the bug.

D27701: [ComboBox] Use transparent dimmer

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R858:2c777b1b4661: [ComboBox] Use transparent dimmer (authored 
by broulik).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D27701?vs=76546=80072#toc

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27701?vs=76546=80072

REVISION DETAIL
  https://phabricator.kde.org/D27701

AFFECTED FILES
  org.kde.desktop/ComboBox.qml

To: broulik, #plasma, ngraham, mart
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D26444: [RunnerResultsModel] Watch krunnerrc and reparse configuration when it changed

[David Edmundson]

davidedmundson requested changes to this revision.
davidedmundson added a comment.
This revision now requires changes to proceed.


  krunner also has horrible file watcher.
  
  This either makes sense at a library level (krunner)
  or in the frontend (krunner)
  
  but milou somewhere in the middle seems weird.

REPOSITORY
  R112 Milou

REVISION DETAIL
  https://phabricator.kde.org/D26444

To: broulik, #plasma, davidedmundson
Cc: davidedmundson, fvogt, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28657: [Notifications] Report roleNames in the relevant places

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:07dc5c49876c: [Notifications] Report roleNames in the 
relevant places (authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28657?vs=79575=80081

REVISION DETAIL
  https://phabricator.kde.org/D28657

AFFECTED FILES
  libnotificationmanager/jobsmodel.cpp
  libnotificationmanager/jobsmodel.h
  libnotificationmanager/notifications.cpp
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/utils.cpp
  libnotificationmanager/utils_p.h

To: broulik, #plasma, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport updated this revision to Diff 80085.
bport added a comment.


  update commit message

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80082=80085

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, meven, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: Identify output according to current applied position, not an unapplied position

[Benjamin Port]

bport updated this revision to Diff 80086.
bport added a comment.


  update commit message

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28818?vs=80083=80086

REVISION DETAIL
  https://phabricator.kde.org/D28818

AFFECTED FILES
  kcm/config_handler.h
  kcm/kcm.cpp

To: bport, #plasma, meven, ervin
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80088.
davidre added a comment.


  - Search when entering text and correctly color delegates
  - use fallback if action doesn't have a friendly name
  - Remove friend declaration

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=80074=80088

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport added a comment.


  I don't think we have a leak, on destructor we delete all view
  qDeleteAll(m_views);

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, meven, ervin
Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Anthony Fieroni]

anthonyfieroni added a comment.


  In D28817#647912 , @bport wrote:
  
  > I don't think we have a leak, on destructor we delete all view
  >  qDeleteAll(m_views);
  
  
  At that point, when rootObj is nullptr, view is not added to m_views.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, meven, ervin
Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[Arjen Hiemstra]

ahiemstra accepted this revision.
ahiemstra added a comment.
This revision is now accepted and ready to land.


  Seems fine to me now. You didn't have a developer account right?

REPOSITORY
  R106 KSysguard

BRANCH
  acpi-energy

REVISION DETAIL
  https://phabricator.kde.org/D28127

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28792: [Purpose Plugin] Open shared URL when clicking notification

[Kai Uwe Broulik]

broulik updated this revision to Diff 80070.
broulik added a comment.


  - Remove unrelated changes

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28792?vs=80011=80070

REVISION DETAIL
  https://phabricator.kde.org/D28792

AFFECTED FILES
  extension/extension-purpose.js

To: broulik, #plasma, fvogt
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28725: Drop QWindow and explicit devicePixelRatio usage for ComboBox

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:0eaf762705d8: Drop QWindow and explicit devicePixelRatio 
usage for ComboBox (authored by broulik).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28725?vs=79773=80071

REVISION DETAIL
  https://phabricator.kde.org/D28725

AFFECTED FILES
  kstyle/breezestyle.cpp

To: broulik, #plasma, davidre, hpereiradacosta, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28467: Converted to Page with a PlasmoidHeading in the heading

[Niccolò Venerandi]

niccolove added inline comments.

INLINE COMMENTS

> ngraham wrote in FullRepresentation.qml:31
> the visibility should be dependent on it having any items in it; or else it's 
> still visible when Bluetooth is disabled.

I though that was done by

  toolbar.visible = (state == "DevicesState" || state == "NoDevicesState");

At the end of the file. If you try to use the widget standalone, you will 
notice that it does disappear. Problem is, system tray doesn't notice. I can't 
understand why it doesn't read the ".visible" property.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28650: [Notifications] Don't reverse() Array

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:0fd991aa577a: [Notifications] Dont reverse() Array 
(authored by broulik).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28650?vs=79565=80080

REVISION DETAIL
  https://phabricator.kde.org/D28650

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: broulik, #plasma, nicolasfella, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28799: Refactor and fix the mobile wifi kcm

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  I wanted to let @ngraham to review this UI wise, but I see there are no UI 
changes. I don't follow mobile KCM development so I'm not sure I'm the right 
person to review this, but it looks good to me. I haven't tried it, but I 
believe you.

INLINE COMMENTS

> mobileproxymodel.cpp:66
>  } else {
> -if (sourceModel()->data(index,NetworkModel::SignalRole).toUInt() 
> == 0)
> -return false; // if signal is 0 yet we still have 
> connection, it means local access point -> we don't want to show that

This is no longer needed anyway as I already filter out local access points (in 
this meaning it is probably an AP which I share as hotspot).

See 
https://cgit.kde.org/plasma-nm.git/diff/libs/models/networkmodel.cpp?id=5e55e45d8794eb6c4840b2916e723177c18cd695.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  mobileWifiFix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28799

To: tfella, #plasma, ngraham, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28706: Restore old Audio prototype after exportFunction

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R856:08468773f1fe: Restore old Audio prototype after 
exportFunction (authored by broulik).

REPOSITORY
  R856 Plasma Browser Integration

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28706?vs=79719=80069

REVISION DETAIL
  https://phabricator.kde.org/D28706

AFFECTED FILES
  extension/content-script.js

To: broulik, #plasma, fvogt, ognarb
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28799: Refactor and fix the mobile wifi kcm

[Tobias Fella]

tfella updated this revision to Diff 80076.
tfella added a comment.


  Minor Fixes

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28799?vs=80029=80076

BRANCH
  mobileWifiFix (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28799

AFFECTED FILES
  libs/models/mobileproxymodel.cpp
  mobile/wifi/package/contents/ui/ConnectionEditor.qml
  mobile/wifi/package/contents/ui/ConnectionItemDelegate.qml
  mobile/wifi/package/contents/ui/NetworkSettings.qml
  mobile/wifi/package/contents/ui/main.qml
  mobile/wifi/wifisettings.cpp

To: tfella, #plasma, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, meven, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  BUG: 385672

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, meven, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: Identify output according to current applied position, not an unapplied position

[Benjamin Port]

bport created this revision.
bport added reviewers: Plasma, meven, ervin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
bport requested review of this revision.

REVISION SUMMARY
  Depends on D28817 .

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

AFFECTED FILES
  kcm/config_handler.h
  kcm/kcm.cpp

To: bport, #plasma, meven, ervin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28678: adjust smb kcm size to be sufficient vis a vis headers

[Harald Sitter]

This revision was automatically updated to reflect the committed changes.
Closed by commit R102:f2c5e10d4af3: adjust smb kcm size to be sufficient vis a 
vis headers (authored by sitter).

REPOSITORY
  R102 KInfoCenter

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28678?vs=79638=80087

REVISION DETAIL
  https://phabricator.kde.org/D28678

AFFECTED FILES
  Modules/samba/main.cpp

To: sitter, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre marked 5 inline comments as done.
davidre added inline comments.

INLINE COMMENTS

> broulik wrote in main.qml:94
> Is `contentItem` the default property?

Yes

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28034: [Applet] Port to ExpandableListItem

[Jan Grulich]

jgrulich accepted this revision.
jgrulich added a comment.
This revision is now accepted and ready to land.


  Those were probably all issues I could find. I will keep using it and if I 
find something later, I will let you know. Thank you.

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28034

To: ngraham, #vdg, #plasma, jgrulich
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport updated this revision to Diff 80090.
bport added a comment.


  Remove border and shadow

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80085=80090

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, meven, ervin
Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> filteredmodel.cpp:41
> +bool displayMatches = 
> index.data(Qt::DisplayRole).toString().contains(m_filter, 
> Qt::CaseInsensitive);
> +if (!source_parent.isValid() || displayMatches) {
> +return displayMatches;

If it's a toplevel item we can just return if the name matches. Recursive 
filtering will take care of the rest

> filteredmodel.cpp:45
> +
> +if (index.parent().data(Qt::DisplayRole).toString().contains(m_filter, 
> Qt::CaseInsensitive)) {
> +return true;

No if the parent matches but the child not, the child is filtered. Recursive 
filtering makes the parent show if it doesn't match but the child does

> ShortcutActionDelegate.qml:58
> +if (model.activeShortcuts.length != 0) {
> +return model.display + ": " + 
> model.activeShortcuts.map(s => kcm.keySequenceToString(s)).join(", ")
> +} else {

Shouldn't QKeySequence::NativeText take care of that or because of the list 
format?

> main.qml:53
> +enabled: exportWarning.visible
> +function onNeedsSaveChanged () {
> +exportWarning.visible = kcm.needsSave

The way I used it caused a binding loop

  Binding on visible {
  when: exportWarning.visible
  value: kcm.needsSave
  restoreMode: Binding.RestoreValue
  }

> main.qml:141
> +icon.name: "list-add"
> +text: i18n("Add application...")
> +onClicked: {

I know...
I will look into what's the most reliable way of deleting things...

> metadata.desktop:4
> +
> +Comment=Global Keyboard Shortcuts
> +

It's the same as in the main desktop file. What will be the user visible one?

> shortcutsmodel.cpp:298
> +{
> +   if (!checkIndex(index) || !index.parent().isValid())  {
> +return;

I think that's wrong way round here

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28818: Identify output according to current applied position, not an unapplied position

[David Edmundson]

davidedmundson added a comment.


  Seems very sensible. +1
  
  Note that kscreen has a commit message schema different to every other KDE 
policy. See CONTRIBUTING.md at the root level.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

To: bport, #plasma, meven, ervin
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre updated this revision to Diff 80074.
davidre marked 33 inline comments as done.
davidre added a comment.


  Minor things and codestyle

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28744?vs=79940=80074

BRANCH
  kcmkeys2 (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28744

AFFECTED FILES
  kcms/keys/CMakeLists.txt
  kcms/keys/ChangeLog
  kcms/keys/Messages.sh
  kcms/keys/README
  kcms/keys/export_scheme_dialog.cpp
  kcms/keys/export_scheme_dialog.h
  kcms/keys/export_scheme_dialog.ui
  kcms/keys/filteredmodel.cpp
  kcms/keys/filteredmodel.h
  kcms/keys/globalshortcuts.cpp
  kcms/keys/globalshortcuts.h
  kcms/keys/kcm_keys.cpp
  kcms/keys/kcm_keys.desktop
  kcms/keys/kcm_keys.h
  kcms/keys/keys.desktop
  kcms/keys/kglobalshortcutseditor.cpp
  kcms/keys/kglobalshortcutseditor.h
  kcms/keys/kglobalshortcutseditor.ui
  kcms/keys/package/contents/ui/ShortcutActionDelegate.qml
  kcms/keys/package/contents/ui/main.qml
  kcms/keys/package/metadata.desktop
  kcms/keys/select_application.ui
  kcms/keys/select_scheme_dialog.cpp
  kcms/keys/select_scheme_dialog.h
  kcms/keys/select_scheme_dialog.ui
  kcms/keys/shortcutsmodel.cpp
  kcms/keys/shortcutsmodel.h

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[José JORGE]

jjorge added a comment.


  In D28127#647747 , @ahiemstra 
wrote:
  
  > Seems fine to me now. You didn't have a developer account right?
  
  
  Yes, I don't.

REPOSITORY
  R106 KSysguard

BRANCH
  acpi-energy

REVISION DETAIL
  https://phabricator.kde.org/D28127

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre added inline comments.

INLINE COMMENTS

> shortcutsmodel.h:59
> +friend FilteredShortcutsModel;
> +enum Roles {
> +SectionRole = Qt::UserRole,

Nevermind it goes through data, apparently I forgot that I changed that :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre marked an inline comment as done.
davidre added inline comments.

INLINE COMMENTS

> shortcutsmodel.h:59
> +friend FilteredShortcutsModel;
> +enum Roles {
> +SectionRole = Qt::UserRole,

It does in filterAcceptRows to not have to go through data each time

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: broulik, davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> output_identifier.cpp:58
>  if (!rootObj) {
>  continue;
>  }

view leaks, no? I see it's not a problem in this patch.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, meven, ervin
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[David Edmundson]

davidedmundson added a comment.


  Technically this introduces a visual change.
  
  Dialog draws a border and shadow by default which appears outside our red 
border from the QML.
  
  I'm pretty sure you can disable it in Dialog, but frankly this looks way 
better so maybe it's a feature.

INLINE COMMENTS

> output_identifier.cpp:58
>  if (!rootObj) {
>  continue;
>  }

Not part of your change, but we would leak view here.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, meven, ervin
Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28783: krunner: polish placement

[Aleix Pol Gonzalez]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:c963fe873f7c: krunner: polish placement (authored by 
apol).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28783?vs=80036=80091

REVISION DETAIL
  https://phabricator.kde.org/D28783

AFFECTED FILES
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  krunner/view.cpp

To: apol, #plasma, cblack, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28744: Rewrite of the global shortcuts kcm

[David Redondo]

davidre edited subscribers, added: davidedmundson; removed: crossi.
davidre added a comment.


  Answering general comments first:
  
  In D28744#647378 , @ngraham wrote:
  
  > - When a shortcut is to launch an app, and that shortcut's name would be 
identical to the app name, maybe we should automatically change it to "Launch 
[app name]. Otherwise you get this following: F8234080: 
Screenshot_20200413_094908.png 
  
  
  I think that's what the old kcm did. It changed the friendly name to "Launch 
$app" which then would be saved if you changed the shortcut in the old kcm. 
That's why there is currently a mixture between "$app" and "Launch $app"...
  But we can change displayed name here, too.
  
  > - I'm seeing some duplicate entries here, and some with missing icons that 
aren't missing in the current version: F8234212: Screenshot_20200413_114058.png 

  
  The KDE Daemon ones are expected. They are different components with 
different unique identifiers that set the same display name (Probably to force 
the old kcm to merge them?). What I would like to happen is that we give them 
each a fitting name and they seperate. They are different modules after all. 
kcm_touchpad (the one with the touchpad icon) should call itself "Touchpad" for 
example. 
  Hmm I don't know about "Power Managment" wasn't their some fallout when d_ed 
ported shortcuts for that but I may be remembering wrong. Do you have these 
modules on dbus too or is it an error in the model? Try `qdbus --literal 
org.kde.kglobalaccel /kglobalaccel org.kde.KGlobalAccel.allMainComponents` or 
take a look in qdbusviewer
  Interested to hear which ones lost their icon compared to the old one.
  
  In D28744#647505 , @nicolasfella 
wrote:
  
  > I always get two horizontal scrollbars, no matter the window size:
  >  F8234349: Screenshot_20200413_212457.png 

  
  
  Not sure what's going on here but I had to 
  ColumnLayout{height: root.availableHeight - Kirigami.Units.smallSpacing 
to not get a vertical scrollbar. Probably `anchors.fill: parent`  works better. 
I will change to that
  
  > The first Choqok shortcut is missing a name, not sure if that's an issue 
here or in Choqok
  >  F8234357: Screenshot_20200413_212731.png 

  
  The action doesn't have a name 
https://lxr.kde.org/source/extragear/network/choqok/choqok/mainwindow.cpp#0215 
. But thanks for the reminder to have a fallback here
  
  In D28744#647507 , @nicolasfella 
wrote:
  
  > When I open the KCM and type 'Krun' + Enter I find KRunner as expected, but 
I still need to click on the KRunner item to actually see the shortcuts. When I 
then type 'Yaku' + Enter Yakuake is shown correctly in the results, but 
clicking on the entry does not show its shortcuts
  
  
  And the comment to always have something in the main view from @ngraham. I 
had some problems with loading and when I update the rootIndex of the 
DelegateModel that causes the issue you are seeing above and prevented me from 
having for example the first element selected when the kcm is openend. I will 
look into how I can make it better.

INLINE COMMENTS

> kcm_keys.desktop:2
>  [Desktop Entry]
> -Exec=kcmshell5 keys
> +Exec=kcmshell5 kcm_keys
>  Icon=preferences-desktop-keyboard-shortcut

From reading 
https://api.kde.org/frameworks/kdeclarative/html/classKQuickAddons_1_1ConfigModule.html
 I thought it had to be kcm_$(something) but I'm not sure now.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28744

To: davidre, #vdg, #plasma
Cc: davidedmundson, nicolasfella, ngraham, iasensio, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart, crossi

D28744: Rewrite of the global shortcuts kcm

[Kai Uwe Broulik]

broulik added a comment.


  Very nice!
  I really like the default shortcuts with checkboxes with additional ones to 
the right.

INLINE COMMENTS

> filteredmodel.cpp:40
> +const QModelIndex index = sourceModel()->index(source_row, 0, 
> source_parent);
> +bool displayMatches = 
> index.data(Qt::DisplayRole).toString().contains(m_filter, 
> Qt::CaseInsensitive);
> +if (!source_parent.isValid() || displayMatches) {

`const bool`

> filteredmodel.cpp:41
> +bool displayMatches = 
> index.data(Qt::DisplayRole).toString().contains(m_filter, 
> Qt::CaseInsensitive);
> +if (!source_parent.isValid() || displayMatches) {
> +return displayMatches;

Why this `!source_parent.isValid()` check?

> filteredmodel.cpp:45
> +
> +if (index.parent().data(Qt::DisplayRole).toString().contains(m_filter, 
> Qt::CaseInsensitive)) {
> +return true;

Shouldn't recursive filtering take care of this?

> filteredmodel.cpp:50
> +const auto  = 
> index.data(ShortcutsModel::DefaultShortcutsRole);
> +for (const auto& shortcut : 
> defaultShortcuts.value>()) {
> +if (shortcut.toString(QKeySequence::NativeText).contains(m_filter, 
> Qt::CaseInsensitive)) {

Put the `.value>` in the line above outside the `for`

> filteredmodel.h:26
> +
> +class FilteredShortcutsModel : public QSortFilterProxyModel {
> +Q_OBJECT

Coding style, `{` on next line

> filteredmodel.h:32
> +public:
> +FilteredShortcutsModel(QObject *parent);
> +

`explicit`

> filteredmodel.h:34
> +
> +bool filterAcceptsRow(int source_row, const QModelIndex & source_parent) 
> const override;
> +

Coding style: `const QModelIndex _parent`

> kcm_keys.cpp:51
> +KAboutData *about = new KAboutData(QStringLiteral("kcm_keys"), 
> i18n("Global Shortcuts"),
> +QStringLiteral("1.0"), QString(), KAboutLicense::GPL);
> +about->addAuthor(i18n("David Redondo"), QString(), 
> QStringLiteral("k...@david-redondo.de"));

I guess this can be 2.0 at this point :)

> kcm_keys.cpp:106
> +{
> +  return m_lastError;
> +}

Not a huge fan of this `lastError` bookkeeping in the KCM

> kcm_keys.cpp:153
> +{
> +auto dialog = new KOpenWithDialog;
> +dialog->hideRunInTerminal();

Set a transient parent on the dialog like so:

  void KCMKeys::addApplication(QQuickItem *ctx)
  {
  auto *dialog = new KOpenWithDialog;
  if (ctx && ctx->window()) {
  dialog->winId(); // so it creates windowHandle
  
dialog->windowHandle()->setTransientParent(QQuickRenderControl::renderWindowFor(ctx->window()));
  dialog->setWindowModality(Qt::WindowModal);
  }
  ...
  }

Then call in QML like `onClicked: kcm.addApplication(this)`

Also, you might want to set `dialog->setAttribute(Qt::WA_DeleteOnClose);` so 
you don't need to `deleteLater()` yourself.

(I believe the `QQuickRenderControl` use may not be necessary when in the same 
process but I recall it behaving funky in `QQuickWidget` in some cases on 
Wayland otherwise)

> kcm_keys.cpp:159
> +const KService::Ptr service = dialog->service();
> +QString desktopFileName = service->entryPath().split('/').last();
> +if (m_shortcutsModel->match(m_shortcutsModel->index(0, 0), 
> ShortcutsModel::ComponentRole, desktopFileName).isEmpty()) {

Perhaps use `KService::desktopEntryName`

> kcm_keys.h:51
> +Q_INVOKABLE void loadScheme(const QUrl );
> +Q_INVOKABLE QVariantList defaultSchemes();
> +

`const`

> kcm_keys.h:54
> +Q_INVOKABLE void addApplication();
> +Q_INVOKABLE QString keySequenceToString(const QKeySequence );
> +

I presume `QKeySequence` is opaque to QML? Also, `const`

> ShortcutActionDelegate.qml:30
> +property int oldHeight: height
> +sourceComponent: ListView.isCurrentItem ? editRepresentation : 
> compactRepresentation
> +ListView.onIsCurrentItemChanged: {

I find the transition between editing and display state somewhat jarring

> ShortcutActionDelegate.qml:58
> +if (model.activeShortcuts.length != 0) {
> +return model.display + ": " + 
> model.activeShortcuts.map(s => kcm.keySequenceToString(s)).join(", ")
> +} else {

Please use `i18n`

> main.qml:33
> +enabled: kcm.lastError == ""
> +property bool exportActive: exportInfo.visible
> +ColumnLayout{

This appears to loop? `exportInfo`'s `visible` is bound to this

> main.qml:34
> +property bool exportActive: exportInfo.visible
> +ColumnLayout{
> +// otherwise we get scrollbars

Coding style: `ColumnLayout {`

> main.qml:36
> +// otherwise we get scrollbars
> +height: root.availableHeight - Kirigami.Units.smallSpacing
> +width: root.availableWidth

Huh?

> main.qml:40
> +Layout.fillWidth: true
> +visible:  kcm.lastError !=  ""
> +text: kcm.lastError

Coding style, also `!==`

> main.qml:53
> +enabled: exportWarning.visible
> +function 

D28467: Converted to Page with a PlasmoidHeading in the heading

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> niccolove wrote in FullRepresentation.qml:31
> I though that was done by
> 
>   toolbar.visible = (state == "DevicesState" || state == "NoDevicesState");
> 
> At the end of the file. If you try to use the widget standalone, you will 
> notice that it does disappear. Problem is, system tray doesn't notice. I 
> can't understand why it doesn't read the ".visible" property.

It's because the binding is broken.

In QML, there are two ways to change a property: with a binding, or 
imperatively.

A binding uses a colon, and looks like this: `visible: (state == "DevicesState" 
|| state == "NoDevicesState")` You want to use binding as much as possible 
because the property being bound (`visible`) will auto-update when the 
condition changes.

Imparative code uses an equals sign: `toolbar.visible = (state == 
"DevicesState" || state == "NoDevicesState");`

This breaks any existing bindings, which means you become responsible for 
manually updating the property in question `toolbar.visible` whenever you want 
it to change. Theoretically that's taken care of by `onStateChanged:` but for 
some reason it doesn't seem to be working. Perhaps there's a state not 
accounted for there? In general I don't like using explicit `State`s though. I 
find that it leads to messy, imperative code.

REPOSITORY
  R97 Bluedevil

REVISION DETAIL
  https://phabricator.kde.org/D28467

To: niccolove, #plasma, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28821: [Notifier] Port from KRun::runCommand

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R134:53375168eb03: [Notifier] Port from KRun::runCommand 
(authored by broulik).

REPOSITORY
  R134 Discover Software Store

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28821?vs=80097=80101

REVISION DETAIL
  https://phabricator.kde.org/D28821

AFFECTED FILES
  notifier/CMakeLists.txt
  notifier/DiscoverNotifier.cpp

To: broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28817: fix (kcm): correct output identifier position on wayland

[David Edmundson]

davidedmundson accepted this revision.
davidedmundson added a comment.


  Using the protocol makes sense, using a class that does it already makes more 
sense than duplicating/
  
  Especially as the other OSD is already a dialog.
  
  From a plasma side, ship it

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 80112.
ngraham added a comment.


  Rebase

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28321?vs=78594=80112

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28321

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/ActionItem.qml
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  applets/notifications/package/contents/ui/NotificationItem.qml
  dataengines/soliddevice/soliddeviceengine.cpp
  krunner/CMakeLists.txt
  krunner/krunner.desktop.cmake
  krunner/view.cpp
  libnotificationmanager/jobsmodel.cpp
  libnotificationmanager/jobsmodel.h
  libnotificationmanager/notifications.cpp
  libnotificationmanager/notificationsmodel.cpp
  libnotificationmanager/notificationsmodel.h
  libnotificationmanager/utils.cpp
  libnotificationmanager/utils_p.h

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 80113.
ngraham added a comment.


  Rebase correctly

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28321?vs=80112=80113

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28321

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/ActionItem.qml
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  dataengines/soliddevice/soliddeviceengine.cpp

To: ngraham, #vdg, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Roman Gilg]

romangg added a comment.


  Please explain your solution in the summary. I don't directly understand how 
this change fixes the bug. Thanks.

INLINE COMMENTS

> CMakeLists.txt:32
>  KF5::QuickAddons
> +KF5::PlasmaQuick
>  KF5::Screen

lexicographic order

> output_identifier.cpp:69
>  if (config->supportedFeatures() & 
> KScreen::Config::Feature::PerOutputScaling) {
> -// no scale adjustment needed on Wayland
> -logicalSize = deviceSize;
> +// no scale adjustment needed on Wayland, we use logicalSize
> +logicalSize = output->logicalSize().toSize();

When you're at it correct the grammar.

> output_identifier.h:24
>  
> -class QQuickView;
> +namespace PlasmaQuick {
> +class Dialog;

style

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, romangg
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28821: [Notifier] Port from KRun::runCommand

[Kai Uwe Broulik]

broulik created this revision.
broulik added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Use `ApplicationLauncherJob` for launching the main application and 
`CommandLauncherJob` for launching the updater.
  This also gives us a nice startup feedback for both cases now.
  The `KService::serviceByDesktopName` could in theory return `null` but imho 
that would be severely broken if we have the updater running but rest of 
Discover is absent.

TEST PLAN
  - "Show Discover" opens discover "recommendations"
  - "View updates" opens update view
  
  Both with a discover bouncy cursor

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D28821

AFFECTED FILES
  notifier/CMakeLists.txt
  notifier/DiscoverNotifier.cpp

To: broulik, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28821: [Notifier] Port from KRun::runCommand

[Aleix Pol Gonzalez]

apol accepted this revision.
apol added a comment.
This revision is now accepted and ready to land.


  Thanks!

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D28821

To: broulik, #plasma, apol
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28822: Create StreamRestore channel if none exists

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added reviewers: Plasma, drosca, broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  We need one channel to be able to control the volume. This restores D7485 
 which was broken by D20450 
 while fixing a different issue.
  This patch tries to combine the two by only creating a new channel if none 
exists and not messing with existing ones.

TEST PLAN
  Can control the notification volume in the KCM now. The slider position 
matches the one in pavucontrol

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volcontrol

REVISION DETAIL
  https://phabricator.kde.org/D28822

AFFECTED FILES
  src/streamrestore.cpp

To: nicolasfella, #plasma, drosca, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: fix(kcm): Identify output according to current applied position, not an unapplied position

[Roman Gilg]

romangg added a comment.


  Header subject and commit message body must have shorter line length in line 
with message guideline. Also note regarding capitalization Angular's subject 
guideline 
.
  
  Also the current description sucks. That's a single sentence with way too 
many words and no grammar.
  
  Come on, coding is not only about the code. Be proud of your work and present 
it to us in the way that it deserves.
  
  Also my assumption is you work together with the original reviewers in the 
same company and may have discussed this patch internally already. That's fine 
but note that this project and any other KDE project is not owned by your 
company alone and it's your responsibility in the end to transform your 
internal discussions and the knowledge you gained from that into public 
knowledge available to all members of this community.
  
  That's why a good description, and in the end all of the documentation you do 
when coding, is tremendously important.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

To: bport, #plasma, romangg
Cc: romangg, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: fix (kcm): correct output identifier position on wayland

[Roman Gilg]

romangg added a comment.


  Conceptually makes sense. +1 form me on that. Good solution. Thanks for 
outlining it in the summary.
  
  This patch can land with a fix for the view leak or without. I accept when my 
inline comments are fixed.
  
  @davidedmundson: can you give a quick accept on the solution from PlasmaQuick 
pov?

INLINE COMMENTS

> output_identifier.cpp:54
> +qmlObject->completeInitialization();
> +auto rootObj = qobject_cast(qmlObject->rootObject());
> +view->setMainItem(rootObj);

This part could use some empty lines.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, romangg
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28678: adjust smb kcm size to be sufficient vis a vis headers

[Marco Martin]

mart added a comment.


  In D28678#644926 , @ngraham wrote:
  
  > I really wish that KCMshell didn't add its own scrollview, so we didn't end 
up with issues like this. The KCM itself should be responsible for its own 
layouting needs.
  >
  > Then again I also wish we didn't have KCMshell at all and that opening a 
specific KCM just opened system settings/kinfocenter. It would eliminate this 
entirely class of kcmshell sizing bugs immediately.
  >
  > Oh well, LGTM.
  
  
  I think I'll take a look into that (i mean, replacing kcmshell with 
systemsettings)

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D28678

To: sitter, ngraham
Cc: mart, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28817: fix (kcm): correct output identifier position on wayland

[Benjamin Port]

bport updated this revision to Diff 80121.
bport added a comment.


  Fix import order (remove unused one)
  Remove QTimer m_timer (field not used). Let me know if you want this one in a 
separate commit.

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80120=80121

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28714: Refactor enableBluetooth function

[Nicolas Fella]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:c13704192284: Refactor enableBluetooth function (authored 
by nicolasfella).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28714?vs=79742=80123

REVISION DETAIL
  https://phabricator.kde.org/D28714

AFFECTED FILES
  libs/handler.cpp

To: nicolasfella, #plasma, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28656: KCM LookAndFeel check if splash screen is provided before applying it.

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.


  LGTM. Stable branch-worthy, probably.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28656

To: crossi, #plasma, ervin, bport, meven, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: fix(kcm): show output ids in reference to currently applied config

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:544a7c14946a: fix(kcm): show output ids in reference to 
currently applied config (authored by bport).

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28818?vs=80086=80126

REVISION DETAIL
  https://phabricator.kde.org/D28818

AFFECTED FILES
  kcm/config_handler.h
  kcm/kcm.cpp

To: bport, #plasma, romangg
Cc: romangg, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: fix (kcm): correct output identifier position on wayland

[Benjamin Port]

This revision was automatically updated to reflect the committed changes.
Closed by commit R104:538116fd1096: fix (kcm): correct output identifier 
position on wayland (authored by bport).

CHANGED PRIOR TO COMMIT
  https://phabricator.kde.org/D28817?vs=80121=80125#toc

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80121=80125

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28830: Don't set a custom palette if we have the same palette as the currently active one

[David Redondo]

davidre created this revision.
davidre added a reviewer: broulik.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidre requested review of this revision.

REVISION SUMMARY
  Caused some icons not be colored correctly

TEST PLAN
  Close KWrite with unsaved changes, all icons should be colored correctly

REPOSITORY
  R31 Breeze

BRANCH
  ffs (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28830

AFFECTED FILES
  kstyle/breezehelper.cpp

To: davidre, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27786: [notifications] Read appname from desktop file if no appname set

[Nicolas Fella]

nicolasfella marked an inline comment as done.
nicolasfella added a comment.


  ping?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27786

To: nicolasfella, #plasma, broulik
Cc: crossi, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28818: fix(kcm): show output ids in reference to currently applied config

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  I changed up the description a bit more (line length!). Please make sure to 
push with arc so it fetches this description for the commit message.
  
  Code change makes sense. Thanks for the fix.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

To: bport, #plasma, romangg
Cc: romangg, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: fix (kcm): correct output identifier position on wayland

[Benjamin Port]

bport updated this revision to Diff 80120.
bport added a comment.


  fix leak and style

REPOSITORY
  R104 KScreen

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28817?vs=80090=80120

REVISION DETAIL
  https://phabricator.kde.org/D28817

AFFECTED FILES
  kcm/CMakeLists.txt
  kcm/output_identifier.cpp
  kcm/output_identifier.h

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28817: fix (kcm): correct output identifier position on wayland

[Roman Gilg]

romangg accepted this revision.
romangg added a comment.
This revision is now accepted and ready to land.


  Thanks. Some minor remaining nitpicks you can change on push.

INLINE COMMENTS

> output_identifier.cpp:28
> +#include 
> +#include 
>  

Lexicographical order. Also add an empty line to differentiate include groups:

  #include 
  #include 
  #include 
  #include 
  
  #include 
  #include 

> output_identifier.cpp:72
>  if (config->supportedFeatures() & 
> KScreen::Config::Feature::PerOutputScaling) {
> -// no scale adjustment needed on Wayland
> -logicalSize = deviceSize;
> +// Scale adjustment is not needed on Wayland, we use logical 
> size"
> +logicalSize = output->logicalSize().toSize();

You wanted to add a `.` but it became a `"`

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28829: Touchpad kcm: On X11 hide scroll speed as it is not supported

[Méven Car]

meven created this revision.
meven added reviewers: KWin, davidedmundson.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
meven requested review of this revision.

REVISION SUMMARY
  BUG: 420079

TEST PLAN
  Tested locally

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28829

AFFECTED FILES
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/kcm/libinput/touchpad.qml

To: meven, #kwin, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: fix (kcm): correct output identifier position on wayland

[Roman Gilg]

romangg added a comment.


  Yes, please put the m_timer removal in a separate patch. And if you removed 
the m_timer the QTimer include in the header file can be removed as well I 
assume. Thanks.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, romangg, davidedmundson
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:4c6c5638ef15: Add some new battery sensors : energy_now, 
energy_full and power_now. (authored by jjorge, committed by ngraham).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28127?vs=79665=80124

REVISION DETAIL
  https://phabricator.kde.org/D28127

AFFECTED FILES
  ksysguardd/Linux/acpi.c
  ksysguardd/Linux/acpi.h

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28127: Add some new battery sensors : energy_now, energy_full and power_now.

[Nathaniel Graham]

ngraham added a comment.


  I've landed this for you.
  
  Keep up the great work!

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D28127

To: jjorge, #plasma, davidedmundson, ahiemstra
Cc: ngraham, anthonyfieroni, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28822: Create StreamRestore channel if none exists

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  OMG you fixed it! Works for me.
  
  Would be great to get this into the stable branch.

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  volcontrol

REVISION DETAIL
  https://phabricator.kde.org/D28822

To: nicolasfella, #plasma, drosca, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28832: Avoid creating subwindow on internal page widget

[Harald Sitter]

sitter accepted this revision.
sitter added a comment.
This revision is now accepted and ready to land.


  I am kind of thinking the cast should be asserted or if'd. But I suppose that 
doesn't add much over just letting it crash on the null dereference.

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28832

To: davidedmundson, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28833: [kcm/toucpad] Simplify directory structure

[Nicolas Fella]

nicolasfella created this revision.
nicolasfella added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
nicolasfella requested review of this revision.

REVISION SUMMARY
  There's no need for yet another directory in between. Also removes some 
redundant cmake code

TEST PLAN
  builds

REPOSITORY
  R119 Plasma Desktop

BRANCH
  touchpad

REVISION DETAIL
  https://phabricator.kde.org/D28833

AFFECTED FILES
  kcms/touchpad/CMakeLists.txt
  kcms/touchpad/applet/CMakeLists.txt
  kcms/touchpad/applet/dataengine.desktop
  kcms/touchpad/applet/qml/contents/ui/touchpad.qml
  kcms/touchpad/applet/qml/metadata.desktop
  kcms/touchpad/applet/touchpad.operations
  kcms/touchpad/applet/touchpad.svg
  kcms/touchpad/applet/touchpadengine.cpp
  kcms/touchpad/applet/touchpadengine.h
  kcms/touchpad/applet/touchpadservice.cpp
  kcms/touchpad/applet/touchpadservice.h
  kcms/touchpad/backends/kwin_wayland.cmake
  kcms/touchpad/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/backends/libinputcommon.cpp
  kcms/touchpad/backends/libinputcommon.h
  kcms/touchpad/backends/x11.cmake
  kcms/touchpad/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/backends/x11/libinputtouchpad.h
  kcms/touchpad/backends/x11/listdevices.cpp
  kcms/touchpad/backends/x11/propertyinfo.cpp
  kcms/touchpad/backends/x11/propertyinfo.h
  kcms/touchpad/backends/x11/synapticstouchpad.cpp
  kcms/touchpad/backends/x11/synapticstouchpad.h
  kcms/touchpad/backends/x11/xcbatom.cpp
  kcms/touchpad/backends/x11/xcbatom.h
  kcms/touchpad/backends/x11/xlibbackend.cpp
  kcms/touchpad/backends/x11/xlibbackend.h
  kcms/touchpad/backends/x11/xlibnotifications.cpp
  kcms/touchpad/backends/x11/xlibnotifications.h
  kcms/touchpad/backends/x11/xlibtouchpad.cpp
  kcms/touchpad/backends/x11/xlibtouchpad.h
  kcms/touchpad/backends/x11/xrecordkeyboardmonitor.cpp
  kcms/touchpad/backends/x11/xrecordkeyboardmonitor.h
  kcms/touchpad/kcm/kcm_touchpad.desktop
  kcms/touchpad/kcm/libinput/touchpad.qml
  kcms/touchpad/kcm/libinput/touchpadconfiglibinput.cpp
  kcms/touchpad/kcm/libinput/touchpadconfiglibinput.h
  kcms/touchpad/kcm/resources.qrc
  kcms/touchpad/kcm/touchpadconfigcontainer.cpp
  kcms/touchpad/kcm/touchpadconfigcontainer.h
  kcms/touchpad/kcm/touchpadconfigplugin.cpp
  kcms/touchpad/kcm/touchpadconfigplugin.h
  kcms/touchpad/kcm/xlib/customconfigdialogmanager.cpp
  kcms/touchpad/kcm/xlib/customconfigdialogmanager.h
  kcms/touchpad/kcm/xlib/customslider.cpp
  kcms/touchpad/kcm/xlib/customslider.h
  kcms/touchpad/kcm/xlib/sliderpair.cpp
  kcms/touchpad/kcm/xlib/sliderpair.h
  kcms/touchpad/kcm/xlib/testarea.cpp
  kcms/touchpad/kcm/xlib/testarea.h
  kcms/touchpad/kcm/xlib/testbutton.cpp
  kcms/touchpad/kcm/xlib/testbutton.h
  kcms/touchpad/kcm/xlib/touchpad.kcfg
  kcms/touchpad/kcm/xlib/touchpadconfigxlib.cpp
  kcms/touchpad/kcm/xlib/touchpadconfigxlib.h
  kcms/touchpad/kcm/xlib/touchpadparameters.kcfgc
  kcms/touchpad/kcm/xlib/touchpadparametersbase.cpp
  kcms/touchpad/kcm/xlib/touchpadparametersbase.h
  kcms/touchpad/kcm/xlib/ui/kded.ui
  kcms/touchpad/kcm/xlib/ui/pointermotion.ui
  kcms/touchpad/kcm/xlib/ui/scroll.ui
  kcms/touchpad/kcm/xlib/ui/sensitivity.ui
  kcms/touchpad/kcm/xlib/ui/tap.ui
  kcms/touchpad/kcm/xlib/ui/testarea.ui
  kcms/touchpad/kded/kcm_touchpad.notifyrc
  kcms/touchpad/kded/kded.cpp
  kcms/touchpad/kded/kded.h
  kcms/touchpad/kded/kded_touchpad.desktop
  kcms/touchpad/kded/kdedactions.cpp
  kcms/touchpad/kded/kdedactions.h
  kcms/touchpad/kded/kdedsettings.kcfgc
  kcms/touchpad/kded/touchpaddaemon.kcfg
  kcms/touchpad/logging.cpp
  kcms/touchpad/logging.h
  kcms/touchpad/plugins.cpp
  kcms/touchpad/plugins.h
  kcms/touchpad/src/CMakeLists.txt
  kcms/touchpad/src/applet/CMakeLists.txt
  kcms/touchpad/src/applet/dataengine.desktop
  kcms/touchpad/src/applet/qml/contents/ui/touchpad.qml
  kcms/touchpad/src/applet/qml/metadata.desktop
  kcms/touchpad/src/applet/touchpad.operations
  kcms/touchpad/src/applet/touchpad.svg
  kcms/touchpad/src/applet/touchpadengine.cpp
  kcms/touchpad/src/applet/touchpadengine.h
  kcms/touchpad/src/applet/touchpadservice.cpp
  kcms/touchpad/src/applet/touchpadservice.h
  kcms/touchpad/src/backends/kwin_wayland.cmake
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandbackend.h
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.cpp
  kcms/touchpad/src/backends/kwin_wayland/kwinwaylandtouchpad.h
  kcms/touchpad/src/backends/libinputcommon.cpp
  kcms/touchpad/src/backends/libinputcommon.h
  kcms/touchpad/src/backends/x11.cmake
  kcms/touchpad/src/backends/x11/libinputtouchpad.cpp
  kcms/touchpad/src/backends/x11/libinputtouchpad.h
  kcms/touchpad/src/backends/x11/listdevices.cpp
  

D28832: Avoid creating subwindow on internal page widget

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  KWallet::openWallet takes a windowId as a parameter.
  
  QWidget->winId() is a dangerous call, it will create an underlying
  platform window when called. This happens even if we're not the toplevel
  widget. On X11 this passed winId must have always been broken, but not
  in a way that caused a problem.
  
  This leaves QtWayland in a very confused state with the side effect that
  all scrolling widgets become broken.
  
  BUG: 418755
  BUG: 420035

TEST PLAN
  Bisected drkonqi till we found the cause
  Verified fix by running crashtest (with some mods so I could report a bug)
  I can't confirm the winId is correct on X11, but the code looks safe

REPOSITORY
  R871 DrKonqi

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28832

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Benjamin Port]

bport added a comment.


  In D28817#647930 , @anthonyfieroni 
wrote:
  
  > In D28817#647912 , @bport wrote:
  >
  > > I don't think we have a leak, on destructor we delete all view
  > >  qDeleteAll(m_views);
  >
  >
  > At that point, when rootObj is nullptr, view is not added to m_views.
  
  
  Indeed...

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, meven, ervin
Cc: davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28818: Identify output according to current applied position, not an unapplied position

[Roman Gilg]

romangg requested changes to this revision.
romangg removed reviewers: meven, ervin.
romangg added a comment.
This revision now requires changes to proceed.


  Message guideline must be adhered. Summary must be more extensive.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28818

To: bport, #plasma, romangg, meven, ervin
Cc: romangg, davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28034: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:b494e08b9bfa: [Applet] Port to ExpandableListItem 
(authored by ngraham).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28034?vs=79981=80096

REVISION DETAIL
  https://phabricator.kde.org/D28034

AFFECTED FILES
  applet/contents/ui/ConnectionItem.qml
  applet/contents/ui/PopupDialog.qml

To: ngraham, #vdg, #plasma, jgrulich
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28034: [Applet] Port to ExpandableListItem

[Nathaniel Graham]

ngraham added a comment.


  Woohoo!

REPOSITORY
  R116 Plasma Network Management Applet

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28034

To: ngraham, #vdg, #plasma, jgrulich
Cc: gvgeo, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28817: Fix KScreen output identifier position on wayland

[Roman Gilg]

romangg requested changes to this revision.
romangg removed reviewers: meven, ervin.
romangg added a comment.
This revision now requires changes to proceed.


  Message guideline must be adhered. Summary must be more extensive.

REPOSITORY
  R104 KScreen

REVISION DETAIL
  https://phabricator.kde.org/D28817

To: bport, #plasma, romangg, meven, ervin
Cc: romangg, davidedmundson, anthonyfieroni, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28703: Make KAccess a regular startup application

[Kai Uwe Broulik]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:6df845ee5373: Make KAccess a regular startup application 
(authored by broulik).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28703?vs=79713=80094

REVISION DETAIL
  https://phabricator.kde.org/D28703

AFFECTED FILES
  kaccess/CMakeLists.txt
  kaccess/kaccess.desktop
  kcms/access/kcmaccess.cpp
  kcms/access/kcmaccess.desktop

To: broulik, #plasma, #plasma_accessibility, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28703: Make KAccess a regular startup application

[Kai Uwe Broulik]

broulik added a comment.


  Autostart doesn't appear to respect that property and I don't think we just 
want to check `KService::noDisplay()` *but* kaccess appears to launch and even 
screen reader works.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28703

To: broulik, #plasma, #plasma_accessibility, davidedmundson
Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28832: Avoid creating subwindow on internal page widget

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R871:262389b1e49b: Avoid creating subwindow on internal page 
widget (authored by davidedmundson).

REPOSITORY
  R871 DrKonqi

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28832?vs=80133=80138

REVISION DETAIL
  https://phabricator.kde.org/D28832

AFFECTED FILES
  src/bugzillaintegration/reportassistantpages_bugzilla.cpp

To: davidedmundson, #plasma, sitter
Cc: sitter, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart