D29380: [System Tray] Always draw the highlight behind the icon

This revision was automatically updated to reflect the committed changes. Closed by commit R120:3f06349549c1: [System Tray] Always draw the highlight behind the icon (authored by filipf). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29356: [applets/systemtray] Fix value read in some onXyxChanged connections

This revision was automatically updated to reflect the committed changes. Closed by commit R120:efe4b603e92f: [applets/systemtray] Fix value read in some onXyxChanged connections (authored by kmaterka). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29386: [systemtray] Fix SNI icon not rendering

kmaterka added a comment. This patch is for "Plasma/5.18" branch only. Can we have it merged before 5.18.5? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29386 To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham Cc: plasma-devel,

D22700: Sync scaling DPI from Plasma to SDDM

guoyunhe added a comment. In D22700#662323 , @filipf wrote: > In D22700#662134 , @guoyunhe wrote: > > > When I press the synchronize button, it looks like the `-dpi 144` (scale x1.5) option makes

D29386: [systemtray] Fix SNI icon not rendering

kmaterka created this revision. kmaterka added reviewers: Plasma: Workspaces, Plasma, davidedmundson, broulik, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. kmaterka requested review of this revision. REVISION SUMMARY In some rare situations SNI icons are

D22700: Sync scaling DPI from Plasma to SDDM

filipf added a comment. In D22700#662134 , @guoyunhe wrote: > When I press the synchronize button, it looks like the `-dpi 144` (scale x1.5) option makes the UI elements huge (feel like x2 scale or more): > > F8280985:

kwallet-pam >= 5.18.4 and ecryptfs homes

Remember to CC me, I'm not subscribed to the list Sadly, a fix i made for Plasma 5.18.4 so that kwallet-pam reads/stores the salt file inside the encrypted home dir (if there is one) means that if you had used kwallet-pam < 5.18.4 and now use kwallet-pam the salt file is not found and your

D29395: Refactor MediaController

cblack created this revision. cblack added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. cblack requested review of this revision. REVISION SUMMARY MediaController is refactored to: 1. make the code easier to read and therefore more

D29394: Add photographic user avatars

filipf created this revision. filipf added reviewers: VDG, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch adds 12 photographic avatars in order to finish work on T9910

D29394: Add photographic user avatars

filipf added a comment. Sources: Basketball: https://www.pexels.com/photo/basketball-net-2169302/ (Pexels licence) Brushes: https://www.pexels.com/photo/abstract-art-artist-artistic-262034/ (CC0 licence) Car: https://www.pexels.com/photo/action-asphalt-auto-racing-automobile-274974

D29394: Add photographic user avatars

filipf added a comment. The permissions are wrong if we do `sudo make install` (the photos folder ends up being root owned). But it doesn't show up with `make install` either. Will investigate more in the morning. REPOSITORY R128 User Manager REVISION DETAIL

D29393: Use player "poster" as album cover if available

broulik created this revision. broulik added reviewers: Plasma, fvogt, ognarb. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Media Sessions artwork takes precedence, if set. TEST PLAN Not sure how useful

D29394: Add photographic user avatars

ngraham added a comment. Love the images! Do they actually show up for you in the KCM though? They don't for me. REPOSITORY R128 User Manager REVISION DETAIL https://phabricator.kde.org/D29394 To: filipf, #vdg, ngraham Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack,

D29395: Refactor MediaController

ngraham added a comment. Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe? F8282138: Screenshot_20200503_202710.png REPOSITORY R120 Plasma

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added reviewers: VDG, Plasma. ngraham added a comment. I agree with the premise that 0.2 steps are much too coarse, and have periodically groused about this myself. However I wonder if 0.05 is too fine? A slider with 41 ticks is screaming out "you used the wrong control for this!"

D29395: Refactor MediaController

trmdi added a comment. In D29395#662576 , @ngraham wrote: > Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe? F8282138:

D25375: Start of the accessibility KCM

ngraham added a comment. Ping? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D25375 To: tcanabrava, ngraham, ervin Cc: broulik, cblack, ervin, ognarb, mart, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen,

D29395: Refactor MediaController

cblack added a comment. In D29395#662576 , @ngraham wrote: > Now the inner image has a greater top margin than bottom margin. Also, could the artist and album be allowed to become two-line strings before eliding, maybe? F8282138:

D29344: [applets/systemtray] Fix invisible plasmoid icons when Media Player is added

ngraham added a comment. 5.19 hasn't branched yet, so code landed in master will still make it there. With this patch, I still see Media Player itself with a blank icon after opening Gwenview. Is that expected? F8282515: Screenshot_20200503_215149.png

D22700: Sync scaling DPI from Plasma to SDDM

guoyunhe added a comment. When I press the synchronize button, it looks like the `-dpi 144` (scale x1.5) option makes the UI elements huge (feel like x2 scale or more): F8280985: IMG_20200503_152810.jpg REPOSITORY R123 SDDM Configuration Panel

D29380: [System Tray] Always draw the highlight behind the icon

filipf updated this revision to Diff 81796. filipf added a comment. move the code change to CurrentItemHighlight.qml REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29380?vs=81785=81796 BRANCH draw-behind-icons (branched from master) REVISION

D29359: Add context for "Automatic" strings

yurchor updated this revision to Diff 81774. yurchor added a comment. Use "comment" instead of "context", fix extracomment according to https://tsdgeos.blogspot.com/2011/05/qt-designer-texts-disambiguation-vs.html REPOSITORY R116 Plasma Network Management Applet CHANGES SINCE LAST

D29366: [Wallpaper Configuration] Remove obsolete inline message concerning widget locking

filipf added a comment. Ok, so the message can indeed still be turned on. Setting: `~/.config/plasmarc [General] immutability=2 (or 4)` ... does not work, however the following does: `~/.config/kdeglobals [KDE Action Restrictions][$i] plasma/plasmashell/unlockedDesktop=false`

D29234: Fix various bugs introduced with heading

niccolove updated this revision to Diff 81791. niccolove added a comment. Fix very long application names REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29234?vs=81750=81791 BRANCH fix_notifications (branched from master) REVISION DETAIL

D29234: Fix various bugs introduced with heading

broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land. INLINE COMMENTS > NotificationItem.qml:118 > +Layout.preferredWidth: notificationHeading.implicitWidth > +id: headingElement > + Put `id` at the top >

D29379: Unassign activity from vault on activity deletion

ivan updated this revision to Diff 81780. CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29379?vs=81779=81780 REVISION DETAIL https://phabricator.kde.org/D29379 AFFECTED FILES kded/service.cpp kded/service.h To: ivan, ngraham Cc: plasma-devel, Orage, LeGast00n,

D29379: Unassign activity from vault on activity deletion

ivan created this revision. ivan added a reviewer: ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ivan requested review of this revision. REVISION SUMMARY CCBUG: 420784 REPOSITORY R845 Plasma Vault BRANCH master REVISION DETAIL

D29380: [System Tray] Always draw the highlight behind the icon

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY There was a slight issue introduced with D28109 : the systray highlight can now cover up the

D29380: [System Tray] Always draw the highlight behind the icon

kmaterka requested changes to this revision. kmaterka added a comment. This revision now requires changes to proceed. The same treatment is needed in `HiddenItemsView` to. Just move `z: -1` to `CurrentItemHighLight` component so that your fix will cover both cases. REPOSITORY R120 Plasma

D29380: [System Tray] Always draw the highlight behind the icon

kmaterka accepted this revision. kmaterka added a comment. This revision is now accepted and ready to land. OK, accepted REPOSITORY R120 Plasma Workspace BRANCH draw-behind-icons (branched from master) REVISION DETAIL https://phabricator.kde.org/D29380 To: filipf, kmaterka, #plasma

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

alex updated this revision to Diff 81801. alex added a comment. Formatting REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29384?vs=81800=81801 BRANCH append_runner_service_file (branched from master) REVISION DETAIL

D29384: KCM Runners: Use setAppendServiceFile method for plugin selector

alex created this revision. alex added reviewers: Plasma, ngraham, meven. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. alex requested review of this revision. REVISION SUMMARY This is required for T13079: Make runner KCMs easier to use