D28154: Add users KCM

[Nathaniel Graham]

ngraham added a comment.


  Changing a user's avatar and clicking Reset instead of Apply makes the avatar 
display revert to the default avatar (which I remember you telling me isn't 
actually possible), not the previous one. This seems inaccurate because the 
avatar does in fact remain at the last one. It's just the display that's wrong.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R135:f9f3f6ca260a: Use Standard Show/Hide Hidden 
files shortcuts in directory chooser dialog (authored by ngraham).

REPOSITORY
  R135 Integration for Qt applications in Plasma

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29238?vs=81378=82151

REVISION DETAIL
  https://phabricator.kde.org/D29238

AFFECTED FILES
  CMakeLists.txt
  src/platformtheme/kdirselectdialog.cpp

To: ngraham, #plasma, #frameworks, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

[Christoph Feck]

cfeck added a comment.


  Instead of darker, you could use the text color with very small alpha.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D28154: Add users KCM

[Nathaniel Graham]

ngraham added a subscriber: mart.
ngraham added a comment.


  Nice, that fixes the last of the avatar issues that I can find.
  
  After you add icons to the items in the keep/delete menu and make it close it 
with a click outside the menu, I think I'll be done reviewing the UI--other 
than the multi-column sizing bug that I'd like @mart to take a look at (video 
#1 in D28154#663205 ). Nice work.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29081: [QStyle] Make menu titles look less like menu items

[Noah Davis]

ndavis added a comment.


  In D29081#665226 , @cblack wrote:
  
  > In D29081#665203 , @ndavis wrote:
  >
  > > Big +1 to the idea, but this shouldn't use `darker()` because that won't 
look right in Breeze Dark.
  >
  >
  > Personally, I think this will look fine when always using `darker()`.
  
  
  It's not consistent with how breeze dark normally works though.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82158.
cblack marked 9 inline comments as done.
cblack added a comment.


  Address code and icon feedback

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82150=82158

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28194: Fix loading button icons from qrc

[Kevin Ottens]

ervin added a comment.


  In D28194#632629 , @apol wrote:
  
  > Fixing QIcon would make sense but I'd say getting this in is not the worst 
thing either.
  
  
  I don't think it's QIcon's fault to be honest. The pattern used in several 
places of `(icon.name || icon.source)` doesn't help, it makes the lower layer 
loose the information of an icon specified by name (thus going through theme 
loading) or by URL (thus going through direct loading). Due to that the lower 
layer ends up having code trying to guess in which situation it is.

INLINE COMMENTS

> kquickstyleitem.cpp:182
>  
>  const QVariant icon = m_properties[QStringLiteral("icon")];
>  if (icon.canConvert()) {

Note that this construct is duplicated three times in that file. It really 
calls for having a findIcon like that:

  QIcon KQuickStyleItem::findIcon(const QVariant ) const
  {
  if (iconProp.canConvert()) {
  return iconProp.value();
  } else if (iconProp.canConvert()) {
  const auto iconId = iconProp.toString();
  if (iconId.startsWith(QLatin1Char('/')) || 
iconId.startsWith(QStringLiteral(":/"))) {
  return QIcon(iconId);
  } else if (iconId.startsWith(QStringLiteral("file:"))) {
  return QIcon(QUrl(iconId).toLocalFile());
  } else if (iconId.startsWith(QStringLiteral("qrc:"))) {
  return QIcon(QLatin1Char(':') + QUrl(iconId).path());
  } else {
  return m_theme->iconFromTheme(iconId, 
m_properties[QStringLiteral("iconColor")].value());
  }
  } else {
  return QIcon();
  }
  }

And then using it for setting opt->icon and opt->currentIcon (combobox case). 
Yes, I did that locally and that definitely helped.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D28194

To: nicolasfella, #plasma, mart, ervin
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham updated this revision to Diff 82140.
ngraham added a comment.


  Rebase

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27845?vs=79514=82140

BRANCH
  iotm-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27845

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: ngraham, #vdg, #plasma
Cc: mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D29466: [applets/appmenu] Add search to global application menu

[Mikhail Zolotukhin]

gikari added a comment.


  Is it possible to integrate the search into the help menu, if it exists 
already or create an entry for it. Much like macOS does.
  F8290151: Screenshot_20200506_214642.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82143.
gikari edited the summary of this revision.
gikari edited the test plan for this revision.
gikari added a comment.


  - Use unique_ptr for buttons
  - Propagate events to buttons
  
  Things to do:
  
  - Figure out why does this only work with some decorations (hello and sierra 
breeze enchanced) and for some does not (breeze, plastic, particially oxygen)
  - Properly scale images into Pixmap
  - Consider exporting in SVG
  - Write CSS into custom gtk css file

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82124=82143

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham added a comment.


  So now with this patch, the new default panel height is 46px. It seems like 
there's still a camp that would prefer a smaller value, though and I don't want 
to steamroll over them. However I agree with @veggero that the 42 and 44px 
sizes look odd given the current icon scaling algorithms, so I'd prefer not to 
use those. I also happen to think that 40 looks odd too, since the Kickoff icon 
is visibly larger than the icons for pinned apps: F8290199: 40.png 

  
  The system tray items do seem to fit the space better with the thinner panel 
though. But I don't think that's a huge deal since tray icons are supposed to 
be small and unobtrusive.
  
  Also from a less technical angle, I think that when using an IOTM, a larger 
effective click area is desirable since the buttons are now much less wide than 
TTM items are. This is especially true for touch use cases, which we need to 
consider since 2-in-1s are a thing. So personally, I think the extra size 
imparted by 46px is useful.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82150.
cblack added a comment.


  Fix faceValid checking

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82137=82150

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82167.
gikari added a comment.


  - Make buttons work with Breeze theme by respecting pallete.

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=82143=82167

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/decorationpalette.cpp
  kded/kwin_bridge/decorationpalette.h
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack created this revision.
cblack added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
cblack updated this revision to Diff 82125.
cblack added a comment.
cblack updated this revision to Diff 82138.
cblack added a dependency: D29486: xdgshellclient: Allow menus from panels to 
take focus.
cblack requested review of this revision.


  Better search

cblack added a comment.


  Fix some quirks

REVISION SUMMARY
  The global application menu has a search field now

TEST PLAN
  F8288104: ksnip_20200505-223308.png 

REPOSITORY
  R120 Plasma Workspace

BRANCH
  cblack/appmenu-search (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29466

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack updated this revision to Diff 82141.
cblack added a comment.


  Add better non-Wayland guards

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29466?vs=82138=82141

BRANCH
  cblack/appmenu-search (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29466

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, #vdg
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack updated this revision to Diff 82144.
cblack added a comment.


  Clear search text on application change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29466?vs=82141=82144

BRANCH
  cblack/appmenu-search (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29466

AFFECTED FILES
  applets/appmenu/lib/appmenuapplet.cpp
  applets/appmenu/plugin/CMakeLists.txt
  applets/appmenu/plugin/appmenumodel.cpp
  applets/appmenu/plugin/appmenumodel.h

To: cblack, #plasma, #vdg
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

[Niccolò Venerandi]

niccolove accepted this revision as: niccolove.
niccolove added a comment.
This revision is now accepted and ready to land.


  VDG wise, this looks good and consistent.

REPOSITORY
  R31 Breeze

BRANCH
  menu-title-looks-less-like-a-menu-item (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove
Cc: niccolove, broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

[Nathaniel Graham]

ngraham planned changes to this revision.
ngraham added a comment.


  I messed up the rounded top corner too. Will revise.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

[Carson Black]

cblack added a comment.


  In D29081#665203 , @ndavis wrote:
  
  > Big +1 to the idea, but this shouldn't use `darker()` because that won't 
look right in Breeze Dark.
  
  
  Personally, I think this will look fine when always using `darker()`.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cblack, cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

D29466: [applets/appmenu] Add search to global application menu

[Carson Black]

cblack added a comment.


  In D29466#665145 , @gikari wrote:
  
  > Is it possible to integrate the search into the help menu, if it exists 
already or create an entry for it. Much like macOS does.
  >  F8290151: Screenshot_20200506_214642.png 

  
  
  There's no reliable way to figure out which menu is the "help" one, and 
there's not a reliable way of modifying a menu for this kind of functionality 
besides appending a new entry to the end.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29466

To: cblack, #plasma, #vdg
Cc: gikari, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

[Noah Davis]

ndavis requested changes to this revision.
ndavis added a comment.
This revision now requires changes to proceed.


  Big +1 to the idea, but this shouldn't use `darker()` because that won't look 
right in Breeze Dark.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29081: [QStyle] Make menu titles look less like menu items

[Christoph Feck]

cfeck added a comment.


  What a small difference that makes such a large difference!

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29081

To: ngraham, #vdg, #breeze, niccolove, ndavis
Cc: cfeck, ndavis, niccolove, broulik, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra, mart

D29467: [applets/batterymonitor] Collapse inhibitions list properly

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:ce6a0ec0aa6a: [applets/batterymonitor] Collapse 
inhibitions list properly (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29467?vs=82047=82157

REVISION DETAIL
  https://phabricator.kde.org/D29467

AFFECTED FILES
  applets/batterymonitor/package/contents/ui/PowerManagementItem.qml

To: ngraham, #plasma, broulik
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82137.
cblack added a comment.


  begone, kule

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82135=82137

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28194: [WIP] Fix loading button icons from qrc

[Nicolas Fella]

nicolasfella updated this revision to Diff 82149.
nicolasfella added a comment.


  - Also handle ':/' prefix

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28194?vs=78197=82149

BRANCH
  qrcicons

REVISION DETAIL
  https://phabricator.kde.org/D28194

AFFECTED FILES
  plugin/kquickstyleitem.cpp

To: nicolasfella, #plasma, mart
Cc: apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham updated this revision to Diff 82142.
ngraham added a comment.


  Round up to nearest even number

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D27845?vs=82140=82142

BRANCH
  iotm-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D27845

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: ngraham, #vdg, #plasma
Cc: mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D29490: This removes the negative top margin, as it's already removed by the NotificationPopup

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:571f0aba2fc5: This removes the negative top margin, as 
its already removed by the… (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29490?vs=82129=82145

REVISION DETAIL
  https://phabricator.kde.org/D29490

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> CMakeLists.txt:16
> +ecm_add_qtwayland_client_protocol(systemclipboard_SRCS
> +PROTOCOL  
> /home/david/projects/kde5/src/kde/workspace/kwayland-server/src/protocols/wlr-data-control-unstable-v1.xml
> +BASENAME wlr-data-control-unstable-v1

I don't seem to have your home directory on my system :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: ngraham, cblack, apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Nathaniel Graham]

ngraham created this revision.
ngraham added reviewers: VDG, Plasma.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
ngraham requested review of this revision.

REVISION SUMMARY
  D27845  seems to have turned into a 
compromise that nobody is happy with, so I'd like to
  propose a bold alternative to it that in my opinion is superior and fully 
implements the
  proposal from T12441 : put the default 
panel on the left, thicken it, and use an an IOTM
  pre-populated with apps.
  
  This yields all of the benefits brought up in T12441 
. Compared to D27845 
 it allows the
  Panel can be made thicker and therefore display larger, prettier icons 
without feeling
  wasteful of space. A thicker panel makes it more touch-friendly since the 
IOTM buttons
  are larger and closer to the size of a finger. Finally, putting the panel on 
a vertical
  edge is more suitable for typical modern widescreen displays where vertical 
space is more
  scarce than horizontal space.
  
  It's a lot like the arrangement used by Ubuntu's Unity, or their current 
GNOME setup. I
  have been using this arrangement for over two years and I think it's 
fantastic. I also
  see a number of other KDE developers using this exact arrangement or a 
similar one so it
  seems to be reasonably popular and battle-tested already.
  
  If we move forward with this, we will need to fix 
https://bugs.kde.org/show_bug.cgi?id=387775
  or work around it by disabling the default left touch screen edge or move it 
a different
  edge. We would also want to consider relocating or disabling the current 
top-left
  hotcorner, as it would slightly interfere with the Kickoff button. My 
recommendtation
  would be to move it to the bottom-right corner, to preserve the ability to 
trigger an
  action in every single screen corner without looking, which we have right now.

TEST PLAN
  F8290733: Left panel with IOTM.png 

REPOSITORY
  R119 Plasma Desktop

BRANCH
  left-panel-iotm-by-default (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29501

AFFECTED FILES
  applets/taskmanager/package/contents/config/main.xml
  layout-templates/org.kde.plasma.desktop.defaultPanel/contents/layout.js

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Great. From my perspective this is ready to go! I'd like a #plasma 
 person to review too, and for @mart 
or another #plasma  person to see if 
they can reproduce and help figure out the issue described in the first video 
at D28154#663205 . But that's not a 
hard blocker IMO.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: mart, yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27845: Replace Task Manager with Icons-Only-Task Manager in the default panel, and thicken it

[Nathaniel Graham]

ngraham added a comment.


  Since I'm not feeling a lot of enthusiasm for this patch, I've submitted an 
alternative that fully implements the proposal in T12441 
 with no design compromises: D29501: Use 
left-aligned thickened panel with IOTM populated with some apps by default 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D27845

To: ngraham, #vdg, #plasma
Cc: mart, filipf, kmaterka, gvgeo, davidedmundson, ndavis, niccolove, 
The-Feren-OS-Dev, plasma-devel, Orage, LeGast00n, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra

D29501: Use left-aligned thickened panel with IOTM populated with some apps by default

[Nathaniel Graham]

ngraham added a comment.


  JFYI I know this kind of thing needs a lot of discussion so I'm not gonna 
rush to land it if people accept or offer +1s, so don't be shy about that. :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29501

To: ngraham, #vdg, #plasma
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ngraham wrote in CMakeLists.txt:16
> I don't seem to have your home directory on my system :)

Never mind :)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: ngraham, cblack, apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29469: Icon in system tray missing when WireGuard connection active on startup

[Jan Grulich]

This revision was automatically updated to reflect the committed changes.
Closed by commit R116:040a5c8ce9b0: Icon in system tray missing when WireGuard 
connection active on startup (authored by andersonbruce, committed by jgrulich).

REPOSITORY
  R116 Plasma Network Management Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29469?vs=82052=82053

REVISION DETAIL
  https://phabricator.kde.org/D29469

AFFECTED FILES
  libs/declarative/connectionicon.cpp

To: andersonbruce, jgrulich
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D27669: [kstyle] Tools area

[Noah Davis]

ndavis added a comment.


  Reposting here so that it won't be forgotten. Some windows are lacking the 
underline:
  
  F8288512: Screenshot_20200506_002747.png 

  F8288514: Screenshot_20200506_002908.png 

  
  For some reason, the settings window for KDevelop takes roughly 4x longer to 
load with this patch. I'm not sure why that is and I don't see any suspicious 
messages that seem related to this patch in GDB.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D29234: Fix various bugs introduced with heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 82062.
niccolove added a comment.


  Remove inHistory change

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=82060=82062

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

[Niccolò Venerandi]

niccolove added a comment.


  Sorry, I'll make a different patch for that

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

[Kai Uwe Broulik]

broulik added a comment.


  > I added one last thing
  
  Can we please not mix behavior changes into a patch that fixes bugs and 
regressions.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Re: Information regarding upcoming Gitlab Migration

[Adriaan de Groot]

On 2020 mayula d. 1id 07:08:41 CEST Ben Cooksley wrote:
> On Fri, May 1, 2020 at 2:46 AM Nate Graham  wrote:
> > If I'm understanding things, we have solutions to most or all of the
> > objections raised so far:
> > 
> > - Projects will be allowed to live in--or at least appear in--multiple
> > top-level groups (e.g. plasma-framework could appear in both the
> > Frameworks top-level group and also the Plasma top-level group)
> 
> Projects will have the option to appear in multiple groups yes.

Forgive me for coming full circle on this discussion, but

- a group can have at most one workboard
- a group offers some facilities for managing issues and reviews that cross 
over repositories within that group
- a project (this is one-to-one with "repository", right?) can have as many 
workboards as it likes

If a project can appear in more than one group, isn't the whole distinction 
between flat and namespaced a little .. 

well, how would this proposal fly?

- Put everything in a single group called "kde" (this matches proposal 2 if I 
still remember the original numbering right -- flat, but not at top-level)
- Other groups hold things from "kde" (this matches proposal 3, giving more 
structure / hierarchy)

People browsing *top* level would see group "kde" (for all I care, bookmark 
that one as "I want to browse the list of 1442 repositories") and a bunch of 
logical groups based on how the community organizes itself. People working 
inside a specific group can do their workboardy-things and focus on the 
repositories for that group, while people with an overall interest go to the 
KDE group.



Somehow I get the feeling that we started with some technical limitations 
which were driving particular choices, where those limitations aren't exactly 
what we assumed that they were, and now it looks to me like those limitations 
do not have to meaningfully impact *any* of the choices.

(*if* my understanding is correct; I've been wrong enough times already today)

[ade]

signature.asc
Description: This is a digitally signed message part.

Re: Information regarding upcoming Gitlab Migration

[Adriaan de Groot]

There are a whole bunch of considerations and use-cases being discussed at 
once in this thread, and Leinir's post made me think a bit about different 
actors can interact with "the collection of repositories".

One actor is "tooling", as Albert has pointed out. Whatever the resulting 
structure is, it needs to be communicated to tool authors on time for tools to 
be updated, released, and rolled out for use. Tools mentioned so far:
 - kdesrc-build
 - i18n / scripty
 - release scripts
The tools don't have An Opinion regarding the layout, they just need to be 
updated.

A tool-like actor that I don't think has been mentioned so far is "existing 
checkouts". I have a src/kde with all the bits I've looked at "recently". 
There may even be some SVN checkouts there -- I'm willing to forget about 
those. Surprising and annoying me every time I update those sometime in the 
future is not good, but it's only going to annoy me once (per repo, so at most 
143 times for my clones).

I'd be *vaguely* worried about existing crontabs and automatic jobs that we've 
forgotten about, or which others have forgotten about. Those aren't fixable in 
the face of any changes to repositories, anyway.


Turning to human actors, who are the more interesting ones,

On 2020 prilula d. 28id 10:38:36 CEST Dan Leinir Turthra Jensen wrote:
> On Monday, 27 April 2020 21:25:09 BST Albert Astals Cid wrote:
> > El dilluns, 27 d’abril de 2020, a les 13:58:02 CEST, Bhushan Shah va
> > > On Mon, Apr 27, 2020 at 12:38:42PM +0200, Aleix Pol wrote:
> > > > Does this mean that to clone it we'll have to go "git clone
> > > > kde:games/knetwalk" or something along the lines?

> > > > If that's the case I'd much prefer if we didn't do this, at the moment
> > > > it's already uncomfortable for me to remember the URL for some of the
> > > > repos (e.g. is it sysadmin/ or not?), this will only increase the
> > > > problem and I personally don't see the advantage.


Humans come in all shapes and sizes; here's one called Aleix who likes to 
remember the name of a thing, one single label. (Ironic: this particular Aleix 
is also labelled "Aleix Pol" and possibly "Aleix Pol Gonzales") The question 
I'd ask is "in what **context** do you need to remember the URL of a repo?" 
and for that matter: "why is 'knetwalk' an obvious thing to remember, and 
'games/knetwalk' not-obvious?"

Context here can mean many things. In this thread we've had mentioned:
 - people just browsing and wanting A Big List
   Here a hierarchical approach means more clicks and navigating a tree,
   rather than a flat structure.
 - people browsing for a known label
   Using ^F in a flat list or some search field (see also Ian Wadham's
   message just now) doesn't seem *that* different to me, although I've
   got to give ^F the benefit of speed and simplicity.
 - developers sharing a task list and reviews

.. probably more. Some of these roles have, depending on the chosen solution, 
problems that can be solved with a *technical* addition 
(bigflatlistofrepositories.kde.org .. or whatever), others are going to need a 
social solution.



Personally, I'm with Leinir here:

> Just adding my "i don't use kdesrc-build, and git clone kde:x everything
> myself" voice, here. 

Perhaps it's the "old school", but kdesrc-build doesn't do anything for me. 
I'm intermittently interested in the source of some random part of KDE -- 
generally because it's mentioned on IRC -- and then I need that source where I 
can look at it. Whether it's 'git clone' or 'kdesrc-build --just-the-source-
please' doesn't matter much.

If there's any compiling to be done, the less magic there is between me and 
the compile, the better.

So, yeah: `git clone kde:x` all the way, but I'm also not really invested in 
the structure of the label x, or the precise configuration of kde:.


> Now, if a simple(ish) script can be created to make
> something akin to the kde: rewriting work, even if what it really does is to
> search gitlab and create a clone with the appropriate command, i could deal
> with that, but having the ability to simply ask for the project name is
> more than a little useful.

I think we shouldn't underestimate how names are a social construct, though: 
the current flat structure comes after a structured SVN naming epoch. But I'd 
totes +1 a search-and-redirector, especially if it means I can write `git 
clone kde:peruse` and the resulting .git/config has followed the redirects and 
whatnot and ended up with `url: kdeforreal:audio/peruse`

(That said, bigflatlistofrepositories.kde.org .. or maybe call it cgit.kde.org 
.. could be a particular view onto gitlab which does flattening and search, 
but only if there's people around to create it and maintain it)

[ade]

signature.asc
Description: This is a digitally signed message part.

Re: Information regarding upcoming Gitlab Migration

[Adriaan de Groot]

On 2020 prilula d. 28id 13:35:22 CEST Ben Cooksley wrote:
> Would some form of git alias/custom command script that works similar
> to the following be suitable?
> 
> git kde-clone skrooge
> 
> That script would then search the appropriate groups (ignoring any
> personal repositories including forks), find the necessary repository
> and perform the clone as appropriate for you. Should it find multiple
> results it would output it's results and then exit with a failure
> (giving you names and the clone urls to pick from manually)

That'd actually be pretty cool.

As a standalone script it'd be useful to migrate existing checkouts, so that's 
shooting two birds in one foot. And then you can have a somewhat structured 
namespace, still with simple lookup and unstructured names (until, as Bhushan 
points out in a different message in this thread, you get non-unique labels 
when decomposing structures names).


[ade]


signature.asc
Description: This is a digitally signed message part.

Re: Information regarding upcoming Gitlab Migration

[Michał Policht]

Hi all,

Sorry for late response, but project "cutehmi" fits into "sdk" category 
better than "applications" (technically it's a framework, but I guess 
"frameorks" is reserved for well integrated KDE Frameworks).


Speaking generally on subject, categorization is always problematic. 
Categories often are fuzzy, they overlap, element can match more than 
one type/category/group at the same time and there are many criteria by 
which you could partition a set of elements.


Maybe for future reference, it would be good if there was some 
explanation on how these groups are created. From what I can see large 
projects organized into subprojects have dedicated groups (e.g. plasma, 
kdevelop). There are groups based on project status (e.g. unmaintained, 
historical). Then we have a division, which seems to be based on use 
case from development applicability perspective (e.g. libraries, 
frameworks, sdk). Then we have applications divided into something like 
user interests (e.g. multimedia, games, office, education). Since you 
mention that project may belong to many groups it would be nice to 
clarify, if for example game-oriented library (which occupies 
"libraries") fits into "games" group as well or is "games" group 
reserved for end-user applications only.


Regards
Michał


On 4/27/20 3:40 AM, Bhushan Shah wrote:

[Please keep sysad...@kde.org list or bs...@kde.org in the CC for
replies]

Hello Community members,

In view of upcoming Gitlab migration, we sysadmin team wants to share
the recommended structuring for the repositories on Gitlab.

We had multiple options,

- Flat structure: In this option we would have everything under one
   single namespace/group: https://invent.kde.org/kde/knetwalk
- Subgroups under top-level group: In this option we would have a groups
   under KDE namespace: https://invent.kde.org/kde/games/knetwalk
- Groups at top level: In this option we would establish a series of
   groups at the top level, e.g.  https://invent.kde.org/games/knetwalk

We have discussed this with small but representative group of
contributors or maintainers, and based on their suggestions, we
recommend that we go with option 3. Having sub-groups at top level will
allow us to,

- Provides good visibility on all reviews, tasks and other items within
   the groups/modules we define
- Provides improvements to discoverability of projects
- Makes it possible for groups of projects to establish a group level
   task board should it fit their needs (for tracking a release for
   instance)
- Makes the most semantic sense, as the ‘KDE’ top level group suggested
   in option 2 is duplicative considering the Gitlab instance is under
   kde.org.
- The discoverability of projects is maximised, as there is no need to
   open the top level ‘KDE’ group before going into the subgroup.

I've worked on draft "move" of the current set of the repositories in
their respective subgroups at the repo-metadata project's branch [1].
You can browse the directory structure to get idea of how final
structure on Gitlab would look like.

If we don't have any objections we would like to implement this next
week and move projects to https://invent.kde.org.

Thanks!
Bhushan for sysadmin team

[1] 
https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent

Re: Information regarding upcoming Gitlab Migration

[Piyush Aggarwal]

On Mon, 27 Apr, 2020, 4:09 pm Aleix Pol,  wrote:

> On Mon, Apr 27, 2020 at 3:41 AM Bhushan Shah  wrote:
> >
> > [Please keep sysad...@kde.org list or bs...@kde.org in the CC for
> > replies]
> >
> > Hello Community members,
> >
> > In view of upcoming Gitlab migration, we sysadmin team wants to share
> > the recommended structuring for the repositories on Gitlab.
> >
> > We had multiple options,
> >
> > - Flat structure: In this option we would have everything under one
> >   single namespace/group: https://invent.kde.org/kde/knetwalk
> > - Subgroups under top-level group: In this option we would have a groups
> >   under KDE namespace: https://invent.kde.org/kde/games/knetwalk
> > - Groups at top level: In this option we would establish a series of
> >   groups at the top level, e.g.  https://invent.kde.org/games/knetwalk
> >
> > We have discussed this with small but representative group of
> > contributors or maintainers, and based on their suggestions, we
> > recommend that we go with option 3. Having sub-groups at top level will
> > allow us to,
> >
> > - Provides good visibility on all reviews, tasks and other items within
> >   the groups/modules we define
> > - Provides improvements to discoverability of projects
> > - Makes it possible for groups of projects to establish a group level
> >   task board should it fit their needs (for tracking a release for
> >   instance)
> > - Makes the most semantic sense, as the ‘KDE’ top level group suggested
> >   in option 2 is duplicative considering the Gitlab instance is under
> >   kde.org.
> > - The discoverability of projects is maximised, as there is no need to
> >   open the top level ‘KDE’ group before going into the subgroup.
> >
> > I've worked on draft "move" of the current set of the repositories in
> > their respective subgroups at the repo-metadata project's branch [1].
> > You can browse the directory structure to get idea of how final
> > structure on Gitlab would look like.
> >
> > If we don't have any objections we would like to implement this next
> > week and move projects to https://invent.kde.org.
> >
> > Thanks!
> > Bhushan for sysadmin team
> >
> > [1]
> https://cgit.kde.org/sysadmin/repo-metadata.git/tree/projects-invent?h=bshah/invent
>
> Does this mean that to clone it we'll have to go "git clone
> kde:games/knetwalk" or something along the lines?
>
> If that's the case I'd much prefer if we didn't do this, at the moment
> it's already uncomfortable for me to remember the URL for some of the
> repos (e.g. is it sysadmin/ or not?), this will only increase the
> problem and I personally don't see the advantage.
>
> e.g. Is okular graphics or office? Is gwenview plasma or graphics? Is
> krita graphics or its own thing?
>
> I really prefer when I don't have to guess this kind of things when
> fetching a repository.
>
> Aleix
>

This is technical so I would love to hear Sysadmin team's thoughts on this:
Probably there can be a redirect system that lets us do git clone
kde:knotifications and manages to redirect it to
kde/frameworks/tier3/knotifications.git
So we can clone and tinker with stuff as we normally do while the sysadmin
team goes with the recommended system of setting up the repos.
I think this should be possible because Invent already redirects my URLs
which don't end with .git to .git ones. I might be wrong about my
assumption that both things can work similarly.

Best
Piyush Aggarwal

>

D29234: Fix various bugs introduced with heading

[Niccolò Venerandi]

niccolove requested review of this revision.
niccolove marked 4 inline comments as done.
niccolove added a comment.


  I added one last thing: I feel like it was not a good idea to show the 
heading in history for notifications that are not in group. I added a inHistory 
bool, false by default, that's set true in FullRepresentation for notifications 
that are in history. Heading is not shown for any notification in the history.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29234

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

[Niccolò Venerandi]

niccolove updated this revision to Diff 82060.
niccolove added a comment.


  Address feedback and add inHistory bool

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=81791=82060

BRANCH
  fix_notifications (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29234: Fix various bugs introduced with heading

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:bf6b8353a73f: Fix various bugs introduced with heading 
(authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29234?vs=82062=82065

REVISION DETAIL
  https://phabricator.kde.org/D29234

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationHeader.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, #plasma, broulik
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29475: [Global Shortcuts KCM] Also check PortableText

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, VDG.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Allows to find keyboard shortcuts without knowing the localized key 
designation.

TEST PLAN
  F8288879: Screenshot_20200506_114738.png 


REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D29475

AFFECTED FILES
  kcms/keys/filteredmodel.cpp

To: broulik, #plasma, #vdg
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29474: Add inHistory bool and hide heading on inHistory

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  This hides the plasmoidHeading on history for not grouped notifications

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_heading_for_ungrouped (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29474

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[David Edmundson]

davidedmundson created this revision.
davidedmundson added a reviewer: KWin.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
davidedmundson requested review of this revision.

REVISION SUMMARY
  Wayland has an entire new protocol for getting and setting clipboard
  when we don't have focus. Unfortunately this means reinventing
  QClipboard from the QPA.
  
  Not mergable as-is, especially the hardcoded line in CMakeLists but
  uploaded to show direction.
  
  It uses the newly agreed approach of using QtWayland generated classes
  in clients directly rather than writing full pimpl API-fixed wrappers first, 
  as ultimately that didn't really help do anything.
  
  Code is written so that it can be moved to KWindowSystem if needed by
  KDEConnect or others.

TEST PLAN
  Copying and pasting all over the place

REPOSITORY
  R120 Plasma Workspace

BRANCH
  davidedmundson/clipboard2

REVISION DETAIL
  https://phabricator.kde.org/D29476

AFFECTED FILES
  klipper/CMakeLists.txt
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/systemclipboard.cpp
  klipper/systemclipboard.h
  klipper/tests/CMakeLists.txt
  klipper/tests/paste.cpp

To: davidedmundson, #kwin
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29478: [Clipboard Plasmoid] Port to Prison QML import

[Kai Uwe Broulik]

broulik created this revision.
broulik added reviewers: Plasma, vkrause.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
broulik requested review of this revision.

REVISION SUMMARY
  Which does the rendering and proper sizing for us, e.g. ensure integer 
scaling so the barcode remains scannable.
  While at it, fix `supportsBarcode` (wasn't routed through to the delegate 
component when it was split out) and add Code 128 which is in Prison now.
  Also, show a label when the barcode would become too large to display (mostly 
for the 1D barcodes).

TEST PLAN
  F8288986: Screenshot_20200506_125330.png 

  F8288990: Screenshot_20200506_125433.png 

  F8288987: Screenshot_20200506_125354.png 


REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29478

AFFECTED FILES
  applets/clipboard/contents/ui/BarcodePage.qml
  applets/clipboard/contents/ui/ClipboardItemDelegate.qml
  applets/clipboard/contents/ui/ClipboardPage.qml
  applets/clipboard/contents/ui/DelegateToolButtons.qml
  applets/clipboard/contents/ui/Menu.qml

To: broulik, #plasma, vkrause
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29468: Update preview images for new "Flow" wallpaper

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:54f59eb2bba4: Update preview images for new 
Flow wallpaper (authored by ngraham).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29468?vs=82051=82086

REVISION DETAIL
  https://phabricator.kde.org/D29468

AFFECTED FILES
  lookandfeel/contents/previews/fullscreenpreview.jpg
  lookandfeel/contents/previews/lockscreen.png
  lookandfeel/contents/previews/preview.png
  sddm-theme/preview.png

To: ngraham, #plasma, #vdg, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart updated this revision to Diff 82089.
mart added a comment.


  - default to linechart
  - default to textonly
  - sensorIds highPrioritySensorIds
  - kill table visualization
  - TotalSensor->TotalSensors list
  - SupportsTotalSensor->SupportsTotalSensors

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=81882=82089

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/facepackages/CMakeLists.txt
  faces/facepackages/barchart/contents/config/main.xml
  faces/facepackages/barchart/contents/ui/BarChart.qml
  faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
  faces/facepackages/barchart/contents/ui/Config.qml
  faces/facepackages/barchart/contents/ui/FullRepresentation.qml
  faces/facepackages/barchart/metadata.desktop
  faces/facepackages/linechart/contents/config/main.xml
  faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/linechart/contents/ui/Config.qml
  faces/facepackages/linechart/contents/ui/FullRepresentation.qml
  faces/facepackages/linechart/contents/ui/LineChart.qml
  faces/facepackages/linechart/metadata.desktop
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/FullRepresentation.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml
  faces/facepackages/piechart/metadata.desktop
  faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
  faces/facepackages/textonly/contents/ui/FullRepresentation.qml
  faces/facepackages/textonly/metadata.desktop
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/packagestructure/CMakeLists.txt
  faces/packagestructure/sensorface-packagestructure.json
  faces/packagestructure/sensorfacepackage.cpp
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorInfo_p.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Nicolas Fella]

nicolasfella added a comment.


  Isn't this something that should be in QClipboard in an ideal world? Or is 
that currently not feasible since the protocol is non-standard?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29478: [Clipboard Plasmoid] Port to Prison QML import

[Nathaniel Graham]

ngraham added a comment.


  +1, very nice.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29478

To: broulik, #plasma, vkrause
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28333: Add a new daemon for stats monitoring

[David Edmundson]

This revision was automatically updated to reflect the committed changes.
Closed by commit R106:75333fc13159: Add a new daemon for stats monitoring 
(authored by davidedmundson).

REPOSITORY
  R106 KSysguard

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28333?vs=81871=82105

REVISION DETAIL
  https://phabricator.kde.org/D28333

AFFECTED FILES
  CMakeLists.txt
  kstats/CMakeLists.txt
  kstats/autotests/CMakeLists.txt
  kstats/autotests/main.cpp
  kstats/client.cpp
  kstats/client.h
  kstats/ksysguard_iface.xml
  kstats/ksysguarddaemon.cpp
  kstats/ksysguarddaemon.h
  kstats/main.cpp
  kstats/test/CMakeLists.txt
  kstats/test/README.txt
  kstats/test/main.cpp
  libkstats/AggregateSensor.cpp
  libkstats/AggregateSensor.h
  libkstats/CMakeLists.txt
  libkstats/SensorContainer.cpp
  libkstats/SensorContainer.h
  libkstats/SensorObject.cpp
  libkstats/SensorObject.h
  libkstats/SensorPlugin.cpp
  libkstats/SensorPlugin.h
  libkstats/SensorProperty.cpp
  libkstats/SensorProperty.h
  libkstats/types.h
  plugins/CMakeLists.txt
  plugins/global/ksgrd/CMakeLists.txt
  plugins/global/ksgrd/ksgrdiface.cpp
  plugins/global/ksgrd/ksgrdiface.h
  plugins/global/nvidia/CMakeLists.txt
  plugins/global/nvidia/nvidia.cpp
  plugins/global/nvidia/nvidia.h

To: davidedmundson, #plasma, mart, ngraham, ahiemstra
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82080.
ahiemstra added a comment.


  - Correct Vlad's name in a few more places
  - Make comments in SensorInfo_p.h a bit more useful

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=81577=82080

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82081.
ahiemstra added a comment.


  Urgh arc

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=82080=82081

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D29476: WIP: Port klipper to use wayland clipboard

[Vlad Zahorodnii]

zzag added a comment.


  +1 in general.
  
  > Not mergable as-is, especially the hardcoded line in CMakeLists but 
uploaded to show direction.
  
  Heh, it seems like we now have a good reason to upstream 
FindWaylandProtocols.cmake from KWayland to extra-cmake-modules. :-)

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Aleix Pol Gonzalez]

apol added a comment.


  In D29476#664751 , @nicolasfella 
wrote:
  
  > Isn't this something that should be in QClipboard in an ideal world? Or is 
that currently not feasible since the protocol is non-standard?
  
  
  It's more that only few processes should be able to monitor the clipboard.
  We'll need some of that code for kdeconnect-kde though, in case that's why 
you're asking.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 82107.
ngraham added a comment.


  Fix  'Unable to assign [undefined] to QString' warning FIXME

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28321?vs=82038=82107

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28321

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/ActionItem.qml
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  dataengines/soliddevice/soliddeviceengine.cpp

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Carson Black]

cblack added inline comments.

INLINE COMMENTS

> systemclipboard.cpp:61
> +
> +#include "qwayland-wlr-data-control-unstable-v1.h"
> +

Is there a reason this `#include` is all the way down here instead of at the 
top of the file?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: cblack, apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, 
mart

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 82108.
ngraham added a comment.


  Remove TODO comment that was already done

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28321?vs=82107=82108

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28321

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/ActionItem.qml
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  dataengines/soliddevice/soliddeviceengine.cpp

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[Aleix Pol Gonzalez]

apol added a comment.


  +1

INLINE COMMENTS

> systemclipboard.cpp:63
> +
> +class DataControlDeviceManager : public 
> QWaylandClientExtensionTemplate
> +, public QtWayland::zwlr_data_control_manager_v1

Maybe split the DataControl classes into a separate file?

> systemclipboard.h:45
> +
> +class XClipboard : public SystemClipboard
> +{

I'd call it QtClipboard or GenericClipboard. There's nothing X-specific there.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29476

To: davidedmundson, #kwin
Cc: apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D29481: Fix blurry icons in KColorSchemeEditor

[Matej Mrenica]

mthw created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
mthw requested review of this revision.

REVISION SUMMARY
  When using fractional scaling, bottom icons are blurred. This patch fixes the 
issue.

TEST PLAN
  No side effects.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29481

AFFECTED FILES
  kcms/colors/editor/kcolorschemeeditor.cpp

To: mthw
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28141: Add KSysGuard::Sensors library

[Arjen Hiemstra]

ahiemstra updated this revision to Diff 82082.
ahiemstra added a comment.


  Maybe right now?

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28141?vs=82081=82082

BRANCH
  sensors_lib

REVISION DETAIL
  https://phabricator.kde.org/D28141

AFFECTED FILES
  CMakeLists.txt
  formatter/Formatter.cpp
  formatter/Formatter.h
  formatter/Unit.h
  processcore/formatter.h
  processcore/unit.h
  sensors/CMakeLists.txt
  sensors/Sensor.cpp
  sensors/Sensor.h
  sensors/SensorDaemonInterface.cpp
  sensors/SensorDaemonInterface_p.h
  sensors/SensorDataModel.cpp
  sensors/SensorDataModel.h
  sensors/SensorInfo_p.h
  sensors/SensorQuery.cpp
  sensors/SensorQuery.h
  sensors/SensorTreeModel.cpp
  sensors/SensorTreeModel.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/SensorsPlugin.cpp
  sensors/declarative/SensorsPlugin.h
  sensors/declarative/qmldir
  sensors/org.kde.KSysGuardDaemon.xml

To: ahiemstra, #plasma
Cc: ngraham, mart, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

D27669: [kstyle] Tools area

[Nathaniel Graham]

ngraham added a comment.


  In D27669#664515 , @ndavis wrote:
  
  > Reposting here so that it won't be forgotten. Some windows are lacking the 
underline:
  >
  > F8288512: Screenshot_20200506_002747.png 

  >  F8288514: Screenshot_20200506_002908.png 

  
  
  Can confirm this with the current state of the patch.

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D27669

To: cblack, #plasma, #breeze, #vdg, hpereiradacosta, davidre, ngraham
Cc: mart, maartens, abstractdevelop, IlyaBizyaev, davidre, davidedmundson, 
hpereiradacosta, ngraham, manueljlin, niccolove, ndavis, plasma-devel, Orage, 
LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, 
ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, 
apol, ahiemstra

D29474: Add inHistory bool and hide heading on inHistory

[Nathaniel Graham]

ngraham accepted this revision.
ngraham added a comment.
This revision is now accepted and ready to land.


  Make sure @broulik agrees though

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_heading_for_ungrouped (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29474

To: niccolove, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Arjen Hiemstra]

ahiemstra accepted this revision.
ahiemstra added a comment.
This revision is now accepted and ready to land.


  Let's get this in and fix anything broken in follow ups.

REPOSITORY
  R111 KSysguard Library

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29481: Fix blurry icons in KColorSchemeEditor

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R119:2c46f28170c7: Fix blurry icons in KColorSchemeEditor 
(authored by mthw, committed by ngraham).

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29481?vs=82097=82103

REVISION DETAIL
  https://phabricator.kde.org/D29481

AFFECTED FILES
  kcms/colors/editor/kcolorschemeeditor.cpp

To: mthw, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28333: Add a new daemon for stats monitoring

[Arjen Hiemstra]

ahiemstra accepted this revision.
ahiemstra added a comment.


  Let's do this.

REPOSITORY
  R106 KSysguard

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D28333

To: davidedmundson, #plasma, mart, ngraham, ahiemstra
Cc: ahiemstra, ivan, mart, zzag, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, 
ngraham, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D29448: Add "Volna" wallpaper

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R131:f5e41f9d25ff: Add Volna wallpaper (authored 
by ngraham).

REPOSITORY
  R131 Plasma Wallpapers

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29448?vs=82005=82088

REVISION DETAIL
  https://phabricator.kde.org/D29448

AFFECTED FILES
  CMakeLists.txt
  Volna/contents/images/5120x2880.jpg
  Volna/contents/screenshot.png
  Volna/metadata.desktop

To: ngraham, #vdg, #plasma, filipf
Cc: filipf, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29449: Use "Flow" wallpaper for Plasma 5.19

[Nathaniel Graham]

This revision was automatically updated to reflect the committed changes.
Closed by commit R31:00f3ea7b185b: Use Flow wallpaper for Plasma 
5.19 (authored by ngraham).

REPOSITORY
  R31 Breeze

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29449?vs=82049=82087

REVISION DETAIL
  https://phabricator.kde.org/D29449

AFFECTED FILES
  lookandfeel.dark/contents/previews/fullscreenpreview.jpg
  lookandfeel.dark/contents/previews/preview.png
  wallpapers/Next/contents/images/1024x768.jpg
  wallpapers/Next/contents/images/1280x1024.jpg
  wallpapers/Next/contents/images/1280x800.jpg
  wallpapers/Next/contents/images/1366x768.jpg
  wallpapers/Next/contents/images/1440x900.jpg
  wallpapers/Next/contents/images/1600x1200.jpg
  wallpapers/Next/contents/images/1680x1050.jpg
  wallpapers/Next/contents/images/1920x1080.jpg
  wallpapers/Next/contents/images/1920x1200.jpg
  wallpapers/Next/contents/images/2560x1440.jpg
  wallpapers/Next/contents/images/2560x1600.jpg
  wallpapers/Next/contents/images/3200x1800.jpg
  wallpapers/Next/contents/images/3200x2000.jpg
  wallpapers/Next/contents/images/3840x2160.jpg
  wallpapers/Next/contents/images/5120x2880.jpg
  wallpapers/Next/contents/screenshot.png
  wallpapers/Next/metadata.desktop

To: ngraham, #vdg, ndavis
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29474: Add inHistory bool and hide heading on inHistory

[Kai Uwe Broulik]

broulik accepted this revision.
broulik added a comment.


  I kinda think this should be named more generically, e.g. 
`headerBackgroundVisible`

REPOSITORY
  R120 Plasma Workspace

BRANCH
  no_heading_for_ungrouped (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29474

To: niccolove, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29481: Fix blurry icons in KColorSchemeEditor

[Matej Mrenica]

mthw added a comment.


  If everything is fine, can you land this, please? Also into 5.18? I am 
guessing 5.12 is already EOL and 5.19 is not branched yet.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29481

To: mthw, #plasma, ngraham
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29476: WIP: Port klipper to use wayland clipboard

[David Edmundson]

davidedmundson updated this revision to Diff 82106.
davidedmundson added a comment.


  Fix the klipper code to handle detecting null buffer better
  X code expected a valid QMimeData object with no contents

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29476?vs=82074=82106

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D29476

AFFECTED FILES
  klipper/CMakeLists.txt
  klipper/klipper.cpp
  klipper/klipper.h
  klipper/systemclipboard.cpp
  klipper/systemclipboard.h
  klipper/tests/CMakeLists.txt
  klipper/tests/paste.cpp

To: davidedmundson, #kwin
Cc: apol, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart

D28487: Redesign of system monitor plasmoids

[Marco Martin]

mart updated this revision to Diff 82118.
mart added a comment.


  - Controls QQC2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28487?vs=82117=82118

BRANCH
  mart/mewSystemMonitor

REVISION DETAIL
  https://phabricator.kde.org/D28487

AFFECTED FILES
  applets/systemmonitor/CMakeLists.txt
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/coreusage/contents/config/faceproperties
  applets/systemmonitor/coreusage/metadata.desktop
  applets/systemmonitor/cpu/Messages.sh
  applets/systemmonitor/cpu/contents/config/config.qml
  applets/systemmonitor/cpu/contents/config/faceproperties
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/cpu/contents/ui/cpuConfig.qml
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/Messages.sh
  applets/systemmonitor/diskactivity/contents/config/config.qml
  applets/systemmonitor/diskactivity/contents/config/faceproperties
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/Messages.sh
  applets/systemmonitor/diskusage/contents/config/config.qml
  applets/systemmonitor/diskusage/contents/config/faceproperties
  applets/systemmonitor/diskusage/contents/ui/diskusage.qml
  applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/Messages.sh
  applets/systemmonitor/memory/contents/config/config.qml
  applets/systemmonitor/memory/contents/config/faceproperties
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/memory/contents/ui/memoryConfig.qml
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/Messages.sh
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/config/faceproperties
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml
  applets/systemmonitor/net/contents/ui/netConfig.qml
  applets/systemmonitor/net/metadata.desktop
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  applets/systemmonitor/systemmonitor/Messages.sh
  applets/systemmonitor/systemmonitor/package/contents/config/config.qml
  applets/systemmonitor/systemmonitor/package/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/package/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/FullRepresentation.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigAppearance.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigSensors.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/config/FaceDetails.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/main.qml
  applets/systemmonitor/systemmonitor/package/metadata.desktop
  applets/systemmonitor/systemmonitor/systemmonitor-faces.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor-presets.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor.cpp
  applets/systemmonitor/systemmonitor/systemmonitor.h

To: mart, #plasma
Cc: alexde, ngraham, ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D29490: This removes the negative top margin, as it's already removed by the NotificationPopup

[Niccolò Venerandi]

niccolove created this revision.
Herald added a project: Plasma.
Herald added a subscriber: plasma-devel.
niccolove requested review of this revision.

REVISION SUMMARY
  The negative top margin was not necessary and causes missing round corners.

REPOSITORY
  R120 Plasma Workspace

BRANCH
  fix_top_margin_of_heading (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D29490

AFFECTED FILES
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> ChangePassword.qml:24
> +import QtQuick.Layouts 1.3
> +import QtQuick.Controls 2.5
> +

...`as QQC2`

> CreateUser.qml:24
> +import QtQuick.Layouts 1.3
> +import QtQuick.Controls 2.5
> +

...`as QQC2`

> UserDetailsPage.qml:25
> +import QtGraphicalEffects 1.12
> +import QtQuick.Controls 2.5
> +import QtQuick.Dialogs 1.3

...`as QQC2`

> UserDetailsPage.qml:188
> +
> +Menu {
> +id: deleteMenu

This menu doesn't close when you click outside of it; you need to hit the 
escape key.

> UserDetailsPage.qml:190
> +id: deleteMenu
> +MenuItem {
> +text: i18n("Delete files")

Give it an icon: `edit-delete`

> UserDetailsPage.qml:198
> +}
> +MenuItem {
> +text: i18n("Keep files")

Give it an icon: `document-multiple`

> UserDetailsPage.qml:208
> +text: i18n("Delete User...")
> +icon.name: "delete"
> +onClicked: deleteMenu.open()

`edit-delete`

> main.qml:135
> +QQC2.Button {
> +Layout.alignment: Qt.AlignLeft
> +

Because the layout has a fillWidth item to the right, this isn't needed

> ngraham wrote in main.qml:96
> "kule"?

That was not a request for explanation but rather a gentle way of saying 
"please change this to something descriptive to a person who does not speak 
Toki Pona" :)

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D28154

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29140: Fix POTD in lock screen (partly)

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  So this only fixes the problem when the POTD image has already been cached by 
the plugin for the desktop wallpaper? While the patch would fix that particular 
use case, I don't think that's a general purpose solution, and if we do 
implement a general-purpose solution, we won't have to do this. So I think we 
should focus on the general solution, sorry. Maybe we can have kded or another 
already-running daemon perform the caching?

INLINE COMMENTS

> cachedprovider.cpp:54
>  const QString path = CachedProvider::identifierToPath( m_identifier );
> -m_image.save(path, "PNG");
> +m_image.save(path, "JPEG");
>  emit done( m_identifier, path, m_image );

seems unrelated

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D29140

To: guoyunhe, #plasma, ngraham
Cc: davidre, ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart updated this revision to Diff 82116.
mart added a comment.


  - move face properties in own file
  - move face config in own file

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=82089=82116

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/facepackages/CMakeLists.txt
  faces/facepackages/barchart/contents/config/main.xml
  faces/facepackages/barchart/contents/faceproperties
  faces/facepackages/barchart/contents/ui/BarChart.qml
  faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
  faces/facepackages/barchart/contents/ui/Config.qml
  faces/facepackages/barchart/contents/ui/FullRepresentation.qml
  faces/facepackages/barchart/metadata.desktop
  faces/facepackages/linechart/contents/config/main.xml
  faces/facepackages/linechart/contents/faceproperties
  faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/linechart/contents/ui/Config.qml
  faces/facepackages/linechart/contents/ui/FullRepresentation.qml
  faces/facepackages/linechart/contents/ui/LineChart.qml
  faces/facepackages/linechart/metadata.desktop
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/faceproperties
  faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/FullRepresentation.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml
  faces/facepackages/piechart/metadata.desktop
  faces/facepackages/textonly/contents/faceproperties
  faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
  faces/facepackages/textonly/contents/ui/FullRepresentation.qml
  faces/facepackages/textonly/metadata.desktop
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/packagestructure/CMakeLists.txt
  faces/packagestructure/sensorface-packagestructure.json
  faces/packagestructure/sensorfacepackage.cpp
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorInfo_p.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28154: Add users KCM

[Carson Black]

cblack updated this revision to Diff 82135.
cblack added a comment.


  Make sure arc diff does what it should

REPOSITORY
  R119 Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28154?vs=82048=82135

BRANCH
  arcpatch-D28154

REVISION DETAIL
  https://phabricator.kde.org/D28154

AFFECTED FILES
  kcms/CMakeLists.txt
  kcms/users/CMakeLists.txt
  kcms/users/Messages.sh
  kcms/users/package/contents/img/Artist Konqi.png
  kcms/users/package/contents/img/Bookworm Konqi.png
  kcms/users/package/contents/img/Boss Konqi.png
  kcms/users/package/contents/img/Bug Catcher Konqi.png
  kcms/users/package/contents/img/Card Shark Konqi.png
  kcms/users/package/contents/img/Hacker Konqi.png
  kcms/users/package/contents/img/Journalist Konqi.png
  kcms/users/package/contents/img/Katie.png
  kcms/users/package/contents/img/Konqi.png
  kcms/users/package/contents/img/Mechanic Konqi.png
  kcms/users/package/contents/img/Messenger Konqi.png
  kcms/users/package/contents/img/Musician Konqi.png
  kcms/users/package/contents/img/Office Worker Konqi.png
  kcms/users/package/contents/img/PC Builder Konqi.png
  kcms/users/package/contents/img/Scientist Konqi.png
  kcms/users/package/contents/img/Teacher Konqi.png
  kcms/users/package/contents/img/Virtual Reality Konqi.png
  kcms/users/package/contents/ui/ChangePassword.qml
  kcms/users/package/contents/ui/CreateUser.qml
  kcms/users/package/contents/ui/UserDetailsPage.qml
  kcms/users/package/contents/ui/main.qml
  kcms/users/package/metadata.desktop
  kcms/users/src/CMakeLists.txt
  kcms/users/src/kcm.cpp
  kcms/users/src/kcm.h
  kcms/users/src/org.freedesktop.Accounts.User.xml
  kcms/users/src/org.freedesktop.Accounts.xml
  kcms/users/src/org.freedesktop.login1.Manager.xml
  kcms/users/src/user.cpp
  kcms/users/src/user.h
  kcms/users/src/usermodel.cpp
  kcms/users/src/usermodel.h
  kcms/users/src/usersessions.h
  kcms/users/user_manager.desktop

To: cblack, #plasma, #vdg, ngraham
Cc: yurchor, iasensio, meven, crossi, The-Feren-OS-Dev, davidedmundson, 
broulik, filipf, ngraham, nicolasfella, zzag, plasma-devel, Orage, LeGast00n, 
cblack, jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29478: [Clipboard Plasmoid] Port to Prison QML import

[Volker Krause]

vkrause added a comment.


  Technically this looks fine from the Prison POV. Whether the barcode type 
selection makes sense beyond "because we can" I'm not sure about though (in 
particular the 1D codes seem to be of questionable use here), but then again 
that's not something introduced by this patch anyway.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D29478

To: broulik, #plasma, vkrause
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28922: Port Sensor Face loading from plasmoid

[Marco Martin]

mart updated this revision to Diff 82119.
mart marked 5 inline comments as done.
mart added a comment.


  - add space

REPOSITORY
  R111 KSysguard Library

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28922?vs=82116=82119

BRANCH
  mart/sensor_face

REVISION DETAIL
  https://phabricator.kde.org/D28922

AFFECTED FILES
  CMakeLists.txt
  faces/CMakeLists.txt
  faces/ConfigAppearance.qml
  faces/ConfigSensors.qml
  faces/FaceDetailsConfig.qml
  faces/SensorFace.cpp
  faces/SensorFaceController.cpp
  faces/SensorFaceController.h
  faces/SensorFaceController_p.h
  faces/SensorFace_p.h
  faces/UsedSensorsView.qml
  faces/facepackages/CMakeLists.txt
  faces/facepackages/barchart/contents/config/main.xml
  faces/facepackages/barchart/contents/faceproperties
  faces/facepackages/barchart/contents/ui/BarChart.qml
  faces/facepackages/barchart/contents/ui/CompactRepresentation.qml
  faces/facepackages/barchart/contents/ui/Config.qml
  faces/facepackages/barchart/contents/ui/FullRepresentation.qml
  faces/facepackages/barchart/metadata.desktop
  faces/facepackages/linechart/contents/config/main.xml
  faces/facepackages/linechart/contents/faceproperties
  faces/facepackages/linechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/linechart/contents/ui/Config.qml
  faces/facepackages/linechart/contents/ui/FullRepresentation.qml
  faces/facepackages/linechart/contents/ui/LineChart.qml
  faces/facepackages/linechart/metadata.desktop
  faces/facepackages/piechart/contents/config/main.xml
  faces/facepackages/piechart/contents/faceproperties
  faces/facepackages/piechart/contents/ui/CompactRepresentation.qml
  faces/facepackages/piechart/contents/ui/Config.qml
  faces/facepackages/piechart/contents/ui/FullRepresentation.qml
  faces/facepackages/piechart/contents/ui/PieChart.qml
  faces/facepackages/piechart/metadata.desktop
  faces/facepackages/textonly/contents/faceproperties
  faces/facepackages/textonly/contents/ui/CompactRepresentation.qml
  faces/facepackages/textonly/contents/ui/FullRepresentation.qml
  faces/facepackages/textonly/metadata.desktop
  faces/import/CMakeLists.txt
  faces/import/ExtendedLegend.qml
  faces/import/FacesPlugin.cpp
  faces/import/FacesPlugin.h
  faces/import/SensorFace.qml
  faces/import/qmldir
  faces/packagestructure/CMakeLists.txt
  faces/packagestructure/sensorface-packagestructure.json
  faces/packagestructure/sensorfacepackage.cpp
  faces/resources.qrc
  processcore/extended_process_list.cpp
  sensors/CMakeLists.txt
  sensors/SensorInfo_p.h
  sensors/declarative/CMakeLists.txt
  sensors/declarative/ExtendedLegend.qml
  sensors/declarative/qmldir

To: mart, #plasma, ahiemstra, #vdg
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29474: Add inHistory bool and hide heading on inHistory

[Niccolò Venerandi]

This revision was automatically updated to reflect the committed changes.
Closed by commit R120:7e4b0979: Add inHistory bool and hide heading on 
inHistory (authored by niccolove).

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D29474?vs=82066=82128

REVISION DETAIL
  https://phabricator.kde.org/D29474

AFFECTED FILES
  applets/notifications/package/contents/ui/FullRepresentation.qml
  applets/notifications/package/contents/ui/NotificationItem.qml

To: niccolove, broulik, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, ragreen, ZrenBot, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28487: Redesign of system monitor plasmoids

[Marco Martin]

mart updated this revision to Diff 82117.
mart added a comment.


  - adapt to api changes
  - move faces config in own file

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28487?vs=81077=82117

BRANCH
  mart/mewSystemMonitor

REVISION DETAIL
  https://phabricator.kde.org/D28487

AFFECTED FILES
  applets/systemmonitor/CMakeLists.txt
  applets/systemmonitor/common/contents/config/main.xml
  applets/systemmonitor/common/contents/ui/Applet.qml
  applets/systemmonitor/common/contents/ui/ConfigGeneral.qml
  applets/systemmonitor/common/contents/ui/DoublePlotter.qml
  applets/systemmonitor/common/contents/ui/SinglePlotter.qml
  applets/systemmonitor/coreusage/contents/config/faceproperties
  applets/systemmonitor/coreusage/metadata.desktop
  applets/systemmonitor/cpu/Messages.sh
  applets/systemmonitor/cpu/contents/config/config.qml
  applets/systemmonitor/cpu/contents/config/faceproperties
  applets/systemmonitor/cpu/contents/ui/cpu.qml
  applets/systemmonitor/cpu/contents/ui/cpuConfig.qml
  applets/systemmonitor/cpu/metadata.desktop
  applets/systemmonitor/diskactivity/Messages.sh
  applets/systemmonitor/diskactivity/contents/config/config.qml
  applets/systemmonitor/diskactivity/contents/config/faceproperties
  applets/systemmonitor/diskactivity/contents/ui/diskactivity.qml
  applets/systemmonitor/diskactivity/contents/ui/diskactivityConfig.qml
  applets/systemmonitor/diskactivity/metadata.desktop
  applets/systemmonitor/diskusage/Messages.sh
  applets/systemmonitor/diskusage/contents/config/config.qml
  applets/systemmonitor/diskusage/contents/config/faceproperties
  applets/systemmonitor/diskusage/contents/ui/diskusage.qml
  applets/systemmonitor/diskusage/contents/ui/diskusageConfig.qml
  applets/systemmonitor/diskusage/metadata.desktop
  applets/systemmonitor/memory/Messages.sh
  applets/systemmonitor/memory/contents/config/config.qml
  applets/systemmonitor/memory/contents/config/faceproperties
  applets/systemmonitor/memory/contents/ui/memory.qml
  applets/systemmonitor/memory/contents/ui/memoryConfig.qml
  applets/systemmonitor/memory/metadata.desktop
  applets/systemmonitor/net/Messages.sh
  applets/systemmonitor/net/contents/config/config.qml
  applets/systemmonitor/net/contents/config/faceproperties
  applets/systemmonitor/net/contents/ui/displayConfig.qml
  applets/systemmonitor/net/contents/ui/net.qml
  applets/systemmonitor/net/contents/ui/netConfig.qml
  applets/systemmonitor/net/metadata.desktop
  applets/systemmonitor/systemmonitor/CMakeLists.txt
  applets/systemmonitor/systemmonitor/Messages.sh
  applets/systemmonitor/systemmonitor/package/contents/config/config.qml
  applets/systemmonitor/systemmonitor/package/contents/config/main.xml
  
applets/systemmonitor/systemmonitor/package/contents/ui/CompactRepresentation.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/FullRepresentation.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigAppearance.qml
  
applets/systemmonitor/systemmonitor/package/contents/ui/config/ConfigSensors.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/config/FaceDetails.qml
  applets/systemmonitor/systemmonitor/package/contents/ui/main.qml
  applets/systemmonitor/systemmonitor/package/metadata.desktop
  applets/systemmonitor/systemmonitor/systemmonitor-faces.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor-presets.knsrc
  applets/systemmonitor/systemmonitor/systemmonitor.cpp
  applets/systemmonitor/systemmonitor/systemmonitor.h

To: mart, #plasma
Cc: alexde, ngraham, ksmanis, davidedmundson, mmustac, ahiemstra, plasma-devel, 
Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, 
ragreen, ZrenBot, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, mart

D29238: Use Standard "Show/Hide Hidden files" shortcuts in directory chooser dialog

[Nathaniel Graham]

ngraham added a comment.


  Ping.

REPOSITORY
  R135 Integration for Qt applications in Plasma

REVISION DETAIL
  https://phabricator.kde.org/D29238

To: ngraham, #plasma, #frameworks
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28623: [WIP] Sync titlebar button appearance with GTK CSD apps

[Mikhail Zolotukhin]

gikari updated this revision to Diff 82124.
gikari added a comment.


  - Export decorations as png images
  
  Global things to do:
  
  - Export decorations in 3 different states: normal, clicked and hovered
  - Consider exporting in SVG
  - Write CSS into custom gtk css file

REPOSITORY
  R99 KDE Gtk Configuration Tool

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28623?vs=79488=82124

BRANCH
  decorations-appearance (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28623

AFFECTED FILES
  CMakeLists.txt
  kded/CMakeLists.txt
  kded/configeditor.cpp
  kded/configeditor.h
  kded/configvalueprovider.cpp
  kded/configvalueprovider.h
  kded/gtkconfig.cpp
  kded/gtkconfig.h
  kded/kwin_bridge/CMakeLists.txt
  kded/kwin_bridge/dummydecoratedclient.cpp
  kded/kwin_bridge/dummydecoratedclient.h
  kded/kwin_bridge/dummydecorationbridge.cpp
  kded/kwin_bridge/dummydecorationbridge.h
  kded/kwin_bridge/dummydecorationsettings.cpp
  kded/kwin_bridge/dummydecorationsettings.h

To: gikari, #breeze, #plasma, cblack
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, 
fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D28321: [WIP] [applets/devicenotifier] Port to ExpandableListItem

[Nathaniel Graham]

ngraham updated this revision to Diff 82111.
ngraham added a comment.


  Namespace qqc2

REPOSITORY
  R120 Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D28321?vs=82108=82111

BRANCH
  port-to-ExpandableListItem (branched from master)

REVISION DETAIL
  https://phabricator.kde.org/D28321

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/ActionItem.qml
  applets/devicenotifier/package/contents/ui/DeviceItem.qml
  applets/devicenotifier/package/contents/ui/FullRepresentation.qml
  applets/devicenotifier/package/contents/ui/devicenotifier.qml
  dataengines/soliddevice/soliddeviceengine.cpp

To: ngraham, #vdg, #plasma, broulik
Cc: dfaure, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, 
zachus, fbampaloukas, ragreen, ZrenBot, ngraham, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

D29264: New tabs for Breeze

[Manuel Jesús de la Fuente]

manueljlin added a comment.


  In D29264#663444 , @ngraham wrote:
  
  > I would suggest to re-add the darkened background for inactive tabs
  
  
  +1
  I think it would still look fine with the 1px color line rounded at the top
  
  F8289464: image.png 
  
  2x
  F8289499: image.png 
  
  Maybe it could even be extended to the top of the outline so it's 2px, but 
that might be slightly hacky and/or inconsistent
  F8289535: image.png 
  
  > Using only color to communicate the "current tab" state would jive with 
that, but then I start to think that we don't have enough color here and that 
it should look more like a Plasma tab, with a thicker highlight bar and the 
whole background colored
  
  Hmm, I think that might look out of place seeing how breeze mostly uses
  1px lines. I also believe that instead of coloring the entire tab background
  with the highlight color, it should just use contrasting colors (selected tab
  and content with view bg, the slightly darker inactive tab bg and the
  outline of the tabs should work)

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D29264

To: abstractdevelop, #vdg, #breeze
Cc: manueljlin, filipf, ngraham, cblack, plasma-devel, dmenig, Orage, 
LeGast00n, The-Feren-OS-Dev, konkinartem, ian, jguidon, Ghost6, jraleigh, 
zachus, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, 
trickyricky26, ragreen, crozbo, ndavis, ZrenBot, firef, skadinna, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, 
ahiemstra, mbohlender, mart