D29726: BookmarksRunner: Change caching databases

meven added inline comments. INLINE COMMENTS > chrome.cpp:55 > for(const Profile : profiles) { > +updateCacheFile(profile.faviconSource(), profile.faviconCache()); > m_profileBookmarks << new ProfileBookmarks(profile); Might as well check the returned value for error >

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82819. guoyunhe marked 9 inline comments as done. guoyunhe added a comment. Fix small issues REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82635=82819 BRANCH master REVISION DETAIL

D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave

broulik updated this revision to Diff 82814. broulik retitled this revision from "[Reminder] Also advert Chromie store for Vivaldi" to "[Reminder] Also advert Chromie store for Vivaldi and Brave". broulik edited the test plan for this revision. broulik added a comment. - Also for brave

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

epopov updated this revision to Diff 82816. epopov added a comment. You're right. Fixed. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29652?vs=82565=82816 REVISION DETAIL https://phabricator.kde.org/D29652 AFFECTED FILES

D29140: Show POTD in lock screen

guoyunhe marked 9 inline comments as done. guoyunhe added inline comments. INLINE COMMENTS > davidre wrote in CMakeLists.txt:44 > Seems unused? It is necessary for the KDED module. Without it, the compilation fails. > davidre wrote in CMakeLists.txt:68 > unrelated Will revert. > davidre

D29140: Show POTD in lock screen

davidre added a comment. I fail to see what the kded module actually does. Or is it the case that simply requesting the data from the engine causes it to cache the image on disk? Maybe that should be documented. INLINE COMMENTS > CMakeLists.txt:44 > CoreAddons > +DBusAddons >

D29533: [Reminder] Also advert Chromie store for Vivaldi and Brave

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit R856:7e2e0bc0: [Reminder] Also advert Chromie store for Vivaldi and Brave (authored by broulik). REPOSITORY R856

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.14 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.14/7/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 19:17:08 + Build duration: 3 min 57 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.14 - Build # 12 - Fixed!

BUILD SUCCESS Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.14/12/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 19:17:05 + Build duration: 4 min 55 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 91 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/91/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Tue, 12 May 2020 20:13:08 + Build duration: 1 day 23 hr and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kwin » kf5-qt5 FreeBSDQt5.14 - Build # 92 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/kwin/job/kf5-qt5%20FreeBSDQt5.14/92/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 19:36:49 + Build duration: 24 min and counting JUnit Tests Name: projectroot

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 88 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/88/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 19:17:07 + Build duration: 2 min 47 sec and counting JUnit Tests Name:

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.14 - Build # 10 - Still unstable!

BUILD UNSTABLE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.14/10/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 19:17:04 + Build duration: 1 min 53 sec and counting JUnit Tests Name: (root)

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.14 - Build # 8 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.14/8/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 19:17:10 + Build duration: 37 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » systemsettings » kf5-qt5 SUSEQt5.14 - Build # 9 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/systemsettings/job/kf5-qt5%20SUSEQt5.14/9/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 10:23:18 + Build duration: 4 min 12 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » plasma-desktop » kf5-qt5 FreeBSDQt5.14 - Build # 87 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20FreeBSDQt5.14/87/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 10:21:32 + Build duration: 5 min 31 sec and counting CONSOLE OUTPUT

D29140: Show POTD in lock screen

guoyunhe updated this revision to Diff 82821. guoyunhe added a comment. Code improvement REPOSITORY R114 Plasma Addons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29140?vs=82819=82821 BRANCH master REVISION DETAIL https://phabricator.kde.org/D29140 AFFECTED FILES

KDE CI: Plasma » powerdevil » kf5-qt5 SUSEQt5.14 - Build # 11 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/powerdevil/job/kf5-qt5%20SUSEQt5.14/11/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 10:23:05 + Build duration: 3 min 20 sec and counting CONSOLE OUTPUT [...truncated

D29748: [GTK Integration] Deprecate GTK2 (Hide backend interface)

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since Inkscape is finally moved to GTK3, it's time to start GTK2 deprecation process. What this does is just a hiding direct

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision. REVISION SUMMARY Since Inkscape is finally moved to GTK3, it's time to start GTK2 deprecation process. What this does is just a hiding GUI for

D29437: Use font: instead of font.pointSize: where possible

ngraham added a comment. So is this good to go? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D29437 To: ngraham, cblack, #plasma Cc: ahiemstra, apol, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, ragreen,

D29766: [applets/taskmanager] Match default tooltip spacing in custom tooltip

ngraham created this revision. ngraham added reviewers: VDG, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision. REVISION SUMMARY The Task Manager app's custom tooltips use level 5 Headings for the subtitles, which is

D29741: [Logout] Port to QQC2 and PC3

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY The logout screen is ported to QtQuick Controls 2 and Plasma Components 3. See D29740 for a

D29717: Fix translation domain for ksysguard plugins

This revision was automatically updated to reflect the committed changes. Closed by commit R106:644648e165fb: Fix translation domain for ksysguard plugins (authored by davidedmundson). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29717?vs=82757=82822

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.14 - Build # 4 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.14/4/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 09:56:30 + Build duration: 1 min 59 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.14 - Build # 5 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.14/5/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 10:10:47 + Build duration: 1 min 8 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.14 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.14/6/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 10:10:47 + Build duration: 26 sec and counting CONSOLE OUTPUT [...truncated

Re: Online sprint(?!)

On Thu, May 14, 2020 at 6:32 AM Bhushan Shah wrote: > So I am seeing this idea floating around in multiple occasion in Plasma > IRC channel and as well on other places, but nothing concrete came up > out of this discussion so I thought I should start formal discussion, > > Due to COVID-19 we had

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.14 - Build # 5 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.14/5/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 09:56:31 + Build duration: 2 min 27 sec and counting CONSOLE OUTPUT

KDE CI: Plasma » plasma-desktop » kf5-qt5 SUSEQt5.14 - Build # 74 - Failure!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/plasma-desktop/job/kf5-qt5%20SUSEQt5.14/74/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 10:21:32 + Build duration: 1 min 0 sec and counting CONSOLE OUTPUT [...truncated

D29700: Add a show label option to the pie chart face

davidedmundson abandoned this revision. davidedmundson added a comment. Arjen suggested in a PM that we already have the concept of "total sensor" being optional or not. No point hiding it at a UI level when we should be doing it at a data level. REPOSITORY R111 KSysguard Library

D29637: Introduce ImageColors

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3986ad9d0955: Introduce ImageColors (authored by mart). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D29637?vs=82645=82820#toc REPOSITORY R169 Kirigami CHANGES SINCE LAST UPDATE

D29765: Add a blurless SDDM theme

filipf created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. filipf requested review of this revision. REVISION SUMMARY This patch adds a blurless SDDM Breeze theme. The non-default theme is added in order to accomodate users who wish to have

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Typically would would bind both to the same backend value and everything would just magically work. However the code in this KCM is terrible, and is quite imperative, without using bindings properly. So you'll have to manually set both anywhere the slider's value is

D28873: Add SwipeNavigator component

ngraham added a comment. When there isn't room to show all labels, eliding the labels or collapsing the inactive tabs to square-ish icons-only things that are still clickable/touchable would seem to make more sense to me. The above screenshot kind of looks like a visual glitch IMO.

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

ngraham added a comment. Actually sorry, I won't get to that refactor soon so I don't want to block your work. Is this reviewable in its current state? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D29365 To: kurmikon, #vdg, #plasma Cc: ndavis,

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#671270 , @ngraham wrote: > Actually sorry, I won't get to that refactor soon so I don't want to block your work. > > Is this reviewable in its current state? Can you explain how I can improve this

D29365: Increase values for touchpad acceleration that can be set from kcm libinput UI

kurmikon added a comment. In D29365#671289 , @ngraham wrote: > Typically would would bind both to the same backend value and everything would just magically work. However the code in this KCM is terrible, and is quite imperative, without using

D29024: feat(wayland): support multiple protocol extensions through plugin system

romangg added a comment. In D29024#669970 , @dvratil wrote: > If I may add my two cents here, Hi Daniel, sorry for the late reply. But I was busy as I had to kick things off now with the libkscreen fork. > I agree with David that

D28873: Add SwipeNavigator component

cblack added a comment. In D28873#671043 , @ngraham wrote: > In that window, there's plenty of space for the component to expand horizontally. I would prefer to avoid scrolling tabs; their interaction is usually not great. It's

D29753: Only build autotests when enabled

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY BUG: 421514 REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D29753

D29756: Remove kiconthemes dependency

This revision was automatically updated to reflect the committed changes. Closed by commit R99:d608a414e411: Remove kiconthemes dependency (authored by arojas). REPOSITORY R99 KDE Gtk Configuration Tool CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29756?vs=82852=82854 REVISION

Plasma 5.19 beta

Plasma 5.18.90 is now released https://www.kde.org/announcements/plasma-5.18.90.php

D29752: Prefix disk name on size labels

lbeltrame added a comment. I don't speak C that well, but it looks OK to me. REPOSITORY R106 KSysguard REVISION DETAIL https://phabricator.kde.org/D29752 To: davidedmundson, lbeltrame, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas,

D28873: Add SwipeNavigator component

mart added a comment. If i make the window narrow enough, that's what happens F8319940: Screenshot_20200514_164118.png perhaps it tabbar should scroll instead? REPOSITORY R169 Kirigami REVISION DETAIL https://phabricator.kde.org/D28873 To:

D29752: Prefix disk name on size labels

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REVISION SUMMARY labels for CPU frequency are "CPU 1 Clock Frequency". Network speeds have the interface name at front. Partitions

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

ngraham added a comment. 1. There's still GIMP (and IIRC Audacity) when it comes to major GTK2 apps. I'm not saying don't do this, but maybe it's a bit premature? 2. Now that the GTK theme page only has one small row of items in it, it seems a bit silly to have on a separate page. It feels

D29140: Show POTD in lock screen

davidre added a comment. I don't get how saving as a png fails if we have the image as QImage. INLINE COMMENTS > kded_potd.cpp:9 > +{ > +consumer = new Plasma::DataEngineConsumer(); > +engine = consumer->dataEngine(QStringLiteral("potd")); still leaks > kded_potd.cpp:28 > + */ >

D29756: Remove kiconthemes dependency

arojas created this revision. arojas added reviewers: Plasma, ngraham. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. arojas requested review of this revision. REVISION SUMMARY It is unused since 702607595599d028e449891f6cf84ae6337344d0

D29753: Only build autotests when enabled

This revision was automatically updated to reflect the committed changes. Closed by commit R106:053d42077d6c: Only build autotests when enabled (authored by davidedmundson). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29753?vs=82849=82856 REVISION

D29752: Prefix disk name on size labels

This revision was automatically updated to reflect the committed changes. Closed by commit R106:ae6c4ac8e39d: Prefix disk name on size labels (authored by davidedmundson). REPOSITORY R106 KSysguard CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D29752?vs=82848=82855 REVISION DETAIL

D28873: Add SwipeNavigator component

ngraham added a comment. In D28873#671042 , @mart wrote: > If i make the window narrow enough, that's what happens > F8319940: Screenshot_20200514_164118.png > > perhaps it tabbar should scroll

D29757: Only search for Qt5::Test inside the autotests dir

davidedmundson created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision. REPOSITORY R106 KSysguard BRANCH master REVISION DETAIL https://phabricator.kde.org/D29757 AFFECTED FILES CMakeLists.txt

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

gikari added a comment. In D29749#671032 , @ngraham wrote: > 1. There's still GIMP (and IIRC Audacity) when it comes to major GTK2 apps. I'm not saying don't do this, but maybe it's a bit premature? Yes. That's why i only hide the UI.

D29652: Automatically close Clipboard applet after clearing history or deleting the last element

This revision was automatically updated to reflect the committed changes. Closed by commit R120:7a4ea26a6561: Automatically close Clipboard applet after clearing history or deleting the… (authored by epopov, committed by ngraham). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE

D29744: [Kicker] Fix jump list actions in RunnerMatchesModel

broulik created this revision. broulik added reviewers: Plasma, hein. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. broulik requested review of this revision. REVISION SUMMARY Fixes regression caused by me meddling with data in

KDE CI: Plasma » kde-cli-tools » kf5-qt5 SUSEQt5.14 - Build # 6 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20SUSEQt5.14/6/ Project: kf5-qt5 SUSEQt5.14 Date of build: Thu, 14 May 2020 11:49:48 + Build duration: 2 min 15 sec and counting CONSOLE OUTPUT [...truncated

KDE CI: Plasma » kde-cli-tools » kf5-qt5 FreeBSDQt5.14 - Build # 7 - Still Failing!

BUILD FAILURE Build URL https://build.kde.org/job/Plasma/job/kde-cli-tools/job/kf5-qt5%20FreeBSDQt5.14/7/ Project: kf5-qt5 FreeBSDQt5.14 Date of build: Thu, 14 May 2020 11:49:48 + Build duration: 47 min and counting CONSOLE OUTPUT [...truncated

D29760: Replace MapProxySource with some javascript code

ahiemstra created this revision. ahiemstra added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ahiemstra requested review of this revision. REVISION SUMMARY MapProxySource has only been added to QuickCharts master so is not available in 5.70, so

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

ndavis added a comment. In D29749#671032 , @ngraham wrote: > 1. There's still GIMP (and IIRC Audacity) when it comes to major GTK2 apps. I'm not saying don't do this, but maybe it's a bit premature? GIMP has its own built-in themes now

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

ngraham added a comment. In D29749#671052 , @gikari wrote: > Yes. That's why i only hide the UI. The backend still sets the GTK2 theme too alongside with GTK3. This only removes the possibility to select different themes for different versions

D29749: [GTK Integration] Deprecate GTK2 (Hide GUI)

ndavis added a comment. wxWidgets is supposed to have GTK3 support since 2.9.4, but Audacity still uses GTK2 for me. https://docs.wxwidgets.org/3.1.3/page_port.html#page_port_wxgtk Audacity also has its own built-in themes and you can't fully use the system theme; you can only use it