Re: Firefox Bookmark runner

2009-11-12 Thread Eduardo Robles Elvira
On Mon, Nov 2, 2009 at 9:50 PM, Aaron J. Seigo ase...@kde.org wrote: On November 2, 2009, Eduardo Robles Elvira wrote: http://github.com/edulix/gsoc/blob/master/kdebase-bookmarks.patch, take a look only at the workspace/plasma part of it). In case this new bookmarks system ships in, I don't

Kubuntu patches to plasma in kdelibs

2009-11-12 Thread Jonathan Riddell
Kubuntu has a couple of patches to plasma in kdelibs, here's a quick review in the interests of distro/upstream hugs. kubuntu_19_no_indent_kickoff_subtext.diff Removes the text intentation from kickoff and elsewhere, it was added on Celeste's advice. I'm pretty sure it's been discussed here

Re: can qtscript plasmoids load C++ qtscript plugins

2009-11-12 Thread Ian Monroe
On Tue, Nov 10, 2009 at 2:56 PM, Aaron J. Seigo ase...@kde.org wrote: On November 10, 2009, Ian Monroe wrote: Ok from talking more in IRC, it sounds like the idea is to have GPG signing of qtscript plasmoids, and then allow them to use the features they ask for. Unlike with C++, it can really

Moving mediawiki runner to kdereview

2009-11-12 Thread Sebastian Kügler
I've just moved a runner that searches in Mediawikis to kdereview, for inclusion in 4.4. The runner can search in arbitrary mediawikis, you need to specify which mediawiki to search in its .desktop file. (If you want to add search for another mediawiki, just add a .desktop file for it, and

Re: Firefox Bookmark runner

2009-11-12 Thread Aaron J. Seigo
On November 12, 2009, Marco Martin wrote: -the nepomuk runner excludes bookmarks, or that really seems to me to be the most sensible thing to do. a nepomuk runner shouldn't return every imaginable thing stored in nepomuk, but should probably be focused by topic, much like every other runner

Re: Kubuntu patches to plasma in kdelibs

2009-11-12 Thread Aaron J. Seigo
On November 12, 2009, Jonathan Riddell wrote: Kubuntu has a couple of patches to plasma in kdelibs, here's a quick review in the interests of distro/upstream hugs. kubuntu_19_no_indent_kickoff_subtext.diff Removes the text intentation from kickoff and elsewhere, it was added on Celeste's

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2090/#review3063 --- trunk/KDE/kdelibs/plasma/abstractrunner.h

Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)

2009-11-12 Thread Aaron Seigo
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/2091/#review3064 --- the line edit for the single query mode should probably have a click

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Jacopo De Simoi
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406 http://reviewboard.kde.org/r/2090/diff/1/?file=13849#file13849line406 this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the

Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)

2009-11-12 Thread Jacopo De Simoi
On 2009-11-12 20:53:01, Aaron Seigo wrote: the line edit for the single query mode should probably have a click text that comes from the name or description of the runner being used; maybe it would even be useful to put a label next to the icon with the name of the runner, so it's

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Aaron Seigo
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/abstractrunner.h, line 406 http://reviewboard.kde.org/r/2090/diff/1/?file=13849#file13849line406 this should probably be setDefaultSyntax, since it doesn't really add another default syntax. also prevents the

Re: Review Request: Add support for single Runner queries to krunner (part II: krunner)

2009-11-12 Thread Aaron Seigo
On 2009-11-12 20:53:01, Aaron Seigo wrote: the line edit for the single query mode should probably have a click text that comes from the name or description of the runner being used; maybe it would even be useful to put a label next to the icon with the name of the runner, so it's

Re: Kubuntu patches to plasma in kdelibs

2009-11-12 Thread Richard Moore
On Thu, Nov 12, 2009 at 8:30 PM, Aaron J. Seigo ase...@kde.org wrote: personally, i'm not a fan of are you sure, yes, yes? dialogs everywhere. that it doesn't work everywhere is a deal breaker, but even then removing widgets by accident doesn't seem to be a huge problem in the wild. i'd prefer

Re: Review Request: Add support for single Runner queries to krunner (part I: libplasma)

2009-11-12 Thread Jacopo De Simoi
On 2009-11-12 20:39:42, Aaron Seigo wrote: trunk/KDE/kdelibs/plasma/runnermanager.h, line 149 http://reviewboard.kde.org/r/2090/diff/1/?file=13853#file13853line149 const bool isn't necessary; in fact, i think this whole method shouldn't be necessary at all. if

Webslice applet moved to kdereview

2009-11-12 Thread Sebastian Kügler
Hey, I've just moved the webslice plasmoid to kdereview, for inclusion in KDE 4.4. The webslice applet is there to put an interactive part of a webpage onto Plasma as an applet. You can specify an element with a CSS selector (a.k.a. the nice way) or by its geometry (the way that works for

Re: Webslice applet moved to kdereview

2009-11-12 Thread Kenneth Christiansen
Hi there, Cool stuff. I don't know about the Plasma naming, but we are trying to not call anything but base classes for *Widget. Plasma widgets are by default GraphicsItems right? So what about Plasma::WebSlice? and then call the QWidget for KWebSlide? Just a suggestion :-) Kenneth On Thu,

Re: Webslice applet moved to kdereview

2009-11-12 Thread Aaron J. Seigo
On November 12, 2009, Kenneth Christiansen wrote: Plasma widgets are by default GraphicsItems right? So what about Plasma::WebSlice? and then call the QWidget for KWebSlide? +1 on Plasma::WebSlice if it goes into libplasma; otherwise KGraphicsWebSliceWidget to go the route of the Qt naming of

Re: Webslice applet moved to kdereview

2009-11-12 Thread Kenneth Christiansen
Qt 4.6 has QGraphicsWebView :-) which is a QGraphicsWidget. If we would make a QGraphics version of, lets say, QLineEdit, it would probably be called QGraphicsLineEdit and not QGraphicsLineEditWidget. That was more or less the consensus we had when naming the QGraphicsWebView (which was renamed

kubuntu kdebase patches to plasma

2009-11-12 Thread Jonathan Riddell
The second in our series of periodical reviews of patches we include to Plasma. kubuntu_19_always_show_kickoff_subtext.diff, the subtexts in kickoff sometimes show always and sometimes on mouse over, this makes that consistent. It's been discussed here before.

Re: Webslice applet moved to kdereview

2009-11-12 Thread Aaron J. Seigo
On November 12, 2009, Kenneth Christiansen wrote: If you go with KGraphics, I would prefer KGraphicsWebSlide. fair enough :) -- Aaron J. Seigo humru othro a kohnu se GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA EE75 D6B7 2EB1 A7F1 DB43 KDE core developer sponsored by Qt Development Frameworks

Re: kubuntu kdebase patches to plasma

2009-11-12 Thread Aaron J. Seigo
On November 12, 2009, Jonathan Riddell wrote: kubuntu_19_always_show_kickoff_subtext.diff, the subtexts in kickoff sometimes show always and sometimes on mouse over, this makes that consistent. It's been discussed here before.

can qtscript plasmoids load C++ qtscript plugins

2009-11-12 Thread Pekka Reijula
On Monday 09 November 2009, Ian Monroe wrote: I suspect the answer to the subject is no since I haven't found a mention of a method to do it. But I also haven't found comprehensive QtScript API docs. :) QtScript apidocs are generated in Qt labs project qtscriptgenerator. My situation is that