Re: Review Request: Fix padding in ToolButton and TabButton

2012-03-19 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104319/#review11644 --- This review has been submitted with commit 37f04317e55b6d66b04

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11632 --- as for comments on the screenshot, labels on the left should be

Re: Review Request: Merge the final and fixed QML battery monitor to master.

2012-03-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104226/#review11631 --- are there updates on this? still issues to work out? - Marco M

Re: QML Plasmoids and complex configs

2012-03-19 Thread Djuro Drljaca
Actually Aaron apparently already fixed it :) On Mon, Mar 19, 2012 at 7:31 PM, Djuro Drljaca wrote: > Will do. But you should find it in the zip file (*.kcrash file ... I agree > it might be better if it was named backtrace :) ). > > > On Mon, Mar 19, 2012 at 7:28 PM, Marco Martin wrote: > >> On

Re: QML Plasmoids and complex configs

2012-03-19 Thread Djuro Drljaca
Will do. But you should find it in the zip file (*.kcrash file ... I agree it might be better if it was named backtrace :) ). On Mon, Mar 19, 2012 at 7:28 PM, Marco Martin wrote: > On Monday 19 March 2012, Djuro Drljaca wrote: > > Aaron: you can find the bug report with the plasmoid and backtrac

Re: QML Plasmoids and complex configs

2012-03-19 Thread Marco Martin
On Monday 19 March 2012, Djuro Drljaca wrote: > Aaron: you can find the bug report with the plasmoid and backtrace here --> > https://bugs.kde.org/show_bug.cgi?id=296379 > i can only see the plasmoid as attachment, not the backtrace can you put the backtrace inline as a comment? (opposed to as at

Re: Creating windows without a minimize button

2012-03-19 Thread Aaron J. Seigo
On Monday, March 19, 2012 16:46:23 Thomas Lübking wrote: > b) I still do believe that this should be handled by the taskbar because > it is the item with limited access. agreed; showing minimized windows that are minimized makes sense imo, even if otherwise marked as "don't show in taskbar". it's

Re: QML Plasmoids and complex configs

2012-03-19 Thread Djuro Drljaca
Aaron: you can find the bug report with the plasmoid and backtrace here --> https://bugs.kde.org/show_bug.cgi?id=296379 Regards, Djuro Drljaca On Mon, Mar 19, 2012 at 11:08 AM, Djuro Drljaca wrote: > I will do it when I get back home (Qt was compiling until 0:30 :) so there > was no time to try

Re: Creating windows without a minimize button

2012-03-19 Thread Nikos Chantziaras
On 19/03/12 17:46, Thomas Lübking wrote: Am 19.03.2012, 02:23 Uhr, schrieb Nikos Chantziaras : On 18/03/12 15:04, Martin Gräßlin wrote: The hint you want to set would only remove the minimize button but does not prevent you from minimizing the window as like I wrote there is no hint to forbid

Re: [RFC] Mission Statement for KWin

2012-03-19 Thread Martin Gräßlin
Am 19.03.2012 09:35, schrieb Luca Beltrame: In data lunedì 19 marzo 2012 09:27:20, Martin Gräßlin ha scritto: Hello Martin, I have written down something like a "Mission Statement" for KWin [1] and I would like to get your input on what I have written. It is a good starting point. I would s

Re: Creating windows without a minimize button

2012-03-19 Thread Thomas Lübking
Am 19.03.2012, 02:23 Uhr, schrieb Nikos Chantziaras : On 18/03/12 15:04, Martin Gräßlin wrote: The hint you want to set would only remove the minimize button but does not prevent you from minimizing the window as like I wrote there is no hint to forbid window minimization. This of course applie

Re: request for review

2012-03-19 Thread Shaun Reich
On Mon, Mar 19, 2012 at 6:28 AM, Sebastian Kügler wrote: > (Positive, because it works, negative, because I > might have been looking for my furry porn collection, not something I'd want > to tell any web services.) yeah, good point. i don't want google knowing i'm into furry porn either. as for

Re: Re: request for review

2012-03-19 Thread Shaun Reich
On Mon, Mar 19, 2012 at 6:33 AM, Alex Fiestas wrote: > On Monday, March 19, 2012 11:28:22 AM Sebastian Kügler wrote: >> Hey, >> >> One potential issue I see is that you ship the youtube logo inside the >> runner. We might not be allowed to redistribute it as that. >> >> It also scales badly, so lo

Re: [RFC] Mission Statement for KWin

2012-03-19 Thread Artur de Souza
Quoting Martin Gräßlin : I have written down something like a "Mission Statement" for KWin [1] and I would like to get your input on what I have written. I think it's good enough and puts KWin's mission in a very good way :) Cheers, -- ---

Re: Re: request for review

2012-03-19 Thread Dario Freddi
Il 19 marzo 2012 11:33, Alex Fiestas ha scritto: >> Also, enabling these runners by default, which you've essentially done, >> brings a great privacy problem -- everything I type into KRunner is sent to >> Google and Bing -- that's not acceptable as such, at least should be >> discussed before we

Re: Pedantic Nitpicking Issues in KRunner

2012-03-19 Thread todd rme
On Mon, Mar 19, 2012 at 11:07 AM, Aaron J. Seigo wrote: > On Monday, March 19, 2012 10:10:49 todd rme wrote: >> On Sun, Mar 18, 2012 at 8:47 PM, Aaron J. Seigo wrote: >> > On Sunday, March 18, 2012 01:33:09 David Edmundson wrote: >> >> * The help view is scrollable, but there is no indication of

Re: request for review

2012-03-19 Thread Aaron J. Seigo
On Monday, March 19, 2012 11:33:13 Alex Fiestas wrote: > In theory they will only be triggered if the prefix match, kinda > > youtube: kde rocks this is easy for the runner itself to do. -- Aaron J. Seigo signature.asc Description: This is a digitally signed message part. _

Re: Re: request for review

2012-03-19 Thread Alex Fiestas
On Monday, March 19, 2012 11:28:22 AM Sebastian Kügler wrote: > Hey, > > One potential issue I see is that you ship the youtube logo inside the > runner. We might not be allowed to redistribute it as that. > > It also scales badly, so looks visually tarred. > > Can you check the license of the y

Re: request for review

2012-03-19 Thread Sebastian Kügler
Hey, One potential issue I see is that you ship the youtube logo inside the runner. We might not be allowed to redistribute it as that. It also scales badly, so looks visually tarred. Can you check the license of the youtube logo, and if we're allowed to ship it, make it look correct? Also, e

Re: Review Request: Add missing property alias "animation" in Slider Plasma Component

2012-03-19 Thread David Edmundson
> On March 18, 2012, 7:57 p.m., Aaron J. Seigo wrote: > > what is the use case for knowing if it is animated or not? this seems like > > an internal implementation detail? > > David Edmundson wrote: > I assume it's more for setting whether it animates or not. (when the user > clicks on the

Re: QML Plasmoids and complex configs

2012-03-19 Thread Djuro Drljaca
I will do it when I get back home (Qt was compiling until 0:30 :) so there was no time to try it). Regards, Djuro Drljaca On Mon, Mar 19, 2012 at 11:05 AM, Aaron J. Seigo wrote: > On Sunday, March 18, 2012 21:32:19 Djuro Drljaca wrote: > > No, but it should be very easy to reproduce. I did some

Re: Pedantic Nitpicking Issues in KRunner

2012-03-19 Thread Aaron J. Seigo
On Monday, March 19, 2012 10:10:49 todd rme wrote: > On Sun, Mar 18, 2012 at 8:47 PM, Aaron J. Seigo wrote: > > On Sunday, March 18, 2012 01:33:09 David Edmundson wrote: > >> * The help view is scrollable, but there is no indication of this. > >> > >> On the desktop, it's not natural to try t

Re: QML Plasmoids and complex configs

2012-03-19 Thread Aaron J. Seigo
On Sunday, March 18, 2012 21:32:19 Djuro Drljaca wrote: > No, but it should be very easy to reproduce. I did something like this in > main.xml: if you can provide a link to a plasmoid package where this is reproduceable, then i can probably find time to reproduce it here and see what can be done.

Re: Review Request: Add missing property alias "animation" in Slider Plasma Component

2012-03-19 Thread Aaron J. Seigo
> On March 18, 2012, 7:57 p.m., Aaron J. Seigo wrote: > > what is the use case for knowing if it is animated or not? this seems like > > an internal implementation detail? > > David Edmundson wrote: > I assume it's more for setting whether it animates or not. (when the user > clicks on the

Re: Review Request: Add missing property alias "animation" in Slider Plasma Component

2012-03-19 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/104318/#review11611 --- actually it was removed and i did forget to remove it from the

Re: Re: Breadcrumbs in Kickoff, IMPORTANT FIXUP

2012-03-19 Thread Mark
On Mon, Mar 19, 2012 at 8:15 AM, Rick Stockton < rickstock...@reno-computerhelp.com> wrote: > I'll top post this one: > > OOPS! And PLEASE ignore my post, in Vol 45/Issue 46, where I talked about > this being requiring "just an easy change": This requires no changes at > all. It's already support

Re: Pedantic Nitpicking Issues in KRunner

2012-03-19 Thread todd rme
On Sun, Mar 18, 2012 at 8:47 PM, Aaron J. Seigo wrote: > On Sunday, March 18, 2012 01:33:09 David Edmundson wrote: >> * The help view is scrollable, but there is no indication of this. >> >>     On the desktop, it's not natural to try to scroll on areas without >> scrollbars. All scroll areas shou

Re: [RFC] Mission Statement for KWin

2012-03-19 Thread Luca Beltrame
In data lunedì 19 marzo 2012 09:27:20, Martin Gräßlin ha scritto: Hello Martin, > I have written down something like a "Mission Statement" for KWin [1] > and I would like to get your input on what I have written. It is a good starting point. I would soften the stance on network transparency beca

[RFC] Mission Statement for KWin

2012-03-19 Thread Martin Gräßlin
Hi all, I have written down something like a "Mission Statement" for KWin [1] and I would like to get your input on what I have written. Why have I written that? Lately I have been rather dissatisfied with the results of some additions to KWin done by non core developers (e.g. Scripting, Tabbi

Re: Re: Breadcrumbs in Kickoff, IMPORTANT FIXUP

2012-03-19 Thread Rick Stockton
I'll top post this one: OOPS! And PLEASE ignore my post, in Vol 45/Issue 46, where I talked about this being requiring "just an easy change": This requires no changes at all. It's already supported, and it even works back in 4.7.4. (Maybe earlier, but 4.7.4 is the ea