Re: kickoff qml

2012-10-23 Thread David Edmundson
On Mon, Oct 22, 2012 at 10:16 AM, Marco Martin wrote: > Hi all, > one thing i would like to have merged for 4.10 is the qml port of kickoff. > i have been looking at it past few days, and it seems to have most of the > features, even tough is still quite rough, i'm not 100% sure it may be ready >

Re: slc repo as dependency

2012-10-23 Thread David Edmundson
It would need to be moved from playground if kde-workspace was to depend on it. The procedure I've had to go through is: - open a sysadmin request to move repo to kdereview stating you want to move to review, and the intended final destination - post to kde-devel to inform people about the move,

Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20758 --- This review has been submitted with commit 6d4955bf63b7d13757a

Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20757 --- This review has been submitted with commit fe5032ec7d5d85caca7

Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-23 Thread Ivan Čukić
> On Oct. 23, 2012, 7:01 a.m., Ivan Čukić wrote: > > You didn't have to bother with screenshots, your word would be sufficient :) > > Diego Casella wrote: > No problem ;) > Btw, should I commit into master and 4.9, or just master? IMO, it can be considered a bugfix, so both. - Ivan

Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-23 Thread Diego Casella
> On Oct. 23, 2012, 7:01 a.m., Ivan Čukić wrote: > > You didn't have to bother with screenshots, your word would be sufficient :) No problem ;) Btw, should I commit into master and 4.9, or just master? - Diego --- This is an automatical

Re: Review Request: Possibility to set QIcon to PlasmaCore.Tooltip

2012-10-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107013/#review20751 --- Ship it! sensible addition - Marco Martin On Oct. 23, 2012,

Review Request: Possibility to set QIcon to PlasmaCore.Tooltip

2012-10-23 Thread Dmitry Ashkadov
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107013/ --- Review request for Plasma. Description --- PlasmaCore.Tooltip [org.kd

Re: Doxyqml, supporting type

2012-10-23 Thread Aleix Pol
On Tue, Oct 23, 2012 at 10:19 AM, Marco Martin wrote: > On Tuesday 23 October 2012, Aleix Pol wrote: > >> >> More seriously though, I think that a patch on some current code would >> be really helpful. >> >> Also did we consider how different will be C++ components vs. QML >> components? Ideally t

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-23 Thread Andreas Demmer
Hi Ural, I would also suggest to give the label text at least some shadows since the current white is somewhat hard to read: http://wstaw.org/m/2012/10/23/plasma-desktopr24762.png Yours, Andreas -- http://www.andreas-demmer.de signature.asc Description: This is a digitally signed message par

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-23 Thread Ural Mullabaev
Hi Martin! > I just tried it and I quite like it, nice work! I have few suggestions > for improvements - first of all don't hide and show the popup when you > change folder, I wasn't sure what's happening when I clicked some > folder in it, I thought Dolphin is being opened and then suddenly the >

Re: SystemTray: QML version #3

2012-10-23 Thread Dmitry Ashkadov
23.10.2012 12:51, Marco Martin пишет: On Tuesday 23 October 2012, Dmitry Ashkadov wrote: 23.10.2012 12:44, Marco Martin пишет: On Tuesday 23 October 2012, Luca Beltrame wrote: In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: it shows only dark blue circle. I've fixed this

Re: Doxyqml, supporting type

2012-10-23 Thread Aurélien Gâteau
Le mardi 23 octobre 2012 00:23:25 Aleix Pol a écrit : > I think you are great Aurélien :D *blushes* :) > > More seriously though, I think that a patch on some current code would > be really helpful. Sure. When this is deployed, I want to go through the current documentation and split it accordi

Re: Review Request: Fix build when NepomukCore and KDELibs reside in different locations

2012-10-23 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107004/#review20724 --- This review has been submitted with commit 5908a28041b7a0fc083

Re: Review Request: Fix build when NepomukCore and KDELibs reside in different locations

2012-10-23 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107004/#review20723 --- Ship it! Ship It! - Marco Martin On Oct. 23, 2012, 9:06 a.m

Review Request: Fix build when NepomukCore and KDELibs reside in different locations

2012-10-23 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107004/ --- Review request for Plasma. Description --- This patch is required if

Re: Stackfolder inclusion to 4.10 [attempt#2]

2012-10-23 Thread Martin Klapetek
Hey Ural, On Mon, Oct 22, 2012 at 12:45 PM, Ural Mullabaev wrote: > Hi Aaron and Marco! > > I fixed the problems which you specified the last time: > - icon decreasing on the panel (attachment - smallicon.png); > - empty popup dialog (now it should show correctly) > And also I changed path to the

Re: SystemTray: QML version #3

2012-10-23 Thread Marco Martin
On Tuesday 23 October 2012, Dmitry Ashkadov wrote: > 23.10.2012 12:44, Marco Martin пишет: > > On Tuesday 23 October 2012, Luca Beltrame wrote: > >> In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: > >>> it shows only dark blue circle. I've fixed this blue circle. Now blue > >>

Re: SystemTray: QML version #3

2012-10-23 Thread Dmitry Ashkadov
23.10.2012 12:44, Marco Martin пишет: On Tuesday 23 October 2012, Luca Beltrame wrote: In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: it shows only dark blue circle. I've fixed this blue circle. Now blue circle of kmail works for me. Could you try choqok& kmail again? I

Re: SystemTray: QML version #3

2012-10-23 Thread Marco Martin
On Tuesday 23 October 2012, Luca Beltrame wrote: > In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: > > it shows only dark blue circle. I've fixed this blue circle. Now blue > > circle of kmail works for me. Could you try choqok & kmail again? > > I tried with Choqok and it wo

Re: SystemTray: QML version #3

2012-10-23 Thread Luca Beltrame
In data martedì 23 ottobre 2012 12:28:44, Dmitry Ashkadov ha scritto: > it shows only dark blue circle. I've fixed this blue circle. Now blue > circle of kmail works for me. Could you try choqok & kmail again? I tried with Choqok and it works now. Thanks. -- Luca Beltrame - KDE Forums team KDE S

Re: SystemTray: QML version #3

2012-10-23 Thread Dmitry Ashkadov
22.10.2012 19:17, Luca Beltrame пишет: In data giovedì 18 ottobre 2012 09:50:49, Dmitry Ashkadov ha scritto: Hello, I've made several changes to system tray with interface in QML (plasma/dmitrya/systemtray-qml branch of kde-workspace): I've been playing with this for a bit and I noticed a reg

Re: Doxyqml, supporting type

2012-10-23 Thread Marco Martin
On Tuesday 23 October 2012, Aleix Pol wrote: > > More seriously though, I think that a patch on some current code would > be really helpful. > > Also did we consider how different will be C++ components vs. QML > components? Ideally they should have a similar aspect since we'll > likely be using

Re: Review Request: Make the Activity Manager's iconButton inside the configuration component to layout correctly in an horizontal layout.

2012-10-23 Thread Ivan Čukić
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106999/#review20718 --- Ship it! You didn't have to bother with screenshots, your word