Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41235 --- This review has been submitted with commit ab56e2f383b4e55a7af

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/ --- (Updated Oct. 4, 2013, 4:26 p.m.) Status -- This change has been mark

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
> On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: > > Looking good, lots of incremental improvements, too. > > > > I suppose we need to adjust the linker targets in plasma-framework and > > kde-workspace, too? If you don't have a patch for that as well, let me > > know, and I'll change it

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
> On Oct. 4, 2013, 12:08 p.m., Marco Martin wrote: > > experimental/kdeclarative/bindings/backportglobal.h, line 24 > > > > > > backportglobal should be not needed anymore since we don't have > > qscriptengine any

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aleix Pol Gonzalez
> On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: > > Looking good, lots of incremental improvements, too. > > > > I suppose we need to adjust the linker targets in plasma-framework and > > kde-workspace, too? If you don't have a patch for that as well, let me > > know, and I'll change it

Re: Review Request 113078: start porting systemmonitor, step 1 hwinfo applet

2013-10-04 Thread Sebastian Kügler
Hey, On Friday, October 04, 2013 17:34:30 Bhushan Shah wrote: > On Fri, Oct 4, 2013 at 4:24 PM, Aaron J. Seigo wrote: > * create a QML import that contains all of the monitors as individual QML > items. > > Looks cool to me.. Will resultant QML import go into plasma-framework or > kde-workspace?

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41220 --- Ship it! +1 for taking care of this. I'm noticing now there a

Re: Review Request 113078: start porting systemmonitor, step 1 hwinfo applet

2013-10-04 Thread Bhushan Shah
Hello! On Fri, Oct 4, 2013 at 4:24 PM, Aaron J. Seigo wrote: > * create a QML import that contains all of the monitors as individual QML > items. Looks cool to me.. Will resultant QML import go into plasma-framework or kde-workspace? > * create a stand-alone plasmoid that wraps those monitor

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
> On Oct. 4, 2013, 11:42 a.m., Sebastian Kügler wrote: > > Looking good, lots of incremental improvements, too. > > > > I suppose we need to adjust the linker targets in plasma-framework and > > kde-workspace, too? If you don't have a patch for that as well, let me > > know, and I'll change it

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41215 --- Ship it! Looking good, lots of incremental improvements, too.

Re: Review Request 113086: KDeclarative cleanup

2013-10-04 Thread Aurélien Gâteau
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113086/#review41214 --- Nothing serious, just some nitpicking. experimental/kdeclarat

Re: Review Request 113078: start porting systemmonitor, step 1 hwinfo applet

2013-10-04 Thread Aaron J. Seigo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/113078/#review41202 --- this review is less about the actual code in this review and mo