Review Request 118012: [screenlocker] Add unit test for LockWindow

2014-05-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118012/ --- Review request for Plasma and David Edmundson. Repository:

Fwd: Jovie Rev 0.6 (KDE 4.11) from Linux Mint-16 KDE edition

2014-05-06 Thread Daniel M . St . André
Colleagues, I wrote to the folks who manage the Jovie speech engine for KDE. After some thought, I decided that you needed to hear about this as well. Please review the following symptom description. Any solution to the symptoms I describe will likely require a localized and profile

Review Request 118013: [screenlocker] More cleanup

2014-05-06 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118013/ --- Review request for Plasma and David Edmundson. Repository:

Re: Review Request 117813: Make the system tray faster

2014-05-06 Thread David Edmundson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117813/ --- (Updated May 6, 2014, 11:03 a.m.) Status -- This change has been

Re: Review Request 117813: Make the system tray faster

2014-05-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117813/#review57400 --- This review has been submitted with commit

Re: Plasma 5?

2014-05-06 Thread Jos Poortvliet
On Monday 05 May 2014 19:25:51 Martin Graesslin wrote: On Monday 05 May 2014 17:56:04 Ivan ?uki? wrote: Jens: the best option is to simply go with Plasma by KDE and So what version am I running? is Plasma 2, Plasma 5, +1 I don't mind the version 5.x (though, I didn't

Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- Review request for Plasma. Repository: kio-extras Description ---

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/ --- (Updated May 6, 2014, 2:42 p.m.) Review request for Plasma and David

Plasma-next Beta is coming soon

2014-05-06 Thread Jos Poortvliet
Amidst a renumbering discussion, Plasma Next Beta is of course on its way. I don't know the impact of the discussion, nor the possible changes in release schedule (Frameworks 5 got delayed a month, didn't it?) but I have a draft for you all to drool over, yell at and add to:

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57402 --- I'm unsure about the isMalformed check. Did you try the

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
On May 6, 2014, 2:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Doesn't pass before - Alexander

RFC: plasma-shell/plasmashell

2014-05-06 Thread Marco Martin
Hi all, at the moment, the plasma shell executable is plasma-shell, but since now dashes are forbidden in application name and bus address, there is palsma_shell i propose to rename it to just plasmashell, so the executable and the application name would be the same. of course, prior release

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
On May 6, 2014, 2:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Alexander Richardson wrote: Doesn't pass

Re: RFC: plasma-shell/plasmashell

2014-05-06 Thread David Edmundson
A bus name can have a hyphen in it. It's interfaces that can't, and they are typically camelCase so different anyway. ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
On May 6, 2014, 2:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Alexander Richardson wrote: Doesn't pass

Re: RFC: plasma-shell/plasmashell

2014-05-06 Thread David Edmundson
oh, we have a convention of doing org.kde.appname-instanceId there's only one instance so I guess that's not a problem, but our KDBusStuff probably enforces it. I don't think we need to rename the binary, but if we do I'd prefer plasmashell over plasma_shell.. David

Re: KF5 Update Meeting Minutes 2014-w19

2014-05-06 Thread Marco Martin
On Tuesday 06 May 2014 15:37:05 Jonathan Riddell wrote: News - beta 2 is tagged and being packaged by distros with release due thursday - it is hoped to make a Plasma beta on friday based on Beta 2 - new schedule up at http://community.kde.org/Frameworks/Epics with beta 3 on june 1st and

Re: Review Request 118022: Replace hacky access to the declarative engine by a PmcRuntime class

2014-05-06 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118022/#review57422 ---

Re: Jovie Rev 0.6 (KDE 4.11) from Linux Mint-16 KDE edition

2014-05-06 Thread Jeremy Whiting
Daniel, You are correct that Jovie just speaks whatever is given to it. I guess the question then is which convention to use (or to somehow allow use of all three depending on user preference). Adding an option for this seems to me a bit overkill for such a small feature, but we'll see, maybe

Re: RFC: plasma-shell/plasmashell

2014-05-06 Thread Aleix Pol
On Tue, May 6, 2014 at 5:02 PM, Marco Martin notm...@gmail.com wrote: On Tuesday 06 May 2014 15:49:57 David Edmundson wrote: oh, we have a convention of doing org.kde.appname-instanceId there's only one instance so I guess that's not a problem, but our KDBusStuff probably enforces it.

Re: Review Request 118022: Replace hacky access to the declarative engine by a PmcRuntime class

2014-05-06 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118022/#review57425 --- What happened to pmcRuntime in qml? - Bhushan Shah On May

Re: Review Request 118022: Replace hacky access to the declarative engine by a PmcRuntime class

2014-05-06 Thread Shantanu Tushar
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118022/ --- (Updated May 6, 2014, 3:56 p.m.) Review request for Plasma. Changes

Re: Review Request 118022: Replace hacky access to the declarative engine by a PmcRuntime class

2014-05-06 Thread Bhushan Shah
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118022/#review57427 --- Ship it! Ship It! - Bhushan Shah On May 6, 2014, 9:26

Re: Plasma 5?

2014-05-06 Thread John Layt
On 5 May 2014 14:55, Sebastian Kügler se...@kde.org wrote: I am not happy with the 2014.6 name and naming scheme. There I said it. Here's a few random thoughts to add to the mix. I'll admit I always thought the .MM number scheme somewhat awkward to use, but that the reasons behind it had a

Re: Plasma 5?

2014-05-06 Thread Mario Fux
Am Dienstag, 06. Mai 2014, 14.24:47 schrieb Jos Poortvliet: Morning guys 2. I'm afraid of people discarding the version because of fear of repeating 4.0. Yeah. We once did the rebranding thing because there was confusion in our user base about what 'KDE' meant, which was hurting projects

Review Request 118024: Insert new Icon applets before the applet at the panel's center, if any

2014-05-06 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118024/ --- Review request for Plasma and Marco Martin. Repository: plasma-desktop

Re: Review Request 118024: Insert new Icon applets before the applet at the panel's center, if any

2014-05-06 Thread Marco Martin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118024/#review57433 --- Ship it! it's ok, just small issue

Re: Review Request 118024: Insert new Icon applets before the applet at the panel's center, if any

2014-05-06 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118024/#review57434 --- This review has been submitted with commit

Re: Review Request 118024: Insert new Icon applets before the applet at the panel's center, if any

2014-05-06 Thread Eike Hein
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118024/ --- (Updated May 6, 2014, 5:29 p.m.) Status -- This change has been

Re: Locale settings in Plasma Next

2014-05-06 Thread John Layt
On 5 May 2014 15:44, Sebastian Kügler se...@kde.org wrote: On Sunday, February 23, 2014 20:10:31 John Layt wrote: One question is when these changes to the envvars will get applied, and the action required to apply them to the apps. I believe Gnome forces you to log out and in again before

Re: Plasma 5?

2014-05-06 Thread Martin Klapetek
On Tue, May 6, 2014 at 5:27 PM, Mario Fux kde...@unormal.org wrote: Aren't the version number mostly important for bug reporting and there they are extracted automatically? That's only for crash reports using Dr. Konqi, if you go to bugs.kde.organd want to file a bug manually (which you'd do

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread David Faure
On May 6, 2014, 12:51 p.m., David Faure wrote: kurifilter-plugins/shorturi/kshorturifilter.cpp, line 374 https://git.reviewboard.kde.org/r/118017/diff/1/?file=271779#file271779line374 Better use QUrl u = QUrl::fromLocalFile(path) then. Alexander Richardson wrote: Doesn't

Re: Locale settings in Plasma Next

2014-05-06 Thread Sebastian Kügler
On Tuesday, May 06, 2014 19:42:32 John Layt wrote: On 5 May 2014 15:44, Sebastian Kügler se...@kde.org wrote: John, you said that you started splitting the locale KCM already, is that work already available somewhere? I could put some time into trying to get it up to scratch for an initial

Re: Plasma 5?

2014-05-06 Thread Jens Reuterberg
Well in all fairness I am all for whatever names comes up. I still think Plasma is the way to go, skip the numbers and simply go Yeah its plasma and if someone asks for version number you give whatever it is. This is again something that we need to divide into Technical and Promotion. These

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread David Faure
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118017/#review57458 --- See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in

Re: Review Request 118017: Fix expansion of ~

2014-05-06 Thread Alexander Richardson
On May 7, 2014, 12:01 a.m., David Faure wrote: See my commit b988ccda0f741eb5475210266f887d7fdf6f8115 in kio-extras. Okay, I guess this review can be dropped then, right? - Alexander --- This is an automatically generated e-mail.