Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5

2014-06-16 Thread Ben Cooksley
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118387/#review60161 --- As systemsettingsview is unlikely to break BC any further in

Re: Re: statusNotifier hide behaviour inconsistent

2014-06-16 Thread Martin Gräßlin
On Sunday 15 June 2014 13:36:52 Damian Ivanov wrote: Thanks Martin for the answer. The long term plan for the strange parts like klipper and kmix is to transform them to a Plasmoid. I hope this won't happen any time soon, I use them in not plasma (their StatusNotifiers) :) For Klipper this

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

2014-06-16 Thread Martin Gräßlin
On June 14, 2014, 9:12 p.m., Hrvoje Senjan wrote: startkde/ksyncdbusenv/CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/118730/diff/2/?file=281040#file281040line5 it was my understanding that KF5_LIBEXEC_INSTALL_DIR is 'reserved' for KF5, and rest of depending software

Re: Review Request 118693: [ksmserver/screenlocker] Use ScreenSaver key as shortcut

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118693/#review60166 --- This review has been submitted with commit

Re: Review Request 118693: [ksmserver/screenlocker] Use ScreenSaver key as shortcut

2014-06-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118693/ --- (Updated June 16, 2014, 7:19 a.m.) Status -- This change has been

Re: Re: statusNotifier hide behaviour inconsistent

2014-06-16 Thread Damian Ivanov
For Klipper this will happen for 5.1. Whether it's worth to keep klipper as a standalone application I'm not yet convinced, especially given that klipper will most likely be bound to KWin in a Wayland world. Just ot of curiosity what part of Klipper would require kwin? If it's for grabbing the

Re: Re: Re: statusNotifier hide behaviour inconsistent

2014-06-16 Thread Martin Gräßlin
On Monday 16 June 2014 10:23:30 Damian Ivanov wrote: For Klipper this will happen for 5.1. Whether it's worth to keep klipper as a standalone application I'm not yet convinced, especially given that klipper will most likely be bound to KWin in a Wayland world. Just ot of curiosity what

Re: Re: Re: Re: statusNotifier hide behaviour inconsistent

2014-06-16 Thread Martin Gräßlin
On Monday 16 June 2014 10:39:34 Damian Ivanov wrote: It's ok if that behavior is for all wayland window manager's. Every window manager supplies a list with known clients for the copy/paste stack. Maybe this is something that should be done as freedesktop standard before it's too late...

Re: Re: Re: Re: statusNotifier hide behaviour inconsistent

2014-06-16 Thread Damian Ivanov
Hmm ok. If I come up with a better idea I'll let you know :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

2014-06-16 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review60178 --- src/klocalizedstring.h

Re: Review Request 118696: Remove unused dependencies.

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118696/#review60181 --- This review has been submitted with commit

Re: Review Request 118696: Remove unused dependencies.

2014-06-16 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118696/ --- (Updated June 16, 2014, 10:14 a.m.) Status -- This change has been

Build failed in Jenkins: plasma-workspace_master_qt5 #425

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/425/changes Changes: [me] Move the Baloo search runner here -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER) in

Minutes Monday Plasma hangout

2014-06-16 Thread Sebastian Kügler
Monday Hangout 16.6.2013 Present: Marco, Martin Gräßlin, Jens, Sebastian, Vishesh, Aleix Jens: - Had a meeting within the VDG, will send results around - Trying to beat Firefox into compliance with QtCurve - Lots of design work of systemsettings going on - Things are moving nicely overall

Re: Minutes Monday Plasma hangout

2014-06-16 Thread Marco Martin
On Monday 16 June 2014, Sebastian Kügler wrote: Marco: - mindless bugfixing mode - Monochrome kickoff tabbar - Fixes in dialog (yes, more of those) - startup fixes: no random opening systray at startup - less animations, applets jumping around the panel at startup -- Marco Martin

Re: Review Request 118730: [startkde] Introduce a ksyncdbusenv helper application

2014-06-16 Thread Martin Gräßlin
On June 14, 2014, 9:12 p.m., Hrvoje Senjan wrote: startkde/ksyncdbusenv/CMakeLists.txt, line 5 https://git.reviewboard.kde.org/r/118730/diff/2/?file=281040#file281040line5 it was my understanding that KF5_LIBEXEC_INSTALL_DIR is 'reserved' for KF5, and rest of depending software

Build failed in Jenkins: plasma-workspace_master_qt5 #426

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/426/changes Changes: [mgraesslin] Don't install ksyncdbusenv to /kf5 in libexecdir -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3

Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut

2014-06-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/ --- Review request for Plasma and Vishesh Handa. Repository:

Re: Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut

2014-06-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/#review60188 --- Ship it! Ship It! - Vishesh Handa On June 16, 2014, 11:45

Re: Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/#review60191 --- This review has been submitted with commit

Re: Review Request 118779: [krunner] Add Qt::Key_Search as a global shortcut

2014-06-16 Thread Martin Gräßlin
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118779/ --- (Updated June 16, 2014, 12:44 p.m.) Status -- This change has been

Build failed in Jenkins: plasma-workspace_master_qt5 #427

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/427/changes Changes: [mgraesslin] [krunner] Add Qt::Key_Search as a global shortcut -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3

Build failed in Jenkins: plasma-workspace_master_qt5 #428

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/428/changes Changes: [notmart] sensible default sizes [notmart] friendlier window title -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave

Build failed in Jenkins: plasma-workspace_master_qt5 #429

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/429/changes Changes: [notmart] remove micro configure button -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER)

kwindowsystem high level functions

2014-06-16 Thread Damian Ivanov
I think that Thomas Luebking agrred with me on this: http://osdir.com/ml/kde-devel/2014-02/msg00063.html except closeWindow I also see missing void setBlockingCompositing(bool active); void setShowingDesktop(bool showing); void setNumberOfDesktops(int numberOfDesktops); It would be only

Re: kwindowsystem high level functions

2014-06-16 Thread Martin Gräßlin
On Monday 16 June 2014 15:14:08 Damian Ivanov wrote: I think that Thomas Luebking agrred with me on this: http://osdir.com/ml/kde-devel/2014-02/msg00063.html except closeWindow I also see missing void setBlockingCompositing(bool active); void setShowingDesktop(bool showing); void

Re: Review Request 118512: Turn KFileMetaData into a Framework.

2014-06-16 Thread Vishesh Handa
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/#review60193 --- I just realized that there is another review about this who

Build failed in Jenkins: plasma-workspace_master_qt5 #430

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/430/changes Changes: [aleixpol] Fix some problems in the lock screen -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER

Build failed in Jenkins: plasma-workspace_master_qt5 #431

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/431/changes Changes: [lukas] add missing Messages.sh, fix catalog loading -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/#review60197 --- This review has been submitted with commit

Re: Review Request 118482: Adjust ksmserver for renamed KWin binary

2014-06-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118482/ --- (Updated June 16, 2014, 1:39 p.m.) Status -- This change has been

Re: Review Request 118574: Adjust componentchooser for renamed KWin binary

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118574/#review60198 --- This review has been submitted with commit

Re: Review Request 118574: Adjust componentchooser for renamed KWin binary

2014-06-16 Thread Hrvoje Senjan
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118574/ --- (Updated June 16, 2014, 1:39 p.m.) Status -- This change has been

Build failed in Jenkins: plasma-workspace_master_qt5 #432

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/432/changes Changes: [lukas] add missing and fix Messages.sh -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER LINBUILDER)

Build failed in Jenkins: plasma-workspace_master_qt5 #433

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/433/changes Changes: [mgraesslin] Adjust KSMServer to renamed KWin binary -- Started by remote host 2a01:4f8:160:9363::9 with note: Triggered by commit Building remotely on LinuxSlave - 3 (PACKAGER

Re: Re: kwindowsystem high level functions

2014-06-16 Thread Martin Gräßlin
On Monday 16 June 2014 15:34:13 Damian Ivanov wrote: I mean you read a property from one class and write to it in a differen class? How can I use kwindowsystem to close a window in wayland (isn't QX11Info::dispay required in netwm) ? not at all as there is no Wayland backend in KWindowSystem

Re: Review Request 117751: Improve dependencies.

2014-06-16 Thread Michael Palimaka
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117751/ --- (Updated June 16, 2014, 1:55 p.m.) Status -- This change has been

Re: Review Request 118763: Remove find_package(XCB) call as it is handled already by the top-level cmake file

2014-06-16 Thread Bernd Steinhauser
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118763/ --- (Updated June 16, 2014, 2:07 p.m.) Review request for kde-workspace,

Re: Review Request 118387: Bump systemsettingsview SOVERSION to 5

2014-06-16 Thread Hrvoje Senjan
On June 16, 2014, 8:54 a.m., Ben Cooksley wrote: As systemsettingsview is unlikely to break BC any further in the 4.x series, could the bump be to SOVERSION 3 instead please? Otherwise, this looks fine to go in from my perspective. off course, i've just used 5, as the rest of the

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

2014-06-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- (Updated June 16, 2014, 2:43 p.m.) Review request for Plasma, Chusslove

Re: Re: kwindowsystem high level functions

2014-06-16 Thread Damian Ivanov
Ok. Whether closing a window is something which will be needed for Wayland in KWindowSystem is quite questionable. If at all it's the taskmanager, no other client should be allowed to perform such a task. I hope you consider for the future non-plasma taskmanagers using kwindowsystem (my fingers

Re: Re: kwindowsystem high level functions

2014-06-16 Thread Aleix Pol
On Mon, Jun 16, 2014 at 4:45 PM, Damian Ivanov damianator...@gmail.com wrote: Ok. Whether closing a window is something which will be needed for Wayland in KWindowSystem is quite questionable. If at all it's the taskmanager, no other client should be allowed to perform such a task. I hope

Re: Re: kwindowsystem high level functions

2014-06-16 Thread Damian Ivanov
Yes, I absolutely will, I also have a wrapper that exposes kwindosystem and kwindowinfo (and few netwm ones) functions to qml https://github.com/damianatorrpm/qmltaskbar (used by https://github.com/damianatorrpm/qmlpanel - old revision there, uploading new one soon) It is a complete rewrite of my

Jenkins build is back to normal : plasma-workspace_master_qt5 #434

2014-06-16 Thread KDE CI System
See http://build.kde.org/job/plasma-workspace_master_qt5/434/changes ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

2014-06-16 Thread Chusslove Illich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review60206 --- Ship it! Ship It! - Chusslove Illich On June 16, 2014,

Re: Review Request 118753: Handle mouse wheel in PlasmaComponents.Slider

2014-06-16 Thread Kai Uwe Broulik
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118753/ --- (Updated June 16, 2014, 6:07 p.m.) Status -- This change has been

Re: Review Request 118753: Handle mouse wheel in PlasmaComponents.Slider

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118753/#review60207 --- This review has been submitted with commit

Re: Re: kwindowsystem high level functions

2014-06-16 Thread Damian Ivanov
And in case this was a hint I should contribute to a wayland kwindowsystem backend, my c is awful, but I'm learning and believe I will when I can. :) ___ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

2014-06-16 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/#review60213 --- This review has been submitted with commit

Re: Review Request 118678: [ki18n] Allow querying for translations of a specific domain

2014-06-16 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118678/ --- (Updated June 16, 2014, 9:32 p.m.) Status -- This change has been

Re: Review Request 118512: Turn KFileMetaData into a Framework.

2014-06-16 Thread Matthew Dawson
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/118512/ --- (Updated June 16, 2014, 5:44 p.m.) Status -- This change has been