[Differential] [Request, 395 lines] D1046: [server] Implement support for drag'n'drop through pointer device

graesslin created this revision. graesslin added reviewers: Plasma, sebas. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY How drag'n'drop works on Wayland: When a surface has a pointer grab and a button pressed on the surface (implicit grab) the

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 442 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/442/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 29 Feb 2016 22:33:58 + Build duration: 21 sec CHANGE SET Revision

Re: Review Request 127229: Workaround bug 352055

> On Feb. 29, 2016, 11:38 p.m., Aleix Pol Gonzalez wrote: > > -1. > > > > You are suggesting us that we don't know what's going on, so we add things > > that have a bigger impact and see if things stick. > > > > Suggestion: > > - Run the model with modeltest: https://wiki.qt.io/Model_Test > >

Re: Review Request 127229: Workaround bug 352055

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127229/#review92955 --- -1. You are suggesting us that we don't know what's going

Re: Review Request 127226: Theme: Discard pixmap cache when changing theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127226/ --- (Updated March 1, 2016, 12:10 a.m.) Status -- This change has been

[Differential] [Updated] D1045: Emit PaletteChanged when setting colors from look and feel package

drosca retitled this revision from "Emit PalleteChanged when setting colors from look and feel package" to "Emit PaletteChanged when setting colors from look and feel package". drosca updated the summary for this revision. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL

[Differential] [Request, 3 lines] D1045: Emit PalleteChanged when setting colors from look and feel package

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY BUG: 359924 REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH kcm-laf (branched from master) REVISION DETAIL

[Differential] [Updated] D1044: [DrKonqi] Reliably quit when closing report assistant

broulik updated the test plan for this revision. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D1044 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma Cc: plasma-devel

[Differential] [Request, 3 lines] D1044: [DrKonqi] Reliably quit when closing report assistant

broulik created this revision. broulik added a reviewer: Plasma. broulik set the repository for this revision to rPLASMAWORKSPACE Plasma Workspace. broulik added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY The finished signal is not emitted when the dialog is

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 450 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/450/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 29 Feb 2016 17:59:07 + Build duration: 29 sec CHANGE SET Revision

Re: Review Request 127226: Theme: Discard pixmap cache when changing theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127226/#review92949 --- Ship it! src/plasma/private/theme_p.cpp (line 775)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 441 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/441/ Project: PLATFORM=Linux,compiler=gcc Date of build: Mon, 29 Feb 2016 16:27:25 + Build duration: 35 sec CHANGE SET Revision

Re: Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127227/ --- (Updated Feb. 29, 2016, 10:17 p.m.) Status -- This change has been

Review Request 127229: Workaround bug 352055

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127229/ --- Review request for Plasma and Marco Martin. Bugs: 352055

Re: Review Request 127226: Theme: Discard pixmap cache when changing theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127226/ --- (Updated Feb. 29, 2016, 10:15 p.m.) Review request for Plasma. Changes

Re: Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell

> On Feb. 29, 2016, 9:52 nachm., Kai Uwe Broulik wrote: > > Isn't that what > > > > QCoreApplication::setAttribute(Qt::AA_DisableHighDpiScaling); > > > > is supposed to do? > > Xuetian Weng wrote: > Emm.. I'm checking if I was running the correct plasmashell... > > Xuetian Weng

Re: Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell

> On Feb. 29, 2016, 9:52 p.m., Kai Uwe Broulik wrote: > > Isn't that what > > > > QCoreApplication::setAttribute(Qt::AA_DisableHighDpiScaling); > > > > is supposed to do? > > Xuetian Weng wrote: > Emm.. I'm checking if I was running the correct plasmashell... > > Xuetian Weng wrote:

Re: Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell

> On Feb. 29, 2016, 9:52 p.m., Kai Uwe Broulik wrote: > > Isn't that what > > > > QCoreApplication::setAttribute(Qt::AA_DisableHighDpiScaling); > > > > is supposed to do? > > Xuetian Weng wrote: > Emm.. I'm checking if I was running the correct plasmashell... Ah, ok. So the real

Re: Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell

> On Feb. 29, 2016, 9:52 p.m., Kai Uwe Broulik wrote: > > Isn't that what > > > > QCoreApplication::setAttribute(Qt::AA_DisableHighDpiScaling); > > > > is supposed to do? Emm.. I'm checking if I was running the correct plasmashell... - Xuetian

Re: Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127227/#review92941 --- Isn't that what

Review Request 127227: Disable Qt 5.6 high dpi scaling for plasmashell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127227/ --- Review request for Plasma and David Edmundson. Repository:

Review Request 127226: Theme: Discard pixmap cache when changing theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127226/ --- Review request for Plasma. Repository: plasma-framework Description

Re: Review Request 127207: IconItem: Fix changing color of svg icons loaded from icon theme

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127207/ --- (Updated Feb. 29, 2016, 9:33 p.m.) Status -- This change has been

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/ --- (Updated Feb. 29, 2016, 11:05 p.m.) Status -- This change has been

Re: [plasma-framework] src/plasma: if path is passed, pick the tail

El dia 29 febr. 2016 5:34 p. m., "Marco Martin" va escriure: > > Git commit 40b99a91222f59a6172b8673536c3c15c0458bf6 by Marco Martin. > Committed on 29/02/2016 at 16:31. > Pushed by mart into branch 'master'. > > if path is passed, pick the tail > > PluginLoader::loadApplet

Re: Review Request 127197: [kcm_colors] Port away from KDELibs4Support

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127197/ --- (Updated Фев. 29, 2016, 9:36 след обяд) Status -- This change has

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 449 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/449/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 28 Feb 2016 21:15:24 + Build duration: 1 min 32 sec CHANGE SET Revision

Re: Review Request 127086: Raise the required CMake version to 3.4.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127086/#review92924 --- Isn't raising the version a bit of a overkill for a module

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On Feb. 29, 2016, 3:50 p.m., Kai Uwe Broulik wrote: > > Looking good, Marco and I are looking into the "Configure..." stuff right > > now. Good. One note though: I do not have a Plasma master setup here, but am working against stable 5.5 from packages. And have simply hacked the toplevel

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Re: Review Request 127225: ShellCorona is responsible for the memory management of views

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127225/#review92919 --- Ship it! Ship It! - Marco Martin On Feb. 29, 2016,

Review Request 127225: ShellCorona is responsible for the memory management of views

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127225/ --- Review request for Plasma. Repository: plasma-workspace Description

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 440 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/440/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sun, 28 Feb 2016 16:18:16 + Build duration: 1 min 4 sec CHANGE SET Revision

Review Request 127223: Don't emit destroyedChanged(true) twice

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127223/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127193/#review92916 --- Looking good, Marco and I are looking into the

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/ --- (Updated Feb. 29, 2016, 1:27 p.m.) Status -- This change has been

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

> On Feb. 29, 2016, 1:18 p.m., Kai Uwe Broulik wrote: > > src/plasma/applet.h, line 463 > > > > > > Better explain the parameter reason here rather than in the getter the text for reason is just copypasted in

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/#review92904 --- Ship it! Ship It! - Kai Uwe Broulik On Feb. 29, 2016,

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

> On Feb. 29, 2016, 1:18 p.m., Kai Uwe Broulik wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, line 644 > > > > > > I think this is not optimal overall: > > > > Imagine you set both

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/#review92902 --- src/plasma/applet.h (line 463)

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/#review92905 --- src/scriptengines/qml/plasmoid/appletinterface.cpp (line

Re: Theming issues noted while porting Weather applet

Am Montag, 29. Februar 2016, 13:17:42 CET schrieb Kai Uwe Broulik: > ‎> If there one switches between dark and breeze meta themes, then for some > reason the updates of the FrameSvgItem items only happen delayed on the > next > > Yeah I've also seen the look and feel package kcm doesn't properly

Re: Review Request 127193: Revival of Weather applet (for Plasma 5.6)

> On Feb. 27, 2016, 10:27 a.m., Kai Uwe Broulik wrote: > > Nice! > > > > Regarding the ComboBox issues, we know, it's horrible, sizing is broken and > > the popup is always white. Not much we can do here :( > > > > I gave the applet a try and there's a couple of issues: > > > > - It seems

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

> On Feb. 29, 2016, 12:19 p.m., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, lines 75-76 > > > > > > why copy the string? > > Kai Uwe Broulik wrote: > We need a getter for

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

> On Feb. 29, 2016, 12:19 nachm., David Edmundson wrote: > > src/scriptengines/qml/plasmoid/appletinterface.cpp, lines 75-76 > > > > > > why copy the string? We need a getter for this. - Kai Uwe

Re: Minutes Monday Plasma Meeting

Hi, d_ed: > - Found out why widget explorer is slow: we're not loading icons, but > complicated SVGs uncached > - will work on that this week, and 5.5 stuff > we talk some times about have also png icons. as I'm not a great fan (cause it's more, and stupid, work), maybe we can add an routine to

Re: Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/#review92895 --- src/scriptengines/qml/plasmoid/appletinterface.cpp (lines

Re: Theming issues noted while porting Weather applet

‎> If there one switches between dark and breeze meta themes, then for some reason the updates of the FrameSvgItem items only happen delayed on the next Yeah I've also seen the look and feel package kcm doesn't properly apply all settings. ‎ ___

Review Request 127218: properties for configurationRequired/configurationRequiredReason

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127218/ --- Review request for Plasma. Repository: plasma-framework Description

Minutes Monday Plasma Meeting

Minutes Plasma 'hangout', 29-2-2016, 12:00 CET Present: mgraesslin, notmart, Riddell, colomar, kbroulik, d_ed, lucas, sebas mgraesslin: * cursor icon works properly, though QtWayland doesn't support animated cursors and doesn't support bitmap cursors * cursortheme kcm ported to Wayland, though

Re: Review Request 127217: Move contextualActionsAboutToShow to Applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127217/ --- (Updated Feb. 29, 2016, 12:10 p.m.) Status -- This change has been

[Differential] [Closed] D1037: fix build properly by adding the lib dir to the includes

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMADESKTOP35d718c20707: fix build properly by adding the lib dir to the includes (authored by sitter). REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D1037: fix build properly by adding the lib dir to the includes

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D1037 EMAIL PREFERENCES

Re: Theming issues noted while porting Weather applet

Hi, Am Samstag, 27. Februar 2016, 18:13:28 CET schrieb Marco Martin: > On Saturday 27 February 2016, Friedrich W. H. Kossebau wrote: > > * PlasmaCore.FrameSvgItem seems to not update to changes of the Plasma > > color theme, stays with theme current on start > > that should update, perhaps there

Re: Review Request 127217: Move contextualActionsAboutToShow to Applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127217/#review92893 --- Ship it! Ship It! - Marco Martin On Feb. 29, 2016,

[Differential] [Request, 1 line] D1037: fix build properly by adding the lib dir to the includes

sitter created this revision. sitter added a reviewer: dfaure. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY libkonq_export is included using pointy brackets, so we need the its directory in the compiler search paths REPOSITORY rPLASMADESKTOP

Review Request 127217: Move contextualActionsAboutToShow to Applet

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127217/ --- Review request for KDE Frameworks and Plasma. Repository:

Re: Review Request 127086: Raise the required CMake version to 3.4.0

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127086/#review92892 --- Ship it! Ship It! - David Edmundson On Feb. 16, 2016,

Re: Review Request 127199: Avoid blocking DBus calls in SNI startup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127199/ --- (Updated Feb. 29, 2016, 11:09 a.m.) Status -- This change has been

Re: Review Request 127201: Fix svg icon path resolving in IconItem

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127201/#review92886 --- Ship it! Ship It! - Marco Martin On Feb. 28, 2016,

[Differential] [Accepted] D1034: [Task Manager] Don't show task is on all activities if there is just one running one

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D1034 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, Plasma, hein Cc: