Re: Review Request 127341: Change the way SUID bits are managed

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127341/#review93465 --- Ship it! >The `kcheckpass` binary only needs the SUID bit

Re: Review Request 127320: Inform applet to update menus before using them

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127320/ --- (Updated March 13, 2016, 1:35 a.m.) Status -- This change has been

Re: Review Request 127322: remove unused file

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127322/ --- (Updated March 13, 2016, 1:35 a.m.) Status -- This change has been

[Differential] [Commented On] D1070: Make panel scripting setLength set min and max length

davidedmundson added a comment. This will be used by any custom layout.js files. We don't use it ourselves. All our layouts are maximised panels. It's other distros layouts that might use it to make a dock style layout and the current code basically does nothing. I'd be happy

Re: Review Request 126970: gtk.css points to nonexistent files (bad filename)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126970/#review93463 --- Sorry for ignoring this. Seems fine to me. But can you

Re: Review Request 126970: gtk.css points to nonexistent files (bad filename)

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126970/#review93461 --- Ship it! Ship It! - David Edmundson On Feb. 2, 2016,

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/#review93459 --- shell/panelview.cpp (line 682)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 473 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/473/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Mar 2016 21:54:09 + Build duration: 7.4 sec CHANGE SET No changes

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93457 --- Fix it, then Ship it! shell/CMakeLists.txt (line 42)

[Differential] [Commented On] D1113: New Desktop Theme KCM

drosca added inline comments. INLINE COMMENTS kcms/desktoptheme-qml/kcm.h:41 It is actually needed to cast to int in model::roleNames() kcms/desktoptheme-qml/package/contents/ui/ThemePreview.qml:31 Because air's background svg has huge margins. This special case could be removed when we

[Differential] [Updated, 818 lines] D1113: New Desktop Theme KCM

drosca updated this revision to Diff 2751. drosca added a comment. Fix issues Remove shadow from clock hands + add center screw Always show vertical scrollbar to fix binding loop on width REPOSITORY rPLASMADESKTOP Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Commented On] D1134: Alternatives: Add new applet only after the old one was removed

mart added a comment. good that makes it look more uniform. tough at some point there was the idea of the possibility of running a script between the addition of the new one and the destruction of the old one, making possible for a script to try to convert some of the config between the

Review Request 127356: [Comic] Improvements

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127356/ --- Review request for Plasma, Kai Uwe Broulik, David Edmundson, and Marco

Re: Review Request 127345: Make it possible for an applet to offer a test object

> On March 12, 2016, 8:26 p.m., Marco Martin wrote: > > src/plasmaquick/appletquickitem.h, line 31 > > > > > > appletquickitem.h is now installed as a public header, <> include > > should be fixed somehow Eh,

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93455 --- src/plasmaquick/appletquickitem.h (line 31)

Re: is there a website / home page for Kirigami that I could point to in my announcement?

On Saturday, March 12, 2016 10:06:43 Dirk Hohndel wrote: > On Mar 12, 2016, at 9:48 AM, Sebastian Kügler wrote: > > Sore point, really. Our web-presence currently utterly sucks (there's some > work going on in that area), but no sensible page to link to, other than, > perhaps. ...

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 23 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/23/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Mar 2016 18:44:59 + Build duration: 2 min 35 sec CHANGE SET No changes

Re: is there a website / home page for Kirigami that I could point to in my announcement?

> On Mar 12, 2016, at 9:48 AM, Sebastian Kügler wrote: > > Sore point, really. Our web-presence currently utterly sucks (there's some > work going on in that area), but no sensible page to link to, other than, > perhaps. ... http://plasma-mobile.org/ or >

Re: is there a website / home page for Kirigami that I could point to in my announcement?

On Saturday, March 12, 2016 09:31:14 Dirk Hohndel wrote: > Or what should I link to? The text I have right now is (based on what Thomas > suggested) > > This release is the result of years of work on Subsurface and a year long > development effort towards a mobile user interface that would shine

Re: Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/125451/ --- (Updated March 12, 2016, 6:40 p.m.) Review request for Plasma.

is there a website / home page for Kirigami that I could point to in my announcement?

Or what should I link to? The text I have right now is (based on what Thomas suggested) This release is the result of years of work on Subsurface and a year long development effort towards a mobile user interface that would shine on phones and tablets. We got tremendous help from the KDE

[Differential] [Requested Changes To] D1113: New Desktop Theme KCM

sebas requested changes to this revision. sebas added a reviewer: sebas. sebas added a comment. This revision now requires changes to proceed. Looks really nice already! Good job! Some comments inline. INLINE COMMENTS kcms/desktoptheme-qml/kcm.cpp:62 QStringLiteral / QLatin1String (I

[Differential] [Accepted] D1117: Fix assigning undefined to double warning on startup

sebas accepted this revision. sebas added a reviewer: sebas. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop BRANCH desktop-preferred-size-warning (branched from master) REVISION DETAIL https://phabricator.kde.org/D1117 EMAIL PREFERENCES

Re: Review Request 127346: Infrastructure for Plasmoid integration testing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/ --- (Updated March 12, 2016, 4:59 p.m.) Review request for Plasma. Changes

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

> On March 12, 2016, 4:12 p.m., Marco Martin wrote: > > shell/main.cpp, line 128 > > > > > > check if it's in standalone mode and not enable the test in that case, > > as it would not be a shellcorona We don't

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93450 --- shell/main.cpp (line 99)

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 12, 2016, 4 p.m.) Review request for KDE Frameworks and

[Differential] [Request, 17 lines] D1134: Alternatives: Add new applet only after the old one was removed

drosca created this revision. drosca added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY New applet is now added at the same position as the old one. CCBUG: 358827 REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93447 --- Ship it! Ship It! - Sebastian Kügler On March 12,

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/ --- (Updated March 12, 2016, 2:13 p.m.) Review request for Plasma. Changes

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/ --- (Updated March 12, 2016, 2:13 p.m.) Review request for KDE Frameworks

[Differential] [Closed] D1130: Set the decoration mode if it doesn't match the server's default mode

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAINTEGRATIONad2a2bcff266: Set the decoration mode if it doesn't match the server's default mode (authored by graesslin). REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma

Re: Review Request 127355: Replace QMenu::exec with QMenu::popup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127355/ --- (Updated March 12, 2016, 12:11 p.m.) Status -- This change has been

Re: Review Request 127344: FrameSvg: Fix dangling pointers in sharedFrames when theme changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127344/ --- (Updated March 12, 2016, 12:11 p.m.) Status -- This change has been

Re: Review Request 127342: IconItem: Schedule pixmap update when window changes

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127342/ --- (Updated March 12, 2016, 12:11 p.m.) Status -- This change has been

Re: Review Request 127355: Replace QMenu::exec with QMenu::popup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127355/#review93446 --- Ship it! - Marco Martin On March 12, 2016, 11:58 a.m.,

Review Request 127355: Replace QMenu::exec with QMenu::popup

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127355/ --- Review request for Plasma. Repository: plasma-framework Description

[Differential] [Closed] D1129: Add a default mode event to ServerSideDecorationManager

This revision was automatically updated to reflect the committed changes. graesslin marked an inline comment as done. Closed by commit rKWAYLANDba479e3ee250: Add a default mode event to ServerSideDecorationManager (authored by graesslin). CHANGED PRIOR TO COMMIT

[Differential] [Updated] D1129: Add a default mode event to ServerSideDecorationManager

graesslin marked 2 inline comments as done. INLINE COMMENTS src/client/protocols/server-decoration.xml:54 This is a protocol and not a C-based programming language ;-) I changed it to "request_mode is requested" REPOSITORY rKWAYLAND KWayland BRANCH server-deco-default-mode-5.6

[Differential] [Accepted] D1129: Add a default mode event to ServerSideDecorationManager

sebas accepted this revision. This revision is now accepted and ready to land. INLINE COMMENTS src/client/protocols/server-decoration.xml:53 till -> until src/client/protocols/server-decoration.xml:54 requestMode() makes more sense here REPOSITORY rKWAYLAND KWayland BRANCH

[Differential] [Accepted] D1130: Set the decoration mode if it doesn't match the server's default mode

sebas accepted this revision. sebas added a reviewer: sebas. sebas added a comment. This revision is now accepted and ready to land. If autotests pass, go for it. :-) REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH decoration-set-mode-on-bind-5.6 REVISION

[Differential] [Abandoned] D1128: Trigger a roundtrip after creating the ServerSideDecoration

graesslin abandoned this revision. graesslin added a comment. better approach with https://phabricator.kde.org/D1129 and https://phabricator.kde.org/D1130 REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1128 EMAIL

[Differential] [Updated] D1130: Set the decoration mode if it doesn't match the server's default mode

graesslin added a dependency: D1129: Add a default mode event to ServerSideDecorationManager. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1130 EMAIL PREFERENCES

[Differential] [Updated] D1129: Add a default mode event to ServerSideDecorationManager

graesslin added a dependent revision: D1130: Set the decoration mode if it doesn't match the server's default mode. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1129 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Request, 5 lines] D1130: Set the decoration mode if it doesn't match the server's default mode

graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY KWayland now provides the default decoration mode of the server allowing us to set the required decoration mode without having to wait

[Differential] [Request, 174 lines] D1129: Add a default mode event to ServerSideDecorationManager

graesslin created this revision. graesslin added reviewers: Plasma, sebas. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY The ServerSideDecorationManager gains a new event which gets sent to the client when it binds the manager. The event indicates

Re: KWayland as framework

> Opinions? comments? +1 from me. I guess it needs to be reviewed before it is moved to frameworks, but that should not take much time (I'd say, it will take exactly two weeks ;) ) Cheers Ivan ___ Plasma-devel mailing list Plasma-devel@kde.org

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 22 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/22/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Mar 2016 10:32:51 + Build duration: 1 min 56 sec CHANGE SET No changes

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93444 --- Ship it! for me is a ship it, modulo just calling it just

Re: Review Request 127345: Make it possible for an applet to offer a test object

> On March 12, 2016, 10:26 a.m., Sebastian Kügler wrote: > > src/plasma/private/packages.cpp, line 46 > > > > > > I'd just go for test.qml or perhaps even autotest.qml test.qml would be good if the abstract name

Re: Review Request 127345: Make it possible for an applet to offer a test object

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127345/#review93442 --- Fix it, then Ship it! Like my other review: if we want

Re: Review Request 127346: RFC: Some infrastructure for Plasma testing

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127346/#review93441 --- Fix it, then Ship it! I'm fine with the approach, but

KWayland as framework

Hi all, As you know in this moment a central effort of the Plasma team is to port the essential bits and pieces of the workspace (such as KWin, plasmashell and various helper bits) to Wayland in order to provide a good usable desktop experience on Wayland before the end of the year. A central

Re: Review Request 127349: Fix wrong usage of KDE brand in kcmshell

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127349/ --- (Updated March 12, 2016, 10:14 a.m.) Status -- This change has been

Jenkins-kde-ci: plasma-desktop Plasma-5.6 stable-kf5-qt5 » Linux,gcc - Build # 21 - Still Failing!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.6%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/21/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 12 Mar 2016 09:21:21 + Build duration: 2 min 53 sec CHANGE SET Revision

[Differential] [Commented On] D1128: Trigger a roundtrip after creating the ServerSideDecoration

graesslin added inline comments. INLINE COMMENTS src/platformtheme/kwaylandintegration.cpp:93 I'm not really happy with the solution. It works, but it introduces a roundtrip. Maybe it's better to adjust the protocol to send out the default on binding the interface. REPOSITORY

Re: Review Request 127352: [kstyle] Implement window shadows on Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127352/#review93432 --- +1 - Marco Martin On March 12, 2016, 8:28 a.m., Martin

[Differential] [Accepted] D1128: Trigger a roundtrip after creating the ServerSideDecoration

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma BRANCH kwayland-roundtrip-server REVISION DETAIL https://phabricator.kde.org/D1128 EMAIL PREFERENCES

Review Request 127352: [kstyle] Implement window shadows on Wayland

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127352/ --- Review request for Plasma and Hugo Pereira Da Costa. Repository: breeze

[Differential] [Request, 5 lines] D1128: Trigger a roundtrip after creating the ServerSideDecoration

graesslin created this revision. graesslin added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. REVISION SUMMARY The server sends out the desired mode directly after creating the ServerSideDecoration. By triggering a roundtrip we make sure that