Re: Munich Sprint

2016-04-21 Thread John Layt
On 18 April 2016 at 22:50, dennis knorr wrote: > as far as i am aware, kprinter from credativ was only a part which was > needed. The old kde printing system had more features. but as i explain > in my other mail, i first wanted to tidy up our issues before > "ambushing"

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 52 - Still Failing!

2016-04-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/52/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Apr 2016 21:09:08 + Build duration: 7 min 25 sec CHANGE SET Revision

Re: Munich Sprint

2016-04-21 Thread John Layt
On 18 April 2016 at 20:58, John Layt wrote: > That would be kprinter. Credative / Limux had a replacement for KDE4 > called kprinter4 (part of which is a poorly-attributed fork of some > code I wrote for Okular): > > http://kde-apps.org/content/show.php/KPrinter4?content=163537 >

Re: Kirigami: pageRow refactor ready for testing

2016-04-21 Thread Marco Martin
On Thursday 21 April 2016 11:38:25 Dirk Hohndel wrote: > > from my tests on the gallery app it seems at least not to have > > regressions (hopefully should work a bit better) > > if from tests looks like it works better, I'll merge it shortly. > > Have you tried building Subsurface-mobile against

Re: Kirigami: pageRow refactor ready for testing

2016-04-21 Thread Dirk Hohndel
On Thu, Apr 21, 2016 at 08:33:19PM +0200, Marco Martin wrote: > Hi all, > i think my rewrite of PageRow is almost done > here's a review request on phab: https://phabricator.kde.org/D1460 > some test would be welcome, it should be pretty easy, just to switch > to the branch > mart/PageRow5.6 > in

Re: latest Kirigami master breaks header size assignments

2016-04-21 Thread Dirk Hohndel
On Thu, Apr 21, 2016 at 08:09:15PM +0200, Marco Martin wrote: > On Thursday 21 April 2016 10:09:38 Dirk Hohndel wrote: > > Currently we do this: > > > > Kirigami.ApplicationWindow { > > id: rootItem > > title: qsTr("Subsurface-mobile") > > > > header.minimumHeight: 0 > >

Kirigami: pageRow refactor ready for testing

2016-04-21 Thread Marco Martin
Hi all, i think my rewrite of PageRow is almost done here's a review request on phab: https://phabricator.kde.org/D1460 some test would be welcome, it should be pretty easy, just to switch to the branch mart/PageRow5.6 in the kirigami repo from my tests on the gallery app it seems at least not to

Re: latest Kirigami master breaks header size assignments

2016-04-21 Thread Marco Martin
On Thursday 21 April 2016 10:09:38 Dirk Hohndel wrote: > Currently we do this: > > Kirigami.ApplicationWindow { > id: rootItem > title: qsTr("Subsurface-mobile") > > header.minimumHeight: 0 > header.preferredHeight: Kirigami.Units.gridUnit * (Qt.platform.os == "ios" > ?

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Marco Martin
On Thursday 21 April 2016 09:59:32 Dirk Hohndel wrote: > On Thu, Apr 21, 2016 at 06:42:59PM +0200, Marco Martin wrote: > > that's subsurface next to the gallery example app how they look on my > > laptop: http://imgur.com/Ni9fhkD > > > > note the size of the bottom action button and drawer

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Marco Martin
On Thursday 21 April 2016 10:02:32 Dirk Hohndel wrote: > > I found a way to more or less fix it on Android: > > > > 1) disable any margin calculation for the case of android in > > ApplicationWindow.qml > > Is there anything I need to do there besides what you've already committed > to master?

latest Kirigami master breaks header size assignments

2016-04-21 Thread Dirk Hohndel
Currently we do this: Kirigami.ApplicationWindow { id: rootItem title: qsTr("Subsurface-mobile") header.minimumHeight: 0 header.preferredHeight: Kirigami.Units.gridUnit * (Qt.platform.os == "ios" ? 2 : 1) header.maximumHeight: Kirigami.Units.gridUnit * 2

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Dirk Hohndel
On Thu, Apr 21, 2016 at 06:17:19PM +0200, Marco Martin wrote: > On Thu, Apr 21, 2016 at 4:42 PM, Dirk Hohndel wrote: > > (1) the keyboard issue on both iOS and (maybe less so) Android. > > Sometimes the virtual keyboard opening is deteceted correctly and > > correct

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Dirk Hohndel
On Thu, Apr 21, 2016 at 05:28:28PM +0200, Marco Martin wrote: > > > (3) the ListView scrolling issue > > When scrolling a ListView it's very easy to get into a state where QML > > gets confused and part or all of the screen becomes background color > > and trying to scroll makes

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Dirk Hohndel
On Thu, Apr 21, 2016 at 06:42:59PM +0200, Marco Martin wrote: > > that's subsurface next to the gallery example app how they look on my laptop: > http://imgur.com/Ni9fhkD > > note the size of the bottom action button and drawer handle.. that > looks pretty weird That's weird indeed. Any idea

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Marco Martin
On Wed, Apr 20, 2016 at 6:41 PM, Dirk Hohndel wrote: > We set the font size based on preferences, IIRC - and we use the same > prefs for desktop and mobile (that's not just laziness - that allows me to > set up the proxy with the desktop version and then have the mobile version

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Marco Martin
On Thu, Apr 21, 2016 at 4:42 PM, Dirk Hohndel wrote: > (1) the keyboard issue on both iOS and (maybe less so) Android. > Sometimes the virtual keyboard opening is deteceted correctly and > correct bottom margin is added, sometimes it isn't. So either we > compensate

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Marco Martin
On Thursday 21 April 2016 07:42:52 Dirk Hohndel wrote: > (1) the keyboard issue on both iOS and (maybe less so) Android. > Sometimes the virtual keyboard opening is deteceted correctly and > correct bottom margin is added, sometimes it isn't. So either we > compensate for the bug in

[Breeze] [Bug 361885] Kalarm crashes when closing main woindow

2016-04-21 Thread Weng Xuetian via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=361885 Weng Xuetian changed: What|Removed |Added CC||wen...@gmail.com --- Comment

[Breeze] [Bug 362039] New: RFE: provide sddm theme without userlists (but explicit username: field instead)

2016-04-21 Thread Rex Dieter via KDE Bugzilla
https://bugs.kde.org/show_bug.cgi?id=362039 Bug ID: 362039 Summary: RFE: provide sddm theme without userlists (but explicit username: field instead) Product: Breeze Version: unspecified Platform: Other OS:

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Dirk Hohndel
On Thu, Apr 21, 2016 at 12:17:14PM +0200, Sebastian Kügler wrote: > On Wednesday 20 April 2016 09:41:15 Dirk Hohndel wrote: > > We set the font size based on preferences, IIRC - and we use the same > > prefs for desktop and mobile (that's not just laziness - that allows me to > > set up the proxy

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 43 - Fixed!

2016-04-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Apr 2016 13:55:09 + Build duration: 8 min 17 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 43 - Fixed!

2016-04-21 Thread no-reply
GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/43/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Apr 2016 13:55:09 + Build duration: 8 min 17 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 51 - Still Failing!

2016-04-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/51/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Apr 2016 13:55:08 + Build duration: 3 min 24 sec CHANGE SET No changes

Re: Review Request 127263: Add Wireless Energy Saving action

2016-04-21 Thread Jan Grulich
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127263/#review94749 --- Ping? - Jan Grulich On Bře. 9, 2016, 4:15 odp., Jan

Re: Kirigami Page.title

2016-04-21 Thread Marco Martin
On Wednesday 20 April 2016 22:51:08 Martin Klapetek wrote: > So in this case it doesn't make sense that this Page would > have the standard blue titlebar too. Unless more things could > go in there. > > I can perhaps write a patch to hide it if empty, if you agree. > > Cheers in latest master

[Differential] [Closed] D1458: Don't include invalid conversions in result

2016-04-21 Thread davidedmundson (David Edmundson)
This revision was automatically updated to reflect the committed changes. Closed by commit rKDEPLASMAADDONSac32370da1eb: Don't include invalid conversions in result (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1458?vs=3445=3446#toc REPOSITORY

[Differential] [Accepted] D1458: Don't include invalid conversions in result

2016-04-21 Thread broulik (Kai Uwe Broulik)
broulik accepted this revision. broulik added a reviewer: broulik. This revision is now accepted and ready to land. INLINE COMMENTS runners/converter/converterrunner.cpp:237 Remove space betwen ! and v REPOSITORY rKDEPLASMAADDONS Plasma Addons BRANCH master REVISION DETAIL

[Differential] [Commented On] D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation

2016-04-21 Thread bshah (Bhushan Shah)
bshah added a comment. In https://phabricator.kde.org/D1444#27056, @aspotashev wrote: > Does this mean Ctrl+Alt+Fxx won't work without systemd, i.e. I'll need to hard reset my computer when Plasma session crashes or hangs up? You don't need systemd to be your init, and

[Differential] [Commented On] D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation

2016-04-21 Thread Martin Gräßlin
graesslin added a comment. In https://phabricator.kde.org/D1444#27056, @aspotashev wrote: > Does this mean Ctrl+Alt+Fxx won't work without systemd, i.e. I'll need to hard reset my computer when Plasma session crashes or hangs up? No, that means Ctrl+Alt+Fxx won't work on

[Differential] [Commented On] D1444: Switch virtual terminal through logind instead of having a VirtualTerminal implementation

2016-04-21 Thread aspotashev (Alexander Potashev)
aspotashev added a comment. Does this mean Ctrl+Alt+Fxx won't work without systemd, i.e. I'll need to hard reset my computer when Plasma session crashes or hangs up? REPOSITORY rKWIN KWin BRANCH vt-integration-through-logind REVISION DETAIL https://phabricator.kde.org/D1444 EMAIL

[Differential] [Request, 5 lines] D1458: Don't include invalid conversions in result

2016-04-21 Thread davidedmundson (David Edmundson)
davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This will happen if the currency conversion rates file could not get downloaded. REPOSITORY

[Differential] [Closed] D1435: Add missing data role for closable state.

2016-04-21 Thread hein (Eike Hein)
This revision was automatically updated to reflect the committed changes. Closed by commit rKWAYLAND4b6177c19a92: Add missing data role for closable state. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D1435?vs=3388=3444#toc REPOSITORY rKWAYLAND KWayland CHANGES

[Differential] [Accepted] D1435: Add missing data role for closable state.

2016-04-21 Thread Martin Gräßlin
graesslin accepted this revision. REPOSITORY rKWAYLAND KWayland BRANCH moveresize REVISION DETAIL https://phabricator.kde.org/D1435 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, mart, graesslin Cc: plasma-devel, sebas

[Differential] [Abandoned] D1446: Fix naming: closable not closeable

2016-04-21 Thread Martin Gräßlin
graesslin abandoned this revision. REPOSITORY rKWAYLAND KWayland REVISION DETAIL https://phabricator.kde.org/D1446 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: graesslin, Plasma, hein Cc: sebas, plasma-devel

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 42 - Failure!

2016-04-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/42/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Apr 2016 10:26:27 + Build duration: 7 min 40 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 50 - Failure!

2016-04-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/50/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Apr 2016 10:26:00 + Build duration: 4 min 29 sec CHANGE SET Revision

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-04-21 Thread Sebastian Kügler
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/#review94747 --- I think we should start adding autotests to those classes we

Re: Kirigami: a feature needed for subsurface and api change feedback

2016-04-21 Thread Sebastian Kügler
On Wednesday 20 April 2016 09:41:15 Dirk Hohndel wrote: > We set the font size based on preferences, IIRC - and we use the same > prefs for desktop and mobile (that's not just laziness - that allows me to > set up the proxy with the desktop version and then have the mobile version > built on the

[Differential] [Request, 110 lines] D1457: Applet: Add settings for maximal volume and volume step

2016-04-21 Thread drosca (David Rosca)
drosca created this revision. drosca added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REPOSITORY rPLASMAPA Plasma Audio Volume Applet BRANCH applet-settings REVISION DETAIL https://phabricator.kde.org/D1457

Re: Review Request 127702: ConfigModel: Don't try to resolve empty source path from package

2016-04-21 Thread David Rosca
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127702/ --- (Updated April 21, 2016, 10:11 a.m.) Review request for Plasma.

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 49 - Failure!

2016-04-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/49/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Apr 2016 10:03:50 + Build duration: 2 min 54 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 41 - Still Failing!

2016-04-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/41/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Apr 2016 10:03:35 + Build duration: 3 min 5 sec CHANGE SET Revision

Jenkins-kde-ci: kinfocenter master kf5-qt5 » Linux,gcc - Build # 4 - Failure!

2016-04-21 Thread no-reply
GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/kinfocenter%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/4/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 21 Apr 2016 10:02:45 + Build duration: 43 sec CHANGE SET Revision edd7344c57c97df90b87d432861299b1f4e806ea

[Differential] [Request, 85 lines] D1455: Auto-test to verify that the empty defaults are loaded correctly in KHintsSettings

2016-04-21 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This change introduces a new auto-test for KHintsSettings. The idea is to verify that defaults are

Re: Kirigami Page.title

2016-04-21 Thread Marco Martin
On Wednesday 20 April 2016 22:51:08 Martin Klapetek wrote: > Is it possible to either hide the blue titlebar when empty > or add things like buttons and icons in there? > > In SpaceBar, the active conversation has this layout at > the top of the Page: > > [Presence Icon] Username [Close

[Differential] [Request, 18 lines] D1456: Fix loading of widgetStyle in KHintsSettings

2016-04-21 Thread Martin Gräßlin
graesslin created this revision. graesslin added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The read value from config is included even if it is empty. REPOSITORY rPLASMAINTEGRATION Integration

[Differential] [Updated] D1455: Auto-test to verify that the empty defaults are loaded correctly in KHintsSettings

2016-04-21 Thread Martin Gräßlin
graesslin added a dependent revision: D1456: Fix loading of widgetStyle in KHintsSettings. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1455 EMAIL PREFERENCES

[Differential] [Updated] D1456: Fix loading of widgetStyle in KHintsSettings

2016-04-21 Thread Martin Gräßlin
graesslin added a dependency: D1455: Auto-test to verify that the empty defaults are loaded correctly in KHintsSettings. REPOSITORY rPLASMAINTEGRATION Integration for Qt applications in Plasma REVISION DETAIL https://phabricator.kde.org/D1456 EMAIL PREFERENCES