hein accepted this revision.
hein added a comment.
This revision is now accepted and ready to land.
I'll merge this into the new lib to be shipped with 5.7.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1673
EMAIL PREFERENCES
davidedmundson added a comment.
In https://phabricator.kde.org/D1670#31368, @andreask wrote:
> In https://phabricator.kde.org/D1670#31201, @davidedmundson wrote:
>
> > Fix most of Kai's comments
> >
> > - only missing changing the user selection screen, as I dont' know what
icon
andreask added a comment.
In https://phabricator.kde.org/D1670#31201, @davidedmundson wrote:
> Fix most of Kai's comments
>
> - only missing changing the user selection screen, as I dont' know what
icon to use
Which icons do you need? can you tel me the icon names and size.
> On April 29, 2016, 4:06 nachm., David Edmundson wrote:
> > lets get this merged ASAP so we have some time to fix any fallout from it.
>
> Sebastian Kügler wrote:
> But we don't depend on Qt 5.6 yet in workspace. I think the blocker there
> is that we need Qt 5.6 on the CI system, then we
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1692
EMAIL PREFERENCES
davidedmundson accepted this revision.
davidedmundson added a reviewer: davidedmundson.
davidedmundson added a comment.
This revision is now accepted and ready to land.
If you go to identity.kde.org you should see an option to upgrade to a
developer account then you can commit.
Put my
> On Май 26, 2016, 4:30 след обяд, David Edmundson wrote:
> > Do you have a backtrace? Mostly so I can see if we can close any bug
> > reports.
> >
> > A TaskManager.Backend objects is owned by the taskItem - so the lifespan of
> > the TaskItem will *always* outlive the Backend - so we
> On Май 26, 2016, 4:30 след обяд, David Edmundson wrote:
> > Do you have a backtrace? Mostly so I can see if we can close any bug
> > reports.
> >
> > A TaskManager.Backend objects is owned by the taskItem - so the lifespan of
> > the TaskItem will *always* outlive the Backend - so we
> On May 26, 2016, 1:30 p.m., David Edmundson wrote:
> > Do you have a backtrace? Mostly so I can see if we can close any bug
> > reports.
> >
> > A TaskManager.Backend objects is owned by the taskItem - so the lifespan of
> > the TaskItem will *always* outlive the Backend - so we shouldn't
volkov added a dependency: D1691: kfontinst: Port to Qt widget classes.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1692
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov, Plasma
Cc: plasma-devel, sebas
volkov created this revision.
volkov added a reviewer: Plasma.
volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- get rid of KGlobal and KLocale
volkov added a dependent revision: D1691: kfontinst: Port to Qt widget classes.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1690
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov, Plasma
Cc: plasma-devel,
volkov added a dependency: D1690: kfontinst: Port away from kde_file.h.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D1691
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: volkov, Plasma
Cc: plasma-devel, sebas
volkov created this revision.
volkov added a reviewer: Plasma.
volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
KAction -> QAction
KPushButton
volkov created this revision.
volkov added a reviewer: Plasma.
volkov set the repository for this revision to rPLASMADESKTOP Plasma Desktop.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REPOSITORY
rPLASMADESKTOP Plasma Desktop
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128021/#review95831
---
Do you have a backtrace? Mostly so I can see if we can close
GENERAL INFO
BUILD UNSTABLE
Build URL:
https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/103/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Thu, 26 May 2016 13:04:40 +
Build duration: 9 min 30 sec
CHANGE SET
Revision
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128021/
---
(Updated May 26, 2016, 3:04 p.m.)
Review request for Plasma and Eike
sebas accepted this revision.
sebas added a reviewer: sebas.
sebas added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> debug_console.cpp:135
> +if (!device) {
> +return tableRow(i18n("Input Device"), i18nc("The input device for
> the event is
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rBREEZEGTK Breeze for Gtk
REVISION DETAIL
https://phabricator.kde.org/D1664
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To: dirrukd,
broulik added inline comments.
INLINE COMMENTS
> mart wrote in Background.qml:36
> are we sure that one is implemented with a software renderer?
The 2D renderer RectangleNode just uses QLinearGradient on a QBrush internally.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
davidedmundson added inline comments.
INLINE COMMENTS
> mart wrote in Background.qml:36
> are we sure that one is implemented with a software renderer?
It works with QT_XCB_FORCE_SOFTWARE_OPENGL=1
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
bdhruve added a comment.
In https://phabricator.kde.org/D1672#31141, @graesslin wrote:
> In https://phabricator.kde.org/D1672#31140, @bdhruve wrote:
>
> > In https://phabricator.kde.org/D1672#31046, @graesslin wrote:
> >
> > > I'm wondering: should we ensure that the ids are
---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127870/#review95815
---
Ship it!
ping :)
- Sebastian Kügler
On May 8, 2016,
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rKWAYLAND KWayland
BRANCH
no-destroy-from-dtor
REVISION DETAIL
https://phabricator.kde.org/D1680
EMAIL PREFERENCES
mart added a comment.
doesn't seem to apply over breeze-gtk master
i get:
The next patch would delete the file
Breeze-dark-gtk/assets/arrow-down-active.png,
which does not exist! Assume -R? [n]
(while there is Breeze-dark-gtk/gtk-2.0/assets/ and
Breeze-dark-gtk/gtk-3.0/assets/ )
mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.
REPOSITORY
rPLASMAWORKSPACE Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D1562
EMAIL PREFERENCES
https://phabricator.kde.org/settings/panel/emailpreferences/
To:
mart added inline comments.
INLINE COMMENTS
> broulik wrote in Background.qml:36
> Rectangle still allows Gradient with GradientStop, just that the gradient can
> only be top to bottom which is what we want here anyway.
are we sure that one is implemented with a software renderer?
REPOSITORY
28 matches
Mail list logo
