Re: Review Request 128997: Fix most obvious clazy and clang warnings

[Anthony Fieroni]

> On Септ. 22, 2016, 2:42 преди обяд, David Edmundson wrote:
> > appmenu/appmenu.cpp, line 90
> > 
> >
> > what's with this change?
> 
> Aleix Pol Gonzalez wrote:
> The warning was saying that it's a delete of something fwd-declared. A 
> bit more research suggested that it's `#if 0`'d everywhere else. So here too.

At line 32 topmenu is removed as include. Deleting pointer of fwrd declared 
class is a no-op, you can get rid of m_menubar usage at all.


- Anthony


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128997/#review99402
---


On Септ. 22, 2016, 2:36 преди обяд, Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128997/
> ---
> 
> (Updated Септ. 22, 2016, 2:36 преди обяд)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Should be ok, would like your +1 nevertheless.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/timezonemodel.cpp efd4eb2 
>   applets/notifications/plugin/notificationshelper.h 066048e 
>   appmenu/appmenu.cpp bb2e7f5 
>   components/shellprivate/interactiveconsole/interactiveconsole.cpp 12f0bb0 
>   components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp 
> 2560d5d 
>   components/shellprivate/widgetexplorer/widgetexplorer.cpp be5c9dc 
>   dataengines/apps/appsengine.cpp 81e8ce5 
>   dataengines/geolocation/geolocation.cpp 38e106c 
>   dataengines/share/shareengine.cpp 039777d 
>   dataengines/weather/ions/noaa/ion_noaa.cpp 40dcd46 
>   drkonqi/parser/backtraceparser.h 9728e20 
>   klipper/clipcommandprocess.cpp b6631b5 
>   klipper/editactiondialog.cpp afd7d3e 
>   klipper/klipper.cpp 525ef87 
>   krunner/dialog.h a34152a 
>   kuiserver/progresslistdelegate.h 0fa3d6f 
>   libtaskmanager/abstracttasksmodel.h cb6e74f 
>   libtaskmanager/abstracttasksproxymodeliface.h 4c627f1 
>   libtaskmanager/activityinfo.cpp 8427cfd 
>   libtaskmanager/flattentaskgroupsproxymodel.cpp 8b02d57 
>   libtaskmanager/taskfilterproxymodel.cpp b2cd2b1 
>   libtaskmanager/tasksmodel.h 1a7eb2c 
>   libtaskmanager/waylandtasksmodel.cpp 458a0c8 
>   plasma-windowed/main.cpp de3dff8 
>   runners/bookmarks/browsers/chrome.cpp 9d5e6e9 
>   runners/bookmarks/browsers/chromefindprofile.cpp 925083a 
>   runners/bookmarks/faviconfromblob.cpp 77512eb 
>   runners/kill/killrunner.cpp a7a7a01 
>   runners/shell/shellrunner.h 29d5d3c 
>   runners/webshortcuts/webshortcutrunner.cpp 1ad6677 
>   shell/alternativeshelper.cpp a96b266 
>   shell/containmentconfigview.cpp 3ae2985 
>   shell/desktopview.h f72add1 
>   shell/panelview.h 36c414e 
>   shell/scripting/scriptengine_v1.cpp ab33bf5 
>   shell/shellcorona.cpp 25e0378 
>   wallpapers/image/backgroundlistmodel.cpp 8130b1c 
>   wallpapers/image/image.h c488a84 
>   wallpapers/image/image.cpp ea66733 
> 
> Diff: https://git.reviewboard.kde.org/r/128997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

[Powerdevil] [Bug 369181] User session security vulnerability from screen lock being suppressed with power management

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369181

Kai Uwe Broulik  changed:

   What|Removed |Added

  Flags||Usability?
 CC||k...@privat.broulik.de

--- Comment #1 from Kai Uwe Broulik  ---
Adding usability team.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 369181] New: User session security vulnerability from screen lock being suppressed with power management

[Boskote via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369181

Bug ID: 369181
   Summary: User session security vulnerability from screen lock
being suppressed with power management
   Product: Powerdevil
   Version: 5.6.4
  Platform: Debian testing
OS: Linux
Status: UNCONFIRMED
  Severity: major
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: bosk...@riseup.net

The problem is that applications (in my experience it has only been browsers,
both firefox and chromium) request that power management be suppressed, which
overrides an automatic screen lock timeout configured through power management.
On its own this behaviour makes sense, but it can result in a silent failure of
the timed automatic screen locking, which is a significant vulnerability for
users who are depending on the auto screen lock for the security of their
session. 

This problem is exacerbated by poorly designed websites that get the browser to
request power management suppression for reasons that are not obvious to the
user (a background webRTC PeerConnection in chromium is the recent example I
saw).

I would expect that there would be an externally visible notification of when
this suppression of power management occurs, so that a user who is depending on
screen locking will be aware that it has been disabled. Alternatively, there
could also be a way of configuring power management to override the suppression
requests for users who value screen locking (and other power management
features) over the convenience of the automatic suppression. 

It is possible to click on the "Battery and Brightness" tab of the system tray
to see a message about suppression of power management, but there is no
externally visible notification when the suppression occurs. It is too tedious
to periodically click into this area to check if there is a suppression. 

It is also possible to configure a button or keyboard shortcut for quick screen
locking and do this manually just in case the automatic screen lock is being
suppressed. This is the workaround I am currently using, but it is basically
just a replacement for a timed screen lock that can't be trusted to work as
configured. 

Reproducible: Always

Steps to Reproduce:
1. Use power management to configure a short timeout on the screen lock
2. Open a poorly designed website in chromium or firefox that makes background
requests to suppress power management (some pages from http://www.laprensa.hn/
in chromium containing background webrtc peerconnections, for example). 
3. Get up and leave the computer with that tab open. See how long it takes for
someone to realize you left your session open and start digging around in your
stuff :p

Actual Results:  
The screen lock will not work because the power management is suppressed. 

Expected Results:  
Popped up a notification (or have the option to enable such a notification) as
soon as the power management is suppressed so that the offending website tab
could be closed, or the screen could be manually locked.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Differential] [Request, 12 lines] D2831: Introduce an action to display what we're showing in the menu

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We let the developer introduce a tree of actions as a menu.
  This patch makes it possible for the application to see how this is being
  navigated

TEST PLAN
  tested locally

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2831

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Request, 10 lines] D2830: ApplicationWindow.bannerPressed signal

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2830

AFFECTED FILES
  src/controls/GlobalDrawer.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Request, 2 lines] D2829: Add description for volume applet

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Fixes appstream test failure on CI.
  Also it's a useful thing to have anyway as the comment is shown in the 
  Widget Explorer.
  
  This breaks the string freeze, but it is a bug fix.
  CC-MAIL: kde-i18n-...@kde.org

TEST PLAN
  appstreamcli validate now passes

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2829

AFFECTED FILES
  applet/metadata.desktop

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128997: Fix most obvious clazy and clang warnings

[Aleix Pol Gonzalez]

> On Sept. 22, 2016, 1:42 a.m., David Edmundson wrote:
> > appmenu/appmenu.cpp, line 90
> > 
> >
> > what's with this change?

The warning was saying that it's a delete of something fwd-declared. A bit more 
research suggested that it's `#if 0`'d everywhere else. So here too.


- Aleix


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128997/#review99402
---


On Sept. 22, 2016, 1:36 a.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128997/
> ---
> 
> (Updated Sept. 22, 2016, 1:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Should be ok, would like your +1 nevertheless.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/timezonemodel.cpp efd4eb2 
>   applets/notifications/plugin/notificationshelper.h 066048e 
>   appmenu/appmenu.cpp bb2e7f5 
>   components/shellprivate/interactiveconsole/interactiveconsole.cpp 12f0bb0 
>   components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp 
> 2560d5d 
>   components/shellprivate/widgetexplorer/widgetexplorer.cpp be5c9dc 
>   dataengines/apps/appsengine.cpp 81e8ce5 
>   dataengines/geolocation/geolocation.cpp 38e106c 
>   dataengines/share/shareengine.cpp 039777d 
>   dataengines/weather/ions/noaa/ion_noaa.cpp 40dcd46 
>   drkonqi/parser/backtraceparser.h 9728e20 
>   klipper/clipcommandprocess.cpp b6631b5 
>   klipper/editactiondialog.cpp afd7d3e 
>   klipper/klipper.cpp 525ef87 
>   krunner/dialog.h a34152a 
>   kuiserver/progresslistdelegate.h 0fa3d6f 
>   libtaskmanager/abstracttasksmodel.h cb6e74f 
>   libtaskmanager/abstracttasksproxymodeliface.h 4c627f1 
>   libtaskmanager/activityinfo.cpp 8427cfd 
>   libtaskmanager/flattentaskgroupsproxymodel.cpp 8b02d57 
>   libtaskmanager/taskfilterproxymodel.cpp b2cd2b1 
>   libtaskmanager/tasksmodel.h 1a7eb2c 
>   libtaskmanager/waylandtasksmodel.cpp 458a0c8 
>   plasma-windowed/main.cpp de3dff8 
>   runners/bookmarks/browsers/chrome.cpp 9d5e6e9 
>   runners/bookmarks/browsers/chromefindprofile.cpp 925083a 
>   runners/bookmarks/faviconfromblob.cpp 77512eb 
>   runners/kill/killrunner.cpp a7a7a01 
>   runners/shell/shellrunner.h 29d5d3c 
>   runners/webshortcuts/webshortcutrunner.cpp 1ad6677 
>   shell/alternativeshelper.cpp a96b266 
>   shell/containmentconfigview.cpp 3ae2985 
>   shell/desktopview.h f72add1 
>   shell/panelview.h 36c414e 
>   shell/scripting/scriptengine_v1.cpp ab33bf5 
>   shell/shellcorona.cpp 25e0378 
>   wallpapers/image/backgroundlistmodel.cpp 8130b1c 
>   wallpapers/image/image.h c488a84 
>   wallpapers/image/image.cpp ea66733 
> 
> Diff: https://git.reviewboard.kde.org/r/128997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 12 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 23:40:50 +
Build duration: 8 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1552/3774 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 12 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/12/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 23:40:50 +
Build duration: 8 min 2 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 7 test(s), Skipped: 0 test(s), Total: 7 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1552/3774 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Re: Review Request 128997: Fix most obvious clazy and clang warnings

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128997/#review99402
---




appmenu/appmenu.cpp (line 90)


what's with this change?


- David Edmundson


On Sept. 21, 2016, 11:36 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128997/
> ---
> 
> (Updated Sept. 21, 2016, 11:36 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> Should be ok, would like your +1 nevertheless.
> 
> 
> Diffs
> -
> 
>   applets/digital-clock/plugin/timezonemodel.cpp efd4eb2 
>   applets/notifications/plugin/notificationshelper.h 066048e 
>   appmenu/appmenu.cpp bb2e7f5 
>   components/shellprivate/interactiveconsole/interactiveconsole.cpp 12f0bb0 
>   components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp 
> 2560d5d 
>   components/shellprivate/widgetexplorer/widgetexplorer.cpp be5c9dc 
>   dataengines/apps/appsengine.cpp 81e8ce5 
>   dataengines/geolocation/geolocation.cpp 38e106c 
>   dataengines/share/shareengine.cpp 039777d 
>   dataengines/weather/ions/noaa/ion_noaa.cpp 40dcd46 
>   drkonqi/parser/backtraceparser.h 9728e20 
>   klipper/clipcommandprocess.cpp b6631b5 
>   klipper/editactiondialog.cpp afd7d3e 
>   klipper/klipper.cpp 525ef87 
>   krunner/dialog.h a34152a 
>   kuiserver/progresslistdelegate.h 0fa3d6f 
>   libtaskmanager/abstracttasksmodel.h cb6e74f 
>   libtaskmanager/abstracttasksproxymodeliface.h 4c627f1 
>   libtaskmanager/activityinfo.cpp 8427cfd 
>   libtaskmanager/flattentaskgroupsproxymodel.cpp 8b02d57 
>   libtaskmanager/taskfilterproxymodel.cpp b2cd2b1 
>   libtaskmanager/tasksmodel.h 1a7eb2c 
>   libtaskmanager/waylandtasksmodel.cpp 458a0c8 
>   plasma-windowed/main.cpp de3dff8 
>   runners/bookmarks/browsers/chrome.cpp 9d5e6e9 
>   runners/bookmarks/browsers/chromefindprofile.cpp 925083a 
>   runners/bookmarks/faviconfromblob.cpp 77512eb 
>   runners/kill/killrunner.cpp a7a7a01 
>   runners/shell/shellrunner.h 29d5d3c 
>   runners/webshortcuts/webshortcutrunner.cpp 1ad6677 
>   shell/alternativeshelper.cpp a96b266 
>   shell/containmentconfigview.cpp 3ae2985 
>   shell/desktopview.h f72add1 
>   shell/panelview.h 36c414e 
>   shell/scripting/scriptengine_v1.cpp ab33bf5 
>   shell/shellcorona.cpp 25e0378 
>   wallpapers/image/backgroundlistmodel.cpp 8130b1c 
>   wallpapers/image/image.h c488a84 
>   wallpapers/image/image.cpp ea66733 
> 
> Diff: https://git.reviewboard.kde.org/r/128997/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 128996: Don't generate appstream files for components that are not in rdn

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128996/
---

(Updated Sept. 21, 2016, 11:38 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 9a29e2047aaacefe38265f9ce1611124973766eb by Aleix Pol to 
branch master.


Repository: kpackage


Description
---

Appstream will spit them out anyway, better do it early in the process and with 
a warning.


Diffs
-

  KF5PackageMacros.cmake 7a12292 

Diff: https://git.reviewboard.kde.org/r/128996/diff/


Testing
---

Plasma Desktop doesn't generate information for offending components but also 
won't make the test fail.

```
  Appstream information won't be generated for kcm_splashscreen.
  Appstream information won't be generated for kcm_desktoptheme.
  Appstream information won't be generated for kcm_lookandfeel.
```


Thanks,

Aleix Pol Gonzalez

Review Request 128997: Fix most obvious clazy and clang warnings

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128997/
---

Review request for Plasma.


Repository: plasma-workspace


Description
---

Should be ok, would like your +1 nevertheless.


Diffs
-

  applets/digital-clock/plugin/timezonemodel.cpp efd4eb2 
  applets/notifications/plugin/notificationshelper.h 066048e 
  appmenu/appmenu.cpp bb2e7f5 
  components/shellprivate/interactiveconsole/interactiveconsole.cpp 12f0bb0 
  components/shellprivate/widgetexplorer/kcategorizeditemsviewmodels.cpp 
2560d5d 
  components/shellprivate/widgetexplorer/widgetexplorer.cpp be5c9dc 
  dataengines/apps/appsengine.cpp 81e8ce5 
  dataengines/geolocation/geolocation.cpp 38e106c 
  dataengines/share/shareengine.cpp 039777d 
  dataengines/weather/ions/noaa/ion_noaa.cpp 40dcd46 
  drkonqi/parser/backtraceparser.h 9728e20 
  klipper/clipcommandprocess.cpp b6631b5 
  klipper/editactiondialog.cpp afd7d3e 
  klipper/klipper.cpp 525ef87 
  krunner/dialog.h a34152a 
  kuiserver/progresslistdelegate.h 0fa3d6f 
  libtaskmanager/abstracttasksmodel.h cb6e74f 
  libtaskmanager/abstracttasksproxymodeliface.h 4c627f1 
  libtaskmanager/activityinfo.cpp 8427cfd 
  libtaskmanager/flattentaskgroupsproxymodel.cpp 8b02d57 
  libtaskmanager/taskfilterproxymodel.cpp b2cd2b1 
  libtaskmanager/tasksmodel.h 1a7eb2c 
  libtaskmanager/waylandtasksmodel.cpp 458a0c8 
  plasma-windowed/main.cpp de3dff8 
  runners/bookmarks/browsers/chrome.cpp 9d5e6e9 
  runners/bookmarks/browsers/chromefindprofile.cpp 925083a 
  runners/bookmarks/faviconfromblob.cpp 77512eb 
  runners/kill/killrunner.cpp a7a7a01 
  runners/shell/shellrunner.h 29d5d3c 
  runners/webshortcuts/webshortcutrunner.cpp 1ad6677 
  shell/alternativeshelper.cpp a96b266 
  shell/containmentconfigview.cpp 3ae2985 
  shell/desktopview.h f72add1 
  shell/panelview.h 36c414e 
  shell/scripting/scriptengine_v1.cpp ab33bf5 
  shell/shellcorona.cpp 25e0378 
  wallpapers/image/backgroundlistmodel.cpp 8130b1c 
  wallpapers/image/image.h c488a84 
  wallpapers/image/image.cpp ea66733 

Diff: https://git.reviewboard.kde.org/r/128997/diff/


Testing
---


Thanks,

Aleix Pol Gonzalez

Re: Review Request 128996: Don't generate appstream files for components that are not in rdn

[Matthias Klumpp]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128996/#review99401
---


Ship it!




Ship It!

- Matthias Klumpp


On Sept. 21, 2016, 10:41 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128996/
> ---
> 
> (Updated Sept. 21, 2016, 10:41 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> Appstream will spit them out anyway, better do it early in the process and 
> with a warning.
> 
> 
> Diffs
> -
> 
>   KF5PackageMacros.cmake 7a12292 
> 
> Diff: https://git.reviewboard.kde.org/r/128996/diff/
> 
> 
> Testing
> ---
> 
> Plasma Desktop doesn't generate information for offending components but also 
> won't make the test fail.
> 
> ```
>   Appstream information won't be generated for kcm_splashscreen.
>   Appstream information won't be generated for kcm_desktoptheme.
>   Appstream information won't be generated for kcm_lookandfeel.
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Jenkins-kde-ci: khotkeys Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 23:01:45 +
Build duration: 2 min 12 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: khotkeys Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 2 - Fixed!

[no-reply]

GENERAL INFO

BUILD SUCCESS
Build URL: 
https://build.kde.org/job/khotkeys%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/2/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 23:01:45 +
Build duration: 2 min 12 sec

CHANGE SET
No changes


JUNIT RESULTS

Name: (root) Failed: 0 test(s), Passed: 1 test(s), Skipped: 0 test(s), Total: 1 
test(s)

COBERTURA RESULTS

Cobertura Coverage Report
  

By packages
  

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 11 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/11/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 22:42:24 +
Build duration: 9 min 27 sec

CHANGE SET
Revision 5d3f0d2a15598c8d470682ec7266710516ba4637 by David Edmundson: (Add 
metadata license to appstream)
  change: edit org.kde.plasmashell.metainfo.xml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1552/3774 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Re: Review Request 128996: Don't generate appstream files for components that are not in rdn

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128996/#review99399
---



+1

- David Edmundson


On Sept. 21, 2016, 10:41 p.m., Aleix Pol Gonzalez wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128996/
> ---
> 
> (Updated Sept. 21, 2016, 10:41 p.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: kpackage
> 
> 
> Description
> ---
> 
> Appstream will spit them out anyway, better do it early in the process and 
> with a warning.
> 
> 
> Diffs
> -
> 
>   KF5PackageMacros.cmake 7a12292 
> 
> Diff: https://git.reviewboard.kde.org/r/128996/diff/
> 
> 
> Testing
> ---
> 
> Plasma Desktop doesn't generate information for offending components but also 
> won't make the test fail.
> 
> ```
>   Appstream information won't be generated for kcm_splashscreen.
>   Appstream information won't be generated for kcm_desktoptheme.
>   Appstream information won't be generated for kcm_lookandfeel.
> ```
> 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
>

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

[David Edmundson]

> On Sept. 21, 2016, 10:35 p.m., John Salatas wrote:
> > Reopened due to 
> > https://bugs.kde.org/show_bug.cgi?id=369160

No need to reopen it, just create a new review with any new changes in it.

Hopefully we'll be a bit quicker at responding. 

Note that reviews have now moved onto phabricator 
(https://community.kde.org/Infrastructure/Phabricator#Posting_a_Patch) which is 
part of the reason we missed responding to this.


- David


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review99397
---


On Sept. 18, 2016, 2:48 p.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated Sept. 18, 2016, 2:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 361210
> https://bugs.kde.org/show_bug.cgi?id=361210
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide any menu and also 
> according to bug 361210 to reorganize them.
> 
> In the attached screenshot you can see
> 
> 1) the configuration options: These are just the menu buttons than can be 
> rearranged or hidden/shown via drag n drop
> 2) The Kickoff menu with just 3 menu items (the other two are hidden).
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
>   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> ested in KDE Neon Developer Stable (as of July 14, 2016)
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png
> 
> 
> Thanks,
> 
> John Salatas
> 
>

Review Request 128996: Don't generate appstream files for components that are not in rdn

[Aleix Pol Gonzalez]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128996/
---

Review request for KDE Frameworks and Plasma.


Repository: kpackage


Description
---

Appstream will spit them out anyway, better do it early in the process and with 
a warning.


Diffs
-

  KF5PackageMacros.cmake 7a12292 

Diff: https://git.reviewboard.kde.org/r/128996/diff/


Testing
---

Plasma Desktop doesn't generate information for offending components but also 
won't make the test fail.

```
  Appstream information won't be generated for kcm_splashscreen.
  Appstream information won't be generated for kcm_desktoptheme.
  Appstream information won't be generated for kcm_lookandfeel.
```


Thanks,

Aleix Pol Gonzalez

Re: Review Request 128402: Kickoff: Ability to change the order of the menu items and hide them.

[John Salatas]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128402/#review99397
---



Reopened due to 
https://bugs.kde.org/show_bug.cgi?id=369160

- John Salatas


On Sept. 18, 2016, 2:48 p.m., John Salatas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128402/
> ---
> 
> (Updated Sept. 18, 2016, 2:48 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 361210
> https://bugs.kde.org/show_bug.cgi?id=361210
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> I'm using the Icons-Only Task Manager and it seems to me that the Favorites 
> tab in kickoff is somewhat redundant, as I have added launchers for all of my 
> favorites in the Icons-Only Task Manager.
> So in this patch I'm introducing an option to hide any menu and also 
> according to bug 361210 to reorganize them.
> 
> In the attached screenshot you can see
> 
> 1) the configuration options: These are just the menu buttons than can be 
> rearranged or hidden/shown via drag n drop
> 2) The Kickoff menu with just 3 menu items (the other two are hidden).
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/config/main.xml 2de73ba 
>   applets/kickoff/package/contents/ui/ConfigButtons.qml PRE-CREATION 
>   applets/kickoff/package/contents/ui/ConfigGeneral.qml 011b76b 
>   applets/kickoff/package/contents/ui/FullRepresentation.qml 8ac029c 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
>   applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml 
> PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/128402/diff/
> 
> 
> Testing
> ---
> 
> ested in KDE Neon Developer Stable (as of July 14, 2016)
> 
> 
> File Attachments
> 
> 
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/09/3090c598-745d-41d5-9b5c-34191cc85b04__kickoff.png
> Screenshot
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/07/14/419ec52a-04db-4cc5-b15a-7b237f0ad084__kickoff.png
> 
> 
> Thanks,
> 
> John Salatas
> 
>

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 358 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/358/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 19:04:06 +
Build duration: 7 min 33 sec

CHANGE SET
Revision 40a1af32e109902a7fe07fdbd59b38ed2105ee27 by lueck: (Proofread/update 
emoticons kcm docbook)
  change: edit doc/kcontrol/emoticons/index.docbook
  change: edit doc/kcontrol/emoticons/emoticons.png


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1532/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Breeze] [Bug 363602] Symlinked SVG files fails to load under Windows

[Jasem Mutlaq via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=363602

Jasem Mutlaq  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|UNCONFIRMED |RESOLVED

--- Comment #6 from Jasem Mutlaq  ---
This seems to have been fixed

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 128977: Proofread/update emoticons kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128977/
---

(Updated Sept. 21, 2016, 7:03 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit 40a1af32e109902a7fe07fdbd59b38ed2105ee27 by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

proofread
fix kde4 path
kde-look.org -> store.kde.org
update screenshot


Diffs
-

  doc/kcontrol/emoticons/emoticons.png b46c8c4 
  doc/kcontrol/emoticons/index.docbook 327a803 

Diff: https://git.reviewboard.kde.org/r/128977/diff/


Testing
---

passes checkXML5


File Attachments


emoticons.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/16b1128d-3014-4f35-9274-a406bc1d8ab3__emoticons.png


Thanks,

Burkhard Lück

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 357 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/357/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 18:49:05 +
Build duration: 7 min 31 sec

CHANGE SET
Revision c94a2cb6b0dedb9a67a66b15e7c02b0451e9b6b9 by lueck: (Proofread/update 
kcmstyle (Widget Style) kcm docbook)
  change: edit doc/kcontrol/kcmstyle/index.docbook


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1532/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 356 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/356/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 18:40:50 +
Build duration: 7 min 41 sec

CHANGE SET
Revision 450724b0b50d396dcc5ebd08d6e918c51402bafd by lueck: (Update color kcm 
docbook to 5.8)
  change: edit doc/kcontrol/colors/index.docbook


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1532/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Re: Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128978/
---

(Updated Sept. 21, 2016, 6:45 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit c94a2cb6b0dedb9a67a66b15e7c02b0451e9b6b9 by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

proofread
remove obsolete option


Diffs
-

  doc/kcontrol/kcmstyle/index.docbook 82cd571 

Diff: https://git.reviewboard.kde.org/r/128978/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128965: Update color kcm docbook to 5.8

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128965/
---

(Updated Sept. 21, 2016, 6:40 p.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation, Plasma and Olivier Churlaud.


Changes
---

Submitted with commit 450724b0b50d396dcc5ebd08d6e918c51402bafd by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

Adapt docbook to changed kcm in 5.8


Diffs
-

  doc/kcontrol/colors/index.docbook 75548b5 

Diff: https://git.reviewboard.kde.org/r/128965/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128950/#review99390
---



for reference, look at what the recent commit 
b2d91a39740b003f4440e1e7df0a26a43fbb51a4 in plasma-workspace does, you need 
something along the lines

- Marco Martin


On Sept. 20, 2016, 2:25 p.m., Kamil Sołtysik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128950/
> ---
> 
> (Updated Sept. 20, 2016, 2:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=363592
> 
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=363592
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As stated in doc here: 
> https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Panels
>  Panels should allow to be placed on selected screen by setting value of 
> Panel::screen property. While looking at code I found out that this property 
> is read-only in code. Patch changes that.
> 
> 
> Diffs
> -
> 
>   shell/scripting/panel.h 0d70784 
>   shell/scripting/panel.cpp b9383df 
> 
> Diff: https://git.reviewboard.kde.org/r/128950/diff/
> 
> 
> Testing
> ---
> 
> Panel's position can now be changed by setting the property. Setting invalid 
> value causes no response.
> 
> 
> File Attachments
> 
> 
> plasma-workspace-2.patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/20/bc1df578-8758-48e4-b2b2-a53792c803f8__plasma-workspace-2.patch
> 
> 
> Thanks,
> 
> Kamil Sołtysik
> 
>

[Differential] [Closed] D2827: Polish SwipeListItem

[apol (Aleix Pol Gonzalez)]

This revision was automatically updated to reflect the committed changes.
apol marked an inline comment as done.
Closed by commit rKIRIGAMIf90a5ca65f04: Polish SwipeListItem (authored by apol).

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2827?vs=6856=6857

REVISION DETAIL
  https://phabricator.kde.org/D2827

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Accepted] D2827: Polish SwipeListItem

[mart (Marco Martin)]

mart accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2827

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Updated] D2827: Polish SwipeListItem

[apol (Aleix Pol Gonzalez)]

apol marked an inline comment as done.
apol added inline comments.

INLINE COMMENTS

> mart wrote in SwipeListItem.qml:362
> what's the rationale for this?

Good point, fixed.

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2827

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Updated, 28 lines] D2827: Polish SwipeListItem

[apol (Aleix Pol Gonzalez)]

apol updated this revision to Diff 6856.
apol added a comment.


  Reduce magic numbers

REPOSITORY
  rKIRIGAMI Kirigami

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2827?vs=6855=6856

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2827

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Commented On] D2827: Polish SwipeListItem

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> SwipeListItem.qml:362
>  margins: Units.smallSpacing
> +rightMargin: handleIcon.width * 2
>  }

what's the rationale for this?

REPOSITORY
  rKIRIGAMI Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D2827

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

[Differential] [Request, 21 lines] D2827: Polish SwipeListItem

[apol (Aleix Pol Gonzalez)]

apol created this revision.
apol added reviewers: Kirigami, mart.
Restricted Application added a project: Kirigami.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Make sure we don't have 2 different code paths for contentItem
  initialization as one of them had a different parent.
  Set a negative z to the background, to make sure it's below the contents.
  Don't let the padding go over the handle, this way the contens will be
  able to fit to the space

TEST PLAN
  Looks the same on kirigamigallery
  Now we can make it look okay in discover, as some neon sources get really 
long.

REPOSITORY
  rKIRIGAMI Kirigami

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2827

AFFECTED FILES
  src/controls/templates/SwipeListItem.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: apol, #kirigami, mart
Cc: plasma-devel, apol

Re: Review Request 128973: Update icon lcm docbook

[Marco Martin]

> On Sept. 21, 2016, 2:58 p.m., Marco Martin wrote:
> > doc/kcontrol/icons/index.docbook, line 33
> > 
> >
> > uppercase Plasma, Dolphin etc?
> 
> Burkhard Lück wrote:
> frameworks/kdoctools
> 
> general.entities:400:Plasma">
> 
> general.entities:136: "Dolphin">
> 
> these entities expang in the html to uppercase

ah, ok, thanks!


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/#review99368
---


On Sept. 21, 2016, 12:32 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128973/
> ---
> 
> (Updated Sept. 21, 2016, 12:32 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> kde -> plasma
> konqueror -> dolphin
> remove kdeartwork
> remove obsolete para already commented since 4.5
> update old screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/icons/delete-theme.png 8421b7e 
>   doc/kcontrol/icons/effects.png b992dff 
>   doc/kcontrol/icons/index.docbook 27a6c9e 
>   doc/kcontrol/icons/size.png 599c162 
> 
> Diff: https://git.reviewboard.kde.org/r/128973/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> size.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
> effects.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
> delete-theme.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128973: Update icon lcm docbook

[Burkhard Lück]

> On Sept. 21, 2016, 2:58 nachm., Marco Martin wrote:
> > doc/kcontrol/icons/index.docbook, line 33
> > 
> >
> > uppercase Plasma, Dolphin etc?

frameworks/kdoctools

general.entities:400:Plasma">

general.entities:136:Dolphin">

these entities expang in the html to uppercase


> On Sept. 21, 2016, 2:58 nachm., Marco Martin wrote:
> > doc/kcontrol/icons/index.docbook, line 65
> > 
> >
> > uppercase (and subsequent ones too)

see obove


- Burkhard


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/#review99368
---


On Sept. 21, 2016, 12:32 nachm., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128973/
> ---
> 
> (Updated Sept. 21, 2016, 12:32 nachm.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> kde -> plasma
> konqueror -> dolphin
> remove kdeartwork
> remove obsolete para already commented since 4.5
> update old screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/icons/delete-theme.png 8421b7e 
>   doc/kcontrol/icons/effects.png b992dff 
>   doc/kcontrol/icons/index.docbook 27a6c9e 
>   doc/kcontrol/icons/size.png 599c162 
> 
> Diff: https://git.reviewboard.kde.org/r/128973/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> size.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
> effects.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
> delete-theme.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128978/#review99365
---


Ship it!




Ship It!

- Marco Martin


On Sept. 21, 2016, 1:31 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128978/
> ---
> 
> (Updated Sept. 21, 2016, 1:31 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread
> remove obsolete option
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/kcmstyle/index.docbook 82cd571 
> 
> Diff: https://git.reviewboard.kde.org/r/128978/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128977: Proofread/update emoticons kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128977/#review99366
---


Ship it!




Ship It!

- Marco Martin


On Sept. 21, 2016, 1:16 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128977/
> ---
> 
> (Updated Sept. 21, 2016, 1:16 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> proofread
> fix kde4 path
> kde-look.org -> store.kde.org
> update screenshot
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/emoticons/emoticons.png b46c8c4 
>   doc/kcontrol/emoticons/index.docbook 327a803 
> 
> Diff: https://git.reviewboard.kde.org/r/128977/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> emoticons.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/16b1128d-3014-4f35-9274-a406bc1d8ab3__emoticons.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128973: Update icon lcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/#review99368
---


Fix it, then Ship it!





doc/kcontrol/icons/index.docbook (line 33)


uppercase Plasma, Dolphin etc?



doc/kcontrol/icons/index.docbook (line 65)


uppercase (and subsequent ones too)


- Marco Martin


On Sept. 21, 2016, 12:32 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128973/
> ---
> 
> (Updated Sept. 21, 2016, 12:32 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> kde -> plasma
> konqueror -> dolphin
> remove kdeartwork
> remove obsolete para already commented since 4.5
> update old screenshots
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/icons/delete-theme.png 8421b7e 
>   doc/kcontrol/icons/effects.png b992dff 
>   doc/kcontrol/icons/index.docbook 27a6c9e 
>   doc/kcontrol/icons/size.png 599c162 
> 
> Diff: https://git.reviewboard.kde.org/r/128973/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> File Attachments
> 
> 
> size.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
> effects.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
> delete-theme.png
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128974: Proofread/update cursortheme kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128974/#review99367
---


Ship it!




Ship It!

- Marco Martin


On Sept. 21, 2016, 12:42 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128974/
> ---
> 
> (Updated Sept. 21, 2016, 12:42 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Proofread/update cursortheme kcm docbook
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/cursortheme/index.docbook 51ca419 
> 
> Diff: https://git.reviewboard.kde.org/r/128974/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

[Differential] [Request, 9 lines] D2826: Fix shortcuts editor with double click to activate enabled

[davidedmundson (David Edmundson)]

davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Semantically we want to show the suboptions on selection not activation.
  Also it fixes an issue that as we use double click for rename a user
  with double click to activate can't open anything.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D2826

AFFECTED FILES
  kcms/keys/kglobalshortcutseditor.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Updated] D2796: Fix valgrind warning in volume and channelMap memcmp

[davidedmundson (David Edmundson)]

davidedmundson updated the summary for this revision.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D2796

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: davidedmundson, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 355 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/355/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 13:29:44 +
Build duration: 24 min

CHANGE SET
Revision 14972276d9fb9eb34098a29cf6b47f461e2d8846 by David Edmundson: (Create a 
QtQuickLayout attached object on kickoff compact representation)
  change: edit applets/kickoff/package/contents/ui/Kickoff.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1532/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 10 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/10/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 13:29:09 +
Build duration: 19 min

CHANGE SET
Revision 14972276d9fb9eb34098a29cf6b47f461e2d8846 by David Edmundson: (Create a 
QtQuickLayout attached object on kickoff compact representation)
  change: edit applets/kickoff/package/contents/ui/Kickoff.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1552/3774 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Review Request 128978: Proofread/update kcmstyle (Widget Style) kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128978/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

proofread
remove obsolete option


Diffs
-

  doc/kcontrol/kcmstyle/index.docbook 82cd571 

Diff: https://git.reviewboard.kde.org/r/128978/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[Breeze] [Bug 369158] New: Breeze sddm theme broken on dual monitor setup (no cursor)

[Andreas Eckstein via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369158

Bug ID: 369158
   Summary: Breeze sddm theme broken on dual monitor setup (no
cursor)
   Product: Breeze
   Version: 5.7.95
  Platform: Other
OS: Linux
Status: UNCONFIRMED
  Severity: normal
  Priority: NOR
 Component: general
  Assignee: plasma-devel@kde.org
  Reporter: andreas.eckst...@gmx.net

Hi,

the breeze sddm theme (plasma 5.7.95) works fine on my laptop when it is not
docked, the docking station however has two monitors attached. Both monitors
correctly display sddm on startup, but there is no (visible) mouse cursor, and
TAB can't be used to cycle the input focus. Or maybe sddm just freezes up, hard
to tell. The elarun theme in contrast works fine.

Reproducible: Always

-- 
You are receiving this mail because:
You are the assignee for the bug.

Review Request 128977: Proofread/update emoticons kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128977/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

proofread
fix kde4 path
kde-look.org -> store.kde.org
update screenshot


Diffs
-

  doc/kcontrol/emoticons/emoticons.png b46c8c4 
  doc/kcontrol/emoticons/index.docbook 327a803 

Diff: https://git.reviewboard.kde.org/r/128977/diff/


Testing
---

passes checkXML5


File Attachments


emoticons.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/16b1128d-3014-4f35-9274-a406bc1d8ab3__emoticons.png


Thanks,

Burkhard Lück

[Differential] [Closed] D2825: [Panel Config View] Set Qt::WindowStaysOnTopHint

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEdacb6b27dcd0: [Panel Config View] Set 
Qt::WindowStaysOnTopHint (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2825?vs=6851=6852

REVISION DETAIL
  https://phabricator.kde.org/D2825

AFFECTED FILES
  shell/panelconfigview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Review Request 128974: Proofread/update cursortheme kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128974/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

Proofread/update cursortheme kcm docbook


Diffs
-

  doc/kcontrol/cursortheme/index.docbook 51ca419 

Diff: https://git.reviewboard.kde.org/r/128974/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[Differential] [Accepted] D2825: [Panel Config View] Set Qt::WindowStaysOnTopHint

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2825

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 4 lines] D2825: [Panel Config View] Set Qt::WindowStaysOnTopHint

[broulik (Kai Uwe Broulik)]

broulik created this revision.
broulik added a reviewer: Plasma.
broulik set the repository for this revision to rPLASMAWORKSPACE Plasma 
Workspace.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  We set KeepAbove using KWindowSystem but since Qt 5.7 apparently Qt does 
something weird and loses the flag.
  Explicitly add it to flags. Not doing any other cleanup in the code because 
this is critical for 5.8.0.

TEST PLAN
  Panel controller now shows up ontop of other panels again

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2825

AFFECTED FILES
  shell/panelconfigview.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 354 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/354/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 12:14:17 +
Build duration: 17 min

CHANGE SET
Revision ea8374a149e592798e1f0cbdd667386c8d87b9af by David Edmundson: (Add 
missing files from 94eedfe86c08817ef646cda463b4706f5296e085)
  change: edit imports/activitymanager/sortedactivitiesmodel.cpp
  change: add applets/kickoff/package/contents/ui/ConfigButtons.qml
  change: add applets/kickoff/package/contents/ui/KickoffConfigurationButton.qml


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1532/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Review Request 128973: Update icon lcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128973/
---

Review request for Documentation and Plasma.


Repository: plasma-desktop


Description
---

kde -> plasma
konqueror -> dolphin
remove kdeartwork
remove obsolete para already commented since 4.5
update old screenshots


Diffs
-

  doc/kcontrol/icons/delete-theme.png 8421b7e 
  doc/kcontrol/icons/effects.png b992dff 
  doc/kcontrol/icons/index.docbook 27a6c9e 
  doc/kcontrol/icons/size.png 599c162 

Diff: https://git.reviewboard.kde.org/r/128973/diff/


Testing
---

passes checkXML5


File Attachments


size.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/83dc0115-520c-4f95-8720-25511309c810__size.png
effects.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/e1ec13b3-0a9f-4418-ac74-269146240886__effects.png
delete-theme.png
  
https://git.reviewboard.kde.org/media/uploaded/files/2016/09/21/38753dee-193f-46a5-b06e-b61a7733ba7b__delete-theme.png


Thanks,

Burkhard Lück

Re: Review Request 128760: Fix crash on exit

[Peter Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/
---

(Updated Sept. 21, 2016, 12:19 p.m.)


Status
--

This change has been marked as submitted.


Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da 
Costa.


Changes
---

Submitted with commit 23e54baa3cf1258b5d105c22609103d13868583f by Hugo Pereira 
Da Costa on behalf of Peter Wu to branch Plasma/5.7.


Bugs: 356940
https://bugs.kde.org/show_bug.cgi?id=356940


Repository: breeze


Description
---

Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
point to this delete-on-destroy hack which was added to avoid outliving
the plugin lifetime.

This method is wrong because the returned style is owned by the caller
(QApplication, QProxyStyle, etc) and will cleaned up when those users
are destructed.


Diffs
-

  kstyle/breezestyleplugin.cpp 083100e 

Diff: https://git.reviewboard.kde.org/r/128760/diff/


Testing
---

Ran the updated test.sh from "Testcase (ASAN) with normal QApplication::quit 
and exit()" from bug https://bugs.kde.org/show_bug.cgi?id=356940, no longer 
crashes. Tested with Qt 5.7.0.


Thanks,

Peter Wu

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

[Rudd-O]

https://bugs.kde.org/show_bug.cgi?id=369129

--- Comment #5 from Manuel Amador (Rudd-O)  ---
We should tackle the problem with KDE first, as KDE moves faster than GNOME and
has a long history of innovating in this space (Solid).  A KDE-only /
Powerdevil-only solution is adequate for the first iteration of the PulseAudio
side of things.  Later on, we can ask the Power Manager folks to adopt the same
inhibition policy.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

[Rudd-O]

https://bugs.kde.org/show_bug.cgi?id=369129

--- Comment #4 from Manuel Amador (Rudd-O)  ---
I don't think things further up the stack have the necessary information to
make an informed decision.  The "sound card" of HDMI outs and the video cards
powering them appear as different PCI devices in many cases.  Those layers up
the stack also do not know how to report back to Powerdevil "well, the reason
we are not shutting the screen off, is because HDMI audio is active", primarily
because it is stuff like Powerdevil which is in charge of policy and setting
the right DPMS configuration bits on the X server (I assume something similar
happens in Wayland).

However, if Powerdevil provided an inhibitor (class) that would explicitly
inhibit DPMS — but nothing else, not the screensaver, not screenlock in the
screensaver, not suspend, not hibernate — then a plugin at the PulseAudio level
of the stack can talk to Powerdevil and use that inhibitor class whenever there
is an active HDMI audio stream, which is something that PulseAudio is perfectly
positioned to know about.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 128760: Fix crash on exit

[Peter Wu]

> On Sept. 17, 2016, 11:39 p.m., Hugo Pereira Da Costa wrote:
> > Sorry for the delay
> > ... for some reason I don't always recieve notifications from reviewboard
> 
> Hugo Pereira Da Costa wrote:
> Ping ? 
> Do people have commit rights ? Should I commit it myself ?

I think you should commit it, same for 
https://git.reviewboard.kde.org/r/128761/ which is already marked as Ship it 
for 3 weeks. (I have no push rights.)


- Peter


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/#review99244
---


On Aug. 27, 2016, 11:04 a.m., Peter Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128760/
> ---
> 
> (Updated Aug. 27, 2016, 11:04 a.m.)
> 
> 
> Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da 
> Costa.
> 
> 
> Bugs: 356940
> https://bugs.kde.org/show_bug.cgi?id=356940
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
> point to this delete-on-destroy hack which was added to avoid outliving
> the plugin lifetime.
> 
> This method is wrong because the returned style is owned by the caller
> (QApplication, QProxyStyle, etc) and will cleaned up when those users
> are destructed.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyleplugin.cpp 083100e 
> 
> Diff: https://git.reviewboard.kde.org/r/128760/diff/
> 
> 
> Testing
> ---
> 
> Ran the updated test.sh from "Testcase (ASAN) with normal QApplication::quit 
> and exit()" from bug https://bugs.kde.org/show_bug.cgi?id=356940, no longer 
> crashes. Tested with Qt 5.7.0.
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

[Differential] [Commented On] D2820: Updating the wallpaper cache only when the configuration file settles

[davidedmundson (David Edmundson)]

davidedmundson added inline comments.

INLINE COMMENTS

> sortedactivitiesmodel.cpp:197
>  bool initialized;
> -KConfig plasmaConfig;
> +KSharedConfig::Ptr plasmaConfig;
> +QTimer updateTimer;

Now it's a sharedconfig (a *very* sensible change) - you don't even need to 
call  reparseConfiguration().

that means it's fairly cheap to call reload.

that means you don't need the timer.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2820

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

Is it possible to include in the plasmoid file the translations?

[Michail Vourlakos]

Hello everyone,

is it possible inside the .plasmoid file to include the various 
translations some how? I am referring to .mo files...



regards,

michail

[Differential] [Closed] D2824: Make sure that default devices are not null

[drosca (David Rosca)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAPA270110e5520f: Make sure that default devices are not 
null (authored by drosca).

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2824?vs=6847=6850

REVISION DETAIL
  https://phabricator.kde.org/D2824

AFFECTED FILES
  src/server.cpp
  src/server.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

[Oliver Henshaw via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369129

Oliver Henshaw  changed:

   What|Removed |Added

 CC||oliver.hens...@gmail.com

--- Comment #3 from Oliver Henshaw  ---
I thought about this kind of thing once since I had another use-case - a screen
where the speaker is powered by the monitor so DPMS would cut the sound.
Fortunately in that case the monitor can be configured to keep audio power on
when the screen was off.

This was part of the motivation for the proposal in bug 318461. I think that
the idea was that screen locking was something that happened when the session
was idle, but screen power-saving was something that happened when the screen
(logind seat? device?) was idle. Then normally the screen being locked would
mean the screen becomes idle but things like screen-powered audio or, now, HDMI
audio could inhibit this.

More practically, it may be feasible for active HDMI audio to inhibit screen
power saving in the same way external screens currently inhibit any kind of
screen interruption. How does that sound, Kai?


I also wonder if this could be handled better with help from further up the
stack. Is there an opportunity to do things better with wayland than with
xserver dpms?

Is there a gnome (or other desktop) bug filed too, or are you only interested
in a KDE Plasma solution?

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 128966: Don't include kdeglobals when dealing with a cache config

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128966/
---

(Updated Sept. 21, 2016, 12:44 p.m.)


Status
--

This change has been marked as submitted.


Review request for KDE Frameworks and Plasma.


Changes
---

Submitted with commit 494c690b18ab1d61bfa7b9998d0f40411364a18c by David 
Edmundson to branch master.


Repository: plasma-framework


Description
---

The svg elements cache isn't really a "configuration" and it's not
something that should be overridden by global config settings.

Loading it as a simple config skips the cascading and saves reparsing
kdeglobals.


Diffs
-

  src/plasma/private/theme_p.cpp 18c7a734141b89e9c6ba7f7689371614d60af927 

Diff: https://git.reviewboard.kde.org/r/128966/diff/


Testing
---


Thanks,

David Edmundson

Re: Review Request 128392: [kickoff] kickoff should use icons from icon theme

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128392/#review99349
---



Any news on that?

- Marco Martin


On July 11, 2016, 10:51 a.m., Andrey Bondrov wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128392/
> ---
> 
> (Updated July 11, 2016, 10:51 a.m.)
> 
> 
> Review request for Plasma, KDE Usability and Eike Hein.
> 
> 
> Bugs: 365204
> https://bugs.kde.org/show_bug.cgi?id=365204
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Likely kickoff should use icons from icon theme, not from plasma theme. 
> 
> https://bugs.kde.org/show_bug.cgi?id=365204
> 
> 
> Diffs
> -
> 
>   applets/kickoff/package/contents/ui/KickoffButton.qml 6b3a2b7 
> 
> Diff: https://git.reviewboard.kde.org/r/128392/diff/
> 
> 
> Testing
> ---
> 
> 1. Added kickoff applet to desktop
> 2. Swicthed from Breeze LAF to Oxygen
> 3. Rebooted
> 4. Kickoff got mixed Breeze and Oxygen icons (see screenshot in #365204)
> 5. Applied the patch
> 6. Rebooted
> 7. All Kickoff icons are properly set to Oxygen
> 
> 
> Thanks,
> 
> Andrey Bondrov
> 
>

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 353 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/353/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 10:17:24 +
Build duration: 12 min

CHANGE SET
Revision 6c3de2f1ffaf681533e4c624c11581702ce601ff by lueck: (Update shortcuts 
kcm docbook)
  change: add doc/kcontrol/keys/remove.png
  change: add doc/kcontrol/keys/list-add.png
  change: edit doc/kcontrol/keys/index.docbook


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1532/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

[Breeze] [Bug 341762] When utilizing the Breeze theme for SDDM, it takes ages for SDDM to startup.

[via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=341762

bl...@vivaldi.net changed:

   What|Removed |Added

 CC||bl...@vivaldi.net

--- Comment #8 from bl...@vivaldi.net ---
Can confirm this for Plasma 5.7.x (K)Ubuntu 16.10 YY.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 352 - Still unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/352/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 09:54:08 +
Build duration: 21 min

CHANGE SET
Revision 9d55c52f76cf831584d71d60a8806688f37ea0cc by kde: ([KeyboardDaemon] 
Don#039;t call getCurrentLayout() in destructor)
  change: edit kcms/keyboard/keyboard_daemon.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1532/3733 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 600/1672 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
431/1110 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Jenkins-kde-ci: plasma-desktop Plasma-5.8 stable-kf5-qt5 » Linux,gcc - Build # 9 - Still Unstable!

[no-reply]

GENERAL INFO

BUILD UNSTABLE
Build URL: 
https://build.kde.org/job/plasma-desktop%20Plasma-5.8%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/9/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 09:53:44 +
Build duration: 22 min

CHANGE SET
Revision 9d55c52f76cf831584d71d60a8806688f37ea0cc by kde: ([KeyboardDaemon] 
Don#039;t call getCurrentLayout() in destructor)
  change: edit kcms/keyboard/keyboard_daemon.cpp


JUNIT RESULTS

Name: (root) Failed: 1 test(s), Passed: 6 test(s), Skipped: 0 test(s), Total: 7 
test(s)Failed: TestSuite.appstreamtest

COBERTURA RESULTS

Cobertura Coverage Report
  PACKAGES 7/7 (100%)FILES 36/39 (92%)CLASSES 36/39 (92%)LINE 2275/3386 
(67%)CONDITIONAL 1552/3774 (41%)

By packages
  
kcms.cursortheme.xcursor
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 99/192 (52%)CONDITIONAL 
22/98 (22%)
kcms.keyboard
FILES 20/23 (87%)CLASSES 20/23 (87%)LINE 743/1511 
(49%)CONDITIONAL 619/1711 (36%)
kcms.keyboard.preview
FILES 4/4 (100%)CLASSES 4/4 (100%)LINE 500/582 (86%)CONDITIONAL 
432/1112 (39%)
kcms.keyboard.tests
FILES 5/5 (100%)CLASSES 5/5 (100%)LINE 229/231 (99%)CONDITIONAL 
236/358 (66%)
kcms.krdb
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 348/401 (87%)CONDITIONAL 
108/196 (55%)
kcms.lookandfeel
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 256/369 (69%)CONDITIONAL 
83/195 (43%)
kcms.lookandfeel.autotests
FILES 1/1 (100%)CLASSES 1/1 (100%)LINE 100/100 
(100%)CONDITIONAL 52/104 (50%)

Re: Review Request 128948: Update shortcuts kcm docbook

[Burkhard Lück]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/
---

(Updated Sept. 21, 2016, 10:11 a.m.)


Status
--

This change has been marked as submitted.


Review request for Documentation and Plasma.


Changes
---

Submitted with commit 6c3de2f1ffaf681533e4c624c11581702ce601ff by Burkhard Lück 
to branch master.


Repository: plasma-desktop


Description
---

adapt to changes in 5.8


Diffs
-

  doc/kcontrol/keys/index.docbook 27eab50 

Diff: https://git.reviewboard.kde.org/r/128948/diff/


Testing
---

passes checkXML5


Thanks,

Burkhard Lück

[Differential] [Closed] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMADESKTOP9d55c52f76cf: [KeyboardDaemon] Don't call 
getCurrentLayout() in destructor (authored by broulik).

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2818?vs=6828=6849

REVISION DETAIL
  https://phabricator.kde.org/D2818

AFFECTED FILES
  kcms/keyboard/keyboard_daemon.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sitter, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2824: Make sure that default devices are not null

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2824

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[kio-extras] [Bug 364642] 16.04.3: kio_sftp is broken

[Elvis Angelaccio via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=364642

Elvis Angelaccio  changed:

   What|Removed |Added

  Component|general |default
   Assignee|dolphin-bugs-n...@kde.org   |plasma-devel@kde.org
Product|dolphin |kio-extras
 CC||elvis.angelac...@kde.org

--- Comment #4 from Elvis Angelaccio  ---
Moving to kio-extras where kio_sftp belongs.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Breeze] [Bug 365025] Breeze Dark Theme made Dolphin main view hard to read

[Elvis Angelaccio via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=365025

Elvis Angelaccio  changed:

   What|Removed |Added

   Assignee|dolphin-bugs-n...@kde.org   |plasma-devel@kde.org
Product|dolphin |Breeze
 CC||elvis.angelac...@kde.org
Version|15.12.3 |5.7.5
 Status|UNCONFIRMED |RESOLVED
  Component|general |general
 Resolution|--- |FIXED

--- Comment #1 from Elvis Angelaccio  ---
Breeze dark has improved a lot and now Dolphin is perfectly usable with it. Try
again with a more recent breeze version.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Re: Review Request 128966: Don't include kdeglobals when dealing with a cache config

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128966/#review99348
---


Ship it!




good catch

- Marco Martin


On Sept. 21, 2016, 6:13 a.m., David Edmundson wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128966/
> ---
> 
> (Updated Sept. 21, 2016, 6:13 a.m.)
> 
> 
> Review request for KDE Frameworks and Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> ---
> 
> The svg elements cache isn't really a "configuration" and it's not
> something that should be overridden by global config settings.
> 
> Loading it as a simple config skips the cascading and saves reparsing
> kdeglobals.
> 
> 
> Diffs
> -
> 
>   src/plasma/private/theme_p.cpp 18c7a734141b89e9c6ba7f7689371614d60af927 
> 
> Diff: https://git.reviewboard.kde.org/r/128966/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

Jenkins-kde-ci: plasma-desktop master kf5-qt5 » Linux,gcc - Build # 351 - Failure!

[no-reply]

GENERAL INFO

BUILD FAILURE
Build URL: 
https://build.kde.org/job/plasma-desktop%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/351/
Project: PLATFORM=Linux,compiler=gcc
Date of build: Wed, 21 Sep 2016 09:26:17 +
Build duration: 3 min 38 sec

CHANGE SET
Revision fb66f14b0410b0cc8a758165a58e734ee55ca8d0 by scripty: (SVN_SILENT made 
messages (.desktop file) - always resolve ours)
  change: edit kcms/keys/keys.desktop
  change: edit dataengines/kimpanel/plasma-dataengine-kimpanel.desktop
  change: edit solid-device-automounter/kded/device_automounter.desktop
  change: edit kcms/translations/translations.desktop
  change: edit kcms/keyboard/keyboard.desktop
  change: edit kcms/standard_actions/standard_actions.desktop
  change: edit kcms/colors/org.kde.kcolorschemeeditor.desktop
  change: edit applets/kimpanel/package/metadata.desktop
  change: edit solid-device-automounter/kcm/device_automounter_kcm.desktop
  change: edit kcms/activities/kcm_activities.desktop
  change: edit runners/kwin/plasma-runner-kwin.desktop

[Differential] [Commented On] D2820: Updating the wallpaper cache only when the configuration file settles

[mart (Marco Martin)]

mart added inline comments.

INLINE COMMENTS

> sortedactivitiesmodel.cpp:65
> +updateTimer.setSingleShot(true);
> +updateTimer.setInterval(500);
> +

is a blind timer the only way to wait enough? :/

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2820

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Accepted] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

[mart (Marco Martin)]

mart accepted this revision.
mart added a reviewer: mart.
This revision is now accepted and ready to land.

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2818

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sitter, mart
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

[Marco Martin]

> On Sept. 19, 2016, 9:52 p.m., Marco Martin wrote:
> > shell/scripting/panel.cpp, line 189
> > 
> >
> > this can't rely on the order of qGuiApp->screens, but should use 
> > screenpool in shellcorona, it's the only place where you can find a 
> > reliable mapping
> 
> Kamil Sołtysik wrote:
> From what I understood from the code, I need first to match ID with a 
> connector and then search for a screen with matching connector in 
> qGuiApp->screens, right?

the function to phisically move the panel can only be in shellcorona (using 
m_screenPool, don't try to reimplement its logic).
and should be:

* if the panel view exists, discover the id using screenpool 
(qGuiApp->screens().indexOf is *not* the id)

* if it doesn't, write the lastScreen config entry in the panel config


- Marco


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128950/#review99285
---


On Sept. 20, 2016, 2:25 p.m., Kamil Sołtysik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128950/
> ---
> 
> (Updated Sept. 20, 2016, 2:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=363592
> 
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=363592
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As stated in doc here: 
> https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Panels
>  Panels should allow to be placed on selected screen by setting value of 
> Panel::screen property. While looking at code I found out that this property 
> is read-only in code. Patch changes that.
> 
> 
> Diffs
> -
> 
>   shell/scripting/panel.h 0d70784 
>   shell/scripting/panel.cpp b9383df 
> 
> Diff: https://git.reviewboard.kde.org/r/128950/diff/
> 
> 
> Testing
> ---
> 
> Panel's position can now be changed by setting the property. Setting invalid 
> value causes no response.
> 
> 
> File Attachments
> 
> 
> plasma-workspace-2.patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/20/bc1df578-8758-48e4-b2b2-a53792c803f8__plasma-workspace-2.patch
> 
> 
> Thanks,
> 
> Kamil Sołtysik
> 
>

Re: Review Request 128948: Update shortcuts kcm docbook

[Marco Martin]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128948/#review99346
---


Ship it!




Ship It!

- Marco Martin


On Sept. 20, 2016, 5:26 p.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128948/
> ---
> 
> (Updated Sept. 20, 2016, 5:26 p.m.)
> 
> 
> Review request for Documentation and Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> adapt to changes in 5.8
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/keys/index.docbook 27eab50 
> 
> Diff: https://git.reviewboard.kde.org/r/128948/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

[Differential] [Closed] D2823: [Device Notifier] Only ever pop up if device is visible in the list

[broulik (Kai Uwe Broulik)]

This revision was automatically updated to reflect the committed changes.
Closed by commit rPLASMAWORKSPACEb28ea53b351c: [Device Notifier] Only ever pop 
up if device is visible in the list (authored by broulik).

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D2823?vs=6839=6848

REVISION DETAIL
  https://phabricator.kde.org/D2823

AFFECTED FILES
  applets/devicenotifier/package/contents/ui/devicenotifier.qml

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson, sitter
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Changed Subscribers] D2820: Updating the wallpaper cache only when the configuration file settles

[broulik (Kai Uwe Broulik)]

broulik added inline comments.

INLINE COMMENTS

> sortedactivitiesmodel.cpp:49
> +, plasmaConfig(KSharedConfig::openConfig(PLASMACONFIG))
> +, updateTimer()
>  {

Not needed?

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2820

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: ivan, #plasma, davidedmundson, mart
Cc: broulik, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas

[Differential] [Updated] D2818: [KeyboardDaemon] Don't call getCurrentLayout() in destructor

[sitter (Harald Sitter)]

sitter added a comment.


  seems to not be crashing anymore. unfortunately I can't comment on the 
correctness of the change

REPOSITORY
  rPLASMADESKTOP Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D2818

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, sitter
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Accepted] D2823: [Device Notifier] Only ever pop up if device is visible in the list

[sitter (Harald Sitter)]

sitter accepted this revision.
sitter added a comment.


  lgtm. and it works \o/

REPOSITORY
  rPLASMAWORKSPACE Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D2823

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: broulik, #plasma, davidedmundson, sitter
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

[Differential] [Request, 43 lines] D2824: Make sure that default devices are not null

[drosca (David Rosca)]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Sometimes at the time when default sink/source change is signalled
  by pa, we don't have that device in sinks/sources list yet.
  Try to update default devices also when sinks/sources are added and
  deleted.
  
  BUG: 366149

REPOSITORY
  rPLASMAPA Plasma Audio Volume Applet

BRANCH
  Plasma/5.8

REVISION DETAIL
  https://phabricator.kde.org/D2824

AFFECTED FILES
  src/server.cpp
  src/server.h

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas

Re: Review Request 128965: Update color kcm docbook to 5.8

[Olivier Churlaud]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128965/#review99344
---


Ship it!




Ship It!

- Olivier Churlaud


On Sept. 21, 2016, 5:42 a.m., Burkhard Lück wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128965/
> ---
> 
> (Updated Sept. 21, 2016, 5:42 a.m.)
> 
> 
> Review request for Documentation, Plasma and Olivier Churlaud.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> ---
> 
> Adapt docbook to changed kcm in 5.8
> 
> 
> Diffs
> -
> 
>   doc/kcontrol/colors/index.docbook 75548b5 
> 
> Diff: https://git.reviewboard.kde.org/r/128965/diff/
> 
> 
> Testing
> ---
> 
> passes checkXML5
> 
> 
> Thanks,
> 
> Burkhard Lück
> 
>

Re: Review Request 128760: Fix crash on exit

[Hugo Pereira Da Costa]

> On Sept. 17, 2016, 9:39 p.m., Hugo Pereira Da Costa wrote:
> > Sorry for the delay
> > ... for some reason I don't always recieve notifications from reviewboard

Ping ? 
Do people have commit rights ? Should I commit it myself ?


- Hugo


---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128760/#review99244
---


On Aug. 27, 2016, 9:04 a.m., Peter Wu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128760/
> ---
> 
> (Updated Aug. 27, 2016, 9:04 a.m.)
> 
> 
> Review request for Plasma, David Edmundson, David Faure, and Hugo Pereira Da 
> Costa.
> 
> 
> Bugs: 356940
> https://bugs.kde.org/show_bug.cgi?id=356940
> 
> 
> Repository: breeze
> 
> 
> Description
> ---
> 
> Since Qt 5.6.0, Qt5 applications started crashing on exit. All signs
> point to this delete-on-destroy hack which was added to avoid outliving
> the plugin lifetime.
> 
> This method is wrong because the returned style is owned by the caller
> (QApplication, QProxyStyle, etc) and will cleaned up when those users
> are destructed.
> 
> 
> Diffs
> -
> 
>   kstyle/breezestyleplugin.cpp 083100e 
> 
> Diff: https://git.reviewboard.kde.org/r/128760/diff/
> 
> 
> Testing
> ---
> 
> Ran the updated test.sh from "Testcase (ASAN) with normal QApplication::quit 
> and exit()" from bug https://bugs.kde.org/show_bug.cgi?id=356940, no longer 
> crashes. Tested with Qt 5.7.0.
> 
> 
> Thanks,
> 
> Peter Wu
> 
>

Re: Review Request 128950: Allow Plasma desktop scripting to change panel's screen.

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128950/#review99342
---




shell/scripting/panel.cpp (line 182)


that's still going to crash if used in an initial setup plasma script.


- David Edmundson


On Sept. 20, 2016, 2:25 p.m., Kamil Sołtysik wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128950/
> ---
> 
> (Updated Sept. 20, 2016, 2:25 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: https://bugs.kde.org/show_bug.cgi?id=363592
> 
> https://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=363592
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> ---
> 
> As stated in doc here: 
> https://userbase.kde.org/KDE_System_Administration/PlasmaDesktopScripting#Panels
>  Panels should allow to be placed on selected screen by setting value of 
> Panel::screen property. While looking at code I found out that this property 
> is read-only in code. Patch changes that.
> 
> 
> Diffs
> -
> 
>   shell/scripting/panel.h 0d70784 
>   shell/scripting/panel.cpp b9383df 
> 
> Diff: https://git.reviewboard.kde.org/r/128950/diff/
> 
> 
> Testing
> ---
> 
> Panel's position can now be changed by setting the property. Setting invalid 
> value causes no response.
> 
> 
> File Attachments
> 
> 
> plasma-workspace-2.patch
>   
> https://git.reviewboard.kde.org/media/uploaded/files/2016/09/20/bc1df578-8758-48e4-b2b2-a53792c803f8__plasma-workspace-2.patch
> 
> 
> Thanks,
> 
> Kamil Sołtysik
> 
>

Re: NM-Qt: tens of blocking DBus calls for every nm device

[Jan Grulich]

Hi,

I'm aware that we do this. Give me few days to fix this in all NMQT classes, 
like we do in Manager class.

Regards,
Jan
-- 
Jan Grulich 
Software Engineer, Desktop team
Red Hat Czech

On středa 21. září 2016 1:46:29 CEST Aleix Pol wrote:
> Hi networkmanagerers, plasmers,
> I have been looking into what kind of things happen between the plasma
> shell is booted and actually starts.
> An obvious way to check where we're blocking, is by seeing who is
> making blocking dbus calls. Adding a breakpoint to whenever there's a
> blocking dbus call goes lengths.
> 
> A big pain point I've found is nm-qt's Device initialization.
> 
> Maintainers, do you think it would be possible to lazily fetch these
> values instead of just populating everything upon construction? I'm
> positive it would have an immediate impact.
> I see few solutions:
> - Just using QDBusPendingReply so it will issue the call and only
> block when the value is actually read.
> - Issue a dbus call that gets all properties at once
> (org.freedesktop.DBus.Properties.GetAll). It will still block, but
> less.
> - Only ask for the value when requested, not before. Then it's
> probably less bad to block.
> 
> HTH,
> Aleix
> 
> [1]
> #0 QDBusConnection::call() at
> /home/apol/devel/frameworks/qt5/qtbase/src/dbus/qdbusconnection.cpp:689
> #1 QDBusAbstractInterfacePrivate::property() at
> /home/apol/devel/frameworks/qt5/qtbase/src/dbus/qdbusabstractinterface.cpp:1
> 79 #2 QDBusAbstractInterfaceBase::qt_metacall() at
> /home/apol/devel/frameworks/qt5/qtbase/src/dbus/qdbusabstractinterface.cpp:2
> 90 #3 QDBusAbstractInterface::qt_metacall() at
> /home/apol/build-devel/qt5/qtbase/src/dbus/.moc/moc_qdbusabstractinterface.c
> pp:97 #4 OrgFreedesktopNetworkManagerDeviceInterface::qt_metacall() at
> /home/apol/build-devel/frameworks/networkmanager-qt/src/moc_nm-deviceinterfa
> ce.cpp:248 #5 QMetaProperty::read(QObject const*) const() at
> /home/apol/devel/kde5/lib/libQt5Core.so.5
> #6 QObject::property(char const*) const() at
> /home/apol/devel/kde5/lib/libQt5Core.so.5
> #7 OrgFreedesktopNetworkManagerDeviceInterface::managed() at
> /home/apol/devel/frameworks/networkmanager-qt/src/dbus/nm-deviceinterface.h:
> 155 #8 NetworkManager::DevicePrivate::DevicePrivate() at
> /home/apol/devel/frameworks/networkmanager-qt/src/device.cpp:112
> #9 NetworkManager::Device::Device() at
> /home/apol/devel/frameworks/networkmanager-qt/src/device.cpp:198
> #10 NetworkManager::NetworkManagerPrivate::createNetworkInterface() at
> /home/apol/devel/frameworks/networkmanager-qt/src/manager.cpp:287
> #11 NetworkManager::NetworkManagerPrivate::findRegisteredNetworkInterface()
> at /home/apol/devel/frameworks/networkmanager-qt/src/manager.cpp:254
> #12 NetworkManager::NetworkManagerPrivate::networkInterfaces() at
> /home/apol/devel/frameworks/networkmanager-qt/src/manager.cpp:360
> #13 NetworkManager::networkInterfaces() at
> /home/apol/devel/frameworks/networkmanager-qt/src/manager.cpp:936
> #14 ConnectionIcon::ConnectionIcon() at
> /home/apol/devel/frameworks/plasma-nm/libs/declarative/connectionicon.cpp:63
> #15 QQmlPrivate::QQmlElement::QQmlElement() at
> /home/apol/devel/kde5/include/QtQml/qqmlprivate.h:99
> #16 QQmlPrivate::createInto() at
> /home/apol/devel/kde5/include/QtQml/qqmlprivate.h:108
> #17 QQmlType::create() at
> /home/apol/devel/frameworks/qt5/qtdeclarative/src/qml/qml/qqmlmetatype.cpp:7
> 61 #18 QQmlObjectCreator::createInstance() at
> /home/apol/devel/frameworks/qt5/qtdeclarative/src/qml/qml/qqmlobjectcreator.
> cpp:1057 #19 QQmlObjectCreator::setPropertyBinding() at
> /home/apol/devel/frameworks/qt5/qtdeclarative/src/qml/qml/qqmlobjectcreator.
> cpp:738 #20 QQmlObjectCreator::setupBindings() at
> /home/apol/devel/frameworks/qt5/qtdeclarative/src/qml/qml/qqmlobjectcreator.
> cpp:690 #21 QQmlObjectCreator::populateInstance() at
> /home/apol/devel/frameworks/qt5/qtdeclarative/src/qml/qml/qqmlobjectcreator.
> cpp:1325 #22 QQmlObjectCreator::createInstance() at
> /home/apol/devel/frameworks/qt5/qtdeclarative/src/qml/qml/qqmlobjectcreator.
> cpp:1183 #23 QQmlObjectCreator::create() at
> /home/apol/devel/frameworks/qt5/qtdeclarative/src/qml/qml/qqmlobjectcreator.
> cpp:200 #24 QQmlIncubatorPrivate::incubate() at
> /home/apol/devel/frameworks/qt5/qtdeclarative/src/qml/qml/qqmlincubator.cpp:
> 301 #25 QQmlIncubationController::incubateFor() at
> /home/apol/devel/frameworks/qt5/qtdeclarative/src/qml/qml/qqmlincubator.cpp:
> 394 #26 KDeclarative::QmlObjectIncubationController::incubate() at
> /home/apol/devel/frameworks/kdeclarative/src/kdeclarative/private/qmlobject_
> p.h:63

[Powerdevil] [Bug 369129] Powerdevil does not provide a way to inhibit screen saving

[Kai Uwe Broulik via KDE Bugzilla]

https://bugs.kde.org/show_bug.cgi?id=369129

Kai Uwe Broulik  changed:

   What|Removed |Added

 CC||k...@privat.broulik.de
 Status|UNCONFIRMED |CONFIRMED
 Ever confirmed|0   |1

--- Comment #2 from Kai Uwe Broulik  ---
Interesting. I never considered keeping the screen on while locked a desirable
usecase as it just wastes power. However, you just described one. :) I'll see
what I can do, however, when the screen is locked PowerDevil would explicitly
ignore a "keep screen on" inhibition as to not let a playing video (covered by
the lock screen and thus invisible) keep the screen on indefinitely.

-- 
You are receiving this mail because:
You are the assignee for the bug.

Review Request 128966: Don't include kdeglobals when dealing with a cache config

[David Edmundson]

---
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128966/
---

Review request for KDE Frameworks and Plasma.


Repository: plasma-framework


Description
---

The svg elements cache isn't really a "configuration" and it's not
something that should be overridden by global config settings.

Loading it as a simple config skips the cascading and saves reparsing
kdeglobals.


Diffs
-

  src/plasma/private/theme_p.cpp 18c7a734141b89e9c6ba7f7689371614d60af927 

Diff: https://git.reviewboard.kde.org/r/128966/diff/


Testing
---


Thanks,

David Edmundson