Review Request 129009: [busy indicator] Limit animation loops

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129009/ --- Review request for Plasma, David Edmundson, David Rosca, and Marco Martin.

[Differential] [Request, 17 lines] D2849: warnings--

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. TEST PLAN Compiled. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL

Re: Review Request 129005: Mark kirigami as runtime component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129005/ --- (Updated Sept. 23, 2016, 9:42 p.m.) Status -- This change has been

Re: Review Request 129006: Mark Kirigami as runtime component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129006/ --- (Updated Sept. 23, 2016, 9:41 p.m.) Status -- This change has been

[Differential] [Request, 20 lines] D2848: Fix binding loop in pager

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Previously on height changed rowHeight changed which changes columnWidth which in turn

[Differential] [Request, 2 lines] D2847: Use correct parent for folderview context menu actions

fvogt created this revision. fvogt added a reviewer: Plasma. fvogt added a subscriber: Plasma. fvogt set the repository for this revision to rPLASMADESKTOP Plasma Desktop. fvogt added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This fixes a crash

Review Request 129007: Update windowspecific (Window Rules) docbook

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129007/ --- Review request for Documentation, Plasma and Martin Gräßlin. Repository:

Re: Review Request 129006: Mark Kirigami as runtime component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129006/#review99490 --- Ship it! Ship It! - David Edmundson On Sept. 23, 2016,

Re: Review Request 129005: Mark kirigami as runtime component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129005/#review99489 --- Ship it! Ship It! - Aleix Pol Gonzalez On set. 23,

Review Request 129006: Mark Kirigami as runtime component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129006/ --- Review request for Plasma. Repository: plasma-sdk Description ---

Review Request 129005: Mark kirigami as runtime component

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129005/ --- Review request for Plasma and Aleix Pol Gonzalez. Repository: discover

Re: Plasma desktop/mobile initial setup

Hi all, Il 15-09-2016 09:20 Ivan Čukić ha scritto: The fact that people are used to a certain kind of UI is not the reason for you not to invent something new and better. +1. Having a first-start tutorial for Plasma would let us improve a bit the defaults (Plasma is still suggested as better

[Powerdevil] [Bug 369181] User session security vulnerability from screen lock being suppressed with power management

https://bugs.kde.org/show_bug.cgi?id=369181 Thomas Pfeiffer changed: What|Removed |Added CC|

[Differential] [Commented On] D2846: Let kicker display executable items instead of empty buttons.

mart added a comment. +1 from me (i think kcms with exec line are here to stay) Eike? REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2846 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, hein,

[Differential] [Changed Subscribers] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud added a subscriber: broulik. ochurlaud added a comment. @broulik remarked that a .desktop file should not define a `Exec=""` when it is `Type=Service`. If we want to respect this, we could split all kcm files in one part which defines the service, and one that defines the Exec

[Differential] [Updated] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud added a reviewer: Plasma. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2846 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, hein, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Updated] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud added a reviewer: hein. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2846 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: ochurlaud, hein Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Request, 2 lines] D2846: Let kicker display executable items instead of empty buttons.

ochurlaud created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY This would partially fix https://bugs.kde.org/show_bug.cgi?id=369242 Another patch is required not to show empty elements (in case

[Differential] [Abandoned] D2845: some sni implementations theme not under /icons

mart abandoned this revision. mart added a comment. hm, forget that, i can't even get to reproduce thunderbirs passing the icon name/theme instead than directly the pixmap now . so i have no idea at the moment how to reproduce those 2 bugs :( REPOSITORY rPLASMAWORKSPACE Plasma Workspace

[Differential] [Requested Changes To] D2845: some sni implementations theme not under /icons

davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added a comment. This revision now requires changes to proceed. Can you start to fill in the "testing done" section properly. INLINE COMMENTS > systemtray.cpp:180 >

[Differential] [Changed Subscribers] D2845: some sni implementations theme not under /icons

davidedmundson added inline comments. INLINE COMMENTS > systemtray.cpp:178 > if (!path.isEmpty()) { > // FIXME: If last part of path is not "icons", this won't > work! > auto tokens = path.splitRef('/', QString::SkipEmptyParts); Then this comment

[Differential] [Updated] D2845: some sni implementations theme not under /icons

mart updated the test plan for this revision. mart added a reviewer: Plasma. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2845 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel,

[Differential] [Request, 4 lines] D2845: some sni implementations theme not under /icons

mart created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY some sni implementations, like thunderbird have their custom systray icons in a place that doesn't end by "icons" (for instance thunderbird

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

> On Sept. 22, 2016, 12:31 p.m., Kai Uwe Broulik wrote: > > src/declarativeimports/plasmacomponents/qmenu.cpp, line 231 > > > > > > if (!item) return; Should be done also in other places. - David

Re: Review Request 128999: Add removeMenuItem to PlasmaComponents.ContextMenu

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/128999/ --- (Updated Sept. 23, 2016, 11:20 a.m.) Review request for Plasma.

[Differential] [Commented On] D2843: Fix method that calls itself recursively

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in image.cpp:126 > Superfluous curly bracket Not superfluous, it's closing the for and the method. Ridiculously whitespaced though. Will fix, thanks. REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL

[Differential] [Changed Subscribers] D2843: Fix method that calls itself recursively

broulik added inline comments. INLINE COMMENTS > image.cpp:126 > +first = false; > +}} > Superfluous curly bracket REPOSITORY rPLASMAWORKSPACE Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D2843 EMAIL PREFERENCES

[Differential] [Closed] D2843: Fix method that calls itself recursively

This revision was automatically updated to reflect the committed changes. Closed by commit rPLASMAWORKSPACE22c6643ef539: Fix method that calls itself recursively (authored by davidedmundson). REPOSITORY rPLASMAWORKSPACE Plasma Workspace CHANGES SINCE LAST UPDATE

[Differential] [Accepted] D2843: Fix method that calls itself recursively

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMAWORKSPACE Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D2843 EMAIL PREFERENCES

[Differential] [Accepted] D2842: Add kinfocenter to the computer tab of Kickoff

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. i'm still not sure it's a good idea to add more links to apps by default, but if people like it, oh, well, why not REPOSITORY rPLASMADESKTOP Plasma Desktop

[Differential] [Accepted] D2841: Don't load system apps model twice

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY rPLASMADESKTOP Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D2841 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: