[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

hein added a comment. I'm against adding a config option for it for a while. We've had a lot of user feedback that the old ones were too big and fluffy, which this is a reaction to. And note that as Roman points out hidpi scaling is accounted for (I use a 3000x200 13" screen myself). Let's

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

anthonyfieroni added a comment. Maybe we can add configuration for tooltip size? I, personally, like very much biggest ones. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

[Differential] [Commented On] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

hein added a comment. You don't neeed any changes to the C++ side - do it in QML. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3931 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, hein, #plasma Cc:

[Differential] [Request, 3 lines] D3988: Set focus on widgets in system tray popup

davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Fixes the issue most noticable with klipper's text field not having focus; though use of

[Differential] [Commented On] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

chinmoyr added a comment. So only the 'historyAvailable' prop and no 'location' prop and stuffs? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3931 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: chinmoyr, hein,

[Differential] [Accepted] D3302: [Task Manager] Indicate applications playing audio

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma:_design, drosca, hein,

[Differential] [Requested Changes To] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

hein requested changes to this revision. hein added a comment. This revision now requires changes to proceed. I don't want two props in the model - I want it to remain simple and simply provide data for one location. It should be oblivious to the configuration concerns of its user. This is

[Differential] [Accepted] D3738: [Task Manager] Tooltips redesign

hein accepted this revision. hein added a comment. This revision is now accepted and ready to land. Ok, let's merge then. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/

Re: CI Requirements - Lessons Not Learnt?

On Fri, Jan 6, 2017 at 12:38 AM, Martin Gräßlin wrote: > Am 2017-01-05 11:20, schrieb Ben Cooksley: >> >> On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin >> wrote: >>> >>> Am 2017-01-05 09:44, schrieb Ben Cooksley: Hi all,

[Differential] [Commented On] D3706: WIP: Global Menu Applet

davidedmundson added a comment. > it look a bit "boring" you can select single button for app menu but when I didn't select it what happens than? I would prefer instead of the checkbox all different styles and radio button to select the style the user want. That's a good idea,simply

[Differential] [Updated, 961 lines] D3706: WIP: Global Menu Applet

davidedmundson updated this revision to Diff 9788. davidedmundson added a comment. - i18n - Merge branch 'master' of git://anongit.kde.org/plasma-workspace - Change config to two exlusive radio buttons - don't set compact representation checked REPOSITORY R120 Plasma Workspace

[Differential] [Updated, 1,123 lines] D3738: [Task Manager] Tooltips redesign

subdiff updated this revision to Diff 9787. subdiff added a comment. Fallback to previously used method: One ToolTipDelegate, which gets repositioned to the the task currently containing the mouse. To do this cleanly, the ToolTipDelegate needed to be split up. On the plus side the ugly

[Differential] [Commented On] D3089: Restore global menu support

davidedmundson added a comment. For the KCM I needed diff --git a/kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp b/kcmkwin/kwindecoration/declarative-plugin/buttonsmodel.cpp index b2ac124ed..26d779015 100644 -

Re: problems with Kirigami on iOS

Am 03.01.2017 um 12:14 schrieb Marco Martin: > On Tuesday 03 January 2017, Dirk Hohndel wrote: >> but that doesn't appear to be sufficient, as the error message above seems >> to indicate... >> >> Is anyone else using Kirigami and Qt 5.7.1 on iOS and has figured out a way >> around that problem? >

[Differential] [Accepted] D3943: Make sure we only initialize the appstream pool once

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3943 EMAIL PREFERENCES

[Differential] [Changed Subscribers] D3088: [KDecoration] Restore application menu button

davidedmundson added inline comments. INLINE COMMENTS > decoration.cpp:201 > +{ > +static_cast *>(d->client->d.get())->requestShowApplicationMenu(rect, actionId); > +} I don't get this? We've replaced one ABI crash with throwing a runtime exception on calling a pure virtual, which isn't

[Differential] [Updated, 187 lines] D3088: [KDecoration] Restore application menu button

broulik updated this revision to Diff 9783. broulik added a comment. - Add basic autotest that verifies that clicking the app menu button results in an application menu request REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE

[Differential] [Updated, 131 lines] D3088: [KDecoration] Restore application menu button

broulik updated this revision to Diff 9782. broulik added a comment. - Introduce subclass (admittedly with a quite a long name) to avoid adding new virtuals in exported class REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 107 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/107/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 22:33:00 + Build duration: 1 min 0 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 110 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/110/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 22:27:36 + Build duration: 1 min 1 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Commented On] D3706: WIP: Global Menu Applet

andreaska added a comment. **settingspage** it look a bit "boring" you can select single button for app menu but when I didn't select it what happens than? I would prefer instead of the checkbox all different styles and radio button to select the style the user want. **compact view**

Jenkins-kde-ci: oxygen-icons5 master kf5-qt5 » Linux,gcc - Build # 109 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/109/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 20:43:45 + Build duration: 1 min 23 sec CHANGE SET No changes JUNIT RESULTS

Jenkins-kde-ci: oxygen-icons5 master stable-kf5-qt5 » Linux,gcc - Build # 106 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/oxygen-icons5%20master%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/106/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 20:36:53 + Build duration: 1 min 4 sec CHANGE SET No changes JUNIT RESULTS

[Differential] [Commented On] D3089: Restore global menu support

graesslin added a comment. I'd still love to see autotests for it, otherwise looks good. Just two very minor issues spotted. INLINE COMMENTS > appmenu.cpp:98 > +{ > +qDebug() << "SHOW APP MENU" << p << actionId; > +m_appmenuInterface->showMenu(p.x(), p.y(), >

[Differential] [Commented On] D3088: [KDecoration] Restore application menu button

graesslin added a comment. I'm for dedicated sub-class. Reason is that this can result in an annoying transition with e.g. breeze compiled against the old and kwin against the new. Let's subclass and cast correctly REPOSITORY R129 Window Decoration Library REVISION DETAIL

[Differential] [Updated, 955 lines] D3706: WIP: Global Menu Applet

davidedmundson updated this revision to Diff 9774. davidedmundson added a comment. Tidy appmenu representations and sizes REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3706?vs=9770=9774 BRANCH master REVISION DETAIL

[Differential] [Abandoned] D3156: WIP: Application Menu applet

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D3706 REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3156 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Updated, 97 lines] D3088: [KDecoration] Restore application menu button

broulik updated this revision to Diff 9772. broulik added a comment. - Pass through actionId argument REPOSITORY R129 Window Decoration Library CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3088?vs=7574=9772 REVISION DETAIL https://phabricator.kde.org/D3088 AFFECTED FILES

[Differential] [Updated, 449 lines] D3089: Restore global menu support

broulik updated this revision to Diff 9771. broulik added a comment. Restricted Application edited projects, added KWin; removed Plasma. - Route through the "actionId" argument - this way an application can tell which submenu to highlight/open (e.g. Alt keyboard activation) REPOSITORY R108

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 646 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/646/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 16:34:17 + Build duration: 5 min 35 sec CHANGE SET Revision

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 646 - Fixed!

GENERAL INFO BUILD SUCCESS Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/646/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 16:34:17 + Build duration: 5 min 35 sec CHANGE SET Revision

[Differential] [Updated, 976 lines] D3706: WIP: Global Menu Applet

davidedmundson updated this revision to Diff 9770. davidedmundson added a comment. Fix compilation REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3706?vs=9257=9770 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3706 AFFECTED

[Differential] [Commandeered] D3706: WIP: Global Menu Applet

davidedmundson commandeered this revision. davidedmundson added a reviewer: chinmoyr. davidedmundson added inline comments. INLINE COMMENTS > main.qml:51 > + > +Plasmoid.fullRepresentation: Item { > + We can go back to your previous (quite clever) use of compact/full representation, I

Jenkins-kde-ci: plasma-workspace master kf5-qt5 » Linux,gcc - Build # 645 - Failure!

GENERAL INFO BUILD FAILURE Build URL: https://build.kde.org/job/plasma-workspace%20master%20kf5-qt5/PLATFORM=Linux,compiler=gcc/645/ Project: PLATFORM=Linux,compiler=gcc Date of build: Thu, 05 Jan 2017 16:26:01 + Build duration: 4 min 9 sec CHANGE SET Revision

[Differential] [Closed] D3926: Move SNI's libdbusmenu-qt fork to the root directory and use that for appmenu too

This revision was automatically updated to reflect the committed changes. Closed by commit R120:ee516ef7eab1: Move SNI's libdbusmenu-qt fork to the root directory and use that for appmenu… (authored by davidedmundson). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3926?vs=9624=9768#toc

[Differential] [Closed] D3086: Clean up KAppMenu

This revision was automatically updated to reflect the committed changes. Closed by commit R120:90de42f2976c: Clean up KAppMenu (authored by broulik). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3086?vs=7784=9767 REVISION DETAIL

[Differential] [Accepted] D3086: Clean up KAppMenu

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3086 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mart, #plasma,

[Differential] [Commented On] D3086: Clean up KAppMenu

broulik added a comment. Ping REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3086 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, mart Cc: graesslin, plasma-devel, lesliezhai, ali-mohamed,

[Differential] [Commented On] D3088: [KDecoration] Restore application menu button

broulik added a comment. What shall we do with this (the new virtual) now? REPOSITORY R129 Window Decoration Library REVISION DETAIL https://phabricator.kde.org/D3088 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma Cc: sitter,

[Differential] [Updated] D3982: [Panel Containment] Correctly compare applets without order

davidedmundson added a comment. Edit, I was wrong about my earlier comment, and found your bug too. You can't reference applets whilst you're sorting applets. } else if (aIdx === -1 && bIdx === -1) { // if both don't have an order yet (fresh config), look up their

[Differential] [Updated, 7 lines] D3981: better clean up of duplicate containments

mart updated this revision to Diff 9766. mart added a comment. - remove the disconnect REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3981?vs=9759=9766 BRANCH phab/cleanupcontainments REVISION DETAIL https://phabricator.kde.org/D3981

[Differential] [Commented On] D3982: [Panel Containment] Correctly compare applets without order

davidedmundson added inline comments. INLINE COMMENTS > LayoutManager.js:42 > return -1 > +} else if (aIdx === -1 && bIdx === -1) { > +// if both don't have an order yet (fresh config), look up their > relative position within "applets" FWIW, if we go back to

[Differential] [Commented On] D3981: better clean up of duplicate containments

mart added inline comments. INLINE COMMENTS > mart wrote in shellcorona.cpp:1922 > i could just remove that disconnect, the thing is, i'm always hesitant to > change things in ways that may have had a reason. > that disconenct was added somewhere back in 2014, i can test removing it if > it

[Differential] [Closed] D3964: Fade out OnScreenNotification when moving with the mouse over it

This revision was automatically updated to reflect the committed changes. Closed by commit R108:80adfd0274af: Fade out OnScreenNotification when moving with the mouse over it (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3928: Sync opacity from an internal QWindow to its ShellClient

This revision was automatically updated to reflect the committed changes. Closed by commit R108:0a042dad6952: Sync opacity from an internal QWindow to its ShellClient (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3928?vs=9626=9763

[Differential] [Closed] D3963: Fix syncing of geometry to internal window when using ::move

This revision was automatically updated to reflect the committed changes. Closed by commit R108:6a78bd45fea3: Fix syncing of geometry to internal window when using ::move (authored by graesslin). REPOSITORY R108 KWin CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3963?vs=9716=9764

[Differential] [Request, 3 lines] D3982: [Panel Containment] Correctly compare applets without order

broulik created this revision. broulik added reviewers: Plasma, davidedmundson. broulik set the repository for this revision to R119 Plasma Desktop. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When comparing two

[Differential] [Commented On] D3834: [Panel Containment] Replace restore order logic by "algorithms"

broulik added a comment. > I think it's this part: > > appletsOrder["unordered"+i] = plasmoid.applets[i] My loop sorts elements that have no index last, maybe that's wrong somehow? It worked for me for when an applet isn't ordered yet but I can reproduce that adding a new

[Differential] [Commented On] D3834: [Panel Containment] Replace restore order logic by "algorithms"

davidedmundson added a comment. This has broken the initial panel population from a clean config. I get all my applets added the wrong way round. Reverting this patch fixes it. I think it's this part: appletsOrder["unordered"+i] = plasmoid.applets[i] REPOSITORY R119

[Differential] [Commented On] D3981: better clean up of duplicate containments

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:1909 > > catches also containments of other activities > > No it doesn't - you're looping through m_desktopContainments.value(activity) >so only things of the same activity. > Either your comment is

[Differential] [Commented On] D3257: Close the system tray on escape - system tray

davidedmundson added inline comments. INLINE COMMENTS > broulik wrote in PlasmoidPopupsContainer.qml:30 > It did break it. I can no longer automatically type in Klipper or use the > shortcuts in Media Controller. Pressing Escape to close still works with this. Interestingly, it works the first

[Differential] [Changed Subscribers] D3257: Close the system tray on escape - system tray

broulik added inline comments. INLINE COMMENTS > mart wrote in PlasmoidPopupsContainer.qml:30 > wouldn't this break keyboard navigation in an item if supported? (like going > up and down in the device list in the device notifier) It did break it. I can no longer automatically type in Klipper

[Differential] [Commented On] D3981: better clean up of duplicate containments

davidedmundson added inline comments. INLINE COMMENTS > shellcorona.cpp:1909 > for (Plasma::Containment *c : m_desktopContainments.value(activity)) { > -if (c->screen() == screenNum) { > +//using lastScreen() instead of screen() catches also containments > of other

[Differential] [Requested Changes To] D3981: better clean up of duplicate containments

davidedmundson requested changes to this revision. davidedmundson added a reviewer: davidedmundson. davidedmundson added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > mart wrote in shellcorona.cpp:1922 > cont is being deleted there, i'm making sure it's not in

[Differential] [Commented On] D3981: better clean up of duplicate containments

mart added inline comments. INLINE COMMENTS > davidedmundson wrote in shellcorona.cpp:1922 > Why are you doing this? cont is being deleted there, i'm making sure it's not in m_desktopContainments anymore for not even an instant. desktopContainmentDestroyed wasn't even called before as it's

[Differential] [Closed] D3893: [Folder View] Let IconItem take entire delegate width

This revision was automatically updated to reflect the committed changes. Closed by commit R119:2d2f33a915d3: [Folder View] Let IconItem take entire delegate width (authored by broulik). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3893?vs=9563=9761

[Differential] [Closed] D3892: [Icon Item] Support non-square icons

This revision was automatically updated to reflect the committed changes. Closed by commit R242:d46a91ea57f1: [Icon Item] Support non-square icons (authored by broulik). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D3892?vs=9658=9760#toc REPOSITORY R242 Plasma Frameworks CHANGES

[Differential] [Changed Subscribers] D3981: better clean up of duplicate containments

davidedmundson added inline comments. INLINE COMMENTS > shellcorona.cpp:1922 > if (cont) { > +m_desktopContainments[activity].remove(cont); > disconnect(cont, SIGNAL(destroyed(QObject*)), Why are you doing this? REPOSITORY R120 Plasma Workspace REVISION DETAIL

[Differential] [Updated] D3981: better clean up of duplicate containments

mart updated the summary for this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D3981 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: mart, #plasma Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg,

[Differential] [Request, 4 lines] D3981: better clean up of duplicate containments

mart created this revision. mart added a reviewer: Plasma. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY due to old multiscreen bugs, sometimes the appletsrc file gets polluted with a lot of containments with same

[Differential] [Accepted] D3892: [Icon Item] Support non-square icons

davidedmundson accepted this revision. davidedmundson added a reviewer: davidedmundson. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Frameworks REVISION DETAIL https://phabricator.kde.org/D3892 EMAIL PREFERENCES

[Differential] [Closed] D3976: And enable high DPI on the icons in kfontview

This revision was automatically updated to reflect the committed changes. Closed by commit R119:f64ef01d76f0: And enable high DPI on the icons in kfontview (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3976?vs=9739=9758

[Differential] [Closed] D3975: Add high DPI support to kfontview and kfontinst KCM

This revision was automatically updated to reflect the committed changes. Closed by commit R119:1c0aed9aa394: Add high DPI support to kfontview and kfontinst KCM (authored by davidedmundson). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE

[Differential] [Closed] D3958: [PackageLoader] Don't access invalid KPluginMetadata

This revision was automatically updated to reflect the committed changes. Closed by commit R290:8391e022e0f0: [PackageLoader] Don't access invalid KPluginMetadata (authored by broulik). REPOSITORY R290 KPackage CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3958?vs=9708=9756

Re: announcement: plymouth-kcm in kdereview

Jonathan Riddell ha scritto: > On Thu, Dec 29, 2016 at 12:58:10PM +0100, Marco Martin wrote: >> Hi all, >> announcing a new KCM module to change the plymouth splash screen >> The repository is named plymouth-kcm and is headed for kdereview now. >> its final resting place would be the workspace

Re: announcement: plymouth-kcm in kdereview

On Thu, Dec 29, 2016 at 12:58:10PM +0100, Marco Martin wrote: > Hi all, > announcing a new KCM module to change the plymouth splash screen > The repository is named plymouth-kcm and is headed for kdereview now. > its final resting place would be the workspace area, to be released in sync > with

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

subdiff added a comment. In https://phabricator.kde.org/D3738#74290, @hein wrote: > I just tried running the patch, and instead of smooth morphs when going between tooltip contents I get an instant change with a 1-frame glitchy stretch ... it's pretty bad. Sorry, I can't

Re: CI Requirements - Lessons Not Learnt?

Am 2017-01-05 11:20, schrieb Ben Cooksley: On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin wrote: Am 2017-01-05 09:44, schrieb Ben Cooksley: Hi all, It seems that my previous vocal complaints about system level / serious impact dependency bumps on the CI system

[Differential] [Accepted] D3971: RFC: Run first action on Shift+Return

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. anyways, for me, i like it, if there isn't anybody with a significant complaint, go for it REPOSITORY R112 Milou REVISION DETAIL

[Differential] [Accepted] D3969: Kill audioplayercontrolrunner

mart accepted this revision. mart added a reviewer: mart. mart added a comment. This revision is now accepted and ready to land. :''( ooh, well, so long REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3969 EMAIL PREFERENCES

[Differential] [Accepted] D3967: [Fifteen Puzzle] Add "Browse" button

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3967 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Accepted] D3968: [Fifteen Puzzle] Start timer on tile click, stop timer on shuffle

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R114 Plasma Addons REVISION DETAIL https://phabricator.kde.org/D3968 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma,

[Differential] [Commented On] D3971: RFC: Run first action on Shift+Return

broulik added a comment. That's why I mention it in the tooltip, so when one wonders "huh, what is this icon on the right?" sees "ooh, Shift+Enter triggers it too!" REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D3971 EMAIL PREFERENCES

[Differential] [Commented On] D3971: RFC: Run first action on Shift+Return

mart added a comment. I like it.. it's a very hidden feature tough, one of the nice things but that noone notices :/ REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D3971 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik,

[Differential] [Accepted] D3975: Add high DPI support to kfontview and kfontinst KCM

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3975 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Updated, 388 lines] D3931: [Plasma folderview] Replace "Up" button with "Back" button in listview mode

chinmoyr updated this revision to Diff 9753. chinmoyr added a comment. Added properties location(which will store folder view's location) and historyAvailable Removed prop url and renamed prop resolvedUrl to currentUrl Bind Back button's visibility to historyAvailable For the logic;

[Differential] [Accepted] D3976: And enable high DPI on the icons in kfontview

mart accepted this revision. mart added a reviewer: mart. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3976 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To:

[Differential] [Commented On] D3302: [Task Manager] Indicate applications playing audio

andreaska added a comment. and when I make a new emblem icon for audio on/off this would have an background circle and inside the mute/volume on icon like we have it for owncloud, ... REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES

Re: CI Requirements - Lessons Not Learnt?

On Thu, Jan 5, 2017 at 10:28 PM, Martin Gräßlin wrote: > Am 2017-01-05 09:44, schrieb Ben Cooksley: >> >> Hi all, >> >> It seems that my previous vocal complaints about system level / >> serious impact dependency bumps on the CI system have gone completely >>

[Differential] [Updated] D3302: [Task Manager] Indicate applications playing audio

broulik updated the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3302 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, #plasma, #plasma:_design, drosca, hein Cc: subdiff, apol, colomar,

[Differential] [Updated, 287 lines] D3302: [Task Manager] Indicate applications playing audio

broulik updated this revision to Diff 9750. broulik added a comment. - Improve visuals for icon-only mode - Put Audio Icon into separate qml file REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3302?vs=8026=9750 REVISION DETAIL

[Differential] [Closed] D3979: Fix race condition causing empty favorites.

This revision was automatically updated to reflect the committed changes. Closed by commit R119:b7976f0c2628: Fix race condition causing empty favorites. (authored by hein). REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3979?vs=9748=9749 REVISION

[Differential] [Commandeered] D3910: [Kicker] Don't nuke favorites on startup

hein commandeered this revision. hein edited reviewers, added: broulik; removed: hein. hein added a comment. Superceded by https://phabricator.kde.org/D3979, thanks to Kai for review. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3910 EMAIL PREFERENCES

[Differential] [Abandoned] D3910: [Kicker] Don't nuke favorites on startup

broulik abandoned this revision. broulik added a comment. Superseded by https://phabricator.kde.org/D3979 REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3910 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: broulik, mart,

[Differential] [Accepted] D3979: Fix race condition causing empty favorites.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop BRANCH master REVISION DETAIL https://phabricator.kde.org/D3979 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, broulik, #plasma Cc:

[Differential] [Request, 29 lines] D3979: Fix race condition causing empty favorites.

hein created this revision. hein added reviewers: Plasma, broulik. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY This puts the frontend in charge of calling refresh() after the favorites have been initially set by setting auto

[Differential] [Abandoned] D3978: Typo fix.

hein abandoned this revision. hein added a comment. Made an --amend fuckup. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3978 EMAIL PREFERENCES https://phabricator.kde.org/settings/panel/emailpreferences/ To: hein, #plasma, broulik Cc: plasma-devel,

[Differential] [Request, 31 lines] D3978: Typo fix.

hein created this revision. hein added reviewers: Plasma, broulik. hein added a subscriber: plasma-devel. Restricted Application added a project: Plasma. REVISION SUMMARY Fix race condition causing empty favorites. This puts the frontend in charge of calling refresh() after the favorites

Re: CI Requirements - Lessons Not Learnt?

Sorry picked wrong from address Am 2017-01-05 10:28, schrieb Martin Gräßlin: Am 2017-01-05 09:44, schrieb Ben Cooksley: Hi all, It seems that my previous vocal complaints about system level / serious impact dependency bumps on the CI system have gone completely unnoticed by (some) members of

[Differential] [Updated, 21 lines] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

hein updated this revision to Diff 9746. hein added a comment. Mark unused. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D3950?vs=9745=9746 BRANCH master REVISION DETAIL https://phabricator.kde.org/D3950 AFFECTED FILES

[Differential] [Updated, 20 lines] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

hein updated this revision to Diff 9745. hein added a comment. Cleanup: filterProxyModel is always flat. Side note: This is why it makes sense to still collect the indices in the (tree-shaped) source model, because it avoids unnecessarily filling dirtyLaunchers for the removal of a

[Differential] [Updated, 25 lines] D3950: Try to fix "Pinned Chrome disappears when all Chrome windows are closed"

hein updated this revision to Diff 9744. hein added a comment. Eliminate reliance on QueuedConnection. In the previous version of the patch we still relied on QueuedConnection for the dataChanged invocation, because we were connecting to our own rowsRemoved. Proxy models emit

[Differential] [Commented On] D3738: [Task Manager] Tooltips redesign

hein added a comment. I just tried running the patch, and instead of smooth morphs when going between tooltip contents I get an instant change with a 1-frame glitchy stretch ... it's pretty bad. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D3738 EMAIL

CI Requirements - Lessons Not Learnt?

Hi all, It seems that my previous vocal complaints about system level / serious impact dependency bumps on the CI system have gone completely unnoticed by (some) members of our Community. This was demonstrated earlier this week when components of Plasma bumped their version requirements for