Jenkins-kde-ci: plasma-desktop Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 89 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-desktop%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/89/ Project: PLATFORM=Linux,compiler=gcc Date of build: Sat, 04 Mar 2017 07:12:08 + Build duration: 16 min CHANGE SET Revision

D4931: Small cleanups

apol created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Move implementation to cpp file, port away from deprecated API. REPOSITORY R242 Plasma Framework (Library) BRANCH master

[Kwin] - Forward special key to alternative app, not plasma?

Hello, I would like to ask about the forwarding of the special key to show apps launcher which is done from kwin to plasma with dbus I think, Is it possible to be forwarded at an alternative app? The use case is Latte which is a docks/panels manager that lives outside plasma. We would like to

D4929: DrKonqi : lldb support (and cross-platform adaptation)

rjvbb added a comment. Not currently, but DrKonqi ought *really* be elsewhere. There's nothing Plasma-specific to it. On the contrary, it should be easily available on every platform for which KDE applications are available so that every KDE user can contribute to KDE improvement by

D4929: DrKonqi : lldb support (and cross-platform adaptation)

broulik added a comment. Do apps even ship DrKonqi? It's part of plasma-workspace, which isn't meant for non-X11/Wayland, after all. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4929 To: rjvbb, #plasma_workspaces Cc: broulik, kde-mac, plasma-devel,

D4929: DrKonqi : lldb support (and cross-platform adaptation)

rjvbb created this revision. rjvbb added a project: Plasma: Workspaces. Restricted Application edited projects, added Plasma; removed Plasma: Workspaces. REVISION SUMMARY As touched upon previously, DrKonqi is a utility that can be very useful outside of Plasma desktop environments too, and

D4922: [Folder View] Set plasmoid.busy to false when listing canceled

aacid resigned from this revision. aacid added a comment. This revision is now accepted and ready to land. ignore me REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4922 To: broulik, #plasma, hein Cc: aacid, plasma-devel, progwolff, lesliezhai, ali-mohamed,

D4922: [Folder View] Set plasmoid.busy to false when listing canceled

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. The patch doesn't seem to apply? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4922 To: broulik, #plasma, hein, aacid Cc: aacid, plasma-devel,

D4845: Fix context menu button's icon size when on default DPI

drosca added a comment. > So we probably need to set Layout.preferredHeight: Math.max(slider.height, units.iconSizes.small) in the ToolButton? Actually, let's make this and also volume indicator icon (next to theslider) have size = units.iconSizes.small and remove the relative sizing by

D4845: Fix context menu button's icon size when on default DPI

aacid requested changes to this revision. aacid added a comment. This revision now requires changes to proceed. Patch does not seem to apply REPOSITORY R115 Plasma Audio Volume Applet REVISION DETAIL https://phabricator.kde.org/D4845 To: Zren, subdiff, drosca, broulik, aacid Cc: aacid,

Jenkins-kde-ci: plasma-workspace Plasma-5.9 stable-kf5-qt5 » Linux,gcc - Build # 88 - Still Unstable!

GENERAL INFO BUILD UNSTABLE Build URL: https://build.kde.org/job/plasma-workspace%20Plasma-5.9%20stable-kf5-qt5/PLATFORM=Linux,compiler=gcc/88/ Project: PLATFORM=Linux,compiler=gcc Date of build: Fri, 03 Mar 2017 18:35:42 + Build duration: 29 min CHANGE SET Revision

D4765: Make DesktopIcon aware of iamgeproviders and embedded ressources

This revision was automatically updated to reflect the committed changes. Closed by commit R169:3553ca6d4147: Make DesktopIcon aware of iamgeproviders and embedded ressources (authored by bsonnemann, committed by aacid). CHANGED PRIOR TO COMMIT

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

This revision was automatically updated to reflect the committed changes. Closed by commit R120:8028a500e3b2: Ignore NoDisplay=true .desktop entries when matching by Name. (authored by hein). CHANGED PRIOR TO COMMIT https://phabricator.kde.org/D4928?vs=12144=12145#toc REPOSITORY R120 Plasma

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

hein added a comment. In https://phabricator.kde.org/D4928#92423, @broulik wrote: > Shouldn't we *always* exclude them, not just for name matching? Two reasons: - I could imagine a case where someone wants to hide a .desktop from the menu (e.g. something like a KCM) but it

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH master REVISION DETAIL https://phabricator.kde.org/D4928 To: hein, #plasma, davidedmundson, broulik Cc: rempt, plasma-devel, progwolff, lesliezhai, ali-mohamed,

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

hein updated this revision to Diff 12144. hein added a comment. Remove debug. REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4928?vs=12143=12144 BRANCH master REVISION DETAIL https://phabricator.kde.org/D4928 AFFECTED FILES

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

broulik added a comment. Shouldn't we *always* exclude them, not just for name matching? INLINE COMMENTS > xwindowtasksmodel.cpp:646 > services = > KServiceTypeTrader::self()->query(QStringLiteral("Application"), > QStringLiteral("exist Exec and ('%1' =~

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

hein added a comment. And now the recent files work fine for Krita: F2676685: Screenshot_20170304_031400.png REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4928 To: hein, #plasma, broulik, davidedmundson Cc:

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

rempt added a comment. This seems correct to me :-) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4928 To: hein, #plasma, broulik, davidedmundson Cc: rempt, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4928: Ignore NoDisplay=true .desktop entries when matching by Name.

hein created this revision. Restricted Application added a project: Plasma. REVISION SUMMARY We currently match Krita by Name. It's classClass is "krita", but its DesktopEntryName is org.kde.krita.desktop. However, Krita also installs numerous additional .desktop entries to associate more

D4925: actually delete old theme caches

apol added inline comments. INLINE COMMENTS > theme_p.cpp:221 > + > +for (const QString : cacheDir.entryList()) { > if (currentCacheFileName.isEmpty() || Use entryInfoList? This way you won't have to construct the path again... > theme_p.cpp:270 > + > +for

D4926: Fix cmake warning

apol created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY Use the native dialog if there's no QApplication TEST PLAN Adds a test REPOSITORY R135 Integration for Qt applications in Plasma BRANCH

D4922: [Folder View] Set plasmoid.busy to false when listing canceled

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4922 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4915: [Folder View] Fix action button hover and pressed state

hein accepted this revision. This revision is now accepted and ready to land. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4915 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4918: [Folder View] Increase delegate action size to smallMedium

hein added a comment. Maybe keep it small in icon view mode though ...? REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4918 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

anthonyfieroni added a comment. It's look like relative path to me. If i'm not wrong KFileItem::setLocalPath should resolve relative path ? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4923 To: broulik, #plasma, hein, dfaure Cc: anthonyfieroni,

Re: Versioning caches in Plasma

On Friday 03 March 2017 16:02:55 Harald Sitter wrote: > Either way, my point is that the files Aleix has should be caught in > the very first part of the cleanup heuristic: "are there files that > are associated with me but not the ones I want to store my cache in".

D4925: actually delete old theme caches

mart created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY QStandardPaths doesn't do file search by wildcards, that code was never actually functional TEST PLAN old kcache and

D4924: [Containment Interface] Trigger context menus on pressing "Menu" key

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY When pressing the "Menu" key, pretend a right-click happened and show the containment context menu. TEST PLAN

Re: Review Request 127409: Make sure we're not forcing the window to be created prematurely

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127409/ --- (Updated mar. 3, 2017, 4:52 p.m.) Status -- This change has been

Re: Versioning caches in Plasma

On Friday 03 March 2017 16:02:55 Harald Sitter wrote: > Either way, my point is that the files Aleix has should be caught in > the very first part of the cleanup heuristic: "are there files that > are associated with me but not the ones I want to store my cache in". > because it's using

Re: Review Request 127408: Make sure the QPlatformWindow doesn't get initialized prematurely.

--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/127408/ --- (Updated mar. 3, 2017, 4:50 p.m.) Status -- This change has been

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

broulik added a comment. I don't know. The rewritten url for desktop:/ is clean (/home/foo/Desktop) but in KFileItem I see tons of places that are like path + '/' + name but I haven't figured out where the "." actuall comes from... REPOSITORY R120 Plasma Workspace REVISION DETAIL

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

dfaure added a comment. QDir::cleanPath or QUrl::NormalizePathSegments can help making this fix more generic. But I'm curious, where does the "/." come from in the first place? REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4923 To: broulik, #plasma,

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When dragging a file from one desktop:/ to another desktop:/ KIO wouldn't notice it's the same location as the source would be

D4923: [desktop:/ KIO] Strip superfluous slashes and fixup local root url

broulik edited the summary of this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4923 To: broulik, #plasma, hein, dfaure Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

Re: Versioning caches in Plasma

On Fri, Mar 3, 2017 at 1:30 PM, Kai Uwe Broulik wrote: >> For binary packages of any sort the mtime would always be different, same >> for stuff from the kde store since that'd rm the old tree first (I am > guessing). > > Different but not necessarily newer. I still

D4922: [Folder View] Set plasmoid.busy to false when listing canceled

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY When trying to access a folder that no longer exists or a KIO slave crashes or any other kind of error, instead of listingCompleted the

D4358: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors

This revision was automatically updated to reflect the committed changes. Closed by commit R31:479773fbf084: [cursors] Add 36px (1.5 scaling) size for Breeze and Breeze Snow Cursors (authored by subdiff). REPOSITORY R31 Breeze CHANGES SINCE LAST UPDATE

[Breeze] [Bug 348603] Small mouse size (24 size too small, 48 too big)

https://bugs.kde.org/show_bug.cgi?id=348603 Roman Gilg changed: What|Removed |Added Latest Commit||https://commits.kde.org/bre

D4921: [Menu] Harmonize openRelative placement

subdiff created this revision. subdiff added projects: Plasma, Frameworks. Restricted Application added a subscriber: Frameworks. REVISION SUMMARY With https://phabricator.kde.org/D4867 the placement was already changed a bit, but mostly the correction if there is not enough screen space

D4919: Don't set acceptHoverEvents in DragArea as we don't use them

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D4919 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D4920: With Qt >= 5.8 use the new API to set scene graph backend

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D4920 To: davidedmundson, #plasma, mart Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D4865: [System Tray] Listen to external collapse

This revision was automatically updated to reflect the committed changes. Closed by commit R120:f873432893ee: [System Tray] Listen to external collapse (authored by mart). REPOSITORY R120 Plasma Workspace CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4865?vs=12013=12127 REVISION

D4866: possible to set expanded=false for a containment

This revision was automatically updated to reflect the committed changes. Closed by commit R242:fba9e9e151a9: possible to set expanded=false for a containment (authored by mart). REPOSITORY R242 Plasma Framework (Library) CHANGES SINCE LAST UPDATE

D4920: With Qt >= 5.8 use the new API to set scene graph backend

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REPOSITORY R296 KDeclarative BRANCH master REVISION DETAIL https://phabricator.kde.org/D4920 AFFECTED FILES

D4919: Don't set acceptHoverEvents in DragArea as we don't use them

davidedmundson created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. TEST PLAN Looked for hoverEvent/Leave/Move in code We still get mouseMove whilst the user is dragging Checked Widget Explorer

D4918: [Folder View] Increase delegate action size to smallMedium

broulik edited the test plan for this revision. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D4918 To: broulik, #plasma, hein Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4842: [System Tray] Listen to external collapse

broulik abandoned this revision. REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D4842 To: broulik, #plasma Cc: mart, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4865: [System Tray] Listen to external collapse

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R120 Plasma Workspace BRANCH phab/collapsesystray REVISION DETAIL https://phabricator.kde.org/D4865 To: mart, #plasma, broulik Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg,

D4866: possible to set expanded=false for a containment

broulik accepted this revision. This revision is now accepted and ready to land. REPOSITORY R242 Plasma Framework (Library) BRANCH phab/collapse REVISION DETAIL https://phabricator.kde.org/D4866 To: mart, #plasma, broulik Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed,

D4918: [Folder View] Increase delegate action size to smallMedium

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The SVGs in Plasma's theme have a 22x22 size (which is smallMedium). This makes the elements more easily clickable and also improves their

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik edited the test plan for this revision. REPOSITORY R242 Plasma Framework (Library) REVISION DETAIL https://phabricator.kde.org/D4917 To: broulik, #plasma, #vdg Cc: plasma-devel, #frameworks, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol

D4917: [Breeze Plasma Theme] Improve action-overlay icons

broulik created this revision. Restricted Application added projects: Plasma, Frameworks. Restricted Application added subscribers: Frameworks, plasma-devel. REVISION SUMMARY The current ones aren't really descriptive and vastly different from what Dolphin uses. BUG: 376321 TEST PLAN

D3805: Per-activity favorites (WIP)

mart added a comment. how do i try the modeltest? INLINE COMMENTS > CMakeLists.txt:63 >Qt5::X11Extras > + Qt5Test >KF5::Activities i need to do Qt5::Test to make it build > placeholdermodel.cpp:246 > + > +

Re: Plasmoid's TextField on Panel?

On 03/02/2017 10:34 AM, Marco Martin wrote: >> On Thursday 02 March 2017 05:35:02 Zoltan Gyarmati wrote: >>> Dear All, >>> >>> I'm developing a simple plasmoid which has a few TextFields (imported >>> from org.kde.plasma.components 2.0) on it. When i add the plasmoid to >>> the desktop or run it

[Powerdevil] [Bug 377130] Power Saving Settings screen cut off when using resolution scaling. Does not scroll, either.

https://bugs.kde.org/show_bug.cgi?id=377130 Christoph Feck changed: What|Removed |Added Component|general |general

Re: Versioning caches in Plasma

> For binary packages of any sort the mtime would always be different, same for > stuff from the kde store since that'd rm the old tree first (I am guessing). Different but not necessarily newer. I still recall the trouble we had when we did major theme changes in Plasma 4.10. When you install

Re: Versioning caches in Plasma

On Fri, Mar 3, 2017 at 12:48 PM, Kai Uwe Broulik wrote: > Hi, > > Since when? :o I made a patch for this [1] which I didn't ship exactly for > that reason. > > We check mtime of theme files but they are preserved when installing updates > and so it can happen it doesn't

D3805: Per-activity favorites (WIP)

ivan added a comment. I would think that I might be exposing some other problem, but if the model behaved correctly, I'm guessing ModelTest from Qt Labs would not crash :) It is obvious that QML and QWidgets handle the events differently, but I think this would not happen if the model

Re: Versioning caches in Plasma

On Friday 03 March 2017 12:37:11 Aleix Pol wrote: > Would it be possible to just have a fast check and whenever the > version is different we flush the cache and populate it again? It's different to what? would have to contain a version number as metadata in a file that doesn't change name? --

Re: Versioning caches in Plasma

Hi, Since when? :o I made a patch for this [1] which I didn't ship exactly for that reason. We check mtime of theme files but they are preserved when installing updates and so it can happen it doesn't properly nuke it. Also, the Metadata.desktop has a version string but it's always forgotten

Versioning caches in Plasma

Hi, I just realized that we're versioning caches. I understand we need to do that to prevent to have get locked into a format version. Nevertheless, this creates a leak that's not easy to solve. For example I have several of these that won't get ever cleaned up: 17M

[kio-extras] [Bug 376344] cant write to smb shares which has write access

https://bugs.kde.org/show_bug.cgi?id=376344 Elvis Angelaccio changed: What|Removed |Added CC|

D4903: Drop building QPulseAudioPrivate library

This revision was automatically updated to reflect the committed changes. Closed by commit R115:eaa85666039c: Drop building QPulseAudioPrivate library (authored by drosca). REPOSITORY R115 Plasma Audio Volume Applet CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D4903?vs=12093=12115

D4915: [Folder View] Fix action button hover and pressed state

broulik created this revision. Restricted Application added a project: Plasma. Restricted Application added a subscriber: plasma-devel. REVISION SUMMARY The hover state didn't work because it referenced "pressed" which it didn't find in the scope. The pressed graphic suffix was wrong. TEST

D4903: Drop building QPulseAudioPrivate library

broulik added a comment. +1 In Task Manager I just blatantly import Plasma-pa's QML module, I don't use this library directly there. REPOSITORY R115 Plasma Audio Volume Applet BRANCH no-lib (branched from master) REVISION DETAIL https://phabricator.kde.org/D4903 To: drosca,

D4903: Drop building QPulseAudioPrivate library

mart accepted this revision. This revision is now accepted and ready to land. REPOSITORY R115 Plasma Audio Volume Applet BRANCH no-lib (branched from master) REVISION DETAIL https://phabricator.kde.org/D4903 To: drosca, #plasma, mart Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed,

D3805: Per-activity favorites (WIP)

mart added a comment. In https://phabricator.kde.org/D3805#92070, @ivan wrote: > And the dashboard and the QListView show different data. Namely, if you try to add a new item not via drag and drop, but right-click and assign to current activity, the dashboard starts showing a few empty

Re: [KDE4] what component does the screenlocking?

In data venerdì 3 marzo 2017 10:59:03 CET, René J.V. Bertin ha scritto: > @plasma-devel : Can anyone tell me if a screensaver exists for > Plasma5 that puts up a simple, CPU-cheap clock like kclock does or if not, Support for screensavers has been removed even in 4.x times when the new lock

Re: [KDE4] what component does the screenlocking?

To come back to the original topic: I have been tinkering with other display managers, and think now that the claim that kscreenlocker_greet uses the DM greeter for unlocking (on Plasma4) is unsubstantiated. When I switch to Ubuntu's LightDM I still get the same unlock dialog. I've built and